[INFO] cloning repository https://github.com/darragh-downey/rs-asset-mgmt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/darragh-downey/rs-asset-mgmt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdarragh-downey%2Frs-asset-mgmt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdarragh-downey%2Frs-asset-mgmt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 089319e83b79ebcae868668235acdf199789e5f1 [INFO] linting darragh-downey/rs-asset-mgmt/089319e83b79ebcae868668235acdf199789e5f1 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdarragh-downey%2Frs-asset-mgmt" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/darragh-downey/rs-asset-mgmt [INFO] finished tweaking git repo https://github.com/darragh-downey/rs-asset-mgmt [INFO] tweaked toml for git repo https://github.com/darragh-downey/rs-asset-mgmt written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/darragh-downey/rs-asset-mgmt on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/darragh-downey/rs-asset-mgmt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sha1 v0.10.1 [INFO] [stderr] Downloaded serde v1.0.141 [INFO] [stderr] Downloaded openssl-sys v0.9.75 [INFO] [stderr] Downloaded serde_derive v1.0.141 [INFO] [stderr] Downloaded crossterm v0.23.2 [INFO] [stderr] Downloaded time v0.3.12 [INFO] [stderr] Downloaded openssl v0.10.41 [INFO] [stderr] Downloaded libssh2-sys v0.2.23 [INFO] [stderr] Downloaded git2 v0.15.0 [INFO] [stderr] Downloaded reqwest v0.11.11 [INFO] [stderr] Downloaded tui v0.18.0 [INFO] [stderr] Downloaded libgit2-sys v0.14.0+1.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30c409fc14b793fac406a31ffd4d22c831ebf4e6e2373f182e1852c16e8a8238 [INFO] running `Command { std: "docker" "start" "-a" "30c409fc14b793fac406a31ffd4d22c831ebf4e6e2373f182e1852c16e8a8238", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30c409fc14b793fac406a31ffd4d22c831ebf4e6e2373f182e1852c16e8a8238", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30c409fc14b793fac406a31ffd4d22c831ebf4e6e2373f182e1852c16e8a8238", kill_on_drop: false }` [INFO] [stdout] 30c409fc14b793fac406a31ffd4d22c831ebf4e6e2373f182e1852c16e8a8238 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c52723ddc8ce584ef1a10c9400db2da8fb5ac2e3410efb876df2dac2041e450 [INFO] running `Command { std: "docker" "start" "-a" "8c52723ddc8ce584ef1a10c9400db2da8fb5ac2e3410efb876df2dac2041e450", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Compiling serde_derive v1.0.141 [INFO] [stderr] Compiling tokio v1.20.1 [INFO] [stderr] Compiling serde v1.0.141 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking parking_lot_core v0.9.3 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking generic-array v0.14.6 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling signal-hook v0.3.14 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling libgit2-sys v0.14.0+1.5.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking time v0.3.12 [INFO] [stderr] Checking password-hash v0.3.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.1 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking pbkdf2 v0.10.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking zip v0.6.2 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking git2 v0.15.0 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking crossterm v0.23.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking serde_json v1.0.82 [INFO] [stderr] Checking hyper v0.14.20 [INFO] [stderr] Checking tui v0.18.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.11 [INFO] [stderr] Checking rs-cli-asset-mgmt v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/zip.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/zip.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use tempfile; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/zip.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use zip; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/zip.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use reqwest; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/zip.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use tempfile; [INFO] [stdout] | ^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/zip.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use zip; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VULN_DB_PATH` is never used [INFO] [stdout] --> src/db.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub const VULN_DB_PATH: &str = "./data/vuln_db.json"; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:17:47 [INFO] [stdout] | [INFO] [stdout] 17 | let mut tmp = tempfile::tempfile().or(Err(format!("failed to create tempfile")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to create tempfile".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | .or(Err(format!("failed to download zip file")))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to download zip file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | .or(Err(format!("issue grabbing chunk")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"issue grabbing chunk".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | .or(Err(format!("issue writing to tmp file")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"issue writing to tmp file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | .or(Err(format!("failed to open zip archive")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to open zip archive".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | .or(Err(format!("failed to get file by its index in zip archive")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to get file by its index in zip archive".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/zip.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 84 | let mut stream = file.bytes(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/zip.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | while let Some(next) = stream.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | .or(Err(format!("issue grabbing chunk")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"issue grabbing chunk".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 95 | .or(Err(format!("failed to write the data from zip archive to local file")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to write the data from zip archive to local file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | .or(Err(format!("failed to flush buffer to file")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to flush buffer to file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:75:24 [INFO] [stdout] | [INFO] [stdout] 75 | if let Ok(_) = tx.send(Event::Tick) { [INFO] [stdout] | -------^^^^^----------------------- help: try: `if tx.send(Event::Tick).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 85 | terminal.clear().or(Err(format!("failed to clear terminal")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to clear terminal".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/main.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | let menu_titles = vec!["Home", "Assets", "Add", "Delete", "Quit", "Fetch"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["Home", "Assets", "Add", "Delete", "Quit", "Fetch"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VULN_DB_PATH` is never used [INFO] [stdout] --> src/db.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub const VULN_DB_PATH: &str = "./data/vuln_db.json"; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:17:47 [INFO] [stdout] | [INFO] [stdout] 17 | let mut tmp = tempfile::tempfile().or(Err(format!("failed to create tempfile")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to create tempfile".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | .or(Err(format!("failed to download zip file")))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to download zip file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | .or(Err(format!("issue grabbing chunk")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"issue grabbing chunk".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | .or(Err(format!("issue writing to tmp file")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"issue writing to tmp file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | .or(Err(format!("failed to open zip archive")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to open zip archive".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | .or(Err(format!("failed to get file by its index in zip archive")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to get file by its index in zip archive".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/zip.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 84 | let mut stream = file.bytes(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/zip.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | while let Some(next) = stream.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | .or(Err(format!("issue grabbing chunk")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"issue grabbing chunk".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 95 | .or(Err(format!("failed to write the data from zip archive to local file")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to write the data from zip archive to local file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/zip.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | .or(Err(format!("failed to flush buffer to file")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to flush buffer to file".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:75:24 [INFO] [stdout] | [INFO] [stdout] 75 | if let Ok(_) = tx.send(Event::Tick) { [INFO] [stdout] | -------^^^^^----------------------- help: try: `if tx.send(Event::Tick).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 85 | terminal.clear().or(Err(format!("failed to clear terminal")))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"failed to clear terminal".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/main.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 87 | let menu_titles = vec!["Home", "Assets", "Add", "Delete", "Quit", "Fetch"]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["Home", "Assets", "Add", "Delete", "Quit", "Fetch"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.16s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "8c52723ddc8ce584ef1a10c9400db2da8fb5ac2e3410efb876df2dac2041e450", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c52723ddc8ce584ef1a10c9400db2da8fb5ac2e3410efb876df2dac2041e450", kill_on_drop: false }` [INFO] [stdout] 8c52723ddc8ce584ef1a10c9400db2da8fb5ac2e3410efb876df2dac2041e450