[INFO] cloning repository https://github.com/daminals/rust-gdrive-upload-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/daminals/rust-gdrive-upload-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaminals%2Frust-gdrive-upload-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaminals%2Frust-gdrive-upload-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dd5ecf128f108ad7ba1066bd5c34b784c10fa5e4 [INFO] linting daminals/rust-gdrive-upload-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaminals%2Frust-gdrive-upload-cli" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/daminals/rust-gdrive-upload-cli [INFO] finished tweaking git repo https://github.com/daminals/rust-gdrive-upload-cli [INFO] tweaked toml for git repo https://github.com/daminals/rust-gdrive-upload-cli written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/daminals/rust-gdrive-upload-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/daminals/rust-gdrive-upload-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ctrlc v3.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4c686693edf3e4553e034b955c8b3e105c082c9e98138f8eef1f4c643b250c2 [INFO] running `Command { std: "docker" "start" "-a" "d4c686693edf3e4553e034b955c8b3e105c082c9e98138f8eef1f4c643b250c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4c686693edf3e4553e034b955c8b3e105c082c9e98138f8eef1f4c643b250c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4c686693edf3e4553e034b955c8b3e105c082c9e98138f8eef1f4c643b250c2", kill_on_drop: false }` [INFO] [stdout] d4c686693edf3e4553e034b955c8b3e105c082c9e98138f8eef1f4c643b250c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 25742b1cf0165fb8f9aaafc35766f013b5c66c2a37679db213b04c0dfecdf660 [INFO] running `Command { std: "docker" "start" "-a" "25742b1cf0165fb8f9aaafc35766f013b5c66c2a37679db213b04c0dfecdf660", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking clap v3.1.2 [INFO] [stderr] Checking ctrlc v3.2.1 [INFO] [stderr] Checking upload v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/append.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | let this_file = format!("{}", &this_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&this_dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return self.gtype == "dir"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return self.gtype == "dir"; [INFO] [stdout] 27 + self.gtype == "dir" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return result_struct; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return result_struct; [INFO] [stdout] 33 + result_struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return result_struct; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return result_struct; [INFO] [stdout] 36 + result_struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | ... return GdriveQuery{ id: result_vector[0].to_string(), name: result_vector[1].to_string(), gtype: result_vector[2].to_string(), dob: result_vector[3].to_string(), age: result_vector[4].to_string(), update: true }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return GdriveQuery{ id: result_vector[0].to_string(), name: result_vector[1].to_string(), gtype: result_vector[2].to_string(), dob: result_vector[3].to_string(), age: result_vector[4].to_string(), update: true }; [INFO] [stdout] 42 + GdriveQuery{ id: result_vector[0].to_string(), name: result_vector[1].to_string(), gtype: result_vector[2].to_string(), dob: result_vector[3].to_string(), age: result_vector[4].to_string(), update: true } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/unwrap.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn unwrap(result: &String) -> GdriveQuery { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 40 - pub fn unwrap(result: &String) -> GdriveQuery { [INFO] [stdout] 40 + pub fn unwrap(result: &str) -> GdriveQuery { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return GdriveQuery::is_none(&query_result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return GdriveQuery::is_none(&query_result); [INFO] [stdout] 55 + GdriveQuery::is_none(&query_result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return FileId{id: "".to_owned()}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return FileId{id: "".to_owned()}; [INFO] [stdout] 69 + FileId{id: "".to_owned()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | return FileId { id: convert_string_ref(&self.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return FileId { id: convert_string_ref(&self.id) }; [INFO] [stdout] 72 + FileId { id: convert_string_ref(&self.id) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | return FileId { id: file_query.id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return FileId { id: file_query.id }; [INFO] [stdout] 85 + FileId { id: file_query.id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | return FileId { id: String::from("") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return FileId { id: String::from("") }; [INFO] [stdout] 87 + FileId { id: String::from("") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | return FileId { id: String::from("") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return FileId { id: String::from("") }; [INFO] [stdout] 90 + FileId { id: String::from("") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return file_id.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return file_id.unwrap().to_str(); [INFO] [stdout] 100 + file_id.unwrap().to_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return convert_string_ref(&self.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return convert_string_ref(&self.id); [INFO] [stdout] 104 + convert_string_ref(&self.id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | return String::from(borrowed_string); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return String::from(borrowed_string); [INFO] [stdout] 111 + String::from(borrowed_string) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unwrap.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 117 | if !keyword.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `keyword.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `keyword` after checking its variant with `is_none` [INFO] [stdout] --> src/unwrap.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 117 | if !keyword.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 118 | return keyword.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return keyword.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return keyword.unwrap(); [INFO] [stdout] 118 + keyword.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | return ""; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return ""; [INFO] [stdout] 123 + "" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | return dir_id; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return dir_id; [INFO] [stdout] 136 + dir_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return contents; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return contents; [INFO] [stdout] 147 + contents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/unwrap.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | let contents; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `contents` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 141 ~ [INFO] [stdout] 142 ~ let contents = if Path::new(".driveignore").exists() { [INFO] [stdout] 143 ~ fs::read_to_string(".driveignore").expect("Something went wrong reading the file") [INFO] [stdout] 144 | } else { [INFO] [stdout] 145 ~ String::from("") [INFO] [stdout] 146 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | return String::from(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return String::from(""); [INFO] [stdout] 162 + String::from("") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/unwrap.rs:151:63 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn unwrap_gdrive_query(cmd_output: String, search_string: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 151 - pub fn unwrap_gdrive_query(cmd_output: String, search_string: &String) -> String { [INFO] [stdout] 151 + pub fn unwrap_gdrive_query(cmd_output: String, search_string: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return format!("gdrive update {} {}", file_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return format!("gdrive update {} {}", file_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] 169 + format!("gdrive update {} {}", file_id, path.as_ref().unwrap().path().display()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return format!("gdrive upload --parent {} {}", parent_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return format!("gdrive upload --parent {} {}", parent_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] 171 + format!("gdrive upload --parent {} {}", parent_id, path.as_ref().unwrap().path().display()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/unwrap.rs:167:43 [INFO] [stdout] | [INFO] [stdout] 167 | if !file_id.is_empty() && !is_trashed(&file_id, false) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | return !trash_query.is_empty(); // if the query returned none, it is not in trash [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return !trash_query.is_empty(); // if the query returned none, it is not in trash [INFO] [stdout] 199 + !trash_query.is_empty()// if the query returned none, it is not in trash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/unwrap.rs:179:42 [INFO] [stdout] | [INFO] [stdout] 179 | let trash_query = gdrive_trash_query(&search_string); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `search_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/unwrap.rs:189:51 [INFO] [stdout] | [INFO] [stdout] 189 | if (return_user_input().to_uppercase() == String::from("Y")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"Y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/unwrap.rs:196:24 [INFO] [stdout] | [INFO] [stdout] 196 | is_trashed(&search_string, true); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `search_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | return !is_trashed(search_string, prompt); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return !is_trashed(search_string, prompt); [INFO] [stdout] 203 + !is_trashed(search_string, prompt) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | return trash_query; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return trash_query; [INFO] [stdout] 215 + trash_query [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/unwrap.rs:211:57 [INFO] [stdout] | [INFO] [stdout] 211 | let trash_stdout = Command::new("sh").arg("-c").arg(&query_trash_cmd) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `query_trash_cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 226 | return user_input.trim().to_string() // disregard the newline character from end [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 - return user_input.trim().to_string() // disregard the newline character from end [INFO] [stdout] 226 + user_input.trim().to_string() // disregard the newline character from end [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/share.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !(shared == "") { // if share is not empty... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(shared != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/share.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | let share_to = unwrap_share(&shared); [INFO] [stdout] | ^^^^^^^ help: change this to: `shared` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/share.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | if !(shared == "") { // if share is not empty... [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `shared.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/share.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return shared.split(",").collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return shared.split(",").collect::>(); [INFO] [stdout] 25 + shared.split(",").collect::>() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return csehashmap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return csehashmap; [INFO] [stdout] 39 + csehashmap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | if !(matches.subcommand_matches("u").is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.subcommand_matches("u").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:124:15 [INFO] [stdout] | [INFO] [stdout] 124 | } else if !(matches.subcommand_matches("add").is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.subcommand_matches("add").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | let get_basedir_cmd = format!("echo $(basename \"$PWD\")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"echo $(basename \"$PWD\")".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:123:22 [INFO] [stdout] | [INFO] [stdout] 123 | command_line(&course, &dir, &share, true, get_basedir_str); [INFO] [stdout] | ^^^^^^^ help: change this to: `course` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:123:31 [INFO] [stdout] | [INFO] [stdout] 123 | command_line(&course, &dir, &share, true, get_basedir_str); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:123:37 [INFO] [stdout] | [INFO] [stdout] 123 | command_line(&course, &dir, &share, true, get_basedir_str); [INFO] [stdout] | ^^^^^^ help: change this to: `share` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/main.rs:147:35 [INFO] [stdout] | [INFO] [stdout] 147 | unwrap::is_trashed(&base_dir, *&base_case); // check if trashed before setting struct to [INFO] [stdout] | ^^^^^^^^^^^ help: try: `base_case` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | print!("{}Updating Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 151 - print!("{}Updating Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] 151 + println!("{}Updating Google Folder: {} ⏳{}", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | print!("{}Uploading Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 153 - print!("{}Uploading Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] 153 + println!("{}Uploading Google Folder: {} ⏳{}", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:158:18 [INFO] [stdout] | [INFO] [stdout] 158 | share::share(&share, &base_dir_id); [INFO] [stdout] | ^^^^^^ help: change this to: `share` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:198:66 [INFO] [stdout] | [INFO] [stdout] 198 | command_line(&base_dir_id, full_path, "", false, String::from(format!("{}\n",short_path))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}\n",short_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/append.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | let this_file = format!("{}", &this_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&this_dir).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | return cse_folder_id.unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return cse_folder_id.unwrap().to_string(); [INFO] [stdout] 238 + cse_folder_id.unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | return cse_folder_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return cse_folder_id; [INFO] [stdout] 241 + cse_folder_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | return gstruct.id.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return gstruct.id.to_owned(); [INFO] [stdout] 250 + gstruct.id.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | return unwrap::unwrap_new_dir(dir_name_full); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return unwrap::unwrap_new_dir(dir_name_full); [INFO] [stdout] 255 + unwrap::unwrap_new_dir(dir_name_full) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return self.gtype == "dir"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return self.gtype == "dir"; [INFO] [stdout] 27 + self.gtype == "dir" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:249:50 [INFO] [stdout] | [INFO] [stdout] 249 | if gstruct.update && unwrap::is_not_trashed(&cse_folder_id, false){ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `cse_folder_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return result_struct; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return result_struct; [INFO] [stdout] 33 + result_struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | return result_struct; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return result_struct; [INFO] [stdout] 36 + result_struct [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | ... return GdriveQuery{ id: result_vector[0].to_string(), name: result_vector[1].to_string(), gtype: result_vector[2].to_string(), dob: result_vector[3].to_string(), age: result_vector[4].to_string(), update: true }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return GdriveQuery{ id: result_vector[0].to_string(), name: result_vector[1].to_string(), gtype: result_vector[2].to_string(), dob: result_vector[3].to_string(), age: result_vector[4].to_string(), update: true }; [INFO] [stdout] 42 + GdriveQuery{ id: result_vector[0].to_string(), name: result_vector[1].to_string(), gtype: result_vector[2].to_string(), dob: result_vector[3].to_string(), age: result_vector[4].to_string(), update: true } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/unwrap.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn unwrap(result: &String) -> GdriveQuery { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 40 - pub fn unwrap(result: &String) -> GdriveQuery { [INFO] [stdout] 40 + pub fn unwrap(result: &str) -> GdriveQuery { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return GdriveQuery::is_none(&query_result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return GdriveQuery::is_none(&query_result); [INFO] [stdout] 55 + GdriveQuery::is_none(&query_result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | return FileId{id: "".to_owned()}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return FileId{id: "".to_owned()}; [INFO] [stdout] 69 + FileId{id: "".to_owned()} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | return FileId { id: convert_string_ref(&self.id) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return FileId { id: convert_string_ref(&self.id) }; [INFO] [stdout] 72 + FileId { id: convert_string_ref(&self.id) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | return FileId { id: file_query.id }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return FileId { id: file_query.id }; [INFO] [stdout] 85 + FileId { id: file_query.id } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | return FileId { id: String::from("") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return FileId { id: String::from("") }; [INFO] [stdout] 87 + FileId { id: String::from("") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | return FileId { id: String::from("") }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return FileId { id: String::from("") }; [INFO] [stdout] 90 + FileId { id: String::from("") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | return file_id.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return file_id.unwrap().to_str(); [INFO] [stdout] 100 + file_id.unwrap().to_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return convert_string_ref(&self.id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return convert_string_ref(&self.id); [INFO] [stdout] 104 + convert_string_ref(&self.id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | return String::from(borrowed_string); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return String::from(borrowed_string); [INFO] [stdout] 111 + String::from(borrowed_string) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unwrap.rs:117:8 [INFO] [stdout] | [INFO] [stdout] 117 | if !keyword.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `keyword.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `keyword` after checking its variant with `is_none` [INFO] [stdout] --> src/unwrap.rs:118:16 [INFO] [stdout] | [INFO] [stdout] 117 | if !keyword.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 118 | return keyword.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return keyword.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return keyword.unwrap(); [INFO] [stdout] 118 + keyword.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | return ""; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return ""; [INFO] [stdout] 123 + "" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | return dir_id; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return dir_id; [INFO] [stdout] 136 + dir_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return contents; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return contents; [INFO] [stdout] 147 + contents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/unwrap.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | let contents; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `contents` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 141 ~ [INFO] [stdout] 142 ~ let contents = if Path::new(".driveignore").exists() { [INFO] [stdout] 143 ~ fs::read_to_string(".driveignore").expect("Something went wrong reading the file") [INFO] [stdout] 144 | } else { [INFO] [stdout] 145 ~ String::from("") [INFO] [stdout] 146 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | return String::from(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return String::from(""); [INFO] [stdout] 162 + String::from("") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/unwrap.rs:151:63 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn unwrap_gdrive_query(cmd_output: String, search_string: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 151 - pub fn unwrap_gdrive_query(cmd_output: String, search_string: &String) -> String { [INFO] [stdout] 151 + pub fn unwrap_gdrive_query(cmd_output: String, search_string: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return format!("gdrive update {} {}", file_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return format!("gdrive update {} {}", file_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] 169 + format!("gdrive update {} {}", file_id, path.as_ref().unwrap().path().display()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return format!("gdrive upload --parent {} {}", parent_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return format!("gdrive upload --parent {} {}", parent_id, path.as_ref().unwrap().path().display()); [INFO] [stdout] 171 + format!("gdrive upload --parent {} {}", parent_id, path.as_ref().unwrap().path().display()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/unwrap.rs:167:43 [INFO] [stdout] | [INFO] [stdout] 167 | if !file_id.is_empty() && !is_trashed(&file_id, false) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `file_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | return !trash_query.is_empty(); // if the query returned none, it is not in trash [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return !trash_query.is_empty(); // if the query returned none, it is not in trash [INFO] [stdout] 199 + !trash_query.is_empty()// if the query returned none, it is not in trash [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/unwrap.rs:179:42 [INFO] [stdout] | [INFO] [stdout] 179 | let trash_query = gdrive_trash_query(&search_string); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `search_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/unwrap.rs:189:51 [INFO] [stdout] | [INFO] [stdout] 189 | if (return_user_input().to_uppercase() == String::from("Y")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"Y"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/unwrap.rs:196:24 [INFO] [stdout] | [INFO] [stdout] 196 | is_trashed(&search_string, true); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `search_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | return !is_trashed(search_string, prompt); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return !is_trashed(search_string, prompt); [INFO] [stdout] 203 + !is_trashed(search_string, prompt) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | return trash_query; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return trash_query; [INFO] [stdout] 215 + trash_query [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/unwrap.rs:211:57 [INFO] [stdout] | [INFO] [stdout] 211 | let trash_stdout = Command::new("sh").arg("-c").arg(&query_trash_cmd) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `query_trash_cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unwrap.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 226 | return user_input.trim().to_string() // disregard the newline character from end [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 226 - return user_input.trim().to_string() // disregard the newline character from end [INFO] [stdout] 226 + user_input.trim().to_string() // disregard the newline character from end [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/share.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !(shared == "") { // if share is not empty... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(shared != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/share.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | let share_to = unwrap_share(&shared); [INFO] [stdout] | ^^^^^^^ help: change this to: `shared` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/share.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | if !(shared == "") { // if share is not empty... [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `shared.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/share.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return shared.split(",").collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return shared.split(",").collect::>(); [INFO] [stdout] 25 + shared.split(",").collect::>() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return csehashmap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return csehashmap; [INFO] [stdout] 39 + csehashmap [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | if !(matches.subcommand_matches("u").is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.subcommand_matches("u").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:124:15 [INFO] [stdout] | [INFO] [stdout] 124 | } else if !(matches.subcommand_matches("add").is_none()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.subcommand_matches("add").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | let get_basedir_cmd = format!("echo $(basename \"$PWD\")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"echo $(basename \"$PWD\")".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:123:22 [INFO] [stdout] | [INFO] [stdout] 123 | command_line(&course, &dir, &share, true, get_basedir_str); [INFO] [stdout] | ^^^^^^^ help: change this to: `course` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:123:31 [INFO] [stdout] | [INFO] [stdout] 123 | command_line(&course, &dir, &share, true, get_basedir_str); [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:123:37 [INFO] [stdout] | [INFO] [stdout] 123 | command_line(&course, &dir, &share, true, get_basedir_str); [INFO] [stdout] | ^^^^^^ help: change this to: `share` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/main.rs:147:35 [INFO] [stdout] | [INFO] [stdout] 147 | unwrap::is_trashed(&base_dir, *&base_case); // check if trashed before setting struct to [INFO] [stdout] | ^^^^^^^^^^^ help: try: `base_case` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | print!("{}Updating Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 151 - print!("{}Updating Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] 151 + println!("{}Updating Google Folder: {} ⏳{}", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | print!("{}Uploading Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 153 - print!("{}Uploading Google Folder: {} ⏳{}\n", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] 153 + println!("{}Uploading Google Folder: {} ⏳{}", YELLOW, &base_dir.trim(), CLEAR_FORMAT); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:158:18 [INFO] [stdout] | [INFO] [stdout] 158 | share::share(&share, &base_dir_id); [INFO] [stdout] | ^^^^^^ help: change this to: `share` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:198:66 [INFO] [stdout] | [INFO] [stdout] 198 | command_line(&base_dir_id, full_path, "", false, String::from(format!("{}\n",short_path))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}\n",short_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | return cse_folder_id.unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return cse_folder_id.unwrap().to_string(); [INFO] [stdout] 238 + cse_folder_id.unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | return cse_folder_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return cse_folder_id; [INFO] [stdout] 241 + cse_folder_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | return gstruct.id.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 250 - return gstruct.id.to_owned(); [INFO] [stdout] 250 + gstruct.id.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | return unwrap::unwrap_new_dir(dir_name_full); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return unwrap::unwrap_new_dir(dir_name_full); [INFO] [stdout] 255 + unwrap::unwrap_new_dir(dir_name_full) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:249:50 [INFO] [stdout] | [INFO] [stdout] 249 | if gstruct.update && unwrap::is_not_trashed(&cse_folder_id, false){ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `cse_folder_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.23s [INFO] running `Command { std: "docker" "inspect" "25742b1cf0165fb8f9aaafc35766f013b5c66c2a37679db213b04c0dfecdf660", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25742b1cf0165fb8f9aaafc35766f013b5c66c2a37679db213b04c0dfecdf660", kill_on_drop: false }` [INFO] [stdout] 25742b1cf0165fb8f9aaafc35766f013b5c66c2a37679db213b04c0dfecdf660