[INFO] cloning repository https://github.com/damiencarol/polilith [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/damiencarol/polilith" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdamiencarol%2Fpolilith", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdamiencarol%2Fpolilith'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9d93b7dc4776fbcb9c85745ee81614a9cfd5ccb6 [INFO] linting damiencarol/polilith against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdamiencarol%2Fpolilith" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/damiencarol/polilith [INFO] finished tweaking git repo https://github.com/damiencarol/polilith [INFO] tweaked toml for git repo https://github.com/damiencarol/polilith written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/damiencarol/polilith on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/damiencarol/polilith already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tar v0.4.44 [INFO] [stderr] Downloaded clap_derive v4.5.40 [INFO] [stderr] Downloaded clap v4.5.40 [INFO] [stderr] Downloaded clap_builder v4.5.40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9a4c4b70b8b5af16333d24f1c2b1a5de40e55edab4ba54772e42a0f23afed487 [INFO] running `Command { std: "docker" "start" "-a" "9a4c4b70b8b5af16333d24f1c2b1a5de40e55edab4ba54772e42a0f23afed487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9a4c4b70b8b5af16333d24f1c2b1a5de40e55edab4ba54772e42a0f23afed487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a4c4b70b8b5af16333d24f1c2b1a5de40e55edab4ba54772e42a0f23afed487", kill_on_drop: false }` [INFO] [stdout] 9a4c4b70b8b5af16333d24f1c2b1a5de40e55edab4ba54772e42a0f23afed487 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b9d08ca2979b78e28a956f8993a6c4ce6e6341a845ae7c9adc4cf3f089d1172 [INFO] running `Command { std: "docker" "start" "-a" "6b9d08ca2979b78e28a956f8993a6c4ce6e6341a845ae7c9adc4cf3f089d1172", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking xattr v1.5.1 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking polilith v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/algo.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | tool: tool, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `tool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/algo.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | tool: tool, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `tool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/algo.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | res.extend(rule1.get_result(&artifact_location)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `artifact_location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/algo.rs:76:32 [INFO] [stdout] | [INFO] [stdout] 76 | res.extend(rule.get_result(&artifact_location)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `artifact_location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/algo.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | uri: (&input).display().to_string(), [INFO] [stdout] | ^^^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if !self.user_detected.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.user_detected.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / return vec![Result { [INFO] [stdout] 51 | | rule_id: "PL007".to_string(), [INFO] [stdout] 52 | | kind: "fail".to_string(), [INFO] [stdout] 53 | | level: "error".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 64 | | }], [INFO] [stdout] 65 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ vec![Result { [INFO] [stdout] 51 + rule_id: "PL007".to_string(), [INFO] [stdout] 52 + kind: "fail".to_string(), [INFO] [stdout] 53 + level: "error".to_string(), [INFO] [stdout] 54 + message: ResultMessage { [INFO] [stdout] 55 + text: "Process in image run as root".to_string(), [INFO] [stdout] 56 + arguments: None, [INFO] [stdout] 57 + }, [INFO] [stdout] 58 + locations: vec![ResultLocation { [INFO] [stdout] 59 + physical_location: PhysicalLocation { [INFO] [stdout] 60 + artifact_location: ArtifactLocation { [INFO] [stdout] 61 + uri: location.uri.clone(), [INFO] [stdout] 62 + }, [INFO] [stdout] 63 + }, [INFO] [stdout] 64 + }], [INFO] [stdout] 65 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | / return vec![Result { [INFO] [stdout] 68 | | rule_id: "PL007".to_string(), [INFO] [stdout] 69 | | kind: "pass".to_string(), [INFO] [stdout] 70 | | level: "none".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 81 | | }], [INFO] [stdout] 82 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ vec![Result { [INFO] [stdout] 68 + rule_id: "PL007".to_string(), [INFO] [stdout] 69 + kind: "pass".to_string(), [INFO] [stdout] 70 + level: "none".to_string(), [INFO] [stdout] 71 + message: ResultMessage { [INFO] [stdout] 72 + text: "Process doesn't run as root".to_string(), [INFO] [stdout] 73 + arguments: None, [INFO] [stdout] 74 + }, [INFO] [stdout] 75 + locations: vec![ResultLocation { [INFO] [stdout] 76 + physical_location: PhysicalLocation { [INFO] [stdout] 77 + artifact_location: ArtifactLocation { [INFO] [stdout] 78 + uri: location.uri.clone(), [INFO] [stdout] 79 + }, [INFO] [stdout] 80 + }, [INFO] [stdout] 81 + }], [INFO] [stdout] 82 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return res; [INFO] [stdout] 154 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | / return vec![Result { [INFO] [stdout] 157 | | rule_id: "PL001".to_string(), [INFO] [stdout] 158 | | kind: "pass".to_string(), [INFO] [stdout] 159 | | level: "none".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 170 | | }], [INFO] [stdout] 171 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 ~ vec![Result { [INFO] [stdout] 157 + rule_id: "PL001".to_string(), [INFO] [stdout] 158 + kind: "pass".to_string(), [INFO] [stdout] 159 + level: "none".to_string(), [INFO] [stdout] 160 + message: ResultMessage { [INFO] [stdout] 161 + text: "No suspicious environment variables found".to_string(), [INFO] [stdout] 162 + arguments: None, [INFO] [stdout] 163 + }, [INFO] [stdout] 164 + locations: vec![ResultLocation { [INFO] [stdout] 165 + physical_location: PhysicalLocation { [INFO] [stdout] 166 + artifact_location: ArtifactLocation { [INFO] [stdout] 167 + uri: location.uri.clone(), [INFO] [stdout] 168 + }, [INFO] [stdout] 169 + }, [INFO] [stdout] 170 + }], [INFO] [stdout] 171 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rules.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 134 | if self.suspicious_envs.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.suspicious_envs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | if None != message.arguments { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `message.arguments.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/algo.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | res.extend(rule1.get_result(&artifact_location)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `artifact_location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/algo.rs:76:32 [INFO] [stdout] | [INFO] [stdout] 76 | res.extend(rule.get_result(&artifact_location)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `artifact_location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/algo.rs:106:18 [INFO] [stdout] | [INFO] [stdout] 106 | uri: (&input).display().to_string(), [INFO] [stdout] | ^^^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rules.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if !self.user_detected.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.user_detected.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / return vec![Result { [INFO] [stdout] 51 | | rule_id: "PL007".to_string(), [INFO] [stdout] 52 | | kind: "fail".to_string(), [INFO] [stdout] 53 | | level: "error".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 64 | | }], [INFO] [stdout] 65 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ vec![Result { [INFO] [stdout] 51 + rule_id: "PL007".to_string(), [INFO] [stdout] 52 + kind: "fail".to_string(), [INFO] [stdout] 53 + level: "error".to_string(), [INFO] [stdout] 54 + message: ResultMessage { [INFO] [stdout] 55 + text: "Process in image run as root".to_string(), [INFO] [stdout] 56 + arguments: None, [INFO] [stdout] 57 + }, [INFO] [stdout] 58 + locations: vec![ResultLocation { [INFO] [stdout] 59 + physical_location: PhysicalLocation { [INFO] [stdout] 60 + artifact_location: ArtifactLocation { [INFO] [stdout] 61 + uri: location.uri.clone(), [INFO] [stdout] 62 + }, [INFO] [stdout] 63 + }, [INFO] [stdout] 64 + }], [INFO] [stdout] 65 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | / return vec![Result { [INFO] [stdout] 68 | | rule_id: "PL007".to_string(), [INFO] [stdout] 69 | | kind: "pass".to_string(), [INFO] [stdout] 70 | | level: "none".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 81 | | }], [INFO] [stdout] 82 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ vec![Result { [INFO] [stdout] 68 + rule_id: "PL007".to_string(), [INFO] [stdout] 69 + kind: "pass".to_string(), [INFO] [stdout] 70 + level: "none".to_string(), [INFO] [stdout] 71 + message: ResultMessage { [INFO] [stdout] 72 + text: "Process doesn't run as root".to_string(), [INFO] [stdout] 73 + arguments: None, [INFO] [stdout] 74 + }, [INFO] [stdout] 75 + locations: vec![ResultLocation { [INFO] [stdout] 76 + physical_location: PhysicalLocation { [INFO] [stdout] 77 + artifact_location: ArtifactLocation { [INFO] [stdout] 78 + uri: location.uri.clone(), [INFO] [stdout] 79 + }, [INFO] [stdout] 80 + }, [INFO] [stdout] 81 + }], [INFO] [stdout] 82 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return res; [INFO] [stdout] 154 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rules.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | / return vec![Result { [INFO] [stdout] 157 | | rule_id: "PL001".to_string(), [INFO] [stdout] 158 | | kind: "pass".to_string(), [INFO] [stdout] 159 | | level: "none".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 170 | | }], [INFO] [stdout] 171 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 ~ vec![Result { [INFO] [stdout] 157 + rule_id: "PL001".to_string(), [INFO] [stdout] 158 + kind: "pass".to_string(), [INFO] [stdout] 159 + level: "none".to_string(), [INFO] [stdout] 160 + message: ResultMessage { [INFO] [stdout] 161 + text: "No suspicious environment variables found".to_string(), [INFO] [stdout] 162 + arguments: None, [INFO] [stdout] 163 + }, [INFO] [stdout] 164 + locations: vec![ResultLocation { [INFO] [stdout] 165 + physical_location: PhysicalLocation { [INFO] [stdout] 166 + artifact_location: ArtifactLocation { [INFO] [stdout] 167 + uri: location.uri.clone(), [INFO] [stdout] 168 + }, [INFO] [stdout] 169 + }, [INFO] [stdout] 170 + }], [INFO] [stdout] 171 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/rules.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 134 | if self.suspicious_envs.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.suspicious_envs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | if None != message.arguments { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `message.arguments.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.41s [INFO] running `Command { std: "docker" "inspect" "6b9d08ca2979b78e28a956f8993a6c4ce6e6341a845ae7c9adc4cf3f089d1172", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b9d08ca2979b78e28a956f8993a6c4ce6e6341a845ae7c9adc4cf3f089d1172", kill_on_drop: false }` [INFO] [stdout] 6b9d08ca2979b78e28a956f8993a6c4ce6e6341a845ae7c9adc4cf3f089d1172