[INFO] cloning repository https://github.com/dalund/wave_propagation_path_finding [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dalund/wave_propagation_path_finding" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalund%2Fwave_propagation_path_finding", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalund%2Fwave_propagation_path_finding'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9b5bf055072773c1440bb61e6baea59c1dd2acaa [INFO] linting dalund/wave_propagation_path_finding against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalund%2Fwave_propagation_path_finding" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dalund/wave_propagation_path_finding [INFO] finished tweaking git repo https://github.com/dalund/wave_propagation_path_finding [INFO] tweaked toml for git repo https://github.com/dalund/wave_propagation_path_finding written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dalund/wave_propagation_path_finding on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dalund/wave_propagation_path_finding already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded skeptic v0.13.4 [INFO] [stderr] Downloaded cargo_metadata v0.6.4 [INFO] [stderr] Downloaded rustc-hash v1.0.1 [INFO] [stderr] Downloaded zip v0.5.3 [INFO] [stderr] Downloaded bytecount v0.4.0 [INFO] [stderr] Downloaded gfx_gl v0.6.0 [INFO] [stderr] Downloaded gfx_window_glutin v0.30.0 [INFO] [stderr] Downloaded sid v0.5.2 [INFO] [stderr] Downloaded glyph_brush_layout v0.1.8 [INFO] [stderr] Downloaded num-iter v0.1.39 [INFO] [stderr] Downloaded twox-hash v1.5.0 [INFO] [stderr] Downloaded directories v2.0.2 [INFO] [stderr] Downloaded euclid_macros v0.1.0 [INFO] [stderr] Downloaded lyon_path v0.13.2 [INFO] [stderr] Downloaded coreaudio-sys v0.2.3 [INFO] [stderr] Downloaded cpal v0.8.2 [INFO] [stderr] Downloaded jpeg-decoder v0.1.16 [INFO] [stderr] Downloaded gif v0.10.3 [INFO] [stderr] Downloaded glutin v0.20.1 [INFO] [stderr] Downloaded xi-unicode v0.2.0 [INFO] [stderr] Downloaded claxon v0.4.2 [INFO] [stderr] Downloaded pulldown-cmark v0.2.0 [INFO] [stderr] Downloaded gilrs v0.7.2 [INFO] [stderr] Downloaded nix v0.11.1 [INFO] [stderr] Downloaded syn v1.0.8 [INFO] [stderr] Downloaded smart-default v0.5.2 [INFO] [stderr] Downloaded nalgebra v0.18.1 [INFO] [stderr] Downloaded image v0.22.3 [INFO] [stderr] Downloaded glyph_brush v0.5.4 [INFO] [stderr] Downloaded lyon_geom v0.12.7 [INFO] [stderr] Downloaded matrixmultiply v0.2.3 [INFO] [stderr] Downloaded glyph_brush v0.6.1 [INFO] [stderr] Downloaded png v0.15.1 [INFO] [stderr] Downloaded minimp3-sys v0.3.1 [INFO] [stderr] Downloaded lyon_algorithms v0.13.4 [INFO] [stderr] Downloaded bzip2-sys v0.1.7 [INFO] [stderr] Downloaded euclid v0.19.9 [INFO] [stderr] Downloaded slice-deque v0.2.4 [INFO] [stderr] Downloaded alga v0.9.2 [INFO] [stderr] Downloaded num-rational v0.2.2 [INFO] [stderr] Downloaded tiff v0.3.1 [INFO] [stderr] Downloaded lyon v0.13.5 [INFO] [stderr] Downloaded ggez v0.5.1 [INFO] [stderr] Downloaded ogg v0.7.0 [INFO] [stderr] Downloaded num-complex v0.2.3 [INFO] [stderr] Downloaded minimp3 v0.3.3 [INFO] [stderr] Downloaded mint v0.5.4 [INFO] [stderr] Downloaded raw-window-handle v0.3.1 [INFO] [stderr] Downloaded rodio v0.9.0 [INFO] [stderr] Downloaded lyon_tessellation v0.13.5 [INFO] [stderr] Downloaded gilrs-core v0.2.4 [INFO] [stderr] Downloaded gfx v0.18.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f9efdd9db4ad0e87a927e4505cdfb1302404a0ea6273780d778817edfa0f8a3 [INFO] running `Command { std: "docker" "start" "-a" "3f9efdd9db4ad0e87a927e4505cdfb1302404a0ea6273780d778817edfa0f8a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f9efdd9db4ad0e87a927e4505cdfb1302404a0ea6273780d778817edfa0f8a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f9efdd9db4ad0e87a927e4505cdfb1302404a0ea6273780d778817edfa0f8a3", kill_on_drop: false }` [INFO] [stdout] 3f9efdd9db4ad0e87a927e4505cdfb1302404a0ea6273780d778817edfa0f8a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b22a62a1b713ad7409eb97a6d2acce47cf65dd71486ef7004f35d9f89e1c3b09 [INFO] running `Command { std: "docker" "start" "-a" "b22a62a1b713ad7409eb97a6d2acce47cf65dd71486ef7004f35d9f89e1c3b09", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling serde v1.0.103 [INFO] [stderr] Compiling cc v1.0.47 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking rustc-hash v1.0.1 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Compiling gl_generator v0.11.0 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling error-chain v0.12.1 [INFO] [stderr] Compiling x11-dl v2.18.4 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking downcast-rs v1.1.1 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Compiling backtrace v0.3.40 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling libm v0.1.4 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling serde_json v1.0.42 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Checking rusttype v0.8.2 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling gfx_gl v0.6.0 [INFO] [stderr] Compiling glutin_glx_sys v0.1.5 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling euclid_macros v0.1.0 [INFO] [stderr] Compiling bzip2-sys v0.1.7 [INFO] [stderr] Compiling minimp3-sys v0.3.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking lock_api v0.3.2 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling remove_dir_all v0.5.2 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling nix v0.11.1 [INFO] [stderr] Checking euclid v0.19.9 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking gfx_core v0.9.2 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking sid v0.5.2 [INFO] [stderr] Checking lyon_geom v0.12.7 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking lyon_path v0.13.2 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking raw-window-handle v0.3.1 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling serde_derive v1.0.103 [INFO] [stderr] Checking xi-unicode v0.2.0 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling bytecount v0.4.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking glyph_brush_layout v0.1.8 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking alga v0.9.2 [INFO] [stderr] Checking twox-hash v1.5.0 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking slice-deque v0.2.4 [INFO] [stderr] Checking ogg v0.7.0 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking mint v0.5.4 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking minimp3 v0.3.3 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking png v0.15.1 [INFO] [stderr] Checking nalgebra v0.18.1 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Checking gfx_device_gl v0.16.2 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking glyph_brush v0.6.1 [INFO] [stderr] Checking lyon_tessellation v0.13.5 [INFO] [stderr] Checking lyon_algorithms v0.13.4 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking jpeg-decoder v0.1.16 [INFO] [stderr] Checking claxon v0.4.2 [INFO] [stderr] Checking gilrs-core v0.2.4 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking lyon v0.13.5 [INFO] [stderr] Checking image v0.22.3 [INFO] [stderr] Checking zip v0.5.3 [INFO] [stderr] Checking gilrs v0.7.2 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking glyph_brush v0.5.4 [INFO] [stderr] Checking gfx v0.18.2 [INFO] [stderr] Compiling smart-default v0.5.2 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Checking toml v0.5.5 [INFO] [stderr] Compiling ggez v0.5.1 [INFO] [stderr] Checking rodio v0.9.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.19.5 [INFO] [stderr] Checking glutin v0.20.1 [INFO] [stderr] Checking gfx_window_glutin v0.30.0 [INFO] [stderr] Checking path_planning v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | if loc_y - 1 >= 0 && self.flow_field_map_z[get_index(loc_x, loc_y - 1)] > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change it to: `loc_y > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/main.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | if loc_y - 1 >= 0 && self.flow_field_map_z[get_index(loc_x, loc_y - 1)] > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change it to: `loc_y > 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:304:18 [INFO] [stdout] | [INFO] [stdout] 304 | for (i, start) in self.starts.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:304:18 [INFO] [stdout] | [INFO] [stdout] 304 | for (i, start) in self.starts.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:72:49 [INFO] [stdout] | [INFO] [stdout] 72 | game_map.push(GridPosition::new(x as i32, y as i32, on)); [INFO] [stdout] | ^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:72:59 [INFO] [stdout] | [INFO] [stdout] 72 | game_map.push(GridPosition::new(x as i32, y as i32, on)); [INFO] [stdout] | ^^^^^^^^ help: try: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 126 | while !(loc_x == self.end.x && loc_y == self.end.y) && !no_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(no_path || loc_x == self.end.x && loc_y == self.end.y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:72:49 [INFO] [stdout] | [INFO] [stdout] 72 | game_map.push(GridPosition::new(x as i32, y as i32, on)); [INFO] [stdout] | ^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/main.rs:72:59 [INFO] [stdout] | [INFO] [stdout] 72 | game_map.push(GridPosition::new(x as i32, y as i32, on)); [INFO] [stdout] | ^^^^^^^^ help: try: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to move all elements into a new `Vec` [INFO] [stdout] --> src/main.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 300 | nodes = new_nodes.drain(0..).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `mem::take`: `std::mem::take(&mut new_nodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drain_collect [INFO] [stdout] = note: `#[warn(clippy::drain_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 126 | while !(loc_x == self.end.x && loc_y == self.end.y) && !no_path { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(no_path || loc_x == self.end.x && loc_y == self.end.y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:434:17 [INFO] [stdout] | [INFO] [stdout] 434 | / if self.starts.len() > 1 { [INFO] [stdout] 435 | | self.starts.pop(); [INFO] [stdout] 436 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 432 ~ KeyCode::Q [INFO] [stdout] 433 | // remove last added start position [INFO] [stdout] 434 ~ if self.starts.len() > 1 => { [INFO] [stdout] 435 | self.starts.pop(); [INFO] [stdout] 436 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:431:9 [INFO] [stdout] | [INFO] [stdout] 431 | / match keycode { [INFO] [stdout] 432 | | KeyCode::Q => { [INFO] [stdout] 433 | | // remove last added start position [INFO] [stdout] 434 | | if self.starts.len() > 1 { [INFO] [stdout] ... | [INFO] [stdout] 440 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 431 ~ if keycode == KeyCode::Q { [INFO] [stdout] 432 + // remove last added start position [INFO] [stdout] 433 + if self.starts.len() > 1 { [INFO] [stdout] 434 + self.starts.pop(); [INFO] [stdout] 435 + } [INFO] [stdout] 436 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to move all elements into a new `Vec` [INFO] [stdout] --> src/main.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 300 | nodes = new_nodes.drain(0..).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `mem::take`: `std::mem::take(&mut new_nodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drain_collect [INFO] [stdout] = note: `#[warn(clippy::drain_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:434:17 [INFO] [stdout] | [INFO] [stdout] 434 | / if self.starts.len() > 1 { [INFO] [stdout] 435 | | self.starts.pop(); [INFO] [stdout] 436 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 432 ~ KeyCode::Q [INFO] [stdout] 433 | // remove last added start position [INFO] [stdout] 434 ~ if self.starts.len() > 1 => { [INFO] [stdout] 435 | self.starts.pop(); [INFO] [stdout] 436 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/main.rs:431:9 [INFO] [stdout] | [INFO] [stdout] 431 | / match keycode { [INFO] [stdout] 432 | | KeyCode::Q => { [INFO] [stdout] 433 | | // remove last added start position [INFO] [stdout] 434 | | if self.starts.len() > 1 { [INFO] [stdout] ... | [INFO] [stdout] 440 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 431 ~ if keycode == KeyCode::Q { [INFO] [stdout] 432 + // remove last added start position [INFO] [stdout] 433 + if self.starts.len() > 1 { [INFO] [stdout] 434 + self.starts.pop(); [INFO] [stdout] 435 + } [INFO] [stdout] 436 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 1m 44s [INFO] running `Command { std: "docker" "inspect" "b22a62a1b713ad7409eb97a6d2acce47cf65dd71486ef7004f35d9f89e1c3b09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b22a62a1b713ad7409eb97a6d2acce47cf65dd71486ef7004f35d9f89e1c3b09", kill_on_drop: false }` [INFO] [stdout] b22a62a1b713ad7409eb97a6d2acce47cf65dd71486ef7004f35d9f89e1c3b09