[INFO] cloning repository https://github.com/dalen/ecs-run [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dalen/ecs-run" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalen%2Fecs-run", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalen%2Fecs-run'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8ad17d7365f3aa9e61da37fe62fe3e13ba932582 [INFO] linting dalen/ecs-run against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalen%2Fecs-run" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dalen/ecs-run [INFO] finished tweaking git repo https://github.com/dalen/ecs-run [INFO] tweaked toml for git repo https://github.com/dalen/ecs-run written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dalen/ecs-run on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dalen/ecs-run already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded semver v1.0.12 [INFO] [stderr] Downloaded indexmap v1.6.1 [INFO] [stderr] Downloaded md-5 v0.9.1 [INFO] [stderr] Downloaded vcpkg v0.2.11 [INFO] [stderr] Downloaded hex v0.4.2 [INFO] [stderr] Downloaded rusoto_signature v0.48.0 [INFO] [stderr] Downloaded os_str_bytes v6.1.0 [INFO] [stderr] Downloaded openssl-sys v0.9.60 [INFO] [stderr] Downloaded security-framework-sys v2.0.0 [INFO] [stderr] Downloaded security-framework v2.0.0 [INFO] [stderr] Downloaded serde_json v1.0.62 [INFO] [stderr] Downloaded tokio-util v0.7.3 [INFO] [stderr] Downloaded tracing-core v0.1.28 [INFO] [stderr] Downloaded clap v3.2.11 [INFO] [stderr] Downloaded tracing v0.1.35 [INFO] [stderr] Downloaded rusoto_ecs v0.48.0 [INFO] [stderr] Downloaded zeroize v1.5.6 [INFO] [stderr] Downloaded rusoto_logs v0.48.0 [INFO] [stderr] Downloaded native-tls v0.2.7 [INFO] [stderr] Downloaded async-trait v0.1.42 [INFO] [stderr] Downloaded rusoto_credential v0.48.0 [INFO] [stderr] Downloaded openssl v0.10.32 [INFO] [stderr] Downloaded rusoto_core v0.48.0 [INFO] [stderr] Downloaded signal-hook-registry v1.3.0 [INFO] [stderr] Downloaded serde v1.0.123 [INFO] [stderr] Downloaded serde_derive v1.0.123 [INFO] [stderr] Downloaded tokio v1.19.2 [INFO] [stderr] Downloaded openssl-src v111.25.0+1.1.1t [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d12a3aa0714f1d2a6d1278052c4bce73ef2a6eb92ce2b1af98b364f48ff54a4 [INFO] running `Command { std: "docker" "start" "-a" "1d12a3aa0714f1d2a6d1278052c4bce73ef2a6eb92ce2b1af98b364f48ff54a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d12a3aa0714f1d2a6d1278052c4bce73ef2a6eb92ce2b1af98b364f48ff54a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d12a3aa0714f1d2a6d1278052c4bce73ef2a6eb92ce2b1af98b364f48ff54a4", kill_on_drop: false }` [INFO] [stdout] 1d12a3aa0714f1d2a6d1278052c4bce73ef2a6eb92ce2b1af98b364f48ff54a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9a5b90bdedf091cc1e8ef3b2a0d0286fb8c231486716d414eafe1e91ac9abf0c [INFO] running `Command { std: "docker" "start" "-a" "9a5b90bdedf091cc1e8ef3b2a0d0286fb8c231486716d414eafe1e91ac9abf0c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling indexmap v1.6.1 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking tracing-core v0.1.28 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Compiling openssl-src v111.25.0+1.1.1t [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling openssl v0.10.32 [INFO] [stderr] Compiling semver v1.0.12 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling native-tls v0.2.7 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling serde_json v1.0.62 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking openssl-probe v0.1.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking zeroize v1.5.6 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking shlex v1.1.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking xml-rs v0.8.3 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling openssl-sys v0.9.60 [INFO] [stderr] Checking clap v3.2.11 [INFO] [stderr] Compiling rusoto_core v0.48.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking crypto-mac v0.11.1 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking hmac v0.11.0 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling async-trait v0.1.42 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking hyper v0.14.20 [INFO] [stderr] Checking rusoto_credential v0.48.0 [INFO] [stderr] Checking rusoto_signature v0.48.0 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking rusoto_logs v0.48.0 [INFO] [stderr] Checking rusoto_ecs v0.48.0 [INFO] [stderr] Checking ecs-run v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | if !log_options.get("awslogs-group").is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `log_options.get("awslogs-group").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `raw_memory` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 73 | if raw_memory.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = raw_memory` [INFO] [stdout] 74 | memory = Option::from(raw_memory.unwrap().parse::().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `raw_memory` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 85 | memory = if raw_memory.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = raw_memory` [INFO] [stdout] 86 | raw_memory.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | let memory: Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `memory` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 71 ~ [INFO] [stdout] 72 | [INFO] [stdout] 73 ~ let memory: Option = if raw_memory.is_some() { [INFO] [stdout] 74 ~ Option::from(raw_memory.unwrap().parse::().unwrap()) [INFO] [stdout] 75 | } else { [INFO] [stdout] 76 ~ None [INFO] [stdout] 77 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:93:38 [INFO] [stdout] | [INFO] [stdout] 93 | match fetch_service(&ecs_client, &cluster, &service) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `cluster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | match fetch_service(&ecs_client, &cluster, &service) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `service` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | &cluster.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `cluster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `rsplitn` [INFO] [stdout] --> src/main.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 117 | let task_id = &task [INFO] [stdout] | ____________________________^ [INFO] [stdout] 118 | | .clone() [INFO] [stdout] 119 | | .task_arn [INFO] [stdout] 120 | | .unwrap() [INFO] [stdout] 121 | | .rsplitn(2, '/') [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn [INFO] [stdout] = note: `#[warn(clippy::needless_splitn)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 117 ~ let task_id = &task [INFO] [stdout] 118 + .clone() [INFO] [stdout] 119 + .task_arn [INFO] [stdout] 120 + .unwrap().rsplit('/') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:129:47 [INFO] [stdout] | [INFO] [stdout] 129 | match fetch_task(&ecs_client, &cluster.to_string(), &task) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `cluster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:134:28 [INFO] [stdout] | [INFO] [stdout] 134 | if task_status.stopped_at != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `task_status.stopped_at.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("awslogs-group").is_none()` [INFO] [stdout] --> src/main.rs:153:29 [INFO] [stdout] | [INFO] [stdout] 153 | if !log_options.get("awslogs-group").is_none() { [INFO] [stdout] | ------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!log_options.contains_key("awslogs-group")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:168:78 [INFO] [stdout] | [INFO] [stdout] 168 | let logs_client = CloudWatchLogsClient::new(Region::from_str(&log_region).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `log_region` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:179:53 [INFO] [stdout] | [INFO] [stdout] 179 | let logs = fetch_logs(&logs_client, &log_group, &log_stream_name); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `log_group` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | / match &log.message { [INFO] [stdout] 183 | | Some(message) => println!("{}", &message), [INFO] [stdout] 184 | | None => (), [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(message) = &log.message { println!("{}", &message) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | / if *exit_code != 0 { [INFO] [stdout] 263 | | return *exit_code; [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 261 ~ Some(exit_code) [INFO] [stdout] 262 ~ if *exit_code != 0 => { [INFO] [stdout] 263 | return *exit_code; [INFO] [stdout] 264 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | / match &container.exit_code { [INFO] [stdout] 261 | | Some(exit_code) => { [INFO] [stdout] 262 | | if *exit_code != 0 { [INFO] [stdout] 263 | | return *exit_code; [INFO] [stdout] ... | [INFO] [stdout] 266 | | None => {} [INFO] [stdout] 267 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 260 ~ if let Some(exit_code) = &container.exit_code { [INFO] [stdout] 261 + if *exit_code != 0 { [INFO] [stdout] 262 + return *exit_code; [INFO] [stdout] 263 + } [INFO] [stdout] 264 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `memory` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:316:22 [INFO] [stdout] | [INFO] [stdout] 315 | if memory.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = memory` [INFO] [stdout] 316 | let memory = memory.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | if !log_options.get("awslogs-group").is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `log_options.get("awslogs-group").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `raw_memory` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:74:31 [INFO] [stdout] | [INFO] [stdout] 73 | if raw_memory.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = raw_memory` [INFO] [stdout] 74 | memory = Option::from(raw_memory.unwrap().parse::().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `raw_memory` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 85 | memory = if raw_memory.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = raw_memory` [INFO] [stdout] 86 | raw_memory.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/main.rs:365:6 [INFO] [stdout] | [INFO] [stdout] 365 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 366 | | rusoto_ecs::DescribeTaskDefinitionResponse, [INFO] [stdout] 367 | | rusoto_core::RusotoError, [INFO] [stdout] 368 | | > { [INFO] [stdout] | |_^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `rusoto_core::RusotoError`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | let memory: Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `memory` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 71 ~ [INFO] [stdout] 72 | [INFO] [stdout] 73 ~ let memory: Option = if raw_memory.is_some() { [INFO] [stdout] 74 ~ Option::from(raw_memory.unwrap().parse::().unwrap()) [INFO] [stdout] 75 | } else { [INFO] [stdout] 76 ~ None [INFO] [stdout] 77 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:93:38 [INFO] [stdout] | [INFO] [stdout] 93 | match fetch_service(&ecs_client, &cluster, &service) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `cluster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:93:48 [INFO] [stdout] | [INFO] [stdout] 93 | match fetch_service(&ecs_client, &cluster, &service) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `service` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | &cluster.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `cluster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `rsplitn` [INFO] [stdout] --> src/main.rs:117:28 [INFO] [stdout] | [INFO] [stdout] 117 | let task_id = &task [INFO] [stdout] | ____________________________^ [INFO] [stdout] 118 | | .clone() [INFO] [stdout] 119 | | .task_arn [INFO] [stdout] 120 | | .unwrap() [INFO] [stdout] 121 | | .rsplitn(2, '/') [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_splitn [INFO] [stdout] = note: `#[warn(clippy::needless_splitn)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 117 ~ let task_id = &task [INFO] [stdout] 118 + .clone() [INFO] [stdout] 119 + .task_arn [INFO] [stdout] 120 + .unwrap().rsplit('/') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:129:47 [INFO] [stdout] | [INFO] [stdout] 129 | match fetch_task(&ecs_client, &cluster.to_string(), &task) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `cluster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/main.rs:134:28 [INFO] [stdout] | [INFO] [stdout] 134 | if task_status.stopped_at != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `task_status.stopped_at.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("awslogs-group").is_none()` [INFO] [stdout] --> src/main.rs:153:29 [INFO] [stdout] | [INFO] [stdout] 153 | if !log_options.get("awslogs-group").is_none() { [INFO] [stdout] | ------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!log_options.contains_key("awslogs-group")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:168:78 [INFO] [stdout] | [INFO] [stdout] 168 | let logs_client = CloudWatchLogsClient::new(Region::from_str(&log_region).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `log_region` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:179:53 [INFO] [stdout] | [INFO] [stdout] 179 | let logs = fetch_logs(&logs_client, &log_group, &log_stream_name); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `log_group` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 182 | / match &log.message { [INFO] [stdout] 183 | | Some(message) => println!("{}", &message), [INFO] [stdout] 184 | | None => (), [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(message) = &log.message { println!("{}", &message) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:262:25 [INFO] [stdout] | [INFO] [stdout] 262 | / if *exit_code != 0 { [INFO] [stdout] 263 | | return *exit_code; [INFO] [stdout] 264 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 261 ~ Some(exit_code) [INFO] [stdout] 262 ~ if *exit_code != 0 => { [INFO] [stdout] 263 | return *exit_code; [INFO] [stdout] 264 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | / match &container.exit_code { [INFO] [stdout] 261 | | Some(exit_code) => { [INFO] [stdout] 262 | | if *exit_code != 0 { [INFO] [stdout] 263 | | return *exit_code; [INFO] [stdout] ... | [INFO] [stdout] 266 | | None => {} [INFO] [stdout] 267 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 260 ~ if let Some(exit_code) = &container.exit_code { [INFO] [stdout] 261 + if *exit_code != 0 { [INFO] [stdout] 262 + return *exit_code; [INFO] [stdout] 263 + } [INFO] [stdout] 264 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `memory` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:316:22 [INFO] [stdout] | [INFO] [stdout] 315 | if memory.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = memory` [INFO] [stdout] 316 | let memory = memory.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/main.rs:365:6 [INFO] [stdout] | [INFO] [stdout] 365 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 366 | | rusoto_ecs::DescribeTaskDefinitionResponse, [INFO] [stdout] 367 | | rusoto_core::RusotoError, [INFO] [stdout] 368 | | > { [INFO] [stdout] | |_^ the `Err`-variant is at least 136 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `rusoto_core::RusotoError`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 38s [INFO] running `Command { std: "docker" "inspect" "9a5b90bdedf091cc1e8ef3b2a0d0286fb8c231486716d414eafe1e91ac9abf0c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9a5b90bdedf091cc1e8ef3b2a0d0286fb8c231486716d414eafe1e91ac9abf0c", kill_on_drop: false }` [INFO] [stdout] 9a5b90bdedf091cc1e8ef3b2a0d0286fb8c231486716d414eafe1e91ac9abf0c