[INFO] cloning repository https://github.com/dai-dao/rust-algorithms [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dai-dao/rust-algorithms" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdai-dao%2Frust-algorithms", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdai-dao%2Frust-algorithms'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 14b2c1ec443cbee164e8c4c2c5ca9d90d727564d [INFO] linting dai-dao/rust-algorithms against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdai-dao%2Frust-algorithms" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dai-dao/rust-algorithms [INFO] finished tweaking git repo https://github.com/dai-dao/rust-algorithms [INFO] tweaked toml for git repo https://github.com/dai-dao/rust-algorithms written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dai-dao/rust-algorithms on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dai-dao/rust-algorithms already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f9a48672a6525266df4df2ff676a8139f4a8784c1ad2aa3e60194c70294d73f5 [INFO] running `Command { std: "docker" "start" "-a" "f9a48672a6525266df4df2ff676a8139f4a8784c1ad2aa3e60194c70294d73f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f9a48672a6525266df4df2ff676a8139f4a8784c1ad2aa3e60194c70294d73f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9a48672a6525266df4df2ff676a8139f4a8784c1ad2aa3e60194c70294d73f5", kill_on_drop: false }` [INFO] [stdout] f9a48672a6525266df4df2ff676a8139f4a8784c1ad2aa3e60194c70294d73f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e1a70c2cd5e74c09b614767738d53d4ce28c8921386c36d7382471fdfdf4a069 [INFO] running `Command { std: "docker" "start" "-a" "e1a70c2cd5e74c09b614767738d53d4ce28c8921386c36d7382471fdfdf4a069", kill_on_drop: false }` [INFO] [stderr] Checking challenge v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | return Node { val : val, next : None } [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | return Node { val : val, next : None } [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | let mut a = &mut l1.clone(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | let mut b = &mut l2.clone(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return Node { value : val, left : None, right : None }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return Node { value : val, left : None, right : None }; [INFO] [stdout] 14 + Node { value : val, left : None, right : None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return true; [INFO] [stdout] 28 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return false; [INFO] [stdout] 30 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/rs/valid_binary_search.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / if node_box.value > low && node_box.value < high && [INFO] [stdout] 25 | | Solution::_is_valid_bst_helper(node_box.left, low, node_box.value) && [INFO] [stdout] 26 | | Solution::_is_valid_bst_helper(node_box.right, node_box.value, high) [INFO] [stdout] ... | [INFO] [stdout] 30 | | return false; [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 24 ~ return node_box.value > low && node_box.value < high && [INFO] [stdout] 25 + Solution::_is_valid_bst_helper(node_box.left, low, node_box.value) && Solution::_is_valid_bst_helper(node_box.right, node_box.value, high) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | let mut a = &mut l1.clone(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | let mut b = &mut l2.clone(); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return Solution::_is_valid_bst_helper(Some(Box::new(node)), -100, 100); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Solution::_is_valid_bst_helper(Some(Box::new(node)), -100, 100); [INFO] [stdout] 38 + Solution::_is_valid_bst_helper(Some(Box::new(node)), -100, 100) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/ransom_note.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return true [INFO] [stdout] 25 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return Node { value : val, left : None, right : None }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return Node { value : val, left : None, right : None }; [INFO] [stdout] 14 + Node { value : val, left : None, right : None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return true; [INFO] [stdout] 28 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return false; [INFO] [stdout] 30 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/rs/valid_binary_search.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / if node_box.value > low && node_box.value < high && [INFO] [stdout] 25 | | Solution::_is_valid_bst_helper(node_box.left, low, node_box.value) && [INFO] [stdout] 26 | | Solution::_is_valid_bst_helper(node_box.right, node_box.value, high) [INFO] [stdout] ... | [INFO] [stdout] 30 | | return false; [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 24 ~ return node_box.value > low && node_box.value < high && [INFO] [stdout] 25 + Solution::_is_valid_bst_helper(node_box.left, low, node_box.value) && Solution::_is_valid_bst_helper(node_box.right, node_box.value, high) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/valid_binary_search.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return Solution::_is_valid_bst_helper(Some(Box::new(node)), -100, 100); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return Solution::_is_valid_bst_helper(Some(Box::new(node)), -100, 100); [INFO] [stdout] 38 + Solution::_is_valid_bst_helper(Some(Box::new(node)), -100, 100) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return Node { val : val, next : None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Node { val : val, next : None } [INFO] [stdout] 12 + Node { val : val, next : None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/ransom_note.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return true [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return true [INFO] [stdout] 25 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if !a.next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `a.next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | if !b.next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `b.next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return ret; [INFO] [stdout] 59 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | if !a.as_ref().unwrap().next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.as_ref().unwrap().next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | if !b.as_ref().unwrap().next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b.as_ref().unwrap().next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return ret; [INFO] [stdout] 98 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return Node { val : val, next : None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return Node { val : val, next : None } [INFO] [stdout] 12 + Node { val : val, next : None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if !a.next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `a.next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | if !b.next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `b.next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return ret; [INFO] [stdout] 59 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | if !a.as_ref().unwrap().next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.as_ref().unwrap().next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 87 | if !b.as_ref().unwrap().next.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b.as_ref().unwrap().next.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rs/add_two_number_linked_list.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return ret; [INFO] [stdout] 98 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s [INFO] running `Command { std: "docker" "inspect" "e1a70c2cd5e74c09b614767738d53d4ce28c8921386c36d7382471fdfdf4a069", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1a70c2cd5e74c09b614767738d53d4ce28c8921386c36d7382471fdfdf4a069", kill_on_drop: false }` [INFO] [stdout] e1a70c2cd5e74c09b614767738d53d4ce28c8921386c36d7382471fdfdf4a069