[INFO] cloning repository https://github.com/daemontus/bn-scc-experiments [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/daemontus/bn-scc-experiments" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaemontus%2Fbn-scc-experiments", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaemontus%2Fbn-scc-experiments'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b25b6e27513c43e4645fe566bef0e10807dd6c08 [INFO] linting daemontus/bn-scc-experiments against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaemontus%2Fbn-scc-experiments" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/daemontus/bn-scc-experiments [INFO] finished tweaking git repo https://github.com/daemontus/bn-scc-experiments [INFO] tweaked toml for git repo https://github.com/daemontus/bn-scc-experiments written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/daemontus/bn-scc-experiments on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/daemontus/bn-scc-experiments already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded spin v0.5.0 [INFO] [stderr] Downloaded rand_chacha v0.2.0 [INFO] [stderr] Downloaded crossbeam v0.7.1 [INFO] [stderr] Downloaded getrandom v0.1.6 [INFO] [stderr] Downloaded rand_core v0.5.0 [INFO] [stderr] Downloaded rand v0.7.0 [INFO] [stderr] Downloaded autocfg v0.1.4 [INFO] [stderr] Downloaded libc v0.2.59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d3f0d526eb6fd324895608fc2377333499046952ddbf0ea7e2c4f5e58e37bf6 [INFO] running `Command { std: "docker" "start" "-a" "0d3f0d526eb6fd324895608fc2377333499046952ddbf0ea7e2c4f5e58e37bf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d3f0d526eb6fd324895608fc2377333499046952ddbf0ea7e2c4f5e58e37bf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d3f0d526eb6fd324895608fc2377333499046952ddbf0ea7e2c4f5e58e37bf6", kill_on_drop: false }` [INFO] [stdout] 0d3f0d526eb6fd324895608fc2377333499046952ddbf0ea7e2c4f5e58e37bf6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66162b53df75cf6bf18b25771f733079177cf205064f766779eba0bd264152e2 [INFO] running `Command { std: "docker" "start" "-a" "66162b53df75cf6bf18b25771f733079177cf205064f766779eba0bd264152e2", kill_on_drop: false }` [INFO] [stderr] Checking spin v0.5.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling libc v0.2.59 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Compiling rand_chacha v0.2.0 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.3.8 [INFO] [stderr] Checking getrandom v0.1.6 [INFO] [stderr] Checking rand_core v0.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking crossbeam v0.7.1 [INFO] [stderr] Checking biodivine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | (s | cx43_m) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 52 - (s | cx43_m) [INFO] [stdout] 52 + s | cx43_m [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | (s | l_tlr) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - (s | l_tlr) [INFO] [stdout] 55 + s | l_tlr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | (!(s | gsk3b_h)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - (!(s | gsk3b_h)) [INFO] [stdout] 60 + !(s | gsk3b_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | (!(s | pi3kakt_h)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 90 - (!(s | pi3kakt_h)) [INFO] [stdout] 90 + !(s | pi3kakt_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | (s | l_tlr) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 114 - (s | l_tlr) [INFO] [stdout] 114 + s | l_tlr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | (!(s | pi3kakt_m)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 135 - (!(s | pi3kakt_m)) [INFO] [stdout] 135 + !(s | pi3kakt_m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | (s | l_tlr) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 155 - (s | l_tlr) [INFO] [stdout] 155 + s | l_tlr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | (s | il1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - (s | il1) [INFO] [stdout] 173 + s | il1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | (s | insulin) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - (s | insulin) [INFO] [stdout] 213 + s | insulin [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | (s | gf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - (s | gf) [INFO] [stdout] 216 + s | gf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | (s | therapy) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - (s | therapy) [INFO] [stdout] 219 + s | therapy [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | (!(s | mdm2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 246 - (!(s | mdm2)) [INFO] [stdout] 246 + !(s | mdm2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | (s | metabolism) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 264 - (s | metabolism) [INFO] [stdout] 264 + s | metabolism [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | (!(s | cdk2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - (!(s | cdk2)) [INFO] [stdout] 293 + !(s | cdk2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | (!(s | m_torc1_s6k1)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 313 - (!(s | m_torc1_s6k1)) [INFO] [stdout] 313 + !(s | m_torc1_s6k1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | (s | myc) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 385 - (s | myc) [INFO] [stdout] 385 + s | myc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | (s | cx43_m) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 52 - (s | cx43_m) [INFO] [stdout] 52 + s | cx43_m [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | (s | l_tlr) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - (s | l_tlr) [INFO] [stdout] 55 + s | l_tlr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | (s | cyclin_d1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 406 - (s | cyclin_d1) [INFO] [stdout] 406 + s | cyclin_d1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | (!(s | gsk3b_h)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - (!(s | gsk3b_h)) [INFO] [stdout] 60 + !(s | gsk3b_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:425:9 [INFO] [stdout] | [INFO] [stdout] 425 | (s | egf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 425 - (s | egf) [INFO] [stdout] 425 + s | egf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:429:9 [INFO] [stdout] | [INFO] [stdout] 429 | (s | egf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 429 - (s | egf) [INFO] [stdout] 429 + s | egf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | (s | egf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 433 - (s | egf) [INFO] [stdout] 433 + s | egf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:463:9 [INFO] [stdout] | [INFO] [stdout] 463 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 463 - (s | p53) [INFO] [stdout] 463 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | (!(s | pi3kakt_h)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 90 - (!(s | pi3kakt_h)) [INFO] [stdout] 90 + !(s | pi3kakt_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 485 - (s | p53) [INFO] [stdout] 485 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 507 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 507 - (s | p53) [INFO] [stdout] 507 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | (s | l_tlr) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 114 - (s | l_tlr) [INFO] [stdout] 114 + s | l_tlr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 529 - (s | p53) [INFO] [stdout] 529 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | (!(s | pi3kakt_m)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 135 - (!(s | pi3kakt_m)) [INFO] [stdout] 135 + !(s | pi3kakt_m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | (s | l_tlr) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 155 - (s | l_tlr) [INFO] [stdout] 155 + s | l_tlr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | (s | il1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 173 - (s | il1) [INFO] [stdout] 173 + s | il1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | (s | insulin) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 213 - (s | insulin) [INFO] [stdout] 213 + s | insulin [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | (s | gf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - (s | gf) [INFO] [stdout] 216 + s | gf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | (s | therapy) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 219 - (s | therapy) [INFO] [stdout] 219 + s | therapy [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | (!(s | mdm2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 246 - (!(s | mdm2)) [INFO] [stdout] 246 + !(s | mdm2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | (s | metabolism) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 264 - (s | metabolism) [INFO] [stdout] 264 + s | metabolism [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:293:9 [INFO] [stdout] | [INFO] [stdout] 293 | (!(s | cdk2)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 293 - (!(s | cdk2)) [INFO] [stdout] 293 + !(s | cdk2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | (!(s | m_torc1_s6k1)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 313 - (!(s | m_torc1_s6k1)) [INFO] [stdout] 313 + !(s | m_torc1_s6k1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | (s | myc) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 385 - (s | myc) [INFO] [stdout] 385 + s | myc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | (s | cyclin_d1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 406 - (s | cyclin_d1) [INFO] [stdout] 406 + s | cyclin_d1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:425:9 [INFO] [stdout] | [INFO] [stdout] 425 | (s | egf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 425 - (s | egf) [INFO] [stdout] 425 + s | egf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:429:9 [INFO] [stdout] | [INFO] [stdout] 429 | (s | egf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 429 - (s | egf) [INFO] [stdout] 429 + s | egf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | (s | egf) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 433 - (s | egf) [INFO] [stdout] 433 + s | egf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:463:9 [INFO] [stdout] | [INFO] [stdout] 463 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 463 - (s | p53) [INFO] [stdout] 463 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 485 - (s | p53) [INFO] [stdout] 485 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 507 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 507 - (s | p53) [INFO] [stdout] 507 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/u32/models.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | (s | p53) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 529 - (s | p53) [INFO] [stdout] 529 + s | p53 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/bitset.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 81 | if self.values[value_index].compare_and_swap(old_value, new_value, Ordering::SeqCst) == old_value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/bitset.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 81 | if self.values[value_index].compare_and_swap(old_value, new_value, Ordering::SeqCst) == old_value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/u32/parallel.rs:169:43 [INFO] [stdout] | [INFO] [stdout] 169 | self.parent_pointer[item].compare_and_swap(parent as u32, parents_parent as u32, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/u32/parallel.rs:186:47 [INFO] [stdout] | [INFO] [stdout] 186 | if self.parent_pointer[r].compare_and_swap(r as u32, l as u32, Ordering::SeqCst) == r as u32 { return } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/u32/parallel.rs:188:47 [INFO] [stdout] | [INFO] [stdout] 188 | if self.parent_pointer[l].compare_and_swap(l as u32, r as u32, Ordering::SeqCst) == l as u32 { return } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/u32/parallel.rs:169:43 [INFO] [stdout] | [INFO] [stdout] 169 | self.parent_pointer[item].compare_and_swap(parent as u32, parents_parent as u32, Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/u32/parallel.rs:186:47 [INFO] [stdout] | [INFO] [stdout] 186 | if self.parent_pointer[r].compare_and_swap(r as u32, l as u32, Ordering::SeqCst) == r as u32 { return } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::Atomic::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/u32/parallel.rs:188:47 [INFO] [stdout] | [INFO] [stdout] 188 | if self.parent_pointer[l].compare_and_swap(l as u32, r as u32, Ordering::SeqCst) == l as u32 { return } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `num_vars` is never used [INFO] [stdout] --> src/bdd/mod.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 73 | impl BDD { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 101 | fn num_vars(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] 16 + BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:15:41 [INFO] [stdout] | [INFO] [stdout] 15 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bitset.rs:16:38 [INFO] [stdout] | [INFO] [stdout] 16 | return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] 16 + return BitSet { values: vec![u32::MAX; size] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return BitSet { values: vec![0; size] } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return BitSet { values: vec![0; size] } [INFO] [stdout] 21 + BitSet { values: vec![0; size] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bitset.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | self.values[value_index] = self.values[value_index] & !(1 << bit_index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.values[value_index] &= !(1 << bit_index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bitset.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | self.values[value_index] = self.values[value_index] | (1 << bit_index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.values[value_index] |= (1 << bit_index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return (self.values[value_index] >> bit_index) & 1 == 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return (self.values[value_index] >> bit_index) & 1 == 1; [INFO] [stdout] 46 + (self.values[value_index] >> bit_index) & 1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] 61 + AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:60:41 [INFO] [stdout] | [INFO] [stdout] 60 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bitset.rs:61:72 [INFO] [stdout] | [INFO] [stdout] 61 | return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 61 - return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] 61 + return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(u32::MAX)).collect() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(0)).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(0)).collect() } [INFO] [stdout] 66 + AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(0)).collect() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 65 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return (self.values[value_index].load(Ordering::SeqCst) >> bit_index) & 1 == 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return (self.values[value_index].load(Ordering::SeqCst) >> bit_index) & 1 == 1; [INFO] [stdout] 72 + (self.values[value_index].load(Ordering::SeqCst) >> bit_index) & 1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return (self.value >> rhs.value) & 1 == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return (self.value >> rhs.value) & 1 == 1 [INFO] [stdout] 64 + (self.value >> rhs.value) & 1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return StateId { value: self.value ^ (1_u32 << rhs.value) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return StateId { value: self.value ^ (1_u32 << rhs.value) } [INFO] [stdout] 73 + StateId { value: self.value ^ (1_u32 << rhs.value) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / return if self.remaining == 0 { None } else { [INFO] [stdout] 95 | | self.remaining -= 1; [INFO] [stdout] 96 | | Some(VariableId { value: self.remaining as u32 }) [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 ~ if self.remaining == 0 { None } else { [INFO] [stdout] 95 + self.remaining -= 1; [INFO] [stdout] 96 + Some(VariableId { value: self.remaining as u32 }) [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / return if self.max_state == 0 { None } else { [INFO] [stdout] 107 | | if self.state == self.max_state { // last state - clean up [INFO] [stdout] 108 | | self.max_state = 0; [INFO] [stdout] 109 | | Some(StateId { value: self.state }) [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 ~ if self.max_state == 0 { None } else { [INFO] [stdout] 107 + if self.state == self.max_state { // last state - clean up [INFO] [stdout] 108 + self.max_state = 0; [INFO] [stdout] 109 + Some(StateId { value: self.state }) [INFO] [stdout] 110 + } else { // continue as usual [INFO] [stdout] 111 + self.state += 1; [INFO] [stdout] 112 + Some(StateId { value: self.state - 1 }) [INFO] [stdout] 113 + } [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] 16 + BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return self.update_functions.len() as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return self.update_functions.len() as u8; [INFO] [stdout] 122 + self.update_functions.len() as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:15:41 [INFO] [stdout] | [INFO] [stdout] 15 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | return 1_u64 << self.var_count() as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return 1_u64 << self.var_count() as u64; [INFO] [stdout] 127 + 1_u64 << self.var_count() as u64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bitset.rs:16:38 [INFO] [stdout] | [INFO] [stdout] 16 | return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - return BitSet { values: vec![std::u32::MAX; size] } [INFO] [stdout] 16 + return BitSet { values: vec![u32::MAX; size] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return VariableIterator { remaining: self.var_count() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return VariableIterator { remaining: self.var_count() } [INFO] [stdout] 131 + VariableIterator { remaining: self.var_count() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return BitSet { values: vec![0; size] } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return BitSet { values: vec![0; size] } [INFO] [stdout] 21 + BitSet { values: vec![0; size] } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | return StateIterator { state: 0, max_state: (self.state_count() - 1) as u32 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return StateIterator { state: 0, max_state: (self.state_count() - 1) as u32 } [INFO] [stdout] 136 + StateIterator { state: 0, max_state: (self.state_count() - 1) as u32 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return if *state | *variable == target { None } else { Some(*state ^ *variable) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return if *state | *variable == target { None } else { Some(*state ^ *variable) } [INFO] [stdout] 143 + if *state | *variable == target { None } else { Some(*state ^ *variable) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `StateId` which implements the `Copy` trait [INFO] [stdout] --> src/u32/bn.rs:142:75 [INFO] [stdout] | [INFO] [stdout] 142 | let target: bool = self.update_functions[variable.value as usize](state.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BooleanNetworkBuilder` [INFO] [stdout] --> src/u32/bn.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / pub fn new() -> BooleanNetworkBuilder { [INFO] [stdout] 152 | | return BooleanNetworkBuilder { [INFO] [stdout] 153 | | variable_count: 0, [INFO] [stdout] 154 | | variable_names: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 148 + impl Default for BooleanNetworkBuilder { [INFO] [stdout] 149 + fn default() -> Self { [INFO] [stdout] 150 + Self::new() [INFO] [stdout] 151 + } [INFO] [stdout] 152 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bitset.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | self.values[value_index] = self.values[value_index] & !(1 << bit_index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.values[value_index] &= !(1 << bit_index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / return BooleanNetworkBuilder { [INFO] [stdout] 153 | | variable_count: 0, [INFO] [stdout] 154 | | variable_names: HashMap::new(), [INFO] [stdout] 155 | | update_functions: HashMap::new() [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 ~ BooleanNetworkBuilder { [INFO] [stdout] 153 + variable_count: 0, [INFO] [stdout] 154 + variable_names: HashMap::new(), [INFO] [stdout] 155 + update_functions: HashMap::new() [INFO] [stdout] 156 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return variable; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return variable; [INFO] [stdout] 169 + variable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bitset.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | self.values[value_index] = self.values[value_index] | (1 << bit_index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.values[value_index] |= (1 << bit_index)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/u32/bn.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | for (_, existing) in &self.variable_names { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 165 - for (_, existing) in &self.variable_names { [INFO] [stdout] 165 + for existing in self.variable_names.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return (self.values[value_index] >> bit_index) & 1 == 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return (self.values[value_index] >> bit_index) & 1 == 1; [INFO] [stdout] 46 + (self.values[value_index] >> bit_index) & 1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] 61 + AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:60:41 [INFO] [stdout] | [INFO] [stdout] 60 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bitset.rs:61:72 [INFO] [stdout] | [INFO] [stdout] 61 | return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 61 - return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(std::u32::MAX)).collect() } [INFO] [stdout] 61 + return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(u32::MAX)).collect() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(0)).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(0)).collect() } [INFO] [stdout] 66 + AtomicBitSet { values: (0..size).map(|_| AtomicU32::new(0)).collect() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bitset.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 65 | let size = (capacity / 32) + if capacity % 32 == 0 { 0 } else { 1 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `capacity.is_multiple_of(32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bitset.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | return (self.values[value_index].load(Ordering::SeqCst) >> bit_index) & 1 == 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return (self.values[value_index].load(Ordering::SeqCst) >> bit_index) & 1 == 1; [INFO] [stdout] 72 + (self.values[value_index].load(Ordering::SeqCst) >> bit_index) & 1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return (self.value >> rhs.value) & 1 == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return (self.value >> rhs.value) & 1 == 1 [INFO] [stdout] 64 + (self.value >> rhs.value) & 1 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return StateId { value: self.value ^ (1_u32 << rhs.value) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return StateId { value: self.value ^ (1_u32 << rhs.value) } [INFO] [stdout] 73 + StateId { value: self.value ^ (1_u32 << rhs.value) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / return if self.remaining == 0 { None } else { [INFO] [stdout] 95 | | self.remaining -= 1; [INFO] [stdout] 96 | | Some(VariableId { value: self.remaining as u32 }) [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 ~ if self.remaining == 0 { None } else { [INFO] [stdout] 95 + self.remaining -= 1; [INFO] [stdout] 96 + Some(VariableId { value: self.remaining as u32 }) [INFO] [stdout] 97 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / return if self.max_state == 0 { None } else { [INFO] [stdout] 107 | | if self.state == self.max_state { // last state - clean up [INFO] [stdout] 108 | | self.max_state = 0; [INFO] [stdout] 109 | | Some(StateId { value: self.state }) [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 ~ if self.max_state == 0 { None } else { [INFO] [stdout] 107 + if self.state == self.max_state { // last state - clean up [INFO] [stdout] 108 + self.max_state = 0; [INFO] [stdout] 109 + Some(StateId { value: self.state }) [INFO] [stdout] 110 + } else { // continue as usual [INFO] [stdout] 111 + self.state += 1; [INFO] [stdout] 112 + Some(StateId { value: self.state - 1 }) [INFO] [stdout] 113 + } [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return self.update_functions.len() as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return self.update_functions.len() as u8; [INFO] [stdout] 122 + self.update_functions.len() as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | return 1_u64 << self.var_count() as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return 1_u64 << self.var_count() as u64; [INFO] [stdout] 127 + 1_u64 << self.var_count() as u64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return VariableIterator { remaining: self.var_count() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return VariableIterator { remaining: self.var_count() } [INFO] [stdout] 131 + VariableIterator { remaining: self.var_count() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | return StateIterator { state: 0, max_state: (self.state_count() - 1) as u32 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 - return StateIterator { state: 0, max_state: (self.state_count() - 1) as u32 } [INFO] [stdout] 136 + StateIterator { state: 0, max_state: (self.state_count() - 1) as u32 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return if *state | *variable == target { None } else { Some(*state ^ *variable) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return if *state | *variable == target { None } else { Some(*state ^ *variable) } [INFO] [stdout] 143 + if *state | *variable == target { None } else { Some(*state ^ *variable) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `StateId` which implements the `Copy` trait [INFO] [stdout] --> src/u32/bn.rs:142:75 [INFO] [stdout] | [INFO] [stdout] 142 | let target: bool = self.update_functions[variable.value as usize](state.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try dereferencing it: `*state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BooleanNetworkBuilder` [INFO] [stdout] --> src/u32/bn.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / pub fn new() -> BooleanNetworkBuilder { [INFO] [stdout] 152 | | return BooleanNetworkBuilder { [INFO] [stdout] 153 | | variable_count: 0, [INFO] [stdout] 154 | | variable_names: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 148 + impl Default for BooleanNetworkBuilder { [INFO] [stdout] 149 + fn default() -> Self { [INFO] [stdout] 150 + Self::new() [INFO] [stdout] 151 + } [INFO] [stdout] 152 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / return BooleanNetworkBuilder { [INFO] [stdout] 153 | | variable_count: 0, [INFO] [stdout] 154 | | variable_names: HashMap::new(), [INFO] [stdout] 155 | | update_functions: HashMap::new() [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 ~ BooleanNetworkBuilder { [INFO] [stdout] 153 + variable_count: 0, [INFO] [stdout] 154 + variable_names: HashMap::new(), [INFO] [stdout] 155 + update_functions: HashMap::new() [INFO] [stdout] 156 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return variable; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return variable; [INFO] [stdout] 169 + variable [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/u32/bn.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | for (_, existing) in &self.variable_names { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 165 - for (_, existing) in &self.variable_names { [INFO] [stdout] 165 + for existing in self.variable_names.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | / return BooleanNetwork { [INFO] [stdout] 195 | | update_functions: functions.into_iter().map(|(_, f)| f).collect() [INFO] [stdout] 196 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 ~ BooleanNetwork { [INFO] [stdout] 195 + update_functions: functions.into_iter().map(|(_, f)| f).collect() [INFO] [stdout] 196 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/bn.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | / return BooleanNetwork { [INFO] [stdout] 195 | | update_functions: functions.into_iter().map(|(_, f)| f).collect() [INFO] [stdout] 196 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 ~ BooleanNetwork { [INFO] [stdout] 195 + update_functions: functions.into_iter().map(|(_, f)| f).collect() [INFO] [stdout] 196 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/u32/bn.rs:191:28 [INFO] [stdout] | [INFO] [stdout] 191 | let mut functions: Vec<(VariableId, Box bool + Sync>)> = self.update_functions.drain().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/u32/bn.rs:191:28 [INFO] [stdout] | [INFO] [stdout] 191 | let mut functions: Vec<(VariableId, Box bool + Sync>)> = self.update_functions.drain().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return builder.build_network(); [INFO] [stdout] 176 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return builder.build_network(); [INFO] [stdout] 176 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 | | (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 - (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] 82 + !((s | erk_h) || (s | pi3kakt_h) || !(s | bcatenin_h) && !(s | ros_h)) [INFO] [stdout] | [INFO] [stdout] 82 - (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 - (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] 82 + ((s | ros_h) || (s | bcatenin_h)) && !(s | pi3kakt_h) && !(s | erk_h) [INFO] [stdout] | [INFO] [stdout] 82 - (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 - (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] 82 + (s | bcatenin_h) && !(s | erk_h) && !(s | pi3kakt_h) || !(s | erk_h) && !(s | pi3kakt_h) && (s | ros_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 | | (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 - (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 - (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] 86 + !((s | gfi1_h) || !(s | tlrs_h) && !(s | gcsf)) [INFO] [stdout] | [INFO] [stdout] 86 - (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 - (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] 86 + !(s | gfi1_h) && (s | tlrs_h) || !(s | gfi1_h) && (s | gcsf) [INFO] [stdout] | [INFO] [stdout] 86 - (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 - (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] 86 + ((s | gcsf) || (s | tlrs_h)) && !(s | gfi1_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 | | (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 93 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 93 + !((s | fox_o3a_h) || (s | pi3kakt_h) || !(s | ros_h) && !(s | tlrs_h)) || [INFO] [stdout] | [INFO] [stdout] 93 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 93 + !(s | fox_o3a_h) && !(s | pi3kakt_h) && (s | ros_h) || !(s | fox_o3a_h) && !(s | pi3kakt_h) && (s | tlrs_h) || [INFO] [stdout] | [INFO] [stdout] 93 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 93 + ((s | tlrs_h) || (s | ros_h)) && !(s | pi3kakt_h) && !(s | fox_o3a_h) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 | | (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 - (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 - (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] 82 + !((s | erk_h) || (s | pi3kakt_h) || !(s | bcatenin_h) && !(s | ros_h)) [INFO] [stdout] | [INFO] [stdout] 82 - (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 - (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] 82 + ((s | ros_h) || (s | bcatenin_h)) && !(s | pi3kakt_h) && !(s | erk_h) [INFO] [stdout] | [INFO] [stdout] 82 - (!(s | bcatenin_h)) && (!(s | erk_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 83 - (s | bcatenin_h) && (!(s | erk_h)) && (!(s | pi3kakt_h)) [INFO] [stdout] 82 + (s | bcatenin_h) && !(s | erk_h) && !(s | pi3kakt_h) || !(s | erk_h) && !(s | pi3kakt_h) && (s | ros_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 | | (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 - (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 - (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] 86 + !((s | gfi1_h) || !(s | tlrs_h) && !(s | gcsf)) [INFO] [stdout] | [INFO] [stdout] 86 - (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 - (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] 86 + !(s | gfi1_h) && (s | tlrs_h) || !(s | gfi1_h) && (s | gcsf) [INFO] [stdout] | [INFO] [stdout] 86 - (!(s | gfi1_h)) && (!(s | tlrs_h)) && (s | gcsf) || [INFO] [stdout] 87 - (!(s | gfi1_h)) && (s | tlrs_h) [INFO] [stdout] 86 + ((s | gcsf) || (s | tlrs_h)) && !(s | gfi1_h) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | / (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 | | (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 93 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 93 + !((s | fox_o3a_h) || (s | pi3kakt_h) || !(s | ros_h) && !(s | tlrs_h)) || [INFO] [stdout] | [INFO] [stdout] 93 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 93 + !(s | fox_o3a_h) && !(s | pi3kakt_h) && (s | ros_h) || !(s | fox_o3a_h) && !(s | pi3kakt_h) && (s | tlrs_h) || [INFO] [stdout] | [INFO] [stdout] 93 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (!(s | ros_h)) && (s | tlrs_h) || [INFO] [stdout] 94 - (!(s | fox_o3a_h)) && (!(s | pi3kakt_h)) && (s | ros_h) || [INFO] [stdout] 93 + ((s | tlrs_h) || (s | ros_h)) && !(s | pi3kakt_h) && !(s | fox_o3a_h) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 128 | | (s | ros_m) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 128 - (s | ros_m) [INFO] [stdout] 126 + !(!(s | ros_m) && !(s | tlrs_m) && !(s | gcsf)) [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 128 - (s | ros_m) [INFO] [stdout] 126 + (s | ros_m) || (s | tlrs_m) || (s | gcsf) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 126 + !((s | ros_m) || !(s | tlrs_m) && !(s | gcsf)) || [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 126 + !(s | ros_m) && (s | tlrs_m) || !(s | ros_m) && (s | gcsf) || [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 126 + ((s | gcsf) || (s | tlrs_m)) && !(s | ros_m) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 128 | | (s | ros_m) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 128 - (s | ros_m) [INFO] [stdout] 126 + !(!(s | ros_m) && !(s | tlrs_m) && !(s | gcsf)) [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 128 - (s | ros_m) [INFO] [stdout] 126 + (s | ros_m) || (s | tlrs_m) || (s | gcsf) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 126 + !((s | ros_m) || !(s | tlrs_m) && !(s | gcsf)) || [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 126 + !(s | ros_m) && (s | tlrs_m) || !(s | ros_m) && (s | gcsf) || [INFO] [stdout] | [INFO] [stdout] 126 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 127 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 126 + ((s | gcsf) || (s | tlrs_m)) && !(s | ros_m) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | / (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 | | (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 131 - (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 - (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] 131 + !((s | erk_m) || (s | pi3kakt_m) || !(s | bcatenin_m) && !(s | ros_m)) [INFO] [stdout] | [INFO] [stdout] 131 - (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 - (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] 131 + ((s | ros_m) || (s | bcatenin_m)) && !(s | pi3kakt_m) && !(s | erk_m) [INFO] [stdout] | [INFO] [stdout] 131 - (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 - (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] 131 + (s | bcatenin_m) && !(s | erk_m) && !(s | pi3kakt_m) || !(s | erk_m) && (s | ros_m) && !(s | pi3kakt_m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | / (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 | | (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 131 - (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 - (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] 131 + !((s | erk_m) || (s | pi3kakt_m) || !(s | bcatenin_m) && !(s | ros_m)) [INFO] [stdout] | [INFO] [stdout] 131 - (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 - (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] 131 + ((s | ros_m) || (s | bcatenin_m)) && !(s | pi3kakt_m) && !(s | erk_m) [INFO] [stdout] | [INFO] [stdout] 131 - (!(s | bcatenin_m)) && (!(s | erk_m)) && (s | ros_m) && (!(s | pi3kakt_m)) || [INFO] [stdout] 132 - (s | bcatenin_m) && (!(s | erk_m)) && (!(s | pi3kakt_m)) [INFO] [stdout] 131 + (s | bcatenin_m) && !(s | erk_m) && !(s | pi3kakt_m) || !(s | erk_m) && (s | ros_m) && !(s | pi3kakt_m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 152 | | (s | ros_m) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 152 - (s | ros_m) [INFO] [stdout] 150 + !(!(s | ros_m) && !(s | tlrs_m) && !(s | gcsf)) [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 152 - (s | ros_m) [INFO] [stdout] 150 + (s | ros_m) || (s | tlrs_m) || (s | gcsf) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 152 | | (s | ros_m) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 152 - (s | ros_m) [INFO] [stdout] 150 + !(!(s | ros_m) && !(s | tlrs_m) && !(s | gcsf)) [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 152 - (s | ros_m) [INFO] [stdout] 150 + (s | ros_m) || (s | tlrs_m) || (s | gcsf) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 150 + !((s | ros_m) || !(s | tlrs_m) && !(s | gcsf)) || [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 150 + !(s | ros_m) && (s | tlrs_m) || !(s | ros_m) && (s | gcsf) || [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 150 + ((s | gcsf) || (s | tlrs_m)) && !(s | ros_m) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / (!(s | bcatenin_m)) || [INFO] [stdout] 159 | | (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] 160 | | (s | bcatenin_m) && (s | nfk_b_m) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - (!(s | bcatenin_m)) || [INFO] [stdout] 159 - (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] 160 - (s | bcatenin_m) && (s | nfk_b_m) [INFO] [stdout] 158 + !((s | bcatenin_m) && !(s | nfk_b_m) && !(s | pi3kakt_m)) [INFO] [stdout] | [INFO] [stdout] 158 - (!(s | bcatenin_m)) || [INFO] [stdout] 159 - (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] 160 - (s | bcatenin_m) && (s | nfk_b_m) [INFO] [stdout] 158 + !(s | bcatenin_m) || (s | nfk_b_m) || (s | pi3kakt_m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / (!(s | bcatenin_m)) || [INFO] [stdout] 159 | | (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] | |_______________________________________________________________^ help: try: `!(s | bcatenin_m) || !(s | nfk_b_m) && (s | pi3kakt_m)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | / (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 | | (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 150 + !((s | ros_m) || !(s | tlrs_m) && !(s | gcsf)) || [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 150 + !(s | ros_m) && (s | tlrs_m) || !(s | ros_m) && (s | gcsf) || [INFO] [stdout] | [INFO] [stdout] 150 - (!(s | ros_m)) && (!(s | tlrs_m)) && (s | gcsf) || [INFO] [stdout] 151 - (!(s | ros_m)) && (s | tlrs_m) || [INFO] [stdout] 150 + ((s | gcsf) || (s | tlrs_m)) && !(s | ros_m) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / (!(s | bcatenin_m)) || [INFO] [stdout] 159 | | (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] 160 | | (s | bcatenin_m) && (s | nfk_b_m) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 158 - (!(s | bcatenin_m)) || [INFO] [stdout] 159 - (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] 160 - (s | bcatenin_m) && (s | nfk_b_m) [INFO] [stdout] 158 + !((s | bcatenin_m) && !(s | nfk_b_m) && !(s | pi3kakt_m)) [INFO] [stdout] | [INFO] [stdout] 158 - (!(s | bcatenin_m)) || [INFO] [stdout] 159 - (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] 160 - (s | bcatenin_m) && (s | nfk_b_m) [INFO] [stdout] 158 + !(s | bcatenin_m) || (s | nfk_b_m) || (s | pi3kakt_m) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | / (!(s | bcatenin_m)) || [INFO] [stdout] 159 | | (s | bcatenin_m) && (!(s | nfk_b_m)) && (s | pi3kakt_m) || [INFO] [stdout] | |_______________________________________________________________^ help: try: `!(s | bcatenin_m) || !(s | nfk_b_m) && (s | pi3kakt_m)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:326:5 [INFO] [stdout] | [INFO] [stdout] 326 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 326 - return builder.build_network(); [INFO] [stdout] 326 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:326:5 [INFO] [stdout] | [INFO] [stdout] 326 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 326 - return builder.build_network(); [INFO] [stdout] 326 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | (!(s | p16)) && (s | p21) && (s | m_torc1_s6k1) || (s | p16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 224 - (!(s | p16)) && (s | p21) && (s | m_torc1_s6k1) || (s | p16) [INFO] [stdout] 224 + ((s | m_torc1_s6k1) || (s | p16)) && ((s | p21) || (s | p16)) [INFO] [stdout] | [INFO] [stdout] 224 - (!(s | p16)) && (s | p21) && (s | m_torc1_s6k1) || (s | p16) [INFO] [stdout] 224 + (s | p16) || (s | p21) && (s | m_torc1_s6k1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | (!(s | p16)) && (s | p21) && (s | m_torc1_s6k1) || (s | p16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 224 - (!(s | p16)) && (s | p21) && (s | m_torc1_s6k1) || (s | p16) [INFO] [stdout] 224 + ((s | m_torc1_s6k1) || (s | p16)) && ((s | p21) || (s | p16)) [INFO] [stdout] | [INFO] [stdout] 224 - (!(s | p16)) && (s | p21) && (s | m_torc1_s6k1) || (s | p16) [INFO] [stdout] 224 + (s | p16) || (s | p21) && (s | m_torc1_s6k1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | / ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 | | ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 250 - ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 - ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] 250 + !((s | akt) || (s | myc) || !(s | p53) && !(s | foxo)) [INFO] [stdout] | [INFO] [stdout] 250 - ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 - ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] 250 + ((s | foxo) || (s | p53)) && !(s | myc) && !(s | akt) [INFO] [stdout] | [INFO] [stdout] 250 - ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 - ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] 250 + (s | p53) && !(s | akt) && !(s | myc) || !(s | akt) && !(s | myc) && (s | foxo) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | / ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 | | ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 255 - ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 - ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] 255 + !((s | pten) || (s | pp2a) || !(s | irs_pik3ca) && !(s | cdk2)) [INFO] [stdout] | [INFO] [stdout] 255 - ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 - ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] 255 + ((s | cdk2) || (s | irs_pik3ca)) && !(s | pp2a) && !(s | pten) [INFO] [stdout] | [INFO] [stdout] 255 - ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 - ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] 255 + (s | irs_pik3ca) && !(s | pten) && !(s | pp2a) || !(s | pten) && (s | cdk2) && !(s | pp2a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | / ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 | | ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 250 - ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 - ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] 250 + !((s | akt) || (s | myc) || !(s | p53) && !(s | foxo)) [INFO] [stdout] | [INFO] [stdout] 250 - ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 - ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] 250 + ((s | foxo) || (s | p53)) && !(s | myc) && !(s | akt) [INFO] [stdout] | [INFO] [stdout] 250 - ((!(s | p53)) && (!(s | akt)) && (!(s | myc)) && (s | foxo)) || [INFO] [stdout] 251 - ((s | p53) && (!(s | akt)) && (!(s | myc))) [INFO] [stdout] 250 + (s | p53) && !(s | akt) && !(s | myc) || !(s | akt) && !(s | myc) && (s | foxo) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | / ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 | | ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 255 - ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 - ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] 255 + !((s | pten) || (s | pp2a) || !(s | irs_pik3ca) && !(s | cdk2)) [INFO] [stdout] | [INFO] [stdout] 255 - ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 - ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] 255 + ((s | cdk2) || (s | irs_pik3ca)) && !(s | pp2a) && !(s | pten) [INFO] [stdout] | [INFO] [stdout] 255 - ((!(s | irs_pik3ca)) && (!(s | pten)) && (s | cdk2) && (!(s | pp2a))) || [INFO] [stdout] 256 - ((s | irs_pik3ca) && (!(s | pten)) && (!(s | pp2a))) [INFO] [stdout] 255 + (s | irs_pik3ca) && !(s | pten) && !(s | pp2a) || !(s | pten) && (s | cdk2) && !(s | pp2a) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 | | ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 288 - ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 - ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] 288 + !((s | p21) || !(s | m_torc1_s6k1) || !(s | myc) && !(s | e2f1)) [INFO] [stdout] | [INFO] [stdout] 288 - ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 - ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] 288 + !(s | p21) && (s | m_torc1_s6k1) && (s | myc) || !(s | p21) && (s | m_torc1_s6k1) && (s | e2f1) [INFO] [stdout] | [INFO] [stdout] 288 - ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 - ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] 288 + ((s | e2f1) || (s | myc)) && (s | m_torc1_s6k1) && !(s | p21) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 | | ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 288 - ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 - ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] 288 + !((s | p21) || !(s | m_torc1_s6k1) || !(s | myc) && !(s | e2f1)) [INFO] [stdout] | [INFO] [stdout] 288 - ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 - ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] 288 + !(s | p21) && (s | m_torc1_s6k1) && (s | myc) || !(s | p21) && (s | m_torc1_s6k1) && (s | e2f1) [INFO] [stdout] | [INFO] [stdout] 288 - ((!(s | p21)) && (s | m_torc1_s6k1) && (!(s | myc)) && (s | e2f1)) || [INFO] [stdout] 289 - ((!(s | p21)) && (s | m_torc1_s6k1) && (s | myc)) [INFO] [stdout] 288 + ((s | e2f1) || (s | myc)) && (s | m_torc1_s6k1) && !(s | p21) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 297 | / ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 | | ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 297 - ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 - ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] 297 + !((s | p_rb) || !(s | e2f1) || !(s | gf) && !(s | myc)) [INFO] [stdout] | [INFO] [stdout] 297 - ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 - ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] 297 + ((s | myc) || (s | gf)) && (s | e2f1) && !(s | p_rb) [INFO] [stdout] | [INFO] [stdout] 297 - ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 - ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] 297 + (s | gf) && !(s | p_rb) && (s | e2f1) || (s | myc) && !(s | p_rb) && (s | e2f1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 297 | / ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 | | ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 297 - ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 - ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] 297 + !((s | p_rb) || !(s | e2f1) || !(s | gf) && !(s | myc)) [INFO] [stdout] | [INFO] [stdout] 297 - ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 - ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] 297 + ((s | myc) || (s | gf)) && (s | e2f1) && !(s | p_rb) [INFO] [stdout] | [INFO] [stdout] 297 - ((!(s | gf)) && (s | myc) && (!(s | p_rb)) && (s | e2f1)) || [INFO] [stdout] 298 - ((s | gf) && (!(s | p_rb)) && (s | e2f1)) [INFO] [stdout] 297 + (s | gf) && !(s | p_rb) && (s | e2f1) || (s | myc) && !(s | p_rb) && (s | e2f1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | / ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 | | ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 306 - ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 - ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] 306 + !((s | mapk) || !(s | m_torc1_s6k1) || !(s | akt) && !(s | pp1c)) || [INFO] [stdout] | [INFO] [stdout] 306 - ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 - ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] 306 + !(s | mapk) && (s | akt) && (s | m_torc1_s6k1) || !(s | mapk) && (s | m_torc1_s6k1) && (s | pp1c) || [INFO] [stdout] | [INFO] [stdout] 306 - ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 - ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] 306 + ((s | pp1c) || (s | akt)) && (s | m_torc1_s6k1) && !(s | mapk) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 306 | / ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 | | ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 306 - ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 - ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] 306 + !((s | mapk) || !(s | m_torc1_s6k1) || !(s | akt) && !(s | pp1c)) || [INFO] [stdout] | [INFO] [stdout] 306 - ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 - ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] 306 + !(s | mapk) && (s | akt) && (s | m_torc1_s6k1) || !(s | mapk) && (s | m_torc1_s6k1) && (s | pp1c) || [INFO] [stdout] | [INFO] [stdout] 306 - ((!(s | mapk)) && (!(s | akt)) && (s | m_torc1_s6k1) && (s | pp1c)) || [INFO] [stdout] 307 - ((!(s | mapk)) && (s | akt) && (s | m_torc1_s6k1)) || [INFO] [stdout] 306 + ((s | pp1c) || (s | akt)) && (s | m_torc1_s6k1) && !(s | mapk) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | ((!(s | mapk)) && (s | akt)) || (s | mapk) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 323 - ((!(s | mapk)) && (s | akt)) || (s | mapk) [INFO] [stdout] 323 + !(!(s | mapk) && !(s | akt)) [INFO] [stdout] | [INFO] [stdout] 323 - ((!(s | mapk)) && (s | akt)) || (s | mapk) [INFO] [stdout] 323 + (s | mapk) || (s | akt) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:323:9 [INFO] [stdout] | [INFO] [stdout] 323 | ((!(s | mapk)) && (s | akt)) || (s | mapk) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 323 - ((!(s | mapk)) && (s | akt)) || (s | mapk) [INFO] [stdout] 323 + !(!(s | mapk) && !(s | akt)) [INFO] [stdout] | [INFO] [stdout] 323 - ((!(s | mapk)) && (s | akt)) || (s | mapk) [INFO] [stdout] 323 + (s | mapk) || (s | akt) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 449 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return builder.build_network(); [INFO] [stdout] 449 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 449 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 449 - return builder.build_network(); [INFO] [stdout] 449 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | / ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 | | ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 372 - ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 - ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] 372 + !(!(s | eralpha) || !(s | myc) || !(s | mek1) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 372 - ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 - ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] 372 + ((s | akt1) || (s | mek1)) && (s | myc) && (s | eralpha) [INFO] [stdout] | [INFO] [stdout] 372 - ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 - ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] 372 + (s | mek1) && (s | eralpha) && (s | myc) || (s | eralpha) && (s | akt1) && (s | myc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | / ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 | | ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 372 - ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 - ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] 372 + !(!(s | eralpha) || !(s | myc) || !(s | mek1) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 372 - ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 - ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] 372 + ((s | akt1) || (s | mek1)) && (s | myc) && (s | eralpha) [INFO] [stdout] | [INFO] [stdout] 372 - ((!(s | mek1)) && (s | eralpha) && (s | akt1) && (s | myc)) || [INFO] [stdout] 373 - ((s | mek1) && (s | eralpha) && (s | myc)) [INFO] [stdout] 372 + (s | mek1) && (s | eralpha) && (s | myc) || (s | eralpha) && (s | akt1) && (s | myc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | / ((!(s | mek1)) && (s | akt1)) || [INFO] [stdout] 394 | | (s | mek1) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 393 - ((!(s | mek1)) && (s | akt1)) || [INFO] [stdout] 394 - (s | mek1) [INFO] [stdout] 393 + !(!(s | mek1) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 393 - ((!(s | mek1)) && (s | akt1)) || [INFO] [stdout] 394 - (s | mek1) [INFO] [stdout] 393 + (s | mek1) || (s | akt1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 393 | / ((!(s | mek1)) && (s | akt1)) || [INFO] [stdout] 394 | | (s | mek1) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 393 - ((!(s | mek1)) && (s | akt1)) || [INFO] [stdout] 394 - (s | mek1) [INFO] [stdout] 393 + !(!(s | mek1) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 393 - ((!(s | mek1)) && (s | akt1)) || [INFO] [stdout] 394 - (s | mek1) [INFO] [stdout] 393 + (s | mek1) || (s | akt1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | / ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 | | ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 412 | | (s | mek1) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 412 - (s | mek1) [INFO] [stdout] 410 + !(!(s | mek1) && !(s | eralpha) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 412 - (s | mek1) [INFO] [stdout] 410 + (s | mek1) || (s | eralpha) || (s | akt1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | / ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 | | ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 410 + !((s | mek1) || !(s | eralpha) && !(s | akt1)) || [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 410 + !(s | mek1) && (s | eralpha) || !(s | mek1) && (s | akt1) || [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 410 + ((s | akt1) || (s | eralpha)) && !(s | mek1) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:416:9 [INFO] [stdout] | [INFO] [stdout] 416 | / ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 | | ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 416 - ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 - ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] 416 + !((s | erbb2_3) || !(s | eralpha) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 416 - ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 - ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] 416 + ((s | akt1) || (s | eralpha)) && !(s | erbb2_3) [INFO] [stdout] | [INFO] [stdout] 416 - ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 - ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] 416 + (s | eralpha) && !(s | erbb2_3) || (s | akt1) && !(s | erbb2_3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | / ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 | | ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 412 | | (s | mek1) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 412 - (s | mek1) [INFO] [stdout] 410 + !(!(s | mek1) && !(s | eralpha) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 412 - (s | mek1) [INFO] [stdout] 410 + (s | mek1) || (s | eralpha) || (s | akt1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | / ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 | | ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 410 + !((s | mek1) || !(s | eralpha) && !(s | akt1)) || [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 410 + !(s | mek1) && (s | eralpha) || !(s | mek1) && (s | akt1) || [INFO] [stdout] | [INFO] [stdout] 410 - ((!(s | mek1)) && (!(s | eralpha)) && (s | akt1)) || [INFO] [stdout] 411 - ((!(s | mek1)) && (s | eralpha)) || [INFO] [stdout] 410 + ((s | akt1) || (s | eralpha)) && !(s | mek1) || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:416:9 [INFO] [stdout] | [INFO] [stdout] 416 | / ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 | | ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 416 - ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 - ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] 416 + !((s | erbb2_3) || !(s | eralpha) && !(s | akt1)) [INFO] [stdout] | [INFO] [stdout] 416 - ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 - ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] 416 + ((s | akt1) || (s | eralpha)) && !(s | erbb2_3) [INFO] [stdout] | [INFO] [stdout] 416 - ((!(s | eralpha)) && (s | akt1) && (!(s | erbb2_3))) || [INFO] [stdout] 417 - ((s | eralpha) && (!(s | erbb2_3))) [INFO] [stdout] 416 + (s | eralpha) && !(s | erbb2_3) || (s | akt1) && !(s | erbb2_3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:472:5 [INFO] [stdout] | [INFO] [stdout] 472 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 472 - return builder.build_network(); [INFO] [stdout] 472 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:472:5 [INFO] [stdout] | [INFO] [stdout] 472 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 472 - return builder.build_network(); [INFO] [stdout] 472 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:469:9 [INFO] [stdout] | [INFO] [stdout] 469 | (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 469 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 469 + (!(s | p53) || (s | m2c)) && (!(s | dna) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] 469 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 469 + (s | m2c) || !(s | dna) && !(s | p53) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:494:5 [INFO] [stdout] | [INFO] [stdout] 494 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 494 - return builder.build_network(); [INFO] [stdout] 494 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:469:9 [INFO] [stdout] | [INFO] [stdout] 469 | (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 469 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 469 + (!(s | p53) || (s | m2c)) && (!(s | dna) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] 469 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 469 + (s | m2c) || !(s | dna) && !(s | p53) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:494:5 [INFO] [stdout] | [INFO] [stdout] 494 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 494 - return builder.build_network(); [INFO] [stdout] 494 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 491 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 491 + (!(s | p53) || (s | m2c)) && (!(s | dna) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] 491 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 491 + (s | m2c) || !(s | dna) && !(s | p53) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:516:5 [INFO] [stdout] | [INFO] [stdout] 516 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 516 - return builder.build_network(); [INFO] [stdout] 516 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 491 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 491 + (!(s | p53) || (s | m2c)) && (!(s | dna) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] 491 - (s | m2c) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 491 + (s | m2c) || !(s | dna) && !(s | p53) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:516:5 [INFO] [stdout] | [INFO] [stdout] 516 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 516 - return builder.build_network(); [INFO] [stdout] 516 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 513 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] 513 + !(!(s | m2c) && (s | p53) || (s | dna) && (s | p53)) [INFO] [stdout] | [INFO] [stdout] 513 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] 513 + !(s | p53) || (s | m2c) && !(s | dna) [INFO] [stdout] | [INFO] [stdout] 513 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] 513 + (!(s | p53) || !(s | dna)) && (!(s | p53) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:538:5 [INFO] [stdout] | [INFO] [stdout] 538 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return builder.build_network(); [INFO] [stdout] 538 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 513 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] 513 + !(!(s | m2c) && (s | p53) || (s | dna) && (s | p53)) [INFO] [stdout] | [INFO] [stdout] 513 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] 513 + !(s | p53) || (s | m2c) && !(s | dna) [INFO] [stdout] | [INFO] [stdout] 513 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | p53)) [INFO] [stdout] 513 + (!(s | p53) || !(s | dna)) && (!(s | p53) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 535 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 535 + (!(s | p53) || !(s | dna)) && (!(s | p53) || (s | m2c)) && (!(s | dna) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] 535 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 535 + (s | m2c) && !(s | dna) || (s | m2c) && !(s | p53) || !(s | dna) && !(s | p53) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/models.rs:538:5 [INFO] [stdout] | [INFO] [stdout] 538 | return builder.build_network(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return builder.build_network(); [INFO] [stdout] 538 + builder.build_network() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/u32/sequential.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | pub const FRESH: u32 = std::u32::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - pub const FRESH: u32 = std::u32::MAX; [INFO] [stdout] 17 + pub const FRESH: u32 = u32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/u32/sequential.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | pub const DEAD: u32 = std::u32::MAX - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 18 - pub const DEAD: u32 = std::u32::MAX - 1; [INFO] [stdout] 18 + pub const DEAD: u32 = u32::MAX - 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/u32/models.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 535 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 535 + (!(s | p53) || !(s | dna)) && (!(s | p53) || (s | m2c)) && (!(s | dna) || (s | m2c)) [INFO] [stdout] | [INFO] [stdout] 535 - ((s | m2c) && (!(s | dna) || !(s | p53))) || (!(s | m2c) && !(s | dna) && !(s | p53)) [INFO] [stdout] 535 + (s | m2c) && !(s | dna) || (s | m2c) && !(s | p53) || !(s | dna) && !(s | p53) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/u32/sequential.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | pub const FRESH: u32 = std::u32::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - pub const FRESH: u32 = std::u32::MAX; [INFO] [stdout] 17 + pub const FRESH: u32 = u32::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/u32/sequential.rs:18:23 [INFO] [stdout] | [INFO] [stdout] 18 | pub const DEAD: u32 = std::u32::MAX - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 18 - pub const DEAD: u32 = std::u32::MAX - 1; [INFO] [stdout] 18 + pub const DEAD: u32 = u32::MAX - 1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/sequential.rs:39:52 [INFO] [stdout] | [INFO] [stdout] 39 | if let Some(t) = network.successor(&s, &var) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/sequential.rs:39:52 [INFO] [stdout] | [INFO] [stdout] 39 | if let Some(t) = network.successor(&s, &var) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/sequential.rs:98:52 [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(t) = network.successor(&s, &var) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/sequential.rs:98:52 [INFO] [stdout] | [INFO] [stdout] 98 | if let Some(t) = network.successor(&s, &var) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | / return DisjointSets { [INFO] [stdout] 162 | | // hash mask is used for hashing state ids in order to implement Tarjan merge condition [INFO] [stdout] 163 | | hash_mask: rnd.next_u64() as usize, [INFO] [stdout] ... | [INFO] [stdout] 167 | | parent_pointer: vec![FRESH; capacity] [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 ~ DisjointSets { [INFO] [stdout] 162 + // hash mask is used for hashing state ids in order to implement Tarjan merge condition [INFO] [stdout] 163 + hash_mask: rnd.next_u64() as usize, [INFO] [stdout] 164 + // initially, every element is in a separate set, hence it is a root [INFO] [stdout] 165 + is_root: BitSet::new_full(capacity), [INFO] [stdout] 166 + // since initially everything is root, parent pointers store the extra u32 value initialized to 0 [INFO] [stdout] 167 + parent_pointer: vec![FRESH; capacity] [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return self.is_root.is_set(key.value as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return self.is_root.is_set(key.value as usize) [INFO] [stdout] 172 + self.is_root.is_set(key.value as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return item [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return item [INFO] [stdout] 189 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return self.parent_pointer[root]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return self.parent_pointer[root]; [INFO] [stdout] 195 + self.parent_pointer[root] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | / return DisjointSets { [INFO] [stdout] 162 | | // hash mask is used for hashing state ids in order to implement Tarjan merge condition [INFO] [stdout] 163 | | hash_mask: rnd.next_u64() as usize, [INFO] [stdout] ... | [INFO] [stdout] 167 | | parent_pointer: vec![FRESH; capacity] [INFO] [stdout] 168 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 ~ DisjointSets { [INFO] [stdout] 162 + // hash mask is used for hashing state ids in order to implement Tarjan merge condition [INFO] [stdout] 163 + hash_mask: rnd.next_u64() as usize, [INFO] [stdout] 164 + // initially, every element is in a separate set, hence it is a root [INFO] [stdout] 165 + is_root: BitSet::new_full(capacity), [INFO] [stdout] 166 + // since initially everything is root, parent pointers store the extra u32 value initialized to 0 [INFO] [stdout] 167 + parent_pointer: vec![FRESH; capacity] [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return self.is_root.is_set(key.value as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return self.is_root.is_set(key.value as usize) [INFO] [stdout] 172 + self.is_root.is_set(key.value as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return item [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return item [INFO] [stdout] 189 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/sequential.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | return self.parent_pointer[root]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return self.parent_pointer[root]; [INFO] [stdout] 195 + self.parent_pointer[root] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/parallel.rs:49:62 [INFO] [stdout] | [INFO] [stdout] 49 | let set_of_s = global_sets.find_root(&s); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/parallel.rs:55:68 [INFO] [stdout] | [INFO] [stdout] 55 | ... if let Some(t) = network.successor(&s, &var) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/parallel.rs:49:62 [INFO] [stdout] | [INFO] [stdout] 49 | let set_of_s = global_sets.find_root(&s); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/parallel.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / return AtomicDisjointSets { [INFO] [stdout] 144 | | hash_mask: rnd.next_u64() as usize, [INFO] [stdout] 145 | | parent_pointer: (0..capacity).map(|s| AtomicU32::new(s as u32)).collect() [INFO] [stdout] 146 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ AtomicDisjointSets { [INFO] [stdout] 144 + hash_mask: rnd.next_u64() as usize, [INFO] [stdout] 145 + parent_pointer: (0..capacity).map(|s| AtomicU32::new(s as u32)).collect() [INFO] [stdout] 146 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/u32/parallel.rs:55:68 [INFO] [stdout] | [INFO] [stdout] 55 | ... if let Some(t) = network.successor(&s, &var) { [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/parallel.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return self.find_root_by_index(key.value as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return self.find_root_by_index(key.value as usize) [INFO] [stdout] 154 + self.find_root_by_index(key.value as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/parallel.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | return item [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return item [INFO] [stdout] 174 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/parallel.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | / return AtomicDisjointSets { [INFO] [stdout] 144 | | hash_mask: rnd.next_u64() as usize, [INFO] [stdout] 145 | | parent_pointer: (0..capacity).map(|s| AtomicU32::new(s as u32)).collect() [INFO] [stdout] 146 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ AtomicDisjointSets { [INFO] [stdout] 144 + hash_mask: rnd.next_u64() as usize, [INFO] [stdout] 145 + parent_pointer: (0..capacity).map(|s| AtomicU32::new(s as u32)).collect() [INFO] [stdout] 146 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/dot_printer.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Result::Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Result::Ok(()); [INFO] [stdout] 41 + Result::Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/parallel.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return self.find_root_by_index(key.value as usize) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return self.find_root_by_index(key.value as usize) [INFO] [stdout] 154 + self.find_root_by_index(key.value as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/u32/parallel.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | return item [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return item [INFO] [stdout] 174 + item [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bdd/dot_printer.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | var_names: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - var_names: &Vec, [INFO] [stdout] 12 + var_names: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/dot_printer.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return Result::Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Result::Ok(()); [INFO] [stdout] 41 + Result::Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bdd/dot_printer.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | var_names: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 12 - var_names: &Vec, [INFO] [stdout] 12 + var_names: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return BDDNode { var: vars, low: 1, high: 1 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return BDDNode { var: vars, low: 1, high: 1 } [INFO] [stdout] 26 + BDDNode { var: vars, low: 1, high: 1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return BDDNode { var: vars, low: 0, high: 0 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return BDDNode { var: vars, low: 0, high: 0 } [INFO] [stdout] 31 + BDDNode { var: vars, low: 0, high: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return self.low == self.high && (self.low == 1 || self.low == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return self.low == self.high && (self.low == 1 || self.low == 0) [INFO] [stdout] 40 + self.low == self.high && (self.low == 1 || self.low == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return self.is_terminal() && self.low == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return self.is_terminal() && self.low == 1 [INFO] [stdout] 45 + self.is_terminal() && self.low == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self.is_terminal() && self.low == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self.is_terminal() && self.low == 0 [INFO] [stdout] 50 + self.is_terminal() && self.low == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return self.0.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.0.len(); [INFO] [stdout] 77 + self.0.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return self.0.len() - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self.0.len() - 1; [INFO] [stdout] 82 + self.0.len() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return BDDNode { var: vars, low: 1, high: 1 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return BDDNode { var: vars, low: 1, high: 1 } [INFO] [stdout] 26 + BDDNode { var: vars, low: 1, high: 1 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return self.0[node_index].var as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return self.0[node_index].var as usize; [INFO] [stdout] 87 + self.0[node_index].var as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return BDDNode { var: vars, low: 0, high: 0 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return BDDNode { var: vars, low: 0, high: 0 } [INFO] [stdout] 31 + BDDNode { var: vars, low: 0, high: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return self.0[node_index].high as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return self.0[node_index].high as usize; [INFO] [stdout] 92 + self.0[node_index].high as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return self.low == self.high && (self.low == 1 || self.low == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return self.low == self.high && (self.low == 1 || self.low == 0) [INFO] [stdout] 40 + self.low == self.high && (self.low == 1 || self.low == 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self.0[node_index].low as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self.0[node_index].low as usize; [INFO] [stdout] 97 + self.0[node_index].low as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | return self.is_terminal() && self.low == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - return self.is_terminal() && self.low == 1 [INFO] [stdout] 45 + self.is_terminal() && self.low == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return self.0[0].var; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return self.0[0].var; [INFO] [stdout] 102 + self.0[0].var [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | return self.is_terminal() && self.low == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 - return self.is_terminal() && self.low == 0 [INFO] [stdout] 50 + self.is_terminal() && self.low == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / return BDDWorker { [INFO] [stdout] 127 | | num_vars: variables.len() as u32, [INFO] [stdout] 128 | | var_names: variables, [INFO] [stdout] 129 | | var_index_mapping [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 ~ BDDWorker { [INFO] [stdout] 127 + num_vars: variables.len() as u32, [INFO] [stdout] 128 + var_names: variables, [INFO] [stdout] 129 + var_index_mapping [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `var_index` is used to index `variables` [INFO] [stdout] --> src/bdd/mod.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | for var_index in 0..variables.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 123 - for var_index in 0..variables.len() { [INFO] [stdout] 123 + for (var_index, ) in variables.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return self.0.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return self.0.len(); [INFO] [stdout] 77 + self.0.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return self.0.len() - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self.0.len() - 1; [INFO] [stdout] 82 + self.0.len() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return self.0[node_index].var as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return self.0[node_index].var as usize; [INFO] [stdout] 87 + self.0[node_index].var as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return BDDWorker::new((0..num_vars).map(|x| x.to_string()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return BDDWorker::new((0..num_vars).map(|x| x.to_string()).collect()) [INFO] [stdout] 135 + BDDWorker::new((0..num_vars).map(|x| x.to_string()).collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return self.0[node_index].high as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return self.0[node_index].high as usize; [INFO] [stdout] 92 + self.0[node_index].high as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return BDDNode::mk_zero(self.num_vars) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return BDDNode::mk_zero(self.num_vars) [INFO] [stdout] 139 + BDDNode::mk_zero(self.num_vars) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | return self.0[node_index].low as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return self.0[node_index].low as usize; [INFO] [stdout] 97 + self.0[node_index].low as usize [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return BDDNode::mk_one(self.num_vars) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return BDDNode::mk_one(self.num_vars) [INFO] [stdout] 143 + BDDNode::mk_one(self.num_vars) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return self.0[0].var; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return self.0[0].var; [INFO] [stdout] 102 + self.0[0].var [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return BDD(vec![self.mk_zero_node()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return BDD(vec![self.mk_zero_node()]) [INFO] [stdout] 148 + BDD(vec![self.mk_zero_node()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | return BDD(vec![self.mk_zero_node(), self.mk_one_node()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - return BDD(vec![self.mk_zero_node(), self.mk_one_node()]) [INFO] [stdout] 153 + BDD(vec![self.mk_zero_node(), self.mk_one_node()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | / return BDDWorker { [INFO] [stdout] 127 | | num_vars: variables.len() as u32, [INFO] [stdout] 128 | | var_names: variables, [INFO] [stdout] 129 | | var_index_mapping [INFO] [stdout] 130 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 ~ BDDWorker { [INFO] [stdout] 127 + num_vars: variables.len() as u32, [INFO] [stdout] 128 + var_names: variables, [INFO] [stdout] 129 + var_index_mapping [INFO] [stdout] 130 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `var_index` is used to index `variables` [INFO] [stdout] --> src/bdd/mod.rs:123:26 [INFO] [stdout] | [INFO] [stdout] 123 | for var_index in 0..variables.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 123 - for var_index in 0..variables.len() { [INFO] [stdout] 123 + for (var_index, ) in variables.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | return BDDWorker::new((0..num_vars).map(|x| x.to_string()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return BDDWorker::new((0..num_vars).map(|x| x.to_string()).collect()) [INFO] [stdout] 135 + BDDWorker::new((0..num_vars).map(|x| x.to_string()).collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / return if var_index >= self.num_vars { [INFO] [stdout] 168 | | self.var_index_out_of_bounds(var_index) [INFO] [stdout] 169 | | } else { [INFO] [stdout] 170 | | BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] ... | [INFO] [stdout] 173 | | }]) [INFO] [stdout] 174 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 ~ if var_index >= self.num_vars { [INFO] [stdout] 168 + self.var_index_out_of_bounds(var_index) [INFO] [stdout] 169 + } else { [INFO] [stdout] 170 + BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] 171 + var: var_index, [INFO] [stdout] 172 + low: 0, high: 1 [INFO] [stdout] 173 + }]) [INFO] [stdout] 174 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | return BDDNode::mk_zero(self.num_vars) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return BDDNode::mk_zero(self.num_vars) [INFO] [stdout] 139 + BDDNode::mk_zero(self.num_vars) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return BDDNode::mk_one(self.num_vars) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return BDDNode::mk_one(self.num_vars) [INFO] [stdout] 143 + BDDNode::mk_one(self.num_vars) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | / return if var_index >= self.num_vars { [INFO] [stdout] 181 | | self.var_index_out_of_bounds(var_index) [INFO] [stdout] 182 | | } else { [INFO] [stdout] 183 | | BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] ... | [INFO] [stdout] 186 | | }]) [INFO] [stdout] 187 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 ~ if var_index >= self.num_vars { [INFO] [stdout] 181 + self.var_index_out_of_bounds(var_index) [INFO] [stdout] 182 + } else { [INFO] [stdout] 183 + BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] 184 + var: var_index, [INFO] [stdout] 185 + low: 0, high: 1 [INFO] [stdout] 186 + }]) [INFO] [stdout] 187 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return BDD(vec![self.mk_zero_node()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return BDD(vec![self.mk_zero_node()]) [INFO] [stdout] 148 + BDD(vec![self.mk_zero_node()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | / return match self.var_index_mapping.get(var_name) { [INFO] [stdout] 194 | | None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 195 | | Some(index) => self.mk_var(*index), [INFO] [stdout] 196 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 ~ match self.var_index_mapping.get(var_name) { [INFO] [stdout] 194 + None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 195 + Some(index) => self.mk_var(*index), [INFO] [stdout] 196 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | return BDD(vec![self.mk_zero_node(), self.mk_one_node()]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - return BDD(vec![self.mk_zero_node(), self.mk_one_node()]) [INFO] [stdout] 153 + BDD(vec![self.mk_zero_node(), self.mk_one_node()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | / return match self.var_index_mapping.get(var_name) { [INFO] [stdout] 203 | | None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 204 | | Some(index) => self.mk_not_var(*index), [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 ~ match self.var_index_mapping.get(var_name) { [INFO] [stdout] 203 + None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 204 + Some(index) => self.mk_not_var(*index), [INFO] [stdout] 205 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | / return if self.is_false(bdd) { [INFO] [stdout] 212 | | self.mk_true() [INFO] [stdout] 213 | | } else if self.is_true(bdd) { [INFO] [stdout] 214 | | self.mk_false() [INFO] [stdout] ... | [INFO] [stdout] 227 | | BDD(negation) [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 ~ if self.is_false(bdd) { [INFO] [stdout] 212 + self.mk_true() [INFO] [stdout] 213 + } else if self.is_true(bdd) { [INFO] [stdout] 214 + self.mk_false() [INFO] [stdout] 215 + } else { [INFO] [stdout] 216 + let mut negation = bdd.0.clone(); [INFO] [stdout] 217 + // In each node, we swap links to `zero` and `one` (but nothing else). [INFO] [stdout] 218 + // Note that this does not break the ordering of nodes because terminals have [INFO] [stdout] 219 + // special position in the vector. (Shape of the graph is the same except for [INFO] [stdout] 220 + // links to terminals which are ordered explicitly) [INFO] [stdout] 221 + for i in 2..negation.len() { // don't flip terminals [INFO] [stdout] 222 + let node = negation.get_mut(i).unwrap(); [INFO] [stdout] 223 + // if link is 0/1, flip the bit using xor [INFO] [stdout] 224 + if node.low <= 1 { node.low = node.low ^ 1; } [INFO] [stdout] 225 + if node.high <= 1 { node.high = node.high ^ 1; } [INFO] [stdout] 226 + } [INFO] [stdout] 227 + BDD(negation) [INFO] [stdout] 228 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | / return if var_index >= self.num_vars { [INFO] [stdout] 168 | | self.var_index_out_of_bounds(var_index) [INFO] [stdout] 169 | | } else { [INFO] [stdout] 170 | | BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] ... | [INFO] [stdout] 173 | | }]) [INFO] [stdout] 174 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 167 ~ if var_index >= self.num_vars { [INFO] [stdout] 168 + self.var_index_out_of_bounds(var_index) [INFO] [stdout] 169 + } else { [INFO] [stdout] 170 + BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] 171 + var: var_index, [INFO] [stdout] 172 + low: 0, high: 1 [INFO] [stdout] 173 + }]) [INFO] [stdout] 174 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | / return if var_index >= self.num_vars { [INFO] [stdout] 181 | | self.var_index_out_of_bounds(var_index) [INFO] [stdout] 182 | | } else { [INFO] [stdout] 183 | | BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] ... | [INFO] [stdout] 186 | | }]) [INFO] [stdout] 187 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 ~ if var_index >= self.num_vars { [INFO] [stdout] 181 + self.var_index_out_of_bounds(var_index) [INFO] [stdout] 182 + } else { [INFO] [stdout] 183 + BDD(vec![self.mk_zero_node(), self.mk_one_node(), BDDNode { [INFO] [stdout] 184 + var: var_index, [INFO] [stdout] 185 + low: 0, high: 1 [INFO] [stdout] 186 + }]) [INFO] [stdout] 187 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bdd/mod.rs:224:36 [INFO] [stdout] | [INFO] [stdout] 224 | if node.low <= 1 { node.low = node.low ^ 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node.low ^= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bdd/mod.rs:225:37 [INFO] [stdout] | [INFO] [stdout] 225 | if node.high <= 1 { node.high = node.high ^ 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node.high ^= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 234 | | if l.is_zero() || r.is_zero() { Some(false) } [INFO] [stdout] 235 | | else if l.is_one() && r.is_one() { Some(true) } [INFO] [stdout] 236 | | else { None } [INFO] [stdout] 237 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 234 + if l.is_zero() || r.is_zero() { Some(false) } [INFO] [stdout] 235 + else if l.is_one() && r.is_one() { Some(true) } [INFO] [stdout] 236 + else { None } [INFO] [stdout] 237 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | / return match self.var_index_mapping.get(var_name) { [INFO] [stdout] 194 | | None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 195 | | Some(index) => self.mk_var(*index), [INFO] [stdout] 196 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 ~ match self.var_index_mapping.get(var_name) { [INFO] [stdout] 194 + None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 195 + Some(index) => self.mk_var(*index), [INFO] [stdout] 196 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 242 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 243 | | if l.is_one() || r.is_one() { Some(true) } [INFO] [stdout] 244 | | else if l.is_zero() && r.is_zero() { Some(false) } [INFO] [stdout] 245 | | else { None } [INFO] [stdout] 246 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 243 + if l.is_one() || r.is_one() { Some(true) } [INFO] [stdout] 244 + else if l.is_zero() && r.is_zero() { Some(false) } [INFO] [stdout] 245 + else { None } [INFO] [stdout] 246 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | / return match self.var_index_mapping.get(var_name) { [INFO] [stdout] 203 | | None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 204 | | Some(index) => self.mk_not_var(*index), [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 ~ match self.var_index_mapping.get(var_name) { [INFO] [stdout] 203 + None => self.var_name_out_of_bounds(var_name), [INFO] [stdout] 204 + Some(index) => self.mk_not_var(*index), [INFO] [stdout] 205 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 251 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 252 | | if l.is_zero() { Some(true) } [INFO] [stdout] 253 | | else if l.is_one() && r.is_zero() { Some(false) } [INFO] [stdout] 254 | | else { None } [INFO] [stdout] 255 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 251 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 252 + if l.is_zero() { Some(true) } [INFO] [stdout] 253 + else if l.is_one() && r.is_zero() { Some(false) } [INFO] [stdout] 254 + else { None } [INFO] [stdout] 255 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | / return if self.is_false(bdd) { [INFO] [stdout] 212 | | self.mk_true() [INFO] [stdout] 213 | | } else if self.is_true(bdd) { [INFO] [stdout] 214 | | self.mk_false() [INFO] [stdout] ... | [INFO] [stdout] 227 | | BDD(negation) [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 ~ if self.is_false(bdd) { [INFO] [stdout] 212 + self.mk_true() [INFO] [stdout] 213 + } else if self.is_true(bdd) { [INFO] [stdout] 214 + self.mk_false() [INFO] [stdout] 215 + } else { [INFO] [stdout] 216 + let mut negation = bdd.0.clone(); [INFO] [stdout] 217 + // In each node, we swap links to `zero` and `one` (but nothing else). [INFO] [stdout] 218 + // Note that this does not break the ordering of nodes because terminals have [INFO] [stdout] 219 + // special position in the vector. (Shape of the graph is the same except for [INFO] [stdout] 220 + // links to terminals which are ordered explicitly) [INFO] [stdout] 221 + for i in 2..negation.len() { // don't flip terminals [INFO] [stdout] 222 + let node = negation.get_mut(i).unwrap(); [INFO] [stdout] 223 + // if link is 0/1, flip the bit using xor [INFO] [stdout] 224 + if node.low <= 1 { node.low = node.low ^ 1; } [INFO] [stdout] 225 + if node.high <= 1 { node.high = node.high ^ 1; } [INFO] [stdout] 226 + } [INFO] [stdout] 227 + BDD(negation) [INFO] [stdout] 228 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 261 | | if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 262 | | Some(l == r) [INFO] [stdout] 263 | | } [INFO] [stdout] 264 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 261 + if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 262 + Some(l == r) [INFO] [stdout] 263 + } [INFO] [stdout] 264 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bdd/mod.rs:224:36 [INFO] [stdout] | [INFO] [stdout] 224 | if node.low <= 1 { node.low = node.low ^ 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node.low ^= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bdd/mod.rs:225:37 [INFO] [stdout] | [INFO] [stdout] 225 | if node.high <= 1 { node.high = node.high ^ 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `node.high ^= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 270 | | if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 271 | | Some(l.is_one() != r.is_one()) [INFO] [stdout] 272 | | } [INFO] [stdout] 273 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 270 + if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 271 + Some(l.is_one() != r.is_one()) [INFO] [stdout] 272 + } [INFO] [stdout] 273 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 234 | | if l.is_zero() || r.is_zero() { Some(false) } [INFO] [stdout] 235 | | else if l.is_one() && r.is_one() { Some(true) } [INFO] [stdout] 236 | | else { None } [INFO] [stdout] 237 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 234 + if l.is_zero() || r.is_zero() { Some(false) } [INFO] [stdout] 235 + else if l.is_one() && r.is_one() { Some(true) } [INFO] [stdout] 236 + else { None } [INFO] [stdout] 237 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | return if is_not_empty { BDD(result) } else { self.mk_false() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 384 - return if is_not_empty { BDD(result) } else { self.mk_false() } [INFO] [stdout] 384 + if is_not_empty { BDD(result) } else { self.mk_false() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 242 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 243 | | if l.is_one() || r.is_one() { Some(true) } [INFO] [stdout] 244 | | else if l.is_zero() && r.is_zero() { Some(false) } [INFO] [stdout] 245 | | else { None } [INFO] [stdout] 246 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 243 + if l.is_one() || r.is_one() { Some(true) } [INFO] [stdout] 244 + else if l.is_zero() && r.is_zero() { Some(false) } [INFO] [stdout] 245 + else { None } [INFO] [stdout] 246 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 251 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 252 | | if l.is_zero() { Some(true) } [INFO] [stdout] 253 | | else if l.is_one() && r.is_zero() { Some(false) } [INFO] [stdout] 254 | | else { None } [INFO] [stdout] 255 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 251 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 252 + if l.is_zero() { Some(true) } [INFO] [stdout] 253 + else if l.is_one() && r.is_zero() { Some(false) } [INFO] [stdout] 254 + else { None } [INFO] [stdout] 255 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/bdd/mod.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 337 | finished.get(&(left_low, right_low)).map(|x| *x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `finished.get(&(left_low, right_low)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/bdd/mod.rs:343:21 [INFO] [stdout] | [INFO] [stdout] 343 | finished.get(&(left_high, right_high)).map(|x| *x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `finished.get(&(left_high, right_high)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 261 | | if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 262 | | Some(l == r) [INFO] [stdout] 263 | | } [INFO] [stdout] 264 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 261 + if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 262 + Some(l == r) [INFO] [stdout] 263 + } [INFO] [stdout] 264 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | / return self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 270 | | if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 271 | | Some(l.is_one() != r.is_one()) [INFO] [stdout] 272 | | } [INFO] [stdout] 273 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 269 ~ self.apply(left, right, |l, r| -> Option { [INFO] [stdout] 270 + if !l.is_terminal() || !r.is_terminal() { None } else { [INFO] [stdout] 271 + Some(l.is_one() != r.is_one()) [INFO] [stdout] 272 + } [INFO] [stdout] 273 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | return if is_not_empty { BDD(result) } else { self.mk_false() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 384 - return if is_not_empty { BDD(result) } else { self.mk_false() } [INFO] [stdout] 384 + if is_not_empty { BDD(result) } else { self.mk_false() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BDDNode` which implements the `Copy` trait [INFO] [stdout] --> src/bdd/mod.rs:367:48 [INFO] [stdout] | [INFO] [stdout] 367 | ... created.insert(node.clone(), result.len()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BDDNode` which implements the `Copy` trait [INFO] [stdout] --> src/bdd/mod.rs:368:45 [INFO] [stdout] | [INFO] [stdout] 368 | ... result.push(node.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:389:9 [INFO] [stdout] | [INFO] [stdout] 389 | return bdd.0.len() == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 389 - return bdd.0.len() == 1 [INFO] [stdout] 389 + bdd.0.len() == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:394:9 [INFO] [stdout] | [INFO] [stdout] 394 | return bdd.0.len() == 2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return bdd.0.len() == 2 [INFO] [stdout] 394 + bdd.0.len() == 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/bdd/mod.rs:337:21 [INFO] [stdout] | [INFO] [stdout] 337 | finished.get(&(left_low, right_low)).map(|x| *x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `finished.get(&(left_low, right_low)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / return String::from_utf8(buffer) [INFO] [stdout] 404 | | .expect("Invalid UTF formatting in .dot string."); [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 ~ String::from_utf8(buffer) [INFO] [stdout] 404 ~ .expect("Invalid UTF formatting in .dot string.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/bdd/mod.rs:343:21 [INFO] [stdout] | [INFO] [stdout] 343 | finished.get(&(left_high, right_high)).map(|x| *x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `finished.get(&(left_high, right_high)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | / return BDD(vec![ [INFO] [stdout] 416 | | BDDNode::mk_zero(5), BDDNode::mk_one(5), [INFO] [stdout] 417 | | BDDNode { var: 3, low: 1, high: 0 }, [INFO] [stdout] 418 | | BDDNode { var: 4, low: 0, high: 2 } [INFO] [stdout] 419 | | ]); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 ~ BDD(vec![ [INFO] [stdout] 416 + BDDNode::mk_zero(5), BDDNode::mk_one(5), [INFO] [stdout] 417 + BDDNode { var: 3, low: 1, high: 0 }, [INFO] [stdout] 418 + BDDNode { var: 4, low: 0, high: 2 } [INFO] [stdout] 419 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | return std::fs::read_to_string(format!("test_results/bdd/{}", test_name)).expect("Cannot open result file.") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - return std::fs::read_to_string(format!("test_results/bdd/{}", test_name)).expect("Cannot open result file.") [INFO] [stdout] 423 + std::fs::read_to_string(format!("test_results/bdd/{}", test_name)).expect("Cannot open result file.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BDDNode` which implements the `Copy` trait [INFO] [stdout] --> src/bdd/mod.rs:367:48 [INFO] [stdout] | [INFO] [stdout] 367 | ... created.insert(node.clone(), result.len()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `BDDNode` which implements the `Copy` trait [INFO] [stdout] --> src/bdd/mod.rs:368:45 [INFO] [stdout] | [INFO] [stdout] 368 | ... result.push(node.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:389:9 [INFO] [stdout] | [INFO] [stdout] 389 | return bdd.0.len() == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 389 - return bdd.0.len() == 1 [INFO] [stdout] 389 + bdd.0.len() == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:394:9 [INFO] [stdout] | [INFO] [stdout] 394 | return bdd.0.len() == 2 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return bdd.0.len() == 2 [INFO] [stdout] 394 + bdd.0.len() == 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bdd/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / return String::from_utf8(buffer) [INFO] [stdout] 404 | | .expect("Invalid UTF formatting in .dot string."); [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 ~ String::from_utf8(buffer) [INFO] [stdout] 404 ~ .expect("Invalid UTF formatting in .dot string.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.72s [INFO] running `Command { std: "docker" "inspect" "66162b53df75cf6bf18b25771f733079177cf205064f766779eba0bd264152e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66162b53df75cf6bf18b25771f733079177cf205064f766779eba0bd264152e2", kill_on_drop: false }` [INFO] [stdout] 66162b53df75cf6bf18b25771f733079177cf205064f766779eba0bd264152e2