[INFO] cloning repository https://github.com/cyb-3r/pk.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cyb-3r/pk.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcyb-3r%2Fpk.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcyb-3r%2Fpk.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0ffe79131465f8f2577449ae5297ecc0104b845d [INFO] linting cyb-3r/pk.rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcyb-3r%2Fpk.rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cyb-3r/pk.rs [INFO] finished tweaking git repo https://github.com/cyb-3r/pk.rs [INFO] tweaked toml for git repo https://github.com/cyb-3r/pk.rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cyb-3r/pk.rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b08d3e20b2cf334914c5735877862323809007c63e94e327db6a256874b1b89 [INFO] running `Command { std: "docker" "start" "-a" "2b08d3e20b2cf334914c5735877862323809007c63e94e327db6a256874b1b89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b08d3e20b2cf334914c5735877862323809007c63e94e327db6a256874b1b89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b08d3e20b2cf334914c5735877862323809007c63e94e327db6a256874b1b89", kill_on_drop: false }` [INFO] [stdout] 2b08d3e20b2cf334914c5735877862323809007c63e94e327db6a256874b1b89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 192d870947ba64fc87ab9e3d4b173cdc5f4dc0f767ded3ef47eed8594936c214 [INFO] running `Command { std: "docker" "start" "-a" "192d870947ba64fc87ab9e3d4b173cdc5f4dc0f767ded3ef47eed8594936c214", kill_on_drop: false }` [INFO] [stderr] Checking pkrs v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/binmat.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | assert_eq!(mat.get_val(2, 2).unwrap(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 244 - assert_eq!(mat.get_val(2, 2).unwrap(), false); [INFO] [stdout] 244 + assert!(!mat.get_val(2, 2).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/binmat.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | assert_eq!(mat.get_val(2, 2).unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 259 - assert_eq!(mat.get_val(2, 2).unwrap(), true); [INFO] [stdout] 259 + assert!(mat.get_val(2, 2).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/board.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | assert!(!board.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `board.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/board.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | assert_eq!(board.unwrap().tile_values[0], true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 217 - assert_eq!(board.unwrap().tile_values[0], true); [INFO] [stdout] 217 + assert!(board.unwrap().tile_values[0]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.28s [INFO] running `Command { std: "docker" "inspect" "192d870947ba64fc87ab9e3d4b173cdc5f4dc0f767ded3ef47eed8594936c214", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "192d870947ba64fc87ab9e3d4b173cdc5f4dc0f767ded3ef47eed8594936c214", kill_on_drop: false }` [INFO] [stdout] 192d870947ba64fc87ab9e3d4b173cdc5f4dc0f767ded3ef47eed8594936c214