[INFO] cloning repository https://github.com/cuhey3/elo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cuhey3/elo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcuhey3%2Felo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcuhey3%2Felo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4dad1db47b241f895d7dd0de7146f467f2102e94 [INFO] linting cuhey3/elo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcuhey3%2Felo" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cuhey3/elo [INFO] finished tweaking git repo https://github.com/cuhey3/elo [INFO] tweaked toml for git repo https://github.com/cuhey3/elo written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cuhey3/elo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cuhey3/elo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_core v0.9.0-alpha.2 [INFO] [stderr] Downloaded rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Downloaded rand v0.9.0-alpha.2 [INFO] [stderr] Downloaded syn v2.0.75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0d2b20af557dc82110bf720112ce9e2b4f23bb329765faac7f0c7e629b9c6a4 [INFO] running `Command { std: "docker" "start" "-a" "e0d2b20af557dc82110bf720112ce9e2b4f23bb329765faac7f0c7e629b9c6a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0d2b20af557dc82110bf720112ce9e2b4f23bb329765faac7f0c7e629b9c6a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0d2b20af557dc82110bf720112ce9e2b4f23bb329765faac7f0c7e629b9c6a4", kill_on_drop: false }` [INFO] [stdout] e0d2b20af557dc82110bf720112ce9e2b4f23bb329765faac7f0c7e629b9c6a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cc71b78d6ffdc59ed0fdd5c152eebdca9bb72b71965570eba1f64ba0656ffb9 [INFO] running `Command { std: "docker" "start" "-a" "5cc71b78d6ffdc59ed0fdd5c152eebdca9bb72b71965570eba1f64ba0656ffb9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking rand_core v0.9.0-alpha.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.2 [INFO] [stderr] Checking rand v0.9.0-alpha.2 [INFO] [stderr] Checking elo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Tournament` is never constructed [INFO] [stdout] --> src/elo.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Tournament { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TournamentSub` is never constructed [INFO] [stdout] --> src/elo.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct TournamentSub { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Player` is never constructed [INFO] [stdout] --> src/elo.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Player { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Character` is never constructed [INFO] [stdout] --> src/elo.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Character { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EloSetting` is never constructed [INFO] [stdout] --> src/elo.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct EloSetting { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `find_player`, `find_tournament`, `find_tournament_sub`, `find_character`, and `create_rating_map` are never used [INFO] [stdout] --> src/elo.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | impl EloSetting { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 36 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn find_player(&self, id: u32) -> Option<&Player> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | fn find_tournament(&self, id: u32) -> Option<&Tournament> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | fn find_tournament_sub(&self, id: u32) -> Option<&TournamentSub> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 58 | fn find_character(&self, id: u32) -> Option<&Character> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 61 | fn create_rating_map(&self) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EloRecord` is never constructed [INFO] [stdout] --> src/elo.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub struct EloRecord { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/elo.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 82 | impl EloRecord { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 83 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_player_rating` is never used [INFO] [stdout] --> src/elo.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn get_player_rating( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `set_number` is never read [INFO] [stdout] --> src/sfl.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct SflRecord { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 10 | pub sfl_match: SflMatch, [INFO] [stdout] 11 | pub set_number: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SflRecord` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `JP2024Playoff` and `JP2024GrandFinal` are never constructed [INFO] [stdout] --> src/sfl.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 133 | pub enum SflStage { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 136 | JP2024Playoff, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 137 | JP2024GrandFinal, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SflStage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `section` and `branch` are never read [INFO] [stdout] --> src/sfl.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 426 | pub struct SflMatch { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 427 | // 節 [INFO] [stdout] 428 | pub section: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 429 | // 節内の順序 [INFO] [stdout] 430 | pub branch: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SflMatch` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `TeamOnly`, `HomeAway`, and `GameType` are never constructed [INFO] [stdout] --> src/sfl.rs:460:5 [INFO] [stdout] | [INFO] [stdout] 459 | pub enum SflRatingSetting { [INFO] [stdout] | ---------------- variants in this enum [INFO] [stdout] 460 | TeamOnly, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 461 | HomeAway, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 462 | GameType, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/elo.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | / pub fn new( [INFO] [stdout] 84 | | tournament_id: u32, [INFO] [stdout] 85 | | tournament_sub_id: u32, [INFO] [stdout] 86 | | date: u64, [INFO] [stdout] ... | [INFO] [stdout] 92 | | lose_count: u32, [INFO] [stdout] 93 | | ) -> EloRecord { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VAN` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | VAN, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Van` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MID` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | MID, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GENERAL` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | GENERAL, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `General` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXTRA` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | EXTRA, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Extra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sfl.rs:369:43 [INFO] [stdout] | [INFO] [stdout] 369 | let decide_flag = (general4.win_flag == general1.win_flag [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 370 | | && general4.win_flag == general2.win_flag [INFO] [stdout] 371 | | && general4.win_flag != general3.win_flag) [INFO] [stdout] 372 | | || (general4.win_flag == general1.win_flag [INFO] [stdout] 373 | | && general4.win_flag != general2.win_flag [INFO] [stdout] 374 | | && general4.win_flag == general3.win_flag) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 369 - let decide_flag = (general4.win_flag == general1.win_flag [INFO] [stdout] 370 - && general4.win_flag == general2.win_flag [INFO] [stdout] 371 - && general4.win_flag != general3.win_flag) [INFO] [stdout] 372 - || (general4.win_flag == general1.win_flag [INFO] [stdout] 373 - && general4.win_flag != general2.win_flag [INFO] [stdout] 374 - && general4.win_flag == general3.win_flag) [INFO] [stdout] 369 + let decide_flag = !(general4.win_flag != general1.win_flag || general4.win_flag != general2.win_flag && general4.win_flag != general3.win_flag || general4.win_flag == general2.win_flag && general4.win_flag == general3.win_flag) [INFO] [stdout] | [INFO] [stdout] 369 - let decide_flag = (general4.win_flag == general1.win_flag [INFO] [stdout] 370 - && general4.win_flag == general2.win_flag [INFO] [stdout] 371 - && general4.win_flag != general3.win_flag) [INFO] [stdout] 372 - || (general4.win_flag == general1.win_flag [INFO] [stdout] 373 - && general4.win_flag != general2.win_flag [INFO] [stdout] 374 - && general4.win_flag == general3.win_flag) [INFO] [stdout] 369 + let decide_flag = (general4.win_flag != general3.win_flag || general4.win_flag != general2.win_flag) && (general4.win_flag == general3.win_flag || general4.win_flag == general2.win_flag) && general4.win_flag == general1.win_flag [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/sfl.rs:269:44 [INFO] [stdout] | [INFO] [stdout] 269 | pub fn correct_records(&self, records: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 269 - pub fn correct_records(&self, records: &mut Vec) { [INFO] [stdout] 269 + pub fn correct_records(&self, records: &mut [SflRecord]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `records.get(0)` [INFO] [stdout] --> src/sfl.rs:272:28 [INFO] [stdout] | [INFO] [stdout] 272 | let van1 = records.get(0).unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `records.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DFM` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 440 | DFM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dfm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOL` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:441:5 [INFO] [stdout] | [INFO] [stdout] 441 | SOL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IBS` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | IBS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ibs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OJA` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:443:5 [INFO] [stdout] | [INFO] [stdout] 443 | OJA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oja` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNB` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | SNB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Snb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CAG` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:446:5 [INFO] [stdout] | [INFO] [stdout] 446 | CAG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IXA` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 447 | IXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ixa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VAR` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 449 | VAR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FAV` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | FAV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Fav` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sfl.rs:469:6 [INFO] [stdout] | [INFO] [stdout] 469 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 470 | | fn(&SflRecord) -> ((SflTeam, u8), (SflTeam, u8)), [INFO] [stdout] 471 | | HashMap<(SflTeam, u8), f64>, [INFO] [stdout] 472 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sfl.rs:568:6 [INFO] [stdout] | [INFO] [stdout] 568 | ) -> HashMap, (u32, u32, i32, i32))> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sfl.rs:569:20 [INFO] [stdout] | [INFO] [stdout] 569 | let mut count: HashMap, (u32, u32, i32, i32))> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | ) -> HashMap, (u32, u32, i32, i32, f64, f64, f64, f64))> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `records.get(0)` [INFO] [stdout] --> src/main.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if records.get(0).unwrap().is_prediction { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `records.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/main.rs:107:31 [INFO] [stdout] | [INFO] [stdout] 107 | for record in records.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:198:16 [INFO] [stdout] | [INFO] [stdout] 198 | if sum > 45 || sum < 40 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(40..=45).contains(&sum)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `flat_map` with an identity function [INFO] [stdout] --> src/main.rs:207:74 [INFO] [stdout] | [INFO] [stdout] 207 | let sfl_records: Vec<&SflRecord> = initial_record_matches.iter().flat_map(|x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#flat_map_identity [INFO] [stdout] = note: `#[warn(clippy::flat_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 250 | .cmp(&a_point) [INFO] [stdout] | ^^^^^^^^ help: change this to: `a_point` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:251:36 [INFO] [stdout] | [INFO] [stdout] 251 | .then(b_battle.cmp(&a_battle)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `a_battle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:289:25 [INFO] [stdout] | [INFO] [stdout] 289 | let mut result_map: HashMap, (u32, u32, i32, i32, f64, f64, f64, f64))> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Tournament` is never constructed [INFO] [stdout] --> src/elo.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Tournament { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TournamentSub` is never constructed [INFO] [stdout] --> src/elo.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct TournamentSub { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Player` is never constructed [INFO] [stdout] --> src/elo.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Player { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Character` is never constructed [INFO] [stdout] --> src/elo.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Character { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EloSetting` is never constructed [INFO] [stdout] --> src/elo.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct EloSetting { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `find_player`, `find_tournament`, `find_tournament_sub`, `find_character`, and `create_rating_map` are never used [INFO] [stdout] --> src/elo.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | impl EloSetting { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 36 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn find_player(&self, id: u32) -> Option<&Player> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | fn find_tournament(&self, id: u32) -> Option<&Tournament> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 55 | fn find_tournament_sub(&self, id: u32) -> Option<&TournamentSub> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 58 | fn find_character(&self, id: u32) -> Option<&Character> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 61 | fn create_rating_map(&self) -> HashMap { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `EloRecord` is never constructed [INFO] [stdout] --> src/elo.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub struct EloRecord { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/elo.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 82 | impl EloRecord { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 83 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_player_rating` is never used [INFO] [stdout] --> src/elo.rs:110:8 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn get_player_rating( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `set_number` is never read [INFO] [stdout] --> src/sfl.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct SflRecord { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 10 | pub sfl_match: SflMatch, [INFO] [stdout] 11 | pub set_number: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SflRecord` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `JP2024Playoff` and `JP2024GrandFinal` are never constructed [INFO] [stdout] --> src/sfl.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 133 | pub enum SflStage { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 136 | JP2024Playoff, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 137 | JP2024GrandFinal, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SflStage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `section` and `branch` are never read [INFO] [stdout] --> src/sfl.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 426 | pub struct SflMatch { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 427 | // 節 [INFO] [stdout] 428 | pub section: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 429 | // 節内の順序 [INFO] [stdout] 430 | pub branch: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SflMatch` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `TeamOnly`, `HomeAway`, and `GameType` are never constructed [INFO] [stdout] --> src/sfl.rs:460:5 [INFO] [stdout] | [INFO] [stdout] 459 | pub enum SflRatingSetting { [INFO] [stdout] | ---------------- variants in this enum [INFO] [stdout] 460 | TeamOnly, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 461 | HomeAway, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 462 | GameType, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/elo.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | / pub fn new( [INFO] [stdout] 84 | | tournament_id: u32, [INFO] [stdout] 85 | | tournament_sub_id: u32, [INFO] [stdout] 86 | | date: u64, [INFO] [stdout] ... | [INFO] [stdout] 92 | | lose_count: u32, [INFO] [stdout] 93 | | ) -> EloRecord { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VAN` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | VAN, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Van` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MID` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | MID, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GENERAL` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | GENERAL, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `General` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXTRA` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | EXTRA, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Extra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sfl.rs:369:43 [INFO] [stdout] | [INFO] [stdout] 369 | let decide_flag = (general4.win_flag == general1.win_flag [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 370 | | && general4.win_flag == general2.win_flag [INFO] [stdout] 371 | | && general4.win_flag != general3.win_flag) [INFO] [stdout] 372 | | || (general4.win_flag == general1.win_flag [INFO] [stdout] 373 | | && general4.win_flag != general2.win_flag [INFO] [stdout] 374 | | && general4.win_flag == general3.win_flag) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 369 - let decide_flag = (general4.win_flag == general1.win_flag [INFO] [stdout] 370 - && general4.win_flag == general2.win_flag [INFO] [stdout] 371 - && general4.win_flag != general3.win_flag) [INFO] [stdout] 372 - || (general4.win_flag == general1.win_flag [INFO] [stdout] 373 - && general4.win_flag != general2.win_flag [INFO] [stdout] 374 - && general4.win_flag == general3.win_flag) [INFO] [stdout] 369 + let decide_flag = !(general4.win_flag != general1.win_flag || general4.win_flag != general2.win_flag && general4.win_flag != general3.win_flag || general4.win_flag == general2.win_flag && general4.win_flag == general3.win_flag) [INFO] [stdout] | [INFO] [stdout] 369 - let decide_flag = (general4.win_flag == general1.win_flag [INFO] [stdout] 370 - && general4.win_flag == general2.win_flag [INFO] [stdout] 371 - && general4.win_flag != general3.win_flag) [INFO] [stdout] 372 - || (general4.win_flag == general1.win_flag [INFO] [stdout] 373 - && general4.win_flag != general2.win_flag [INFO] [stdout] 374 - && general4.win_flag == general3.win_flag) [INFO] [stdout] 369 + let decide_flag = (general4.win_flag != general3.win_flag || general4.win_flag != general2.win_flag) && (general4.win_flag == general3.win_flag || general4.win_flag == general2.win_flag) && general4.win_flag == general1.win_flag [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/sfl.rs:269:44 [INFO] [stdout] | [INFO] [stdout] 269 | pub fn correct_records(&self, records: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 269 - pub fn correct_records(&self, records: &mut Vec) { [INFO] [stdout] 269 + pub fn correct_records(&self, records: &mut [SflRecord]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `records.get(0)` [INFO] [stdout] --> src/sfl.rs:272:28 [INFO] [stdout] | [INFO] [stdout] 272 | let van1 = records.get(0).unwrap().to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `records.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DFM` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 440 | DFM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dfm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SOL` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:441:5 [INFO] [stdout] | [INFO] [stdout] 441 | SOL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IBS` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | IBS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ibs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OJA` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:443:5 [INFO] [stdout] | [INFO] [stdout] 443 | OJA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Oja` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNB` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | SNB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Snb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CAG` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:446:5 [INFO] [stdout] | [INFO] [stdout] 446 | CAG, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IXA` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:447:5 [INFO] [stdout] | [INFO] [stdout] 447 | IXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ixa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VAR` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 449 | VAR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Var` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FAV` contains a capitalized acronym [INFO] [stdout] --> src/sfl.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | FAV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Fav` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sfl.rs:469:6 [INFO] [stdout] | [INFO] [stdout] 469 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 470 | | fn(&SflRecord) -> ((SflTeam, u8), (SflTeam, u8)), [INFO] [stdout] 471 | | HashMap<(SflTeam, u8), f64>, [INFO] [stdout] 472 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sfl.rs:568:6 [INFO] [stdout] | [INFO] [stdout] 568 | ) -> HashMap, (u32, u32, i32, i32))> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sfl.rs:569:20 [INFO] [stdout] | [INFO] [stdout] 569 | let mut count: HashMap, (u32, u32, i32, i32))> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | ) -> HashMap, (u32, u32, i32, i32, f64, f64, f64, f64))> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `records.get(0)` [INFO] [stdout] --> src/main.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if records.get(0).unwrap().is_prediction { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `records.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter_mut()` and will not consume the `Vec` [INFO] [stdout] --> src/main.rs:107:31 [INFO] [stdout] | [INFO] [stdout] 107 | for record in records.into_iter() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:198:16 [INFO] [stdout] | [INFO] [stdout] 198 | if sum > 45 || sum < 40 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `!(40..=45).contains(&sum)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `flat_map` with an identity function [INFO] [stdout] --> src/main.rs:207:74 [INFO] [stdout] | [INFO] [stdout] 207 | let sfl_records: Vec<&SflRecord> = initial_record_matches.iter().flat_map(|x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#flat_map_identity [INFO] [stdout] = note: `#[warn(clippy::flat_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 250 | .cmp(&a_point) [INFO] [stdout] | ^^^^^^^^ help: change this to: `a_point` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:251:36 [INFO] [stdout] | [INFO] [stdout] 251 | .then(b_battle.cmp(&a_battle)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `a_battle` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:289:25 [INFO] [stdout] | [INFO] [stdout] 289 | let mut result_map: HashMap, (u32, u32, i32, i32, f64, f64, f64, f64))> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.23s [INFO] running `Command { std: "docker" "inspect" "5cc71b78d6ffdc59ed0fdd5c152eebdca9bb72b71965570eba1f64ba0656ffb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cc71b78d6ffdc59ed0fdd5c152eebdca9bb72b71965570eba1f64ba0656ffb9", kill_on_drop: false }` [INFO] [stdout] 5cc71b78d6ffdc59ed0fdd5c152eebdca9bb72b71965570eba1f64ba0656ffb9