[INFO] cloning repository https://github.com/ctrlok/shoporusni_prompt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ctrlok/shoporusni_prompt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fctrlok%2Fshoporusni_prompt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fctrlok%2Fshoporusni_prompt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 04949ca6169f43e706dbf87ede30d14a4b9a4379 [INFO] linting ctrlok/shoporusni_prompt against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fctrlok%2Fshoporusni_prompt" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ctrlok/shoporusni_prompt [INFO] finished tweaking git repo https://github.com/ctrlok/shoporusni_prompt [INFO] tweaked toml for git repo https://github.com/ctrlok/shoporusni_prompt written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ctrlok/shoporusni_prompt on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ctrlok/shoporusni_prompt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap_lex v0.2.3 [INFO] [stderr] Downloaded tracing-core v0.1.28 [INFO] [stderr] Downloaded clap-verbosity-flag v1.0.1 [INFO] [stderr] Downloaded clap_derive v3.2.6 [INFO] [stderr] Downloaded simplelog v0.12.0 [INFO] [stderr] Downloaded openssl-sys v0.9.74 [INFO] [stderr] Downloaded unicode-normalization v0.1.20 [INFO] [stderr] Downloaded clap v3.2.6 [INFO] [stderr] Downloaded openssl v0.10.40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d8200f676d218cb89e91e32880494735f33afc32b5f0aaac84658babf9c12baa [INFO] running `Command { std: "docker" "start" "-a" "d8200f676d218cb89e91e32880494735f33afc32b5f0aaac84658babf9c12baa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d8200f676d218cb89e91e32880494735f33afc32b5f0aaac84658babf9c12baa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8200f676d218cb89e91e32880494735f33afc32b5f0aaac84658babf9c12baa", kill_on_drop: false }` [INFO] [stdout] d8200f676d218cb89e91e32880494735f33afc32b5f0aaac84658babf9c12baa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac7d9673863551b54d066aa0cb197b81afbf11660e550f3d316dac85aede6327 [INFO] running `Command { std: "docker" "start" "-a" "ac7d9673863551b54d066aa0cb197b81afbf11660e550f3d316dac85aede6327", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking hashbrown v0.12.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling openssl v0.10.40 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.28 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.20 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking tokio v1.19.2 [INFO] [stderr] Checking time v0.3.11 [INFO] [stderr] Checking clap_lex v0.2.3 [INFO] [stderr] Checking encoding_rs v0.8.31 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking simplelog v0.12.0 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling clap_derive v3.2.6 [INFO] [stderr] Checking clap v3.2.6 [INFO] [stderr] Checking hyper v0.14.19 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking serde v1.0.137 [INFO] [stderr] Checking clap-verbosity-flag v1.0.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking reqwest v0.11.11 [INFO] [stderr] Checking shoporusni v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error` [INFO] [stdout] --> src/lib/cache.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | use log::{debug, error, info, warn}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use humantime; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod lib; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `error` [INFO] [stdout] --> src/lib/cache.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | use log::{debug, error, info, warn}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use humantime; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/lib/config.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | .unwrap_or(PathBuf::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/cache.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | !File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/lib/cache.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | assert!(matches!(cache.read(), Ok(_))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cache.read().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/cache.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | !File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/lib/cache.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | assert!(matches!(cache.read(), Ok(_))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cache.read().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/cache.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | !File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/lib/cache.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | assert!(matches!(cache.read(), Ok(_))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cache.read().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/cache.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | !File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `File::open(format!("{}/cache.json", dir.to_str().unwrap())).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/lib/cache.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | assert!(matches!(cache.write("data"), Ok(_))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cache.write("data").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(lib::print_result(&data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 40 ~ lib::print_result(&data); [INFO] [stdout] 41 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or` to construct default value [INFO] [stdout] --> src/lib/config.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | .unwrap_or(PathBuf::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | Ok(lib::print_result(&data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 40 ~ lib::print_result(&data); [INFO] [stdout] 41 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.14s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.40 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "ac7d9673863551b54d066aa0cb197b81afbf11660e550f3d316dac85aede6327", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac7d9673863551b54d066aa0cb197b81afbf11660e550f3d316dac85aede6327", kill_on_drop: false }` [INFO] [stdout] ac7d9673863551b54d066aa0cb197b81afbf11660e550f3d316dac85aede6327