[INFO] cloning repository https://github.com/crastinus/hlfun_auth_srv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/crastinus/hlfun_auth_srv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcrastinus%2Fhlfun_auth_srv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcrastinus%2Fhlfun_auth_srv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 991f40829c8f2a8c67f0986c9bca2aa01418794b [INFO] linting crastinus/hlfun_auth_srv against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcrastinus%2Fhlfun_auth_srv" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/crastinus/hlfun_auth_srv [INFO] finished tweaking git repo https://github.com/crastinus/hlfun_auth_srv [INFO] tweaked toml for git repo https://github.com/crastinus/hlfun_auth_srv written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/crastinus/hlfun_auth_srv on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/crastinus/hlfun_auth_srv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded reusable-box-future v0.2.0 [INFO] [stderr] Downloaded ct-codecs v1.1.1 [INFO] [stderr] Downloaded jemallocator v0.5.4 [INFO] [stderr] Downloaded cc v1.0.90 [INFO] [stderr] Downloaded iprange v0.6.7 [INFO] [stderr] Downloaded branches v0.1.3 [INFO] [stderr] Downloaded coarsetime v0.1.34 [INFO] [stderr] Downloaded blake2b_simd v1.0.2 [INFO] [stderr] Downloaded p256 v0.13.2 [INFO] [stderr] Downloaded ecdsa v0.16.9 [INFO] [stderr] Downloaded csv-core v0.1.11 [INFO] [stderr] Downloaded ff v0.13.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.79 [INFO] [stderr] Downloaded superboring v0.1.2 [INFO] [stderr] Downloaded sec1 v0.7.3 [INFO] [stderr] Downloaded k256 v0.13.3 [INFO] [stderr] Downloaded jwt-simple v0.12.9 [INFO] [stderr] Downloaded p384 v0.13.0 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.52.4 [INFO] [stderr] Downloaded base16ct v0.2.0 [INFO] [stderr] Downloaded jemalloc-sys v0.5.4+5.3.0-patched [INFO] [stderr] Downloaded nix v0.26.4 [INFO] [stderr] Downloaded group v0.13.0 [INFO] [stderr] Downloaded tick_counter v0.4.5 [INFO] [stderr] Downloaded hmac-sha1-compact v1.1.4 [INFO] [stderr] Downloaded hmac-sha256 v1.1.7 [INFO] [stderr] Downloaded windows_i686_gnu v0.52.4 [INFO] [stderr] Downloaded crypto-bigint v0.5.5 [INFO] [stderr] Downloaded smol_str v0.2.1 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.52.4 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.52.4 [INFO] [stderr] Downloaded monoio-compat v0.2.2 [INFO] [stderr] Downloaded monoio-macros v0.1.0 [INFO] [stderr] Downloaded hyper v1.2.0 [INFO] [stderr] Downloaded windows_x86_64_gnullvm v0.52.4 [INFO] [stderr] Downloaded wasix v0.12.21 [INFO] [stderr] Downloaded syn v2.0.57 [INFO] [stderr] Downloaded hmac-sha512 v1.1.5 [INFO] [stderr] Downloaded windows-targets v0.52.4 [INFO] [stderr] Downloaded elliptic-curve v0.13.8 [INFO] [stderr] Downloaded binstring v0.1.1 [INFO] [stderr] Downloaded monoio v0.2.3 [INFO] [stderr] Downloaded primeorder v0.13.6 [INFO] [stderr] Downloaded auto-const-array v0.2.1 [INFO] [stderr] Downloaded serde_derive v1.0.200 [INFO] [stderr] Downloaded io-uring v0.6.3 [INFO] [stderr] Downloaded ed25519-compact v2.1.1 [INFO] [stderr] Downloaded rfc6979 v0.4.0 [INFO] [stderr] Downloaded serde v1.0.200 [INFO] [stderr] Downloaded windows_aarch64_gnullvm v0.52.4 [INFO] [stderr] Downloaded csv v1.3.0 [INFO] [stderr] Downloaded windows_i686_msvc v0.52.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac5a0f89d9642c4fc42d37bd0653f73c597de90189587b8f09d0f21a4f34df96 [INFO] running `Command { std: "docker" "start" "-a" "ac5a0f89d9642c4fc42d37bd0653f73c597de90189587b8f09d0f21a4f34df96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac5a0f89d9642c4fc42d37bd0653f73c597de90189587b8f09d0f21a4f34df96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac5a0f89d9642c4fc42d37bd0653f73c597de90189587b8f09d0f21a4f34df96", kill_on_drop: false }` [INFO] [stdout] ac5a0f89d9642c4fc42d37bd0653f73c597de90189587b8f09d0f21a4f34df96 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4bc1c20507ab40eb208bb3a85aa0f4c892063577c6b69f348470245d44e5a9bf [INFO] running `Command { std: "docker" "start" "-a" "4bc1c20507ab40eb208bb3a85aa0f4c892063577c6b69f348470245d44e5a9bf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling io-uring v0.6.3 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking ct-codecs v1.1.1 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking hmac-sha1-compact v1.1.4 [INFO] [stderr] Compiling syn v2.0.57 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking binstring v0.1.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking reusable-box-future v0.2.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking tick_counter v0.4.5 [INFO] [stderr] Checking branches v0.1.3 [INFO] [stderr] Compiling jemalloc-sys v0.5.4+5.3.0-patched [INFO] [stderr] Checking iprange v0.6.7 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking coarsetime v0.1.34 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ed25519-compact v2.1.1 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac-sha256 v1.1.7 [INFO] [stderr] Checking hmac-sha512 v1.1.5 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling auto-const-array v0.2.1 [INFO] [stderr] Compiling monoio-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking superboring v0.1.2 [INFO] [stderr] Checking monoio v0.2.3 [INFO] [stderr] Checking monoio-compat v0.2.2 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking jwt-simple v0.12.9 [INFO] [stderr] Checking jemallocator v0.5.4 [INFO] [stderr] Checking hlfun_srv v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `MAX_HEADER_SIZE` is never used [INFO] [stdout] --> src/service.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const MAX_HEADER_SIZE: usize = 10 * 1024; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAX_HEADER_SIZE` is never used [INFO] [stdout] --> src/service.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const MAX_HEADER_SIZE: usize = 10 * 1024; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/service.rs:248:20 [INFO] [stdout] | [INFO] [stdout] 248 | if let None = self.state.is_proper_country(login.clone(), ip) { [INFO] [stdout] | -------^^^^-------------------------------------------------- help: try: `if self.state.is_proper_country(login.clone(), ip).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/service.rs:277:28 [INFO] [stdout] | [INFO] [stdout] 277 | if let None = self.state.edit_user( [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 277 ~ if self.state.edit_user( [INFO] [stdout] 278 + login, [INFO] [stdout] 279 + request.name, [INFO] [stdout] 280 + request.password, [INFO] [stdout] 281 + request.phone, [INFO] [stdout] 282 + request.is_admin, [INFO] [stdout] 283 + request.country, [INFO] [stdout] 284 ~ ).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/service.rs:248:20 [INFO] [stdout] | [INFO] [stdout] 248 | if let None = self.state.is_proper_country(login.clone(), ip) { [INFO] [stdout] | -------^^^^-------------------------------------------------- help: try: `if self.state.is_proper_country(login.clone(), ip).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/service.rs:277:28 [INFO] [stdout] | [INFO] [stdout] 277 | if let None = self.state.edit_user( [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 277 ~ if self.state.edit_user( [INFO] [stdout] 278 + login, [INFO] [stdout] 279 + request.name, [INFO] [stdout] 280 + request.password, [INFO] [stdout] 281 + request.phone, [INFO] [stdout] 282 + request.is_admin, [INFO] [stdout] 283 + request.country, [INFO] [stdout] 284 ~ ).is_none() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/state.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | / let Some(rec) = self.users.get(&login) else { [INFO] [stdout] 170 | | return None; [INFO] [stdout] 171 | | }; [INFO] [stdout] | |______________^ help: replace it with: `let rec = self.users.get(&login)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/state.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | / let Some(rec) = self.users.get(&login) else { [INFO] [stdout] 170 | | return None; [INFO] [stdout] 171 | | }; [INFO] [stdout] | |______________^ help: replace it with: `let rec = self.users.get(&login)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/request.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::u8; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u8::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | return Some(Handler::BlacklistSubnet { subnet: ip, mask }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ Some(Handler::BlacklistSubnet { subnet: ip, mask }) [INFO] [stdout] 75 | } [INFO] [stdout] ... [INFO] [stdout] 79 | _ => return None, [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | return Some(Handler::UnblacklistSubnet { subnet: ip, mask }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ Some(Handler::UnblacklistSubnet { subnet: ip, mask }) [INFO] [stdout] 78 | } [INFO] [stdout] 79 | _ => return None, [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:79:26 [INFO] [stdout] | [INFO] [stdout] 79 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ _ => None, [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | return Some(Handler::BlacklistUser { user }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ Some(Handler::BlacklistUser { user }) [INFO] [stdout] 91 | } [INFO] [stdout] ... [INFO] [stdout] 95 | _ => return None, [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | return Some(Handler::UnblacklistUser { user }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 ~ Some(Handler::UnblacklistUser { user }) [INFO] [stdout] 94 | } [INFO] [stdout] 95 | _ => return None, [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:95:26 [INFO] [stdout] | [INFO] [stdout] 95 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 ~ _ => None, [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:98:18 [INFO] [stdout] | [INFO] [stdout] 98 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - _ => return None, [INFO] [stdout] 98 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/request.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | / match method { [INFO] [stdout] 43 | | &Method::PUT => { [INFO] [stdout] 44 | | return Some(Handler::RegisterUser); [INFO] [stdout] ... | [INFO] [stdout] 55 | | _ => return None, [INFO] [stdout] 56 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 42 ~ match *method { [INFO] [stdout] 43 ~ Method::PUT => { [INFO] [stdout] 44 | return Some(Handler::RegisterUser); [INFO] [stdout] 45 | } [INFO] [stdout] 46 | [INFO] [stdout] 47 ~ Method::GET => { [INFO] [stdout] 48 | return Some(Handler::GetUser); [INFO] [stdout] 49 | } [INFO] [stdout] 50 | [INFO] [stdout] 51 ~ Method::PATCH => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/request.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::u8; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u8::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 38 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:68:20 [INFO] [stdout] | [INFO] [stdout] 68 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/request.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | if !splitted.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `splitted.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | return Some(Handler::BlacklistSubnet { subnet: ip, mask }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ Some(Handler::BlacklistSubnet { subnet: ip, mask }) [INFO] [stdout] 75 | } [INFO] [stdout] ... [INFO] [stdout] 79 | _ => return None, [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | return Some(Handler::UnblacklistSubnet { subnet: ip, mask }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ Some(Handler::UnblacklistSubnet { subnet: ip, mask }) [INFO] [stdout] 78 | } [INFO] [stdout] 79 | _ => return None, [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:79:26 [INFO] [stdout] | [INFO] [stdout] 79 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ _ => None, [INFO] [stdout] 80 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | return Some(Handler::BlacklistUser { user }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 ~ Some(Handler::BlacklistUser { user }) [INFO] [stdout] 91 | } [INFO] [stdout] ... [INFO] [stdout] 95 | _ => return None, [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | return Some(Handler::UnblacklistUser { user }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 ~ Some(Handler::UnblacklistUser { user }) [INFO] [stdout] 94 | } [INFO] [stdout] 95 | _ => return None, [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:95:26 [INFO] [stdout] | [INFO] [stdout] 95 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 ~ _ => None, [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request.rs:98:18 [INFO] [stdout] | [INFO] [stdout] 98 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - _ => return None, [INFO] [stdout] 98 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/request.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | / match method { [INFO] [stdout] 43 | | &Method::PUT => { [INFO] [stdout] 44 | | return Some(Handler::RegisterUser); [INFO] [stdout] ... | [INFO] [stdout] 55 | | _ => return None, [INFO] [stdout] 56 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 42 ~ match *method { [INFO] [stdout] 43 ~ Method::PUT => { [INFO] [stdout] 44 | return Some(Handler::RegisterUser); [INFO] [stdout] 45 | } [INFO] [stdout] 46 | [INFO] [stdout] 47 ~ Method::GET => { [INFO] [stdout] 48 | return Some(Handler::GetUser); [INFO] [stdout] 49 | } [INFO] [stdout] 50 | [INFO] [stdout] 51 ~ Method::PATCH => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/request.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | / match method { [INFO] [stdout] 73 | | &Method::PUT => { [INFO] [stdout] 74 | | return Some(Handler::BlacklistSubnet { subnet: ip, mask }); [INFO] [stdout] ... | [INFO] [stdout] 79 | | _ => return None, [INFO] [stdout] 80 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 72 ~ match *method { [INFO] [stdout] 73 ~ Method::PUT => { [INFO] [stdout] 74 | return Some(Handler::BlacklistSubnet { subnet: ip, mask }); [INFO] [stdout] 75 | } [INFO] [stdout] 76 ~ Method::DELETE => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/request.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | / match method { [INFO] [stdout] 73 | | &Method::PUT => { [INFO] [stdout] 74 | | return Some(Handler::BlacklistSubnet { subnet: ip, mask }); [INFO] [stdout] ... | [INFO] [stdout] 79 | | _ => return None, [INFO] [stdout] 80 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 72 ~ match *method { [INFO] [stdout] 73 ~ Method::PUT => { [INFO] [stdout] 74 | return Some(Handler::BlacklistSubnet { subnet: ip, mask }); [INFO] [stdout] 75 | } [INFO] [stdout] 76 ~ Method::DELETE => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/request.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | / match method { [INFO] [stdout] 89 | | &Method::PUT => { [INFO] [stdout] 90 | | return Some(Handler::BlacklistUser { user }); [INFO] [stdout] ... | [INFO] [stdout] 95 | | _ => return None, [INFO] [stdout] 96 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 88 ~ match *method { [INFO] [stdout] 89 ~ Method::PUT => { [INFO] [stdout] 90 | return Some(Handler::BlacklistUser { user }); [INFO] [stdout] 91 | } [INFO] [stdout] 92 ~ Method::DELETE => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/request.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | / match method { [INFO] [stdout] 89 | | &Method::PUT => { [INFO] [stdout] 90 | | return Some(Handler::BlacklistUser { user }); [INFO] [stdout] ... | [INFO] [stdout] 95 | | _ => return None, [INFO] [stdout] 96 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 88 ~ match *method { [INFO] [stdout] 89 ~ Method::PUT => { [INFO] [stdout] 90 | return Some(Handler::BlacklistUser { user }); [INFO] [stdout] 91 | } [INFO] [stdout] 92 ~ Method::DELETE => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:60:39 [INFO] [stdout] | [INFO] [stdout] 60 | let prefixes = std::thread::spawn(|| read_countries()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `read_countries` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:60:39 [INFO] [stdout] | [INFO] [stdout] 60 | let prefixes = std::thread::spawn(|| read_countries()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `read_countries` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:165:38 [INFO] [stdout] | [INFO] [stdout] 165 | for (_idx, line) in lines.skip(1).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 165 - for (_idx, line) in lines.skip(1).enumerate() { [INFO] [stdout] 165 + for line in lines.skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `running` should have an upper case name [INFO] [stdout] --> src/main.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | static running: std::sync::atomic::AtomicBool = AtomicBool::new(true); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 27 - static running: std::sync::atomic::AtomicBool = AtomicBool::new(true); [INFO] [stdout] 27 + static RUNNING: std::sync::atomic::AtomicBool = AtomicBool::new(true); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:165:38 [INFO] [stdout] | [INFO] [stdout] 165 | for (_idx, line) in lines.skip(1).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 165 - for (_idx, line) in lines.skip(1).enumerate() { [INFO] [stdout] 165 + for line in lines.skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static variable `running` should have an upper case name [INFO] [stdout] --> src/main.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | static running: std::sync::atomic::AtomicBool = AtomicBool::new(true); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 27 - static running: std::sync::atomic::AtomicBool = AtomicBool::new(true); [INFO] [stdout] 27 + static RUNNING: std::sync::atomic::AtomicBool = AtomicBool::new(true); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 42s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "4bc1c20507ab40eb208bb3a85aa0f4c892063577c6b69f348470245d44e5a9bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bc1c20507ab40eb208bb3a85aa0f4c892063577c6b69f348470245d44e5a9bf", kill_on_drop: false }` [INFO] [stdout] 4bc1c20507ab40eb208bb3a85aa0f4c892063577c6b69f348470245d44e5a9bf