[INFO] cloning repository https://github.com/cowai/pwm-better-fan-control [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cowai/pwm-better-fan-control" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcowai%2Fpwm-better-fan-control", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcowai%2Fpwm-better-fan-control'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0db42615f1d7a8d2bf67c0c8e40dbe52c02f5733 [INFO] linting cowai/pwm-better-fan-control against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcowai%2Fpwm-better-fan-control" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cowai/pwm-better-fan-control [INFO] finished tweaking git repo https://github.com/cowai/pwm-better-fan-control [INFO] tweaked toml for git repo https://github.com/cowai/pwm-better-fan-control written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cowai/pwm-better-fan-control on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cowai/pwm-better-fan-control already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/pop-os/sysfs-class` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitflags v0.4.0 [INFO] [stderr] Downloaded graceful v0.1.1 [INFO] [stderr] Downloaded nix v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7957f6c23ad5e1fcd97cf858a8ab61e2f168c601887839caa526a45da939a24 [INFO] running `Command { std: "docker" "start" "-a" "b7957f6c23ad5e1fcd97cf858a8ab61e2f168c601887839caa526a45da939a24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7957f6c23ad5e1fcd97cf858a8ab61e2f168c601887839caa526a45da939a24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7957f6c23ad5e1fcd97cf858a8ab61e2f168c601887839caa526a45da939a24", kill_on_drop: false }` [INFO] [stdout] b7957f6c23ad5e1fcd97cf858a8ab61e2f168c601887839caa526a45da939a24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f23313c2bced33d340d34dab8eff3ce2306954b0e8b7eaeddc0cd62ef3576ec5 [INFO] running `Command { std: "docker" "start" "-a" "f23313c2bced33d340d34dab8eff3ce2306954b0e8b7eaeddc0cd62ef3576ec5", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking sysfs-class v0.1.1 (https://github.com/pop-os/sysfs-class#35d6015d) [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Compiling nix v0.7.0 [INFO] [stderr] Checking graceful v0.1.1 [INFO] [stderr] Checking pwm-better-fan-control v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/fan.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | state: state, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:5:47 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::atomic::{AtomicBool, Ordering, ATOMIC_BOOL_INIT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | static STOP: AtomicBool = ATOMIC_BOOL_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 14 - static STOP: AtomicBool = ATOMIC_BOOL_INIT; [INFO] [stdout] 14 + static STOP: AtomicBool = AtomicBool::new(false); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fan.rs:68:37 [INFO] [stdout] | [INFO] [stdout] 68 | let long_since_update = !self.state.last_updated.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.state.last_updated.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.state.duty` after checking its variant with `is_some` [INFO] [stdout] --> src/fan.rs:88:48 [INFO] [stdout] | [INFO] [stdout] 84 | if self.state.duty.is_some() [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 88 | let new_duty = ((u32::from(self.state.duty.unwrap()) * 750) / 1000) as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fan.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return true; [INFO] [stdout] 121 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fan.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return false; [INFO] [stdout] 124 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/fan.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | state: state, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/fan.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / if self.state.sliding_max_duty.is_some() { [INFO] [stdout] 73 | | if duty > self.state.sliding_max_duty.unwrap() [INFO] [stdout] 74 | | || self.state.spindown_count == 0 [INFO] [stdout] 75 | | && now.duration_since(self.state.last_max_updated.unwrap()) > max_duration [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if self.state.sliding_max_duty.is_some() [INFO] [stdout] 73 ~ && (duty > self.state.sliding_max_duty.unwrap() [INFO] [stdout] 74 | || self.state.spindown_count == 0 [INFO] [stdout] 75 ~ && now.duration_since(self.state.last_max_updated.unwrap()) > max_duration) [INFO] [stdout] 76 | { [INFO] [stdout] 77 | self.state.sliding_max_duty = duty_opt; [INFO] [stdout] 78 | self.state.last_max_updated = Some(now); [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/fan.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | self.state.spindown_count = self.state.spindown_count + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.state.spindown_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:5:47 [INFO] [stdout] | [INFO] [stdout] 5 | use std::sync::atomic::{AtomicBool, Ordering, ATOMIC_BOOL_INIT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/main.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | static STOP: AtomicBool = ATOMIC_BOOL_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 14 - static STOP: AtomicBool = ATOMIC_BOOL_INIT; [INFO] [stdout] 14 + static STOP: AtomicBool = AtomicBool::new(false); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/fan.rs:68:37 [INFO] [stdout] | [INFO] [stdout] 68 | let long_since_update = !self.state.last_updated.is_none() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.state.last_updated.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.state.duty` after checking its variant with `is_some` [INFO] [stdout] --> src/fan.rs:88:48 [INFO] [stdout] | [INFO] [stdout] 84 | if self.state.duty.is_some() [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 88 | let new_duty = ((u32::from(self.state.duty.unwrap()) * 750) / 1000) as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fan.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return true; [INFO] [stdout] 121 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/fan.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return false; [INFO] [stdout] 124 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/fan.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / if self.state.sliding_max_duty.is_some() { [INFO] [stdout] 73 | | if duty > self.state.sliding_max_duty.unwrap() [INFO] [stdout] 74 | | || self.state.spindown_count == 0 [INFO] [stdout] 75 | | && now.duration_since(self.state.last_max_updated.unwrap()) > max_duration [INFO] [stdout] ... | [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 72 ~ if self.state.sliding_max_duty.is_some() [INFO] [stdout] 73 ~ && (duty > self.state.sliding_max_duty.unwrap() [INFO] [stdout] 74 | || self.state.spindown_count == 0 [INFO] [stdout] 75 ~ && now.duration_since(self.state.last_max_updated.unwrap()) > max_duration) [INFO] [stdout] 76 | { [INFO] [stdout] 77 | self.state.sliding_max_duty = duty_opt; [INFO] [stdout] 78 | self.state.last_max_updated = Some(now); [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/fan.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | self.state.spindown_count = self.state.spindown_count + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.state.spindown_count += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.07s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.4.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "f23313c2bced33d340d34dab8eff3ce2306954b0e8b7eaeddc0cd62ef3576ec5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f23313c2bced33d340d34dab8eff3ce2306954b0e8b7eaeddc0cd62ef3576ec5", kill_on_drop: false }` [INFO] [stdout] f23313c2bced33d340d34dab8eff3ce2306954b0e8b7eaeddc0cd62ef3576ec5