[INFO] cloning repository https://github.com/coumcashier/rustfm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/coumcashier/rustfm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoumcashier%2Frustfm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoumcashier%2Frustfm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1350f20edc3fbfc2b217a4eaa81bbaf14736a0dd [INFO] linting coumcashier/rustfm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoumcashier%2Frustfm" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/coumcashier/rustfm [INFO] finished tweaking git repo https://github.com/coumcashier/rustfm [INFO] tweaked toml for git repo https://github.com/coumcashier/rustfm written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/coumcashier/rustfm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/coumcashier/rustfm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: executables [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tiny-skia-path v0.7.0 [INFO] [stderr] Downloaded sctk-adwaita v0.4.3 [INFO] [stderr] Downloaded crossfont v0.5.1 [INFO] [stderr] Downloaded imgui-winit-support v0.11.0 [INFO] [stderr] Downloaded value-bag v1.4.2 [INFO] [stderr] Downloaded ndk-glue v0.7.0 [INFO] [stderr] Downloaded servo-fontconfig v0.5.1 [INFO] [stderr] Downloaded wayland-egl v0.29.5 [INFO] [stderr] Downloaded chlorine v1.0.10 [INFO] [stderr] Downloaded async-global-executor v2.4.0 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.38 [INFO] [stderr] Downloaded imgui-glow-renderer v0.11.0 [INFO] [stderr] Downloaded async-io v2.2.1 [INFO] [stderr] Downloaded glutin v0.29.1 [INFO] [stderr] Downloaded imgui v0.11.0 [INFO] [stderr] Downloaded winnow v0.5.18 [INFO] [stderr] Downloaded freetype-rs v0.26.0 [INFO] [stderr] Downloaded serde v1.0.190 [INFO] [stderr] Downloaded rustix v0.38.21 [INFO] [stderr] Downloaded tiny-skia v0.7.0 [INFO] [stderr] Downloaded expat-sys v2.1.6 [INFO] [stderr] Downloaded serde_derive v1.0.190 [INFO] [stderr] Downloaded winit v0.27.5 [INFO] [stderr] Downloaded web-sys v0.3.65 [INFO] [stderr] Downloaded servo-fontconfig-sys v5.1.0 [INFO] [stderr] Downloaded imgui-sys v0.11.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fbd984f81e7b7bbdd0b59fd93b8acf809383f85b99c24913616c2375e45b5ba0 [INFO] running `Command { std: "docker" "start" "-a" "fbd984f81e7b7bbdd0b59fd93b8acf809383f85b99c24913616c2375e45b5ba0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fbd984f81e7b7bbdd0b59fd93b8acf809383f85b99c24913616c2375e45b5ba0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbd984f81e7b7bbdd0b59fd93b8acf809383f85b99c24913616c2375e45b5ba0", kill_on_drop: false }` [INFO] [stdout] fbd984f81e7b7bbdd0b59fd93b8acf809383f85b99c24913616c2375e45b5ba0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 56323d52bf5d0542d6f1477a27e208ada8fd4de71f6d2534a2fd1c08995601a4 [INFO] running `Command { std: "docker" "start" "-a" "56323d52bf5d0542d6f1477a27e208ada8fd4de71f6d2534a2fd1c08995601a4", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: executables [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking value-bag v1.4.2 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Compiling slotmap v1.0.6 [INFO] [stderr] Compiling servo-fontconfig-sys v5.1.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking event-listener v4.0.0 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking fdeflate v0.3.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling freetype-sys v0.13.1 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling crossfont v0.5.1 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tiny-skia-path v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking servo-fontconfig v0.5.1 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking freetype-rs v0.26.0 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Compiling imgui-sys v0.11.0 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking futures-lite v2.1.0 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking async-lock v3.2.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking tiny-skia v0.7.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking chlorine v1.0.10 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking async-task v4.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking async-channel v2.1.1 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking polling v3.3.1 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking async-io v2.2.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking async-global-executor v2.4.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking wayland-egl v0.29.5 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking glow v0.12.3 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking imgui v0.11.0 [INFO] [stderr] Checking imgui-glow-renderer v0.11.0 [INFO] [stderr] Checking sctk-adwaita v0.4.3 [INFO] [stderr] Checking winit v0.27.5 [INFO] [stderr] Checking glutin v0.29.1 [INFO] [stderr] Checking imgui-winit-support v0.11.0 [INFO] [stderr] Checking rust-fm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `core_intrinsics` is internal to the compiler or standard library [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(core_intrinsics)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: using it is strongly discouraged [INFO] [stdout] = note: `#[warn(internal_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync::Mutex` [INFO] [stdout] --> src/main.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use std::{sync::Mutex, io::Write}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use chrono; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `async_std::task::JoinHandle` [INFO] [stdout] --> src/app_gui.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use async_std::task::JoinHandle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `glutin::event` [INFO] [stdout] --> src/app_gui.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use glutin::event; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EventLoopWindowTarget`, `EventLoop`, and `self` [INFO] [stdout] --> src/app_gui.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use glutin::event_loop::{self, EventLoop, EventLoopProxy, EventLoopWindowTarget}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `imgui::internal::RawCast` [INFO] [stdout] --> src/app_gui.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use imgui::internal::RawCast; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DirEntry` and `self` [INFO] [stdout] --> src/app_gui.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | use std::fs::{self, DirEntry}; [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Error` [INFO] [stdout] --> src/app_gui.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/app_gui.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/app_gui.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/app_gui.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 118 | ... if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 118 + if self.coreApp.parent_path() != self.coreApp.current_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/app_gui.rs:140:28 [INFO] [stdout] | [INFO] [stdout] 140 | if (change_dir == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 140 - if (change_dir == true) { [INFO] [stdout] 140 + if change_dir == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `event` [INFO] [stdout] --> src/imgui_main_loop.rs:4:54 [INFO] [stdout] | [INFO] [stdout] 4 | use glutin::{event_loop::EventLoop, WindowedContext, event}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/imgui_main_loop.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use imgui_winit_support; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/imgui_main_loop.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use glutin; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DirEntry`, `fmt::Error`, `rc::Rc`, and `self` [INFO] [stdout] --> src/core.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{path::PathBuf, fs::{self, DirEntry}, fmt::Error, rc::Rc}; [INFO] [stdout] | ^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `async_std::fs::ReadDir` [INFO] [stdout] --> src/core.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use async_std::fs::ReadDir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `async_std::stream::StreamExt` [INFO] [stdout] --> src/app_gui.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use async_std::stream::StreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let mut app = app_gui::AppGui::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/app_gui.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 78 | ... let mut paths = paths; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/app_gui.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | ... let mut paths = self.coreApp.list_dir(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/app_gui.rs:88:53 [INFO] [stdout] | [INFO] [stdout] 88 | ... Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop_proxy` [INFO] [stdout] --> src/imgui_main_loop.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | event_loop.run(move |event, event_loop_proxy, control_flow| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop_proxy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let mut s = Self { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_gui.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | } else if !self.list_dir_join_handle.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.list_dir_join_handle.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_gui.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 116 | if !self.dir_listing.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dir_listing.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_gui.rs:128:28 [INFO] [stdout] | [INFO] [stdout] 128 | if !self.dir_listing.as_ref().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dir_listing.as_ref().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app_gui.rs:99:41 [INFO] [stdout] | [INFO] [stdout] 99 | ... return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return Vec::new(); [INFO] [stdout] 99 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_gui.rs:116:25 [INFO] [stdout] | [INFO] [stdout] 116 | / if !self.dir_listing.is_none() { [INFO] [stdout] 117 | | if ui.button("../") { [INFO] [stdout] 118 | | if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 119 | | self.coreApp.change_path(self.coreApp.parent_path()); [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 116 ~ if !self.dir_listing.is_none() [INFO] [stdout] 117 ~ && ui.button("../") { [INFO] [stdout] 118 | if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] ... [INFO] [stdout] 123 | } [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_gui.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | / ... if ui.button("../") { [INFO] [stdout] 118 | | ... if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 119 | | ... self.coreApp.change_path(self.coreApp.parent_path()); [INFO] [stdout] 120 | | ... self.dir_listing = None; [INFO] [stdout] ... | [INFO] [stdout] 124 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ if ui.button("../") [INFO] [stdout] 118 ~ && (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 119 | self.coreApp.change_path(self.coreApp.parent_path()); [INFO] [stdout] ... [INFO] [stdout] 122 | proxy.lock().unwrap().send_event(()).unwrap(); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/app_gui.rs:140:29 [INFO] [stdout] | [INFO] [stdout] 140 | if (change_dir == true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `change_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 12 | / let mut s = Self { [INFO] [stdout] 13 | | current_path: PathBuf::from("./").canonicalize().unwrap(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 15 | s [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 12 ~ [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + current_path: PathBuf::from("./").canonicalize().unwrap(), [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `coreApp` should have a snake case name [INFO] [stdout] --> src/app_gui.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | coreApp: App, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `core_app` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `box_patterns` is declared but not used [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(box_patterns)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `type_alias_impl_trait` is declared but not used [INFO] [stdout] --> src/main.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(type_alias_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_advance_by` is declared but not used [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iter_advance_by)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `core_intrinsics` is declared but not used [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(core_intrinsics)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `core_intrinsics` is internal to the compiler or standard library [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(core_intrinsics)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: using it is strongly discouraged [INFO] [stdout] = note: `#[warn(internal_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync::Mutex` [INFO] [stdout] --> src/main.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | use std::{sync::Mutex, io::Write}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use chrono; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `async_std::task::JoinHandle` [INFO] [stdout] --> src/app_gui.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use async_std::task::JoinHandle; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `glutin::event` [INFO] [stdout] --> src/app_gui.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use glutin::event; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EventLoopWindowTarget`, `EventLoop`, and `self` [INFO] [stdout] --> src/app_gui.rs:5:26 [INFO] [stdout] | [INFO] [stdout] 5 | use glutin::event_loop::{self, EventLoop, EventLoopProxy, EventLoopWindowTarget}; [INFO] [stdout] | ^^^^ ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `imgui::internal::RawCast` [INFO] [stdout] --> src/app_gui.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use imgui::internal::RawCast; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DirEntry` and `self` [INFO] [stdout] --> src/app_gui.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | use std::fs::{self, DirEntry}; [INFO] [stdout] | ^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Error` [INFO] [stdout] --> src/app_gui.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/app_gui.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::rc::Rc` [INFO] [stdout] --> src/app_gui.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::rc::Rc; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/app_gui.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 118 | ... if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 118 - if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 118 + if self.coreApp.parent_path() != self.coreApp.current_path { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/app_gui.rs:140:28 [INFO] [stdout] | [INFO] [stdout] 140 | if (change_dir == true) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 140 - if (change_dir == true) { [INFO] [stdout] 140 + if change_dir == true { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `event` [INFO] [stdout] --> src/imgui_main_loop.rs:4:54 [INFO] [stdout] | [INFO] [stdout] 4 | use glutin::{event_loop::EventLoop, WindowedContext, event}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/imgui_main_loop.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use imgui_winit_support; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/imgui_main_loop.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use glutin; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DirEntry`, `fmt::Error`, `rc::Rc`, and `self` [INFO] [stdout] --> src/core.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{path::PathBuf, fs::{self, DirEntry}, fmt::Error, rc::Rc}; [INFO] [stdout] | ^^^^ ^^^^^^^^ ^^^^^^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `async_std::fs::ReadDir` [INFO] [stdout] --> src/core.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use async_std::fs::ReadDir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `async_std::stream::StreamExt` [INFO] [stdout] --> src/app_gui.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use async_std::stream::StreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | let mut app = app_gui::AppGui::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/app_gui.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 78 | ... let mut paths = paths; [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/app_gui.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | ... let mut paths = self.coreApp.list_dir(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/app_gui.rs:88:53 [INFO] [stdout] | [INFO] [stdout] 88 | ... Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop_proxy` [INFO] [stdout] --> src/imgui_main_loop.rs:29:33 [INFO] [stdout] | [INFO] [stdout] 29 | event_loop.run(move |event, event_loop_proxy, control_flow| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop_proxy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | let mut s = Self { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_gui.rs:105:35 [INFO] [stdout] | [INFO] [stdout] 105 | } else if !self.list_dir_join_handle.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.list_dir_join_handle.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_gui.rs:116:28 [INFO] [stdout] | [INFO] [stdout] 116 | if !self.dir_listing.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dir_listing.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_gui.rs:128:28 [INFO] [stdout] | [INFO] [stdout] 128 | if !self.dir_listing.as_ref().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dir_listing.as_ref().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app_gui.rs:99:41 [INFO] [stdout] | [INFO] [stdout] 99 | ... return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return Vec::new(); [INFO] [stdout] 99 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_gui.rs:116:25 [INFO] [stdout] | [INFO] [stdout] 116 | / if !self.dir_listing.is_none() { [INFO] [stdout] 117 | | if ui.button("../") { [INFO] [stdout] 118 | | if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 119 | | self.coreApp.change_path(self.coreApp.parent_path()); [INFO] [stdout] ... | [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 116 ~ if !self.dir_listing.is_none() [INFO] [stdout] 117 ~ && ui.button("../") { [INFO] [stdout] 118 | if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] ... [INFO] [stdout] 123 | } [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_gui.rs:117:29 [INFO] [stdout] | [INFO] [stdout] 117 | / ... if ui.button("../") { [INFO] [stdout] 118 | | ... if (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 119 | | ... self.coreApp.change_path(self.coreApp.parent_path()); [INFO] [stdout] 120 | | ... self.dir_listing = None; [INFO] [stdout] ... | [INFO] [stdout] 124 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ if ui.button("../") [INFO] [stdout] 118 ~ && (self.coreApp.parent_path() != self.coreApp.current_path) { [INFO] [stdout] 119 | self.coreApp.change_path(self.coreApp.parent_path()); [INFO] [stdout] ... [INFO] [stdout] 122 | proxy.lock().unwrap().send_event(()).unwrap(); [INFO] [stdout] 123 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/app_gui.rs:140:29 [INFO] [stdout] | [INFO] [stdout] 140 | if (change_dir == true) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `change_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/core.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 12 | / let mut s = Self { [INFO] [stdout] 13 | | current_path: PathBuf::from("./").canonicalize().unwrap(), [INFO] [stdout] 14 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 15 | s [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 12 ~ [INFO] [stdout] 13 ~ Self { [INFO] [stdout] 14 + current_path: PathBuf::from("./").canonicalize().unwrap(), [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `coreApp` should have a snake case name [INFO] [stdout] --> src/app_gui.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | coreApp: App, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `core_app` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `box_patterns` is declared but not used [INFO] [stdout] --> src/main.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #![feature(box_patterns)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `type_alias_impl_trait` is declared but not used [INFO] [stdout] --> src/main.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | #![feature(type_alias_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_advance_by` is declared but not used [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iter_advance_by)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `core_intrinsics` is declared but not used [INFO] [stdout] --> src/main.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | #![feature(core_intrinsics)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 23s [INFO] running `Command { std: "docker" "inspect" "56323d52bf5d0542d6f1477a27e208ada8fd4de71f6d2534a2fd1c08995601a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56323d52bf5d0542d6f1477a27e208ada8fd4de71f6d2534a2fd1c08995601a4", kill_on_drop: false }` [INFO] [stdout] 56323d52bf5d0542d6f1477a27e208ada8fd4de71f6d2534a2fd1c08995601a4