[INFO] cloning repository https://github.com/cortexd-labs/mcpd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cortexd-labs/mcpd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcortexd-labs%2Fmcpd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcortexd-labs%2Fmcpd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e46bec1656f3fa382e353409d0f73cab6bc93479 [INFO] linting cortexd-labs/mcpd against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcortexd-labs%2Fmcpd" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cortexd-labs/mcpd [INFO] finished tweaking git repo https://github.com/cortexd-labs/mcpd [INFO] tweaked toml for git repo https://github.com/cortexd-labs/mcpd written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cortexd-labs/mcpd on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cortexd-labs/mcpd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded netlink-sys v0.8.8 [INFO] [stderr] Downloaded asn1-rs-derive v0.5.1 [INFO] [stderr] Downloaded asn1-rs-impl v0.2.0 [INFO] [stderr] Downloaded oid-registry v0.7.1 [INFO] [stderr] Downloaded der-parser v9.0.0 [INFO] [stderr] Downloaded rmcp-macros v0.16.0 [INFO] [stderr] Downloaded netlink-proto v0.11.5 [INFO] [stderr] Downloaded bollard-stubs v1.47.1-rc.27.3.1 [INFO] [stderr] Downloaded rtnetlink v0.14.1 [INFO] [stderr] Downloaded procfs-core v0.17.0 [INFO] [stderr] Downloaded asn1-rs v0.6.2 [INFO] [stderr] Downloaded netlink-packet-route v0.19.0 [INFO] [stderr] Downloaded x509-parser v0.16.0 [INFO] [stderr] Downloaded procfs v0.17.0 [INFO] [stderr] Downloaded rmcp v0.16.0 [INFO] [stderr] Downloaded bollard v0.18.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4af7897307dec76face1ef512bbd7ad18adee08dd2bfea23b97f90cbba052e8a [INFO] running `Command { std: "docker" "start" "-a" "4af7897307dec76face1ef512bbd7ad18adee08dd2bfea23b97f90cbba052e8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4af7897307dec76face1ef512bbd7ad18adee08dd2bfea23b97f90cbba052e8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4af7897307dec76face1ef512bbd7ad18adee08dd2bfea23b97f90cbba052e8a", kill_on_drop: false }` [INFO] [stdout] 4af7897307dec76face1ef512bbd7ad18adee08dd2bfea23b97f90cbba052e8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af0c89c559e10e5de3f6659913ce5a5111cbb303362a9ea8d74a8a9ad7832f9f [INFO] running `Command { std: "docker" "start" "-a" "af0c89c559e10e5de3f6659913ce5a5111cbb303362a9ea8d74a8a9ad7832f9f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling ref-cast v1.0.25 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking endi v1.1.1 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Compiling oid-registry v0.7.1 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling rmcp v0.16.0 [INFO] [stderr] Compiling procfs v0.17.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling pastey v0.2.1 [INFO] [stderr] Checking data-encoding v2.10.0 [INFO] [stderr] Checking rusticata-macros v4.1.0 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking serde_with v3.17.0 [INFO] [stderr] Checking serde_spanned v1.0.4 [INFO] [stderr] Checking toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Checking toml v1.0.3+spec-1.1.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking getrandom v0.4.1 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling asn1-rs-derive v0.5.1 [INFO] [stderr] Compiling asn1-rs-impl v0.2.0 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling schemars_derive v1.2.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking netlink-packet-utils v0.5.2 [INFO] [stderr] Checking asn1-rs v0.6.2 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking netlink-packet-core v0.7.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking netlink-packet-route v0.19.0 [INFO] [stderr] Compiling rmcp-macros v0.16.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking der-parser v9.0.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking x509-parser v0.16.0 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking bollard-stubs v1.47.1-rc.27.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking schemars v1.2.1 [INFO] [stderr] Checking procfs-core v0.17.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking netlink-sys v0.8.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking netlink-proto v0.11.5 [INFO] [stderr] Checking rtnetlink v0.14.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyperlocal v0.9.1 [INFO] [stderr] Checking bollard v0.18.1 [INFO] [stderr] Checking mcpd v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/tools/file.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | / if is_last_chunk && *i == buffer.len() - 1 { [INFO] [stdout] 202 | | false [INFO] [stdout] 203 | | } else { [INFO] [stdout] 204 | | true [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `!(is_last_chunk && *i == buffer.len() - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/tools/file.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | / if is_last_chunk && *i == buffer.len() - 1 { [INFO] [stdout] 202 | | false [INFO] [stdout] 203 | | } else { [INFO] [stdout] 204 | | true [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________________^ help: you can reduce it to: `!(is_last_chunk && *i == buffer.len() - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tools/file.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | assert_eq!(val["is_file"].as_bool().unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 333 - assert_eq!(val["is_file"].as_bool().unwrap(), true); [INFO] [stdout] 333 + assert!(val["is_file"].as_bool().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tools/file.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | assert_eq!(result["is_dir"].as_bool().unwrap(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 340 - assert_eq!(result["is_dir"].as_bool().unwrap(), true); [INFO] [stdout] 340 + assert!(result["is_dir"].as_bool().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.38s [INFO] running `Command { std: "docker" "inspect" "af0c89c559e10e5de3f6659913ce5a5111cbb303362a9ea8d74a8a9ad7832f9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af0c89c559e10e5de3f6659913ce5a5111cbb303362a9ea8d74a8a9ad7832f9f", kill_on_drop: false }` [INFO] [stdout] af0c89c559e10e5de3f6659913ce5a5111cbb303362a9ea8d74a8a9ad7832f9f