[INFO] cloning repository https://github.com/corkine/ci-transfer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/corkine/ci-transfer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcorkine%2Fci-transfer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcorkine%2Fci-transfer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b1bf793ec94bf65dbb8da8d129203cac0eb12de8 [INFO] linting corkine/ci-transfer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcorkine%2Fci-transfer" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/corkine/ci-transfer [INFO] finished tweaking git repo https://github.com/corkine/ci-transfer [INFO] tweaked toml for git repo https://github.com/corkine/ci-transfer written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/corkine/ci-transfer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/corkine/ci-transfer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ipnet v2.10.0 [INFO] [stderr] Downloaded aliyun-oss-rust-sdk v0.2.1 [INFO] [stderr] Downloaded ssh2 v0.9.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf7f0b9ff3393f0b8a367a9b3cb52fbd228bcef167653a47f9b2468b42220c69 [INFO] running `Command { std: "docker" "start" "-a" "cf7f0b9ff3393f0b8a367a9b3cb52fbd228bcef167653a47f9b2468b42220c69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf7f0b9ff3393f0b8a367a9b3cb52fbd228bcef167653a47f9b2468b42220c69", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf7f0b9ff3393f0b8a367a9b3cb52fbd228bcef167653a47f9b2468b42220c69", kill_on_drop: false }` [INFO] [stdout] cf7f0b9ff3393f0b8a367a9b3cb52fbd228bcef167653a47f9b2468b42220c69 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d787de2d1854ae0c701caea42a2d7bed1539ae8e6ec2defdabfbf6600bda2b8e [INFO] running `Command { std: "docker" "start" "-a" "d787de2d1854ae0c701caea42a2d7bed1539ae8e6ec2defdabfbf6600bda2b8e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ipnet v2.10.0 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking ssh2 v0.9.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking aliyun-oss-rust-sdk v0.2.1 [INFO] [stderr] Checking ci-transfer v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/oss.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] 38 | | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] 39 | | Ok(s) => return parse_destination_oss(s), [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | }, [INFO] [stdout] 42 | | _ => (), [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Ok(decoded) = general_purpose::STANDARD.decode(&destination) { match std::str::from_utf8(&decoded) { [INFO] [stdout] 38 + Ok(s) => return parse_destination_oss(s), [INFO] [stdout] 39 + _ => (), [INFO] [stdout] 40 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/oss.rs:37:44 [INFO] [stdout] | [INFO] [stdout] 37 | match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/oss.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 38 | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 39 | | Ok(s) => return parse_destination_oss(s), [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | }, [INFO] [stdout] | |_________^ help: try: `if let Ok(s) = std::str::from_utf8(&decoded) { return parse_destination_oss(s) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/oss.rs:45:51 [INFO] [stdout] | [INFO] [stdout] 45 | serde_json::from_str(destination).map_err(|e| TransferError::JsonParseError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TransferError::JsonParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/oss.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | format!("Path {} is neither a file nor directory", source).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Path {} is neither a file nor directory", source)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ssh.rs:145:63 [INFO] [stdout] | [INFO] [stdout] 145 | if let Ok(decoded) = general_purpose::STANDARD.decode(&command) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ssh.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | / match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] 187 | | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] 188 | | Ok(s) => return parse_destination_ssh(s), [INFO] [stdout] 189 | | _ => (), [INFO] [stdout] 190 | | }, [INFO] [stdout] 191 | | _ => (), [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 186 ~ if let Ok(decoded) = general_purpose::STANDARD.decode(&destination) { match std::str::from_utf8(&decoded) { [INFO] [stdout] 187 + Ok(s) => return parse_destination_ssh(s), [INFO] [stdout] 188 + _ => (), [INFO] [stdout] 189 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ssh.rs:186:44 [INFO] [stdout] | [INFO] [stdout] 186 | match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ssh.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 187 | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 188 | | Ok(s) => return parse_destination_ssh(s), [INFO] [stdout] 189 | | _ => (), [INFO] [stdout] 190 | | }, [INFO] [stdout] | |_________^ help: try: `if let Ok(s) = std::str::from_utf8(&decoded) { return parse_destination_ssh(s) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if !transfer_done && !(has_precommands || has_commands) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(transfer_done || has_precommands || has_commands)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | / format!( [INFO] [stdout] 93 | | "Destination cannot be empty (unless you have precommands/commands for side-effect only operations), [INFO] [stdout] 94 | | you can put user:pass@ip:/path to use ssh destination, [INFO] [stdout] 95 | | or put json format like {json_str} to use aliyun oss destination [INFO] [stdout] ... | [INFO] [stdout] 98 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 92 ~ format!( [INFO] [stdout] 93 + "Destination cannot be empty (unless you have precommands/commands for side-effect only operations), [INFO] [stdout] 94 + you can put user:pass@ip:/path to use ssh destination, [INFO] [stdout] 95 + or put json format like {json_str} to use aliyun oss destination [INFO] [stdout] 96 + or use base64 encode ssh/oss format" [INFO] [stdout] 97 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | return Err(TransferError::Other(errors.join("\n").into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `errors.join("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ssh.rs:166:24 [INFO] [stdout] | [INFO] [stdout] 166 | fn escape_command(cmd: &str) -> Cow { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 166 | fn escape_command(cmd: &str) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/oss.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | / match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] 38 | | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] 39 | | Ok(s) => return parse_destination_oss(s), [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | }, [INFO] [stdout] 42 | | _ => (), [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Ok(decoded) = general_purpose::STANDARD.decode(&destination) { match std::str::from_utf8(&decoded) { [INFO] [stdout] 38 + Ok(s) => return parse_destination_oss(s), [INFO] [stdout] 39 + _ => (), [INFO] [stdout] 40 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/oss.rs:37:44 [INFO] [stdout] | [INFO] [stdout] 37 | match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/oss.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 38 | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 39 | | Ok(s) => return parse_destination_oss(s), [INFO] [stdout] 40 | | _ => (), [INFO] [stdout] 41 | | }, [INFO] [stdout] | |_________^ help: try: `if let Ok(s) = std::str::from_utf8(&decoded) { return parse_destination_oss(s) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/oss.rs:45:51 [INFO] [stdout] | [INFO] [stdout] 45 | serde_json::from_str(destination).map_err(|e| TransferError::JsonParseError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `TransferError::JsonParseError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/oss.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | format!("Path {} is neither a file nor directory", source).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("Path {} is neither a file nor directory", source)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ssh.rs:145:63 [INFO] [stdout] | [INFO] [stdout] 145 | if let Ok(decoded) = general_purpose::STANDARD.decode(&command) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ssh.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | / match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] 187 | | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] 188 | | Ok(s) => return parse_destination_ssh(s), [INFO] [stdout] 189 | | _ => (), [INFO] [stdout] 190 | | }, [INFO] [stdout] 191 | | _ => (), [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 186 ~ if let Ok(decoded) = general_purpose::STANDARD.decode(&destination) { match std::str::from_utf8(&decoded) { [INFO] [stdout] 187 + Ok(s) => return parse_destination_ssh(s), [INFO] [stdout] 188 + _ => (), [INFO] [stdout] 189 + } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ssh.rs:186:44 [INFO] [stdout] | [INFO] [stdout] 186 | match general_purpose::STANDARD.decode(&destination) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ssh.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 187 | Ok(decoded) => match std::str::from_utf8(&decoded) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 188 | | Ok(s) => return parse_destination_ssh(s), [INFO] [stdout] 189 | | _ => (), [INFO] [stdout] 190 | | }, [INFO] [stdout] | |_________^ help: try: `if let Ok(s) = std::str::from_utf8(&decoded) { return parse_destination_ssh(s) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if !transfer_done && !(has_precommands || has_commands) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(transfer_done || has_precommands || has_commands)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | / format!( [INFO] [stdout] 93 | | "Destination cannot be empty (unless you have precommands/commands for side-effect only operations), [INFO] [stdout] 94 | | you can put user:pass@ip:/path to use ssh destination, [INFO] [stdout] 95 | | or put json format like {json_str} to use aliyun oss destination [INFO] [stdout] ... | [INFO] [stdout] 98 | | .into(), [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 92 ~ format!( [INFO] [stdout] 93 + "Destination cannot be empty (unless you have precommands/commands for side-effect only operations), [INFO] [stdout] 94 + you can put user:pass@ip:/path to use ssh destination, [INFO] [stdout] 95 + or put json format like {json_str} to use aliyun oss destination [INFO] [stdout] 96 + or use base64 encode ssh/oss format" [INFO] [stdout] 97 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 108 | return Err(TransferError::Other(errors.join("\n").into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `errors.join("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/ssh.rs:166:24 [INFO] [stdout] | [INFO] [stdout] 166 | fn escape_command(cmd: &str) -> Cow { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 166 | fn escape_command(cmd: &str) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.00s [INFO] running `Command { std: "docker" "inspect" "d787de2d1854ae0c701caea42a2d7bed1539ae8e6ec2defdabfbf6600bda2b8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d787de2d1854ae0c701caea42a2d7bed1539ae8e6ec2defdabfbf6600bda2b8e", kill_on_drop: false }` [INFO] [stdout] d787de2d1854ae0c701caea42a2d7bed1539ae8e6ec2defdabfbf6600bda2b8e