[INFO] cloning repository https://github.com/corgijan/little-share [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/corgijan/little-share" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcorgijan%2Flittle-share", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcorgijan%2Flittle-share'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 35fbe39dd1081fc167a56c61492c5b6cef11e174 [INFO] linting corgijan/little-share against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcorgijan%2Flittle-share" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/corgijan/little-share [INFO] finished tweaking git repo https://github.com/corgijan/little-share [INFO] tweaked toml for git repo https://github.com/corgijan/little-share written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/corgijan/little-share on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/corgijan/little-share already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: target.armv7-unknown-linux-gnueabihf.linker [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded axum-core v0.4.3 [INFO] [stderr] Downloaded tokio-macros v2.3.0 [INFO] [stderr] Downloaded axum_static v1.7.1 [INFO] [stderr] Downloaded httparse v1.9.3 [INFO] [stderr] Downloaded cc v1.0.99 [INFO] [stderr] Downloaded object v0.36.0 [INFO] [stderr] Downloaded serde_path_to_error v0.1.16 [INFO] [stderr] Downloaded zerocopy v0.8.0-alpha.6 [INFO] [stderr] Downloaded rand_chacha v0.9.0-alpha.1 [INFO] [stderr] Downloaded minijinja v2.0.2 [INFO] [stderr] Downloaded zerocopy-derive v0.8.0-alpha.6 [INFO] [stderr] Downloaded http-range-header v0.4.1 [INFO] [stderr] Downloaded tokio-util v0.7.11 [INFO] [stderr] Downloaded axum v0.7.5 [INFO] [stderr] Downloaded miniz_oxide v0.7.3 [INFO] [stderr] Downloaded parking_lot v0.12.2 [INFO] [stderr] Downloaded rand v0.9.0-alpha.1 [INFO] [stderr] Downloaded tokio v1.38.0 [INFO] [stderr] Downloaded hyper-util v0.1.5 [INFO] [stderr] Downloaded rand_core v0.9.0-alpha.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d910aa1a76ff9b9cb773b76257a65fd90dc4a96215d7e104795a92c4a365087 [INFO] running `Command { std: "docker" "start" "-a" "6d910aa1a76ff9b9cb773b76257a65fd90dc4a96215d7e104795a92c4a365087", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d910aa1a76ff9b9cb773b76257a65fd90dc4a96215d7e104795a92c4a365087", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d910aa1a76ff9b9cb773b76257a65fd90dc4a96215d7e104795a92c4a365087", kill_on_drop: false }` [INFO] [stdout] 6d910aa1a76ff9b9cb773b76257a65fd90dc4a96215d7e104795a92c4a365087 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41c9dc13ead34c2725c66fcdc134425b16d1f3b9e1a7fcbd37fafbfda80a9e2e [INFO] running `Command { std: "docker" "start" "-a" "41c9dc13ead34c2725c66fcdc134425b16d1f3b9e1a7fcbd37fafbfda80a9e2e", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: target.armv7-unknown-linux-gnueabihf.linker [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling httparse v1.9.3 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling zerocopy v0.8.0-alpha.6 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking http-range-header v0.4.1 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking rand_core v0.9.0-alpha.1 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand v0.9.0-alpha.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking minijinja v2.0.2 [INFO] [stderr] Checking axum_static v1.7.1 [INFO] [stderr] Checking smbackup v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `axum::http::HeaderMap` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::http::HeaderMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Response` [INFO] [stdout] --> src/main.rs:4:38 [INFO] [stdout] | [INFO] [stdout] 4 | use axum::response::{Html, Redirect, Response}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::stream::StreamExt` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use futures_util::stream::StreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `create_folder` [INFO] [stdout] --> src/main.rs:6:28 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::file_handlers::{create_folder, create_folder_wrap}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Html` [INFO] [stdout] --> src/index_page.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use axum::response::{Html, IntoResponse, Response}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow::anyhow` [INFO] [stdout] --> src/backup.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::anyhow; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/fs_utils.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::Extension` [INFO] [stdout] --> src/fs_utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::Extension; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::http::HeaderMap` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::http::HeaderMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Response` [INFO] [stdout] --> src/main.rs:4:38 [INFO] [stdout] | [INFO] [stdout] 4 | use axum::response::{Html, Redirect, Response}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::stream::StreamExt` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use futures_util::stream::StreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `create_folder` [INFO] [stdout] --> src/main.rs:6:28 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::file_handlers::{create_folder, create_folder_wrap}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Html` [INFO] [stdout] --> src/index_page.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use axum::response::{Html, IntoResponse, Response}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow::anyhow` [INFO] [stdout] --> src/backup.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::anyhow; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/fs_utils.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `axum::Extension` [INFO] [stdout] --> src/fs_utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use axum::Extension; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | pub async fn upload_wrap(mut multipart: Multipart) -> impl IntoResponse { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut file = File::create(format!("{}/{}", tmp_folder, tmp_file_name)).await?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | while let Some(mut field) = multipart.next_field().await? { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 82 | let mut file_data = field.bytes().await?; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:179:37 [INFO] [stdout] | [INFO] [stdout] 179 | async fn stream_to_file(path: &str, mut data: Bytes) -> io::Result<()> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:40:26 [INFO] [stdout] | [INFO] [stdout] 40 | pub async fn upload_wrap(mut multipart: Multipart) -> impl IntoResponse { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::TryFutureExt` [INFO] [stdout] --> src/file_handlers.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use futures_util::TryFutureExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::TryStreamExt` [INFO] [stdout] --> src/file_handlers.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use futures_util::TryStreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/index_page.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | resp.unwrap_or_else(|e| error_resp) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/index_page.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/file_handlers.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `proper_file_name` is assigned to, but never used [INFO] [stdout] --> src/file_handlers.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | let mut proper_file_name = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_proper_file_name` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/file_handlers.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut file = File::create(format!("{}/{}", tmp_folder, tmp_file_name)).await?; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `proper_file_name` is never read [INFO] [stdout] --> src/file_handlers.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | proper_file_name = original_file_name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut file = File::create(format!("{}/{}", tmp_folder, tmp_file_name)).await?; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | while let Some(mut field) = multipart.next_field().await? { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 82 | let mut file_data = field.bytes().await?; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_handlers.rs:179:37 [INFO] [stdout] | [INFO] [stdout] 179 | async fn stream_to_file(path: &str, mut data: Bytes) -> io::Result<()> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `main_loc` [INFO] [stdout] --> src/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | let main_loc = fs_utils::get_main_loc(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_main_loc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `handler_wildcard` is never used [INFO] [stdout] --> src/main.rs:42:10 [INFO] [stdout] | [INFO] [stdout] 42 | async fn handler_wildcard(Path(path): Path) -> Html { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_file` is never used [INFO] [stdout] --> src/backup.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 58 | pub async fn write_file(file_name: String, data: Bytes) -> Result<(), anyhow::Error> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NaiveDateTime` is never constructed [INFO] [stdout] --> src/fs_utils.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | struct NaiveDateTime(i64, i32); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/index_page.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | resp.unwrap_or_else(|e| error_resp) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 14 - resp.unwrap_or_else(|e| error_resp) [INFO] [stdout] 14 + resp.unwrap_or(error_resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/index_page.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 24 - resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] 24 + resp.unwrap_or(error_resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/index_page.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | if !fs::metadata(loc.clone()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(loc.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/index_page.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / return Ok(Response::builder() [INFO] [stdout] 56 | | .status(200) [INFO] [stdout] 57 | | .body(tmpl.render(context!(files => files, current_path => path,breadcrumbs => bread_list, creation_on=> show_created_time... [INFO] [stdout] 58 | | .unwrap()); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 ~ Ok(Response::builder() [INFO] [stdout] 56 + .status(200) [INFO] [stdout] 57 + .body(tmpl.render(context!(files => files, current_path => path,breadcrumbs => bread_list, creation_on=> show_created_timestamp))?.into()) [INFO] [stdout] 58 ~ .unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/index_page.rs:36:31 [INFO] [stdout] | [INFO] [stdout] 36 | last_agg = last_agg + &*b + "/"; [INFO] [stdout] | ^^^ help: if you would like to reborrow, try removing `&*`: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/file_handlers.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 22 - resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] 22 + resp.unwrap_or(error_resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/file_handlers.rs:141:78 [INFO] [stdout] | [INFO] [stdout] 129 | if data && chunk_index.is_some() && total_chunks.is_some() && chunk_index == total_chunks && path.is_some() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 141 | let final_path = format!("{}{}/{}", crate::fs_utils::get_main_loc(), path.unwrap(), file_name); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file_handlers.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return Ok(Redirect::to("/").into_response()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return Ok(Redirect::to("/").into_response()); [INFO] [stdout] 163 + Ok(Redirect::to("/").into_response()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/file_handlers.rs:108:48 [INFO] [stdout] | [INFO] [stdout] 108 | original_file_ending = name.split('.').last().map(|s| s.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 108 - original_file_ending = name.split('.').last().map(|s| s.to_string()); [INFO] [stdout] 108 + original_file_ending = name.split('.').next_back().map(|s| s.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::TryFutureExt` [INFO] [stdout] --> src/file_handlers.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use futures_util::TryFutureExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::TryStreamExt` [INFO] [stdout] --> src/file_handlers.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use futures_util::TryStreamExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/index_page.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | resp.unwrap_or_else(|e| error_resp) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/file_handlers.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 125 | let cclone = chunk_index.clone().ok_or(anyhow::anyhow!("Chunk index not found"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chunk_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/index_page.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/file_handlers.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `proper_file_name` is assigned to, but never used [INFO] [stdout] --> src/file_handlers.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | let mut proper_file_name = None; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_proper_file_name` instead [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file` [INFO] [stdout] --> src/file_handlers.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | let mut file = File::create(format!("{}/{}", tmp_folder, tmp_file_name)).await?; [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `proper_file_name` is never read [INFO] [stdout] --> src/file_handlers.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | proper_file_name = original_file_name.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/file_handlers.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 181 | file.write_all(&*data)?; [INFO] [stdout] | ^^^^^^ help: try: `&data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file_handlers.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | / return show(Path(file_name), download).await.unwrap_or_else(|e| { [INFO] [stdout] 187 | | Response::builder() [INFO] [stdout] 188 | | .status(404) [INFO] [stdout] 189 | | .body(format!("Error: {}", e).into()) [INFO] [stdout] 190 | | .unwrap() [INFO] [stdout] 191 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 ~ show(Path(file_name), download).await.unwrap_or_else(|e| { [INFO] [stdout] 187 + Response::builder() [INFO] [stdout] 188 + .status(404) [INFO] [stdout] 189 + .body(format!("Error: {}", e).into()) [INFO] [stdout] 190 + .unwrap() [INFO] [stdout] 191 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backup.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | if !fs::metadata(loc).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(loc).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/backup.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | if std::env::var("GENERATE_DIRS").unwrap_or("false".to_string()).to_string() == "True".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("GENERATE_DIRS").unwrap_or("false".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/backup.rs:10:93 [INFO] [stdout] | [INFO] [stdout] 10 | if std::env::var("GENERATE_DIRS").unwrap_or("false".to_string()).to_string() == "True".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"True"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/backup.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | } else if path.is_file() { [INFO] [stdout] | ________________^ [INFO] [stdout] 50 | | if !dest_path.exists() { [INFO] [stdout] 51 | | fs::copy(&path, &dest_path)?; [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 49 ~ } else if path.is_file() [INFO] [stdout] 50 ~ && !dest_path.exists() { [INFO] [stdout] 51 | fs::copy(&path, &dest_path)?; [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/fs_utils.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | let creation_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `creation_time` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 50 ~ [INFO] [stdout] 51 ~ let creation_time = if std::env::var("PLATFORM").is_ok() && std::env::var("PLATFORM").unwrap() != "ARM"{ [INFO] [stdout] 52 ~ DateTime::from_timestamp(e.metadata().unwrap().created().unwrap().duration_since(UNIX_EPOCH).unwrap().as_secs() as i64, 0).unwrap().to_string() [INFO] [stdout] 53 | }else { [INFO] [stdout] 54 ~ "".to_string() [INFO] [stdout] 55 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/fs_utils.rs:58:37 [INFO] [stdout] | [INFO] [stdout] 58 | let extension = file_name.split('.').last().unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - let extension = file_name.split('.').last().unwrap().to_string(); [INFO] [stdout] 58 + let extension = file_name.split('.').next_back().unwrap().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:26:87 [INFO] [stdout] | [INFO] [stdout] 26 | .route("/upload/*key", get(|Path(path): Path|async move {Redirect::to(&*("/".to_owned() + &*path)).into_response()})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&("/".to_owned() + &*path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `main_loc` [INFO] [stdout] --> src/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | let main_loc = fs_utils::get_main_loc(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_main_loc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `handler_wildcard` is never used [INFO] [stdout] --> src/main.rs:42:10 [INFO] [stdout] | [INFO] [stdout] 42 | async fn handler_wildcard(Path(path): Path) -> Html { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write_file` is never used [INFO] [stdout] --> src/backup.rs:58:14 [INFO] [stdout] | [INFO] [stdout] 58 | pub async fn write_file(file_name: String, data: Bytes) -> Result<(), anyhow::Error> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `NaiveDateTime` is never constructed [INFO] [stdout] --> src/fs_utils.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | struct NaiveDateTime(i64, i32); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/index_page.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | resp.unwrap_or_else(|e| error_resp) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 14 - resp.unwrap_or_else(|e| error_resp) [INFO] [stdout] 14 + resp.unwrap_or(error_resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/index_page.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 24 - resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] 24 + resp.unwrap_or(error_resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/index_page.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | if !fs::metadata(loc.clone()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(loc.clone()).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/index_page.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | / return Ok(Response::builder() [INFO] [stdout] 56 | | .status(200) [INFO] [stdout] 57 | | .body(tmpl.render(context!(files => files, current_path => path,breadcrumbs => bread_list, creation_on=> show_created_time... [INFO] [stdout] 58 | | .unwrap()); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 ~ Ok(Response::builder() [INFO] [stdout] 56 + .status(200) [INFO] [stdout] 57 + .body(tmpl.render(context!(files => files, current_path => path,breadcrumbs => bread_list, creation_on=> show_created_timestamp))?.into()) [INFO] [stdout] 58 ~ .unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/index_page.rs:36:31 [INFO] [stdout] | [INFO] [stdout] 36 | last_agg = last_agg + &*b + "/"; [INFO] [stdout] | ^^^ help: if you would like to reborrow, try removing `&*`: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/file_handlers.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 22 - resp.unwrap_or_else(|e| error_resp ) [INFO] [stdout] 22 + resp.unwrap_or(error_resp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `path` after checking its variant with `is_some` [INFO] [stdout] --> src/file_handlers.rs:141:78 [INFO] [stdout] | [INFO] [stdout] 129 | if data && chunk_index.is_some() && total_chunks.is_some() && chunk_index == total_chunks && path.is_some() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 141 | let final_path = format!("{}{}/{}", crate::fs_utils::get_main_loc(), path.unwrap(), file_name); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file_handlers.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return Ok(Redirect::to("/").into_response()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return Ok(Redirect::to("/").into_response()); [INFO] [stdout] 163 + Ok(Redirect::to("/").into_response()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/file_handlers.rs:108:48 [INFO] [stdout] | [INFO] [stdout] 108 | original_file_ending = name.split('.').last().map(|s| s.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 108 - original_file_ending = name.split('.').last().map(|s| s.to_string()); [INFO] [stdout] 108 + original_file_ending = name.split('.').next_back().map(|s| s.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/file_handlers.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 125 | let cclone = chunk_index.clone().ok_or(anyhow::anyhow!("Chunk index not found"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `chunk_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/file_handlers.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 181 | file.write_all(&*data)?; [INFO] [stdout] | ^^^^^^ help: try: `&data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/file_handlers.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | / return show(Path(file_name), download).await.unwrap_or_else(|e| { [INFO] [stdout] 187 | | Response::builder() [INFO] [stdout] 188 | | .status(404) [INFO] [stdout] 189 | | .body(format!("Error: {}", e).into()) [INFO] [stdout] 190 | | .unwrap() [INFO] [stdout] 191 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 ~ show(Path(file_name), download).await.unwrap_or_else(|e| { [INFO] [stdout] 187 + Response::builder() [INFO] [stdout] 188 + .status(404) [INFO] [stdout] 189 + .body(format!("Error: {}", e).into()) [INFO] [stdout] 190 + .unwrap() [INFO] [stdout] 191 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/backup.rs:9:12 [INFO] [stdout] | [INFO] [stdout] 9 | if !fs::metadata(loc).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(loc).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/backup.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | if std::env::var("GENERATE_DIRS").unwrap_or("false".to_string()).to_string() == "True".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("GENERATE_DIRS").unwrap_or("false".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/backup.rs:10:93 [INFO] [stdout] | [INFO] [stdout] 10 | if std::env::var("GENERATE_DIRS").unwrap_or("false".to_string()).to_string() == "True".to_string(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"True"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/backup.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | } else if path.is_file() { [INFO] [stdout] | ________________^ [INFO] [stdout] 50 | | if !dest_path.exists() { [INFO] [stdout] 51 | | fs::copy(&path, &dest_path)?; [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 49 ~ } else if path.is_file() [INFO] [stdout] 50 ~ && !dest_path.exists() { [INFO] [stdout] 51 | fs::copy(&path, &dest_path)?; [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/fs_utils.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | let creation_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `creation_time` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 50 ~ [INFO] [stdout] 51 ~ let creation_time = if std::env::var("PLATFORM").is_ok() && std::env::var("PLATFORM").unwrap() != "ARM"{ [INFO] [stdout] 52 ~ DateTime::from_timestamp(e.metadata().unwrap().created().unwrap().duration_since(UNIX_EPOCH).unwrap().as_secs() as i64, 0).unwrap().to_string() [INFO] [stdout] 53 | }else { [INFO] [stdout] 54 ~ "".to_string() [INFO] [stdout] 55 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/fs_utils.rs:58:37 [INFO] [stdout] | [INFO] [stdout] 58 | let extension = file_name.split('.').last().unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - let extension = file_name.split('.').last().unwrap().to_string(); [INFO] [stdout] 58 + let extension = file_name.split('.').next_back().unwrap().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/main.rs:26:87 [INFO] [stdout] | [INFO] [stdout] 26 | .route("/upload/*key", get(|Path(path): Path|async move {Redirect::to(&*("/".to_owned() + &*path)).into_response()})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&("/".to_owned() + &*path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 47.60s [INFO] running `Command { std: "docker" "inspect" "41c9dc13ead34c2725c66fcdc134425b16d1f3b9e1a7fcbd37fafbfda80a9e2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41c9dc13ead34c2725c66fcdc134425b16d1f3b9e1a7fcbd37fafbfda80a9e2e", kill_on_drop: false }` [INFO] [stdout] 41c9dc13ead34c2725c66fcdc134425b16d1f3b9e1a7fcbd37fafbfda80a9e2e