[INFO] cloning repository https://github.com/copyleftdev/laconic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/copyleftdev/laconic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcopyleftdev%2Flaconic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcopyleftdev%2Flaconic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2f75da6e2364e45002ec850276b63f8f8aafabf6 [INFO] linting copyleftdev/laconic against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcopyleftdev%2Flaconic" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/copyleftdev/laconic [INFO] finished tweaking git repo https://github.com/copyleftdev/laconic [INFO] tweaked toml for git repo https://github.com/copyleftdev/laconic written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/copyleftdev/laconic on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/copyleftdev/laconic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded entities v1.0.1 [INFO] [stderr] Downloaded comrak v0.38.0 [INFO] [stderr] Downloaded tiktoken-rs v0.6.0 [INFO] [stderr] Downloaded caseless v0.2.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d58fc61d53077bdaf42d1f177c811a90aed8810b5c4e029ea6d86508f1f9ff97 [INFO] running `Command { std: "docker" "start" "-a" "d58fc61d53077bdaf42d1f177c811a90aed8810b5c4e029ea6d86508f1f9ff97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d58fc61d53077bdaf42d1f177c811a90aed8810b5c4e029ea6d86508f1f9ff97", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d58fc61d53077bdaf42d1f177c811a90aed8810b5c4e029ea6d86508f1f9ff97", kill_on_drop: false }` [INFO] [stdout] d58fc61d53077bdaf42d1f177c811a90aed8810b5c4e029ea6d86508f1f9ff97 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b8990550aca10b6ca7000d0b2ca2dba8c31a4708bb052aa9bacd5fc801b52e1c [INFO] running `Command { std: "docker" "start" "-a" "b8990550aca10b6ca7000d0b2ca2dba8c31a4708bb052aa9bacd5fc801b52e1c", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking deunicode v1.6.2 [INFO] [stderr] Checking caseless v0.2.2 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Checking entities v1.0.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Compiling rmcp v0.16.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking comrak v0.38.0 [INFO] [stderr] Checking ring v0.17.14 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking tiktoken-rs v0.6.0 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling ref-cast-impl v1.0.25 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling schemars_derive v1.2.1 [INFO] [stderr] Checking ref-cast v1.0.25 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling rmcp-macros v0.16.0 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking laconic-core v0.1.0 (/opt/rustwide/workdir/crates/laconic-core) [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/laconic-core/src/strategies/tables.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 65 | .filter(|s| !s.is_empty() || false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - .filter(|s| !s.is_empty() || false) [INFO] [stdout] 65 + .filter(|s| !s.is_empty()) [INFO] [stdout] | [INFO] [stdout] 65 - .filter(|s| !s.is_empty() || false) [INFO] [stdout] 65 + .filter(|s| !s.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/laconic-core/tests/fabric_corpus.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 29 | if entry.extension().map_or(false, |e| e == "md") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 29 - if entry.extension().map_or(false, |e| e == "md") { [INFO] [stdout] 29 + if entry.extension().is_some_and(|e| e == "md") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/laconic-core/tests/fabric_corpus.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 227 | if comp_fences % 2 != 0 && orig_fences % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `!comp_fences.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/laconic-core/tests/fabric_corpus.rs:227:36 [INFO] [stdout] | [INFO] [stdout] 227 | if comp_fences % 2 != 0 && orig_fences % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `orig_fences.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/laconic-core/src/strategies/tables.rs:65:21 [INFO] [stdout] | [INFO] [stdout] 65 | .filter(|s| !s.is_empty() || false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 - .filter(|s| !s.is_empty() || false) [INFO] [stdout] 65 + .filter(|s| !s.is_empty()) [INFO] [stdout] | [INFO] [stdout] 65 - .filter(|s| !s.is_empty() || false) [INFO] [stdout] 65 + .filter(|s| !s.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking schemars v1.2.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking laconic-cli v0.1.0 (/opt/rustwide/workdir/crates/laconic-cli) [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking laconic-mcp v0.1.0 (/opt/rustwide/workdir/crates/laconic-mcp) [INFO] [stdout] warning: field `tool_router` is never read [INFO] [stdout] --> crates/laconic-mcp/src/main.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 68 | pub struct LaconicService { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 69 | tool_router: ToolRouter, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LaconicService` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `tool_router` is never read [INFO] [stdout] --> crates/laconic-mcp/src/main.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 68 | pub struct LaconicService { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 69 | tool_router: ToolRouter, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LaconicService` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LaconicService` [INFO] [stdout] --> crates/laconic-mcp/src/main.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / pub fn new() -> Self { [INFO] [stdout] 74 | | Self { [INFO] [stdout] 75 | | tool_router: Self::tool_router(), [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 72 + impl Default for LaconicService { [INFO] [stdout] 73 + fn default() -> Self { [INFO] [stdout] 74 + Self::new() [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `LaconicService` [INFO] [stdout] --> crates/laconic-mcp/src/main.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | / pub fn new() -> Self { [INFO] [stdout] 74 | | Self { [INFO] [stdout] 75 | | tool_router: Self::tool_router(), [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 72 + impl Default for LaconicService { [INFO] [stdout] 73 + fn default() -> Self { [INFO] [stdout] 74 + Self::new() [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 41.46s [INFO] running `Command { std: "docker" "inspect" "b8990550aca10b6ca7000d0b2ca2dba8c31a4708bb052aa9bacd5fc801b52e1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8990550aca10b6ca7000d0b2ca2dba8c31a4708bb052aa9bacd5fc801b52e1c", kill_on_drop: false }` [INFO] [stdout] b8990550aca10b6ca7000d0b2ca2dba8c31a4708bb052aa9bacd5fc801b52e1c