[INFO] cloning repository https://github.com/conseg/stordy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/conseg/stordy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconseg%2Fstordy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconseg%2Fstordy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3b1b8afde8f04e08b4ce3064f1055202888a73b0 [INFO] linting conseg/stordy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconseg%2Fstordy" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/conseg/stordy [INFO] finished tweaking git repo https://github.com/conseg/stordy [INFO] tweaked toml for git repo https://github.com/conseg/stordy written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/conseg/stordy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/conseg/stordy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded base36 v0.0.1 [INFO] [stderr] Downloaded tonic-build v0.11.0 [INFO] [stderr] Downloaded num-complex v0.4.5 [INFO] [stderr] Downloaded cuid2 v0.1.2 [INFO] [stderr] Downloaded cuid v1.3.2 [INFO] [stderr] Downloaded cuid-util v0.1.0 [INFO] [stderr] Downloaded h2 v0.3.25 [INFO] [stderr] Downloaded tonic v0.11.0 [INFO] [stderr] Downloaded prost-build v0.12.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2f2c86b366bb02b3f6c739975df63fa26f6c5d9692986185e9e83167be78edc [INFO] running `Command { std: "docker" "start" "-a" "d2f2c86b366bb02b3f6c739975df63fa26f6c5d9692986185e9e83167be78edc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2f2c86b366bb02b3f6c739975df63fa26f6c5d9692986185e9e83167be78edc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2f2c86b366bb02b3f6c739975df63fa26f6c5d9692986185e9e83167be78edc", kill_on_drop: false }` [INFO] [stdout] d2f2c86b366bb02b3f6c739975df63fa26f6c5d9692986185e9e83167be78edc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 787f665e9fe0454e69b22aff677fdf5112b4728ca62c0d0df53b7f1fd37fe2c8 [INFO] running `Command { std: "docker" "start" "-a" "787f665e9fe0454e69b22aff677fdf5112b4728ca62c0d0df53b7f1fd37fe2c8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling prettyplease v0.2.16 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling fastrand v2.0.2 [INFO] [stderr] Compiling async-trait v0.1.79 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking cuid-util v0.1.0 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking atomic v0.5.3 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking cuid2 v0.1.2 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking base36 v0.0.1 [INFO] [stderr] Checking cuid v1.3.2 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling prost-derive v0.12.3 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking axum-core v0.3.4 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling prost v0.12.3 [INFO] [stderr] Compiling prost-types v0.12.3 [INFO] [stderr] Compiling prost-build v0.12.3 [INFO] [stderr] Compiling tonic-build v0.11.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking h2 v0.3.25 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling stordy v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking tonic v0.11.0 [INFO] [stdout] warning: unused variable: `request` [INFO] [stdout] --> src/transaction.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | request: Request, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `db_transaction` is never read [INFO] [stdout] --> src/block.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Block { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 16 | db_block: Arc>, [INFO] [stdout] 17 | db_transaction: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_last` is never used [INFO] [stdout] --> src/./btree.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl BTree { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn get_last(&self) -> Option<(String, Vec)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/block.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / pub mod block { [INFO] [stdout] 12 | | tonic::include_proto!("stordy.block"); // The string specified here must match the proto package name [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `request` [INFO] [stdout] --> src/transaction.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | request: Request, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `db_transaction` is never read [INFO] [stdout] --> src/block.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Block { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 16 | db_block: Arc>, [INFO] [stdout] 17 | db_transaction: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_last` is never used [INFO] [stdout] --> src/./btree.rs:33:10 [INFO] [stdout] | [INFO] [stdout] 9 | impl BTree { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn get_last(&self) -> Option<(String, Vec)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/block.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | / pub mod block { [INFO] [stdout] 12 | | tonic::include_proto!("stordy.block"); // The string specified here must match the proto package name [INFO] [stdout] 13 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 68 | buf.extend_from_slice(&two_bytes_of_block_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `two_bytes_of_block_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/block.rs:142:48 [INFO] [stdout] | [INFO] [stdout] 142 | file.seek(std::io::SeekFrom::Start(pointer as u64)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/./btree.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / match self.db.get(key).unwrap() { [INFO] [stdout] 23 | | Some(value) => Some(value.to_vec()), [INFO] [stdout] 24 | | None => None, [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ help: try: `self.db.get(key).unwrap().map(|value| value.to_vec())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/./btree.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !last.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `last.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:68:31 [INFO] [stdout] | [INFO] [stdout] 68 | buf.extend_from_slice(&two_bytes_of_block_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `two_bytes_of_block_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/transaction.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub mod transaction { [INFO] [stdout] 17 | | tonic::include_proto!("stordy.transaction"); // The string specified here must match the proto package name [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/block.rs:142:48 [INFO] [stdout] | [INFO] [stdout] 142 | file.seek(std::io::SeekFrom::Start(pointer as u64)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/./btree.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / match self.db.get(key).unwrap() { [INFO] [stdout] 23 | | Some(value) => Some(value.to_vec()), [INFO] [stdout] 24 | | None => None, [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ help: try: `self.db.get(key).unwrap().map(|value| value.to_vec())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/./btree.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !last.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `last.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/transaction.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub mod transaction { [INFO] [stdout] 17 | | tonic::include_proto!("stordy.transaction"); // The string specified here must match the proto package name [INFO] [stdout] 18 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/transaction.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | let qtd = match request.qtd { [INFO] [stdout] | ___________________^ [INFO] [stdout] 48 | | Some(x) => x, [INFO] [stdout] 49 | | None => 1, [INFO] [stdout] 50 | | }; [INFO] [stdout] | |_________^ help: replace with: `request.qtd.unwrap_or(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/transaction.rs:83:35 [INFO] [stdout] | [INFO] [stdout] 83 | buf.extend_from_slice(&two_bytes_of_transaction_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `two_bytes_of_transaction_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/transaction.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 85 | buf.extend_from_slice(&two_bytes_of_transaction_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `two_bytes_of_transaction_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/transaction.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 101 | buf.extend_from_slice(&shift.to_be_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `shift.to_be_bytes().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/transaction.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | buf.extend_from_slice(&block_public_key.as_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `block_public_key.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(tamanho_arquivo - 2 - size_last_transaction as u64)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/transaction.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | let shift = (tamanho_arquivo - 2 - size_last_transaction as u64).max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(tamanho_arquivo - 2 - size_last_transaction as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/transaction.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 47 | let qtd = match request.qtd { [INFO] [stdout] | ___________________^ [INFO] [stdout] 48 | | Some(x) => x, [INFO] [stdout] 49 | | None => 1, [INFO] [stdout] 50 | | }; [INFO] [stdout] | |_________^ help: replace with: `request.qtd.unwrap_or(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/transaction.rs:83:35 [INFO] [stdout] | [INFO] [stdout] 83 | buf.extend_from_slice(&two_bytes_of_transaction_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `two_bytes_of_transaction_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/transaction.rs:85:35 [INFO] [stdout] | [INFO] [stdout] 85 | buf.extend_from_slice(&two_bytes_of_transaction_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `two_bytes_of_transaction_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/transaction.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 101 | buf.extend_from_slice(&shift.to_be_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `shift.to_be_bytes().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/transaction.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | buf.extend_from_slice(&block_public_key.as_bytes().to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `block_public_key.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `(tamanho_arquivo - 2 - size_last_transaction as u64)` is never smaller than `0` and has therefore no effect [INFO] [stdout] --> src/transaction.rs:137:21 [INFO] [stdout] | [INFO] [stdout] 137 | let shift = (tamanho_arquivo - 2 - size_last_transaction as u64).max(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(tamanho_arquivo - 2 - size_last_transaction as u64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 42.43s [INFO] running `Command { std: "docker" "inspect" "787f665e9fe0454e69b22aff677fdf5112b4728ca62c0d0df53b7f1fd37fe2c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "787f665e9fe0454e69b22aff677fdf5112b4728ca62c0d0df53b7f1fd37fe2c8", kill_on_drop: false }` [INFO] [stdout] 787f665e9fe0454e69b22aff677fdf5112b4728ca62c0d0df53b7f1fd37fe2c8