[INFO] cloning repository https://github.com/connorwstein/exchange [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/connorwstein/exchange" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnorwstein%2Fexchange", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnorwstein%2Fexchange'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 680e880e82c8faa753b2b359fcf89eb50348115c [INFO] linting connorwstein/exchange against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconnorwstein%2Fexchange" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/connorwstein/exchange [INFO] finished tweaking git repo https://github.com/connorwstein/exchange [INFO] tweaked toml for git repo https://github.com/connorwstein/exchange written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/connorwstein/exchange on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/connorwstein/exchange already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded env_logger v0.5.13 [INFO] [stderr] Downloaded diesel v1.4.3 [INFO] [stderr] Downloaded libc v0.2.64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5153077e9cce04a1ba65d65624c4af5726a42217b5f2ca95fed2483d76019c4e [INFO] running `Command { std: "docker" "start" "-a" "5153077e9cce04a1ba65d65624c4af5726a42217b5f2ca95fed2483d76019c4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5153077e9cce04a1ba65d65624c4af5726a42217b5f2ca95fed2483d76019c4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5153077e9cce04a1ba65d65624c4af5726a42217b5f2ca95fed2483d76019c4e", kill_on_drop: false }` [INFO] [stdout] 5153077e9cce04a1ba65d65624c4af5726a42217b5f2ca95fed2483d76019c4e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54e869fc9e3ea3fd57d5cf4d8c1f04ee7b4f78d7d804f84345788075eede806c [INFO] running `Command { std: "docker" "start" "-a" "54e869fc9e3ea3fd57d5cf4d8c1f04ee7b4f78d7d804f84345788075eede806c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.64 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Compiling indexmap v1.3.0 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling pq-sys v0.4.6 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Compiling hyper v0.12.35 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Checking tokio-executor v0.1.8 [INFO] [stderr] Checking tokio-sync v0.1.7 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking http v0.1.19 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-timer v0.2.11 [INFO] [stderr] Checking tokio-threadpool v0.1.16 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking tokio-reactor v0.1.10 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking url v2.1.0 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Checking diesel v1.4.3 [INFO] [stderr] Checking serde_json v1.0.41 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking exchange v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/order_book.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | side: side, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `side` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `FillResult` [INFO] [stdout] --> src/order_book.rs:258:29 [INFO] [stdout] | [INFO] [stdout] 258 | use crate::order_book::{FillResult, OpenLimitOrder, OrderBook, Side, Symbol}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/order_book.rs:306:10 [INFO] [stdout] | [INFO] [stdout] 306 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/order_book.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/order_book.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | side: side, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `side` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `side` [INFO] [stdout] --> src/order_book.rs:450:26 [INFO] [stdout] | [INFO] [stdout] 450 | fn create_order_book(side: Side, orders: Vec) -> OrderBook { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_side` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_request` [INFO] [stdout] --> src/main.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | Err(order_request) => Box::new(future::ok( [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_request` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `order_request` [INFO] [stdout] --> src/main.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | Err(order_request) => Box::new(future::ok( [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_order_request` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `payload` [INFO] [stdout] --> src/main.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | let payload = String::new(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_payload` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `find_order` and `remove_order` are never used [INFO] [stdout] --> src/order_book.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 43 | impl OrderBook { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn find_order(&self, t: OpenLimitOrder) -> (Option, Option) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | pub fn remove_order(&mut self, t: OpenLimitOrder) -> Result<&'static str, &'static str> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AAPL` contains a capitalized acronym [INFO] [stdout] --> src/order_book.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | AAPL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aapl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MSFT` contains a capitalized acronym [INFO] [stdout] --> src/order_book.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | MSFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Msft` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AMZN` contains a capitalized acronym [INFO] [stdout] --> src/order_book.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | AMZN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Amzn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AAPL` contains a capitalized acronym [INFO] [stdout] --> src/order_book.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | AAPL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aapl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MSFT` contains a capitalized acronym [INFO] [stdout] --> src/order_book.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | MSFT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Msft` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AMZN` contains a capitalized acronym [INFO] [stdout] --> src/order_book.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | AMZN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Amzn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/order_book.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 36 | book: Box>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] = note: `#[warn(clippy::box_collection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return (*self.book).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return (*self.book).clone(); [INFO] [stdout] 52 + (*self.book).clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return (None, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return (None, None); [INFO] [stdout] 65 + (None, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/order_book.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | return (Some(i as usize), Some(j as usize)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/order_book.rs:61:52 [INFO] [stdout] | [INFO] [stdout] 61 | return (Some(i as usize), Some(j as usize)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok("successfully removed order"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok("successfully removed order"); [INFO] [stdout] 81 + Ok("successfully removed order") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if self.book[queue_index.unwrap()].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book[queue_index.unwrap()].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | return Ok(order); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return Ok(order); [INFO] [stdout] 134 + Ok(order) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `Box>`. Consider using just `Vec<..>` [INFO] [stdout] --> src/order_book.rs:36:11 [INFO] [stdout] | [INFO] [stdout] 36 | book: Box>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `Vec<..>` is already on the heap, `Box>` makes an extra allocation [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_collection [INFO] [stdout] = note: `#[warn(clippy::box_collection)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return (*self.book).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return (*self.book).clone(); [INFO] [stdout] 52 + (*self.book).clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return (None, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return (None, None); [INFO] [stdout] 65 + (None, None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `OpenLimitOrder` which implements the `Copy` trait [INFO] [stdout] --> src/order_book.rs:88:25 [INFO] [stdout] | [INFO] [stdout] 88 | let mut order = t.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/order_book.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | return (Some(i as usize), Some(j as usize)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/order_book.rs:61:52 [INFO] [stdout] | [INFO] [stdout] 61 | return (Some(i as usize), Some(j as usize)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `j` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return Ok("successfully removed order"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return Ok("successfully removed order"); [INFO] [stdout] 81 + Ok("successfully removed order") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if self.book[queue_index.unwrap()].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book[queue_index.unwrap()].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/order_book.rs:103:94 [INFO] [stdout] | [INFO] [stdout] 103 | } else if order_queue.front().unwrap().price < t.price && self.side == Side::Buy { [INFO] [stdout] | ______________________________________________________________________________________________^ [INFO] [stdout] 104 | | insert_index = Some(index); [INFO] [stdout] 105 | | break; [INFO] [stdout] 106 | | } else if order_queue.front().unwrap().price > t.price && self.side == Side::Sell { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/order_book.rs:106:95 [INFO] [stdout] | [INFO] [stdout] 106 | } else if order_queue.front().unwrap().price > t.price && self.side == Side::Sell { [INFO] [stdout] | _______________________________________________________________________________________________^ [INFO] [stdout] 107 | | insert_index = Some(index); [INFO] [stdout] 108 | | break; [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | return Ok(order); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return Ok(order); [INFO] [stdout] 134 + Ok(order) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return to_fill_price >= candidate_order_price; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return to_fill_price >= candidate_order_price; [INFO] [stdout] 141 + to_fill_price >= candidate_order_price [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | return Ok(orders); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return Ok(orders); [INFO] [stdout] 224 + Ok(orders) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 159 | if self.book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/order_book.rs:179:21 [INFO] [stdout] | [INFO] [stdout] 179 | remaining = remaining - order.amount as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining -= order.amount as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | if self.book[0].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book[0].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:192:16 [INFO] [stdout] | [INFO] [stdout] 192 | if self.book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `OpenLimitOrder` which implements the `Copy` trait [INFO] [stdout] --> src/order_book.rs:88:25 [INFO] [stdout] | [INFO] [stdout] 88 | let mut order = t.clone(); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to u32 [INFO] [stdout] --> src/order_book.rs:221:21 [INFO] [stdout] | [INFO] [stdout] 221 | amount: remaining.abs() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `remaining.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/order_book.rs:103:94 [INFO] [stdout] | [INFO] [stdout] 103 | } else if order_queue.front().unwrap().price < t.price && self.side == Side::Buy { [INFO] [stdout] | ______________________________________________________________________________________________^ [INFO] [stdout] 104 | | insert_index = Some(index); [INFO] [stdout] 105 | | break; [INFO] [stdout] 106 | | } else if order_queue.front().unwrap().price > t.price && self.side == Side::Sell { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/order_book.rs:106:95 [INFO] [stdout] | [INFO] [stdout] 106 | } else if order_queue.front().unwrap().price > t.price && self.side == Side::Sell { [INFO] [stdout] | _______________________________________________________________________________________________^ [INFO] [stdout] 107 | | insert_index = Some(index); [INFO] [stdout] 108 | | break; [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `OpenLimitOrder` which implements the `Copy` trait [INFO] [stdout] --> src/order_book.rs:243:35 [INFO] [stdout] | [INFO] [stdout] 243 | let mut extra_order = extra_order[0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `extra_order[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return to_fill_price >= candidate_order_price; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return to_fill_price >= candidate_order_price; [INFO] [stdout] 141 + to_fill_price >= candidate_order_price [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | return Ok(orders); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 224 - return Ok(orders); [INFO] [stdout] 224 + Ok(orders) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 159 | if self.book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/order_book.rs:179:21 [INFO] [stdout] | [INFO] [stdout] 179 | remaining = remaining - order.amount as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining -= order.amount as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | if self.book[0].len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book[0].is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/order_book.rs:192:16 [INFO] [stdout] | [INFO] [stdout] 192 | if self.book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to u32 [INFO] [stdout] --> src/order_book.rs:221:21 [INFO] [stdout] | [INFO] [stdout] 221 | amount: remaining.abs() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `remaining.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Side` [INFO] [stdout] 8 | pub enum Side { [INFO] [stdout] | ---- `Side` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `OpenLimitOrder` which implements the `Copy` trait [INFO] [stdout] --> src/order_book.rs:243:35 [INFO] [stdout] | [INFO] [stdout] 243 | let mut extra_order = extra_order[0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `extra_order[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Side` [INFO] [stdout] 8 | pub enum Side { [INFO] [stdout] | ---- `Side` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Symbol` [INFO] [stdout] 14 | pub enum Symbol { [INFO] [stdout] | ------ `Symbol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Symbol` [INFO] [stdout] 14 | pub enum Symbol { [INFO] [stdout] | ------ `Symbol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_OpenLimitOrder` [INFO] [stdout] 21 | pub struct OpenLimitOrder { [INFO] [stdout] | -------------- `OpenLimitOrder` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_OpenLimitOrder` [INFO] [stdout] 21 | pub struct OpenLimitOrder { [INFO] [stdout] | -------------- `OpenLimitOrder` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_FillResult` [INFO] [stdout] 31 | pub struct FillResult { [INFO] [stdout] | ---------- `FillResult` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_FillResult` [INFO] [stdout] 31 | pub struct FillResult { [INFO] [stdout] | ---------- `FillResult` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/order_book.rs:198:32 [INFO] [stdout] | [INFO] [stdout] 198 | panic!(result); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{:?}" format string to use the `Debug` implementation of `std::result::Result` [INFO] [stdout] | [INFO] [stdout] 198 | panic!("{:?}", result); [INFO] [stdout] | +++++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 198 - panic!(result); [INFO] [stdout] 198 + std::panic::panic_any(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/order_book.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | / self.add_order(OpenLimitOrder { [INFO] [stdout] 218 | | id: last_order.id, [INFO] [stdout] 219 | | price: last_order.price, [INFO] [stdout] 220 | | side: last_order.side, [INFO] [stdout] 221 | | amount: remaining.abs() as u32, [INFO] [stdout] 222 | | symbol: last_order.symbol, [INFO] [stdout] 223 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 217 | let _ = self.add_order(OpenLimitOrder { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/order_book.rs:242:46 [INFO] [stdout] | [INFO] [stdout] 242 | let mut orders_used = orders_used.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[order_book::OpenLimitOrder]` does not implement `Clone`, so calling `clone` on `&[order_book::OpenLimitOrder]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/order_book.rs:439:25 [INFO] [stdout] | [INFO] [stdout] 439 | assert!(!result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/order_book.rs:444:25 [INFO] [stdout] | [INFO] [stdout] 444 | assert!(!result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/order_book.rs:454:21 [INFO] [stdout] | [INFO] [stdout] 454 | assert!(!result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/order_book.rs:456:9 [INFO] [stdout] | [INFO] [stdout] 456 | return buy_ob; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 - return buy_ob; [INFO] [stdout] 456 + buy_ob [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/order_book.rs:499:17 [INFO] [stdout] | [INFO] [stdout] 499 | assert!(!result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/order_book.rs:580:17 [INFO] [stdout] | [INFO] [stdout] 580 | assert!(!result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/order_book.rs:307:26 [INFO] [stdout] | [INFO] [stdout] 307 | let test_cases = vec![ [INFO] [stdout] | __________________________^ [INFO] [stdout] 308 | | // Single add remove [INFO] [stdout] 309 | | TestCase { [INFO] [stdout] 310 | | add: vec![OpenLimitOrder { [INFO] [stdout] ... | [INFO] [stdout] 433 | | }, [INFO] [stdout] 434 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 307 ~ let test_cases = [TestCase { [INFO] [stdout] 308 + add: vec![OpenLimitOrder { [INFO] [stdout] 309 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 310 + amount: 10, [INFO] [stdout] 311 + symbol: Symbol::AAPL, [INFO] [stdout] 312 + side: Side::Buy, [INFO] [stdout] 313 + price: 5, [INFO] [stdout] 314 + }], [INFO] [stdout] 315 + expected_after_add: vec![VecDeque::from(vec![OpenLimitOrder { [INFO] [stdout] 316 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 317 + amount: 10, [INFO] [stdout] 318 + symbol: Symbol::AAPL, [INFO] [stdout] 319 + side: Side::Buy, [INFO] [stdout] 320 + price: 5, [INFO] [stdout] 321 + }])], [INFO] [stdout] 322 + remove: vec![OpenLimitOrder { [INFO] [stdout] 323 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 324 + amount: 10, [INFO] [stdout] 325 + symbol: Symbol::AAPL, [INFO] [stdout] 326 + side: Side::Buy, [INFO] [stdout] 327 + price: 5, [INFO] [stdout] 328 + }], [INFO] [stdout] 329 + expected_after_remove: Vec::new(), [INFO] [stdout] 330 + }, [INFO] [stdout] 331 + // Same price should queue [INFO] [stdout] 332 + TestCase { [INFO] [stdout] 333 + add: vec![ [INFO] [stdout] 334 + OpenLimitOrder { [INFO] [stdout] 335 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 336 + amount: 10, [INFO] [stdout] 337 + symbol: Symbol::AAPL, [INFO] [stdout] 338 + side: Side::Buy, [INFO] [stdout] 339 + price: 5, [INFO] [stdout] 340 + }, [INFO] [stdout] 341 + OpenLimitOrder { [INFO] [stdout] 342 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000001").unwrap(), [INFO] [stdout] 343 + amount: 10, [INFO] [stdout] 344 + symbol: Symbol::AAPL, [INFO] [stdout] 345 + side: Side::Buy, [INFO] [stdout] 346 + price: 5, [INFO] [stdout] 347 + }, [INFO] [stdout] 348 + ], [INFO] [stdout] 349 + expected_after_add: vec![VecDeque::from(vec![ [INFO] [stdout] 350 + OpenLimitOrder { [INFO] [stdout] 351 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 352 + amount: 10, [INFO] [stdout] 353 + symbol: Symbol::AAPL, [INFO] [stdout] 354 + side: Side::Buy, [INFO] [stdout] 355 + price: 5, [INFO] [stdout] 356 + }, [INFO] [stdout] 357 + OpenLimitOrder { [INFO] [stdout] 358 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000001").unwrap(), [INFO] [stdout] 359 + amount: 10, [INFO] [stdout] 360 + symbol: Symbol::AAPL, [INFO] [stdout] 361 + side: Side::Buy, [INFO] [stdout] 362 + price: 5, [INFO] [stdout] 363 + }, [INFO] [stdout] 364 + ])], [INFO] [stdout] 365 + remove: vec![OpenLimitOrder { [INFO] [stdout] 366 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 367 + amount: 10, [INFO] [stdout] 368 + symbol: Symbol::AAPL, [INFO] [stdout] 369 + side: Side::Buy, [INFO] [stdout] 370 + price: 5, [INFO] [stdout] 371 + }], [INFO] [stdout] 372 + expected_after_remove: vec![VecDeque::from(vec![OpenLimitOrder { [INFO] [stdout] 373 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000001").unwrap(), [INFO] [stdout] 374 + amount: 10, [INFO] [stdout] 375 + symbol: Symbol::AAPL, [INFO] [stdout] 376 + side: Side::Buy, [INFO] [stdout] 377 + price: 5, [INFO] [stdout] 378 + }])], [INFO] [stdout] 379 + }, [INFO] [stdout] 380 + // Maintain sort [INFO] [stdout] 381 + TestCase { [INFO] [stdout] 382 + add: vec![ [INFO] [stdout] 383 + OpenLimitOrder { [INFO] [stdout] 384 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 385 + amount: 10, [INFO] [stdout] 386 + symbol: Symbol::AAPL, [INFO] [stdout] 387 + side: Side::Buy, [INFO] [stdout] 388 + price: 4, [INFO] [stdout] 389 + }, [INFO] [stdout] 390 + OpenLimitOrder { [INFO] [stdout] 391 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000001").unwrap(), [INFO] [stdout] 392 + amount: 10, [INFO] [stdout] 393 + symbol: Symbol::AAPL, [INFO] [stdout] 394 + side: Side::Buy, [INFO] [stdout] 395 + price: 5, [INFO] [stdout] 396 + }, [INFO] [stdout] 397 + ], [INFO] [stdout] 398 + expected_after_add: vec![ [INFO] [stdout] 399 + VecDeque::from(vec![OpenLimitOrder { [INFO] [stdout] 400 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000001").unwrap(), [INFO] [stdout] 401 + amount: 10, [INFO] [stdout] 402 + symbol: Symbol::AAPL, [INFO] [stdout] 403 + side: Side::Buy, [INFO] [stdout] 404 + price: 5, [INFO] [stdout] 405 + }]), [INFO] [stdout] 406 + VecDeque::from(vec![OpenLimitOrder { [INFO] [stdout] 407 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 408 + amount: 10, [INFO] [stdout] 409 + symbol: Symbol::AAPL, [INFO] [stdout] 410 + side: Side::Buy, [INFO] [stdout] 411 + price: 4, [INFO] [stdout] 412 + }]), [INFO] [stdout] 413 + ], [INFO] [stdout] 414 + remove: Vec::new(), [INFO] [stdout] 415 + expected_after_remove: vec![ [INFO] [stdout] 416 + VecDeque::from(vec![OpenLimitOrder { [INFO] [stdout] 417 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000001").unwrap(), [INFO] [stdout] 418 + amount: 10, [INFO] [stdout] 419 + symbol: Symbol::AAPL, [INFO] [stdout] 420 + side: Side::Buy, [INFO] [stdout] 421 + price: 5, [INFO] [stdout] 422 + }]), [INFO] [stdout] 423 + VecDeque::from(vec![OpenLimitOrder { [INFO] [stdout] 424 + id: Uuid::parse_str("00000000-0000-0000-0000-000000000010").unwrap(), [INFO] [stdout] 425 + amount: 10, [INFO] [stdout] 426 + symbol: Symbol::AAPL, [INFO] [stdout] 427 + side: Side::Buy, [INFO] [stdout] 428 + price: 4, [INFO] [stdout] 429 + }]), [INFO] [stdout] 430 + ], [INFO] [stdout] 431 ~ }]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Side` [INFO] [stdout] 8 | pub enum Side { [INFO] [stdout] | ---- `Side` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, PartialEq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Side` [INFO] [stdout] 8 | pub enum Side { [INFO] [stdout] | ---- `Side` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:13:10 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Symbol` [INFO] [stdout] 14 | pub enum Symbol { [INFO] [stdout] | ------ `Symbol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:13:21 [INFO] [stdout] | [INFO] [stdout] 13 | #[derive(Serialize, Deserialize, Debug, Copy, Clone, Eq, PartialEq, Hash)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Symbol` [INFO] [stdout] 14 | pub enum Symbol { [INFO] [stdout] | ------ `Symbol` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_OpenLimitOrder` [INFO] [stdout] 21 | pub struct OpenLimitOrder { [INFO] [stdout] | -------------- `OpenLimitOrder` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_OpenLimitOrder` [INFO] [stdout] 21 | pub struct OpenLimitOrder { [INFO] [stdout] | -------------- `OpenLimitOrder` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:30:10 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_FillResult` [INFO] [stdout] 31 | pub struct FillResult { [INFO] [stdout] | ---------- `FillResult` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/order_book.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | #[derive(Serialize, Deserialize, Debug, Copy, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_FillResult` [INFO] [stdout] 31 | pub struct FillResult { [INFO] [stdout] | ---------- `FillResult` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/order_book.rs:198:32 [INFO] [stdout] | [INFO] [stdout] 198 | panic!(result); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{:?}" format string to use the `Debug` implementation of `std::result::Result` [INFO] [stdout] | [INFO] [stdout] 198 | panic!("{:?}", result); [INFO] [stdout] | +++++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 198 - panic!(result); [INFO] [stdout] 198 + std::panic::panic_any(result); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/order_book.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | / self.add_order(OpenLimitOrder { [INFO] [stdout] 218 | | id: last_order.id, [INFO] [stdout] 219 | | price: last_order.price, [INFO] [stdout] 220 | | side: last_order.side, [INFO] [stdout] 221 | | amount: remaining.abs() as u32, [INFO] [stdout] 222 | | symbol: last_order.symbol, [INFO] [stdout] 223 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 217 | let _ = self.add_order(OpenLimitOrder { [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/order_book.rs:242:46 [INFO] [stdout] | [INFO] [stdout] 242 | let mut orders_used = orders_used.clone().to_vec(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[order_book::OpenLimitOrder]` does not implement `Clone`, so calling `clone` on `&[order_book::OpenLimitOrder]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.15s [INFO] running `Command { std: "docker" "inspect" "54e869fc9e3ea3fd57d5cf4d8c1f04ee7b4f78d7d804f84345788075eede806c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54e869fc9e3ea3fd57d5cf4d8c1f04ee7b4f78d7d804f84345788075eede806c", kill_on_drop: false }` [INFO] [stdout] 54e869fc9e3ea3fd57d5cf4d8c1f04ee7b4f78d7d804f84345788075eede806c