[INFO] cloning repository https://github.com/conman2305/kastlewatch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/conman2305/kastlewatch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconman2305%2Fkastlewatch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconman2305%2Fkastlewatch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4b389f4f3b75543598f5c682fa5384a4caedc7ad [INFO] linting conman2305/kastlewatch against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fconman2305%2Fkastlewatch" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/conman2305/kastlewatch [INFO] finished tweaking git repo https://github.com/conman2305/kastlewatch [INFO] tweaked toml for git repo https://github.com/conman2305/kastlewatch written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/conman2305/kastlewatch on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/conman2305/kastlewatch already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tower-test v0.4.0 [INFO] [stderr] Downloaded kube v0.96.0 [INFO] [stderr] Downloaded tonic-prost v0.14.2 [INFO] [stderr] Downloaded bollard-buildkit-proto v0.7.0 [INFO] [stderr] Downloaded kube-derive v0.96.0 [INFO] [stderr] Downloaded jsonpath-rust v0.5.1 [INFO] [stderr] Downloaded astral-tokio-tar v0.5.6 [INFO] [stderr] Downloaded kube-client v0.96.0 [INFO] [stderr] Downloaded kube-runtime v0.96.0 [INFO] [stderr] Downloaded axum v0.8.7 [INFO] [stderr] Downloaded tonic v0.14.2 [INFO] [stderr] Downloaded bollard v0.19.4 [INFO] [stderr] Downloaded testcontainers-modules v0.13.0 [INFO] [stderr] Downloaded bollard-stubs v1.49.1-rc.28.4.0 [INFO] [stderr] Downloaded fluent-uri v0.1.4 [INFO] [stderr] Downloaded testcontainers v0.25.2 [INFO] [stderr] Downloaded jsonptr v0.4.7 [INFO] [stderr] Downloaded json-patch v2.0.0 [INFO] [stderr] Downloaded k8s-openapi v0.23.0 [INFO] [stderr] Downloaded openssl-src v300.5.4+3.5.4 [INFO] [stderr] Downloaded kube-core v0.96.0 [INFO] [stderr] Downloaded cc v1.2.48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7860158553d2baf70df888251ef99e4000bd411e28e6914e442c095e4ab512a1 [INFO] running `Command { std: "docker" "start" "-a" "7860158553d2baf70df888251ef99e4000bd411e28e6914e442c095e4ab512a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7860158553d2baf70df888251ef99e4000bd411e28e6914e442c095e4ab512a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7860158553d2baf70df888251ef99e4000bd411e28e6914e442c095e4ab512a1", kill_on_drop: false }` [INFO] [stdout] 7860158553d2baf70df888251ef99e4000bd411e28e6914e442c095e4ab512a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3821d1c476658ff344af93e128638e85c504cac211a6e5545b9c08c6b9af2099 [INFO] running `Command { std: "docker" "start" "-a" "3821d1c476658ff344af93e128638e85c504cac211a6e5545b9c08c6b9af2099", kill_on_drop: false }` [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling cc v1.2.48 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling zerocopy v0.8.30 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling pest v2.8.4 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking rustls-native-certs v0.8.2 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling prost-derive v0.14.1 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking axum-core v0.5.5 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling k8s-openapi v0.23.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling openssl-src v300.5.4+3.5.4 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking jsonptr v0.4.7 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking json-patch v2.0.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Checking ahash v0.7.8 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking webpki-roots v1.0.4 [INFO] [stderr] Checking ureq-proto v0.5.3 [INFO] [stderr] Compiling schemars_derive v0.8.22 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling enum-ordinalize-derive v4.3.2 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling pest_meta v2.8.4 [INFO] [stderr] Compiling bollard-buildkit-proto v0.7.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking prost v0.14.1 [INFO] [stderr] Compiling enum-ordinalize v4.3.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking prost-types v0.14.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling pest_generator v2.8.4 [INFO] [stderr] Checking schemars v0.8.22 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tower-http v0.6.7 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Checking dlv-list v0.3.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Compiling pest_derive v2.8.4 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking jsonpath-rust v0.5.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling educe v0.6.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking ron v0.7.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Compiling structmeta v0.3.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking filetime v0.2.26 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking ulid v1.2.1 [INFO] [stderr] Checking docker_credential v1.3.2 [INFO] [stderr] Checking etcetera v0.10.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking astral-tokio-tar v0.5.6 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Compiling ctor v0.2.9 [INFO] [stderr] Checking deadpool v0.12.3 [INFO] [stderr] Checking tower-test v0.4.0 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Checking config v0.13.4 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Compiling kube-derive v0.96.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling parse-display-derive v0.9.1 [INFO] [stderr] Checking axum v0.8.7 [INFO] [stderr] Checking parse-display v0.9.1 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking ureq v3.1.4 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-util v0.1.18 [INFO] [stderr] Checking kube-core v0.96.0 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyperlocal v0.9.1 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking wiremock v0.6.5 [INFO] [stderr] Checking tonic v0.14.2 [INFO] [stderr] Checking kube-client v0.96.0 [INFO] [stderr] Checking tonic-prost v0.14.2 [INFO] [stderr] Checking kube-runtime v0.96.0 [INFO] [stderr] Checking kube v0.96.0 [INFO] [stderr] Checking bollard-stubs v1.49.1-rc.28.4.0 [INFO] [stderr] Checking bollard v0.19.4 [INFO] [stderr] Checking testcontainers v0.25.2 [INFO] [stderr] Checking testcontainers-modules v0.13.0 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking kastlewatch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/controller/common.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Some(status) = obj.status() { [INFO] [stdout] 29 | | if let Some(last_checked_str) = &status.last_checked { [INFO] [stdout] 30 | | if let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] 31 | | let last_checked_utc = last_checked.with_timezone(&Utc); [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(status) = obj.status() [INFO] [stdout] 29 ~ && let Some(last_checked_str) = &status.last_checked { [INFO] [stdout] 30 | if let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] ... [INFO] [stdout] 47 | } [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/controller/common.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if let Some(last_checked_str) = &status.last_checked { [INFO] [stdout] 30 | | if let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] 31 | | let last_checked_utc = last_checked.with_timezone(&Utc); [INFO] [stdout] 32 | | let now = Utc::now(); [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ if let Some(last_checked_str) = &status.last_checked [INFO] [stdout] 30 ~ && let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] 31 | let last_checked_utc = last_checked.with_timezone(&Utc); [INFO] [stdout] ... [INFO] [stdout] 46 | } [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/controller/common.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Some(status) = obj.status() { [INFO] [stdout] 29 | | if let Some(last_checked_str) = &status.last_checked { [INFO] [stdout] 30 | | if let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] 31 | | let last_checked_utc = last_checked.with_timezone(&Utc); [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(status) = obj.status() [INFO] [stdout] 29 ~ && let Some(last_checked_str) = &status.last_checked { [INFO] [stdout] 30 | if let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] ... [INFO] [stdout] 47 | } [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/controller/common.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if let Some(last_checked_str) = &status.last_checked { [INFO] [stdout] 30 | | if let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] 31 | | let last_checked_utc = last_checked.with_timezone(&Utc); [INFO] [stdout] 32 | | let now = Utc::now(); [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ if let Some(last_checked_str) = &status.last_checked [INFO] [stdout] 30 ~ && let Ok(last_checked) = chrono::DateTime::parse_from_rfc3339(last_checked_str) { [INFO] [stdout] 31 | let last_checked_utc = last_checked.with_timezone(&Utc); [INFO] [stdout] ... [INFO] [stdout] 46 | } [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/controller/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod controller; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/controller/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod controller; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/shared/resources/common.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | let version = api_version.split('/').last().unwrap_or(&api_version); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - let version = api_version.split('/').last().unwrap_or(&api_version); [INFO] [stdout] 70 + let version = api_version.split('/').next_back().unwrap_or(&api_version); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/shared/resources/common.rs:113:1 [INFO] [stdout] | [INFO] [stdout] 113 | / pub async fn publish_event( [INFO] [stdout] 114 | | client: kube::Client, [INFO] [stdout] 115 | | resource_name: &str, [INFO] [stdout] 116 | | resource_kind: &str, [INFO] [stdout] ... | [INFO] [stdout] 121 | | type_: &str, [INFO] [stdout] 122 | | ) -> anyhow::Result<()> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/shared/resources/common.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | let version = api_version.split('/').last().unwrap_or(&api_version); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - let version = api_version.split('/').last().unwrap_or(&api_version); [INFO] [stdout] 70 + let version = api_version.split('/').next_back().unwrap_or(&api_version); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/shared/resources/common.rs:113:1 [INFO] [stdout] | [INFO] [stdout] 113 | / pub async fn publish_event( [INFO] [stdout] 114 | | client: kube::Client, [INFO] [stdout] 115 | | resource_name: &str, [INFO] [stdout] 116 | | resource_kind: &str, [INFO] [stdout] ... | [INFO] [stdout] 121 | | type_: &str, [INFO] [stdout] 122 | | ) -> anyhow::Result<()> { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/shared/resources/monitors/http_monitor/v1alpha1.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | status >= 200 && status < 300 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(200..300).contains(&status)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/shared/resources/monitors/http_monitor/v1alpha1.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | status >= 200 && status < 300 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(200..300).contains(&status)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/shared/resources/notifiers/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / if let Some(data) = secret.data { [INFO] [stdout] 32 | | if let Some(byte_string) = data.get(&secret_ref.key) { [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if let Some(data) = secret.data [INFO] [stdout] 32 ~ && let Some(byte_string) = data.get(&secret_ref.key) { [INFO] [stdout] 33 | // ByteString is a wrapper around Vec that decodes from base64 when deserialized from k8s json [INFO] [stdout] 34 | // but here we are accessing the decoded bytes directly from the ByteString [INFO] [stdout] 35 | return Ok(std::str::from_utf8(&byte_string.0)?.to_string()); [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/shared/resources/notifiers/mod.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / if let Some(data) = secret.data { [INFO] [stdout] 32 | | if let Some(byte_string) = data.get(&secret_ref.key) { [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if let Some(data) = secret.data [INFO] [stdout] 32 ~ && let Some(byte_string) = data.get(&secret_ref.key) { [INFO] [stdout] 33 | // ByteString is a wrapper around Vec that decodes from base64 when deserialized from k8s json [INFO] [stdout] 34 | // but here we are accessing the decoded bytes directly from the ByteString [INFO] [stdout] 35 | return Ok(std::str::from_utf8(&byte_string.0)?.to_string()); [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/discord_notification_test.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Some(reqs) = mock_server.received_requests().await { [INFO] [stdout] 91 | | if reqs.len() > 0 { [INFO] [stdout] 92 | | received = true; [INFO] [stdout] 93 | | break; [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Some(reqs) = mock_server.received_requests().await [INFO] [stdout] 91 ~ && reqs.len() > 0 { [INFO] [stdout] 92 | received = true; [INFO] [stdout] 93 | break; [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/discord_notification_test.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if reqs.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!reqs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 30s [INFO] running `Command { std: "docker" "inspect" "3821d1c476658ff344af93e128638e85c504cac211a6e5545b9c08c6b9af2099", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3821d1c476658ff344af93e128638e85c504cac211a6e5545b9c08c6b9af2099", kill_on_drop: false }` [INFO] [stdout] 3821d1c476658ff344af93e128638e85c504cac211a6e5545b9c08c6b9af2099