[INFO] cloning repository https://github.com/commafakir/advent-of-code-2020
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/commafakir/advent-of-code-2020" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcommafakir%2Fadvent-of-code-2020", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcommafakir%2Fadvent-of-code-2020'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 3cd3288ede6d79be887df20ad7613229d371c446
[INFO] linting commafakir/advent-of-code-2020 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcommafakir%2Fadvent-of-code-2020" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/commafakir/advent-of-code-2020
[INFO] finished tweaking git repo https://github.com/commafakir/advent-of-code-2020
[INFO] tweaked toml for git repo https://github.com/commafakir/advent-of-code-2020 written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/commafakir/advent-of-code-2020 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/commafakir/advent-of-code-2020 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 9301e0668136f2ec74877d03d458a4dde012e760aac37e425099f7700e54c896
[INFO] running `Command { std: "docker" "start" "-a" "9301e0668136f2ec74877d03d458a4dde012e760aac37e425099f7700e54c896", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "9301e0668136f2ec74877d03d458a4dde012e760aac37e425099f7700e54c896", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "9301e0668136f2ec74877d03d458a4dde012e760aac37e425099f7700e54c896", kill_on_drop: false }`
[INFO] [stdout] 9301e0668136f2ec74877d03d458a4dde012e760aac37e425099f7700e54c896
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] db9c4d2919d10f5394e3ad27ffe69dbf920e511065c5afdf8e3a32437b17beb2
[INFO] running `Command { std: "docker" "start" "-a" "db9c4d2919d10f5394e3ad27ffe69dbf920e511065c5afdf8e3a32437b17beb2", kill_on_drop: false }`
[INFO] [stderr]     Checking thread_local v1.0.1
[INFO] [stderr]     Checking regex-syntax v0.6.21
[INFO] [stderr]     Checking regex v1.4.2
[INFO] [stderr]     Checking advent-of-code-2020-rust v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/util/ioutil.rs:10:3
[INFO] [stdout]    |
[INFO] [stdout] 10 |   return fs::read_to_string(filename).expect("Can't open file");
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 10 -   return fs::read_to_string(filename).expect("Can't open file");
[INFO] [stdout] 10 +   fs::read_to_string(filename).expect("Can't open file")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/util/ioutil.rs:15:3
[INFO] [stdout]    |
[INFO] [stdout] 15 |   return parse(read_file(filename), parser);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 -   return parse(read_file(filename), parser);
[INFO] [stdout] 15 +   parse(read_file(filename), parser)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/util/ioutil.rs:19:3
[INFO] [stdout]    |
[INFO] [stdout] 19 | /   return data.lines().map(|raw| match parser(raw) {
[INFO] [stdout] 20 | |     Ok(v) => Ok(v),
[INFO] [stdout] 21 | |     Err(e) => Err(e)
[INFO] [stdout] 22 | |   }).collect();
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 ~   data.lines().map(|raw| match parser(raw) {
[INFO] [stdout] 20 +     Ok(v) => Ok(v),
[INFO] [stdout] 21 +     Err(e) => Err(e)
[INFO] [stdout] 22 ~   }).collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_1.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 |     return ("Day 1", p1, p2);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 -     return ("Day 1", p1, p2);
[INFO] [stdout] 19 +     ("Day 1", p1, p2)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]   --> src/day_1.rs:11:14
[INFO] [stdout]    |
[INFO] [stdout] 11 |       let p1 = match calculate_part_one() {
[INFO] [stdout]    |  ______________^
[INFO] [stdout] 12 | |       Some(res) => Some(res.to_string()),
[INFO] [stdout] 13 | |       None => None
[INFO] [stdout] 14 | |     };
[INFO] [stdout]    | |_____^ help: try: `calculate_part_one().map(|res| res.to_string())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]    = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]   --> src/day_1.rs:15:14
[INFO] [stdout]    |
[INFO] [stdout] 15 |       let p2 = match calculate_part_two() {
[INFO] [stdout]    |  ______________^
[INFO] [stdout] 16 | |       Some(res) => Some(res.to_string()),
[INFO] [stdout] 17 | |       None => None
[INFO] [stdout] 18 | |     };
[INFO] [stdout]    | |_____^ help: try: `calculate_part_two().map(|res| res.to_string())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 |     return ("Day 2", Some(p1), Some(p2));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -     return ("Day 2", Some(p1), Some(p2));
[INFO] [stdout] 23 +     ("Day 2", Some(p1), Some(p2))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:29:3
[INFO] [stdout]    |
[INFO] [stdout] 29 | /   return entries
[INFO] [stdout] 30 | |     .into_iter()
[INFO] [stdout] 31 | |     .filter(validator)
[INFO] [stdout] 32 | |     .collect::<Vec<PwdEntry>>()
[INFO] [stdout] 33 | |     .len();
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 ~   entries
[INFO] [stdout] 30 +     .into_iter()
[INFO] [stdout] 31 +     .filter(validator)
[INFO] [stdout] 32 +     .collect::<Vec<PwdEntry>>()
[INFO] [stdout] 33 ~     .len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:50:3
[INFO] [stdout]    |
[INFO] [stdout] 50 |   return found >= entry.min && found <= entry.max;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 50 -   return found >= entry.min && found <= entry.max;
[INFO] [stdout] 50 +   found >= entry.min && found <= entry.max
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_2.rs:47:7
[INFO] [stdout]    |
[INFO] [stdout] 47 |       found = found + 1;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^ help: replace it with: `found += 1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:60:3
[INFO] [stdout]    |
[INFO] [stdout] 60 |   return (first == entry.character || second == entry.character) && first != second;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 -   return (first == entry.character || second == entry.character) && first != second;
[INFO] [stdout] 60 +   (first == entry.character || second == entry.character) && first != second
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:77:7
[INFO] [stdout]    |
[INFO] [stdout] 77 |       return Err( ParseError { invalid_data: raw_line.to_string() });
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 77 -       return Err( ParseError { invalid_data: raw_line.to_string() });
[INFO] [stdout] 77 +       Err( ParseError { invalid_data: raw_line.to_string() })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/day_2.rs:72:18
[INFO] [stdout]    |
[INFO] [stdout] 72 |       character: captures.get(3).unwrap().as_str().chars().nth(0).unwrap(),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `captures.get(3).unwrap().as_str().chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     return ("Day 3", Some(p1), Some(p2));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 14 -     return ("Day 3", Some(p1), Some(p2));
[INFO] [stdout] 14 +     ("Day 3", Some(p1), Some(p2))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EMPTY` contains a capitalized acronym
[INFO] [stdout]   --> src/day_3.rs:21:3
[INFO] [stdout]    |
[INFO] [stdout] 21 |   EMPTY,
[INFO] [stdout]    |   ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Empty`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `TREE` contains a capitalized acronym
[INFO] [stdout]   --> src/day_3.rs:22:3
[INFO] [stdout]    |
[INFO] [stdout] 22 |   TREE
[INFO] [stdout]    |   ^^^^ help: consider making the acronym lowercase, except the initial letter: `Tree`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:28:3
[INFO] [stdout]    |
[INFO] [stdout] 28 |   return traverse_and_count(&prepare_data(), 3, 1);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -   return traverse_and_count(&prepare_data(), 3, 1);
[INFO] [stdout] 28 +   traverse_and_count(&prepare_data(), 3, 1)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:33:3
[INFO] [stdout]    |
[INFO] [stdout] 33 | /   return traverse_and_count(&data, 1, 1) * 
[INFO] [stdout] 34 | |     traverse_and_count(&data, 3, 1) *
[INFO] [stdout] 35 | |     traverse_and_count(&data, 5, 1) *
[INFO] [stdout] 36 | |     traverse_and_count(&data, 7, 1) *
[INFO] [stdout] 37 | |     traverse_and_count(&data, 1, 2);
[INFO] [stdout]    | |___________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 ~   traverse_and_count(&data, 1, 1) * 
[INFO] [stdout] 34 +     traverse_and_count(&data, 3, 1) *
[INFO] [stdout] 35 +     traverse_and_count(&data, 5, 1) *
[INFO] [stdout] 36 +     traverse_and_count(&data, 7, 1) *
[INFO] [stdout] 37 ~     traverse_and_count(&data, 1, 2)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:56:3
[INFO] [stdout]    |
[INFO] [stdout] 56 |   return trees_encountered;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 56 -   return trees_encountered;
[INFO] [stdout] 56 +   trees_encountered
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if`
[INFO] [stdout]   --> src/day_3.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 | /     match world[x][y] {
[INFO] [stdout] 47 | |       Thing::TREE => trees_encountered = trees_encountered + 1,
[INFO] [stdout] 48 | |       _ => ()
[INFO] [stdout] 49 | |     }
[INFO] [stdout]    | |_____^ help: try: `if world[x][y] == Thing::TREE { trees_encountered = trees_encountered + 1 }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:47:22
[INFO] [stdout]    |
[INFO] [stdout] 47 |       Thing::TREE => trees_encountered = trees_encountered + 1,
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trees_encountered += 1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:50:5
[INFO] [stdout]    |
[INFO] [stdout] 50 |     y = y + r_steps;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^ help: replace it with: `y += r_steps`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 |     x = x + d_steps;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^ help: replace it with: `x += d_steps`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:53:7
[INFO] [stdout]    |
[INFO] [stdout] 53 |       y = y - width;
[INFO] [stdout]    |       ^^^^^^^^^^^^^ help: replace it with: `y -= width`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/util/ioutil.rs:10:3
[INFO] [stdout]    |
[INFO] [stdout] 10 |   return fs::read_to_string(filename).expect("Can't open file");
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 10 -   return fs::read_to_string(filename).expect("Can't open file");
[INFO] [stdout] 10 +   fs::read_to_string(filename).expect("Can't open file")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/util/ioutil.rs:15:3
[INFO] [stdout]    |
[INFO] [stdout] 15 |   return parse(read_file(filename), parser);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 -   return parse(read_file(filename), parser);
[INFO] [stdout] 15 +   parse(read_file(filename), parser)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/util/ioutil.rs:19:3
[INFO] [stdout]    |
[INFO] [stdout] 19 | /   return data.lines().map(|raw| match parser(raw) {
[INFO] [stdout] 20 | |     Ok(v) => Ok(v),
[INFO] [stdout] 21 | |     Err(e) => Err(e)
[INFO] [stdout] 22 | |   }).collect();
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 ~   data.lines().map(|raw| match parser(raw) {
[INFO] [stdout] 20 +     Ok(v) => Ok(v),
[INFO] [stdout] 21 +     Err(e) => Err(e)
[INFO] [stdout] 22 ~   }).collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_1.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 |     return ("Day 1", p1, p2);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 -     return ("Day 1", p1, p2);
[INFO] [stdout] 19 +     ("Day 1", p1, p2)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]   --> src/day_1.rs:11:14
[INFO] [stdout]    |
[INFO] [stdout] 11 |       let p1 = match calculate_part_one() {
[INFO] [stdout]    |  ______________^
[INFO] [stdout] 12 | |       Some(res) => Some(res.to_string()),
[INFO] [stdout] 13 | |       None => None
[INFO] [stdout] 14 | |     };
[INFO] [stdout]    | |_____^ help: try: `calculate_part_one().map(|res| res.to_string())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]    = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]   --> src/day_1.rs:15:14
[INFO] [stdout]    |
[INFO] [stdout] 15 |       let p2 = match calculate_part_two() {
[INFO] [stdout]    |  ______________^
[INFO] [stdout] 16 | |       Some(res) => Some(res.to_string()),
[INFO] [stdout] 17 | |       None => None
[INFO] [stdout] 18 | |     };
[INFO] [stdout]    | |_____^ help: try: `calculate_part_two().map(|res| res.to_string())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/day_1.rs:77:13
[INFO] [stdout]    |
[INFO] [stdout] 77 |     assert!(!result.is_none());
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/day_1.rs:83:13
[INFO] [stdout]    |
[INFO] [stdout] 83 |     assert!(!result.is_none());
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^ help: try: `result.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 |     return ("Day 2", Some(p1), Some(p2));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 23 -     return ("Day 2", Some(p1), Some(p2));
[INFO] [stdout] 23 +     ("Day 2", Some(p1), Some(p2))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:29:3
[INFO] [stdout]    |
[INFO] [stdout] 29 | /   return entries
[INFO] [stdout] 30 | |     .into_iter()
[INFO] [stdout] 31 | |     .filter(validator)
[INFO] [stdout] 32 | |     .collect::<Vec<PwdEntry>>()
[INFO] [stdout] 33 | |     .len();
[INFO] [stdout]    | |__________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 ~   entries
[INFO] [stdout] 30 +     .into_iter()
[INFO] [stdout] 31 +     .filter(validator)
[INFO] [stdout] 32 +     .collect::<Vec<PwdEntry>>()
[INFO] [stdout] 33 ~     .len()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:50:3
[INFO] [stdout]    |
[INFO] [stdout] 50 |   return found >= entry.min && found <= entry.max;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 50 -   return found >= entry.min && found <= entry.max;
[INFO] [stdout] 50 +   found >= entry.min && found <= entry.max
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_2.rs:47:7
[INFO] [stdout]    |
[INFO] [stdout] 47 |       found = found + 1;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^ help: replace it with: `found += 1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:60:3
[INFO] [stdout]    |
[INFO] [stdout] 60 |   return (first == entry.character || second == entry.character) && first != second;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 -   return (first == entry.character || second == entry.character) && first != second;
[INFO] [stdout] 60 +   (first == entry.character || second == entry.character) && first != second
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_2.rs:77:7
[INFO] [stdout]    |
[INFO] [stdout] 77 |       return Err( ParseError { invalid_data: raw_line.to_string() });
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 77 -       return Err( ParseError { invalid_data: raw_line.to_string() });
[INFO] [stdout] 77 +       Err( ParseError { invalid_data: raw_line.to_string() })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/day_2.rs:72:18
[INFO] [stdout]    |
[INFO] [stdout] 72 |       character: captures.get(3).unwrap().as_str().chars().nth(0).unwrap(),
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `captures.get(3).unwrap().as_str().chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     return ("Day 3", Some(p1), Some(p2));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 14 -     return ("Day 3", Some(p1), Some(p2));
[INFO] [stdout] 14 +     ("Day 3", Some(p1), Some(p2))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `EMPTY` contains a capitalized acronym
[INFO] [stdout]   --> src/day_3.rs:21:3
[INFO] [stdout]    |
[INFO] [stdout] 21 |   EMPTY,
[INFO] [stdout]    |   ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Empty`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout]    = note: `#[warn(clippy::upper_case_acronyms)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: name `TREE` contains a capitalized acronym
[INFO] [stdout]   --> src/day_3.rs:22:3
[INFO] [stdout]    |
[INFO] [stdout] 22 |   TREE
[INFO] [stdout]    |   ^^^^ help: consider making the acronym lowercase, except the initial letter: `Tree`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:28:3
[INFO] [stdout]    |
[INFO] [stdout] 28 |   return traverse_and_count(&prepare_data(), 3, 1);
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -   return traverse_and_count(&prepare_data(), 3, 1);
[INFO] [stdout] 28 +   traverse_and_count(&prepare_data(), 3, 1)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:33:3
[INFO] [stdout]    |
[INFO] [stdout] 33 | /   return traverse_and_count(&data, 1, 1) * 
[INFO] [stdout] 34 | |     traverse_and_count(&data, 3, 1) *
[INFO] [stdout] 35 | |     traverse_and_count(&data, 5, 1) *
[INFO] [stdout] 36 | |     traverse_and_count(&data, 7, 1) *
[INFO] [stdout] 37 | |     traverse_and_count(&data, 1, 2);
[INFO] [stdout]    | |___________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 ~   traverse_and_count(&data, 1, 1) * 
[INFO] [stdout] 34 +     traverse_and_count(&data, 3, 1) *
[INFO] [stdout] 35 +     traverse_and_count(&data, 5, 1) *
[INFO] [stdout] 36 +     traverse_and_count(&data, 7, 1) *
[INFO] [stdout] 37 ~     traverse_and_count(&data, 1, 2)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/day_3.rs:56:3
[INFO] [stdout]    |
[INFO] [stdout] 56 |   return trees_encountered;
[INFO] [stdout]    |   ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 56 -   return trees_encountered;
[INFO] [stdout] 56 +   trees_encountered
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if`
[INFO] [stdout]   --> src/day_3.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 | /     match world[x][y] {
[INFO] [stdout] 47 | |       Thing::TREE => trees_encountered = trees_encountered + 1,
[INFO] [stdout] 48 | |       _ => ()
[INFO] [stdout] 49 | |     }
[INFO] [stdout]    | |_____^ help: try: `if world[x][y] == Thing::TREE { trees_encountered = trees_encountered + 1 }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:47:22
[INFO] [stdout]    |
[INFO] [stdout] 47 |       Thing::TREE => trees_encountered = trees_encountered + 1,
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trees_encountered += 1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:50:5
[INFO] [stdout]    |
[INFO] [stdout] 50 |     y = y + r_steps;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^ help: replace it with: `y += r_steps`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 |     x = x + d_steps;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^ help: replace it with: `x += d_steps`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/day_3.rs:53:7
[INFO] [stdout]    |
[INFO] [stdout] 53 |       y = y - width;
[INFO] [stdout]    |       ^^^^^^^^^^^^^ help: replace it with: `y -= width`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.75s
[INFO] running `Command { std: "docker" "inspect" "db9c4d2919d10f5394e3ad27ffe69dbf920e511065c5afdf8e3a32437b17beb2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "db9c4d2919d10f5394e3ad27ffe69dbf920e511065c5afdf8e3a32437b17beb2", kill_on_drop: false }`
[INFO] [stdout] db9c4d2919d10f5394e3ad27ffe69dbf920e511065c5afdf8e3a32437b17beb2