[INFO] cloning repository https://github.com/com4/wd-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/com4/wd-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcom4%2Fwd-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcom4%2Fwd-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eaf62f3905eb44a067db2aaf4b54bf2518db2df8 [INFO] linting com4/wd-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcom4%2Fwd-rs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-2-tc1/source/.cargo/config [INFO] started tweaking git repo https://github.com/com4/wd-rs [INFO] finished tweaking git repo https://github.com/com4/wd-rs [INFO] tweaked toml for git repo https://github.com/com4/wd-rs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/com4/wd-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/com4/wd-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded stderrlog v0.4.3 [INFO] [stderr] Downloaded chrono v0.4.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b1a35dd630de63a74e022a8a8b7d55f65ecbae756301d6580e3773ea1b4624e4 [INFO] running `Command { std: "docker" "start" "-a" "b1a35dd630de63a74e022a8a8b7d55f65ecbae756301d6580e3773ea1b4624e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b1a35dd630de63a74e022a8a8b7d55f65ecbae756301d6580e3773ea1b4624e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1a35dd630de63a74e022a8a8b7d55f65ecbae756301d6580e3773ea1b4624e4", kill_on_drop: false }` [INFO] [stdout] b1a35dd630de63a74e022a8a8b7d55f65ecbae756301d6580e3773ea1b4624e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc633ab950f1a2c0c5899ce91b2f785842da55f2a201a8daffff5d770b5b0ad0 [INFO] running `Command { std: "docker" "start" "-a" "fc633ab950f1a2c0c5899ce91b2f785842da55f2a201a8daffff5d770b5b0ad0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling time v0.1.43 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Compiling chrono v0.4.11 [INFO] [stderr] Compiling warpdir v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> build.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | .args(&["timeline", "-t", "ci", "-n", "1"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["timeline", "-t", "ci", "-n", "1"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking stderrlog v0.4.3 [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / return Ok(match env::var(ENV_RC_PATH) { [INFO] [stdout] 33 | | Ok(d) => d, [INFO] [stdout] 34 | | Err(_) => match home_dir() { [INFO] [stdout] ... | [INFO] [stdout] 54 | | }, [INFO] [stdout] 55 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Ok(match env::var(ENV_RC_PATH) { [INFO] [stdout] 33 + Ok(d) => d, [INFO] [stdout] 34 + Err(_) => match home_dir() { [INFO] [stdout] 35 + // Try the home directory [INFO] [stdout] 36 + Some(mut d) => { [INFO] [stdout] 37 + d.push(".warprc"); [INFO] [stdout] 38 + match d.to_str() { [INFO] [stdout] 39 + Some(path) => path.to_string(), [INFO] [stdout] 40 + None => { [INFO] [stdout] 41 + return Err(io::Error::new( [INFO] [stdout] 42 + io::ErrorKind::Other, [INFO] [stdout] 43 + "unable to guess path of rc file. (non-UTF8 chars in path)", [INFO] [stdout] 44 + )) [INFO] [stdout] 45 + } [INFO] [stdout] 46 + } [INFO] [stdout] 47 + } [INFO] [stdout] 48 + None => { [INFO] [stdout] 49 + return Err(io::Error::new( [INFO] [stdout] 50 + io::ErrorKind::Other, [INFO] [stdout] 51 + format!("unable to guess path of rc file. (unable to find home directory). try using {}", ENV_RC_PATH), [INFO] [stdout] 52 + )) [INFO] [stdout] 53 + } [INFO] [stdout] 54 + }, [INFO] [stdout] 55 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 42 | | io::ErrorKind::Other, [INFO] [stdout] 43 | | "unable to guess path of rc file. (non-UTF8 chars in path)", [INFO] [stdout] 44 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 41 ~ return Err(io::Error::other( [INFO] [stdout] 42 ~ "unable to guess path of rc file. (non-UTF8 chars in path)", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 50 | | io::ErrorKind::Other, [INFO] [stdout] 51 | | format!("unable to guess path of rc file. (unable to find home directory). try using {}", ENV_RC_PATH), [INFO] [stdout] 52 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 49 ~ return Err(io::Error::other( [INFO] [stdout] 50 ~ format!("unable to guess path of rc file. (unable to find home directory). try using {}", ENV_RC_PATH), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:149:15 [INFO] [stdout] | [INFO] [stdout] 149 | match write!(writer, "{}\n", v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 149 - match write!(writer, "{}\n", v) { [INFO] [stdout] 149 + match writeln!(writer, "{}", v) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | / return format!( [INFO] [stdout] 161 | | r#" [INFO] [stdout] 162 | | _wd_completions() {{ [INFO] [stdout] 163 | | COMMANDS="add clean help hook list path rm show" [INFO] [stdout] ... | [INFO] [stdout] 183 | | bin_name [INFO] [stdout] 184 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 ~ format!( [INFO] [stdout] 161 + r#" [INFO] [stdout] 162 + _wd_completions() {{ [INFO] [stdout] 163 + COMMANDS="add clean help hook list path rm show" [INFO] [stdout] 164 + # Maybe only warp points makes the most sense for completions... [INFO] [stdout] 165 + WARPS=`wd list --completion` [INFO] [stdout] 166 + COMPLETIONS="${{WARPS}}" [INFO] [stdout] 167 + COMPREPLY=($(compgen -W "${{COMPLETIONS}}" "${{COMP_WORDS[1]}}")) [INFO] [stdout] 168 + }} [INFO] [stdout] 169 + [INFO] [stdout] 170 + wd() {{ [INFO] [stdout] 171 + output=$({} $@) [INFO] [stdout] 172 + status_code=$? [INFO] [stdout] 173 + if [[ $status_code -eq 0 ]]; then [INFO] [stdout] 174 + cd "$output" [INFO] [stdout] 175 + elif [[ "$output" != "" ]]; then [INFO] [stdout] 176 + echo "$output" [INFO] [stdout] 177 + fi [INFO] [stdout] 178 + unset output [INFO] [stdout] 179 + unset status_code [INFO] [stdout] 180 + }} [INFO] [stdout] 181 + complete -F _wd_completions wd [INFO] [stdout] 182 + "#, [INFO] [stdout] 183 + bin_name [INFO] [stdout] 184 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | / return format!( [INFO] [stdout] 190 | | r#"wd() {{ [INFO] [stdout] 191 | | output=$({} $@) [INFO] [stdout] 192 | | status_code=$? [INFO] [stdout] ... | [INFO] [stdout] 212 | | bin_name [INFO] [stdout] 213 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 ~ format!( [INFO] [stdout] 190 + r#"wd() {{ [INFO] [stdout] 191 + output=$({} $@) [INFO] [stdout] 192 + status_code=$? [INFO] [stdout] 193 + if [[ $status_code -eq 0 ]]; then [INFO] [stdout] 194 + cd "$output" [INFO] [stdout] 195 + elif [[ "$output" != "" ]]; then [INFO] [stdout] 196 + echo "$output" [INFO] [stdout] 197 + fi [INFO] [stdout] 198 + unset output [INFO] [stdout] 199 + unset status_code [INFO] [stdout] 200 + }} [INFO] [stdout] 201 + [INFO] [stdout] 202 + function _wd {{ [INFO] [stdout] 203 + local line [INFO] [stdout] 204 + WARPS=`wd list --completion` [INFO] [stdout] 205 + _arguments -C \ [INFO] [stdout] 206 + "1: :(${{WARPS}})" \ [INFO] [stdout] 207 + "*::arg:->args" [INFO] [stdout] 208 + }} [INFO] [stdout] 209 + [INFO] [stdout] 210 + compdef _wd wd [INFO] [stdout] 211 + "#, [INFO] [stdout] 212 + bin_name [INFO] [stdout] 213 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return format!("{}{}{}", version, build_vcs_hash, build_timestamp); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return format!("{}{}{}", version, build_vcs_hash, build_timestamp); [INFO] [stdout] 231 + format!("{}{}{}", version, build_vcs_hash, build_timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | format!("{}", crate_version!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `crate_version!().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:452:20 [INFO] [stdout] | [INFO] [stdout] 452 | if !fs::metadata(path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | format!("{}", crate_version!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `crate_version!().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded use of `concat!` macro [INFO] [stdout] --> src/main.rs:341:24 [INFO] [stdout] | [INFO] [stdout] 341 | .about(concat!("Print shell specific configuration")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `"Print shell specific configuration"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_concat [INFO] [stdout] = note: `#[warn(clippy::useless_concat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / return Ok(match env::var(ENV_RC_PATH) { [INFO] [stdout] 33 | | Ok(d) => d, [INFO] [stdout] 34 | | Err(_) => match home_dir() { [INFO] [stdout] ... | [INFO] [stdout] 54 | | }, [INFO] [stdout] 55 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ Ok(match env::var(ENV_RC_PATH) { [INFO] [stdout] 33 + Ok(d) => d, [INFO] [stdout] 34 + Err(_) => match home_dir() { [INFO] [stdout] 35 + // Try the home directory [INFO] [stdout] 36 + Some(mut d) => { [INFO] [stdout] 37 + d.push(".warprc"); [INFO] [stdout] 38 + match d.to_str() { [INFO] [stdout] 39 + Some(path) => path.to_string(), [INFO] [stdout] 40 + None => { [INFO] [stdout] 41 + return Err(io::Error::new( [INFO] [stdout] 42 + io::ErrorKind::Other, [INFO] [stdout] 43 + "unable to guess path of rc file. (non-UTF8 chars in path)", [INFO] [stdout] 44 + )) [INFO] [stdout] 45 + } [INFO] [stdout] 46 + } [INFO] [stdout] 47 + } [INFO] [stdout] 48 + None => { [INFO] [stdout] 49 + return Err(io::Error::new( [INFO] [stdout] 50 + io::ErrorKind::Other, [INFO] [stdout] 51 + format!("unable to guess path of rc file. (unable to find home directory). try using {}", ENV_RC_PATH), [INFO] [stdout] 52 + )) [INFO] [stdout] 53 + } [INFO] [stdout] 54 + }, [INFO] [stdout] 55 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(io::Error::new( [INFO] [stdout] | ________________________^ [INFO] [stdout] 42 | | io::ErrorKind::Other, [INFO] [stdout] 43 | | "unable to guess path of rc file. (non-UTF8 chars in path)", [INFO] [stdout] 44 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 41 ~ return Err(io::Error::other( [INFO] [stdout] 42 ~ "unable to guess path of rc file. (non-UTF8 chars in path)", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/main.rs:49:28 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(io::Error::new( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 50 | | io::ErrorKind::Other, [INFO] [stdout] 51 | | format!("unable to guess path of rc file. (unable to find home directory). try using {}", ENV_RC_PATH), [INFO] [stdout] 52 | | )) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 49 ~ return Err(io::Error::other( [INFO] [stdout] 50 ~ format!("unable to guess path of rc file. (unable to find home directory). try using {}", ENV_RC_PATH), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:149:15 [INFO] [stdout] | [INFO] [stdout] 149 | match write!(writer, "{}\n", v) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 149 - match write!(writer, "{}\n", v) { [INFO] [stdout] 149 + match writeln!(writer, "{}", v) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | / return format!( [INFO] [stdout] 161 | | r#" [INFO] [stdout] 162 | | _wd_completions() {{ [INFO] [stdout] 163 | | COMMANDS="add clean help hook list path rm show" [INFO] [stdout] ... | [INFO] [stdout] 183 | | bin_name [INFO] [stdout] 184 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 ~ format!( [INFO] [stdout] 161 + r#" [INFO] [stdout] 162 + _wd_completions() {{ [INFO] [stdout] 163 + COMMANDS="add clean help hook list path rm show" [INFO] [stdout] 164 + # Maybe only warp points makes the most sense for completions... [INFO] [stdout] 165 + WARPS=`wd list --completion` [INFO] [stdout] 166 + COMPLETIONS="${{WARPS}}" [INFO] [stdout] 167 + COMPREPLY=($(compgen -W "${{COMPLETIONS}}" "${{COMP_WORDS[1]}}")) [INFO] [stdout] 168 + }} [INFO] [stdout] 169 + [INFO] [stdout] 170 + wd() {{ [INFO] [stdout] 171 + output=$({} $@) [INFO] [stdout] 172 + status_code=$? [INFO] [stdout] 173 + if [[ $status_code -eq 0 ]]; then [INFO] [stdout] 174 + cd "$output" [INFO] [stdout] 175 + elif [[ "$output" != "" ]]; then [INFO] [stdout] 176 + echo "$output" [INFO] [stdout] 177 + fi [INFO] [stdout] 178 + unset output [INFO] [stdout] 179 + unset status_code [INFO] [stdout] 180 + }} [INFO] [stdout] 181 + complete -F _wd_completions wd [INFO] [stdout] 182 + "#, [INFO] [stdout] 183 + bin_name [INFO] [stdout] 184 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | / return format!( [INFO] [stdout] 190 | | r#"wd() {{ [INFO] [stdout] 191 | | output=$({} $@) [INFO] [stdout] 192 | | status_code=$? [INFO] [stdout] ... | [INFO] [stdout] 212 | | bin_name [INFO] [stdout] 213 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 ~ format!( [INFO] [stdout] 190 + r#"wd() {{ [INFO] [stdout] 191 + output=$({} $@) [INFO] [stdout] 192 + status_code=$? [INFO] [stdout] 193 + if [[ $status_code -eq 0 ]]; then [INFO] [stdout] 194 + cd "$output" [INFO] [stdout] 195 + elif [[ "$output" != "" ]]; then [INFO] [stdout] 196 + echo "$output" [INFO] [stdout] 197 + fi [INFO] [stdout] 198 + unset output [INFO] [stdout] 199 + unset status_code [INFO] [stdout] 200 + }} [INFO] [stdout] 201 + [INFO] [stdout] 202 + function _wd {{ [INFO] [stdout] 203 + local line [INFO] [stdout] 204 + WARPS=`wd list --completion` [INFO] [stdout] 205 + _arguments -C \ [INFO] [stdout] 206 + "1: :(${{WARPS}})" \ [INFO] [stdout] 207 + "*::arg:->args" [INFO] [stdout] 208 + }} [INFO] [stdout] 209 + [INFO] [stdout] 210 + compdef _wd wd [INFO] [stdout] 211 + "#, [INFO] [stdout] 212 + bin_name [INFO] [stdout] 213 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return format!("{}{}{}", version, build_vcs_hash, build_timestamp); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return format!("{}{}{}", version, build_vcs_hash, build_timestamp); [INFO] [stdout] 231 + format!("{}{}{}", version, build_vcs_hash, build_timestamp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | format!("{}", crate_version!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `crate_version!().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:452:20 [INFO] [stdout] | [INFO] [stdout] 452 | if !fs::metadata(path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | format!("{}", crate_version!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `crate_version!().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded use of `concat!` macro [INFO] [stdout] --> src/main.rs:341:24 [INFO] [stdout] | [INFO] [stdout] 341 | .about(concat!("Print shell specific configuration")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `"Print shell specific configuration"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_concat [INFO] [stdout] = note: `#[warn(clippy::useless_concat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.54s [INFO] running `Command { std: "docker" "inspect" "fc633ab950f1a2c0c5899ce91b2f785842da55f2a201a8daffff5d770b5b0ad0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc633ab950f1a2c0c5899ce91b2f785842da55f2a201a8daffff5d770b5b0ad0", kill_on_drop: false }` [INFO] [stdout] fc633ab950f1a2c0c5899ce91b2f785842da55f2a201a8daffff5d770b5b0ad0