[INFO] cloning repository https://github.com/coevolutions/canvasette [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/coevolutions/canvasette" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoevolutions%2Fcanvasette", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoevolutions%2Fcanvasette'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5441f5891986cb54b00d664562d47803fa2ed329 [INFO] linting coevolutions/canvasette against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoevolutions%2Fcanvasette" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/coevolutions/canvasette [INFO] finished tweaking git repo https://github.com/coevolutions/canvasette [INFO] tweaked toml for git repo https://github.com/coevolutions/canvasette written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/coevolutions/canvasette on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/coevolutions/canvasette already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sys-locale v0.3.1 [INFO] [stderr] Downloaded svg_fmt v0.4.3 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.4 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.4 [INFO] [stderr] Downloaded self_cell v1.0.4 [INFO] [stderr] Downloaded pin-project-internal v1.1.6 [INFO] [stderr] Downloaded font-types v0.7.2 [INFO] [stderr] Downloaded const_panic v0.2.10 [INFO] [stderr] Downloaded pin-project v1.1.6 [INFO] [stderr] Downloaded etagere v0.2.13 [INFO] [stderr] Downloaded fdeflate v0.3.5 [INFO] [stderr] Downloaded wayland-cursor v0.31.6 [INFO] [stderr] Downloaded spright v0.16.2 [INFO] [stderr] Downloaded wayland-client v0.31.6 [INFO] [stderr] Downloaded naga v23.0.0 [INFO] [stderr] Downloaded wayland-protocols v0.32.4 [INFO] [stderr] Downloaded image v0.25.2 [INFO] [stderr] Downloaded read-fonts v0.22.3 [INFO] [stderr] Downloaded glam v0.29.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54901339f0afd801a990c9a9adfe70622e5d0b4ecba420f67cc109b5d6ec407b [INFO] running `Command { std: "docker" "start" "-a" "54901339f0afd801a990c9a9adfe70622e5d0b4ecba420f67cc109b5d6ec407b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54901339f0afd801a990c9a9adfe70622e5d0b4ecba420f67cc109b5d6ec407b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54901339f0afd801a990c9a9adfe70622e5d0b4ecba420f67cc109b5d6ec407b", kill_on_drop: false }` [INFO] [stdout] 54901339f0afd801a990c9a9adfe70622e5d0b4ecba420f67cc109b5d6ec407b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f2549e9fc6c1899c448df720333360963cb266107b0adf17610e7db981e59ed [INFO] running `Command { std: "docker" "start" "-a" "7f2549e9fc6c1899c448df720333360963cb266107b0adf17610e7db981e59ed", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling cc v1.1.28 [INFO] [stderr] Compiling wayland-sys v0.31.5 [INFO] [stderr] Compiling wayland-client v0.31.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling naga v23.0.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling ash v0.38.0+1.3.281 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Compiling wgpu-hal v23.0.1 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Checking wgpu-types v23.0.0 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling wgpu-core v23.0.1 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Compiling wgpu v23.0.1 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-properties v0.1.3 [INFO] [stderr] Checking zeno v0.2.3 [INFO] [stderr] Checking unicode-script v0.5.7 [INFO] [stderr] Checking glam v0.29.0 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking unicode-ccc v0.2.0 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Checking const_panic v0.2.10 [INFO] [stderr] Checking fontconfig-parser v0.5.7 [INFO] [stderr] Checking unicode-bidi-mirroring v0.2.0 [INFO] [stderr] Checking yazi v0.1.6 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking euclid v0.22.11 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking fdeflate v0.3.5 [INFO] [stderr] Compiling wayland-scanner v0.31.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking svg_fmt v0.4.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.17 [INFO] [stderr] Checking rangemap v1.5.1 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking png v0.17.14 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Compiling wayland-backend v0.3.7 [INFO] [stderr] Checking gpu-descriptor v0.3.0 [INFO] [stderr] Checking etagere v0.2.13 [INFO] [stderr] Checking fontdb v0.16.2 [INFO] [stderr] Compiling encase_derive_impl v0.10.0 [INFO] [stderr] Compiling bytemuck_derive v1.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling encase_derive v0.10.0 [INFO] [stderr] Checking bytemuck v1.19.0 [INFO] [stderr] Checking font-types v0.7.2 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking rustybuzz v0.14.1 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking encase v0.10.0 [INFO] [stderr] Checking read-fonts v0.22.3 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.32.4 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-cursor v0.31.6 [INFO] [stderr] Checking skrifa v0.22.3 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.4 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.4 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking swash v0.1.19 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking winit v0.30.5 [INFO] [stderr] Checking cosmic-text v0.12.1 [INFO] [stderr] Checking spright v0.16.2 [INFO] [stderr] Checking canvasette v0.22.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/atlas.rs:186:54 [INFO] [stdout] | [INFO] [stdout] 186 | let Some(alloc_id) = self.allocations.remove(&key) else { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/lib.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / enum Command<'a> { [INFO] [stdout] 31 | | Sprite(Sprite<'a>), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 80 bytes [INFO] [stdout] 32 | | #[cfg(feature = "text")] [INFO] [stdout] 33 | | Text(text::Section), [INFO] [stdout] | | ------------------- the largest variant contains at least 368 bytes [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ the entire enum is at least 368 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 33 - Text(text::Section), [INFO] [stdout] 33 + Text(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/lib.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 177 | | Self { [INFO] [stdout] 178 | | texture: self.texture, [INFO] [stdout] 179 | | layer: self.layer, [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Canvas<'a>` [INFO] [stdout] --> src/lib.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 275 | / pub fn new() -> Self { [INFO] [stdout] 276 | | Self { commands: vec![] } [INFO] [stdout] 277 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 274 + impl<'a> Default for Canvas<'a> { [INFO] [stdout] 275 + fn default() -> Self { [INFO] [stdout] 276 + Self::new() [INFO] [stdout] 277 + } [INFO] [stdout] 278 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/atlas.rs:186:54 [INFO] [stdout] | [INFO] [stdout] 186 | let Some(alloc_id) = self.allocations.remove(&key) else { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/lib.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / enum Command<'a> { [INFO] [stdout] 31 | | Sprite(Sprite<'a>), [INFO] [stdout] | | ------------------ the second-largest variant contains at least 80 bytes [INFO] [stdout] 32 | | #[cfg(feature = "text")] [INFO] [stdout] 33 | | Text(text::Section), [INFO] [stdout] | | ------------------- the largest variant contains at least 368 bytes [INFO] [stdout] 34 | | } [INFO] [stdout] | |_^ the entire enum is at least 368 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 33 - Text(text::Section), [INFO] [stdout] 33 + Text(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/lib.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 176 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 177 | | Self { [INFO] [stdout] 178 | | texture: self.texture, [INFO] [stdout] 179 | | layer: self.layer, [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Canvas<'a>` [INFO] [stdout] --> src/lib.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 275 | / pub fn new() -> Self { [INFO] [stdout] 276 | | Self { commands: vec![] } [INFO] [stdout] 277 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 274 + impl<'a> Default for Canvas<'a> { [INFO] [stdout] 275 + fn default() -> Self { [INFO] [stdout] 276 + Self::new() [INFO] [stdout] 277 + } [INFO] [stdout] 278 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 58.94s [INFO] running `Command { std: "docker" "inspect" "7f2549e9fc6c1899c448df720333360963cb266107b0adf17610e7db981e59ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f2549e9fc6c1899c448df720333360963cb266107b0adf17610e7db981e59ed", kill_on_drop: false }` [INFO] [stdout] 7f2549e9fc6c1899c448df720333360963cb266107b0adf17610e7db981e59ed