[INFO] cloning repository https://github.com/coekfung/ebkit_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/coekfung/ebkit_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoekfung%2Febkit_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoekfung%2Febkit_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2eb04c71d69e75c25963505258ccc2cff0cfa3b5 [INFO] linting coekfung/ebkit_rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcoekfung%2Febkit_rs" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/coekfung/ebkit_rs [INFO] finished tweaking git repo https://github.com/coekfung/ebkit_rs [INFO] tweaked toml for git repo https://github.com/coekfung/ebkit_rs written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/coekfung/ebkit_rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/coekfung/ebkit_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e81d5704b929b7d69646ba5c1de58e340c2f04f17f07d9c3ead8b5ff3f6fa19b [INFO] running `Command { std: "docker" "start" "-a" "e81d5704b929b7d69646ba5c1de58e340c2f04f17f07d9c3ead8b5ff3f6fa19b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e81d5704b929b7d69646ba5c1de58e340c2f04f17f07d9c3ead8b5ff3f6fa19b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e81d5704b929b7d69646ba5c1de58e340c2f04f17f07d9c3ead8b5ff3f6fa19b", kill_on_drop: false }` [INFO] [stdout] e81d5704b929b7d69646ba5c1de58e340c2f04f17f07d9c3ead8b5ff3f6fa19b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4938c9307720d5f2c6989dd682df3d3f9b2c8865c4bb2d0cceedbea9b09514e4 [INFO] running `Command { std: "docker" "start" "-a" "4938c9307720d5f2c6989dd682df3d3f9b2c8865c4bb2d0cceedbea9b09514e4", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.23 [INFO] [stderr] Compiling anyhow v1.0.101 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking ebkit_core v0.1.0 (/opt/rustwide/workdir/ebkit_core) [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Checking proc-macro2 v1.0.106 [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> ebkit_core/src/lib.rs:69:1 [INFO] [stdout] | [INFO] [stdout] 69 | / impl Default for MetadataBuilder { [INFO] [stdout] 70 | | fn default() -> Self { [INFO] [stdout] 71 | | Self { [INFO] [stdout] 72 | | encoding: None, [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 56 + #[derive(Default)] [INFO] [stdout] 57 | pub struct MetadataBuilder { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ebkit_core/src/lib.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return self; [INFO] [stdout] 109 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> ebkit_core/src/lib.rs:69:1 [INFO] [stdout] | [INFO] [stdout] 69 | / impl Default for MetadataBuilder { [INFO] [stdout] 70 | | fn default() -> Self { [INFO] [stdout] 71 | | Self { [INFO] [stdout] 72 | | encoding: None, [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 56 + #[derive(Default)] [INFO] [stdout] 57 | pub struct MetadataBuilder { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ebkit_core/src/lib.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return self; [INFO] [stdout] 109 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking quote v1.0.44 [INFO] [stderr] Checking ebkit_macros v0.1.0 (/opt/rustwide/workdir/ebkit_macros) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> ebkit_macros/src/lib.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | / if let Type::Path(type_path) = word_ty { [INFO] [stdout] 252 | | if type_path.qself.is_none() && type_path.path.segments.len() == 1 { [INFO] [stdout] 253 | | let ident = &type_path.path.segments[0].ident; [INFO] [stdout] 254 | | if ident == "u16" { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 251 ~ if let Type::Path(type_path) = word_ty [INFO] [stdout] 252 ~ && type_path.qself.is_none() && type_path.path.segments.len() == 1 { [INFO] [stdout] 253 | let ident = &type_path.path.segments[0].ident; [INFO] [stdout] ... [INFO] [stdout] 262 | } [INFO] [stdout] 263 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> ebkit_macros/src/lib.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | / if let Type::Path(type_path) = word_ty { [INFO] [stdout] 252 | | if type_path.qself.is_none() && type_path.path.segments.len() == 1 { [INFO] [stdout] 253 | | let ident = &type_path.path.segments[0].ident; [INFO] [stdout] 254 | | if ident == "u16" { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 251 ~ if let Type::Path(type_path) = word_ty [INFO] [stdout] 252 ~ && type_path.qself.is_none() && type_path.path.segments.len() == 1 { [INFO] [stdout] 253 | let ident = &type_path.path.segments[0].ident; [INFO] [stdout] ... [INFO] [stdout] 262 | } [INFO] [stdout] 263 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> ebkit_macros/src/lib.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | / if let Type::Path(type_path) = word_ty { [INFO] [stdout] 252 | | if type_path.qself.is_none() && type_path.path.segments.len() == 1 { [INFO] [stdout] 253 | | let ident = &type_path.path.segments[0].ident; [INFO] [stdout] 254 | | if ident == "u16" { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 251 ~ if let Type::Path(type_path) = word_ty [INFO] [stdout] 252 ~ && type_path.qself.is_none() && type_path.path.segments.len() == 1 { [INFO] [stdout] 253 | let ident = &type_path.path.segments[0].ident; [INFO] [stdout] ... [INFO] [stdout] 262 | } [INFO] [stdout] 263 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ebkit_raw v0.1.0 (/opt/rustwide/workdir/ebkit_raw) [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> ebkit_raw/src/lib.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct RawReader { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 7 | inner: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `EvtDecoder` is never used [INFO] [stdout] --> ebkit_raw/src/evt/mod.rs:5:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait EvtDecoder { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Evt20Decoder` is never constructed [INFO] [stdout] --> ebkit_raw/src/evt/evt20.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Evt20Decoder { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `full_timestamp` are never used [INFO] [stdout] --> ebkit_raw/src/evt/evt20.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Evt20Decoder { [INFO] [stdout] | ----------------- associated items in this implementation [INFO] [stdout] 19 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | fn full_timestamp(&self, time_low: u8) -> i64 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Word` is never used [INFO] [stdout] --> ebkit_raw/src/evt/evt20.rs:110:6 [INFO] [stdout] | [INFO] [stdout] 110 | enum Word { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_u32` is never used [INFO] [stdout] --> ebkit_raw/src/evt/evt20.rs:159:8 [INFO] [stdout] | [INFO] [stdout] 158 | impl Word { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 159 | fn from_u32(data: u32) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'i [INFO] [stdout] --> ebkit_raw/src/header.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn raw_headers<'i>(input: &mut &'i [u8]) -> ModalResult { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 10 - pub fn raw_headers<'i>(input: &mut &'i [u8]) -> ModalResult { [INFO] [stdout] 10 + pub fn raw_headers(input: &mut &[u8]) -> ModalResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ebkit_raw/src/header.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !literal::<_, _, ()>(b"% ").parse_next(input).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `literal::<_, _, ()>(b"% ").parse_next(input).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> ebkit_raw/src/lib.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct RawReader { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 7 | inner: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'i [INFO] [stdout] --> ebkit_raw/src/header.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn raw_headers<'i>(input: &mut &'i [u8]) -> ModalResult { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 10 - pub fn raw_headers<'i>(input: &mut &'i [u8]) -> ModalResult { [INFO] [stdout] 10 + pub fn raw_headers(input: &mut &[u8]) -> ModalResult { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ebkit_raw/src/header.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if !literal::<_, _, ()>(b"% ").parse_next(input).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `literal::<_, _, ()>(b"% ").parse_next(input).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.77s [INFO] running `Command { std: "docker" "inspect" "4938c9307720d5f2c6989dd682df3d3f9b2c8865c4bb2d0cceedbea9b09514e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4938c9307720d5f2c6989dd682df3d3f9b2c8865c4bb2d0cceedbea9b09514e4", kill_on_drop: false }` [INFO] [stdout] 4938c9307720d5f2c6989dd682df3d3f9b2c8865c4bb2d0cceedbea9b09514e4