[INFO] cloning repository https://github.com/coderSomya/auction [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/coderSomya/auction" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FcoderSomya%2Fauction", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FcoderSomya%2Fauction'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 500462254236fb415ed562394100f3c8eac63a42 [INFO] linting coderSomya/auction against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FcoderSomya%2Fauction" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/coderSomya/auction [INFO] finished tweaking git repo https://github.com/coderSomya/auction [INFO] tweaked toml for git repo https://github.com/coderSomya/auction written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/coderSomya/auction on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/coderSomya/auction already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded scylla-cql v0.1.0 [INFO] [stderr] Downloaded strum_macros v0.23.1 [INFO] [stderr] Downloaded strum v0.23.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.28 [INFO] [stderr] Downloaded scylla-macros v0.4.0 [INFO] [stderr] Downloaded scylla v0.12.0 [INFO] [stderr] Downloaded zerocopy v0.8.28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 359ba414e769de6fd1c80d19f546f009ddb6b99eff264ecfae2dc55bcb8afbcd [INFO] running `Command { std: "docker" "start" "-a" "359ba414e769de6fd1c80d19f546f009ddb6b99eff264ecfae2dc55bcb8afbcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "359ba414e769de6fd1c80d19f546f009ddb6b99eff264ecfae2dc55bcb8afbcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "359ba414e769de6fd1c80d19f546f009ddb6b99eff264ecfae2dc55bcb8afbcd", kill_on_drop: false }` [INFO] [stdout] 359ba414e769de6fd1c80d19f546f009ddb6b99eff264ecfae2dc55bcb8afbcd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28a1c8c9c00ed4d125b032886626706859d4cd6083bc1d5a74d976a3a06c1070 [INFO] running `Command { std: "docker" "start" "-a" "28a1c8c9c00ed4d125b032886626706859d4cd6083bc1d5a74d976a3a06c1070", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.28 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling socket2 v0.6.1 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling cc v1.2.46 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling tokio v1.48.0 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling linux-raw-sys v0.11.0 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling sqlformat v0.2.6 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking twox-hash v2.1.2 [INFO] [stderr] Checking lz4_flex v0.11.5 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking rand_pcg v0.3.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking histogram v0.6.9 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking strum v0.23.0 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Compiling strum_macros v0.23.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling tempfile v3.23.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling num_enum_derive v0.6.1 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling scylla-macros v0.4.0 [INFO] [stderr] Checking num_enum v0.6.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Compiling sqlx-core v0.7.4 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking scylla-cql v0.1.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking hyper-util v0.1.18 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking scylla v0.12.0 [INFO] [stderr] Compiling sqlx-postgres v0.7.4 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Compiling sqlx-macros-core v0.7.4 [INFO] [stderr] Compiling sqlx-macros v0.7.4 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking sqlx v0.7.4 [INFO] [stderr] Checking auction v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `cricketer` and `price` are never read [INFO] [stdout] --> src/game.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | struct Buy{ [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 24 | cricketer: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 25 | price: u64 [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rooms` is never read [INFO] [stdout] --> src/ws/mod.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Hub { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 53 | /// room_id -> (user_id -> sender) [INFO] [stdout] 54 | rooms: Arc>>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hub` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `list_users` is never used [INFO] [stdout] --> src/ws/mod.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 58 | impl Hub { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 140 | fn list_users(&self, room_id: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game.rs:382:49 [INFO] [stdout] | [INFO] [stdout] 382 | let winning_amount = get_winning_amount(&self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ws/mod.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | ... .or_insert_with(|| DashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Some(user_map) = rooms_clone.get(&room_id) { [INFO] [stdout] 100 | | if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(user_map) = rooms_clone.get(&room_id) [INFO] [stdout] 100 ~ && let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 100 | / ... if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | ... if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | ... warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | | ... } [INFO] [stdout] 104 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Some(tx) = user_map.get(&to) [INFO] [stdout] 101 ~ && let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Evaluator` [INFO] [stdout] --> src/evaluator/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | Self { [INFO] [stdout] 27 | | evaluator: Box::new(random::Random), [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for Evaluator { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/integration_test.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cricketer` and `price` are never read [INFO] [stdout] --> src/game.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | struct Buy{ [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 24 | cricketer: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 25 | price: u64 [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rooms` is never read [INFO] [stdout] --> src/ws/mod.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Hub { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 53 | /// room_id -> (user_id -> sender) [INFO] [stdout] 54 | rooms: Arc>>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hub` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `list_users` is never used [INFO] [stdout] --> src/ws/mod.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 58 | impl Hub { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 140 | fn list_users(&self, room_id: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game.rs:382:49 [INFO] [stdout] | [INFO] [stdout] 382 | let winning_amount = get_winning_amount(&self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ws/mod.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | ... .or_insert_with(|| DashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Some(user_map) = rooms_clone.get(&room_id) { [INFO] [stdout] 100 | | if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(user_map) = rooms_clone.get(&room_id) [INFO] [stdout] 100 ~ && let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 100 | / ... if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | ... if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | ... warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | | ... } [INFO] [stdout] 104 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Some(tx) = user_map.get(&to) [INFO] [stdout] 101 ~ && let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Evaluator` [INFO] [stdout] --> src/evaluator/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | Self { [INFO] [stdout] 27 | | evaluator: Box::new(random::Random), [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for Evaluator { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/integration_test.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | / if let Ok(Message::Text(text)) = msg { [INFO] [stdout] 190 | | if let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 191 | | println!("WS Message: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 192 | | } [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 189 ~ if let Ok(Message::Text(text)) = msg [INFO] [stdout] 190 ~ && let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 191 | println!("WS Message: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/integration_test.rs:467:13 [INFO] [stdout] | [INFO] [stdout] 467 | / if let Ok(Message::Text(text)) = msg { [INFO] [stdout] 468 | | if let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 469 | | messages_clone1.lock().await.push(value.clone()); [INFO] [stdout] 470 | | println!("WS1 Message: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 471 | | } [INFO] [stdout] 472 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 467 ~ if let Ok(Message::Text(text)) = msg [INFO] [stdout] 468 ~ && let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 469 | messages_clone1.lock().await.push(value.clone()); [INFO] [stdout] 470 | println!("WS1 Message: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 471 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/integration_test.rs:483:13 [INFO] [stdout] | [INFO] [stdout] 483 | / if let Ok(Message::Text(text)) = msg { [INFO] [stdout] 484 | | if let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 485 | | messages_clone2.lock().await.push(value.clone()); [INFO] [stdout] 486 | | println!("WS2 Message: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 487 | | } [INFO] [stdout] 488 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 483 ~ if let Ok(Message::Text(text)) = msg [INFO] [stdout] 484 ~ && let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 485 | messages_clone2.lock().await.push(value.clone()); [INFO] [stdout] 486 | println!("WS2 Message: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 487 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/integration_test.rs:695:13 [INFO] [stdout] | [INFO] [stdout] 695 | / if let Ok(Message::Text(text)) = msg { [INFO] [stdout] 696 | | if let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 697 | | messages1.lock().await.push(value.clone()); [INFO] [stdout] 698 | | println!("Player1 WS: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 699 | | } [INFO] [stdout] 700 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 695 ~ if let Ok(Message::Text(text)) = msg [INFO] [stdout] 696 ~ && let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 697 | messages1.lock().await.push(value.clone()); [INFO] [stdout] 698 | println!("Player1 WS: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 699 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/integration_test.rs:710:13 [INFO] [stdout] | [INFO] [stdout] 710 | / if let Ok(Message::Text(text)) = msg { [INFO] [stdout] 711 | | if let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 712 | | messages2.lock().await.push(value.clone()); [INFO] [stdout] 713 | | println!("Player2 WS: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 714 | | } [INFO] [stdout] 715 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 710 ~ if let Ok(Message::Text(text)) = msg [INFO] [stdout] 711 ~ && let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 712 | messages2.lock().await.push(value.clone()); [INFO] [stdout] 713 | println!("Player2 WS: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 714 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/integration_test.rs:725:13 [INFO] [stdout] | [INFO] [stdout] 725 | / if let Ok(Message::Text(text)) = msg { [INFO] [stdout] 726 | | if let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 727 | | messages3.lock().await.push(value.clone()); [INFO] [stdout] 728 | | println!("Player3 WS: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 729 | | } [INFO] [stdout] 730 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 725 ~ if let Ok(Message::Text(text)) = msg [INFO] [stdout] 726 ~ && let Ok(value) = serde_json::from_str::(&text) { [INFO] [stdout] 727 | messages3.lock().await.push(value.clone()); [INFO] [stdout] 728 | println!("Player3 WS: {}", serde_json::to_string_pretty(&value).unwrap()); [INFO] [stdout] 729 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cricketer` and `price` are never read [INFO] [stdout] --> src/game.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | struct Buy{ [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 24 | cricketer: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 25 | price: u64 [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rooms` is never read [INFO] [stdout] --> src/ws/mod.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Hub { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 53 | /// room_id -> (user_id -> sender) [INFO] [stdout] 54 | rooms: Arc>>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hub` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `list_users` is never used [INFO] [stdout] --> src/ws/mod.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 58 | impl Hub { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 140 | fn list_users(&self, room_id: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game.rs:382:49 [INFO] [stdout] | [INFO] [stdout] 382 | let winning_amount = get_winning_amount(&self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cricketer` and `price` are never read [INFO] [stdout] --> src/game.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | struct Buy{ [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 24 | cricketer: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 25 | price: u64 [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `rooms` is never read [INFO] [stdout] --> src/ws/mod.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct Hub { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 53 | /// room_id -> (user_id -> sender) [INFO] [stdout] 54 | rooms: Arc>>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Hub` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `list_users` is never used [INFO] [stdout] --> src/ws/mod.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 58 | impl Hub { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 140 | fn list_users(&self, room_id: &str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/game.rs:382:49 [INFO] [stdout] | [INFO] [stdout] 382 | let winning_amount = get_winning_amount(&self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ws/mod.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | ... .or_insert_with(|| DashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Some(user_map) = rooms_clone.get(&room_id) { [INFO] [stdout] 100 | | if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(user_map) = rooms_clone.get(&room_id) [INFO] [stdout] 100 ~ && let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 100 | / ... if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | ... if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | ... warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | | ... } [INFO] [stdout] 104 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Some(tx) = user_map.get(&to) [INFO] [stdout] 101 ~ && let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Evaluator` [INFO] [stdout] --> src/evaluator/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | Self { [INFO] [stdout] 27 | | evaluator: Box::new(random::Random), [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for Evaluator { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ws/mod.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | ... .or_insert_with(|| DashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:99:25 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Some(user_map) = rooms_clone.get(&room_id) { [INFO] [stdout] 100 | | if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(user_map) = rooms_clone.get(&room_id) [INFO] [stdout] 100 ~ && let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ws/mod.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 100 | / ... if let Some(tx) = user_map.get(&to) { [INFO] [stdout] 101 | | ... if let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | | ... warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 | | ... } [INFO] [stdout] 104 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if let Some(tx) = user_map.get(&to) [INFO] [stdout] 101 ~ && let Err(_e) = tx.send(envelope) { [INFO] [stdout] 102 | warn!(room = %room_id, user = %to, "failed to send to user"); [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Evaluator` [INFO] [stdout] --> src/evaluator/mod.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / pub fn new() -> Self { [INFO] [stdout] 26 | | Self { [INFO] [stdout] 27 | | evaluator: Box::new(random::Random), [INFO] [stdout] 28 | | } [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for Evaluator { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 13s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: sqlx-postgres v0.7.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "28a1c8c9c00ed4d125b032886626706859d4cd6083bc1d5a74d976a3a06c1070", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28a1c8c9c00ed4d125b032886626706859d4cd6083bc1d5a74d976a3a06c1070", kill_on_drop: false }` [INFO] [stdout] 28a1c8c9c00ed4d125b032886626706859d4cd6083bc1d5a74d976a3a06c1070