[INFO] cloning repository https://github.com/codemonument/doty [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/codemonument/doty" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodemonument%2Fdoty", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodemonument%2Fdoty'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5ab0e61dcc8e8f8c286b33e3cf50e2adf78fe7e0 [INFO] linting codemonument/doty against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodemonument%2Fdoty" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/codemonument/doty [INFO] finished tweaking git repo https://github.com/codemonument/doty [INFO] tweaked toml for git repo https://github.com/codemonument/doty written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/codemonument/doty on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/codemonument/doty already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded console v0.15.11 [INFO] [stderr] Downloaded pluralizer v0.5.0 [INFO] [stderr] Downloaded hostname v0.4.1 [INFO] [stderr] Downloaded colored v2.2.0 [INFO] [stderr] Downloaded winnow v0.6.24 [INFO] [stderr] Downloaded kdl v6.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ac3b861c48423a1fc785354168694b7a54fde409f90c09f031ee7826144184b [INFO] running `Command { std: "docker" "start" "-a" "1ac3b861c48423a1fc785354168694b7a54fde409f90c09f031ee7826144184b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ac3b861c48423a1fc785354168694b7a54fde409f90c09f031ee7826144184b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ac3b861c48423a1fc785354168694b7a54fde409f90c09f031ee7826144184b", kill_on_drop: false }` [INFO] [stdout] 1ac3b861c48423a1fc785354168694b7a54fde409f90c09f031ee7826144184b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f5628668fdeba826c221343a0cf1fcfb5cd22110ea210855a36d6f6a7c7c0f0 [INFO] running `Command { std: "docker" "start" "-a" "7f5628668fdeba826c221343a0cf1fcfb5cd22110ea210855a36d6f6a7c7c0f0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling camino v1.2.1 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking winnow v0.6.24 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking miette v7.6.0 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking hostname v0.4.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking kdl v6.5.0 [INFO] [stderr] Checking pluralizer v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking doty v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `run_doty` is never used [INFO] [stdout] --> tests/test_lib/cli_test_utils.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn run_doty(args: &[impl AsRef]) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> tests/01_link_folder.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | /// Approved by: bjesuiter [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 12 | /// Approved by: bjesuiter [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/01_link_folder.rs:33:15 [INFO] [stdout] | [INFO] [stdout] 33 | fs::write(&source_dir.join("dummy/dummy.txt"), "Hello World").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_dir.join("dummy/dummy.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/01_link_folder.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | fs::write(&source_dir.join("dummy/dummy.txt"), "Hello World 2").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_dir.join("dummy/dummy.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> tests/01_link_folder.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | /// Approved by: bjesuiter [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 79 | /// Approved by: bjesuiter [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/01_link_folder.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | !fs::symlink_metadata(&expected_symlink).is_ok(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::symlink_metadata(&expected_symlink).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/01_link_folder.rs:103:24 [INFO] [stdout] | [INFO] [stdout] 103 | fs::create_dir_all(&source_dir.join("dummy")).expect("Failed to create source/dummy directory"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_dir.join("dummy")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/01_link_folder.rs:104:15 [INFO] [stdout] | [INFO] [stdout] 104 | fs::write(&source_dir.join("dummy/dummy.txt"), "Hello World").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_dir.join("dummy/dummy.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/01_link_folder.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 127 | fs::remove_dir_all(&source_dir.join("dummy")).expect("Failed to remove source/dummy"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `source_dir.join("dummy")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_managed` and `get_source` are never used [INFO] [stdout] --> src/lockfile.rs:221:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl Lockfile { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 221 | pub fn is_managed(&self, target: &Utf8Path) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 232 | pub fn get_source(&self, target: &Utf8Path) -> Option<&Utf8PathBuf> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Modified` and `Orphaned` are never constructed [INFO] [stdout] --> src/scanner.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub enum DriftType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 18 | Modified, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | /// In state but not in config (already handled by linker, included for completeness) [INFO] [stdout] 20 | Orphaned, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DriftType` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands.rs:89:30 [INFO] [stdout] | [INFO] [stdout] 89 | ... .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands.rs:115:30 [INFO] [stdout] | [INFO] [stdout] 115 | ... .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commands.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | / match action { [INFO] [stdout] 191 | | LinkAction::Removed { target, source } => { [INFO] [stdout] 192 | | println!(" {} {} → {}", "[-]".red().bold(), target, source); [INFO] [stdout] ... | [INFO] [stdout] 195 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 ~ if let LinkAction::Removed { target, source } = action { [INFO] [stdout] 191 ~ println!(" {} {} → {}", "[-]".red().bold(), target, source); [INFO] [stdout] 192 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands.rs:482:26 [INFO] [stdout] | [INFO] [stdout] 482 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl Default for PathResolution { [INFO] [stdout] 17 | | fn default() -> Self { [INFO] [stdout] 18 | | PathResolution::Config [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Default)] [INFO] [stdout] 10 | pub enum PathResolution { [INFO] [stdout] 11 | /// Resolve paths relative to config file location (default) [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Config, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linker.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | / return vec![LinkAction::Skipped { [INFO] [stdout] 416 | | target: target.clone(), [INFO] [stdout] 417 | | source: desired_source.clone(), [INFO] [stdout] 418 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 ~ vec![LinkAction::Skipped { [INFO] [stdout] 416 + target: target.clone(), [INFO] [stdout] 417 + source: desired_source.clone(), [INFO] [stdout] 418 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linker.rs:420:13 [INFO] [stdout] | [INFO] [stdout] 420 | / return vec![LinkAction::Created { [INFO] [stdout] 421 | | target: target.clone(), [INFO] [stdout] 422 | | source: desired_source.clone(), [INFO] [stdout] 423 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 420 ~ vec![LinkAction::Created { [INFO] [stdout] 421 + target: target.clone(), [INFO] [stdout] 422 + source: desired_source.clone(), [INFO] [stdout] 423 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | Self::normalize_to_absolute(&target, &base_path).unwrap_or_else(|_| target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 88 - Self::normalize_to_absolute(&target, &base_path).unwrap_or_else(|_| target); [INFO] [stdout] 88 + Self::normalize_to_absolute(&target, &base_path).unwrap_or(target); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | Self::normalize_to_absolute(&source, &base_path).unwrap_or_else(|_| source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 90 - Self::normalize_to_absolute(&source, &base_path).unwrap_or_else(|_| source); [INFO] [stdout] 90 + Self::normalize_to_absolute(&source, &base_path).unwrap_or(source); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lockfile.rs:112:64 [INFO] [stdout] | [INFO] [stdout] 112 | target = entry.value().as_string().map(|s| Utf8PathBuf::from(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Utf8PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lockfile.rs:115:64 [INFO] [stdout] | [INFO] [stdout] 115 | source = entry.value().as_string().map(|s| Utf8PathBuf::from(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Utf8PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | Self::normalize_to_absolute(&target, &self.base_path).unwrap_or_else(|_| target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 202 - Self::normalize_to_absolute(&target, &self.base_path).unwrap_or_else(|_| target); [INFO] [stdout] 202 + Self::normalize_to_absolute(&target, &self.base_path).unwrap_or(target); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | Self::normalize_to_absolute(&source, &self.base_path).unwrap_or_else(|_| source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 204 - Self::normalize_to_absolute(&source, &self.base_path).unwrap_or_else(|_| source); [INFO] [stdout] 204 + Self::normalize_to_absolute(&source, &self.base_path).unwrap_or(source); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/scanner.rs:54:37 [INFO] [stdout] | [INFO] [stdout] 54 | for (lockfile_target, _) in &lockfile.links { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 54 - for (lockfile_target, _) in &lockfile.links { [INFO] [stdout] 54 + for lockfile_target in lockfile.links.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scanner.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | / if fs_type == crate::fs_utils::FsType::Symlink { [INFO] [stdout] 80 | | if is_broken_symlink(&resolved_target)? { [INFO] [stdout] 81 | | let symlink_target = std::fs::read_link(&resolved_target) [INFO] [stdout] 82 | | .ok() [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 79 ~ if fs_type == crate::fs_utils::FsType::Symlink [INFO] [stdout] 80 ~ && is_broken_symlink(&resolved_target)? { [INFO] [stdout] 81 | let symlink_target = std::fs::read_link(&resolved_target) [INFO] [stdout] ... [INFO] [stdout] 90 | }); [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/scanner.rs:274:36 [INFO] [stdout] | [INFO] [stdout] 274 | let (_temp_dir, temp_path, mut config, mut lockfile) = setup_test_env()?; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Modified` and `Orphaned` are never constructed [INFO] [stdout] --> src/scanner.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub enum DriftType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 18 | Modified, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | /// In state but not in config (already handled by linker, included for completeness) [INFO] [stdout] 20 | Orphaned, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DriftType` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands.rs:89:30 [INFO] [stdout] | [INFO] [stdout] 89 | ... .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands.rs:115:30 [INFO] [stdout] | [INFO] [stdout] 115 | ... .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/commands.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | / match action { [INFO] [stdout] 191 | | LinkAction::Removed { target, source } => { [INFO] [stdout] 192 | | println!(" {} {} → {}", "[-]".red().bold(), target, source); [INFO] [stdout] ... | [INFO] [stdout] 195 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 ~ if let LinkAction::Removed { target, source } = action { [INFO] [stdout] 191 ~ println!(" {} {} → {}", "[-]".red().bold(), target, source); [INFO] [stdout] 192 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/commands.rs:482:26 [INFO] [stdout] | [INFO] [stdout] 482 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl Default for PathResolution { [INFO] [stdout] 17 | | fn default() -> Self { [INFO] [stdout] 18 | | PathResolution::Config [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Default)] [INFO] [stdout] 10 | pub enum PathResolution { [INFO] [stdout] 11 | /// Resolve paths relative to config file location (default) [INFO] [stdout] 12 ~ #[default] [INFO] [stdout] 13 ~ Config, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linker.rs:415:13 [INFO] [stdout] | [INFO] [stdout] 415 | / return vec![LinkAction::Skipped { [INFO] [stdout] 416 | | target: target.clone(), [INFO] [stdout] 417 | | source: desired_source.clone(), [INFO] [stdout] 418 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 ~ vec![LinkAction::Skipped { [INFO] [stdout] 416 + target: target.clone(), [INFO] [stdout] 417 + source: desired_source.clone(), [INFO] [stdout] 418 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/linker.rs:420:13 [INFO] [stdout] | [INFO] [stdout] 420 | / return vec![LinkAction::Created { [INFO] [stdout] 421 | | target: target.clone(), [INFO] [stdout] 422 | | source: desired_source.clone(), [INFO] [stdout] 423 | | }]; [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 420 ~ vec![LinkAction::Created { [INFO] [stdout] 421 + target: target.clone(), [INFO] [stdout] 422 + source: desired_source.clone(), [INFO] [stdout] 423 ~ }] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/linker.rs:651:36 [INFO] [stdout] | [INFO] [stdout] 651 | let _ = fs::remove_dir_all(format!("tests/tmpfs/test_clean_removes_links")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"tests/tmpfs/test_clean_removes_links".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/linker.rs:677:36 [INFO] [stdout] | [INFO] [stdout] 677 | let _ = fs::remove_dir_all(format!("tests/tmpfs/test_clean_dry_run")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"tests/tmpfs/test_clean_dry_run".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | Self::normalize_to_absolute(&target, &base_path).unwrap_or_else(|_| target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 88 - Self::normalize_to_absolute(&target, &base_path).unwrap_or_else(|_| target); [INFO] [stdout] 88 + Self::normalize_to_absolute(&target, &base_path).unwrap_or(target); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:90:21 [INFO] [stdout] | [INFO] [stdout] 90 | Self::normalize_to_absolute(&source, &base_path).unwrap_or_else(|_| source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 90 - Self::normalize_to_absolute(&source, &base_path).unwrap_or_else(|_| source); [INFO] [stdout] 90 + Self::normalize_to_absolute(&source, &base_path).unwrap_or(source); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lockfile.rs:112:64 [INFO] [stdout] | [INFO] [stdout] 112 | target = entry.value().as_string().map(|s| Utf8PathBuf::from(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Utf8PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/lockfile.rs:115:64 [INFO] [stdout] | [INFO] [stdout] 115 | source = entry.value().as_string().map(|s| Utf8PathBuf::from(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Utf8PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | Self::normalize_to_absolute(&target, &self.base_path).unwrap_or_else(|_| target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 202 - Self::normalize_to_absolute(&target, &self.base_path).unwrap_or_else(|_| target); [INFO] [stdout] 202 + Self::normalize_to_absolute(&target, &self.base_path).unwrap_or(target); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Result::Err` [INFO] [stdout] --> src/lockfile.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | Self::normalize_to_absolute(&source, &self.base_path).unwrap_or_else(|_| source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 204 - Self::normalize_to_absolute(&source, &self.base_path).unwrap_or_else(|_| source); [INFO] [stdout] 204 + Self::normalize_to_absolute(&source, &self.base_path).unwrap_or(source); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/scanner.rs:54:37 [INFO] [stdout] | [INFO] [stdout] 54 | for (lockfile_target, _) in &lockfile.links { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 54 - for (lockfile_target, _) in &lockfile.links { [INFO] [stdout] 54 + for lockfile_target in lockfile.links.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scanner.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | / if fs_type == crate::fs_utils::FsType::Symlink { [INFO] [stdout] 80 | | if is_broken_symlink(&resolved_target)? { [INFO] [stdout] 81 | | let symlink_target = std::fs::read_link(&resolved_target) [INFO] [stdout] 82 | | .ok() [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 79 ~ if fs_type == crate::fs_utils::FsType::Symlink [INFO] [stdout] 80 ~ && is_broken_symlink(&resolved_target)? { [INFO] [stdout] 81 | let symlink_target = std::fs::read_link(&resolved_target) [INFO] [stdout] ... [INFO] [stdout] 90 | }); [INFO] [stdout] 91 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.39s [INFO] running `Command { std: "docker" "inspect" "7f5628668fdeba826c221343a0cf1fcfb5cd22110ea210855a36d6f6a7c7c0f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f5628668fdeba826c221343a0cf1fcfb5cd22110ea210855a36d6f6a7c7c0f0", kill_on_drop: false }` [INFO] [stdout] 7f5628668fdeba826c221343a0cf1fcfb5cd22110ea210855a36d6f6a7c7c0f0