[INFO] cloning repository https://github.com/codefalcon95/wc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/codefalcon95/wc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodefalcon95%2Fwc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodefalcon95%2Fwc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d1f0f4f4cdc84f10a25cce7c24ecb24a91bdb632 [INFO] linting codefalcon95/wc against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcodefalcon95%2Fwc" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/codefalcon95/wc [INFO] finished tweaking git repo https://github.com/codefalcon95/wc [INFO] tweaked toml for git repo https://github.com/codefalcon95/wc written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/codefalcon95/wc on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/codefalcon95/wc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63f68528ee66f7797208b7cc3d56c8308dcbe2f166e93a646dc7fff93e467271 [INFO] running `Command { std: "docker" "start" "-a" "63f68528ee66f7797208b7cc3d56c8308dcbe2f166e93a646dc7fff93e467271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63f68528ee66f7797208b7cc3d56c8308dcbe2f166e93a646dc7fff93e467271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63f68528ee66f7797208b7cc3d56c8308dcbe2f166e93a646dc7fff93e467271", kill_on_drop: false }` [INFO] [stdout] 63f68528ee66f7797208b7cc3d56c8308dcbe2f166e93a646dc7fff93e467271 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 686021d92fedaa3a81701504f1b2c5f0acd85bcfc021c434740bb04f9c1a5602 [INFO] running `Command { std: "docker" "start" "-a" "686021d92fedaa3a81701504f1b2c5f0acd85bcfc021c434740bb04f9c1a5602", kill_on_drop: false }` [INFO] [stderr] Checking wc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/wc.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod wc { [INFO] [stdout] 2 | | use std::fs; [INFO] [stdout] 3 | | use std::io::prelude::*; [INFO] [stdout] 4 | | use std::io::BufReader; [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/wc.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 68 | let total_lines = reader.lines().count(); [INFO] [stdout] | ----------------------------------------- unnecessary `let` binding [INFO] [stdout] 69 | total_lines [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 68 ~ [INFO] [stdout] 69 ~ reader.lines().count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | if !fs::metadata(file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/wc.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / pub mod wc { [INFO] [stdout] 2 | | use std::fs; [INFO] [stdout] 3 | | use std::io::prelude::*; [INFO] [stdout] 4 | | use std::io::BufReader; [INFO] [stdout] ... | [INFO] [stdout] 87 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/wc.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 68 | let total_lines = reader.lines().count(); [INFO] [stdout] | ----------------------------------------- unnecessary `let` binding [INFO] [stdout] 69 | total_lines [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 68 ~ [INFO] [stdout] 69 ~ reader.lines().count() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | if !fs::metadata(file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s [INFO] running `Command { std: "docker" "inspect" "686021d92fedaa3a81701504f1b2c5f0acd85bcfc021c434740bb04f9c1a5602", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "686021d92fedaa3a81701504f1b2c5f0acd85bcfc021c434740bb04f9c1a5602", kill_on_drop: false }` [INFO] [stdout] 686021d92fedaa3a81701504f1b2c5f0acd85bcfc021c434740bb04f9c1a5602