[INFO] cloning repository https://github.com/codeMonkey760/wfo-parser [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/codeMonkey760/wfo-parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FcodeMonkey760%2Fwfo-parser", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FcodeMonkey760%2Fwfo-parser'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 42c94707643a17d898366fc0cfb949e101d7d1bc [INFO] linting codeMonkey760/wfo-parser against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FcodeMonkey760%2Fwfo-parser" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/codeMonkey760/wfo-parser [INFO] finished tweaking git repo https://github.com/codeMonkey760/wfo-parser [INFO] tweaked toml for git repo https://github.com/codeMonkey760/wfo-parser written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/codeMonkey760/wfo-parser on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/codeMonkey760/wfo-parser already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ordered-float v4.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8fbfaf018fe405c392630ad616373c67322d1bc67dfbe20c0fa8cdd7901a8e2 [INFO] running `Command { std: "docker" "start" "-a" "e8fbfaf018fe405c392630ad616373c67322d1bc67dfbe20c0fa8cdd7901a8e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8fbfaf018fe405c392630ad616373c67322d1bc67dfbe20c0fa8cdd7901a8e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8fbfaf018fe405c392630ad616373c67322d1bc67dfbe20c0fa8cdd7901a8e2", kill_on_drop: false }` [INFO] [stdout] e8fbfaf018fe405c392630ad616373c67322d1bc67dfbe20c0fa8cdd7901a8e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4dbfaaf1e182cd6fc7e5fcc18745499f9450eefbd6b3d1ef1bdcb03df4cea708 [INFO] running `Command { std: "docker" "start" "-a" "4dbfaaf1e182cd6fc7e5fcc18745499f9450eefbd6b3d1ef1bdcb03df4cea708", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking ordered-float v4.4.0 [INFO] [stderr] Checking rust-wfo-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `VertexFormat` [INFO] [stdout] --> src/compiler.rs:3:33 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::vertex::{VertexData, VertexFormat}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `LexerState` is never used [INFO] [stdout] --> src/lexer.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | enum LexerState { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Lexer` is never constructed [INFO] [stdout] --> src/lexer.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | struct Lexer { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/lexer.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | impl Lexer { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 36 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 40 | fn lex_tokens(&mut self, stream: &mut R) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | fn advance_char(stream: &mut R) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | fn check_for_state_transition(&mut self, cur_char: char) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 101 | fn save_char(&mut self, cur_char: char) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | fn process_char_buffer(&mut self, lexed_tokens: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | fn lex_polygon(text: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `TokenType` is never used [INFO] [stdout] --> src/token.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum TokenType { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_str` is never used [INFO] [stdout] --> src/token.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 44 | impl TokenType { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 45 | pub(crate) fn from_str(name: &str) -> Option { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `TokenDataType` is never used [INFO] [stdout] --> src/token.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | pub(crate) enum TokenDataType { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Token` is never constructed [INFO] [stdout] --> src/token.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 70 | pub(crate) struct Token { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from` is never used [INFO] [stdout] --> src/token.rs:78:19 [INFO] [stdout] | [INFO] [stdout] 77 | impl Token { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 78 | pub(crate) fn from( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Parser` is never constructed [INFO] [stdout] --> src/parser.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct Parser { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/parser.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 31 | impl Parser { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 32 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub fn parse_tokens( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | fn parse_token(&mut self, token: &Token) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | fn handle_expecting_header_state(&mut self, cur_token: &Token) -> Result<(), String>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | fn handle_token(&mut self, token: &Token) -> Result, String>{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | fn parse_comment_statement(&mut self, token: &Token) -> Result, String>{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 126 | fn parse_single_string_statement(&mut self, token: &Token) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 144 | fn parse_number_statement(&mut self, token: &Token, expected_number_count: u64) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 203 | fn parse_face_statement(&mut self, token: &Token) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 249 | fn is_expected_token(&self, token: &Token, expected_type: TokenType) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 253 | fn get_unexpected_token_error(token: &Token) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 257 | fn convert_token_data_to_statement_data(token_data: &TokenDataType) -> StatementDataType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 265 | fn convert_token_type_to_statement_type(token_type: TokenType) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 280 | fn extract_statement(&mut self) -> Statement { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 293 | fn reset_state(&mut self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `StatementType` is never used [INFO] [stdout] --> src/statement.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum StatementType { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `StatementDataType` is never used [INFO] [stdout] --> src/statement.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) enum StatementDataType { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `number_3d_as_tuple`, `number_2d_as_tuple`, and `face_as_index_tuples` are never used [INFO] [stdout] --> src/statement.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 28 | impl StatementDataType { [INFO] [stdout] | ---------------------- methods in this implementation [INFO] [stdout] 29 | pub(crate) fn number_3d_as_tuple(&self) -> Option<(Float, Float, Float)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub(crate) fn number_2d_as_tuple(&self) -> Option<(Float, Float)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub(crate) fn face_as_index_tuples(&self) -> Option> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Statement` is never constructed [INFO] [stdout] --> src/statement.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) struct Statement { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from` is never used [INFO] [stdout] --> src/statement.rs:83:19 [INFO] [stdout] | [INFO] [stdout] 82 | impl Statement { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 83 | pub(crate) fn from( [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Compiler` is never constructed [INFO] [stdout] --> src/compiler.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct Compiler { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/compiler.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | impl Compiler { [INFO] [stdout] | ------------- associated items in this implementation [INFO] [stdout] 15 | fn from_default_name(new_default_name: &String) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 25 | fn compile(&mut self, statements: &Vec) -> Result, String> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | fn handle_vertex_statement(&mut self, statement: &Statement) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | fn handle_normal_statement(&mut self, statement: &Statement) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 58 | fn handle_tex_coord_statement(&mut self, statement: &Statement) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 64 | fn handle_object_statement(&mut self, statement: &Statement, results: &mut Vec) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | fn handle_face_statement(&mut self, statement: &Statement) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | fn clean_up(&mut self, results: &mut Vec) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Object3d` is never constructed [INFO] [stdout] --> src/object3d.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | pub(crate) struct Object3d { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `from` and `add_vertex` are never used [INFO] [stdout] --> src/object3d.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 10 | impl Object3d { [INFO] [stdout] | ------------- associated items in this implementation [INFO] [stdout] 11 | pub(crate) fn from(name: String) -> Self { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub(crate) fn add_vertex(&mut self, new_vertex: VertexData) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `VertexFormat` is never used [INFO] [stdout] --> src/vertex.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | pub(crate) enum VertexFormat { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_indices` is never used [INFO] [stdout] --> src/vertex.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 12 | impl VertexFormat { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 13 | pub(crate) fn from_indices(indices: &(u64, u64, u64)) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `VertexDataIndex` is never constructed [INFO] [stdout] --> src/vertex.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | pub(crate) struct VertexDataIndex { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_indices` is never used [INFO] [stdout] --> src/vertex.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 31 | impl VertexDataIndex { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] 32 | pub(crate) fn from_indices(indices: &(u64, u64, u64)) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `VertexData` is never constructed [INFO] [stdout] --> src/vertex.rs:43:19 [INFO] [stdout] | [INFO] [stdout] 43 | pub(crate) struct VertexData { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated functions are never used [INFO] [stdout] --> src/vertex.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 50 | impl VertexData { [INFO] [stdout] | --------------- associated functions in this implementation [INFO] [stdout] 51 | pub(crate) fn vertex_p_from_floats(x: Float, y: Float, z:Float) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub(crate) fn vertex_pn_from_floats( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub(crate) fn vertex_pt_from_floats( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 84 | pub(crate) fn vertex_pnt_from_floats( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 97 | pub(crate) fn compile( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | fn compile_vertex_p( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 129 | fn compile_vertex_pn( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | fn compile_vertex_pt( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 179 | fn compile_vertex_pnt( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Float` is never used [INFO] [stdout] --> src/nan_safe_float.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | pub type Float = NotNan; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | if !next_state.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `next_state.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `next_state` after checking its variant with `is_none` [INFO] [stdout] --> src/lexer.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 52 | if !next_state.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 53 | self.process_char_buffer(&mut lexed_tokens); [INFO] [stdout] 54 | self.state = next_state.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lexer.rs:82:66 [INFO] [stdout] | [INFO] [stdout] 82 | if is_line_ending && self.state != LexerState::LineBreak { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 83 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 84 | | } else if is_n_line_ending && self.state == LexerState::LineBreak { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lexer.rs:84:75 [INFO] [stdout] | [INFO] [stdout] 84 | } else if is_n_line_ending && self.state == LexerState::LineBreak { [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 85 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 86 | | } else if is_line_ending && has_nr_line_ending { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lexer.rs:84:75 [INFO] [stdout] | [INFO] [stdout] 84 | } else if is_n_line_ending && self.state == LexerState::LineBreak { [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 85 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 86 | | } else if is_line_ending && has_nr_line_ending { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lexer.rs:86:56 [INFO] [stdout] | [INFO] [stdout] 86 | } else if is_line_ending && has_nr_line_ending { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 87 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 88 | | } else if is_line_ending && self.state == LexerState::Comment { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !token_type.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `token_type.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:164:16 [INFO] [stdout] | [INFO] [stdout] 164 | if !parse_float_result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_float_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | if !parse_float_result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_float_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | if !lex_polygon_result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lex_polygon_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token_type` after checking its variant with `is_none` [INFO] [stdout] --> src/lexer.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 150 | if !token_type.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 153 | token_type.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_float_result` after checking its variant with `is_err` [INFO] [stdout] --> src/lexer.rs:165:53 [INFO] [stdout] | [INFO] [stdout] 164 | if !parse_float_result.is_err() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 165 | let parse_float_result = Float::new(parse_float_result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_float_result` after checking its variant with `is_err` [INFO] [stdout] --> src/lexer.rs:170:51 [INFO] [stdout] | [INFO] [stdout] 166 | if !parse_float_result.is_err() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 170 | TokenDataType::Number(parse_float_result.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `lex_polygon_result` after checking its variant with `is_none` [INFO] [stdout] --> src/lexer.rs:185:25 [INFO] [stdout] | [INFO] [stdout] 181 | if !lex_polygon_result.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 185 | lex_polygon_result.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 107 | if self.char_buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lexer.rs:120:43 [INFO] [stdout] | [INFO] [stdout] 120 | TokenDataType::String(String::from(char_buffer.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `char_buffer.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lexer.rs:129:43 [INFO] [stdout] | [INFO] [stdout] 129 | TokenDataType::String(String::from(char_buffer.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `char_buffer.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:214:15 [INFO] [stdout] | [INFO] [stdout] 214 | while chars.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!chars.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | if buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 235 | if buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COMMENT` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | COMMENT, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MTLLIB` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | MTLLIB, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Mtllib` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OBJECT` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | OBJECT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Object` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VERTEX` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | VERTEX, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Vertex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORMAL` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | NORMAL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXCOORD` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | TEXCOORD, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Texcoord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USEMTL` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | USEMTL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Usemtl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FACE` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FACE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Face` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ILLUM` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | ILLUM, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Illum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NUMBER` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | NUMBER, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | STRING, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POLYGON` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | POLYGON, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Polygon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEPARATOR` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | SEPARATOR, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LINEBREAK` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | LINEBREAK, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Linebreak` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | if !parse_result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_result` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:50:40 [INFO] [stdout] | [INFO] [stdout] 49 | if !parse_result.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 50 | parsed_statements.push(parse_result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/parser.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | String::from(format!("Unexpected token: {}", token.token_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Unexpected token: {}", token.token_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COMMENT` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | COMMENT, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MTLLIB` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | MTLLIB, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Mtllib` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OBJECT` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | OBJECT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Object` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VERTEX` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | VERTEX, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Vertex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORMAL` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | NORMAL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXCOORD` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | TEXCOORD, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Texcoord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USEMTL` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | USEMTL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Usemtl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FACE` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FACE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Face` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ILLUM` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | ILLUM, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Illum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/statement.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / let mut ret = Vec::new(); [INFO] [stdout] 48 | | ret.push(VertexDataIndex::from_indices(&(*xp, *xn, *xt))); [INFO] [stdout] 49 | | ret.push(VertexDataIndex::from_indices(&(*yp, *yn, *yt))); [INFO] [stdout] 50 | | ret.push(VertexDataIndex::from_indices(&(*zp, *zn, *zt))); [INFO] [stdout] | |______________________________________________________________________^ help: consider using the `vec![]` macro: `let ret = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/compiler.rs:15:44 [INFO] [stdout] | [INFO] [stdout] 15 | fn from_default_name(new_default_name: &String) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 ~ fn from_default_name(new_default_name: &str) -> Self { [INFO] [stdout] 16 | Compiler { [INFO] [stdout] 17 ~ default_name: new_default_name.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:88:74 [INFO] [stdout] | [INFO] [stdout] 88 | ... let vertex = VertexData::compile(vertex_indices, pos_buffer, &normal_buffer, &tex_coord_buffer).expect("Expected vertex compil... [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `normal_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:88:90 [INFO] [stdout] | [INFO] [stdout] 88 | ...dices, pos_buffer, &normal_buffer, &tex_coord_buffer).expect("Expected vertex compilation"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `tex_coord_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/vertex.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / pub(crate) fn vertex_pnt_from_floats( [INFO] [stdout] 85 | | px: Float, py: Float, pz: Float, [INFO] [stdout] 86 | | nx: Float, ny: Float, nz: Float, [INFO] [stdout] 87 | | tx: Float, ty: Float [INFO] [stdout] 88 | | )-> Self { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:114:26 [INFO] [stdout] | [INFO] [stdout] 114 | position_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 114 - position_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] 114 + position_buffer: &[(Float, Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 131 | position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 131 + position_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:132:24 [INFO] [stdout] | [INFO] [stdout] 132 | normal_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 132 - normal_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] 132 + normal_buffer: &[(Float, Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | if let None = normal { [INFO] [stdout] | -------^^^^--------- help: try: `if normal.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 156 | position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 156 - position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 156 + position_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 157 | tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 157 - tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] 157 + tex_coord_buffer: &[(Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if let None = tex_coord { [INFO] [stdout] | -------^^^^------------ help: try: `if tex_coord.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 181 - position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 181 + position_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | normal_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 182 - normal_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 182 + normal_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:183:27 [INFO] [stdout] | [INFO] [stdout] 183 | tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 183 - tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] 183 + tex_coord_buffer: &[(Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:191:16 [INFO] [stdout] | [INFO] [stdout] 191 | if let None = normal { [INFO] [stdout] | -------^^^^--------- help: try: `if normal.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 196 | if let None = tex_coord { [INFO] [stdout] | -------^^^^------------ help: try: `if tex_coord.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:52:16 [INFO] [stdout] | [INFO] [stdout] 52 | if !next_state.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `next_state.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `next_state` after checking its variant with `is_none` [INFO] [stdout] --> src/lexer.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 52 | if !next_state.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 53 | self.process_char_buffer(&mut lexed_tokens); [INFO] [stdout] 54 | self.state = next_state.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lexer.rs:82:66 [INFO] [stdout] | [INFO] [stdout] 82 | if is_line_ending && self.state != LexerState::LineBreak { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 83 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 84 | | } else if is_n_line_ending && self.state == LexerState::LineBreak { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lexer.rs:84:75 [INFO] [stdout] | [INFO] [stdout] 84 | } else if is_n_line_ending && self.state == LexerState::LineBreak { [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 85 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 86 | | } else if is_line_ending && has_nr_line_ending { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lexer.rs:84:75 [INFO] [stdout] | [INFO] [stdout] 84 | } else if is_n_line_ending && self.state == LexerState::LineBreak { [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 85 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 86 | | } else if is_line_ending && has_nr_line_ending { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lexer.rs:86:56 [INFO] [stdout] | [INFO] [stdout] 86 | } else if is_line_ending && has_nr_line_ending { [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 87 | | return Some(LexerState::LineBreak); //fake a state transition by returning the current state [INFO] [stdout] 88 | | } else if is_line_ending && self.state == LexerState::Comment { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !token_type.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `token_type.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:164:16 [INFO] [stdout] | [INFO] [stdout] 164 | if !parse_float_result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_float_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:166:20 [INFO] [stdout] | [INFO] [stdout] 166 | if !parse_float_result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_float_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lexer.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | if !lex_polygon_result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `lex_polygon_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token_type` after checking its variant with `is_none` [INFO] [stdout] --> src/lexer.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 150 | if !token_type.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 153 | token_type.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_float_result` after checking its variant with `is_err` [INFO] [stdout] --> src/lexer.rs:165:53 [INFO] [stdout] | [INFO] [stdout] 164 | if !parse_float_result.is_err() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] 165 | let parse_float_result = Float::new(parse_float_result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_float_result` after checking its variant with `is_err` [INFO] [stdout] --> src/lexer.rs:170:51 [INFO] [stdout] | [INFO] [stdout] 166 | if !parse_float_result.is_err() { [INFO] [stdout] | --------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 170 | TokenDataType::Number(parse_float_result.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `lex_polygon_result` after checking its variant with `is_none` [INFO] [stdout] --> src/lexer.rs:185:25 [INFO] [stdout] | [INFO] [stdout] 181 | if !lex_polygon_result.is_none() { [INFO] [stdout] | ---------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 185 | lex_polygon_result.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 107 | if self.char_buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lexer.rs:120:43 [INFO] [stdout] | [INFO] [stdout] 120 | TokenDataType::String(String::from(char_buffer.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `char_buffer.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lexer.rs:129:43 [INFO] [stdout] | [INFO] [stdout] 129 | TokenDataType::String(String::from(char_buffer.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `char_buffer.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:214:15 [INFO] [stdout] | [INFO] [stdout] 214 | while chars.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!chars.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | if buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lexer.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 235 | if buffer.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lexer.rs:416:13 [INFO] [stdout] | [INFO] [stdout] 416 | &expected_result, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `expected_result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexer.rs:506:56 [INFO] [stdout] | [INFO] [stdout] 506 | fn assert_token_vectors_are_equal(expected_result: &Vec, actual_result: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 506 - fn assert_token_vectors_are_equal(expected_result: &Vec, actual_result: &Vec) { [INFO] [stdout] 506 + fn assert_token_vectors_are_equal(expected_result: &[Token], actual_result: &Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/lexer.rs:506:84 [INFO] [stdout] | [INFO] [stdout] 506 | fn assert_token_vectors_are_equal(expected_result: &Vec, actual_result: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 506 - fn assert_token_vectors_are_equal(expected_result: &Vec, actual_result: &Vec) { [INFO] [stdout] 506 + fn assert_token_vectors_are_equal(expected_result: &Vec, actual_result: &[Token]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COMMENT` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | COMMENT, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MTLLIB` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | MTLLIB, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Mtllib` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OBJECT` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | OBJECT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Object` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VERTEX` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | VERTEX, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Vertex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORMAL` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | NORMAL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXCOORD` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | TEXCOORD, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Texcoord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USEMTL` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | USEMTL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Usemtl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FACE` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FACE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Face` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ILLUM` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | ILLUM, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Illum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NUMBER` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | NUMBER, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Number` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | STRING, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POLYGON` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | POLYGON, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Polygon` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEPARATOR` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | SEPARATOR, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Separator` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LINEBREAK` contains a capitalized acronym [INFO] [stdout] --> src/token.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | LINEBREAK, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Linebreak` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | if !parse_result.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parse_result` after checking its variant with `is_none` [INFO] [stdout] --> src/parser.rs:50:40 [INFO] [stdout] | [INFO] [stdout] 49 | if !parse_result.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 50 | parsed_statements.push(parse_result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/parser.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | String::from(format!("Unexpected token: {}", token.token_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Unexpected token: {}", token.token_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:513:19 [INFO] [stdout] | [INFO] [stdout] 513 | expected: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 513 - expected: &Vec, [INFO] [stdout] 513 + expected: &[Statement], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:514:17 [INFO] [stdout] | [INFO] [stdout] 514 | actual: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 514 - actual: &Vec, [INFO] [stdout] 514 + actual: &[Statement], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COMMENT` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | COMMENT, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Comment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MTLLIB` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | MTLLIB, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Mtllib` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OBJECT` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | OBJECT, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Object` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VERTEX` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | VERTEX, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Vertex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NORMAL` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | NORMAL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Normal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TEXCOORD` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | TEXCOORD, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Texcoord` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USEMTL` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | USEMTL, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Usemtl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FACE` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | FACE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Face` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ILLUM` contains a capitalized acronym [INFO] [stdout] --> src/statement.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | ILLUM, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Illum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/statement.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / let mut ret = Vec::new(); [INFO] [stdout] 48 | | ret.push(VertexDataIndex::from_indices(&(*xp, *xn, *xt))); [INFO] [stdout] 49 | | ret.push(VertexDataIndex::from_indices(&(*yp, *yn, *yt))); [INFO] [stdout] 50 | | ret.push(VertexDataIndex::from_indices(&(*zp, *zn, *zt))); [INFO] [stdout] | |______________________________________________________________________^ help: consider using the `vec![]` macro: `let ret = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/compiler.rs:15:44 [INFO] [stdout] | [INFO] [stdout] 15 | fn from_default_name(new_default_name: &String) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 ~ fn from_default_name(new_default_name: &str) -> Self { [INFO] [stdout] 16 | Compiler { [INFO] [stdout] 17 ~ default_name: new_default_name.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:88:74 [INFO] [stdout] | [INFO] [stdout] 88 | ... let vertex = VertexData::compile(vertex_indices, pos_buffer, &normal_buffer, &tex_coord_buffer).expect("Expected vertex compil... [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `normal_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/compiler.rs:88:90 [INFO] [stdout] | [INFO] [stdout] 88 | ...dices, pos_buffer, &normal_buffer, &tex_coord_buffer).expect("Expected vertex compilation"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `tex_coord_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/compiler.rs:369:35 [INFO] [stdout] | [INFO] [stdout] 369 | compile_generates_objects(String::from(file_name), expected_object_list, statements); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/compiler.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 381 | / assert_eq!( [INFO] [stdout] 382 | | false, [INFO] [stdout] 383 | | actual_object_list.is_err(), [INFO] [stdout] 384 | | "Compile returns successful result when given valid data" [INFO] [stdout] 385 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 381 ~ assert!( [INFO] [stdout] 382 ~ !actual_object_list.is_err(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/vertex.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | / pub(crate) fn vertex_pnt_from_floats( [INFO] [stdout] 85 | | px: Float, py: Float, pz: Float, [INFO] [stdout] 86 | | nx: Float, ny: Float, nz: Float, [INFO] [stdout] 87 | | tx: Float, ty: Float [INFO] [stdout] 88 | | )-> Self { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:114:26 [INFO] [stdout] | [INFO] [stdout] 114 | position_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 114 - position_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] 114 + position_buffer: &[(Float, Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:117:16 [INFO] [stdout] | [INFO] [stdout] 117 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:131:26 [INFO] [stdout] | [INFO] [stdout] 131 | position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 131 + position_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:132:24 [INFO] [stdout] | [INFO] [stdout] 132 | normal_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 132 - normal_buffer: &Vec<(Float, Float, Float)> [INFO] [stdout] 132 + normal_buffer: &[(Float, Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:140:16 [INFO] [stdout] | [INFO] [stdout] 140 | if let None = normal { [INFO] [stdout] | -------^^^^--------- help: try: `if normal.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 156 | position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 156 - position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 156 + position_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:157:27 [INFO] [stdout] | [INFO] [stdout] 157 | tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 157 - tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] 157 + tex_coord_buffer: &[(Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if let None = tex_coord { [INFO] [stdout] | -------^^^^------------ help: try: `if tex_coord.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 181 - position_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 181 + position_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | normal_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 182 - normal_buffer: &Vec<(Float, Float, Float)>, [INFO] [stdout] 182 + normal_buffer: &[(Float, Float, Float)], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/vertex.rs:183:27 [INFO] [stdout] | [INFO] [stdout] 183 | tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 183 - tex_coord_buffer: &Vec<(Float, Float)> [INFO] [stdout] 183 + tex_coord_buffer: &[(Float, Float)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | if let None = position { [INFO] [stdout] | -------^^^^----------- help: try: `if position.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:191:16 [INFO] [stdout] | [INFO] [stdout] 191 | if let None = normal { [INFO] [stdout] | -------^^^^--------- help: try: `if normal.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/vertex.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 196 | if let None = tex_coord { [INFO] [stdout] | -------^^^^------------ help: try: `if tex_coord.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `Command { std: "docker" "inspect" "4dbfaaf1e182cd6fc7e5fcc18745499f9450eefbd6b3d1ef1bdcb03df4cea708", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4dbfaaf1e182cd6fc7e5fcc18745499f9450eefbd6b3d1ef1bdcb03df4cea708", kill_on_drop: false }` [INFO] [stdout] 4dbfaaf1e182cd6fc7e5fcc18745499f9450eefbd6b3d1ef1bdcb03df4cea708