[INFO] cloning repository https://github.com/cobaltgit/mainui-game-picker
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cobaltgit/mainui-game-picker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcobaltgit%2Fmainui-game-picker", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcobaltgit%2Fmainui-game-picker'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 4dec612b64f9310aea11f579b930010960b2e4bb
[INFO] linting cobaltgit/mainui-game-picker against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcobaltgit%2Fmainui-game-picker" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] removed /workspace/builds/worker-7-tc1/source/.cargo/config.toml
[INFO] started tweaking git repo https://github.com/cobaltgit/mainui-game-picker
[INFO] finished tweaking git repo https://github.com/cobaltgit/mainui-game-picker
[INFO] tweaked toml for git repo https://github.com/cobaltgit/mainui-game-picker written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/cobaltgit/mainui-game-picker on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/cobaltgit/mainui-game-picker already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] cca84d2419a3353dc41960b258c62f50cc0e4b9f6383db7d34d6c6621fc722bf
[INFO] running `Command { std: "docker" "start" "-a" "cca84d2419a3353dc41960b258c62f50cc0e4b9f6383db7d34d6c6621fc722bf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "cca84d2419a3353dc41960b258c62f50cc0e4b9f6383db7d34d6c6621fc722bf", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "cca84d2419a3353dc41960b258c62f50cc0e4b9f6383db7d34d6c6621fc722bf", kill_on_drop: false }`
[INFO] [stdout] cca84d2419a3353dc41960b258c62f50cc0e4b9f6383db7d34d6c6621fc722bf
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] de03323c4b63369609489085891293c60b78877fcc9d1f24ff0a7838f688a615
[INFO] running `Command { std: "docker" "start" "-a" "de03323c4b63369609489085891293c60b78877fcc9d1f24ff0a7838f688a615", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.177
[INFO] [stderr]    Compiling getrandom v0.3.4
[INFO] [stderr]    Compiling serde_core v1.0.228
[INFO] [stderr]     Checking memchr v2.7.6
[INFO] [stderr]    Compiling serde_json v1.0.145
[INFO] [stderr]     Checking ppv-lite86 v0.2.21
[INFO] [stderr]     Checking rand_core v0.9.3
[INFO] [stderr]     Checking rand_chacha v0.9.0
[INFO] [stderr]     Checking rand v0.9.2
[INFO] [stderr]     Checking mainui-game-picker v1.2.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:86:8
[INFO] [stdout]    |
[INFO] [stdout] 86 |     if !fs::metadata(chosen_system).is_ok() || system_arg.map_or(false, |s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(chosen_system).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/main.rs:86:48
[INFO] [stdout]    |
[INFO] [stdout] 86 |     if !fs::metadata(chosen_system).is_ok() || system_arg.map_or(false, |s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 86 -     if !fs::metadata(chosen_system).is_ok() || system_arg.map_or(false, |s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout] 86 +     if !fs::metadata(chosen_system).is_ok() || system_arg.is_some_and(|s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:92:24
[INFO] [stdout]    |
[INFO] [stdout] 92 |         match get_roms(&chosen_system) {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^ help: change this to: `chosen_system`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:112:30
[INFO] [stdout]     |
[INFO] [stdout] 112 |                         .arg(&chosen_rom)
[INFO] [stdout]     |                              ^^^^^^^^^^^ help: change this to: `chosen_rom`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:86:8
[INFO] [stdout]    |
[INFO] [stdout] 86 |     if !fs::metadata(chosen_system).is_ok() || system_arg.map_or(false, |s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(chosen_system).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `map_or` can be simplified
[INFO] [stdout]   --> src/main.rs:86:48
[INFO] [stdout]    |
[INFO] [stdout] 86 |     if !fs::metadata(chosen_system).is_ok() || system_arg.map_or(false, |s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_map_or)]` on by default
[INFO] [stdout] help: use `is_some_and` instead
[INFO] [stdout]    |
[INFO] [stdout] 86 -     if !fs::metadata(chosen_system).is_ok() || system_arg.map_or(false, |s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout] 86 +     if !fs::metadata(chosen_system).is_ok() || system_arg.is_some_and(|s| s.starts_with('/') || s.contains("..")) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/main.rs:92:24
[INFO] [stdout]    |
[INFO] [stdout] 92 |         match get_roms(&chosen_system) {
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^ help: change this to: `chosen_system`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:112:30
[INFO] [stdout]     |
[INFO] [stdout] 112 |                         .arg(&chosen_rom)
[INFO] [stdout]     |                              ^^^^^^^^^^^ help: change this to: `chosen_rom`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.31s
[INFO] running `Command { std: "docker" "inspect" "de03323c4b63369609489085891293c60b78877fcc9d1f24ff0a7838f688a615", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "de03323c4b63369609489085891293c60b78877fcc9d1f24ff0a7838f688a615", kill_on_drop: false }`
[INFO] [stdout] de03323c4b63369609489085891293c60b78877fcc9d1f24ff0a7838f688a615