[INFO] cloning repository https://github.com/cnsr/rust-snake [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cnsr/rust-snake" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcnsr%2Frust-snake", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcnsr%2Frust-snake'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f6de6d6dd85c6a9e61c2922de331bac962fc947 [INFO] linting cnsr/rust-snake against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcnsr%2Frust-snake" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cnsr/rust-snake [INFO] finished tweaking git repo https://github.com/cnsr/rust-snake [INFO] tweaked toml for git repo https://github.com/cnsr/rust-snake written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cnsr/rust-snake on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cnsr/rust-snake already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded getrandom v0.1.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc26de6b31bf12ad5dc82d0b5048f6e05a520a3d0f3e10f4f806e1a112595686 [INFO] running `Command { std: "docker" "start" "-a" "fc26de6b31bf12ad5dc82d0b5048f6e05a520a3d0f3e10f4f806e1a112595686", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc26de6b31bf12ad5dc82d0b5048f6e05a520a3d0f3e10f4f806e1a112595686", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc26de6b31bf12ad5dc82d0b5048f6e05a520a3d0f3e10f4f806e1a112595686", kill_on_drop: false }` [INFO] [stdout] fc26de6b31bf12ad5dc82d0b5048f6e05a520a3d0f3e10f4f806e1a112595686 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf35e00fe348f8e10e657dfc2a6ed2dbff4b4095e2882ee71376d18bb2399461 [INFO] running `Command { std: "docker" "start" "-a" "bf35e00fe348f8e10e657dfc2a6ed2dbff4b4095e2882ee71376d18bb2399461", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Compiling sdl2-sys v0.32.6 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking snake v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | pub mod lib; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::render::TextureQuery` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use sdl2::render::TextureQuery; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SnakeSegment` [INFO] [stdout] --> src/lib/snake.rs:1:48 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::lib::types::{Cell, SnakeHead, Grid, SnakeSegment, Food}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lib::grid_init` [INFO] [stdout] --> src/lib/snake.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::lib::grid_init; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/snake.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found module declaration for lib.rs [INFO] [stdout] --> src/main.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | pub mod lib; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: lib.rs is the root of this crate's library target [INFO] [stdout] = help: to refer to it from other targets, use the library's name as the path [INFO] [stdout] = note: `#[warn(special_module_name)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::render::TextureQuery` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use sdl2::render::TextureQuery; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SnakeSegment` [INFO] [stdout] --> src/lib/snake.rs:1:48 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::lib::types::{Cell, SnakeHead, Grid, SnakeSegment, Food}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::lib::grid_init` [INFO] [stdout] --> src/lib/snake.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::lib::grid_init; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib/snake.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | direction: direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/types.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | let mut newvec = vec.to_vec(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/types.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | let mut newvec = vec.to_vec(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dimensions` [INFO] [stdout] --> src/lib/snake.rs:7:54 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn change_grid(mut grid: Grid, head: &SnakeHead, dimensions: (u32, u32)) -> Grid{ [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dimensions` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> src/lib/snake.rs:49:56 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn draw_body(head: &mut SnakeHead, mut grid: Grid, direction: (i32, i32)) -> Grid { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cell_color` [INFO] [stdout] --> src/lib/snake.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let cell_color: Cell = Cell{red: 0_u8, green: 196_u8, blue: 0_u8}; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cell_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/snake.rs:64:35 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn draw_food(food: &mut Food, mut grid: Grid) -> Grid { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dimensions` [INFO] [stdout] --> src/lib/snake.rs:7:54 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn change_grid(mut grid: Grid, head: &SnakeHead, dimensions: (u32, u32)) -> Grid{ [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_dimensions` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut event_pump: EventPump = sdl_context.event_pump().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> src/lib/snake.rs:49:56 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn draw_body(head: &mut SnakeHead, mut grid: Grid, direction: (i32, i32)) -> Grid { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cell_color` [INFO] [stdout] --> src/lib/snake.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | let cell_color: Cell = Cell{red: 0_u8, green: 196_u8, blue: 0_u8}; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cell_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/snake.rs:64:35 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn draw_food(food: &mut Food, mut grid: Grid) -> Grid { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | let mut event_pump: EventPump = sdl_context.event_pump().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut direction: (i32, i32) = (1,0); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | let mut debug_text = format!("x {:?} y {:?} len {:?} seg {:?} fx {:?} fy {:?}", [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib/types.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 60 | let mut newvec = vec.to_vec(); [INFO] [stdout] | ------------------------------ unnecessary `let` binding [INFO] [stdout] 61 | newvec [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ vec.to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib/types.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | self.row = self.row + self.direction.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.row += self.direction.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib/types.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | self.column = self.column + self.direction.1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.column += self.direction.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/types.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if self.body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut direction: (i32, i32) = (1,0); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | let mut debug_text = format!("x {:?} y {:?} len {:?} seg {:?} fx {:?} fy {:?}", [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/snake.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if !(food.row % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(food.row % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/snake.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if !(food.col % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(food.col % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib/mod.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 45 | let grid = Grid{grid: grid_vector}; [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 46 | [INFO] [stdout] 47 | grid [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 45 ~ [INFO] [stdout] 46 | [INFO] [stdout] 47 ~ Grid{grid: grid_vector} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/mod.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / match square { [INFO] [stdout] 75 | | Err(error) => println!("{}", error), [INFO] [stdout] 76 | | Ok(()) => {} [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(error) = square { println!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/mod.rs:93:46 [INFO] [stdout] | [INFO] [stdout] 93 | display_cell(renderer, row, col, &grid, &cell_width) [INFO] [stdout] | ^^^^^ help: change this to: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/mod.rs:93:53 [INFO] [stdout] | [INFO] [stdout] 93 | display_cell(renderer, row, col, &grid, &cell_width) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `cell_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib/types.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 60 | let mut newvec = vec.to_vec(); [INFO] [stdout] | ------------------------------ unnecessary `let` binding [INFO] [stdout] 61 | newvec [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ vec.to_vec() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib/types.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | self.row = self.row + self.direction.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.row += self.direction.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib/types.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | self.column = self.column + self.direction.1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.column += self.direction.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib/types.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 86 | if self.body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | canvas.copy(&texture, None, Some(target)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 140 | let _ = canvas.copy(&texture, None, Some(target)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/snake.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | if !(food.row % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(food.row % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/snake.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if !(food.col % 2 == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(food.col % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib/mod.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 45 | let grid = Grid{grid: grid_vector}; [INFO] [stdout] | ----------------------------------- unnecessary `let` binding [INFO] [stdout] 46 | [INFO] [stdout] 47 | grid [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 45 ~ [INFO] [stdout] 46 | [INFO] [stdout] 47 ~ Grid{grid: grid_vector} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib/mod.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | / match square { [INFO] [stdout] 75 | | Err(error) => println!("{}", error), [INFO] [stdout] 76 | | Ok(()) => {} [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____^ help: try: `if let Err(error) = square { println!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/mod.rs:93:46 [INFO] [stdout] | [INFO] [stdout] 93 | display_cell(renderer, row, col, &grid, &cell_width) [INFO] [stdout] | ^^^^^ help: change this to: `grid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/mod.rs:93:53 [INFO] [stdout] | [INFO] [stdout] 93 | display_cell(renderer, row, col, &grid, &cell_width) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `cell_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | canvas.copy(&texture, None, Some(target)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 140 | let _ = canvas.copy(&texture, None, Some(target)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.35s [INFO] running `Command { std: "docker" "inspect" "bf35e00fe348f8e10e657dfc2a6ed2dbff4b4095e2882ee71376d18bb2399461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf35e00fe348f8e10e657dfc2a6ed2dbff4b4095e2882ee71376d18bb2399461", kill_on_drop: false }` [INFO] [stdout] bf35e00fe348f8e10e657dfc2a6ed2dbff4b4095e2882ee71376d18bb2399461