[INFO] cloning repository https://github.com/cmoyates/platformer-jump-checker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cmoyates/platformer-jump-checker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcmoyates%2Fplatformer-jump-checker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcmoyates%2Fplatformer-jump-checker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 10a0257749e3577ba2aad43046ec4bf93b53429d [INFO] linting cmoyates/platformer-jump-checker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcmoyates%2Fplatformer-jump-checker" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/cmoyates/platformer-jump-checker [INFO] finished tweaking git repo https://github.com/cmoyates/platformer-jump-checker [INFO] tweaked toml for git repo https://github.com/cmoyates/platformer-jump-checker written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cmoyates/platformer-jump-checker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cmoyates/platformer-jump-checker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ahash v0.8.8 [INFO] [stderr] Downloaded bevy_tasks v0.13.0 [INFO] [stderr] Downloaded bevy_encase_derive v0.13.0 [INFO] [stderr] Downloaded bevy_derive v0.13.0 [INFO] [stderr] Downloaded bevy_audio v0.13.0 [INFO] [stderr] Downloaded event-listener-strategy v0.5.0 [INFO] [stderr] Downloaded bevy_mikktspace v0.13.0 [INFO] [stderr] Downloaded gltf-derive v1.4.0 [INFO] [stderr] Downloaded bevy_internal v0.13.0 [INFO] [stderr] Downloaded gltf-json v1.4.0 [INFO] [stderr] Downloaded bevy_utils v0.13.0 [INFO] [stderr] Downloaded bevy_winit v0.13.0 [INFO] [stderr] Downloaded bevy_sprite v0.13.0 [INFO] [stderr] Downloaded bevy_asset v0.13.0 [INFO] [stderr] Downloaded bevy_animation v0.13.0 [INFO] [stderr] Downloaded bevy_gizmos v0.13.0 [INFO] [stderr] Downloaded bevy_gltf v0.13.0 [INFO] [stderr] Downloaded sysinfo v0.30.5 [INFO] [stderr] Downloaded bevy_diagnostic v0.13.0 [INFO] [stderr] Downloaded bevy_gizmos_macros v0.13.0 [INFO] [stderr] Downloaded gilrs-core v0.5.10 [INFO] [stderr] Downloaded bevy_asset_macros v0.13.0 [INFO] [stderr] Downloaded gilrs v0.10.4 [INFO] [stderr] Downloaded bevy_reflect v0.13.0 [INFO] [stderr] Downloaded wgpu-core v0.19.0 [INFO] [stderr] Downloaded wgpu-hal v0.19.1 [INFO] [stderr] Downloaded bevy_utils_proc_macros v0.13.0 [INFO] [stderr] Downloaded bevy v0.13.0 [INFO] [stderr] Downloaded wgpu v0.19.1 [INFO] [stderr] Downloaded bevy_render v0.13.0 [INFO] [stderr] Downloaded ruzstd v0.5.0 [INFO] [stderr] Downloaded bevy_ecs v0.13.0 [INFO] [stderr] Downloaded winit v0.29.10 [INFO] [stderr] Downloaded bevy_core_pipeline v0.13.0 [INFO] [stderr] Downloaded naga v0.19.0 [INFO] [stderr] Downloaded bevy_text v0.13.0 [INFO] [stderr] Downloaded bevy_hierarchy v0.13.0 [INFO] [stderr] Downloaded bevy_window v0.13.0 [INFO] [stderr] Downloaded wgpu-types v0.19.0 [INFO] [stderr] Downloaded bevy_gilrs v0.13.0 [INFO] [stderr] Downloaded bevy_ptr v0.13.0 [INFO] [stderr] Downloaded io-kit-sys v0.4.0 [INFO] [stderr] Downloaded bevy_app v0.13.0 [INFO] [stderr] Downloaded bumpalo v3.15.0 [INFO] [stderr] Downloaded async-fs v2.1.1 [INFO] [stderr] Downloaded bevy_render_macros v0.13.0 [INFO] [stderr] Downloaded encase v0.7.0 [INFO] [stderr] Downloaded hexasphere v10.0.0 [INFO] [stderr] Downloaded bevy_core v0.13.0 [INFO] [stderr] Downloaded bevy_log v0.13.0 [INFO] [stderr] Downloaded bevy_ecs_macros v0.13.0 [INFO] [stderr] Downloaded event-listener v5.1.0 [INFO] [stderr] Downloaded bevy_math v0.13.0 [INFO] [stderr] Downloaded bevy_pbr v0.13.0 [INFO] [stderr] Downloaded erased-serde v0.4.3 [INFO] [stderr] Downloaded gltf v1.4.0 [INFO] [stderr] Downloaded bevy_scene v0.13.0 [INFO] [stderr] Downloaded bevy_time v0.13.0 [INFO] [stderr] Downloaded encase_derive_impl v0.7.0 [INFO] [stderr] Downloaded taffy v0.3.18 [INFO] [stderr] Downloaded bevy_macro_utils v0.13.0 [INFO] [stderr] Downloaded naga_oil v0.13.0 [INFO] [stderr] Downloaded bevy_reflect_derive v0.13.0 [INFO] [stderr] Downloaded bytemuck v1.14.3 [INFO] [stderr] Downloaded polling v3.5.0 [INFO] [stderr] Downloaded bevy_ui v0.13.0 [INFO] [stderr] Downloaded async-channel v2.2.0 [INFO] [stderr] Downloaded bevy_transform v0.13.0 [INFO] [stderr] Downloaded bevy_a11y v0.13.0 [INFO] [stderr] Downloaded bevy_input v0.13.0 [INFO] [stderr] Downloaded image v0.24.8 [INFO] [stderr] Downloaded accesskit_winit v0.17.0 [INFO] [stderr] Downloaded syn v2.0.49 [INFO] [stderr] Downloaded encase_derive v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5f7002549e45b6540629a4dbe24b8485cf296cd38efd12564640b46594bba7e [INFO] running `Command { std: "docker" "start" "-a" "e5f7002549e45b6540629a4dbe24b8485cf296cd38efd12564640b46594bba7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5f7002549e45b6540629a4dbe24b8485cf296cd38efd12564640b46594bba7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5f7002549e45b6540629a4dbe24b8485cf296cd38efd12564640b46594bba7e", kill_on_drop: false }` [INFO] [stdout] e5f7002549e45b6540629a4dbe24b8485cf296cd38efd12564640b46594bba7e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2eaeb6c4fa27865e57180bc5426a8a6bbcbe9ec0a0ee5b3969409f19b6fd1717 [INFO] running `Command { std: "docker" "start" "-a" "2eaeb6c4fa27865e57180bc5426a8a6bbcbe9ec0a0ee5b3969409f19b6fd1717", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling ahash v0.8.8 [INFO] [stderr] Compiling indexmap v2.2.3 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v2.0.49 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Checking nonmax v0.5.5 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking bevy_ptr v0.13.0 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking raw-window-handle v0.6.0 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling wgpu-hal v0.19.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking accesskit v0.12.2 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Compiling wgpu-core v0.19.0 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking renderdoc-sys v1.0.0 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling wgpu v0.19.1 [INFO] [stderr] Checking const_soft_float v0.1.4 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking const_panic v0.2.8 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.1.0 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Checking constgebra v0.1.3 [INFO] [stderr] Checking ktx2 v0.3.0 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Compiling uuid v1.7.0 [INFO] [stderr] Checking radsort v0.1.0 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking svg_fmt v0.4.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking bevy_tasks v0.13.0 [INFO] [stderr] Checking euclid v0.22.9 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Compiling winit v0.29.10 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking xkeysym v0.2.0 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking x11rb-protocol v0.13.0 [INFO] [stderr] Checking rectangle-pack v0.4.2 [INFO] [stderr] Checking ab_glyph v0.2.23 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Compiling gilrs v0.10.4 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking grid v0.10.0 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking sysinfo v0.30.5 [INFO] [stderr] Checking const-fnv1a-hash v1.1.0 [INFO] [stderr] Checking glyph_brush_layout v0.2.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking taffy v0.3.18 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling bevy_macro_utils v0.13.0 [INFO] [stderr] Compiling encase_derive_impl v0.7.0 [INFO] [stderr] Checking ruzstd v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.13.0 [INFO] [stderr] Compiling bevy_reflect_derive v0.13.0 [INFO] [stderr] Compiling bevy_ecs_macros v0.13.0 [INFO] [stderr] Compiling bevy_derive v0.13.0 [INFO] [stderr] Compiling bevy_asset_macros v0.13.0 [INFO] [stderr] Compiling bevy_render_macros v0.13.0 [INFO] [stderr] Compiling gltf-derive v1.4.0 [INFO] [stderr] Compiling bevy_gizmos_macros v0.13.0 [INFO] [stderr] Compiling encase_derive v0.7.0 [INFO] [stderr] Compiling bevy_encase_derive v0.13.0 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking image v0.24.8 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.57 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking async-fs v2.1.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking glam v0.25.0 [INFO] [stderr] Checking erased-serde v0.4.3 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking wgpu-types v0.19.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking gilrs-core v0.5.10 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking gltf-json v1.4.0 [INFO] [stderr] Checking rodio v0.17.3 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking naga v0.19.0 [INFO] [stderr] Checking bevy_math v0.13.0 [INFO] [stderr] Checking encase v0.7.0 [INFO] [stderr] Checking hexasphere v10.0.0 [INFO] [stderr] Checking bevy_mikktspace v0.13.0 [INFO] [stderr] Checking bevy_utils v0.13.0 [INFO] [stderr] Checking bevy_reflect v0.13.0 [INFO] [stderr] Checking gltf v1.4.0 [INFO] [stderr] Checking polling v3.5.0 [INFO] [stderr] Checking x11rb v0.13.0 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking bevy_ecs v0.13.0 [INFO] [stderr] Checking accesskit_winit v0.17.0 [INFO] [stderr] Checking naga_oil v0.13.0 [INFO] [stderr] Checking bevy_app v0.13.0 [INFO] [stderr] Checking bevy_log v0.13.0 [INFO] [stderr] Checking bevy_core v0.13.0 [INFO] [stderr] Checking bevy_input v0.13.0 [INFO] [stderr] Checking bevy_time v0.13.0 [INFO] [stderr] Checking bevy_a11y v0.13.0 [INFO] [stderr] Checking bevy_asset v0.13.0 [INFO] [stderr] Checking bevy_hierarchy v0.13.0 [INFO] [stderr] Checking bevy_diagnostic v0.13.0 [INFO] [stderr] Checking bevy_transform v0.13.0 [INFO] [stderr] Checking bevy_window v0.13.0 [INFO] [stderr] Checking bevy_gilrs v0.13.0 [INFO] [stderr] Checking bevy_audio v0.13.0 [INFO] [stderr] Checking bevy_winit v0.13.0 [INFO] [stderr] Checking bevy_render v0.13.0 [INFO] [stderr] Checking bevy_core_pipeline v0.13.0 [INFO] [stderr] Checking bevy_animation v0.13.0 [INFO] [stderr] Checking bevy_scene v0.13.0 [INFO] [stderr] Checking bevy_sprite v0.13.0 [INFO] [stderr] Checking bevy_pbr v0.13.0 [INFO] [stderr] Checking bevy_text v0.13.0 [INFO] [stderr] Checking bevy_ui v0.13.0 [INFO] [stderr] Checking bevy_gizmos v0.13.0 [INFO] [stderr] Checking bevy_gltf v0.13.0 [INFO] [stderr] Checking bevy_internal v0.13.0 [INFO] [stderr] Checking bevy v0.13.0 [INFO] [stderr] Checking platformer-jump-checker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/level.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | const LEVEL_DATA: &'static [u8] = include_bytes!("../assets/level.json"); [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/pathfinding.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | polygon_index: polygon_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polygon_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/pathfinding.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | polygon_index: polygon_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polygon_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/level.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | const LEVEL_DATA: &'static [u8] = include_bytes!("../assets/level.json"); [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/pathfinding.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | polygon_index: polygon_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polygon_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/pathfinding.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | polygon_index: polygon_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `polygon_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 95 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `start` [INFO] [stdout] --> src/level.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn line_of_sight_check(&self, start: Vec2, end: Vec2) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_start` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/level.rs:34:52 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn line_of_sight_check(&self, start: Vec2, end: Vec2) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 95 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `jump_possible` is never read [INFO] [stdout] --> src/jump_check.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | jump_possible = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `start` [INFO] [stdout] --> src/level.rs:34:39 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn line_of_sight_check(&self, start: Vec2, end: Vec2) -> bool { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_start` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `jumpability_check` is never used [INFO] [stdout] --> src/jump_check.rs:176:8 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn jumpability_check(pathfinding: &Pathfinding, level: &Level, radius: f32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `end` [INFO] [stdout] --> src/level.rs:34:52 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn line_of_sight_check(&self, start: Vec2, end: Vec2) -> bool { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `draw_jump_arc` is never used [INFO] [stdout] --> src/jump_check.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 294 | pub fn draw_jump_arc( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PolygonLine` is never constructed [INFO] [stdout] --> src/level.rs:302:12 [INFO] [stdout] | [INFO] [stdout] 302 | pub struct PolygonLine { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `side_of_line_detection` is never used [INFO] [stdout] --> src/utils.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn side_of_line_detection(line_start: Vec2, line_end: Vec2, point: Vec2) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/jump_check.rs:49:35 [INFO] [stdout] | [INFO] [stdout] 49 | let timestep = t_low_energy / 10 as f32; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/jump_check.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return jump_possible; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return jump_possible; [INFO] [stdout] 291 + jump_possible [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/jump_check.rs:195:35 [INFO] [stdout] | [INFO] [stdout] 195 | let timestep = t_low_energy / 10 as f32; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/jump_check.rs:294:1 [INFO] [stdout] | [INFO] [stdout] 294 | / pub fn draw_jump_arc( [INFO] [stdout] 295 | | start_pos: Vec2, [INFO] [stdout] 296 | | goal_pos: Vec2, [INFO] [stdout] 297 | | launch_velocity: Vec2, [INFO] [stdout] ... | [INFO] [stdout] 302 | | radius: f32, [INFO] [stdout] 303 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return true; [INFO] [stdout] 48 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `point_removal_data` after checking its variant with `is_some` [INFO] [stdout] --> src/level.rs:131:38 [INFO] [stdout] | [INFO] [stdout] 130 | if point_removal_data.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = point_removal_data` [INFO] [stdout] 131 | let point_removal_data = point_removal_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 266 | return (polygons, size, size / 2.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 266 - return (polygons, size, size / 2.0); [INFO] [stdout] 266 + (polygons, size, size / 2.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/level.rs:58:65 [INFO] [stdout] | [INFO] [stdout] 58 | let level_grid_data: Vec> = serde_json::from_str(&res.unwrap()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `res.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `jumpability_check` is never used [INFO] [stdout] --> src/jump_check.rs:176:8 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn jumpability_check(pathfinding: &Pathfinding, level: &Level, radius: f32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `draw_jump_arc` is never used [INFO] [stdout] --> src/jump_check.rs:294:8 [INFO] [stdout] | [INFO] [stdout] 294 | pub fn draw_jump_arc( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PolygonLine` is never constructed [INFO] [stdout] --> src/level.rs:302:12 [INFO] [stdout] | [INFO] [stdout] 302 | pub struct PolygonLine { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `side_of_line_detection` is never used [INFO] [stdout] --> src/utils.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn side_of_line_detection(line_start: Vec2, line_end: Vec2, point: Vec2) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/jump_check.rs:49:35 [INFO] [stdout] | [INFO] [stdout] 49 | let timestep = t_low_energy / 10 as f32; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:134:33 [INFO] [stdout] | [INFO] [stdout] 134 | let unique_vert_1 = line_points[point_removal_data.1 .0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[point_removal_data.1 .0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:135:33 [INFO] [stdout] | [INFO] [stdout] 135 | let unique_vert_2 = line_points[point_removal_data.1 .1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[point_removal_data.1 .1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/jump_check.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return jump_possible; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return jump_possible; [INFO] [stdout] 291 + jump_possible [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `line_points` [INFO] [stdout] --> src/level.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | for i in 0..line_points.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 159 - for i in 0..line_points.len() { [INFO] [stdout] 159 + for in &mut line_points { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:180:28 [INFO] [stdout] | [INFO] [stdout] 180 | polygon_lines.push(line_points[0].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:181:28 [INFO] [stdout] | [INFO] [stdout] 181 | polygon_lines.push(line_points[1].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/jump_check.rs:195:35 [INFO] [stdout] | [INFO] [stdout] 195 | let timestep = t_low_energy / 10 as f32; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:190:26 [INFO] [stdout] | [INFO] [stdout] 190 | let start_vert = polygon_lines[0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `polygon_lines[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:191:32 [INFO] [stdout] | [INFO] [stdout] 191 | let mut current_vert = polygon_lines[polygon_lines.len() - 1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `polygon_lines[polygon_lines.len() - 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/level.rs:227:21 [INFO] [stdout] | [INFO] [stdout] 227 | line_count -= 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:196:34 [INFO] [stdout] | [INFO] [stdout] 196 | let line_start = line_points[i * 2].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[i * 2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:197:32 [INFO] [stdout] | [INFO] [stdout] 197 | let line_end = line_points[i * 2 + 1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[i * 2 + 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 202 | polygon_lines.push(line_end.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:220:40 [INFO] [stdout] | [INFO] [stdout] 220 | polygon_lines.push(line_start.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/jump_check.rs:294:1 [INFO] [stdout] | [INFO] [stdout] 294 | / pub fn draw_jump_arc( [INFO] [stdout] 295 | | start_pos: Vec2, [INFO] [stdout] 296 | | goal_pos: Vec2, [INFO] [stdout] 297 | | launch_velocity: Vec2, [INFO] [stdout] ... | [INFO] [stdout] 302 | | radius: f32, [INFO] [stdout] 303 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/level.rs:269:38 [INFO] [stdout] | [INFO] [stdout] 269 | fn calculate_winding_order(vertices: &Vec) -> f32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 269 - fn calculate_winding_order(vertices: &Vec) -> f32 { [INFO] [stdout] 269 + fn calculate_winding_order(vertices: &[Vec2]) -> f32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 298 | return intersect_counter % 2 == 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return intersect_counter % 2 == 1; [INFO] [stdout] 298 + intersect_counter % 2 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/level.rs:281:36 [INFO] [stdout] | [INFO] [stdout] 281 | fn point_in_polygon(polygon_lines: &Vec, point: Vec2) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 281 - fn point_in_polygon(polygon_lines: &Vec, point: Vec2) -> bool { [INFO] [stdout] 281 + fn point_in_polygon(polygon_lines: &[Vec2], point: Vec2) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return true; [INFO] [stdout] 48 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `point_removal_data` after checking its variant with `is_some` [INFO] [stdout] --> src/level.rs:131:38 [INFO] [stdout] | [INFO] [stdout] 130 | if point_removal_data.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = point_removal_data` [INFO] [stdout] 131 | let point_removal_data = point_removal_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:710:5 [INFO] [stdout] | [INFO] [stdout] 710 | return line_points; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 710 - return line_points; [INFO] [stdout] 710 + line_points [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:266:5 [INFO] [stdout] | [INFO] [stdout] 266 | return (polygons, size, size / 2.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 266 - return (polygons, size, size / 2.0); [INFO] [stdout] 266 + (polygons, size, size / 2.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/level.rs:58:65 [INFO] [stdout] | [INFO] [stdout] 58 | let level_grid_data: Vec> = serde_json::from_str(&res.unwrap()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `res.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/pathfinding.rs:101:39 [INFO] [stdout] | [INFO] [stdout] 101 | let nodes_on_line_count = (length.abs() / 20.0).ceil() as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(length.abs() / 20.0).ceil()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:134:33 [INFO] [stdout] | [INFO] [stdout] 134 | let unique_vert_1 = line_points[point_removal_data.1 .0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[point_removal_data.1 .0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:135:33 [INFO] [stdout] | [INFO] [stdout] 135 | let unique_vert_2 = line_points[point_removal_data.1 .1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[point_removal_data.1 .1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pathfinding.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 383 | return Some(launch_velocity.length()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return Some(launch_velocity.length()); [INFO] [stdout] 383 + Some(launch_velocity.length()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/pathfinding.rs:335:35 [INFO] [stdout] | [INFO] [stdout] 335 | let timestep = t_low_energy / 10 as f32; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `line_points` [INFO] [stdout] --> src/level.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | for i in 0..line_points.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 159 - for i in 0..line_points.len() { [INFO] [stdout] 159 + for in &mut line_points { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:180:28 [INFO] [stdout] | [INFO] [stdout] 180 | polygon_lines.push(line_points[0].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:181:28 [INFO] [stdout] | [INFO] [stdout] 181 | polygon_lines.push(line_points[1].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:190:26 [INFO] [stdout] | [INFO] [stdout] 190 | let start_vert = polygon_lines[0].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `polygon_lines[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:191:32 [INFO] [stdout] | [INFO] [stdout] 191 | let mut current_vert = polygon_lines[polygon_lines.len() - 1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `polygon_lines[polygon_lines.len() - 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: attempt to mutate range bound within loop [INFO] [stdout] --> src/level.rs:227:21 [INFO] [stdout] | [INFO] [stdout] 227 | line_count -= 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the range of the loop is unchanged [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_range_bound [INFO] [stdout] = note: `#[warn(clippy::mut_range_bound)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:196:34 [INFO] [stdout] | [INFO] [stdout] 196 | let line_start = line_points[i * 2].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[i * 2]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:197:32 [INFO] [stdout] | [INFO] [stdout] 197 | let line_end = line_points[i * 2 + 1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_points[i * 2 + 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 202 | polygon_lines.push(line_end.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/level.rs:220:40 [INFO] [stdout] | [INFO] [stdout] 220 | polygon_lines.push(line_start.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `line_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/level.rs:269:38 [INFO] [stdout] | [INFO] [stdout] 269 | fn calculate_winding_order(vertices: &Vec) -> f32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 269 - fn calculate_winding_order(vertices: &Vec) -> f32 { [INFO] [stdout] 269 + fn calculate_winding_order(vertices: &[Vec2]) -> f32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:298:5 [INFO] [stdout] | [INFO] [stdout] 298 | return intersect_counter % 2 == 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return intersect_counter % 2 == 1; [INFO] [stdout] 298 + intersect_counter % 2 == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/utils.rs:20:32 [INFO] [stdout] | [INFO] [stdout] 20 | if t >= 0.0 && t <= 1.0 && u >= 0.0 && u <= 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&u)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/level.rs:281:36 [INFO] [stdout] | [INFO] [stdout] 281 | fn point_in_polygon(polygon_lines: &Vec, point: Vec2) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 281 - fn point_in_polygon(polygon_lines: &Vec, point: Vec2) -> bool { [INFO] [stdout] 281 + fn point_in_polygon(polygon_lines: &[Vec2], point: Vec2) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/utils.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | if t >= 0.0 && t <= 1.0 && u >= 0.0 && u <= 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return determinant.signum(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return determinant.signum(); [INFO] [stdout] 38 + determinant.signum() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/level.rs:710:5 [INFO] [stdout] | [INFO] [stdout] 710 | return line_points; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 710 - return line_points; [INFO] [stdout] 710 + line_points [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/main.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | polygon.points.iter().cloned().collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/pathfinding.rs:101:39 [INFO] [stdout] | [INFO] [stdout] 101 | let nodes_on_line_count = (length.abs() / 20.0).ceil() as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(length.abs() / 20.0).ceil()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/pathfinding.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 383 | return Some(launch_velocity.length()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return Some(launch_velocity.length()); [INFO] [stdout] 383 + Some(launch_velocity.length()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/pathfinding.rs:335:35 [INFO] [stdout] | [INFO] [stdout] 335 | let timestep = t_low_energy / 10 as f32; [INFO] [stdout] | ^^^^^^^^^ help: try: `10_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/utils.rs:20:32 [INFO] [stdout] | [INFO] [stdout] 20 | if t >= 0.0 && t <= 1.0 && u >= 0.0 && u <= 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&u)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/utils.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | if t >= 0.0 && t <= 1.0 && u >= 0.0 && u <= 1.0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&t)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return determinant.signum(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return determinant.signum(); [INFO] [stdout] 38 + determinant.signum() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/main.rs:110:27 [INFO] [stdout] | [INFO] [stdout] 110 | polygon.points.iter().cloned().collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 41s [INFO] running `Command { std: "docker" "inspect" "2eaeb6c4fa27865e57180bc5426a8a6bbcbe9ec0a0ee5b3969409f19b6fd1717", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2eaeb6c4fa27865e57180bc5426a8a6bbcbe9ec0a0ee5b3969409f19b6fd1717", kill_on_drop: false }` [INFO] [stdout] 2eaeb6c4fa27865e57180bc5426a8a6bbcbe9ec0a0ee5b3969409f19b6fd1717