[INFO] cloning repository https://github.com/cloudcalvin/raven [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cloudcalvin/raven" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcloudcalvin%2Fraven", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcloudcalvin%2Fraven'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 32273c5b887e722d17b018f515e5a5597cd37137 [INFO] linting cloudcalvin/raven against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcloudcalvin%2Fraven" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cloudcalvin/raven [INFO] finished tweaking git repo https://github.com/cloudcalvin/raven [INFO] tweaked toml for git repo https://github.com/cloudcalvin/raven written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cloudcalvin/raven on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cloudcalvin/raven already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded regex-syntax v0.2.2 [INFO] [stderr] Downloaded aho-corasick v0.4.0 [INFO] [stderr] Downloaded regex v0.1.48 [INFO] [stderr] Downloaded memchr v0.1.7 [INFO] [stderr] Downloaded libc v0.2.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4749877ffda77d0e857292409d1ea0187302903e3527db45e23186001786588d [INFO] running `Command { std: "docker" "start" "-a" "4749877ffda77d0e857292409d1ea0187302903e3527db45e23186001786588d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4749877ffda77d0e857292409d1ea0187302903e3527db45e23186001786588d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4749877ffda77d0e857292409d1ea0187302903e3527db45e23186001786588d", kill_on_drop: false }` [INFO] [stdout] 4749877ffda77d0e857292409d1ea0187302903e3527db45e23186001786588d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf6fa96d264cfce202a0728891f2317d135b82bfd61c45ecefc70e9498283256 [INFO] running `Command { std: "docker" "start" "-a" "bf6fa96d264cfce202a0728891f2317d135b82bfd61c45ecefc70e9498283256", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.6 [INFO] [stderr] Checking regex-syntax v0.2.2 [INFO] [stderr] Checking memchr v0.1.7 [INFO] [stderr] Checking aho-corasick v0.4.0 [INFO] [stderr] Checking regex v0.1.48 [INFO] [stderr] Checking raven_renamer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if !_cap.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `_cap.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `_cap` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 54 | if !_cap.is_none(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 55 | println!("{}",_cap.unwrap().name("b").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:21:30 [INFO] [stdout] | [INFO] [stdout] 21 | let paths = fs::read_dir(&Path::new( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 22 | | &env::current_dir().unwrap())).unwrap(); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 ~ let paths = fs::read_dir(Path::new( [INFO] [stdout] 22 ~ &env::current_dir().unwrap())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:39:11 [INFO] [stdout] | [INFO] [stdout] 37 | let file_name_as_string = String::from(file_name_as_str); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 38 | [INFO] [stdout] 39 | file_name_as_string [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 | [INFO] [stdout] 39 ~ String::from(file_name_as_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if !_cap.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `_cap.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `_cap` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 54 | if !_cap.is_none(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 55 | println!("{}",_cap.unwrap().name("b").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:21:30 [INFO] [stdout] | [INFO] [stdout] 21 | let paths = fs::read_dir(&Path::new( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 22 | | &env::current_dir().unwrap())).unwrap(); [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 ~ let paths = fs::read_dir(Path::new( [INFO] [stdout] 22 ~ &env::current_dir().unwrap())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:39:11 [INFO] [stdout] | [INFO] [stdout] 37 | let file_name_as_string = String::from(file_name_as_str); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 38 | [INFO] [stdout] 39 | file_name_as_string [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 | [INFO] [stdout] 39 ~ String::from(file_name_as_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `Command { std: "docker" "inspect" "bf6fa96d264cfce202a0728891f2317d135b82bfd61c45ecefc70e9498283256", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf6fa96d264cfce202a0728891f2317d135b82bfd61c45ecefc70e9498283256", kill_on_drop: false }` [INFO] [stdout] bf6fa96d264cfce202a0728891f2317d135b82bfd61c45ecefc70e9498283256