[INFO] cloning repository https://github.com/clockworksfr/cosmic-hue-applet [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/clockworksfr/cosmic-hue-applet" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclockworksfr%2Fcosmic-hue-applet", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclockworksfr%2Fcosmic-hue-applet'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54e227df9615da78f363704c61e1d4052aa53f5b [INFO] linting clockworksfr/cosmic-hue-applet against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclockworksfr%2Fcosmic-hue-applet" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/clockworksfr/cosmic-hue-applet [INFO] finished tweaking git repo https://github.com/clockworksfr/cosmic-hue-applet [INFO] tweaked toml for git repo https://github.com/clockworksfr/cosmic-hue-applet written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/clockworksfr/cosmic-hue-applet on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/clockworksfr/cosmic-hue-applet already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/pop-os/libcosmic.git` [INFO] [stderr] Updating git submodule `https://github.com/pop-os/iced.git` [INFO] [stderr] Updating git submodule `https://github.com/pop-os/cosmic-icons` [INFO] [stderr] Updating git repository `https://github.com/pop-os/cosmic-protocols` [INFO] [stderr] Updating git repository `https://github.com/pop-os/cosmic-panel` [INFO] [stderr] Updating git repository `https://github.com/pop-os/dbus-settings-bindings` [INFO] [stderr] Updating git repository `https://github.com/pop-os/freedesktop-icons` [INFO] [stderr] Updating git repository `https://github.com/jackpot51/rust-atomicwrites` [INFO] [stderr] Updating git repository `https://github.com/pop-os/window_clipboard.git` [INFO] [stderr] Updating git repository `https://github.com/wash2/accesskit` [INFO] [stderr] Updating git repository `https://github.com/pop-os/cosmic-text.git` [INFO] [stderr] Updating git repository `https://github.com/pop-os/softbuffer` [INFO] [stderr] Updating git repository `https://github.com/pop-os/winit.git` [INFO] [stderr] Updating git repository `https://github.com/pop-os/smithay-clipboard` [INFO] [stderr] Updating git repository `https://github.com/pop-os/glyphon.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded kamadak-exif v0.5.5 [INFO] [stderr] Downloaded apply v0.3.0 [INFO] [stderr] Downloaded drm-sys v0.6.1 [INFO] [stderr] Downloaded xdg v3.0.0 [INFO] [stderr] Downloaded iced_color_picker v0.14.0 [INFO] [stderr] Downloaded redox_event v0.4.5 [INFO] [stderr] Downloaded csscolorparser v0.8.2 [INFO] [stderr] Downloaded almost v0.2.0 [INFO] [stderr] Downloaded huelib v0.13.2 [INFO] [stderr] Downloaded arc-swap v1.8.1 [INFO] [stderr] Downloaded ashpd v0.12.1 [INFO] [stderr] Downloaded css-color v0.2.8 [INFO] [stderr] Downloaded lyon_tessellation v1.0.16 [INFO] [stderr] Downloaded lyon_path v1.0.16 [INFO] [stderr] Downloaded btoi v0.5.0 [INFO] [stderr] Downloaded skrifa v0.40.0 [INFO] [stderr] Downloaded drm v0.11.1 [INFO] [stderr] Downloaded harfrust v0.5.0 [INFO] [stderr] Downloaded d3d12 v22.0.0 [INFO] [stderr] Downloaded auto_enums v0.8.7 [INFO] [stderr] Downloaded wayland-server v0.31.11 [INFO] [stderr] Downloaded ouroboros_macro v0.18.5 [INFO] [stderr] Downloaded read-fonts v0.37.0 [INFO] [stderr] Downloaded lyon_geom v1.0.18 [INFO] [stderr] Downloaded known-folders v1.4.0 [INFO] [stderr] Downloaded derive_setters v0.1.9 [INFO] [stderr] Downloaded lyon_algorithms v1.0.16 [INFO] [stderr] Downloaded font-types v0.11.0 [INFO] [stderr] Downloaded zune-core v0.5.1 [INFO] [stderr] Downloaded float_next_after v1.0.0 [INFO] [stderr] Downloaded ctor-lite v0.1.1 [INFO] [stderr] Downloaded ouroboros v0.18.5 [INFO] [stderr] Downloaded smol_str v0.3.5 [INFO] [stderr] Downloaded zune-jpeg v0.5.12 [INFO] [stderr] Downloaded derive_utils v0.15.0 [INFO] [stderr] Downloaded lyon v1.0.16 [INFO] [stderr] Downloaded mutate_once v0.1.2 [INFO] [stderr] Downloaded drm-ffi v0.7.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 596b8c05dd002fbc6febf93417c46587930f7049a85727b92916d292f0faa1bb [INFO] running `Command { std: "docker" "start" "-a" "596b8c05dd002fbc6febf93417c46587930f7049a85727b92916d292f0faa1bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "596b8c05dd002fbc6febf93417c46587930f7049a85727b92916d292f0faa1bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "596b8c05dd002fbc6febf93417c46587930f7049a85727b92916d292f0faa1bb", kill_on_drop: false }` [INFO] [stdout] 596b8c05dd002fbc6febf93417c46587930f7049a85727b92916d292f0faa1bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7bb2416721e1be049142a8fdd30d54b9e804752f8270b0c873e8f1e8acc2fbbc [INFO] running `Command { std: "docker" "start" "-a" "7bb2416721e1be049142a8fdd30d54b9e804752f8270b0c873e8f1e8acc2fbbc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.9 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking wayland-server v0.31.11 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking immutable-chunkmap v2.1.2 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling slotmap v1.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking accesskit v0.16.0 (https://github.com/wash2/accesskit?tag=iced-xdg-surface-0.13-rc#c46afc04) [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Compiling winit v0.30.5 (https://github.com/pop-os/winit.git?tag=iced-xdg-surface-0.13-rc#dd46a149) [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking accesskit_consumer v0.24.0 (https://github.com/wash2/accesskit?tag=iced-xdg-surface-0.13-rc#c46afc04) [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking glam v0.25.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Checking dpi v0.1.1 (https://github.com/pop-os/winit.git?tag=iced-xdg-surface-0.13-rc#dd46a149) [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking fontconfig-parser v0.5.8 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking xkbcommon v0.8.0 [INFO] [stderr] Checking font-types v0.10.1 [INFO] [stderr] Compiling palette v0.7.6 [INFO] [stderr] Compiling by_address v1.2.1 [INFO] [stderr] Compiling palette_derive v0.7.6 [INFO] [stderr] Checking read-fonts v0.35.0 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking self_cell v1.2.2 [INFO] [stderr] Checking fast-srgb8 v1.0.0 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Checking unicode-script v0.5.8 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Compiling unic-langid-impl v0.9.6 [INFO] [stderr] Compiling zvariant_utils v3.3.0 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking sys-locale v0.3.2 [INFO] [stderr] Checking zeno v0.3.3 [INFO] [stderr] Checking yazi v0.2.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling zvariant_derive v5.9.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stderr] Compiling unic-langid v0.9.6 [INFO] [stderr] Checking fontdb v0.23.0 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking font-types v0.11.0 [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stderr] Checking euclid v0.22.13 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Checking rangemap v1.7.1 [INFO] [stderr] Checking cosmic-protocols v0.1.0 (https://github.com/pop-os/cosmic-protocols?rev=d0e95be#d0e95be2) [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking linebender_resource_handle v0.1.1 [INFO] [stderr] Checking lyon_geom v1.0.18 [INFO] [stderr] Checking smithay-clipboard v0.8.0 (https://github.com/pop-os/smithay-clipboard?tag=pop-dnd-5#5a3007de) [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking skrifa v0.37.0 [INFO] [stderr] Checking mime v0.1.0 (https://github.com/pop-os/window_clipboard.git?tag=pop-0.13-2#6b9faab8) [INFO] [stderr] Checking read-fonts v0.37.0 [INFO] [stderr] Checking dnd v0.1.0 (https://github.com/pop-os/window_clipboard.git?tag=pop-0.13-2#6b9faab8) [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking clipboard_wayland v0.2.2 (https://github.com/pop-os/window_clipboard.git?tag=pop-0.13-2#6b9faab8) [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Compiling drm-sys v0.6.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Checking cosmic-client-toolkit v0.1.0 (https://github.com/pop-os/cosmic-protocols?rev=d0e95be#d0e95be2) [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking lyon_path v1.0.16 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking accesskit_atspi_common v0.9.0 (https://github.com/wash2/accesskit?tag=iced-xdg-surface-0.13-rc#c46afc04) [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Checking linux-raw-sys v0.6.5 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling drm-fourcc v2.2.0 [INFO] [stderr] Checking swash v0.2.6 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stderr] Checking accesskit_unix v0.12.0 (https://github.com/wash2/accesskit?tag=iced-xdg-surface-0.13-rc#c46afc04) [INFO] [stderr] Checking clipboard_x11 v0.4.2 (https://github.com/pop-os/window_clipboard.git?tag=pop-0.13-2#6b9faab8) [INFO] [stderr] Checking window_clipboard v0.4.1 (https://github.com/pop-os/window_clipboard.git?tag=pop-0.13-2#6b9faab8) [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Compiling zvariant v5.9.2 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking kurbo v0.11.3 [INFO] [stderr] Compiling tiny-xlib v0.2.4 [INFO] [stderr] Checking mutate_once v0.1.2 [INFO] [stderr] Checking unicode-bidi-mirroring v0.2.0 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking skrifa v0.40.0 [INFO] [stderr] Checking harfrust v0.5.0 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking unicode-ccc v0.2.0 [INFO] [stderr] Checking smol_str v0.3.5 [INFO] [stderr] Checking accesskit_winit v0.22.0 (https://github.com/wash2/accesskit?tag=iced-xdg-surface-0.13-rc#c46afc04) [INFO] [stderr] Checking rustybuzz v0.14.1 [INFO] [stderr] Compiling zbus_names v4.3.1 [INFO] [stderr] Checking svgtypes v0.15.3 [INFO] [stderr] Checking iced_accessibility v0.1.0 (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking iced_core v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking kamadak-exif v0.5.5 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking drm-ffi v0.7.1 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Compiling rust-embed-utils v8.11.0 [INFO] [stderr] Checking fontdb v0.18.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Compiling softbuffer v0.4.1 (https://github.com/pop-os/softbuffer?tag=cosmic-4.0#a3f77e25) [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking simplecss v0.2.2 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Checking unicode-vo v0.1.0 [INFO] [stderr] Checking data-url v0.3.2 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Checking imagesize v0.12.0 [INFO] [stderr] Checking ctor-lite v0.1.1 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking iced_futures v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Compiling typeid v1.0.3 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Compiling type-map v0.5.1 [INFO] [stderr] Checking usvg v0.42.0 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking cosmic-text v0.17.1 (https://github.com/pop-os/cosmic-text.git#d7dc22dd) [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking drm v0.11.1 [INFO] [stderr] Compiling rust-embed-impl v8.11.0 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Compiling phf_shared v0.13.1 [INFO] [stderr] Checking iced_graphics v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Compiling zbus_macros v5.13.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling basic-toml v0.1.10 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking resvg v0.42.0 [INFO] [stderr] Compiling phf_generator v0.13.1 [INFO] [stderr] Compiling i18n-config v0.4.8 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking inotify v0.11.0 [INFO] [stderr] Compiling find-crate v0.6.3 [INFO] [stderr] Compiling fluent-syntax v0.12.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Compiling intl-memoizer v0.5.3 [INFO] [stderr] Compiling fluent-langneg v0.13.1 [INFO] [stderr] Compiling intl_pluralrules v7.0.2 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking notify-types v2.1.0 [INFO] [stderr] Checking kurbo v0.10.4 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Checking xdg v3.0.0 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Compiling ouroboros_macro v0.18.5 [INFO] [stderr] Compiling i18n-embed-impl v0.8.4 [INFO] [stderr] Compiling fluent-bundle v0.16.0 [INFO] [stderr] Checking zbus v5.13.2 [INFO] [stderr] Checking iced_tiny_skia v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking notify v8.2.0 [INFO] [stderr] Checking atomicwrites v0.4.2 (https://github.com/jackpot51/rust-atomicwrites#043ab485) [INFO] [stderr] Checking ron v0.12.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Compiling phf_macros v0.13.1 [INFO] [stderr] Checking iced_runtime v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking lilt v0.8.1 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Compiling cosmic-config-derive v1.0.0 (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking memmap2 v0.8.0 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Compiling anyhow v1.0.101 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking ouroboros v0.18.5 [INFO] [stderr] Checking xkbcommon v0.7.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking iced_core v0.14.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking iced_renderer v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Compiling fluent v0.17.0 [INFO] [stderr] Compiling arc-swap v1.8.1 [INFO] [stderr] Compiling rust-embed v8.11.0 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Checking harfrust v0.3.2 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Compiling i18n-embed v0.16.0 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Compiling derive_setters v0.1.9 [INFO] [stderr] Checking iced_widget v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking iced_winit v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking iced_futures v0.14.0 [INFO] [stderr] Checking csscolorparser v0.8.2 [INFO] [stderr] Checking xdg-shell-wrapper-config v0.1.0 (https://github.com/pop-os/cosmic-panel#8eb8a1b6) [INFO] [stderr] Compiling derive_utils v0.15.0 [INFO] [stderr] Checking btoi v0.5.0 [INFO] [stderr] Checking almost v0.2.0 [INFO] [stderr] Checking grid v1.0.0 [INFO] [stderr] Compiling libcosmic v1.0.0 (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Compiling auto_enums v0.8.7 [INFO] [stderr] Checking cosmic-freedesktop-icons v0.4.0 (https://github.com/pop-os/freedesktop-icons#7a61a704) [INFO] [stderr] Checking taffy v0.9.2 [INFO] [stderr] Checking cosmic-settings-daemon v0.1.0 (https://github.com/pop-os/dbus-settings-bindings#87c3c356) [INFO] [stderr] Checking cosmic-text v0.15.0 [INFO] [stderr] Checking cosmic-config v1.0.0 (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Compiling i18n-embed-fl v0.10.0 [INFO] [stderr] Checking css-color v0.2.8 [INFO] [stderr] Checking cosmic-theme v1.0.0 (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking cosmic-panel-config v0.1.0 (https://github.com/pop-os/cosmic-panel#8eb8a1b6) [INFO] [stderr] Checking apply v0.3.0 [INFO] [stderr] Checking iced_graphics v0.14.0 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking iced_color_picker v0.14.0 [INFO] [stderr] Checking iced v0.14.0-dev (https://github.com/pop-os/libcosmic.git#3e78eb23) [INFO] [stderr] Checking huelib v0.13.2 [INFO] [stderr] Checking cosmic-ext-applet-hue v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/app.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | use huelib; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/app.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | use huelib; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `cosmic::widget::ListColumn<'_, app::Message>` [INFO] [stdout] --> src/app.rs:323:32 [INFO] [stdout] | [INFO] [stdout] 323 | content_list = widget::list_column().add( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 324 | | widget::flex_row(vec![ [INFO] [stdout] 325 | | widget::text(fl!("app-title")).align_y(Alignment::Center).height(30.0).into(), [INFO] [stdout] 326 | | widget::horizontal_space().into(), [INFO] [stdout] 327 | | widget::button::icon(widget::icon::from_name("view-more-symbolic")).on_pres... [INFO] [stdout] 328 | | ]) [INFO] [stdout] 329 | | ).into(); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 323 ~ content_list = widget::list_column().add( [INFO] [stdout] 324 + widget::flex_row(vec![ [INFO] [stdout] 325 + widget::text(fl!("app-title")).align_y(Alignment::Center).height(30.0).into(), [INFO] [stdout] 326 + widget::horizontal_space().into(), [INFO] [stdout] 327 + widget::button::icon(widget::icon::from_name("view-more-symbolic")).on_press(Message::ToggleMoreMenu).into(), [INFO] [stdout] 328 + ]) [INFO] [stdout] 329 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `cosmic::widget::ListColumn<'_, app::Message>` [INFO] [stdout] --> src/app.rs:349:28 [INFO] [stdout] | [INFO] [stdout] 349 | content_list = content_list.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `content_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `IpAddr` which implements the `Copy` trait [INFO] [stdout] --> src/app.rs:406:47 [INFO] [stdout] | [INFO] [stdout] 406 | self.last_discovery = Some(Ok(bridge_ip.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `bridge_ip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:530:17 [INFO] [stdout] | [INFO] [stdout] 530 | lights_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 530 - lights_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 530 + lights_vm.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `first_light` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:563:29 [INFO] [stdout] | [INFO] [stdout] 562 | let color = if first_light.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = first_light` [INFO] [stdout] 563 | first_light.unwrap().color [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `first_light` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:568:29 [INFO] [stdout] | [INFO] [stdout] 567 | let brightness = if first_light.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = first_light` [INFO] [stdout] 568 | first_light.unwrap().brightness [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:555:25 [INFO] [stdout] | [INFO] [stdout] 555 | / if let Some(light_id) = group.lights.first() { [INFO] [stdout] 556 | | if let Some(light) = [INFO] [stdout] 557 | | self.lights.iter().find(|light| light.id == *light_id) [INFO] [stdout] ... | [INFO] [stdout] 561 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 555 ~ if let Some(light_id) = group.lights.first() [INFO] [stdout] 556 ~ && let Some(light) = [INFO] [stdout] 557 | self.lights.iter().find(|light| light.id == *light_id) [INFO] [stdout] 558 | { [INFO] [stdout] 559 | first_light = Some(light); [INFO] [stdout] 560 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:585:17 [INFO] [stdout] | [INFO] [stdout] 585 | groups_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 585 - groups_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 585 + groups_vm.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:616:17 [INFO] [stdout] | [INFO] [stdout] 616 | scenes_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 616 - scenes_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 616 + scenes_vm.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:734:17 [INFO] [stdout] | [INFO] [stdout] 734 | / if let Some((brightness, current_counter)) = self.pending_light_brightness.get(&light_id) { [INFO] [stdout] 735 | | if *current_counter == counter { [INFO] [stdout] 736 | | // It's the last request, apply it [INFO] [stdout] 737 | | let brightness = *brightness; [INFO] [stdout] ... | [INFO] [stdout] 756 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 734 ~ if let Some((brightness, current_counter)) = self.pending_light_brightness.get(&light_id) [INFO] [stdout] 735 ~ && *current_counter == counter { [INFO] [stdout] 736 | // It's the last request, apply it [INFO] [stdout] ... [INFO] [stdout] 754 | ); [INFO] [stdout] 755 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/app.rs:745:64 [INFO] [stdout] | [INFO] [stdout] 745 | ... huelib::resource::Adjust::Override((brightness as u8).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(brightness as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:760:17 [INFO] [stdout] | [INFO] [stdout] 760 | / if let Some(group) = self.groups.iter_mut().find(|group| group.id == group_id) { [INFO] [stdout] 761 | | if group.brightness.is_some() { [INFO] [stdout] 762 | | // Find all lights in the group and set their brightness to the new brightness [INFO] [stdout] 763 | | for light_id in &group.lights { [INFO] [stdout] ... | [INFO] [stdout] 773 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 760 ~ if let Some(group) = self.groups.iter_mut().find(|group| group.id == group_id) [INFO] [stdout] 761 ~ && group.brightness.is_some() { [INFO] [stdout] 762 | // Find all lights in the group and set their brightness to the new brightness [INFO] [stdout] ... [INFO] [stdout] 771 | group.brightness = Some(new_brightness as u8); [INFO] [stdout] 772 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:791:17 [INFO] [stdout] | [INFO] [stdout] 791 | / if let Some((brightness, current_counter)) = self.pending_group_brightness.get(&group_id) { [INFO] [stdout] 792 | | if *current_counter == counter { [INFO] [stdout] 793 | | // It's the last request, apply it [INFO] [stdout] 794 | | let brightness = *brightness; [INFO] [stdout] ... | [INFO] [stdout] 813 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 791 ~ if let Some((brightness, current_counter)) = self.pending_group_brightness.get(&group_id) [INFO] [stdout] 792 ~ && *current_counter == counter { [INFO] [stdout] 793 | // It's the last request, apply it [INFO] [stdout] ... [INFO] [stdout] 811 | ); [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/app.rs:802:64 [INFO] [stdout] | [INFO] [stdout] 802 | ... huelib::resource::Adjust::Override((brightness as u8).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(brightness as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:820:21 [INFO] [stdout] | [INFO] [stdout] 820 | / match update { [INFO] [stdout] 821 | | ColorPickerUpdate::ActiveColor(color) => { [INFO] [stdout] 822 | | // Update the local state immediately for the UI [INFO] [stdout] 823 | | light.color = Some(hsv_palette_to_rgb(color)); [INFO] [stdout] ... | [INFO] [stdout] 843 | | _ => {} [INFO] [stdout] 844 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 820 ~ if let ColorPickerUpdate::ActiveColor(color) = update { [INFO] [stdout] 821 + // Update the local state immediately for the UI [INFO] [stdout] 822 + light.color = Some(hsv_palette_to_rgb(color)); [INFO] [stdout] 823 + [INFO] [stdout] 824 + // Convert the HSV values [INFO] [stdout] 825 + let (hue, saturation, brightness) = hsv_palette_to_hsv_lib(color); [INFO] [stdout] 826 + [INFO] [stdout] 827 + // Increment the counter and store the value in pending [INFO] [stdout] 828 + let light_id = light.id.clone(); [INFO] [stdout] 829 + self.debounce_counter += 1; [INFO] [stdout] 830 + let counter = self.debounce_counter; [INFO] [stdout] 831 + self.pending_light_color.insert(light_id.clone(), ((hue, saturation, brightness), counter)); [INFO] [stdout] 832 + [INFO] [stdout] 833 + // Create a task that will wait 300ms then apply the change [INFO] [stdout] 834 + return Task::perform( [INFO] [stdout] 835 + async move { [INFO] [stdout] 836 + tokio::time::sleep(tokio::time::Duration::from_millis(300)).await; [INFO] [stdout] 837 + (light_id, counter) [INFO] [stdout] 838 + }, [INFO] [stdout] 839 + |(id, cnt)| Action::App(Message::ApplyLightColor(id, cnt)), [INFO] [stdout] 840 + ); [INFO] [stdout] 841 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:849:17 [INFO] [stdout] | [INFO] [stdout] 849 | / if let Some((color_values, current_counter)) = self.pending_light_color.get(&light_id) { [INFO] [stdout] 850 | | if *current_counter == counter { [INFO] [stdout] 851 | | // It's the last request, apply it [INFO] [stdout] 852 | | let (hue, saturation, brightness) = *color_values; [INFO] [stdout] ... | [INFO] [stdout] 874 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 849 ~ if let Some((color_values, current_counter)) = self.pending_light_color.get(&light_id) [INFO] [stdout] 850 ~ && *current_counter == counter { [INFO] [stdout] 851 | // It's the last request, apply it [INFO] [stdout] ... [INFO] [stdout] 872 | ); [INFO] [stdout] 873 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:881:21 [INFO] [stdout] | [INFO] [stdout] 881 | / match update { [INFO] [stdout] 882 | | ColorPickerUpdate::ActiveColor(color) => { [INFO] [stdout] 883 | | // Update the local state immediately for the UI [INFO] [stdout] 884 | | let new_color = hsv_palette_to_rgb(color); [INFO] [stdout] ... | [INFO] [stdout] 912 | | _ => {} [INFO] [stdout] 913 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 881 ~ if let ColorPickerUpdate::ActiveColor(color) = update { [INFO] [stdout] 882 + // Update the local state immediately for the UI [INFO] [stdout] 883 + let new_color = hsv_palette_to_rgb(color); [INFO] [stdout] 884 + for light_id in &group.lights { [INFO] [stdout] 885 + if let Some(light) = [INFO] [stdout] 886 + self.lights.iter_mut().find(|light| light.id == *light_id) [INFO] [stdout] 887 + { [INFO] [stdout] 888 + light.color = Some(new_color); [INFO] [stdout] 889 + } [INFO] [stdout] 890 + } [INFO] [stdout] 891 + group.color = Some(new_color); [INFO] [stdout] 892 + [INFO] [stdout] 893 + // Convert the HSV values [INFO] [stdout] 894 + let (hue, saturation, brightness) = hsv_palette_to_hsv_lib(color); [INFO] [stdout] 895 + [INFO] [stdout] 896 + // Increment the counter and store the value in pending [INFO] [stdout] 897 + let group_id = group.id.clone(); [INFO] [stdout] 898 + self.debounce_counter += 1; [INFO] [stdout] 899 + let counter = self.debounce_counter; [INFO] [stdout] 900 + self.pending_group_color.insert(group_id.clone(), ((hue, saturation, brightness), counter)); [INFO] [stdout] 901 + [INFO] [stdout] 902 + // Create a task that will wait 300ms then apply the change [INFO] [stdout] 903 + return Task::perform( [INFO] [stdout] 904 + async move { [INFO] [stdout] 905 + tokio::time::sleep(tokio::time::Duration::from_millis(300)).await; [INFO] [stdout] 906 + (group_id, counter) [INFO] [stdout] 907 + }, [INFO] [stdout] 908 + |(id, cnt)| Action::App(Message::ApplyGroupColor(id, cnt)), [INFO] [stdout] 909 + ); [INFO] [stdout] 910 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:918:17 [INFO] [stdout] | [INFO] [stdout] 918 | / if let Some((color_values, current_counter)) = self.pending_group_color.get(&group_id) { [INFO] [stdout] 919 | | if *current_counter == counter { [INFO] [stdout] 920 | | // C'est la dernière demande, on l'applique [INFO] [stdout] 921 | | let (hue, saturation, brightness) = *color_values; [INFO] [stdout] ... | [INFO] [stdout] 943 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 918 ~ if let Some((color_values, current_counter)) = self.pending_group_color.get(&group_id) [INFO] [stdout] 919 ~ && *current_counter == counter { [INFO] [stdout] 920 | // C'est la dernière demande, on l'applique [INFO] [stdout] ... [INFO] [stdout] 941 | ); [INFO] [stdout] 942 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&0).is_none()` [INFO] [stdout] --> src/app.rs:946:49 [INFO] [stdout] | [INFO] [stdout] 946 | if self.color_button_rectangles.get(&0).is_none() { [INFO] [stdout] | -----------------------------^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.color_button_rectangles.contains_key(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `cosmic::widget::ListColumn<'_, app::Message>` [INFO] [stdout] --> src/app.rs:323:32 [INFO] [stdout] | [INFO] [stdout] 323 | content_list = widget::list_column().add( [INFO] [stdout] | ________________________________^ [INFO] [stdout] 324 | | widget::flex_row(vec![ [INFO] [stdout] 325 | | widget::text(fl!("app-title")).align_y(Alignment::Center).height(30.0).into(), [INFO] [stdout] 326 | | widget::horizontal_space().into(), [INFO] [stdout] 327 | | widget::button::icon(widget::icon::from_name("view-more-symbolic")).on_pres... [INFO] [stdout] 328 | | ]) [INFO] [stdout] 329 | | ).into(); [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 323 ~ content_list = widget::list_column().add( [INFO] [stdout] 324 + widget::flex_row(vec![ [INFO] [stdout] 325 + widget::text(fl!("app-title")).align_y(Alignment::Center).height(30.0).into(), [INFO] [stdout] 326 + widget::horizontal_space().into(), [INFO] [stdout] 327 + widget::button::icon(widget::icon::from_name("view-more-symbolic")).on_press(Message::ToggleMoreMenu).into(), [INFO] [stdout] 328 + ]) [INFO] [stdout] 329 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `cosmic::widget::ListColumn<'_, app::Message>` [INFO] [stdout] --> src/app.rs:349:28 [INFO] [stdout] | [INFO] [stdout] 349 | content_list = content_list.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `content_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `IpAddr` which implements the `Copy` trait [INFO] [stdout] --> src/app.rs:406:47 [INFO] [stdout] | [INFO] [stdout] 406 | self.last_discovery = Some(Ok(bridge_ip.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `bridge_ip` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:530:17 [INFO] [stdout] | [INFO] [stdout] 530 | lights_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 530 - lights_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 530 + lights_vm.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `first_light` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:563:29 [INFO] [stdout] | [INFO] [stdout] 562 | let color = if first_light.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = first_light` [INFO] [stdout] 563 | first_light.unwrap().color [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `first_light` after checking its variant with `is_some` [INFO] [stdout] --> src/app.rs:568:29 [INFO] [stdout] | [INFO] [stdout] 567 | let brightness = if first_light.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = first_light` [INFO] [stdout] 568 | first_light.unwrap().brightness [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:555:25 [INFO] [stdout] | [INFO] [stdout] 555 | / if let Some(light_id) = group.lights.first() { [INFO] [stdout] 556 | | if let Some(light) = [INFO] [stdout] 557 | | self.lights.iter().find(|light| light.id == *light_id) [INFO] [stdout] ... | [INFO] [stdout] 561 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 555 ~ if let Some(light_id) = group.lights.first() [INFO] [stdout] 556 ~ && let Some(light) = [INFO] [stdout] 557 | self.lights.iter().find(|light| light.id == *light_id) [INFO] [stdout] 558 | { [INFO] [stdout] 559 | first_light = Some(light); [INFO] [stdout] 560 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:585:17 [INFO] [stdout] | [INFO] [stdout] 585 | groups_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 585 - groups_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 585 + groups_vm.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:616:17 [INFO] [stdout] | [INFO] [stdout] 616 | scenes_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 616 - scenes_vm.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 616 + scenes_vm.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:734:17 [INFO] [stdout] | [INFO] [stdout] 734 | / if let Some((brightness, current_counter)) = self.pending_light_brightness.get(&light_id) { [INFO] [stdout] 735 | | if *current_counter == counter { [INFO] [stdout] 736 | | // It's the last request, apply it [INFO] [stdout] 737 | | let brightness = *brightness; [INFO] [stdout] ... | [INFO] [stdout] 756 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 734 ~ if let Some((brightness, current_counter)) = self.pending_light_brightness.get(&light_id) [INFO] [stdout] 735 ~ && *current_counter == counter { [INFO] [stdout] 736 | // It's the last request, apply it [INFO] [stdout] ... [INFO] [stdout] 754 | ); [INFO] [stdout] 755 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/app.rs:745:64 [INFO] [stdout] | [INFO] [stdout] 745 | ... huelib::resource::Adjust::Override((brightness as u8).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(brightness as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:760:17 [INFO] [stdout] | [INFO] [stdout] 760 | / if let Some(group) = self.groups.iter_mut().find(|group| group.id == group_id) { [INFO] [stdout] 761 | | if group.brightness.is_some() { [INFO] [stdout] 762 | | // Find all lights in the group and set their brightness to the new brightness [INFO] [stdout] 763 | | for light_id in &group.lights { [INFO] [stdout] ... | [INFO] [stdout] 773 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 760 ~ if let Some(group) = self.groups.iter_mut().find(|group| group.id == group_id) [INFO] [stdout] 761 ~ && group.brightness.is_some() { [INFO] [stdout] 762 | // Find all lights in the group and set their brightness to the new brightness [INFO] [stdout] ... [INFO] [stdout] 771 | group.brightness = Some(new_brightness as u8); [INFO] [stdout] 772 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:791:17 [INFO] [stdout] | [INFO] [stdout] 791 | / if let Some((brightness, current_counter)) = self.pending_group_brightness.get(&group_id) { [INFO] [stdout] 792 | | if *current_counter == counter { [INFO] [stdout] 793 | | // It's the last request, apply it [INFO] [stdout] 794 | | let brightness = *brightness; [INFO] [stdout] ... | [INFO] [stdout] 813 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 791 ~ if let Some((brightness, current_counter)) = self.pending_group_brightness.get(&group_id) [INFO] [stdout] 792 ~ && *current_counter == counter { [INFO] [stdout] 793 | // It's the last request, apply it [INFO] [stdout] ... [INFO] [stdout] 811 | ); [INFO] [stdout] 812 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/app.rs:802:64 [INFO] [stdout] | [INFO] [stdout] 802 | ... huelib::resource::Adjust::Override((brightness as u8).into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(brightness as u8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:820:21 [INFO] [stdout] | [INFO] [stdout] 820 | / match update { [INFO] [stdout] 821 | | ColorPickerUpdate::ActiveColor(color) => { [INFO] [stdout] 822 | | // Update the local state immediately for the UI [INFO] [stdout] 823 | | light.color = Some(hsv_palette_to_rgb(color)); [INFO] [stdout] ... | [INFO] [stdout] 843 | | _ => {} [INFO] [stdout] 844 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 820 ~ if let ColorPickerUpdate::ActiveColor(color) = update { [INFO] [stdout] 821 + // Update the local state immediately for the UI [INFO] [stdout] 822 + light.color = Some(hsv_palette_to_rgb(color)); [INFO] [stdout] 823 + [INFO] [stdout] 824 + // Convert the HSV values [INFO] [stdout] 825 + let (hue, saturation, brightness) = hsv_palette_to_hsv_lib(color); [INFO] [stdout] 826 + [INFO] [stdout] 827 + // Increment the counter and store the value in pending [INFO] [stdout] 828 + let light_id = light.id.clone(); [INFO] [stdout] 829 + self.debounce_counter += 1; [INFO] [stdout] 830 + let counter = self.debounce_counter; [INFO] [stdout] 831 + self.pending_light_color.insert(light_id.clone(), ((hue, saturation, brightness), counter)); [INFO] [stdout] 832 + [INFO] [stdout] 833 + // Create a task that will wait 300ms then apply the change [INFO] [stdout] 834 + return Task::perform( [INFO] [stdout] 835 + async move { [INFO] [stdout] 836 + tokio::time::sleep(tokio::time::Duration::from_millis(300)).await; [INFO] [stdout] 837 + (light_id, counter) [INFO] [stdout] 838 + }, [INFO] [stdout] 839 + |(id, cnt)| Action::App(Message::ApplyLightColor(id, cnt)), [INFO] [stdout] 840 + ); [INFO] [stdout] 841 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:849:17 [INFO] [stdout] | [INFO] [stdout] 849 | / if let Some((color_values, current_counter)) = self.pending_light_color.get(&light_id) { [INFO] [stdout] 850 | | if *current_counter == counter { [INFO] [stdout] 851 | | // It's the last request, apply it [INFO] [stdout] 852 | | let (hue, saturation, brightness) = *color_values; [INFO] [stdout] ... | [INFO] [stdout] 874 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 849 ~ if let Some((color_values, current_counter)) = self.pending_light_color.get(&light_id) [INFO] [stdout] 850 ~ && *current_counter == counter { [INFO] [stdout] 851 | // It's the last request, apply it [INFO] [stdout] ... [INFO] [stdout] 872 | ); [INFO] [stdout] 873 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:881:21 [INFO] [stdout] | [INFO] [stdout] 881 | / match update { [INFO] [stdout] 882 | | ColorPickerUpdate::ActiveColor(color) => { [INFO] [stdout] 883 | | // Update the local state immediately for the UI [INFO] [stdout] 884 | | let new_color = hsv_palette_to_rgb(color); [INFO] [stdout] ... | [INFO] [stdout] 912 | | _ => {} [INFO] [stdout] 913 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 881 ~ if let ColorPickerUpdate::ActiveColor(color) = update { [INFO] [stdout] 882 + // Update the local state immediately for the UI [INFO] [stdout] 883 + let new_color = hsv_palette_to_rgb(color); [INFO] [stdout] 884 + for light_id in &group.lights { [INFO] [stdout] 885 + if let Some(light) = [INFO] [stdout] 886 + self.lights.iter_mut().find(|light| light.id == *light_id) [INFO] [stdout] 887 + { [INFO] [stdout] 888 + light.color = Some(new_color); [INFO] [stdout] 889 + } [INFO] [stdout] 890 + } [INFO] [stdout] 891 + group.color = Some(new_color); [INFO] [stdout] 892 + [INFO] [stdout] 893 + // Convert the HSV values [INFO] [stdout] 894 + let (hue, saturation, brightness) = hsv_palette_to_hsv_lib(color); [INFO] [stdout] 895 + [INFO] [stdout] 896 + // Increment the counter and store the value in pending [INFO] [stdout] 897 + let group_id = group.id.clone(); [INFO] [stdout] 898 + self.debounce_counter += 1; [INFO] [stdout] 899 + let counter = self.debounce_counter; [INFO] [stdout] 900 + self.pending_group_color.insert(group_id.clone(), ((hue, saturation, brightness), counter)); [INFO] [stdout] 901 + [INFO] [stdout] 902 + // Create a task that will wait 300ms then apply the change [INFO] [stdout] 903 + return Task::perform( [INFO] [stdout] 904 + async move { [INFO] [stdout] 905 + tokio::time::sleep(tokio::time::Duration::from_millis(300)).await; [INFO] [stdout] 906 + (group_id, counter) [INFO] [stdout] 907 + }, [INFO] [stdout] 908 + |(id, cnt)| Action::App(Message::ApplyGroupColor(id, cnt)), [INFO] [stdout] 909 + ); [INFO] [stdout] 910 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:918:17 [INFO] [stdout] | [INFO] [stdout] 918 | / if let Some((color_values, current_counter)) = self.pending_group_color.get(&group_id) { [INFO] [stdout] 919 | | if *current_counter == counter { [INFO] [stdout] 920 | | // C'est la dernière demande, on l'applique [INFO] [stdout] 921 | | let (hue, saturation, brightness) = *color_values; [INFO] [stdout] ... | [INFO] [stdout] 943 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 918 ~ if let Some((color_values, current_counter)) = self.pending_group_color.get(&group_id) [INFO] [stdout] 919 ~ && *current_counter == counter { [INFO] [stdout] 920 | // C'est la dernière demande, on l'applique [INFO] [stdout] ... [INFO] [stdout] 941 | ); [INFO] [stdout] 942 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&0).is_none()` [INFO] [stdout] --> src/app.rs:946:49 [INFO] [stdout] | [INFO] [stdout] 946 | if self.color_button_rectangles.get(&0).is_none() { [INFO] [stdout] | -----------------------------^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.color_button_rectangles.contains_key(&0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 22s [INFO] running `Command { std: "docker" "inspect" "7bb2416721e1be049142a8fdd30d54b9e804752f8270b0c873e8f1e8acc2fbbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bb2416721e1be049142a8fdd30d54b9e804752f8270b0c873e8f1e8acc2fbbc", kill_on_drop: false }` [INFO] [stdout] 7bb2416721e1be049142a8fdd30d54b9e804752f8270b0c873e8f1e8acc2fbbc