[INFO] cloning repository https://github.com/clemsys/INF568-poly1305 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/clemsys/INF568-poly1305" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclemsys%2FINF568-poly1305", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclemsys%2FINF568-poly1305'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d3ec8e99da9e8ef32fcaf79c1c5addf4256cfef5 [INFO] linting clemsys/INF568-poly1305 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fclemsys%2FINF568-poly1305" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/clemsys/INF568-poly1305 [INFO] finished tweaking git repo https://github.com/clemsys/INF568-poly1305 [INFO] tweaked toml for git repo https://github.com/clemsys/INF568-poly1305 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/clemsys/INF568-poly1305 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/clemsys/INF568-poly1305 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded assert_cmd v2.0.13 [INFO] [stderr] Downloaded clap v4.4.18 [INFO] [stderr] Downloaded anstream v0.6.11 [INFO] [stderr] Downloaded clap_builder v4.4.18 [INFO] [stderr] Downloaded rug v1.23.0 [INFO] [stderr] Downloaded bstr v1.9.0 [INFO] [stderr] Downloaded gmp-mpfr-sys v1.6.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 676cad2f87fcdff078252ddb0e3f97e1bfb2f0a8cd6a73d28864a928c3b024fe [INFO] running `Command { std: "docker" "start" "-a" "676cad2f87fcdff078252ddb0e3f97e1bfb2f0a8cd6a73d28864a928c3b024fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "676cad2f87fcdff078252ddb0e3f97e1bfb2f0a8cd6a73d28864a928c3b024fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "676cad2f87fcdff078252ddb0e3f97e1bfb2f0a8cd6a73d28864a928c3b024fe", kill_on_drop: false }` [INFO] [stdout] 676cad2f87fcdff078252ddb0e3f97e1bfb2f0a8cd6a73d28864a928c3b024fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b220c3aa0e9908ef48863874be81e7c1de2444cbc46eb924f1370c71b648322 [INFO] running `Command { std: "docker" "start" "-a" "2b220c3aa0e9908ef48863874be81e7c1de2444cbc46eb924f1370c71b648322", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling gmp-mpfr-sys v1.6.1 [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Compiling rug v1.23.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking assert_cmd v2.0.13 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking chacha20_poly1305_aead v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib/poly1305.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | assert!(s.len() % 2 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `s.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/lib/poly1305.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | assert!(s.len() % 2 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `s.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/aead_unwrap.rs:12:33 [INFO] [stdout] | [INFO] [stdout] 12 | std::fs::read_to_string(&format!("{AEAD_SAMPLES_DIR}/sunscreen.txt")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{AEAD_SAMPLES_DIR}/sunscreen.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> tests/poly1305_gen.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | &format!("{}", filename), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `filename.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/poly1305_gen.rs:64:43 [INFO] [stdout] | [INFO] [stdout] 64 | let binding = std::fs::read_to_string(&format!("{SAMPLES_DIR}/urandom_keys")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/urandom_keys")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> tests/poly1305_check.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | &format!("{}", filename), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `filename.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/poly1305_check.rs:80:43 [INFO] [stdout] | [INFO] [stdout] 80 | let binding = std::fs::read_to_string(&format!("{SAMPLES_DIR}/urandom_keys")).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/urandom_keys")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/aead_wrap.rs:21:32 [INFO] [stdout] | [INFO] [stdout] 21 | let result = std::fs::read(&format!("{AEAD_SAMPLES_DIR}/my_ciphertext.bin"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{AEAD_SAMPLES_DIR}/my_ciphertext.bin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/aead_wrap.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | std::fs::remove_file(&format!("{AEAD_SAMPLES_DIR}/my_ciphertext.bin"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{AEAD_SAMPLES_DIR}/my_ciphertext.bin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/aead_wrap.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | let expected = std::fs::read(&format!("{AEAD_SAMPLES_DIR}/ciphertext.bin"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{AEAD_SAMPLES_DIR}/ciphertext.bin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/chacha20.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 19 | let result = std::fs::read(&format!("{SAMPLES_DIR}/my_ciphertext.bin"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/my_ciphertext.bin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/chacha20.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | std::fs::remove_file(&format!("{SAMPLES_DIR}/my_ciphertext.bin"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/my_ciphertext.bin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/chacha20.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | let expected = std::fs::read(&format!("{SAMPLES_DIR}/ciphertext.bin"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/ciphertext.bin")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/chacha20.rs:38:32 [INFO] [stdout] | [INFO] [stdout] 38 | let result = std::fs::read(&format!("{SAMPLES_DIR}/my_sunscreen.txt"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/my_sunscreen.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/chacha20.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | std::fs::remove_file(&format!("{SAMPLES_DIR}/my_sunscreen.txt"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/my_sunscreen.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/chacha20.rs:40:34 [INFO] [stdout] | [INFO] [stdout] 40 | let expected = std::fs::read(&format!("{SAMPLES_DIR}/sunscreen.txt"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{SAMPLES_DIR}/sunscreen.txt")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 57s [INFO] running `Command { std: "docker" "inspect" "2b220c3aa0e9908ef48863874be81e7c1de2444cbc46eb924f1370c71b648322", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b220c3aa0e9908ef48863874be81e7c1de2444cbc46eb924f1370c71b648322", kill_on_drop: false }` [INFO] [stdout] 2b220c3aa0e9908ef48863874be81e7c1de2444cbc46eb924f1370c71b648322