[INFO] cloning repository https://github.com/cjglo/todo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cjglo/todo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjglo%2Ftodo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjglo%2Ftodo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 77529943885f25713167d1d1a81e3f046d4bc939 [INFO] linting cjglo/todo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjglo%2Ftodo" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cjglo/todo [INFO] finished tweaking git repo https://github.com/cjglo/todo [INFO] tweaked toml for git repo https://github.com/cjglo/todo written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cjglo/todo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cjglo/todo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded phf_shared v0.11.2 [INFO] [stderr] Downloaded phf_generator v0.11.2 [INFO] [stderr] Downloaded bitflags v2.4.2 [INFO] [stderr] Downloaded phf_macros v0.11.2 [INFO] [stderr] Downloaded phf v0.11.2 [INFO] [stderr] Downloaded term_size v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3951ce49484f9f276780802a8998d3a3ba3a63384aad094aed7831db44bfd63 [INFO] running `Command { std: "docker" "start" "-a" "d3951ce49484f9f276780802a8998d3a3ba3a63384aad094aed7831db44bfd63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3951ce49484f9f276780802a8998d3a3ba3a63384aad094aed7831db44bfd63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3951ce49484f9f276780802a8998d3a3ba3a63384aad094aed7831db44bfd63", kill_on_drop: false }` [INFO] [stdout] d3951ce49484f9f276780802a8998d3a3ba3a63384aad094aed7831db44bfd63 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1daa3ebec8d388d1424dad13974b1f29a01dadb748a245bf046125aa651425c [INFO] running `Command { std: "docker" "start" "-a" "c1daa3ebec8d388d1424dad13974b1f29a01dadb748a245bf046125aa651425c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.51 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking todo-helper v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/text_util.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | const TODO_DIRECTORY: &'static str = "/todo-program-info"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/text_util.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | const TODO_FILE_NAME: &'static str = "/todo_data.ron"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/text_util.rs:28:84 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn get_or_create_directory_file_path(current_path: PathBuf) -> std::io::Result<(String)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub fn get_or_create_directory_file_path(current_path: PathBuf) -> std::io::Result<(String)> { [INFO] [stdout] 28 + pub fn get_or_create_directory_file_path(current_path: PathBuf) -> std::io::Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::write` [INFO] [stdout] --> src/todo_item.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::write; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `colored::*` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use colored::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead`, `Read`, and `Write` [INFO] [stdout] --> src/main.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io::{BufRead, Read, Write}; [INFO] [stdout] | ^^^^^^^ ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use term_size; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `term_size` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use term_size; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/text_util.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | const TODO_DIRECTORY: &'static str = "/todo-program-info"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/text_util.rs:7:24 [INFO] [stdout] | [INFO] [stdout] 7 | const TODO_FILE_NAME: &'static str = "/todo_data.ron"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/text_util.rs:28:84 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn get_or_create_directory_file_path(current_path: PathBuf) -> std::io::Result<(String)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - pub fn get_or_create_directory_file_path(current_path: PathBuf) -> std::io::Result<(String)> { [INFO] [stdout] 28 + pub fn get_or_create_directory_file_path(current_path: PathBuf) -> std::io::Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::write` [INFO] [stdout] --> src/todo_item.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fmt::write; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `colored::*` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use colored::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead`, `Read`, and `Write` [INFO] [stdout] --> src/main.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | use std::io::{BufRead, Read, Write}; [INFO] [stdout] | ^^^^^^^ ^^^^ ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use term_size; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `term_size` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use term_size; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/text_util.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut iterations = 0; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/text_util.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let mut iterations = 0; [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `header` [INFO] [stdout] --> src/todo_handler.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | let header = i.to_string(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_header` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `header` [INFO] [stdout] --> src/todo_handler.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | let header = i.to_string(); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_header` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `result` is never read [INFO] [stdout] --> src/todo_item.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | let mut result = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/text_util.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn handle_text_wrap<'a>(line: &'a str, line_length: u16) -> Vec<&'a str> { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 9 - pub fn handle_text_wrap<'a>(line: &'a str, line_length: u16) -> Vec<&'a str> { [INFO] [stdout] 9 + pub fn handle_text_wrap(line: &str, line_length: u16) -> Vec<&str> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/text_util.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !fs::metadata(&file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/text_util.rs:38:38 [INFO] [stdout] | [INFO] [stdout] 38 | fs::write(file_path.clone(), "[]".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"[]"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args_handler.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(args_count: usize, args: &Vec) -> ArgsHandler { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - pub fn new(args_count: usize, args: &Vec) -> ArgsHandler { [INFO] [stdout] 20 + pub fn new(args_count: usize, args: &[String]) -> ArgsHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a `Vec` [INFO] [stdout] --> src/args_handler.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] = note: `#[warn(clippy::iter_nth)]` on by default [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 28 - if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] 28 + if args.get(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `result` is never read [INFO] [stdout] --> src/todo_item.rs:53:26 [INFO] [stdout] | [INFO] [stdout] 53 | let mut result = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a `Vec` [INFO] [stdout] --> src/args_handler.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 36 - if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] 36 + if args.get(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a `Vec` [INFO] [stdout] --> src/args_handler.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 44 - if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] 44 + if args.get(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.delete_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:44:37 [INFO] [stdout] | [INFO] [stdout] 43 | if args_handler.delete_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.delete_flag_and_index` [INFO] [stdout] 44 | let index: usize = args[args_handler.delete_flag_and_index.unwrap() + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.change_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 67 | } else if args_handler.change_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.change_flag_and_index` [INFO] [stdout] 68 | let to_edit = &mut todos[args[args_handler.change_flag_and_index.unwrap() + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.change_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:72:38 [INFO] [stdout] | [INFO] [stdout] 67 | } else if args_handler.change_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.change_flag_and_index` [INFO] [stdout] ... [INFO] [stdout] 72 | let first_arg = args.get(args_handler.change_flag_and_index.unwrap() + 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.change_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 67 | } else if args_handler.change_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.change_flag_and_index` [INFO] [stdout] ... [INFO] [stdout] 73 | let second_arg = args.get(args_handler.change_flag_and_index.unwrap() + 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/text_util.rs:9:25 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn handle_text_wrap<'a>(line: &'a str, line_length: u16) -> Vec<&'a str> { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 9 - pub fn handle_text_wrap<'a>(line: &'a str, line_length: u16) -> Vec<&'a str> { [INFO] [stdout] 9 + pub fn handle_text_wrap(line: &str, line_length: u16) -> Vec<&str> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/todo_handler.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 22 | args: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - args: &Vec, [INFO] [stdout] 22 + args: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/text_util.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !fs::metadata(&file_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&file_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/todo_handler.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if todos.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `todos.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/text_util.rs:38:38 [INFO] [stdout] | [INFO] [stdout] 38 | fs::write(file_path.clone(), "[]".to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"[]"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/todo_handler.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | if due_date.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!due_date.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/todo_handler.rs:84:36 [INFO] [stdout] | [INFO] [stdout] 84 | to_edit.due_date = if let Some(due_date) = first_arg { Some(due_date.clone().to_uppercase()) } else { None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `first_arg.map(|due_date| due_date.clone().to_uppercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args_handler.rs:20:41 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new(args_count: usize, args: &Vec) -> ArgsHandler { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 20 - pub fn new(args_count: usize, args: &Vec) -> ArgsHandler { [INFO] [stdout] 20 + pub fn new(args_count: usize, args: &[String]) -> ArgsHandler { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a `Vec` [INFO] [stdout] --> src/args_handler.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] = note: `#[warn(clippy::iter_nth)]` on by default [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 28 - if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] 28 + if args.get(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a `Vec` [INFO] [stdout] --> src/args_handler.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 36 - if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] 36 + if args.get(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.iter().nth()` on a `Vec` [INFO] [stdout] --> src/args_handler.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stdout] help: `get` is equivalent but more concise [INFO] [stdout] | [INFO] [stdout] 44 - if args.iter().nth(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] 44 + if args.get(index + 1).unwrap().parse::().is_err() { // if the argument after flag is not a number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.delete_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:44:37 [INFO] [stdout] | [INFO] [stdout] 43 | if args_handler.delete_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.delete_flag_and_index` [INFO] [stdout] 44 | let index: usize = args[args_handler.delete_flag_and_index.unwrap() + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.change_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 67 | } else if args_handler.change_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.change_flag_and_index` [INFO] [stdout] 68 | let to_edit = &mut todos[args[args_handler.change_flag_and_index.unwrap() + 1] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.change_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:72:38 [INFO] [stdout] | [INFO] [stdout] 67 | } else if args_handler.change_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.change_flag_and_index` [INFO] [stdout] ... [INFO] [stdout] 72 | let first_arg = args.get(args_handler.change_flag_and_index.unwrap() + 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args_handler.change_flag_and_index` after checking its variant with `is_some` [INFO] [stdout] --> src/todo_handler.rs:73:39 [INFO] [stdout] | [INFO] [stdout] 67 | } else if args_handler.change_flag_and_index.is_some() { [INFO] [stdout] | ----------------------------------------------- help: try: `if let Some() = args_handler.change_flag_and_index` [INFO] [stdout] ... [INFO] [stdout] 73 | let second_arg = args.get(args_handler.change_flag_and_index.unwrap() + 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/todo_handler.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 22 | args: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - args: &Vec, [INFO] [stdout] 22 + args: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/todo_handler.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 47 | if todos.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `todos.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/todo_handler.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | if due_date.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!due_date.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/todo_handler.rs:84:36 [INFO] [stdout] | [INFO] [stdout] 84 | to_edit.due_date = if let Some(due_date) = first_arg { Some(due_date.clone().to_uppercase()) } else { None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `first_arg.map(|due_date| due_date.clone().to_uppercase())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/todo_item.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | write!(f, "{}", '\n')?; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stdout] = note: `#[warn(clippy::write_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - write!(f, "{}", '\n')?; [INFO] [stdout] 74 + write!(f, "\n")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/todo_item.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | write!(f, "{}", format!("{0: <50}\n", color_lambda(each)))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/todo_item.rs:74:25 [INFO] [stdout] | [INFO] [stdout] 74 | write!(f, "{}", '\n')?; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stdout] = note: `#[warn(clippy::write_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - write!(f, "{}", '\n')?; [INFO] [stdout] 74 + write!(f, "\n")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `write!` args [INFO] [stdout] --> src/todo_item.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | write!(f, "{}", format!("{0: <50}\n", color_lambda(each)))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `write!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.74s [INFO] running `Command { std: "docker" "inspect" "c1daa3ebec8d388d1424dad13974b1f29a01dadb748a245bf046125aa651425c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1daa3ebec8d388d1424dad13974b1f29a01dadb748a245bf046125aa651425c", kill_on_drop: false }` [INFO] [stdout] c1daa3ebec8d388d1424dad13974b1f29a01dadb748a245bf046125aa651425c