[INFO] cloning repository https://github.com/cjdelisle/pkt-checksig
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cjdelisle/pkt-checksig" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjdelisle%2Fpkt-checksig", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjdelisle%2Fpkt-checksig'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f64a26af020bd4add589e22217c56aa7f84ca62c
[INFO] linting cjdelisle/pkt-checksig against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcjdelisle%2Fpkt-checksig" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/cjdelisle/pkt-checksig
[INFO] finished tweaking git repo https://github.com/cjdelisle/pkt-checksig
[INFO] tweaked toml for git repo https://github.com/cjdelisle/pkt-checksig written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/cjdelisle/pkt-checksig on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/cjdelisle/pkt-checksig already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
[INFO] [stderr]   |
[INFO] [stderr]   = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
[INFO] [stderr]   = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
[INFO] [stderr]   = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded base64-compat v1.0.0
[INFO] [stderr]   Downloaded secp256k1-sys v0.4.0
[INFO] [stderr]   Downloaded bitcoin v0.26.0
[INFO] [stderr]   Downloaded secp256k1 v0.20.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 946b63b3751eb744a2f2ced555b0164bac35431501d6ada97840b2460aa7f3ce
[INFO] running `Command { std: "docker" "start" "-a" "946b63b3751eb744a2f2ced555b0164bac35431501d6ada97840b2460aa7f3ce", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "946b63b3751eb744a2f2ced555b0164bac35431501d6ada97840b2460aa7f3ce", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "946b63b3751eb744a2f2ced555b0164bac35431501d6ada97840b2460aa7f3ce", kill_on_drop: false }`
[INFO] [stdout] 946b63b3751eb744a2f2ced555b0164bac35431501d6ada97840b2460aa7f3ce
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c7f968e1b3d0a1c9049fa3d10ec0c70040d03c553025d1e445ded276ea6e3df0
[INFO] running `Command { std: "docker" "start" "-a" "c7f968e1b3d0a1c9049fa3d10ec0c70040d03c553025d1e445ded276ea6e3df0", kill_on_drop: false }`
[INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
[INFO] [stderr]   |
[INFO] [stderr]   = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
[INFO] [stderr]   = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
[INFO] [stderr]   = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
[INFO] [stderr]    Compiling secp256k1-sys v0.4.0
[INFO] [stderr]    Compiling anyhow v1.0.40
[INFO] [stderr]     Checking bech32 v0.7.3
[INFO] [stderr]     Checking bitcoin_hashes v0.9.4
[INFO] [stderr]     Checking base64-compat v1.0.0
[INFO] [stderr]     Checking secp256k1 v0.20.1
[INFO] [stderr]     Checking bitcoin v0.26.0
[INFO] [stderr]     Checking libchecksig v0.1.0 (/opt/rustwide/workdir/libchecksig)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> libchecksig/src/lib.rs:78:17
[INFO] [stdout]    |
[INFO] [stdout] 78 |           assert!(!super::verify_msg(
[INFO] [stdout]    |  _________________^
[INFO] [stdout] 79 | |             "pGKemQBhkQY4yce9tPnAiq4c27m1k38s2i",
[INFO] [stdout] 80 | |             &sig,
[INFO] [stdout] 81 | |             "hello world",
[INFO] [stdout] 82 | |         ).is_ok());
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 78 ~         assert!(super::verify_msg(
[INFO] [stdout] 79 +             "pGKemQBhkQY4yce9tPnAiq4c27m1k38s2i",
[INFO] [stdout] 80 +             &sig,
[INFO] [stdout] 81 +             "hello world",
[INFO] [stdout] 82 ~         ).is_err());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> libchecksig/src/lib.rs:92:17
[INFO] [stdout]    |
[INFO] [stdout] 92 |           assert!(!super::verify_msg(
[INFO] [stdout]    |  _________________^
[INFO] [stdout] 93 | |             "pDWYi9XtZHiUgoVGMqykEHwvhytYv5Ejam",
[INFO] [stdout] 94 | |             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWardkFaq4tw=",
[INFO] [stdout] 95 | |             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb2_",
[INFO] [stdout] 96 | |         ).is_ok());
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 92 ~         assert!(super::verify_msg(
[INFO] [stdout] 93 +             "pDWYi9XtZHiUgoVGMqykEHwvhytYv5Ejam",
[INFO] [stdout] 94 +             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWardkFaq4tw=",
[INFO] [stdout] 95 +             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb2_",
[INFO] [stdout] 96 ~         ).is_err());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> libchecksig/src/lib.rs:98:17
[INFO] [stdout]     |
[INFO] [stdout]  98 |           assert!(!super::verify_msg(
[INFO] [stdout]     |  _________________^
[INFO] [stdout]  99 | |             "pDWYi9XtZHiUgoVGMqykEHwvhytYv5Ejam", //                                      v-- here 
[INFO] [stdout] 100 | |             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWbrdkFaq4tw=",
[INFO] [stdout] 101 | |             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb27",
[INFO] [stdout] 102 | |         ).is_ok());
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout]  98 ~         assert!(super::verify_msg(
[INFO] [stdout]  99 +             "pDWYi9XtZHiUgoVGMqykEHwvhytYv5Ejam", //                                      v-- here 
[INFO] [stdout] 100 +             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWbrdkFaq4tw=",
[INFO] [stdout] 101 +             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb27",
[INFO] [stdout] 102 ~         ).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> libchecksig/src/lib.rs:104:17
[INFO] [stdout]     |
[INFO] [stdout] 104 |           assert!(!super::verify_msg(
[INFO] [stdout]     |  _________________^
[INFO] [stdout] 105 | |             "pDWYi9XtZHiUgoVGMqykEHwvhytYv5Ejan", // bad addr
[INFO] [stdout] 106 | |             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWardkFaq4tw=",
[INFO] [stdout] 107 | |             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb27",
[INFO] [stdout] 108 | |         ).is_ok());
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 104 ~         assert!(super::verify_msg(
[INFO] [stdout] 105 +             "pDWYi9XtZHiUgoVGMqykEHwvhytYv5Ejan", // bad addr
[INFO] [stdout] 106 +             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWardkFaq4tw=",
[INFO] [stdout] 107 +             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb27",
[INFO] [stdout] 108 ~         ).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> libchecksig/src/lib.rs:110:17
[INFO] [stdout]     |
[INFO] [stdout] 110 |           assert!(!super::verify_msg(
[INFO] [stdout]     |  _________________^
[INFO] [stdout] 111 | |             "p65SN5gLGwFeW7QnZUwhn2h344Dwm9km4N", // valid wrong addr
[INFO] [stdout] 112 | |             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWardkFaq4tw=",
[INFO] [stdout] 113 | |             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb27",
[INFO] [stdout] 114 | |         ).is_ok());
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 110 ~         assert!(super::verify_msg(
[INFO] [stdout] 111 +             "p65SN5gLGwFeW7QnZUwhn2h344Dwm9km4N", // valid wrong addr
[INFO] [stdout] 112 +             "IFlf6v1rDHzjpJqoNSgW8ilJLeAz6ARJ+euecWrZqy43eM6J6JLnEZ4zL586DVEZfkYNJLTT6xovWardkFaq4tw=",
[INFO] [stdout] 113 +             "f5ef339a9b43c74900f854d9d28528e05438eb3a7ada3c66cacccb1a60c0cb27",
[INFO] [stdout] 114 ~         ).is_err());
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Checking checksig v0.1.0 (/opt/rustwide/workdir/checksig)
[INFO] [stderr]     Checking signmsg v0.1.0 (/opt/rustwide/workdir/signmsg)
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.24s
[INFO] running `Command { std: "docker" "inspect" "c7f968e1b3d0a1c9049fa3d10ec0c70040d03c553025d1e445ded276ea6e3df0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c7f968e1b3d0a1c9049fa3d10ec0c70040d03c553025d1e445ded276ea6e3df0", kill_on_drop: false }`
[INFO] [stdout] c7f968e1b3d0a1c9049fa3d10ec0c70040d03c553025d1e445ded276ea6e3df0