[INFO] cloning repository https://github.com/cisko3000/fair-share-meters [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cisko3000/fair-share-meters" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcisko3000%2Ffair-share-meters", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcisko3000%2Ffair-share-meters'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ef9c103e3ccd3fc6c930f32a2f534884f202b95c [INFO] linting cisko3000/fair-share-meters against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcisko3000%2Ffair-share-meters" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cisko3000/fair-share-meters [INFO] finished tweaking git repo https://github.com/cisko3000/fair-share-meters [INFO] tweaked toml for git repo https://github.com/cisko3000/fair-share-meters written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cisko3000/fair-share-meters on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cisko3000/fair-share-meters already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51b3138a47b490b67e0531b0b00525a180eb8ba792db3eb0ea7f073a41db747f [INFO] running `Command { std: "docker" "start" "-a" "51b3138a47b490b67e0531b0b00525a180eb8ba792db3eb0ea7f073a41db747f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51b3138a47b490b67e0531b0b00525a180eb8ba792db3eb0ea7f073a41db747f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51b3138a47b490b67e0531b0b00525a180eb8ba792db3eb0ea7f073a41db747f", kill_on_drop: false }` [INFO] [stdout] 51b3138a47b490b67e0531b0b00525a180eb8ba792db3eb0ea7f073a41db747f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ccac56c2e221e964f869f18a7d13ef48cad5b25923d2b700c3e78e3c643aa311 [INFO] running `Command { std: "docker" "start" "-a" "ccac56c2e221e964f869f18a7d13ef48cad5b25923d2b700c3e78e3c643aa311", kill_on_drop: false }` [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking meters v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/meter.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | clients: clients, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `clients` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::{io, thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Widget` [INFO] [stdout] --> src/main.rs:9:59 [INFO] [stdout] | [INFO] [stdout] 9 | use tui::{backend::{CrosstermBackend, Backend}, widgets::{Widget, Block, Borders, Gauge}, layout::{Layout, Constraint, Direction}, Fr... [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Update` [INFO] [stdout] --> src/main.rs:24:45 [INFO] [stdout] | [INFO] [stdout] 24 | use crate::meter::{Account, Client, Reader, Update}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:115:19 [INFO] [stdout] | [INFO] [stdout] 115 | match (app.account.master_meter.clients[1].meter.history.len() > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - match (app.account.master_meter.clients[1].meter.history.len() > 0) { [INFO] [stdout] 115 + match app.account.master_meter.clients[1].meter.history.len() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/meter.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | clients: clients, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `clients` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::{io, thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Widget` [INFO] [stdout] --> src/main.rs:9:59 [INFO] [stdout] | [INFO] [stdout] 9 | use tui::{backend::{CrosstermBackend, Backend}, widgets::{Widget, Block, Borders, Gauge}, layout::{Layout, Constraint, Direction}, Fr... [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Update` [INFO] [stdout] --> src/main.rs:24:45 [INFO] [stdout] | [INFO] [stdout] 24 | use crate::meter::{Account, Client, Reader, Update}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/main.rs:115:19 [INFO] [stdout] | [INFO] [stdout] 115 | match (app.account.master_meter.clients[1].meter.history.len() > 0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 115 - match (app.account.master_meter.clients[1].meter.history.len() > 0) { [INFO] [stdout] 115 + match app.account.master_meter.clients[1].meter.history.len() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/meter.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 114 | for (i, h) in self.clients[0].meter.history.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/meter.rs:158:25 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|(idx, client)| [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `meter` [INFO] [stdout] --> src/meter.rs:204:33 [INFO] [stdout] | [INFO] [stdout] 204 | fn update_totals(&mut self, meter: &Meter) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_meter` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/meter.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | for (i, h) in self.clients[0].meter.history.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hist_len` [INFO] [stdout] --> src/meter.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | let hist_len = hist.len(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hist_len` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/main.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | let res = run_app(&mut terminal, app, tick_rate); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/meter.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 114 | for (i, h) in self.clients[0].meter.history.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `expenses` is never read [INFO] [stdout] --> src/meter.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Expenses { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 18 | window_total: f32, [INFO] [stdout] 19 | expenses: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `balance` and `bill_expenses` are never read [INFO] [stdout] --> src/meter.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub struct Account { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 131 | balance: f32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 132 | pub(crate) master_meter: MasterMeter, [INFO] [stdout] 133 | bill_expenses: [f32; 2], [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Charger` is never used [INFO] [stdout] --> src/meter.rs:145:11 [INFO] [stdout] | [INFO] [stdout] 145 | pub trait Charger { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client` [INFO] [stdout] --> src/meter.rs:158:25 [INFO] [stdout] | [INFO] [stdout] 158 | .map(|(idx, client)| [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_client` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / return Client { [INFO] [stdout] 46 | | meter: Meter::new(), [INFO] [stdout] 47 | | expenses: Expenses::new(), [INFO] [stdout] 48 | | _data_array: (1..=30) [INFO] [stdout] ... | [INFO] [stdout] 51 | | .collect::>().try_into().unwrap(), [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ Client { [INFO] [stdout] 46 + meter: Meter::new(), [INFO] [stdout] 47 + expenses: Expenses::new(), [INFO] [stdout] 48 + _data_array: (1..=30) [INFO] [stdout] 49 + .into_iter() [INFO] [stdout] 50 + .map(|i| {(0 as f64, i as f64)}) [INFO] [stdout] 51 + .collect::>().try_into().unwrap(), [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `meter` [INFO] [stdout] --> src/meter.rs:204:33 [INFO] [stdout] | [INFO] [stdout] 204 | fn update_totals(&mut self, meter: &Meter) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_meter` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `h` [INFO] [stdout] --> src/meter.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | for (i, h) in self.clients[0].meter.history.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_h` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hist_len` [INFO] [stdout] --> src/meter.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | let hist_len = hist.len(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hist_len` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/meter.rs:48:26 [INFO] [stdout] | [INFO] [stdout] 48 | _data_array: (1..=30) [INFO] [stdout] | __________________________^ [INFO] [stdout] 49 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(1..=30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / return MasterMeter { [INFO] [stdout] 100 | | meter: Meter::new(), [INFO] [stdout] 101 | | expenses: Expenses::new(), [INFO] [stdout] 102 | | clients: clients, [INFO] [stdout] 103 | | expense_factors: [].to_vec(), [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ MasterMeter { [INFO] [stdout] 100 + meter: Meter::new(), [INFO] [stdout] 101 + expenses: Expenses::new(), [INFO] [stdout] 102 + clients: clients, [INFO] [stdout] 103 + expense_factors: [].to_vec(), [INFO] [stdout] 104 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/meter.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 108 | if !self.expenses.old_ratchet.is_none() && self.expenses.old_ratchet.unwrap().0 == self.expenses.ratchet_val.unwrap().0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.expenses.old_ratchet.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res` [INFO] [stdout] --> src/main.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | let res = run_app(&mut terminal, app, tick_rate); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_res` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `expenses` is never read [INFO] [stdout] --> src/meter.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Expenses { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 18 | window_total: f32, [INFO] [stdout] 19 | expenses: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | / return Account { [INFO] [stdout] 139 | | balance: 0.0, [INFO] [stdout] 140 | | master_meter: MasterMeter::new(clients), [INFO] [stdout] 141 | | bill_expenses: [0.0, 0.0], [INFO] [stdout] 142 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ Account { [INFO] [stdout] 139 + balance: 0.0, [INFO] [stdout] 140 + master_meter: MasterMeter::new(clients), [INFO] [stdout] 141 + bill_expenses: [0.0, 0.0], [INFO] [stdout] 142 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `balance` and `bill_expenses` are never read [INFO] [stdout] --> src/meter.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub struct Account { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 131 | balance: f32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 132 | pub(crate) master_meter: MasterMeter, [INFO] [stdout] 133 | bill_expenses: [f32; 2], [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Charger` is never used [INFO] [stdout] --> src/meter.rs:145:11 [INFO] [stdout] | [INFO] [stdout] 145 | pub trait Charger { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / return Client { [INFO] [stdout] 46 | | meter: Meter::new(), [INFO] [stdout] 47 | | expenses: Expenses::new(), [INFO] [stdout] 48 | | _data_array: (1..=30) [INFO] [stdout] ... | [INFO] [stdout] 51 | | .collect::>().try_into().unwrap(), [INFO] [stdout] 52 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 ~ Client { [INFO] [stdout] 46 + meter: Meter::new(), [INFO] [stdout] 47 + expenses: Expenses::new(), [INFO] [stdout] 48 + _data_array: (1..=30) [INFO] [stdout] 49 + .into_iter() [INFO] [stdout] 50 + .map(|i| {(0 as f64, i as f64)}) [INFO] [stdout] 51 + .collect::>().try_into().unwrap(), [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - self.history.push((t, rng.gen_range(5..=30))); [INFO] [stdout] 246 - return; [INFO] [stdout] 245 + self.history.push((t, rng.gen_range(5..=30))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/meter.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 228 | if self.history.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SystemTime` which implements the `Copy` trait [INFO] [stdout] --> src/meter.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 231 | t = SystemTime::now().clone().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `SystemTime::now()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/meter.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | t = t + Duration::days(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t += Duration::days(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/meter.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | if self.history.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/meter.rs:261:26 [INFO] [stdout] | [INFO] [stdout] 261 | let amount = b_client.meter.history[b_client.meter.history.len() - 1].1 as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b_client.meter.history[b_client.meter.history.len() - 1].1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return App { [INFO] [stdout] 33 | | account: Account::new(vec![Client::new(), Client::new()]), [INFO] [stdout] 34 | | day: 0, [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ App { [INFO] [stdout] 33 + account: Account::new(vec![Client::new(), Client::new()]), [INFO] [stdout] 34 + day: 0, [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/meter.rs:48:26 [INFO] [stdout] | [INFO] [stdout] 48 | _data_array: (1..=30) [INFO] [stdout] | __________________________^ [INFO] [stdout] 49 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(1..=30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 98 | match app.account.master_meter.clients[0].meter.history.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!app.account.master_meter.clients[0].meter.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / return MasterMeter { [INFO] [stdout] 100 | | meter: Meter::new(), [INFO] [stdout] 101 | | expenses: Expenses::new(), [INFO] [stdout] 102 | | clients: clients, [INFO] [stdout] 103 | | expense_factors: [].to_vec(), [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ MasterMeter { [INFO] [stdout] 100 + meter: Meter::new(), [INFO] [stdout] 101 + expenses: Expenses::new(), [INFO] [stdout] 102 + clients: clients, [INFO] [stdout] 103 + expense_factors: [].to_vec(), [INFO] [stdout] 104 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/main.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | 0 as u16 [INFO] [stdout] | ^^^^^^^^ help: try: `0_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/meter.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 108 | if !self.expenses.old_ratchet.is_none() && self.expenses.old_ratchet.unwrap().0 == self.expenses.ratchet_val.unwrap().0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.expenses.old_ratchet.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 115 | match (app.account.master_meter.clients[1].meter.history.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!app.account.master_meter.clients[1].meter.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/main.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | 0 as u16 [INFO] [stdout] | ^^^^^^^^ help: try: `0_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | / return Account { [INFO] [stdout] 139 | | balance: 0.0, [INFO] [stdout] 140 | | master_meter: MasterMeter::new(clients), [INFO] [stdout] 141 | | bill_expenses: [0.0, 0.0], [INFO] [stdout] 142 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ Account { [INFO] [stdout] 139 + balance: 0.0, [INFO] [stdout] 140 + master_meter: MasterMeter::new(clients), [INFO] [stdout] 141 + bill_expenses: [0.0, 0.0], [INFO] [stdout] 142 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/meter.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 - self.history.push((t, rng.gen_range(5..=30))); [INFO] [stdout] 246 - return; [INFO] [stdout] 245 + self.history.push((t, rng.gen_range(5..=30))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/meter.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 228 | if self.history.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SystemTime` which implements the `Copy` trait [INFO] [stdout] --> src/meter.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 231 | t = SystemTime::now().clone().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `SystemTime::now()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/meter.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | t = t + Duration::days(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `t += Duration::days(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/meter.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | if self.history.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/meter.rs:261:26 [INFO] [stdout] | [INFO] [stdout] 261 | let amount = b_client.meter.history[b_client.meter.history.len() - 1].1 as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b_client.meter.history[b_client.meter.history.len() - 1].1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return App { [INFO] [stdout] 33 | | account: Account::new(vec![Client::new(), Client::new()]), [INFO] [stdout] 34 | | day: 0, [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ App { [INFO] [stdout] 33 + account: Account::new(vec![Client::new(), Client::new()]), [INFO] [stdout] 34 + day: 0, [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 98 | match app.account.master_meter.clients[0].meter.history.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!app.account.master_meter.clients[0].meter.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/main.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | 0 as u16 [INFO] [stdout] | ^^^^^^^^ help: try: `0_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 115 | match (app.account.master_meter.clients[1].meter.history.len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!app.account.master_meter.clients[1].meter.history.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u16` is unnecessary [INFO] [stdout] --> src/main.rs:122:21 [INFO] [stdout] | [INFO] [stdout] 122 | 0 as u16 [INFO] [stdout] | ^^^^^^^^ help: try: `0_u16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.62s [INFO] running `Command { std: "docker" "inspect" "ccac56c2e221e964f869f18a7d13ef48cad5b25923d2b700c3e78e3c643aa311", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccac56c2e221e964f869f18a7d13ef48cad5b25923d2b700c3e78e3c643aa311", kill_on_drop: false }` [INFO] [stdout] ccac56c2e221e964f869f18a7d13ef48cad5b25923d2b700c3e78e3c643aa311