[INFO] cloning repository https://github.com/cirerick/Rusty_Pipe_Maze
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cirerick/Rusty_Pipe_Maze" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcirerick%2FRusty_Pipe_Maze", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcirerick%2FRusty_Pipe_Maze'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] dca5d198895e718226c66876c3b69d5321faa624
[INFO] linting cirerick/Rusty_Pipe_Maze against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcirerick%2FRusty_Pipe_Maze" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/cirerick/Rusty_Pipe_Maze
[INFO] finished tweaking git repo https://github.com/cirerick/Rusty_Pipe_Maze
[INFO] tweaked toml for git repo https://github.com/cirerick/Rusty_Pipe_Maze written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/cirerick/Rusty_Pipe_Maze on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/cirerick/Rusty_Pipe_Maze already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] b2c4504d3a16b4b2f88f1c099bab545e2e731a5b67d39711986ea722d2f2bdbe
[INFO] running `Command { std: "docker" "start" "-a" "b2c4504d3a16b4b2f88f1c099bab545e2e731a5b67d39711986ea722d2f2bdbe", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "b2c4504d3a16b4b2f88f1c099bab545e2e731a5b67d39711986ea722d2f2bdbe", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "b2c4504d3a16b4b2f88f1c099bab545e2e731a5b67d39711986ea722d2f2bdbe", kill_on_drop: false }`
[INFO] [stdout] b2c4504d3a16b4b2f88f1c099bab545e2e731a5b67d39711986ea722d2f2bdbe
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 84ebe43f615ea9b750c878687ef768fad6731d1b0d78d3ac2bb83169e9f5f3c9
[INFO] running `Command { std: "docker" "start" "-a" "84ebe43f615ea9b750c878687ef768fad6731d1b0d78d3ac2bb83169e9f5f3c9", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.155
[INFO] [stderr]     Checking getrandom v0.2.15
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking Rusty_Pipe_Maze v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses
[INFO] [stdout]   --> src/resu.rs:41:18
[INFO] [stdout]    |
[INFO] [stdout] 41 |             if !(((*self.pipe_pos)).bridged.is_null()) {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^ help: remove them: `(*self.pipe_pos)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stdout]    = note: `#[warn(clippy::double_parens)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::alloc::alloc`
[INFO] [stdout]   --> src/pipes.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | use std::alloc::alloc;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::alloc::handle_alloc_error`
[INFO] [stdout]   --> src/pipes.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | use std::alloc::handle_alloc_error;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::ops::DerefMut`
[INFO] [stdout]   --> src/pipes.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | use std::ops::DerefMut;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::ptr`
[INFO] [stdout]   --> src/pipes.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 | use std::ptr;
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipes.rs:62:13
[INFO] [stdout]    |
[INFO] [stdout] 62 |             data: data,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/pipes.rs:152:22
[INFO] [stdout]     |
[INFO] [stdout] 152 |         return Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout]     |                      ^^^^^^ help: replace it with: `id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::path`
[INFO] [stdout]  --> src/main.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::path;
[INFO] [stdout]   |     ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stdout]   --> src/main.rs:32:23
[INFO] [stdout]    |
[INFO] [stdout] 32 |         y if y < 1 || y >= path_n + 1 => {
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^ help: change it to: `y > path_n`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stdout]    = note: `#[warn(clippy::int_plus_one)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: file is loaded as a module multiple times: `src/lib/cin.rs`
[INFO] [stdout]  --> src/main.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | / #[path = "lib/cin.rs"]
[INFO] [stdout] 5 | | mod cin;
[INFO] [stdout]   | |________^ loaded again here
[INFO] [stdout]   |
[INFO] [stdout]  ::: src/pipes.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | / #[path = "lib/cin.rs"]
[INFO] [stdout] 5 | | mod cin;
[INFO] [stdout]   | |________^ first loaded here
[INFO] [stdout]   |
[INFO] [stdout]   = help: replace all but one `mod` item with `use` items
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod
[INFO] [stdout]   = note: `#[warn(clippy::duplicate_mod)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `running`
[INFO] [stdout]   --> src/resu.rs:39:29
[INFO] [stdout]    |
[INFO] [stdout] 39 |     pub fn cross(&mut self, running: &mut bool) {
[INFO] [stdout]    |                             ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_running`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `pipes::Node<T>` is more private than the item `pipes::resu::User::pipe_pos`
[INFO] [stdout]   --> src/resu.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     pub pipe_pos: *mut Node<T>,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ field `pipes::resu::User::pipe_pos` is reachable at visibility `pub(crate)`
[INFO] [stdout]    |
[INFO] [stdout] note: but type `pipes::Node<T>` is only usable at visibility `pub(self)`
[INFO] [stdout]   --> src/pipes.rs:33:1
[INFO] [stdout]    |
[INFO] [stdout] 33 | struct Node<T> {
[INFO] [stdout]    | ^^^^^^^^^^^^^^
[INFO] [stdout]    = note: `#[warn(private_interfaces)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `new` is never used
[INFO] [stdout]   --> src/pipes.rs:59:8
[INFO] [stdout]    |
[INFO] [stdout] 58 | impl<T> Node<T> {
[INFO] [stdout]    | --------------- associated function in this implementation
[INFO] [stdout] 59 |     fn new(data: T) -> Self {
[INFO] [stdout]    |        ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/math.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 |     return result
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 11 -     return result
[INFO] [stdout] 11 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]  --> src/lib/math.rs:8:9
[INFO] [stdout]   |
[INFO] [stdout] 8 |         result = result * base;
[INFO] [stdout]   |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result *= base`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]   = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     return user_input
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 14 -     return user_input
[INFO] [stdout] 14 +     user_input
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     return user_char
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -     return user_char
[INFO] [stdout] 33 +     user_char
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 46 -     return num
[INFO] [stdout] 46 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:59:5
[INFO] [stdout]    |
[INFO] [stdout] 59 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 59 -     return num
[INFO] [stdout] 59 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -     return num
[INFO] [stdout] 71 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:84:5
[INFO] [stdout]    |
[INFO] [stdout] 84 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 84 -     return num
[INFO] [stdout] 84 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:97:5
[INFO] [stdout]    |
[INFO] [stdout] 97 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -     return num
[INFO] [stdout] 97 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib/cin.rs:110:5
[INFO] [stdout]     |
[INFO] [stdout] 110 |     return num
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -     return num
[INFO] [stdout] 110 +     num
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/resu.rs:19:9
[INFO] [stdout]    |
[INFO] [stdout] 19 | /         return User {pipe_pos: path.start,
[INFO] [stdout] 20 | |                      ascii_pos: (start_pos_x, start_pos_y),        
[INFO] [stdout] 21 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 ~         User {pipe_pos: path.start,
[INFO] [stdout] 20 +                      ascii_pos: (start_pos_x, start_pos_y),        
[INFO] [stdout] 21 +                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 | /         return Node {
[INFO] [stdout] 61 | |             id: 0,
[INFO] [stdout] 62 | |             data: data,
[INFO] [stdout] 63 | |             on_path: 0,
[INFO] [stdout] ...  |
[INFO] [stdout] 66 | |             next: std::ptr::null_mut(), 
[INFO] [stdout] 67 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 ~         Node {
[INFO] [stdout] 61 +             id: 0,
[INFO] [stdout] 62 +             data: data,
[INFO] [stdout] 63 +             on_path: 0,
[INFO] [stdout] 64 +             bridged: std::ptr::null_mut(),
[INFO] [stdout] 65 +             side: Side::None,
[INFO] [stdout] 66 +             next: std::ptr::null_mut(), 
[INFO] [stdout] 67 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:83:13
[INFO] [stdout]    |
[INFO] [stdout] 83 |             return unsafe {(*self.next).get_node(id)}
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 83 -             return unsafe {(*self.next).get_node(id)}
[INFO] [stdout] 83 +             unsafe {(*self.next).get_node(id)}
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:85:13
[INFO] [stdout]    |
[INFO] [stdout] 85 |             return self
[INFO] [stdout]    |             ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 85 -             return self
[INFO] [stdout] 85 +             self
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:96:17
[INFO] [stdout]    |
[INFO] [stdout] 96 |                 return (*self.next).set_next(id, data, path_id)
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 96 -                 return (*self.next).set_next(id, data, path_id)
[INFO] [stdout] 96 +                 (*self.next).set_next(id, data, path_id)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:137:21
[INFO] [stdout]     |
[INFO] [stdout] 137 |                     return
[INFO] [stdout]     |                     ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 136 -                     println!("Head node is empty. Presumed Node ID: {}", id_b);
[INFO] [stdout] 137 -                     return
[INFO] [stdout] 136 +                     println!("Head node is empty. Presumed Node ID: {}", id_b);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:152:9
[INFO] [stdout]     |
[INFO] [stdout] 152 |         return Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 152 -         return Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout] 152 +         Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses
[INFO] [stdout]   --> src/resu.rs:41:18
[INFO] [stdout]    |
[INFO] [stdout] 41 |             if !(((*self.pipe_pos)).bridged.is_null()) {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^ help: remove them: `(*self.pipe_pos)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stdout]    = note: `#[warn(clippy::double_parens)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::alloc::alloc`
[INFO] [stdout]   --> src/pipes.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | use std::alloc::alloc;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::alloc::handle_alloc_error`
[INFO] [stdout]   --> src/pipes.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | use std::alloc::handle_alloc_error;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::ops::DerefMut`
[INFO] [stdout]   --> src/pipes.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 | use std::ops::DerefMut;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::ptr`
[INFO] [stdout]   --> src/pipes.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 | use std::ptr;
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/pipes.rs:62:13
[INFO] [stdout]    |
[INFO] [stdout] 62 |             data: data,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/pipes.rs:152:22
[INFO] [stdout]     |
[INFO] [stdout] 152 |         return Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout]     |                      ^^^^^^ help: replace it with: `id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:219:9
[INFO] [stdout]     |
[INFO] [stdout] 219 |         return Map {path_list: Vec::new(),}
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 219 -         return Map {path_list: Vec::new(),}
[INFO] [stdout] 219 +         Map {path_list: Vec::new(),}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type parameter `T` goes unused in function definition
[INFO] [stdout]    --> src/pipes.rs:236:17
[INFO] [stdout]     |
[INFO] [stdout] 236 | pub fn spawn_map<T: std::fmt::Debug>(path_n: u8, bridge_n: u8) -> Map<i32> {
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
[INFO] [stdout]     = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
[INFO] [stdout] help: consider removing the parameter
[INFO] [stdout]     |
[INFO] [stdout] 236 - pub fn spawn_map<T: std::fmt::Debug>(path_n: u8, bridge_n: u8) -> Map<i32> {
[INFO] [stdout] 236 + pub fn spawn_map(path_n: u8, bridge_n: u8) -> Map<i32> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:307:5
[INFO] [stdout]     |
[INFO] [stdout] 307 |     return map
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 307 -     return map
[INFO] [stdout] 307 +     map
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:263:71
[INFO] [stdout]     |
[INFO] [stdout] 263 |                 map.path_list[rand as usize].push(temp_node_id as u8, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                       ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout]     = note: `#[warn(clippy::neg_multiply)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:264:83
[INFO] [stdout]     |
[INFO] [stdout] 264 |                 map.path_list[(rand as usize) + 1].push((temp_node_id as u8) + 1, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:269:71
[INFO] [stdout]     |
[INFO] [stdout] 269 |                 map.path_list[rand as usize].push(temp_node_id as u8, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                       ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::path`
[INFO] [stdout]  --> src/main.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::path;
[INFO] [stdout]   |     ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=`
[INFO] [stdout]   --> src/main.rs:32:23
[INFO] [stdout]    |
[INFO] [stdout] 32 |         y if y < 1 || y >= path_n + 1 => {
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^ help: change it to: `y > path_n`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one
[INFO] [stdout]    = note: `#[warn(clippy::int_plus_one)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:270:83
[INFO] [stdout]     |
[INFO] [stdout] 270 |                 map.path_list[(rand as usize) - 1].push((temp_node_id as u8) + 1, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: file is loaded as a module multiple times: `src/lib/cin.rs`
[INFO] [stdout]  --> src/main.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | / #[path = "lib/cin.rs"]
[INFO] [stdout] 5 | | mod cin;
[INFO] [stdout]   | |________^ loaded again here
[INFO] [stdout]   |
[INFO] [stdout]  ::: src/pipes.rs:4:1
[INFO] [stdout]   |
[INFO] [stdout] 4 | / #[path = "lib/cin.rs"]
[INFO] [stdout] 5 | | mod cin;
[INFO] [stdout]   | |________^ first loaded here
[INFO] [stdout]   |
[INFO] [stdout]   = help: replace all but one `mod` item with `use` items
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod
[INFO] [stdout]   = note: `#[warn(clippy::duplicate_mod)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:277:75
[INFO] [stdout]     |
[INFO] [stdout] 277 |                 map.path_list[temp_pos as usize].push(temp_node_id as u8, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                           ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:286:100
[INFO] [stdout]     |
[INFO] [stdout] 286 |                 map.path_list[((temp_pos as i8) + (rand)) as usize].push((temp_node_id as u8) + 1, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                                                    ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/pipes.rs:367:67
[INFO] [stdout]     |
[INFO] [stdout] 367 |                     if _j % 4 == 0 && _j != cols - 1 && !found && !cached_lists[_j / 4].is_none(){   
[INFO] [stdout]     |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_lists[_j / 4].is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:444:5
[INFO] [stdout]     |
[INFO] [stdout] 444 |     return matrix
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 444 -     return matrix
[INFO] [stdout] 444 +     matrix
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_j` is used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:336:27
[INFO] [stdout]     |
[INFO] [stdout] 336 |                 for _j in 0..cols {
[INFO] [stdout]     |                           ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 336 -                 for _j in 0..cols {
[INFO] [stdout] 336 +                 for (_j, <item>) in matrix.iter_mut().enumerate().take(cols) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:362:19
[INFO] [stdout]     |
[INFO] [stdout] 362 |             _i if (rows - _i - 1) % 2 == 0 => {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(rows - _i - 1).is_multiple_of(2)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]     = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:367:24
[INFO] [stdout]     |
[INFO] [stdout] 367 |                     if _j % 4 == 0 && _j != cols - 1 && !found && !cached_lists[_j / 4].is_none(){   
[INFO] [stdout]     |                        ^^^^^^^^^^^ help: replace with: `_j.is_multiple_of(4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:382:89
[INFO] [stdout]     |
[INFO] [stdout] 382 | ...                   Some(node) => { cached_lists[_j / 4] = Some(&node);},
[INFO] [stdout]     |                                                                   ^^^^^ help: change this to: `node`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:387:44
[INFO] [stdout]     |
[INFO] [stdout] 387 | ...                   if _j % 4 != 0 {
[INFO] [stdout]     |                          ^^^^^^^^^^^ help: replace with: `!_j.is_multiple_of(4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:421:31
[INFO] [stdout]     |
[INFO] [stdout] 421 |                     } else if _j % 4 == 0{
[INFO] [stdout]     |                               ^^^^^^^^^^^ help: replace with: `_j.is_multiple_of(4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_j` is used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:433:27
[INFO] [stdout]     |
[INFO] [stdout] 433 |                 for _j in 0..cols {
[INFO] [stdout]     |                           ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 433 -                 for _j in 0..cols {
[INFO] [stdout] 433 +                 for (_j, <item>) in matrix.iter_mut().enumerate().take(cols) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pipes.rs:448:25
[INFO] [stdout]     |
[INFO] [stdout] 448 | pub fn draw_map(matrix: &Vec<Vec<char>>, path_n: u8, bridge_n: u8) {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 448 - pub fn draw_map(matrix: &Vec<Vec<char>>, path_n: u8, bridge_n: u8) {
[INFO] [stdout] 448 + pub fn draw_map(matrix: &[Vec<char>], path_n: u8, bridge_n: u8) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_i` is only used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:452:15
[INFO] [stdout]     |
[INFO] [stdout] 452 |     for _i in 0..rows{
[INFO] [stdout]     |               ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 452 -     for _i in 0..rows{
[INFO] [stdout] 452 +     for <item> in matrix.iter().take(rows){
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_j` is only used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:453:19
[INFO] [stdout]     |
[INFO] [stdout] 453 |         for _j in 0..cols {
[INFO] [stdout]     |                   ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 453 -         for _j in 0..cols {
[INFO] [stdout] 453 +         for <item> in matrix.iter().take(cols) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/pipes.rs:456:9
[INFO] [stdout]     |
[INFO] [stdout] 456 |         println!("");
[INFO] [stdout]     |         ^^^^^^^^^--^
[INFO] [stdout]     |                  |
[INFO] [stdout]     |                  help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]     = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:474:22
[INFO] [stdout]     |
[INFO] [stdout] 474 |             draw_map(&map_drawing, path_n, bridge_n); 
[INFO] [stdout]     |                      ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:496:50
[INFO] [stdout]     |
[INFO] [stdout] 496 | ...                   draw_map(&map_drawing, path_n, bridge_n);
[INFO] [stdout]     |                                ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:513:50
[INFO] [stdout]     |
[INFO] [stdout] 513 | ...                   draw_map(&map_drawing, path_n, bridge_n);
[INFO] [stdout]     |                                ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:537:22
[INFO] [stdout]     |
[INFO] [stdout] 537 |             draw_map(&map_drawing, path_n, bridge_n);
[INFO] [stdout]     |                      ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/pipes.rs:548:25
[INFO] [stdout]     |
[INFO] [stdout] 548 |               if *running {
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 549 | |                 map_drawing[resu.ascii_pos.1][resu.ascii_pos.0] = *prev_ascii; 
[INFO] [stdout] 550 | |                 resu.ascii_pos.1 -= 1;
[INFO] [stdout] 551 | |                 *prev_ascii = map_drawing[resu.ascii_pos.1][resu.ascii_pos.0];
[INFO] [stdout] ...   |
[INFO] [stdout] 557 | |                 resu.next(running);
[INFO] [stdout] 558 | |             } else {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/pipes.rs:558:20
[INFO] [stdout]     |
[INFO] [stdout] 558 |               } else {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 559 | |                 map_drawing[resu.ascii_pos.1][resu.ascii_pos.0] = *prev_ascii; 
[INFO] [stdout] 560 | |                 resu.ascii_pos.1 -= 1;
[INFO] [stdout] 561 | |                 *prev_ascii = map_drawing[resu.ascii_pos.1][resu.ascii_pos.0];
[INFO] [stdout] ...   |
[INFO] [stdout] 567 | |                 resu.next(running);
[INFO] [stdout] 568 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:555:26
[INFO] [stdout]     |
[INFO] [stdout] 555 |                 draw_map(&map_drawing, path_n, bridge_n); 
[INFO] [stdout]     |                          ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:565:26
[INFO] [stdout]     |
[INFO] [stdout] 565 |                 draw_map(&map_drawing, path_n, bridge_n); 
[INFO] [stdout]     |                          ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `running`
[INFO] [stdout]   --> src/resu.rs:39:29
[INFO] [stdout]    |
[INFO] [stdout] 39 |     pub fn cross(&mut self, running: &mut bool) {
[INFO] [stdout]    |                             ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_running`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type `pipes::Node<T>` is more private than the item `pipes::resu::User::pipe_pos`
[INFO] [stdout]   --> src/resu.rs:13:5
[INFO] [stdout]    |
[INFO] [stdout] 13 |     pub pipe_pos: *mut Node<T>,
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ field `pipes::resu::User::pipe_pos` is reachable at visibility `pub(crate)`
[INFO] [stdout]    |
[INFO] [stdout] note: but type `pipes::Node<T>` is only usable at visibility `pub(self)`
[INFO] [stdout]   --> src/pipes.rs:33:1
[INFO] [stdout]    |
[INFO] [stdout] 33 | struct Node<T> {
[INFO] [stdout]    | ^^^^^^^^^^^^^^
[INFO] [stdout]    = note: `#[warn(private_interfaces)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `new` is never used
[INFO] [stdout]   --> src/pipes.rs:59:8
[INFO] [stdout]    |
[INFO] [stdout] 58 | impl<T> Node<T> {
[INFO] [stdout]    | --------------- associated function in this implementation
[INFO] [stdout] 59 |     fn new(data: T) -> Self {
[INFO] [stdout]    |        ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/math.rs:11:5
[INFO] [stdout]    |
[INFO] [stdout] 11 |     return result
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 11 -     return result
[INFO] [stdout] 11 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]  --> src/lib/math.rs:8:9
[INFO] [stdout]   |
[INFO] [stdout] 8 |         result = result * base;
[INFO] [stdout]   |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result *= base`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]   = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:14:5
[INFO] [stdout]    |
[INFO] [stdout] 14 |     return user_input
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 14 -     return user_input
[INFO] [stdout] 14 +     user_input
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:33:5
[INFO] [stdout]    |
[INFO] [stdout] 33 |     return user_char
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 33 -     return user_char
[INFO] [stdout] 33 +     user_char
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:46:5
[INFO] [stdout]    |
[INFO] [stdout] 46 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 46 -     return num
[INFO] [stdout] 46 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:59:5
[INFO] [stdout]    |
[INFO] [stdout] 59 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 59 -     return num
[INFO] [stdout] 59 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:71:5
[INFO] [stdout]    |
[INFO] [stdout] 71 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 71 -     return num
[INFO] [stdout] 71 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:84:5
[INFO] [stdout]    |
[INFO] [stdout] 84 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 84 -     return num
[INFO] [stdout] 84 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lib/cin.rs:97:5
[INFO] [stdout]    |
[INFO] [stdout] 97 |     return num
[INFO] [stdout]    |     ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -     return num
[INFO] [stdout] 97 +     num
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib/cin.rs:110:5
[INFO] [stdout]     |
[INFO] [stdout] 110 |     return num
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 110 -     return num
[INFO] [stdout] 110 +     num
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/resu.rs:19:9
[INFO] [stdout]    |
[INFO] [stdout] 19 | /         return User {pipe_pos: path.start,
[INFO] [stdout] 20 | |                      ascii_pos: (start_pos_x, start_pos_y),        
[INFO] [stdout] 21 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 ~         User {pipe_pos: path.start,
[INFO] [stdout] 20 +                      ascii_pos: (start_pos_x, start_pos_y),        
[INFO] [stdout] 21 +                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 | /         return Node {
[INFO] [stdout] 61 | |             id: 0,
[INFO] [stdout] 62 | |             data: data,
[INFO] [stdout] 63 | |             on_path: 0,
[INFO] [stdout] ...  |
[INFO] [stdout] 66 | |             next: std::ptr::null_mut(), 
[INFO] [stdout] 67 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 ~         Node {
[INFO] [stdout] 61 +             id: 0,
[INFO] [stdout] 62 +             data: data,
[INFO] [stdout] 63 +             on_path: 0,
[INFO] [stdout] 64 +             bridged: std::ptr::null_mut(),
[INFO] [stdout] 65 +             side: Side::None,
[INFO] [stdout] 66 +             next: std::ptr::null_mut(), 
[INFO] [stdout] 67 +         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:83:13
[INFO] [stdout]    |
[INFO] [stdout] 83 |             return unsafe {(*self.next).get_node(id)}
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 83 -             return unsafe {(*self.next).get_node(id)}
[INFO] [stdout] 83 +             unsafe {(*self.next).get_node(id)}
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:85:13
[INFO] [stdout]    |
[INFO] [stdout] 85 |             return self
[INFO] [stdout]    |             ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 85 -             return self
[INFO] [stdout] 85 +             self
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/pipes.rs:96:17
[INFO] [stdout]    |
[INFO] [stdout] 96 |                 return (*self.next).set_next(id, data, path_id)
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 96 -                 return (*self.next).set_next(id, data, path_id)
[INFO] [stdout] 96 +                 (*self.next).set_next(id, data, path_id)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:137:21
[INFO] [stdout]     |
[INFO] [stdout] 137 |                     return
[INFO] [stdout]     |                     ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 136 -                     println!("Head node is empty. Presumed Node ID: {}", id_b);
[INFO] [stdout] 137 -                     return
[INFO] [stdout] 136 +                     println!("Head node is empty. Presumed Node ID: {}", id_b);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:152:9
[INFO] [stdout]     |
[INFO] [stdout] 152 |         return Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 152 -         return Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout] 152 +         Path {id: id, start:  std::ptr::null_mut(), goal: None}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:219:9
[INFO] [stdout]     |
[INFO] [stdout] 219 |         return Map {path_list: Vec::new(),}
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 219 -         return Map {path_list: Vec::new(),}
[INFO] [stdout] 219 +         Map {path_list: Vec::new(),}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: type parameter `T` goes unused in function definition
[INFO] [stdout]    --> src/pipes.rs:236:17
[INFO] [stdout]     |
[INFO] [stdout] 236 | pub fn spawn_map<T: std::fmt::Debug>(path_n: u8, bridge_n: u8) -> Map<i32> {
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
[INFO] [stdout]     = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
[INFO] [stdout] help: consider removing the parameter
[INFO] [stdout]     |
[INFO] [stdout] 236 - pub fn spawn_map<T: std::fmt::Debug>(path_n: u8, bridge_n: u8) -> Map<i32> {
[INFO] [stdout] 236 + pub fn spawn_map(path_n: u8, bridge_n: u8) -> Map<i32> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:307:5
[INFO] [stdout]     |
[INFO] [stdout] 307 |     return map
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 307 -     return map
[INFO] [stdout] 307 +     map
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:263:71
[INFO] [stdout]     |
[INFO] [stdout] 263 |                 map.path_list[rand as usize].push(temp_node_id as u8, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                       ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout]     = note: `#[warn(clippy::neg_multiply)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:264:83
[INFO] [stdout]     |
[INFO] [stdout] 264 |                 map.path_list[(rand as usize) + 1].push((temp_node_id as u8) + 1, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:269:71
[INFO] [stdout]     |
[INFO] [stdout] 269 |                 map.path_list[rand as usize].push(temp_node_id as u8, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                       ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:270:83
[INFO] [stdout]     |
[INFO] [stdout] 270 |                 map.path_list[(rand as usize) - 1].push((temp_node_id as u8) + 1, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:277:75
[INFO] [stdout]     |
[INFO] [stdout] 277 |                 map.path_list[temp_pos as usize].push(temp_node_id as u8, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                           ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this multiplication by -1 can be written more succinctly
[INFO] [stdout]    --> src/pipes.rs:286:100
[INFO] [stdout]     |
[INFO] [stdout] 286 |                 map.path_list[((temp_pos as i8) + (rand)) as usize].push((temp_node_id as u8) + 1, ((_i) as i32) * (-1));
[INFO] [stdout]     |                                                                                                    ^^^^^^^^^^^^^^^^^^^^ help: consider using: `-((_i) as i32)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/pipes.rs:367:67
[INFO] [stdout]     |
[INFO] [stdout] 367 |                     if _j % 4 == 0 && _j != cols - 1 && !found && !cached_lists[_j / 4].is_none(){   
[INFO] [stdout]     |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cached_lists[_j / 4].is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/pipes.rs:444:5
[INFO] [stdout]     |
[INFO] [stdout] 444 |     return matrix
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 444 -     return matrix
[INFO] [stdout] 444 +     matrix
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_j` is used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:336:27
[INFO] [stdout]     |
[INFO] [stdout] 336 |                 for _j in 0..cols {
[INFO] [stdout]     |                           ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 336 -                 for _j in 0..cols {
[INFO] [stdout] 336 +                 for (_j, <item>) in matrix.iter_mut().enumerate().take(cols) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:362:19
[INFO] [stdout]     |
[INFO] [stdout] 362 |             _i if (rows - _i - 1) % 2 == 0 => {
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(rows - _i - 1).is_multiple_of(2)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout]     = note: `#[warn(clippy::manual_is_multiple_of)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:367:24
[INFO] [stdout]     |
[INFO] [stdout] 367 |                     if _j % 4 == 0 && _j != cols - 1 && !found && !cached_lists[_j / 4].is_none(){   
[INFO] [stdout]     |                        ^^^^^^^^^^^ help: replace with: `_j.is_multiple_of(4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:382:89
[INFO] [stdout]     |
[INFO] [stdout] 382 | ...                   Some(node) => { cached_lists[_j / 4] = Some(&node);},
[INFO] [stdout]     |                                                                   ^^^^^ help: change this to: `node`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:387:44
[INFO] [stdout]     |
[INFO] [stdout] 387 | ...                   if _j % 4 != 0 {
[INFO] [stdout]     |                          ^^^^^^^^^^^ help: replace with: `!_j.is_multiple_of(4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `.is_multiple_of()`
[INFO] [stdout]    --> src/pipes.rs:421:31
[INFO] [stdout]     |
[INFO] [stdout] 421 |                     } else if _j % 4 == 0{
[INFO] [stdout]     |                               ^^^^^^^^^^^ help: replace with: `_j.is_multiple_of(4)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_j` is used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:433:27
[INFO] [stdout]     |
[INFO] [stdout] 433 |                 for _j in 0..cols {
[INFO] [stdout]     |                           ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 433 -                 for _j in 0..cols {
[INFO] [stdout] 433 +                 for (_j, <item>) in matrix.iter_mut().enumerate().take(cols) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/pipes.rs:448:25
[INFO] [stdout]     |
[INFO] [stdout] 448 | pub fn draw_map(matrix: &Vec<Vec<char>>, path_n: u8, bridge_n: u8) {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 448 - pub fn draw_map(matrix: &Vec<Vec<char>>, path_n: u8, bridge_n: u8) {
[INFO] [stdout] 448 + pub fn draw_map(matrix: &[Vec<char>], path_n: u8, bridge_n: u8) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_i` is only used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:452:15
[INFO] [stdout]     |
[INFO] [stdout] 452 |     for _i in 0..rows{
[INFO] [stdout]     |               ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 452 -     for _i in 0..rows{
[INFO] [stdout] 452 +     for <item> in matrix.iter().take(rows){
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `_j` is only used to index `matrix`
[INFO] [stdout]    --> src/pipes.rs:453:19
[INFO] [stdout]     |
[INFO] [stdout] 453 |         for _j in 0..cols {
[INFO] [stdout]     |                   ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator
[INFO] [stdout]     |
[INFO] [stdout] 453 -         for _j in 0..cols {
[INFO] [stdout] 453 +         for <item> in matrix.iter().take(cols) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]    --> src/pipes.rs:456:9
[INFO] [stdout]     |
[INFO] [stdout] 456 |         println!("");
[INFO] [stdout]     |         ^^^^^^^^^--^
[INFO] [stdout]     |                  |
[INFO] [stdout]     |                  help: remove the empty string
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]     = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:474:22
[INFO] [stdout]     |
[INFO] [stdout] 474 |             draw_map(&map_drawing, path_n, bridge_n); 
[INFO] [stdout]     |                      ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:496:50
[INFO] [stdout]     |
[INFO] [stdout] 496 | ...                   draw_map(&map_drawing, path_n, bridge_n);
[INFO] [stdout]     |                                ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:513:50
[INFO] [stdout]     |
[INFO] [stdout] 513 | ...                   draw_map(&map_drawing, path_n, bridge_n);
[INFO] [stdout]     |                                ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:537:22
[INFO] [stdout]     |
[INFO] [stdout] 537 |             draw_map(&map_drawing, path_n, bridge_n);
[INFO] [stdout]     |                      ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/pipes.rs:548:25
[INFO] [stdout]     |
[INFO] [stdout] 548 |               if *running {
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 549 | |                 map_drawing[resu.ascii_pos.1][resu.ascii_pos.0] = *prev_ascii; 
[INFO] [stdout] 550 | |                 resu.ascii_pos.1 -= 1;
[INFO] [stdout] 551 | |                 *prev_ascii = map_drawing[resu.ascii_pos.1][resu.ascii_pos.0];
[INFO] [stdout] ...   |
[INFO] [stdout] 557 | |                 resu.next(running);
[INFO] [stdout] 558 | |             } else {
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/pipes.rs:558:20
[INFO] [stdout]     |
[INFO] [stdout] 558 |               } else {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 559 | |                 map_drawing[resu.ascii_pos.1][resu.ascii_pos.0] = *prev_ascii; 
[INFO] [stdout] 560 | |                 resu.ascii_pos.1 -= 1;
[INFO] [stdout] 561 | |                 *prev_ascii = map_drawing[resu.ascii_pos.1][resu.ascii_pos.0];
[INFO] [stdout] ...   |
[INFO] [stdout] 567 | |                 resu.next(running);
[INFO] [stdout] 568 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:555:26
[INFO] [stdout]     |
[INFO] [stdout] 555 |                 draw_map(&map_drawing, path_n, bridge_n); 
[INFO] [stdout]     |                          ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/pipes.rs:565:26
[INFO] [stdout]     |
[INFO] [stdout] 565 |                 draw_map(&map_drawing, path_n, bridge_n); 
[INFO] [stdout]     |                          ^^^^^^^^^^^^ help: change this to: `map_drawing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.26s
[INFO] running `Command { std: "docker" "inspect" "84ebe43f615ea9b750c878687ef768fad6731d1b0d78d3ac2bb83169e9f5f3c9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "84ebe43f615ea9b750c878687ef768fad6731d1b0d78d3ac2bb83169e9f5f3c9", kill_on_drop: false }`
[INFO] [stdout] 84ebe43f615ea9b750c878687ef768fad6731d1b0d78d3ac2bb83169e9f5f3c9