[INFO] cloning repository https://github.com/chrischaps/Modular [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chrischaps/Modular" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrischaps%2FModular", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrischaps%2FModular'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 586d257dd03d2b38f0f813b365fca8b6c0fdd148 [INFO] linting chrischaps/Modular against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchrischaps%2FModular" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/chrischaps/Modular [INFO] finished tweaking git repo https://github.com/chrischaps/Modular [INFO] tweaked toml for git repo https://github.com/chrischaps/Modular written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/chrischaps/Modular on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/chrischaps/Modular already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/chrischaps/egui_node_graph2` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded async-net v2.0.0 [INFO] [stderr] Downloaded rtrb v0.3.2 [INFO] [stderr] Downloaded coremidi-sys v3.2.0 [INFO] [stderr] Downloaded rfd v0.15.4 [INFO] [stderr] Downloaded windows-interface v0.56.0 [INFO] [stderr] Downloaded windows-implement v0.56.0 [INFO] [stderr] Downloaded zbus_macros v5.13.2 [INFO] [stderr] Downloaded egui-wgpu v0.30.0 [INFO] [stderr] Downloaded egui-winit v0.30.0 [INFO] [stderr] Downloaded windows-core v0.56.0 [INFO] [stderr] Downloaded zvariant v5.9.2 [INFO] [stderr] Downloaded ashpd v0.11.1 [INFO] [stderr] Downloaded zbus v5.13.2 [INFO] [stderr] Downloaded midir v0.10.3 [INFO] [stderr] Downloaded egui_glow v0.30.0 [INFO] [stderr] Downloaded emath v0.30.0 [INFO] [stderr] Downloaded coremidi v0.8.0 [INFO] [stderr] Downloaded ecolor v0.30.0 [INFO] [stderr] Downloaded eframe v0.30.0 [INFO] [stderr] Downloaded epaint v0.30.0 [INFO] [stderr] Downloaded zvariant_derive v5.9.2 [INFO] [stderr] Downloaded egui v0.30.0 [INFO] [stderr] Downloaded epaint_default_fonts v0.30.0 [INFO] [stderr] Downloaded windows v0.56.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f84a38b82894bf84e42468693f863f2361987bcb5f52acce097f758b864e58d9 [INFO] running `Command { std: "docker" "start" "-a" "f84a38b82894bf84e42468693f863f2361987bcb5f52acce097f758b864e58d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f84a38b82894bf84e42468693f863f2361987bcb5f52acce097f758b864e58d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f84a38b82894bf84e42468693f863f2361987bcb5f52acce097f758b864e58d9", kill_on_drop: false }` [INFO] [stdout] f84a38b82894bf84e42468693f863f2361987bcb5f52acce097f758b864e58d9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b5c8938da0f065933f360dc06c126e150b32f7d4717a1e68409719892c641d25 [INFO] running `Command { std: "docker" "start" "-a" "b5c8938da0f065933f360dc06c126e150b32f7d4717a1e68409719892c641d25", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking accesskit v0.17.1 [INFO] [stderr] Checking unicode-ident v1.0.22 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking immutable-chunkmap v2.1.2 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking epaint_default_fonts v0.30.0 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking accesskit_consumer v0.26.0 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Compiling slotmap v1.1.1 [INFO] [stderr] Compiling rfd v0.15.4 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking rtrb v0.3.2 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking midir v0.10.3 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.30.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking ecolor v0.30.0 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking epaint v0.30.0 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking quick-xml v0.30.0 [INFO] [stderr] Checking zvariant_utils v3.3.0 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Compiling zvariant_derive v5.9.2 [INFO] [stderr] Checking egui v0.30.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling zvariant v5.9.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking zbus_xml v4.0.0 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Checking zbus-lockstep v0.4.4 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling zbus_names v4.3.1 [INFO] [stderr] Compiling zbus-lockstep-macros v0.4.4 [INFO] [stderr] Compiling zbus_macros v5.13.2 [INFO] [stderr] Checking egui_glow v0.30.0 [INFO] [stderr] Checking egui_node_graph2 v0.7.0 (https://github.com/chrischaps/egui_node_graph2#d472af16) [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking wayland-protocols-misc v0.3.10 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking zbus v5.13.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking atspi-common v0.6.0 [INFO] [stderr] Checking ashpd v0.11.1 [INFO] [stderr] Checking atspi-proxies v0.6.0 [INFO] [stderr] Checking accesskit_atspi_common v0.10.1 [INFO] [stderr] Checking atspi-connection v0.6.0 [INFO] [stderr] Checking atspi v0.22.0 [INFO] [stderr] Checking accesskit_unix v0.13.1 [INFO] [stderr] Checking accesskit_winit v0.23.1 [INFO] [stderr] Checking egui-winit v0.30.0 [INFO] [stderr] Checking eframe v0.30.0 [INFO] [stderr] Checking modular_synth v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `sample_rate` [INFO] [stdout] --> src/engine/audio_engine.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | let sample_rate = self.config.sample_rate.0 as f32; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sample_rate` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_secondary_icon` is never used [INFO] [stdout] --> src/graph/node_data.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 232 | impl SynthNodeData { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 346 | fn draw_secondary_icon(&self, painter: &egui::Painter, center: egui::Pos2, size: f32, color: Color32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `types_equal` is never used [INFO] [stdout] --> src/graph/validation.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn types_equal(a: &SynthDataType, b: &SynthDataType) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_OUT_R` is never used [INFO] [stdout] --> src/modules/chorus.rs:231:11 [INFO] [stdout] | [INFO] [stdout] 154 | impl Chorus { [INFO] [stdout] | ----------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 231 | const PORT_OUT_R: usize = 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_GR` is never used [INFO] [stdout] --> src/modules/compressor.rs:189:11 [INFO] [stdout] | [INFO] [stdout] 108 | impl Compressor { [INFO] [stdout] | --------------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 189 | const PORT_GR: usize = 1; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_OUT_R` is never used [INFO] [stdout] --> src/modules/delay.rs:132:11 [INFO] [stdout] | [INFO] [stdout] 72 | impl StereoDelay { [INFO] [stdout] | ---------------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 132 | const PORT_OUT_R: usize = 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PORT_HIGHPASS` and `PORT_BANDPASS` are never used [INFO] [stdout] --> src/modules/filter.rs:106:11 [INFO] [stdout] | [INFO] [stdout] 57 | impl SvfFilter { [INFO] [stdout] | -------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 106 | const PORT_HIGHPASS: usize = 1; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 107 | const PORT_BANDPASS: usize = 2; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_OUT_R` is never used [INFO] [stdout] --> src/modules/reverb.rs:301:11 [INFO] [stdout] | [INFO] [stdout] 217 | impl Reverb { [INFO] [stdout] | ----------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 301 | const PORT_OUT_R: usize = 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/synth_app.rs:306:25 [INFO] [stdout] | [INFO] [stdout] 306 | / if !self.midi_held_notes.iter().any(|(n, _, _)| *n == note) { [INFO] [stdout] 307 | | self.midi_held_notes.push((note, velocity, channel)); [INFO] [stdout] 308 | | notes_changed = true; [INFO] [stdout] 309 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 304 ~ MidiEvent::NoteOn { channel, note, velocity } [INFO] [stdout] 305 | // Add note if not already in list [INFO] [stdout] 306 ~ if !self.midi_held_notes.iter().any(|(n, _, _)| *n == note) => { [INFO] [stdout] 307 | self.midi_held_notes.push((note, velocity, channel)); [INFO] [stdout] 308 | notes_changed = true; [INFO] [stdout] 309 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/synth_app.rs:320:25 [INFO] [stdout] | [INFO] [stdout] 320 | / if self.midi_aftertouch != pressure { [INFO] [stdout] 321 | | self.midi_aftertouch = pressure; [INFO] [stdout] 322 | | notes_changed = true; [INFO] [stdout] 323 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 318 ~ MidiEvent::ChannelPressure { pressure, .. } [INFO] [stdout] 319 | // Update aftertouch [INFO] [stdout] 320 ~ if self.midi_aftertouch != pressure => { [INFO] [stdout] 321 | self.midi_aftertouch = pressure; [INFO] [stdout] 322 | notes_changed = true; [INFO] [stdout] 323 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/app/synth_app.rs:1170:38 [INFO] [stdout] | [INFO] [stdout] 1170 | let in_submenu = submenu_rect.map_or(false, |r| r.contains(pos)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1170 - let in_submenu = submenu_rect.map_or(false, |r| r.contains(pos)); [INFO] [stdout] 1170 + let in_submenu = submenu_rect.is_some_and(|r| r.contains(pos)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/app/synth_app.rs:2201:29 [INFO] [stdout] | [INFO] [stdout] 2201 | .map(|(rel, _)| relative_to_midi(*rel, 0) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `relative_to_midi(*rel, 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> src/dsp/smoothed_value.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | / pub fn next(&mut self) -> f32 { [INFO] [stdout] ... | [INFO] [stdout] 118 | | self.current [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/engine/audio_engine.rs:342:28 [INFO] [stdout] | [INFO] [stdout] 342 | if fails % 1000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `fails.is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/graph/node_data.rs:1519:29 [INFO] [stdout] | [INFO] [stdout] 1519 | let base_note = (60 + octave_shift * 12).max(0).min(127) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(60 + octave_shift * 12).clamp(0, 127)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/graph/node_data.rs:1573:29 [INFO] [stdout] | [INFO] [stdout] 1573 | let base_note = (60 + octave_shift * 12).max(0).min(127) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(60 + octave_shift * 12).clamp(0, 127)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/modules/chorus.rs:319:33 [INFO] [stdout] | [INFO] [stdout] 319 | let max_delay_samples = (MAX_DELAY_SECONDS * self.sample_rate) as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(MAX_DELAY_SECONDS * self.sample_rate)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/modules/filter.rs:239:13 [INFO] [stdout] | [INFO] [stdout] 239 | self.low = self.low + f * self.band; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.low += f * self.band` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/modules/filter.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | self.band = f * high + self.band; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.band += f * high` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/modules/mixer.rs:182:22 [INFO] [stdout] | [INFO] [stdout] 182 | x.signum() * (1.0 + (1.0 - (x.abs() - 1.0).min(1.0) * 0.5)) [INFO] [stdout] | ______________________^ [INFO] [stdout] 183 | | .min(1.5) [INFO] [stdout] 184 | | .max(1.0) [INFO] [stdout] | |_____________________^ help: replace with clamp: `(1.0 + (1.0 - (x.abs() - 1.0).min(1.0) * 0.5)).clamp(1.0, 1.5)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/modules/oscillator.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 233 | / let value = if phase < 0.5 { [INFO] [stdout] 234 | | 4.0 * phase - 1.0 [INFO] [stdout] 235 | | } else { [INFO] [stdout] 236 | | 3.0 - 4.0 * phase [INFO] [stdout] 237 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 238 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 233 ~ [INFO] [stdout] 234 ~ if phase < 0.5 { [INFO] [stdout] 235 + 4.0 * phase - 1.0 [INFO] [stdout] 236 + } else { [INFO] [stdout] 237 + 3.0 - 4.0 * phase [INFO] [stdout] 238 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/widgets/fader.rs:219:53 [INFO] [stdout] | [INFO] [stdout] 219 | draw_scale_markers(painter, track_rect, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/widgets/waveform_display.rs:536:1 [INFO] [stdout] | [INFO] [stdout] 536 | / impl Default for WaveformType { [INFO] [stdout] 537 | | fn default() -> Self { [INFO] [stdout] 538 | | WaveformType::Sine [INFO] [stdout] 539 | | } [INFO] [stdout] 540 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 523 + #[derive(Default)] [INFO] [stdout] 524 | pub enum WaveformType { [INFO] [stdout] 525 | /// Sine wave [INFO] [stdout] 526 ~ #[default] [INFO] [stdout] 527 ~ Sine, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sample_rate` [INFO] [stdout] --> src/engine/audio_engine.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | let sample_rate = self.config.sample_rate.0 as f32; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sample_rate` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `draw_secondary_icon` is never used [INFO] [stdout] --> src/graph/node_data.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 232 | impl SynthNodeData { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 346 | fn draw_secondary_icon(&self, painter: &egui::Painter, center: egui::Pos2, size: f32, color: Color32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `types_equal` is never used [INFO] [stdout] --> src/graph/validation.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn types_equal(a: &SynthDataType, b: &SynthDataType) -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_OUT_R` is never used [INFO] [stdout] --> src/modules/chorus.rs:231:11 [INFO] [stdout] | [INFO] [stdout] 154 | impl Chorus { [INFO] [stdout] | ----------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 231 | const PORT_OUT_R: usize = 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_GR` is never used [INFO] [stdout] --> src/modules/compressor.rs:189:11 [INFO] [stdout] | [INFO] [stdout] 108 | impl Compressor { [INFO] [stdout] | --------------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 189 | const PORT_GR: usize = 1; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_OUT_R` is never used [INFO] [stdout] --> src/modules/delay.rs:132:11 [INFO] [stdout] | [INFO] [stdout] 72 | impl StereoDelay { [INFO] [stdout] | ---------------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 132 | const PORT_OUT_R: usize = 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PORT_HIGHPASS` and `PORT_BANDPASS` are never used [INFO] [stdout] --> src/modules/filter.rs:106:11 [INFO] [stdout] | [INFO] [stdout] 57 | impl SvfFilter { [INFO] [stdout] | -------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 106 | const PORT_HIGHPASS: usize = 1; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 107 | const PORT_BANDPASS: usize = 2; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `PORT_OUT_R` is never used [INFO] [stdout] --> src/modules/reverb.rs:301:11 [INFO] [stdout] | [INFO] [stdout] 217 | impl Reverb { [INFO] [stdout] | ----------- associated constant in this implementation [INFO] [stdout] ... [INFO] [stdout] 301 | const PORT_OUT_R: usize = 1; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/synth_app.rs:306:25 [INFO] [stdout] | [INFO] [stdout] 306 | / if !self.midi_held_notes.iter().any(|(n, _, _)| *n == note) { [INFO] [stdout] 307 | | self.midi_held_notes.push((note, velocity, channel)); [INFO] [stdout] 308 | | notes_changed = true; [INFO] [stdout] 309 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 304 ~ MidiEvent::NoteOn { channel, note, velocity } [INFO] [stdout] 305 | // Add note if not already in list [INFO] [stdout] 306 ~ if !self.midi_held_notes.iter().any(|(n, _, _)| *n == note) => { [INFO] [stdout] 307 | self.midi_held_notes.push((note, velocity, channel)); [INFO] [stdout] 308 | notes_changed = true; [INFO] [stdout] 309 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/app/synth_app.rs:320:25 [INFO] [stdout] | [INFO] [stdout] 320 | / if self.midi_aftertouch != pressure { [INFO] [stdout] 321 | | self.midi_aftertouch = pressure; [INFO] [stdout] 322 | | notes_changed = true; [INFO] [stdout] 323 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 318 ~ MidiEvent::ChannelPressure { pressure, .. } [INFO] [stdout] 319 | // Update aftertouch [INFO] [stdout] 320 ~ if self.midi_aftertouch != pressure => { [INFO] [stdout] 321 | self.midi_aftertouch = pressure; [INFO] [stdout] 322 | notes_changed = true; [INFO] [stdout] 323 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/app/synth_app.rs:1170:38 [INFO] [stdout] | [INFO] [stdout] 1170 | let in_submenu = submenu_rect.map_or(false, |r| r.contains(pos)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1170 - let in_submenu = submenu_rect.map_or(false, |r| r.contains(pos)); [INFO] [stdout] 1170 + let in_submenu = submenu_rect.is_some_and(|r| r.contains(pos)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/app/synth_app.rs:2201:29 [INFO] [stdout] | [INFO] [stdout] 2201 | .map(|(rel, _)| relative_to_midi(*rel, 0) as u8) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `relative_to_midi(*rel, 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> src/app/theme.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | assert!(node::PORT_RADIUS > 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> src/app/theme.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | assert!(cable::THICKNESS > 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> src/app/theme.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 290 | assert!(cable::GLOW_RADIUS > cable::THICKNESS); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> src/app/theme.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | assert!(GRID_SPACING >= 10.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion has a constant value [INFO] [stdout] --> src/app/theme.rs:296:9 [INFO] [stdout] | [INFO] [stdout] 296 | assert!(GRID_SPACING <= 50.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider moving this into a const block: `const { assert!(..) }` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> src/dsp/smoothed_value.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | / pub fn next(&mut self) -> f32 { [INFO] [stdout] ... | [INFO] [stdout] 118 | | self.current [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/engine/audio_engine.rs:342:28 [INFO] [stdout] | [INFO] [stdout] 342 | if fails % 1000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `fails.is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/engine/audio_graph.rs:868:5 [INFO] [stdout] | [INFO] [stdout] 868 | / impl Default for TestOutput { [INFO] [stdout] 869 | | fn default() -> Self { [INFO] [stdout] 870 | | Self { received: Vec::new() } [INFO] [stdout] 871 | | } [INFO] [stdout] 872 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 864 ~ #[derive(Default)] [INFO] [stdout] 865 ~ struct TestOutput { [INFO] [stdout] 866 | received: Vec, [INFO] [stdout] 867 | } [INFO] [stdout] 868 | [INFO] [stdout] 869 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/engine/audio_graph.rs:1089:47 [INFO] [stdout] | [INFO] [stdout] 1089 | graph.add_module_instance(2, Box::new(TestPassthrough::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 1089 - graph.add_module_instance(2, Box::new(TestPassthrough::default())); [INFO] [stdout] 1089 + graph.add_module_instance(2, Box::new(TestPassthrough)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/engine/audio_graph.rs:1128:47 [INFO] [stdout] | [INFO] [stdout] 1128 | graph.add_module_instance(2, Box::new(TestPassthrough::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 1128 - graph.add_module_instance(2, Box::new(TestPassthrough::default())); [INFO] [stdout] 1128 + graph.add_module_instance(2, Box::new(TestPassthrough)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/engine/audio_graph.rs:1151:47 [INFO] [stdout] | [INFO] [stdout] 1151 | graph.add_module_instance(1, Box::new(TestPassthrough::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 1151 - graph.add_module_instance(1, Box::new(TestPassthrough::default())); [INFO] [stdout] 1151 + graph.add_module_instance(1, Box::new(TestPassthrough)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/engine/audio_graph.rs:1152:47 [INFO] [stdout] | [INFO] [stdout] 1152 | graph.add_module_instance(2, Box::new(TestPassthrough::default())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 1152 - graph.add_module_instance(2, Box::new(TestPassthrough::default())); [INFO] [stdout] 1152 + graph.add_module_instance(2, Box::new(TestPassthrough)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/graph/node_data.rs:1519:29 [INFO] [stdout] | [INFO] [stdout] 1519 | let base_note = (60 + octave_shift * 12).max(0).min(127) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(60 + octave_shift * 12).clamp(0, 127)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/graph/node_data.rs:1573:29 [INFO] [stdout] | [INFO] [stdout] 1573 | let base_note = (60 + octave_shift * 12).max(0).min(127) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(60 + octave_shift * 12).clamp(0, 127)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/modules/chorus.rs:319:33 [INFO] [stdout] | [INFO] [stdout] 319 | let max_delay_samples = (MAX_DELAY_SECONDS * self.sample_rate) as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(MAX_DELAY_SECONDS * self.sample_rate)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/modules/clock.rs:345:24 [INFO] [stdout] | [INFO] [stdout] 345 | let has_high = outputs[0].samples.iter().any(|&s| s == 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `outputs[0].samples.contains(&1.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/modules/clock.rs:346:23 [INFO] [stdout] | [INFO] [stdout] 346 | let has_low = outputs[0].samples.iter().any(|&s| s == 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `outputs[0].samples.contains(&0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/modules/clock.rs:384:34 [INFO] [stdout] | [INFO] [stdout] 384 | (high_count as i32 - expected as i32).abs() < tolerance, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/modules/clock.rs:413:34 [INFO] [stdout] | [INFO] [stdout] 413 | (high_count as i32 - expected as i32).abs() < tolerance, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/clock.rs:447:13 [INFO] [stdout] | [INFO] [stdout] 447 | rising_edges >= 3 && rising_edges <= 5, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(3..=5).contains(&rising_edges)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/clock.rs:558:13 [INFO] [stdout] | [INFO] [stdout] 558 | rising_edges >= 18 && rising_edges <= 22, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(18..=22).contains(&rising_edges)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `all_outputs` [INFO] [stdout] --> src/modules/delay.rs:556:18 [INFO] [stdout] | [INFO] [stdout] 556 | for i in search_start..search_end { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 556 - for i in search_start..search_end { [INFO] [stdout] 556 + for in all_outputs.iter().take(search_end).skip(search_start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/envelope.rs:625:17 [INFO] [stdout] | [INFO] [stdout] 625 | sample >= 0.0 && sample <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/modules/filter.rs:239:13 [INFO] [stdout] | [INFO] [stdout] 239 | self.low = self.low + f * self.band; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.low += f * self.band` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/modules/filter.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | self.band = f * high + self.band; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.band += f * high` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/filter.rs:369:21 [INFO] [stdout] | [INFO] [stdout] 369 | sample >= -2.0 && sample <= 2.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-2.0..=2.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/lfo.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 397 | sample >= -1.0 && sample <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-1.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/lfo.rs:418:17 [INFO] [stdout] | [INFO] [stdout] 418 | sample >= 0.0 && sample <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/lfo.rs:517:13 [INFO] [stdout] | [INFO] [stdout] 517 | zero_crossings >= 1 && zero_crossings <= 3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=3).contains(&zero_crossings)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/lfo.rs:629:13 [INFO] [stdout] | [INFO] [stdout] 629 | zero_crossings >= 95 && zero_crossings <= 105, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(95..=105).contains(&zero_crossings)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/modules/mixer.rs:182:22 [INFO] [stdout] | [INFO] [stdout] 182 | x.signum() * (1.0 + (1.0 - (x.abs() - 1.0).min(1.0) * 0.5)) [INFO] [stdout] | ______________________^ [INFO] [stdout] 183 | | .min(1.5) [INFO] [stdout] 184 | | .max(1.0) [INFO] [stdout] | |_____________________^ help: replace with clamp: `(1.0 + (1.0 - (x.abs() - 1.0).min(1.0) * 0.5)).clamp(1.0, 1.5)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/modules/oscillator.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 233 | / let value = if phase < 0.5 { [INFO] [stdout] 234 | | 4.0 * phase - 1.0 [INFO] [stdout] 235 | | } else { [INFO] [stdout] 236 | | 3.0 - 4.0 * phase [INFO] [stdout] 237 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 238 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 233 ~ [INFO] [stdout] 234 ~ if phase < 0.5 { [INFO] [stdout] 235 + 4.0 * phase - 1.0 [INFO] [stdout] 236 + } else { [INFO] [stdout] 237 + 3.0 - 4.0 * phase [INFO] [stdout] 238 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/oscillator.rs:489:17 [INFO] [stdout] | [INFO] [stdout] 489 | sample >= -1.0 && sample <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-1.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/oscillator.rs:545:17 [INFO] [stdout] | [INFO] [stdout] 545 | sample >= -1.1 && sample <= 1.1, // Small tolerance for PolyBLEP overshoot [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-1.1..=1.1).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/oscillator.rs:597:17 [INFO] [stdout] | [INFO] [stdout] 597 | sample >= -1.0 && sample <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-1.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/oscillator.rs:666:21 [INFO] [stdout] | [INFO] [stdout] 666 | assert!(sample >= -1.1 && sample <= 1.1, "Sample out of range"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-1.1..=1.1).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/modules/oscillator.rs:722:17 [INFO] [stdout] | [INFO] [stdout] 722 | sample >= -1.0 && sample <= 1.0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-1.0..=1.0).contains(&sample)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `out_buf` [INFO] [stdout] --> src/modules/output.rs:327:18 [INFO] [stdout] | [INFO] [stdout] 327 | for i in 200..256 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 327 - for i in 200..256 { [INFO] [stdout] 327 + for (i, ) in out_buf.iter().enumerate().take(256).skip(200) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `out_buf` [INFO] [stdout] --> src/modules/output.rs:372:18 [INFO] [stdout] | [INFO] [stdout] 372 | for i in 200..256 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 372 - for i in 200..256 { [INFO] [stdout] 372 + for (i, ) in out_buf.iter().enumerate().take(256).skip(200) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `out_buf` [INFO] [stdout] --> src/modules/output.rs:416:18 [INFO] [stdout] | [INFO] [stdout] 416 | for i in 200..256 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 416 - for i in 200..256 { [INFO] [stdout] 416 + for (i, ) in out_buf.iter().enumerate().take(256).skip(200) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `out_buf` [INFO] [stdout] --> src/modules/output.rs:450:18 [INFO] [stdout] | [INFO] [stdout] 450 | for i in 200..256 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 450 - for i in 200..256 { [INFO] [stdout] 450 + for in out_buf.iter().take(256).skip(200) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `out_buf` [INFO] [stdout] --> src/modules/output.rs:478:18 [INFO] [stdout] | [INFO] [stdout] 478 | for i in 200..256 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 478 - for i in 200..256 { [INFO] [stdout] 478 + for in out_buf.iter().take(256).skip(200) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `out_buf` [INFO] [stdout] --> src/modules/output.rs:511:18 [INFO] [stdout] | [INFO] [stdout] 511 | for i in 200..256 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 511 - for i in 200..256 { [INFO] [stdout] 511 + for in out_buf.iter().take(256).skip(200) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/widgets/fader.rs:219:53 [INFO] [stdout] | [INFO] [stdout] 219 | draw_scale_markers(painter, track_rect, &config); [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/widgets/waveform_display.rs:536:1 [INFO] [stdout] | [INFO] [stdout] 536 | / impl Default for WaveformType { [INFO] [stdout] 537 | | fn default() -> Self { [INFO] [stdout] 538 | | WaveformType::Sine [INFO] [stdout] 539 | | } [INFO] [stdout] 540 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 523 + #[derive(Default)] [INFO] [stdout] 524 | pub enum WaveformType { [INFO] [stdout] 525 | /// Sine wave [INFO] [stdout] 526 ~ #[default] [INFO] [stdout] 527 ~ Sine, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/widgets/waveform_display.rs:638:21 [INFO] [stdout] | [INFO] [stdout] 638 | assert!(s >= -1.0 && s <= 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(-1.0..=1.0).contains(&s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/widgets/waveform_display.rs:658:17 [INFO] [stdout] | [INFO] [stdout] 658 | assert!(positive_count >= 40 && positive_count <= 60); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(40..=60).contains(&positive_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/widgets/waveform_display.rs:680:17 [INFO] [stdout] | [INFO] [stdout] 680 | assert!(peak_idx >= 20 && peak_idx <= 30); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=30).contains(&peak_idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/widgets/waveform_display.rs:689:17 [INFO] [stdout] | [INFO] [stdout] 689 | assert!(positive_count >= 20 && positive_count <= 30); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=30).contains(&positive_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `Command { std: "docker" "inspect" "b5c8938da0f065933f360dc06c126e150b32f7d4717a1e68409719892c641d25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5c8938da0f065933f360dc06c126e150b32f7d4717a1e68409719892c641d25", kill_on_drop: false }` [INFO] [stdout] b5c8938da0f065933f360dc06c126e150b32f7d4717a1e68409719892c641d25