[INFO] cloning repository https://github.com/choudhary463/rocpp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/choudhary463/rocpp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchoudhary463%2Frocpp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchoudhary463%2Frocpp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 21c0fedb3aed90643becdb4d1cb71ec551979fa5 [INFO] linting choudhary463/rocpp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchoudhary463%2Frocpp" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/choudhary463/rocpp [INFO] finished tweaking git repo https://github.com/choudhary463/rocpp [INFO] tweaked toml for git repo https://github.com/choudhary463/rocpp written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/choudhary463/rocpp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/choudhary463/rocpp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded uptime_lib v0.3.1 [INFO] [stderr] Downloaded tokio v1.45.0 [INFO] [stderr] Downloaded humantime v2.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8968a5aed4f625fd8345f61f9344fd157299f28e440a135f7ccdae7bf762ffa [INFO] running `Command { std: "docker" "start" "-a" "e8968a5aed4f625fd8345f61f9344fd157299f28e440a135f7ccdae7bf762ffa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8968a5aed4f625fd8345f61f9344fd157299f28e440a135f7ccdae7bf762ffa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8968a5aed4f625fd8345f61f9344fd157299f28e440a135f7ccdae7bf762ffa", kill_on_drop: false }` [INFO] [stdout] e8968a5aed4f625fd8345f61f9344fd157299f28e440a135f7ccdae7bf762ffa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b40917f0471275a441fad02d044777f83b7a9cbb12bec7584e75f6533ec6fb1e [INFO] running `Command { std: "docker" "start" "-a" "b40917f0471275a441fad02d044777f83b7a9cbb12bec7584e75f6533ec6fb1e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tokio v1.45.0 [INFO] [stderr] Checking uptime_lib v0.3.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking rocpp_core v1.0.0 (/opt/rustwide/workdir/ocpp-core) [INFO] [stderr] Checking rocpp_client v1.0.1 (/opt/rustwide/workdir/ocpp-client) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/state_machine/auth.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | Self::Upsert { id_tag, .. } => &id_tag, [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/state_machine/auth.rs:18:40 [INFO] [stdout] | [INFO] [stdout] 18 | Self::Delete { id_tag } => &id_tag, [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/src/v16/state_machine/auth.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - self.interface.db_update_cache(&id_tag, info).await; [INFO] [stdout] 57 - return; [INFO] [stdout] 56 + self.interface.db_update_cache(&id_tag, info).await; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> ocpp-client/src/v16/state_machine/clock.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | base_dt + Duration::from_micros(t.duration_since(base_instant).0 as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t.duration_since(base_instant).0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> ocpp-client/src/v16/state_machine/connector.rs:287:17 [INFO] [stdout] | [INFO] [stdout] 287 | / if previous_status != status { [INFO] [stdout] 288 | | self.stabilize(connector_id, previous_status).await; [INFO] [stdout] 289 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 286 ~ StatusNotificationState::Idle [INFO] [stdout] 287 ~ if previous_status != status => { [INFO] [stdout] 288 | self.stabilize(connector_id, previous_status).await; [INFO] [stdout] 289 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> ocpp-client/src/v16/state_machine/transaction.rs:215:48 [INFO] [stdout] | [INFO] [stdout] 215 | ... let meter_tx = self [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 216 | | ... .transaction_stop_meter_val_count [INFO] [stdout] 217 | | ... .get(&t.local_transaction_id) [INFO] [stdout] 218 | | ... .map(|f| *f) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 215 ~ let meter_tx = self [INFO] [stdout] 216 + .transaction_stop_meter_val_count [INFO] [stdout] 217 + .get(&t.local_transaction_id).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> ocpp-client/src/v16/state_machine/config.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | pub validator: Option bool + Send>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> ocpp-client/src/v16/state_machine/config.rs:309:29 [INFO] [stdout] | [INFO] [stdout] 309 | fn format_meter_data(v: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 309 - fn format_meter_data(v: &Vec) -> String { [INFO] [stdout] 309 + fn format_meter_data(v: &[MeterDataType]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ready()` [INFO] [stdout] --> ocpp-client/src/v16/cp.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 172 | if let Poll::Ready(_) = cp.interface.interface.poll_reset(cx) { [INFO] [stdout] | -------^^^^^^^^^^^^^^---------------------------------------- help: try: `if cp.interface.interface.poll_reset(cx).is_ready()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> ocpp-client/src/v16/cp.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 198 | / match &cp.diagnostics_state { [INFO] [stdout] 199 | | DiagnosticsState::Uploading(_) => { [INFO] [stdout] 200 | | if let Poll::Ready(res) = cp.interface.interface.poll_diagnostics_upload(cx) [INFO] [stdout] ... | [INFO] [stdout] 205 | | _ => {} [INFO] [stdout] 206 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 198 ~ if let DiagnosticsState::Uploading(_) = &cp.diagnostics_state { [INFO] [stdout] 199 + if let Poll::Ready(res) = cp.interface.interface.poll_diagnostics_upload(cx) [INFO] [stdout] 200 + { [INFO] [stdout] 201 + return Poll::Ready(ChargePointEvent::Diagnostics(res)); [INFO] [stdout] 202 + } [INFO] [stdout] 203 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> ocpp-client/src/v16/cp.rs:283:17 [INFO] [stdout] | [INFO] [stdout] 283 | / match &cp.diagnostics_state { [INFO] [stdout] 284 | | DiagnosticsState::Uploading(_) => { [INFO] [stdout] 285 | | let res = [INFO] [stdout] 286 | | poll_fn(|cx| cp.interface.interface.poll_diagnostics_upload(cx)).await; [INFO] [stdout] ... | [INFO] [stdout] 289 | | _ => {} [INFO] [stdout] 290 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ if let DiagnosticsState::Uploading(_) = &cp.diagnostics_state { [INFO] [stdout] 284 + let res = [INFO] [stdout] 285 + poll_fn(|cx| cp.interface.interface.poll_diagnostics_upload(cx)).await; [INFO] [stdout] 286 + cp.handle_diagnostics_response(res).await; [INFO] [stdout] 287 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ocpp-client/src/v16/events/ocpp/request/send_local_list.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | ... if !self [INFO] [stdout] | __________________________^ [INFO] [stdout] 54 | | ... .interface [INFO] [stdout] 55 | | ... .db_get_from_local_list(&id_tag) [INFO] [stdout] 56 | | ... .await [INFO] [stdout] 57 | | ... .is_some() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ if self [INFO] [stdout] 54 + .interface [INFO] [stdout] 55 + .db_get_from_local_list(&id_tag) [INFO] [stdout] 56 + .await.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ocpp-client/src/v16/events/ocpp/request/send_local_list.rs:67:32 [INFO] [stdout] | [INFO] [stdout] 67 | ... if !self [INFO] [stdout] | __________________________^ [INFO] [stdout] 68 | | ... .interface [INFO] [stdout] 69 | | ... .db_get_from_local_list(&id_tag) [INFO] [stdout] 70 | | ... .await [INFO] [stdout] 71 | | ... .is_some() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 ~ if self [INFO] [stdout] 68 + .interface [INFO] [stdout] 69 + .db_get_from_local_list(&id_tag) [INFO] [stdout] 70 + .await.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> ocpp-client/src/v16/events/ocpp/response/stop_transaction.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | let meter_tx = self [INFO] [stdout] | ________________________^ [INFO] [stdout] 21 | | .transaction_stop_meter_val_count [INFO] [stdout] 22 | | .get(&local_transaction_id) [INFO] [stdout] 23 | | .map(|f| *f) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 20 ~ let meter_tx = self [INFO] [stdout] 21 + .transaction_stop_meter_val_count [INFO] [stdout] 22 + .get(&local_transaction_id).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TimerId` which implements the `Copy` trait [INFO] [stdout] --> ocpp-client/src/v16/events/timeouts.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | self.remove_timeout(id.clone()).await; [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:87:64 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|f| serde_json::from_str::(&f.1).unwrap()) [INFO] [stdout] | ^^^^ help: change this to: `f.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:98:69 [INFO] [stdout] | [INFO] [stdout] 98 | let kind = serde_json::from_str::(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `connector_id` is used to index `connector_state` [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 141 | for connector_id in 0..num_connectors { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 141 - for connector_id in 0..num_connectors { [INFO] [stdout] 141 + for (connector_id, ) in connector_state.iter().enumerate().take(num_connectors) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:186:70 [INFO] [stdout] | [INFO] [stdout] 186 | let event = serde_json::from_str::(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:216:28 [INFO] [stdout] | [INFO] [stdout] 216 | let (tail, head) = events [INFO] [stdout] | ____________________________^ [INFO] [stdout] 217 | | .first() [INFO] [stdout] 218 | | .map(|x| *x) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 216 ~ let (tail, head) = events [INFO] [stdout] 217 + .first().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:234:46 [INFO] [stdout] | [INFO] [stdout] 234 | let state = serde_json::from_str(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:246:30 [INFO] [stdout] | [INFO] [stdout] 246 | .db_get("cache", &id_tag) [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:278:35 [INFO] [stdout] | [INFO] [stdout] 278 | .db_get("local_list", &id_tag) [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/state_machine/auth.rs:17:44 [INFO] [stdout] | [INFO] [stdout] 17 | Self::Upsert { id_tag, .. } => &id_tag, [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/state_machine/auth.rs:18:40 [INFO] [stdout] | [INFO] [stdout] 18 | Self::Delete { id_tag } => &id_tag, [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/src/v16/state_machine/auth.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - self.interface.db_update_cache(&id_tag, info).await; [INFO] [stdout] 57 - return; [INFO] [stdout] 56 + self.interface.db_update_cache(&id_tag, info).await; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> ocpp-client/src/v16/state_machine/clock.rs:35:45 [INFO] [stdout] | [INFO] [stdout] 35 | base_dt + Duration::from_micros(t.duration_since(base_instant).0 as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t.duration_since(base_instant).0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> ocpp-client/src/v16/state_machine/connector.rs:287:17 [INFO] [stdout] | [INFO] [stdout] 287 | / if previous_status != status { [INFO] [stdout] 288 | | self.stabilize(connector_id, previous_status).await; [INFO] [stdout] 289 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 286 ~ StatusNotificationState::Idle [INFO] [stdout] 287 ~ if previous_status != status => { [INFO] [stdout] 288 | self.stabilize(connector_id, previous_status).await; [INFO] [stdout] 289 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> ocpp-client/src/v16/state_machine/transaction.rs:215:48 [INFO] [stdout] | [INFO] [stdout] 215 | ... let meter_tx = self [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 216 | | ... .transaction_stop_meter_val_count [INFO] [stdout] 217 | | ... .get(&t.local_transaction_id) [INFO] [stdout] 218 | | ... .map(|f| *f) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 215 ~ let meter_tx = self [INFO] [stdout] 216 + .transaction_stop_meter_val_count [INFO] [stdout] 217 + .get(&t.local_transaction_id).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> ocpp-client/src/v16/state_machine/config.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | pub validator: Option bool + Send>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> ocpp-client/src/v16/state_machine/config.rs:309:29 [INFO] [stdout] | [INFO] [stdout] 309 | fn format_meter_data(v: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 309 - fn format_meter_data(v: &Vec) -> String { [INFO] [stdout] 309 + fn format_meter_data(v: &[MeterDataType]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ready()` [INFO] [stdout] --> ocpp-client/src/v16/cp.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 172 | if let Poll::Ready(_) = cp.interface.interface.poll_reset(cx) { [INFO] [stdout] | -------^^^^^^^^^^^^^^---------------------------------------- help: try: `if cp.interface.interface.poll_reset(cx).is_ready()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> ocpp-client/src/v16/cp.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 198 | / match &cp.diagnostics_state { [INFO] [stdout] 199 | | DiagnosticsState::Uploading(_) => { [INFO] [stdout] 200 | | if let Poll::Ready(res) = cp.interface.interface.poll_diagnostics_upload(cx) [INFO] [stdout] ... | [INFO] [stdout] 205 | | _ => {} [INFO] [stdout] 206 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 198 ~ if let DiagnosticsState::Uploading(_) = &cp.diagnostics_state { [INFO] [stdout] 199 + if let Poll::Ready(res) = cp.interface.interface.poll_diagnostics_upload(cx) [INFO] [stdout] 200 + { [INFO] [stdout] 201 + return Poll::Ready(ChargePointEvent::Diagnostics(res)); [INFO] [stdout] 202 + } [INFO] [stdout] 203 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> ocpp-client/src/v16/cp.rs:283:17 [INFO] [stdout] | [INFO] [stdout] 283 | / match &cp.diagnostics_state { [INFO] [stdout] 284 | | DiagnosticsState::Uploading(_) => { [INFO] [stdout] 285 | | let res = [INFO] [stdout] 286 | | poll_fn(|cx| cp.interface.interface.poll_diagnostics_upload(cx)).await; [INFO] [stdout] ... | [INFO] [stdout] 289 | | _ => {} [INFO] [stdout] 290 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ if let DiagnosticsState::Uploading(_) = &cp.diagnostics_state { [INFO] [stdout] 284 + let res = [INFO] [stdout] 285 + poll_fn(|cx| cp.interface.interface.poll_diagnostics_upload(cx)).await; [INFO] [stdout] 286 + cp.handle_diagnostics_response(res).await; [INFO] [stdout] 287 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ocpp-client/src/v16/events/ocpp/request/send_local_list.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | ... if !self [INFO] [stdout] | __________________________^ [INFO] [stdout] 54 | | ... .interface [INFO] [stdout] 55 | | ... .db_get_from_local_list(&id_tag) [INFO] [stdout] 56 | | ... .await [INFO] [stdout] 57 | | ... .is_some() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ if self [INFO] [stdout] 54 + .interface [INFO] [stdout] 55 + .db_get_from_local_list(&id_tag) [INFO] [stdout] 56 + .await.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> ocpp-client/src/v16/events/ocpp/request/send_local_list.rs:67:32 [INFO] [stdout] | [INFO] [stdout] 67 | ... if !self [INFO] [stdout] | __________________________^ [INFO] [stdout] 68 | | ... .interface [INFO] [stdout] 69 | | ... .db_get_from_local_list(&id_tag) [INFO] [stdout] 70 | | ... .await [INFO] [stdout] 71 | | ... .is_some() [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 ~ if self [INFO] [stdout] 68 + .interface [INFO] [stdout] 69 + .db_get_from_local_list(&id_tag) [INFO] [stdout] 70 + .await.is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> ocpp-client/src/v16/events/ocpp/response/stop_transaction.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | let meter_tx = self [INFO] [stdout] | ________________________^ [INFO] [stdout] 21 | | .transaction_stop_meter_val_count [INFO] [stdout] 22 | | .get(&local_transaction_id) [INFO] [stdout] 23 | | .map(|f| *f) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 20 ~ let meter_tx = self [INFO] [stdout] 21 + .transaction_stop_meter_val_count [INFO] [stdout] 22 + .get(&local_transaction_id).copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TimerId` which implements the `Copy` trait [INFO] [stdout] --> ocpp-client/src/v16/events/timeouts.rs:22:29 [INFO] [stdout] | [INFO] [stdout] 22 | self.remove_timeout(id.clone()).await; [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_005_2_cs.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | connector_id: connector_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_005_3_cs.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_008_cs.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_010_cs.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_023_cs.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | id_tag_info: id_tag_info [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id_tag_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_031_cs.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | connector_id: connector_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_037_1_cs.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_037_2_cs.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_037_3_cs.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_039_cs.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_1_cs.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | id_tag: id_tag, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_3_cs.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | id_tag: id_tag, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_046_1_cs.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_046_2_cs.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | id_tag_info: id_tag_info, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id_tag_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_046_2_cs.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_047_cs.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | id_tag_info: id_tag_info, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id_tag_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_047_cs.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_051_cs.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_052_cs.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | id_tag: id_tag, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/conformance/tc_053_cs.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | transaction_id: transaction_id [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:87:64 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|f| serde_json::from_str::(&f.1).unwrap()) [INFO] [stdout] | ^^^^ help: change this to: `f.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:98:69 [INFO] [stdout] | [INFO] [stdout] 98 | let kind = serde_json::from_str::(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `connector_id` is used to index `connector_state` [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 141 | for connector_id in 0..num_connectors { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 141 - for connector_id in 0..num_connectors { [INFO] [stdout] 141 + for (connector_id, ) in connector_state.iter().enumerate().take(num_connectors) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:186:70 [INFO] [stdout] | [INFO] [stdout] 186 | let event = serde_json::from_str::(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:216:28 [INFO] [stdout] | [INFO] [stdout] 216 | let (tail, head) = events [INFO] [stdout] | ____________________________^ [INFO] [stdout] 217 | | .first() [INFO] [stdout] 218 | | .map(|x| *x) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 216 ~ let (tail, head) = events [INFO] [stdout] 217 + .first().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:234:46 [INFO] [stdout] | [INFO] [stdout] 234 | let state = serde_json::from_str(&value).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:246:30 [INFO] [stdout] | [INFO] [stdout] 246 | .db_get("cache", &id_tag) [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> ocpp-client/tests/state/reusable_states.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | expected_connector_state: expected_connector_state, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_connector_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> ocpp-client/src/v16/interfaces/backend.rs:278:35 [INFO] [stdout] | [INFO] [stdout] 278 | .db_get("local_list", &id_tag) [INFO] [stdout] | ^^^^^^^ help: change this to: `id_tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_003_cs.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_004_1_cs.rs:7:18 [INFO] [stdout] | [INFO] [stdout] 7 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_004_2_cs.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_005_2_cs.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_005_3_cs.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_007_cs.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_008_cs.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 23 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_010_cs.rs:103:18 [INFO] [stdout] | [INFO] [stdout] 103 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> ocpp-client/tests/conformance/tc_011_1_cs.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 57 | / let chain = test_chain!( [INFO] [stdout] 58 | | chain, [INFO] [stdout] 59 | | plug(connector_id), [INFO] [stdout] 60 | | await_ws_msg(StatusNotificationRequest { [INFO] [stdout] ... | [INFO] [stdout] 79 | | any_order(2), [INFO] [stdout] 80 | | ); [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 81 | [INFO] [stdout] 82 | chain [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 57 ~ [INFO] [stdout] 58 | [INFO] [stdout] 59 ~ $start.any_order($n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_011_1_cs.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> ocpp-client/tests/conformance/tc_011_2_cs.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 55 | / let res = test_chain!( [INFO] [stdout] 56 | | res, [INFO] [stdout] 57 | | await_ws_msg(StatusNotificationRequest { [INFO] [stdout] 58 | | connector_id: connector_id, [INFO] [stdout] ... | [INFO] [stdout] 66 | | respond(StatusNotificationResponse {}), [INFO] [stdout] 67 | | ); [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 68 | [INFO] [stdout] 69 | res [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 | [INFO] [stdout] 57 ~ $start.respond($payload) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_011_2_cs.rs:90:18 [INFO] [stdout] | [INFO] [stdout] 90 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_012_cs.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_015_cs.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_016_cs.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_018_2_cs.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> ocpp-client/tests/conformance/tc_021_cs.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | if value != "10".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `"10"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_023_cs.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_026_cs.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | let id_tag1 = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_026_cs.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 18 | let id_tag2 = format!("2345"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_027_cs.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 16 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_028_cs.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_032_2_cs.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 15 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_036_cs.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 23 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_037_1_cs.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 23 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_037_2_cs.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 23 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_037_3_cs.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 24 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_038_cs.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_039_cs.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 20 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_040_1_cs.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | key: format!("Testing"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Testing".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_040_1_cs.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | value: format!("true") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"true".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_040_2_cs.rs:17:18 [INFO] [stdout] | [INFO] [stdout] 17 | key: format!("MeterValueSampleInterval"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"MeterValueSampleInterval".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_040_2_cs.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | value: format!("-1") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-1".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_041_cs.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_1_cs.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_2_cs.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | id_tag: format!("1234"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_2_cs.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | id_tag: format!("2345"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_2_cs.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 37 | id_tag: format!("2345"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_2_cs.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | id_tag: format!("2345"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_3_cs.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_cs.rs:15:21 [INFO] [stdout] | [INFO] [stdout] 15 | id_tag: format!("1234"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_cs.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | id_tag: format!("2345"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_043_cs.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | id_tag: format!("2345"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_044_1_cs.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let location = format!("download_success:install:success"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"download_success:install:success".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_044_2_cs.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let location = format!("download_fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"download_fail".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_044_3_cs.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let location = format!("download_success:install:fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"download_success:install:fail".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_045_1_cs.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | let location = format!("valid_location"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"valid_location".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_045_2_cs.rs:18:20 [INFO] [stdout] | [INFO] [stdout] 18 | let location = format!("invalid_location"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"invalid_location".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_046_1_cs.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | let id_tag1 = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_046_1_cs.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | let id_tag2 = format!("2345"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_046_2_cs.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 24 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_047_cs.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 24 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_048_1_cs.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_048_2_cs.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_048_3_cs.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_051_cs.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | let id_tag1 = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_051_cs.rs:26:19 [INFO] [stdout] | [INFO] [stdout] 26 | let id_tag2 = format!("2345"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_052_cs.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_053_cs.rs:21:19 [INFO] [stdout] | [INFO] [stdout] 21 | let id_tag1 = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_053_cs.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | let id_tag2 = format!("2345"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_053_cs.rs:26:29 [INFO] [stdout] | [INFO] [stdout] 26 | parent_id_tag: Some(format!("parent")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"parent".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_053_cs.rs:39:33 [INFO] [stdout] | [INFO] [stdout] 39 | parent_id_tag: Some(format!("parent")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"parent".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_061_cs.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 18 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_062_cs.rs:17:24 [INFO] [stdout] | [INFO] [stdout] 17 | vendor_id: format!("vendor"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"vendor".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_062_cs.rs:26:26 [INFO] [stdout] | [INFO] [stdout] 26 | .then(|| format!("DataTransferStatus::Accepted was not expected")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"DataTransferStatus::Accepted was not expected".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_068_cs.rs:19:18 [INFO] [stdout] | [INFO] [stdout] 19 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_068_cs.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | let id_tag2 = format!("2345"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_069_cs.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | let id_tag1 = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_069_cs.rs:23:29 [INFO] [stdout] | [INFO] [stdout] 23 | parent_id_tag: Some(format!("parent")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"parent".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_069_cs.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 27 | let id_tag2 = format!("2345"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"2345".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_069_cs.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | parent_id_tag: Some(format!("parent")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"parent".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_070_cs.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_070_cs.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | format!("Energy.Active.Import.Register") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Energy.Active.Import.Register".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_071_cs.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | let id_tag = format!("1234"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"1234".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/conformance/tc_071_cs.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | format!("Energy.Active.Import.Register") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Energy.Active.Import.Register".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/harness/diagnostics.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | let res = location == format!("valid_location"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"valid_location".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> ocpp-client/tests/harness/diagnostics.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | let res = res [INFO] [stdout] | ___________________^ [INFO] [stdout] 42 | | .then(|| DiagnosticsResponse::Success) [INFO] [stdout] 43 | | .unwrap_or(DiagnosticsResponse::Failed); [INFO] [stdout] | |___________________________________________________^ help: try: `if res { DiagnosticsResponse::Success } else { DiagnosticsResponse::Failed }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] = note: `#[warn(clippy::obfuscated_if_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> ocpp-client/tests/harness/diagnostics.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | let res = res [INFO] [stdout] | ___________________^ [INFO] [stdout] 42 | | .then(|| DiagnosticsResponse::Success) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 42 - .then(|| DiagnosticsResponse::Success) [INFO] [stdout] 42 + .then_some(DiagnosticsResponse::Success) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/harness/firmware.rs:24:39 [INFO] [stdout] | [INFO] [stdout] 24 | let download = if location == format!("download_success:install:success") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"download_success:install:success".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/harness/firmware.rs:27:31 [INFO] [stdout] | [INFO] [stdout] 27 | } else if location == format!("download_success:install:fail") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"download_success:install:fail".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/harness/hardware.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / return Some(MeterData { [INFO] [stdout] 63 | | value: String::from("10"), [INFO] [stdout] 64 | | location: None, [INFO] [stdout] 65 | | unit: None, [INFO] [stdout] 66 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 ~ Some(MeterData { [INFO] [stdout] 63 + value: String::from("10"), [INFO] [stdout] 64 + location: None, [INFO] [stdout] 65 + unit: None, [INFO] [stdout] 66 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> ocpp-client/tests/harness/mod.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | pub mod harness; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/harness/harness.rs:85:29 [INFO] [stdout] | [INFO] [stdout] 85 | charge_point_model: format!("CP"), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CP".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> ocpp-client/tests/harness/harness.rs:87:30 [INFO] [stdout] | [INFO] [stdout] 87 | charge_point_vendor: format!("IDK"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"IDK".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method chain can be written more clearly with `if .. else ..` [INFO] [stdout] --> ocpp-client/tests/harness/harness.rs:142:25 [INFO] [stdout] | [INFO] [stdout] 142 | let event = res [INFO] [stdout] | _________________________^ [INFO] [stdout] 143 | | .is_ok() [INFO] [stdout] 144 | | .then(|| SeccEvents::HardReset) [INFO] [stdout] 145 | | .unwrap_or(SeccEvents::Crashed); [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#obfuscated_if_else [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 142 ~ let event = if res [INFO] [stdout] 143 ~ .is_ok() { SeccEvents::HardReset } else { SeccEvents::Crashed }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> ocpp-client/tests/harness/harness.rs:142:25 [INFO] [stdout] | [INFO] [stdout] 142 | let event = res [INFO] [stdout] | _________________________^ [INFO] [stdout] 143 | | .is_ok() [INFO] [stdout] 144 | | .then(|| SeccEvents::HardReset) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 144 - .then(|| SeccEvents::HardReset) [INFO] [stdout] 144 + .then_some(SeccEvents::HardReset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:71:25 [INFO] [stdout] | [INFO] [stdout] 71 | return self.next.take().map_or(StepResult::Done, StepResult::Next); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return self.next.take().map_or(StepResult::Done, StepResult::Next); [INFO] [stdout] 71 + self.next.take().map_or(StepResult::Done, StepResult::Next) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 73 | return StepResult::Pending; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return StepResult::Pending; [INFO] [stdout] 73 + StepResult::Pending [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | StepResult::Pending => return StepResult::Pending, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - StepResult::Pending => return StepResult::Pending, [INFO] [stdout] 76 + StepResult::Pending => StepResult::Pending, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | return StepResult::Pending; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return StepResult::Pending; [INFO] [stdout] 79 + StepResult::Pending [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:81:40 [INFO] [stdout] | [INFO] [stdout] 81 | StepResult::Fail(e) => return StepResult::Fail(e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - StepResult::Fail(e) => return StepResult::Fail(e), [INFO] [stdout] 81 + StepResult::Fail(e) => StepResult::Fail(e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:88:25 [INFO] [stdout] | [INFO] [stdout] 88 | return self.next.take().map_or(StepResult::Done, StepResult::Next); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return self.next.take().map_or(StepResult::Done, StepResult::Next); [INFO] [stdout] 88 + self.next.take().map_or(StepResult::Done, StepResult::Next) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:90:25 [INFO] [stdout] | [INFO] [stdout] 90 | return StepResult::Pending; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return StepResult::Pending; [INFO] [stdout] 90 + StepResult::Pending [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:93:27 [INFO] [stdout] | [INFO] [stdout] 93 | Err(e) => return StepResult::Fail(e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - Err(e) => return StepResult::Fail(e), [INFO] [stdout] 93 + Err(e) => StepResult::Fail(e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:109:25 [INFO] [stdout] | [INFO] [stdout] 109 | / return self [INFO] [stdout] 110 | | .next [INFO] [stdout] 111 | | .take() [INFO] [stdout] 112 | | .map_or(StartResult::Done, StartResult::Next); [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 ~ self [INFO] [stdout] 110 + .next [INFO] [stdout] 111 + .take() [INFO] [stdout] 112 ~ .map_or(StartResult::Done, StartResult::Next) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/any_order.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | return StartResult::Break; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return StartResult::Break; [INFO] [stdout] 114 + StartResult::Break [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> ocpp-client/tests/state/operation.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | op: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> ocpp-client/tests/state/reusable_states.rs:345:28 [INFO] [stdout] | [INFO] [stdout] 345 | let cfg = keys.into_iter().next().unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> ocpp-client/tests/state/reusable_states.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | / if value [INFO] [stdout] 448 | | .location [INFO] [stdout] 449 | | .as_ref() [INFO] [stdout] 450 | | .map(|t| *t == Location::Ev) [INFO] [stdout] ... | [INFO] [stdout] 464 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 451 ~ .unwrap_or(false) [INFO] [stdout] 452 ~ && value [INFO] [stdout] 453 | .measurand [INFO] [stdout] ... [INFO] [stdout] 461 | )); [INFO] [stdout] 462 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> ocpp-client/tests/state/ws_recv.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | validator: Option) -> AfterValidation + Send>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> ocpp-client/tests/state/ws_recv.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / return StepResult::Fail(anyhow!( [INFO] [stdout] 73 | | "expected WS msg {}", [INFO] [stdout] 74 | | std::any::type_name::().rsplit("::").next().unwrap() [INFO] [stdout] 75 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 ~ StepResult::Fail(anyhow!( [INFO] [stdout] 73 + "expected WS msg {}", [INFO] [stdout] 74 + std::any::type_name::().rsplit("::").next().unwrap() [INFO] [stdout] 75 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> ocpp-client/tests/state/ws_recv.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 83 | default_validations: Vec Option + Send>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.02s [INFO] running `Command { std: "docker" "inspect" "b40917f0471275a441fad02d044777f83b7a9cbb12bec7584e75f6533ec6fb1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b40917f0471275a441fad02d044777f83b7a9cbb12bec7584e75f6533ec6fb1e", kill_on_drop: false }` [INFO] [stdout] b40917f0471275a441fad02d044777f83b7a9cbb12bec7584e75f6533ec6fb1e