[INFO] cloning repository https://github.com/chjudge/password_store
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chjudge/password_store" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchjudge%2Fpassword_store", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchjudge%2Fpassword_store'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 1a2ee239c9888bab06635b1c1ddccb90c8b70faa
[INFO] linting chjudge/password_store against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchjudge%2Fpassword_store" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/chjudge/password_store
[INFO] finished tweaking git repo https://github.com/chjudge/password_store
[INFO] tweaked toml for git repo https://github.com/chjudge/password_store written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/chjudge/password_store on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/chjudge/password_store already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded block-buffer v0.10.3
[INFO] [stderr]   Downloaded digest v0.10.5
[INFO] [stderr]   Downloaded generic-array v0.14.6
[INFO] [stderr]   Downloaded cpufeatures v0.2.5
[INFO] [stderr]   Downloaded aho-corasick v0.7.19
[INFO] [stderr]   Downloaded regex v1.6.0
[INFO] [stderr]   Downloaded regex-syntax v0.6.27
[INFO] [stderr]   Downloaded libc v0.2.136
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 452bd8d82b6087cb625fe284a4b7f27faa76f80b04d7730bef42f8fba58eab10
[INFO] running `Command { std: "docker" "start" "-a" "452bd8d82b6087cb625fe284a4b7f27faa76f80b04d7730bef42f8fba58eab10", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "452bd8d82b6087cb625fe284a4b7f27faa76f80b04d7730bef42f8fba58eab10", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "452bd8d82b6087cb625fe284a4b7f27faa76f80b04d7730bef42f8fba58eab10", kill_on_drop: false }`
[INFO] [stdout] 452bd8d82b6087cb625fe284a4b7f27faa76f80b04d7730bef42f8fba58eab10
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f2fbefb405917d60397dc7fc2d62d9d488b5bc59b87c8d039cb9e3b3ad557da9
[INFO] running `Command { std: "docker" "start" "-a" "f2fbefb405917d60397dc7fc2d62d9d488b5bc59b87c8d039cb9e3b3ad557da9", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.136
[INFO] [stderr]     Checking cpufeatures v0.2.5
[INFO] [stderr]     Checking regex-syntax v0.6.27
[INFO] [stderr]     Checking base64 v0.13.1
[INFO] [stderr]    Compiling generic-array v0.14.6
[INFO] [stderr]     Checking aho-corasick v0.7.19
[INFO] [stderr]     Checking getrandom v0.2.8
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking regex v1.6.0
[INFO] [stderr]     Checking crypto-common v0.1.6
[INFO] [stderr]     Checking block-buffer v0.10.3
[INFO] [stderr]     Checking digest v0.10.5
[INFO] [stderr]     Checking sha2 v0.10.6
[INFO] [stderr]     Checking password_store v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/password_store.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use base64;
[INFO] [stdout]   | ^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/password_store.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 | /     return std::fs::read_to_string(PATH)
[INFO] [stdout] 16 | |         .unwrap_or("".to_string())
[INFO] [stdout] 17 | |         .split('\n')
[INFO] [stdout] 18 | |         .map(|x| x.to_string())
[INFO] [stdout] 19 | |         .collect();
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 ~     std::fs::read_to_string(PATH)
[INFO] [stdout] 16 +         .unwrap_or("".to_string())
[INFO] [stdout] 17 +         .split('\n')
[INFO] [stdout] 18 +         .map(|x| x.to_string())
[INFO] [stdout] 19 ~         .collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/password_store.rs:61:5
[INFO] [stdout]    |
[INFO] [stdout] 61 |     return base64::encode(hasher.finalize());
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 61 -     return base64::encode(hasher.finalize());
[INFO] [stdout] 61 +     base64::encode(hasher.finalize())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/password_store.rs:97:9
[INFO] [stdout]    |
[INFO] [stdout] 97 | ...   return user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -         return user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout] 97 +         user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/password_store.rs:94:12
[INFO] [stdout]    |
[INFO] [stdout] 94 |         if text == "" {return false};
[INFO] [stdout]    |            ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/password_store.rs:97:24
[INFO] [stdout]    |
[INFO] [stdout] 97 | ...   return user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `caps["user"]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/password_store.rs:97:112
[INFO] [stdout]    |
[INFO] [stdout] 97 | ..._owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `caps["pass"]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/password_store.rs:116:12
[INFO] [stdout]     |
[INFO] [stdout] 116 |         if &line == "" {continue};
[INFO] [stdout]     |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/password_store.rs:118:24
[INFO] [stdout]     |
[INFO] [stdout] 118 |             if user != caps["user"].to_string() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `caps["user"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:46:28
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^ help: try: `user.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:46:47
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                               ^^^^^^^^^^^^^^^^^^^ help: try: `password.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:62:28
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^ help: try: `user.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:62:47
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                               ^^^^^^^^^^^^^^^^^^^ help: try: `password.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:73:28
[INFO] [stdout]    |
[INFO] [stdout] 73 |                         if !user.is_none(){
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^ help: try: `user.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:47:49
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 47 |                             if user_re.is_match(user.unwrap()) {
[INFO] [stdout]    |                                                 ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:48:53
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 47 |                             if user_re.is_match(user.unwrap()) {
[INFO] [stdout] 48 |                                 password_store::add(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `password` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:48:79
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                                ------------------ the check is happening here
[INFO] [stdout] 47 |                             if user_re.is_match(user.unwrap()) {
[INFO] [stdout] 48 |                                 password_store::add(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                                               ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:64:51
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 63 |                             // validates the given password hashed matches the one in the file
[INFO] [stdout] 64 |                             password_store::check(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `password` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:64:77
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                                ------------------ the check is happening here
[INFO] [stdout] 63 |                             // validates the given password hashed matches the one in the file
[INFO] [stdout] 64 |                             password_store::check(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                                             ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:75:52
[INFO] [stdout]    |
[INFO] [stdout] 73 |                         if !user.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 74 |                             // removes the given user from file
[INFO] [stdout] 75 |                             password_store::remove(user.unwrap().to_owned())
[INFO] [stdout]    |                                                    ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]   --> src/Project2.rs:42:31
[INFO] [stdout]    |
[INFO] [stdout] 42 |                 let user_re = Regex::new(r"^[a-zA-Z_\-0-9]+$").unwrap();
[INFO] [stdout]    |                               ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]   --> src/Project2.rs:25:5
[INFO] [stdout]    |
[INFO] [stdout] 25 |     loop {
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]    = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.30s
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/password_store.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use base64;
[INFO] [stdout]   | ^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/password_store.rs:15:5
[INFO] [stdout]    |
[INFO] [stdout] 15 | /     return std::fs::read_to_string(PATH)
[INFO] [stdout] 16 | |         .unwrap_or("".to_string())
[INFO] [stdout] 17 | |         .split('\n')
[INFO] [stdout] 18 | |         .map(|x| x.to_string())
[INFO] [stdout] 19 | |         .collect();
[INFO] [stdout]    | |__________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 ~     std::fs::read_to_string(PATH)
[INFO] [stdout] 16 +         .unwrap_or("".to_string())
[INFO] [stdout] 17 +         .split('\n')
[INFO] [stdout] 18 +         .map(|x| x.to_string())
[INFO] [stdout] 19 ~         .collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/password_store.rs:61:5
[INFO] [stdout]    |
[INFO] [stdout] 61 |     return base64::encode(hasher.finalize());
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 61 -     return base64::encode(hasher.finalize());
[INFO] [stdout] 61 +     base64::encode(hasher.finalize())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/password_store.rs:97:9
[INFO] [stdout]    |
[INFO] [stdout] 97 | ...   return user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 97 -         return user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout] 97 +         user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/password_store.rs:94:12
[INFO] [stdout]    |
[INFO] [stdout] 94 |         if text == "" {return false};
[INFO] [stdout]    |            ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/password_store.rs:97:24
[INFO] [stdout]    |
[INFO] [stdout] 97 | ...   return user == caps["user"].to_string() && hash_pass(password.to_owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `caps["user"]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/password_store.rs:97:112
[INFO] [stdout]    |
[INFO] [stdout] 97 | ..._owned(), caps["salt"].to_string()) == caps["pass"].to_string();
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `caps["pass"]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/password_store.rs:116:12
[INFO] [stdout]     |
[INFO] [stdout] 116 |         if &line == "" {continue};
[INFO] [stdout]     |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/password_store.rs:118:24
[INFO] [stdout]     |
[INFO] [stdout] 118 |             if user != caps["user"].to_string() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `caps["user"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:46:28
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^ help: try: `user.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:46:47
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                               ^^^^^^^^^^^^^^^^^^^ help: try: `password.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:62:28
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^ help: try: `user.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:62:47
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                               ^^^^^^^^^^^^^^^^^^^ help: try: `password.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/Project2.rs:73:28
[INFO] [stdout]    |
[INFO] [stdout] 73 |                         if !user.is_none(){
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^ help: try: `user.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:47:49
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 47 |                             if user_re.is_match(user.unwrap()) {
[INFO] [stdout]    |                                                 ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:48:53
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 47 |                             if user_re.is_match(user.unwrap()) {
[INFO] [stdout] 48 |                                 password_store::add(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `password` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:48:79
[INFO] [stdout]    |
[INFO] [stdout] 46 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                                ------------------ the check is happening here
[INFO] [stdout] 47 |                             if user_re.is_match(user.unwrap()) {
[INFO] [stdout] 48 |                                 password_store::add(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                                               ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:64:51
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 63 |                             // validates the given password hashed matches the one in the file
[INFO] [stdout] 64 |                             password_store::check(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `password` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:64:77
[INFO] [stdout]    |
[INFO] [stdout] 62 |                         if !user.is_none() && !password.is_none(){
[INFO] [stdout]    |                                                ------------------ the check is happening here
[INFO] [stdout] 63 |                             // validates the given password hashed matches the one in the file
[INFO] [stdout] 64 |                             password_store::check(user.unwrap().to_owned(), password.unwrap().to_owned())
[INFO] [stdout]    |                                                                             ^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `user` after checking its variant with `is_none`
[INFO] [stdout]   --> src/Project2.rs:75:52
[INFO] [stdout]    |
[INFO] [stdout] 73 |                         if !user.is_none(){
[INFO] [stdout]    |                             -------------- the check is happening here
[INFO] [stdout] 74 |                             // removes the given user from file
[INFO] [stdout] 75 |                             password_store::remove(user.unwrap().to_owned())
[INFO] [stdout]    |                                                    ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: compiling a regex in a loop
[INFO] [stdout]   --> src/Project2.rs:42:31
[INFO] [stdout]    |
[INFO] [stdout] 42 |                 let user_re = Regex::new(r"^[a-zA-Z_\-0-9]+$").unwrap();
[INFO] [stdout]    |                               ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: move the regex construction outside this loop
[INFO] [stdout]   --> src/Project2.rs:25:5
[INFO] [stdout]    |
[INFO] [stdout] 25 |     loop {
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops
[INFO] [stdout]    = note: `#[warn(clippy::regex_creation_in_loops)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "f2fbefb405917d60397dc7fc2d62d9d488b5bc59b87c8d039cb9e3b3ad557da9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f2fbefb405917d60397dc7fc2d62d9d488b5bc59b87c8d039cb9e3b3ad557da9", kill_on_drop: false }`
[INFO] [stdout] f2fbefb405917d60397dc7fc2d62d9d488b5bc59b87c8d039cb9e3b3ad557da9