[INFO] cloning repository https://github.com/chenshuai2144/pro-changelog [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chenshuai2144/pro-changelog" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchenshuai2144%2Fpro-changelog", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchenshuai2144%2Fpro-changelog'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8ae78f9c6f7a88eafc458ca622ffa621324390fc [INFO] linting chenshuai2144/pro-changelog against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchenshuai2144%2Fpro-changelog" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/chenshuai2144/pro-changelog [INFO] finished tweaking git repo https://github.com/chenshuai2144/pro-changelog [INFO] tweaked toml for git repo https://github.com/chenshuai2144/pro-changelog written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/chenshuai2144/pro-changelog on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/chenshuai2144/pro-changelog already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hyper-tls v0.3.2 [INFO] [stderr] Downloaded try_from v0.3.2 [INFO] [stderr] Downloaded native-tls v0.2.8 [INFO] [stderr] Downloaded cookie v0.12.0 [INFO] [stderr] Downloaded exitfailure v0.5.1 [INFO] [stderr] Downloaded libssh2-sys v0.2.23 [INFO] [stderr] Downloaded hyper v0.12.36 [INFO] [stderr] Downloaded git2 v0.14.1 [INFO] [stderr] Downloaded publicsuffix v1.5.6 [INFO] [stderr] Downloaded cookie_store v0.7.0 [INFO] [stderr] Downloaded uuid v0.7.4 [INFO] [stderr] Downloaded libgit2-sys v0.13.1+1.4.2 [INFO] [stderr] Downloaded reqwest v0.9.24 [INFO] [stderr] Downloaded libz-sys v1.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32fd96e9ee4ddba13f96bbd9920391e6efc3e39b99c7467406daa82a36509b46 [INFO] running `Command { std: "docker" "start" "-a" "32fd96e9ee4ddba13f96bbd9920391e6efc3e39b99c7467406daa82a36509b46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32fd96e9ee4ddba13f96bbd9920391e6efc3e39b99c7467406daa82a36509b46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32fd96e9ee4ddba13f96bbd9920391e6efc3e39b99c7467406daa82a36509b46", kill_on_drop: false }` [INFO] [stdout] 32fd96e9ee4ddba13f96bbd9920391e6efc3e39b99c7467406daa82a36509b46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 068d93981f5e4ab097b5617587242b96fae27835d367352ca0ce41808bf54be4 [INFO] running `Command { std: "docker" "start" "-a" "068d93981f5e4ab097b5617587242b96fae27835d367352ca0ce41808bf54be4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling hyper v0.12.36 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling encoding_rs v0.8.30 [INFO] [stderr] Checking try_from v0.3.2 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Compiling backtrace v0.3.64 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.13.1+1.4.2 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking publicsuffix v1.5.6 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking exitfailure v0.5.1 [INFO] [stderr] Checking hyper-tls v0.3.2 [INFO] [stderr] Checking git2 v0.14.1 [INFO] [stderr] Checking serde_urlencoded v0.5.5 [INFO] [stderr] Checking cookie_store v0.7.0 [INFO] [stderr] Checking reqwest v0.9.24 [INFO] [stderr] Checking pro-changelog v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changelog.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | client: client, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changelog.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 308 | author_github_map: author_github_map, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `author_github_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changelog.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 310 | repo_name: repo_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repo_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `string_array::StringArray` [INFO] [stdout] --> src/npm.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | use git2::{string_array::StringArray, Repository}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/npm.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rc::Rc` [INFO] [stdout] --> src/npm.rs:6:64 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{collections::HashMap, env, fs, io, process::Command, rc::Rc}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/npm.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | pub const NPM: &'static str = "npm"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead` and `self` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, BufRead}; [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::process::Command` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::process::Command; // 引入命令模块 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `changelog::Changelogs` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use changelog::Changelogs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | use std::fs::{self, create_dir, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changelog.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | client: client, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changelog.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 308 | author_github_map: author_github_map, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `author_github_map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/changelog.rs:310:13 [INFO] [stdout] | [INFO] [stdout] 310 | repo_name: repo_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repo_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `string_array::StringArray` [INFO] [stdout] --> src/npm.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | use git2::{string_array::StringArray, Repository}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/npm.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rc::Rc` [INFO] [stdout] --> src/npm.rs:6:64 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{collections::HashMap, env, fs, io, process::Command, rc::Rc}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/npm.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | pub const NPM: &'static str = "npm"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BufRead` and `self` [INFO] [stdout] --> src/main.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::io::{self, BufRead}; [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::process::Command` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::process::Command; // 引入命令模块 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `changelog::Changelogs` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use changelog::Changelogs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 10 | use std::fs::{self, create_dir, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `create_md_file` is never used [INFO] [stdout] --> src/main.rs:16:4 [INFO] [stdout] | [INFO] [stdout] 16 | fn create_md_file(package: String, content: String) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Changelogs` is never constructed [INFO] [stdout] --> src/changelog.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Changelogs { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MARKDOWN` is never constructed [INFO] [stdout] --> src/changelog.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct MARKDOWN { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GithubUser` is never constructed [INFO] [stdout] --> src/changelog.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | struct GithubUser { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GithubPull` is never constructed [INFO] [stdout] --> src/changelog.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | struct GithubPull { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GithubRepo` is never constructed [INFO] [stdout] --> src/changelog.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | struct GithubRepo { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/changelog.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl Changelogs { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 38 | pub fn get_md_message(&mut self, commit: &Commit) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | pub fn gen_change_log_by_commit_list( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | pub fn gen_change_log_to_md(&mut self, tag: &Tag, change_logs: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | pub fn get_change_log_list(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 186 | pub fn get_all_change_log_list(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 233 | pub fn get_pr_user_name(&mut self, pr_number: &str, author: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 264 | pub fn new(repo: String) -> Changelogs { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `package` is never read [INFO] [stdout] --> src/git.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct TagAndVersion { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 9 | pub package: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TagAndVersion` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TagAndCommit` is never constructed [INFO] [stdout] --> src/git.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct TagAndCommit { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `latest_tag` is never read [INFO] [stdout] --> src/git.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct CommitRange<'r> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 38 | latest_tag: Tag, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommitRange` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_tag_list` is never used [INFO] [stdout] --> src/git.rs:133:4 [INFO] [stdout] | [INFO] [stdout] 133 | fn get_tag_list<'a>(repo: &'a Repository, package_name: &'a str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_all_tag_range` is never used [INFO] [stdout] --> src/git.rs:234:8 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn get_all_tag_range<'r>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_commit_list_by_commit_range` is never used [INFO] [stdout] --> src/git.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | pub fn get_commit_list_by_commit_range( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `latest_commits` is never used [INFO] [stdout] --> src/git.rs:342:8 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn latest_commits(repo: &Repository, package_name: &str) -> crate::Result<(Tag, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `full_commits` is never used [INFO] [stdout] --> src/git.rs:352:8 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn full_commits(repo: &Repository, package_name: &str) -> crate::Result> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_package_latest_version` is never used [INFO] [stdout] --> src/npm.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl Npm { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 130 | pub fn get_package_latest_version(&self, name: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MARKDOWN` contains a capitalized acronym [INFO] [stdout] --> src/changelog.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct MARKDOWN { [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Markdown` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `create_md_file` is never used [INFO] [stdout] --> src/main.rs:16:4 [INFO] [stdout] | [INFO] [stdout] 16 | fn create_md_file(package: String, content: String) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Changelogs` is never constructed [INFO] [stdout] --> src/changelog.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct Changelogs { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MARKDOWN` is never constructed [INFO] [stdout] --> src/changelog.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct MARKDOWN { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GithubUser` is never constructed [INFO] [stdout] --> src/changelog.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | struct GithubUser { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GithubPull` is never constructed [INFO] [stdout] --> src/changelog.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | struct GithubPull { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GithubRepo` is never constructed [INFO] [stdout] --> src/changelog.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | struct GithubRepo { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/changelog.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | impl Changelogs { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 38 | pub fn get_md_message(&mut self, commit: &Commit) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | pub fn gen_change_log_by_commit_list( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 127 | pub fn gen_change_log_to_md(&mut self, tag: &Tag, change_logs: Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 141 | pub fn get_change_log_list(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 186 | pub fn get_all_change_log_list(&mut self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 233 | pub fn get_pr_user_name(&mut self, pr_number: &str, author: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 264 | pub fn new(repo: String) -> Changelogs { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `package` is never read [INFO] [stdout] --> src/git.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct TagAndVersion { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 9 | pub package: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TagAndVersion` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TagAndCommit` is never constructed [INFO] [stdout] --> src/git.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct TagAndCommit { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `latest_tag` is never read [INFO] [stdout] --> src/git.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct CommitRange<'r> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 38 | latest_tag: Tag, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CommitRange` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_tag_list` is never used [INFO] [stdout] --> src/git.rs:133:4 [INFO] [stdout] | [INFO] [stdout] 133 | fn get_tag_list<'a>(repo: &'a Repository, package_name: &'a str) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_all_tag_range` is never used [INFO] [stdout] --> src/git.rs:234:8 [INFO] [stdout] | [INFO] [stdout] 234 | pub fn get_all_tag_range<'r>( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_commit_list_by_commit_range` is never used [INFO] [stdout] --> src/git.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | pub fn get_commit_list_by_commit_range( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `latest_commits` is never used [INFO] [stdout] --> src/git.rs:342:8 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn latest_commits(repo: &Repository, package_name: &str) -> crate::Result<(Tag, Vec)> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `full_commits` is never used [INFO] [stdout] --> src/git.rs:352:8 [INFO] [stdout] | [INFO] [stdout] 352 | pub fn full_commits(repo: &Repository, package_name: &str) -> crate::Result> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_package_latest_version` is never used [INFO] [stdout] --> src/npm.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl Npm { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 130 | pub fn get_package_latest_version(&self, name: &str) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MARKDOWN` contains a capitalized acronym [INFO] [stdout] --> src/changelog.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct MARKDOWN { [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Markdown` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/changelog.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | if need_insert_message && !commit_hash_map.get(&hash).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `commit_hash_map.get(&hash).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/changelog.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | let re = Regex::new(r"[fix|feat]\(([0-9a-zA-Z_]*)\)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/changelog.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | for commit in commit_list { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/changelog.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / if re.is_match(message) { [INFO] [stdout] 105 | | if re [INFO] [stdout] 106 | | .captures(message) [INFO] [stdout] 107 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if re.is_match(message) [INFO] [stdout] 105 ~ && re [INFO] [stdout] 106 | .captures(message) [INFO] [stdout] ... [INFO] [stdout] 112 | need_insert_message = true [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&hash).is_some()` [INFO] [stdout] --> src/changelog.rs:116:56 [INFO] [stdout] | [INFO] [stdout] 116 | if need_insert_message && !commit_hash_map.get(&hash).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&hash)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/changelog.rs:163:16 [INFO] [stdout] | [INFO] [stdout] 163 | if change_logs.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `change_logs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/changelog.rs:209:20 [INFO] [stdout] | [INFO] [stdout] 209 | if change_logs.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `change_logs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(author).is_none()` [INFO] [stdout] --> src/changelog.rs:234:35 [INFO] [stdout] | [INFO] [stdout] 234 | if self.author_github_map.get(author).is_none() { [INFO] [stdout] | -----------------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.author_github_map.contains_key(author)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/changelog.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | if need_insert_message && !commit_hash_map.get(&hash).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `commit_hash_map.get(&hash).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/changelog.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | let re = Regex::new(r"[fix|feat]\(([0-9a-zA-Z_]*)\)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/changelog.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | for commit in commit_list { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/changelog.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / if re.is_match(message) { [INFO] [stdout] 105 | | if re [INFO] [stdout] 106 | | .captures(message) [INFO] [stdout] 107 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if re.is_match(message) [INFO] [stdout] 105 ~ && re [INFO] [stdout] 106 | .captures(message) [INFO] [stdout] ... [INFO] [stdout] 112 | need_insert_message = true [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&hash).is_some()` [INFO] [stdout] --> src/changelog.rs:116:56 [INFO] [stdout] | [INFO] [stdout] 116 | if need_insert_message && !commit_hash_map.get(&hash).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&hash)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/error.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | &*self.inner.get_context() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.inner.get_context()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/changelog.rs:163:16 [INFO] [stdout] | [INFO] [stdout] 163 | if change_logs.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `change_logs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/changelog.rs:209:20 [INFO] [stdout] | [INFO] [stdout] 209 | if change_logs.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `change_logs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(author).is_none()` [INFO] [stdout] --> src/changelog.rs:234:35 [INFO] [stdout] | [INFO] [stdout] 234 | if self.author_github_map.get(author).is_none() { [INFO] [stdout] | -----------------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.author_github_map.contains_key(author)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/git.rs:98:30 [INFO] [stdout] | [INFO] [stdout] 98 | let buf = str::from_utf8(&*buf).context(crate::ErrorKind::Other)?; [INFO] [stdout] | ^^^^^ help: try: `&buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/git.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 108 | package: "@".to_owned() + &package_list.get(1).unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `package_list.get(1).unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/git.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 128 | let tags = tags.into_iter().map(|(tag, _)| tag).collect(); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 129 | [INFO] [stdout] 130 | tags [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 128 ~ [INFO] [stdout] 129 | [INFO] [stdout] 130 ~ tags.into_iter().map(|(tag, _)| tag).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/git.rs:139:10 [INFO] [stdout] | [INFO] [stdout] 139 | .filter_map(|x| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/error.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | &*self.inner.get_context() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.inner.get_context()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/git.rs:170:14 [INFO] [stdout] | [INFO] [stdout] 170 | .filter_map(|x| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/git.rs:187:23 [INFO] [stdout] | [INFO] [stdout] 187 | let oid = reveals [INFO] [stdout] | _______________________^ [INFO] [stdout] 188 | | .nth(0) [INFO] [stdout] | |_______________________^ help: try calling `.next()` instead of `.nth(0)`: `reveals.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/git.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | Ok(diff(&repo, start, end)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 231 - Ok(diff(&repo, start, end)?) [INFO] [stdout] 231 + diff(&repo, start, end) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/git.rs:98:30 [INFO] [stdout] | [INFO] [stdout] 98 | let buf = str::from_utf8(&*buf).context(crate::ErrorKind::Other)?; [INFO] [stdout] | ^^^^^ help: try: `&buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/git.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 108 | package: "@".to_owned() + &package_list.get(1).unwrap().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `package_list.get(1).unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/git.rs:262:27 [INFO] [stdout] | [INFO] [stdout] 262 | let oid = reveals [INFO] [stdout] | ___________________________^ [INFO] [stdout] 263 | | .nth(0) [INFO] [stdout] | |___________________________^ help: try calling `.next()` instead of `.nth(0)`: `reveals.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/git.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 128 | let tags = tags.into_iter().map(|(tag, _)| tag).collect(); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 129 | [INFO] [stdout] 130 | tags [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 128 ~ [INFO] [stdout] 129 | [INFO] [stdout] 130 ~ tags.into_iter().map(|(tag, _)| tag).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/git.rs:139:10 [INFO] [stdout] | [INFO] [stdout] 139 | .filter_map(|x| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/git.rs:170:14 [INFO] [stdout] | [INFO] [stdout] 170 | .filter_map(|x| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/git.rs:309:31 [INFO] [stdout] | [INFO] [stdout] 309 | let end_is_first_commit = match end.parent(0) { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 310 | | Err(_err) => true, [INFO] [stdout] 311 | | _ => false, [INFO] [stdout] 312 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 309 - let end_is_first_commit = match end.parent(0) { [INFO] [stdout] 310 - Err(_err) => true, [INFO] [stdout] 311 - _ => false, [INFO] [stdout] 312 - }; [INFO] [stdout] 309 + let end_is_first_commit = matches!(end.parent(0), Err(_err)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:343:48 [INFO] [stdout] | [INFO] [stdout] 343 | let commit_range = get_commit_latest_range(&repo, package_name)?; [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:347:51 [INFO] [stdout] | [INFO] [stdout] 347 | let commits = get_commit_list_by_commit_range(&repo, commit_range).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/git.rs:187:23 [INFO] [stdout] | [INFO] [stdout] 187 | let oid = reveals [INFO] [stdout] | _______________________^ [INFO] [stdout] 188 | | .nth(0) [INFO] [stdout] | |_______________________^ help: try calling `.next()` instead of `.nth(0)`: `reveals.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:353:47 [INFO] [stdout] | [INFO] [stdout] 353 | let commit_range_list = get_all_tag_range(&repo, package_name)?; [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:359:55 [INFO] [stdout] | [INFO] [stdout] 359 | let commits = get_commit_list_by_commit_range(&repo, commit_range).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/git.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | Ok(diff(&repo, start, end)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 231 - Ok(diff(&repo, start, end)?) [INFO] [stdout] 231 + diff(&repo, start, end) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/git.rs:262:27 [INFO] [stdout] | [INFO] [stdout] 262 | let oid = reveals [INFO] [stdout] | ___________________________^ [INFO] [stdout] 263 | | .nth(0) [INFO] [stdout] | |___________________________^ help: try calling `.next()` instead of `.nth(0)`: `reveals.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/git.rs:309:31 [INFO] [stdout] | [INFO] [stdout] 309 | let end_is_first_commit = match end.parent(0) { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 310 | | Err(_err) => true, [INFO] [stdout] 311 | | _ => false, [INFO] [stdout] 312 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 309 - let end_is_first_commit = match end.parent(0) { [INFO] [stdout] 310 - Err(_err) => true, [INFO] [stdout] 311 - _ => false, [INFO] [stdout] 312 - }; [INFO] [stdout] 309 + let end_is_first_commit = matches!(end.parent(0), Err(_err)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:343:48 [INFO] [stdout] | [INFO] [stdout] 343 | let commit_range = get_commit_latest_range(&repo, package_name)?; [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:347:51 [INFO] [stdout] | [INFO] [stdout] 347 | let commits = get_commit_list_by_commit_range(&repo, commit_range).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:353:47 [INFO] [stdout] | [INFO] [stdout] 353 | let commit_range_list = get_all_tag_range(&repo, package_name)?; [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git.rs:359:55 [INFO] [stdout] | [INFO] [stdout] 359 | let commits = get_commit_list_by_commit_range(&repo, commit_range).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `repo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | let s = Npm::new("C:/github/pro-components".to_string()).check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 53 ~ Npm::new("C:/github/pro-components".to_string()).check(); [INFO] [stdout] 54 | [INFO] [stdout] 55 ~ println!("{:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ErrorKind` [INFO] [stdout] 23 | pub enum ErrorKind { [INFO] [stdout] | --------- `ErrorKind` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ErrorKind` [INFO] [stdout] 23 | pub enum ErrorKind { [INFO] [stdout] | --------- `ErrorKind` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/npm.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | .current_dir(npm_path.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | let s = Npm::new("C:/github/pro-components".to_string()).check(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 53 ~ Npm::new("C:/github/pro-components".to_string()).check(); [INFO] [stdout] 54 | [INFO] [stdout] 55 ~ println!("{:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ErrorKind` [INFO] [stdout] 23 | pub enum ErrorKind { [INFO] [stdout] | --------- `ErrorKind` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ErrorKind` [INFO] [stdout] 23 | pub enum ErrorKind { [INFO] [stdout] | --------- `ErrorKind` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/npm.rs:70:42 [INFO] [stdout] | [INFO] [stdout] 70 | .current_dir(npm_path.clone()) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 41.11s [INFO] running `Command { std: "docker" "inspect" "068d93981f5e4ab097b5617587242b96fae27835d367352ca0ce41808bf54be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "068d93981f5e4ab097b5617587242b96fae27835d367352ca0ce41808bf54be4", kill_on_drop: false }` [INFO] [stdout] 068d93981f5e4ab097b5617587242b96fae27835d367352ca0ce41808bf54be4