[INFO] cloning repository https://github.com/cheme/service-pre [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cheme/service-pre" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcheme%2Fservice-pre", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcheme%2Fservice-pre'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ce8e33baa75953bc18722e7f50023c20491b0a65 [INFO] linting cheme/service-pre against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcheme%2Fservice-pre" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cheme/service-pre [INFO] finished tweaking git repo https://github.com/cheme/service-pre [INFO] tweaked toml for git repo https://github.com/cheme/service-pre written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cheme/service-pre on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cheme/service-pre already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating git repository `https://github.com/cheme/immut-send.git` [INFO] [stderr] Updating git repository `https://github.com/cheme/rust-proto.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded smallvec v0.6.3 [INFO] [stderr] Downloaded bitflags v1.0.3 [INFO] [stderr] Downloaded stable_deref_trait v1.1.0 [INFO] [stderr] Downloaded parking_lot_core v0.2.14 [INFO] [stderr] Downloaded cfg-if v0.1.4 [INFO] [stderr] Downloaded log v0.4.3 [INFO] [stderr] Downloaded coroutine v0.8.0 [INFO] [stderr] Downloaded parking_lot v0.6.3 [INFO] [stderr] Downloaded cc v1.0.18 [INFO] [stderr] Downloaded error-chain v0.12.0 [INFO] [stderr] Downloaded mio v0.6.15 [INFO] [stderr] Downloaded libc v0.2.42 [INFO] [stderr] Downloaded futures v0.1.23 [INFO] [stderr] Downloaded context v1.0.1 [INFO] [stderr] Downloaded backtrace-sys v0.1.23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 439f4b43f2d8b6bafefd484840268b4699405590c34142f0fef989a7fdeefce2 [INFO] running `Command { std: "docker" "start" "-a" "439f4b43f2d8b6bafefd484840268b4699405590c34142f0fef989a7fdeefce2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "439f4b43f2d8b6bafefd484840268b4699405590c34142f0fef989a7fdeefce2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "439f4b43f2d8b6bafefd484840268b4699405590c34142f0fef989a7fdeefce2", kill_on_drop: false }` [INFO] [stdout] 439f4b43f2d8b6bafefd484840268b4699405590c34142f0fef989a7fdeefce2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c2fb14575b5859905deef6cec25eb90ccf233ed161e084601518eaf9627e3bc [INFO] running `Command { std: "docker" "start" "-a" "1c2fb14575b5859905deef6cec25eb90ccf233ed161e084601518eaf9627e3bc", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Compiling cc v1.0.18 [INFO] [stderr] Checking cfg-if v0.1.4 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking stable_deref_trait v1.1.0 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking futures v0.1.23 [INFO] [stderr] Checking immut-send v0.0.1 (https://github.com/cheme/immut-send.git#e3197f3a) [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking rust-proto v0.1.0 (https://github.com/cheme/rust-proto.git#04df6d11) [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking smallvec v0.6.3 [INFO] [stderr] Checking lock_api v0.1.3 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking service-pre v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: error reading Clippy's configuration file: deprecated field `blacklisted-names`. Please use `disallowed-names` instead [INFO] [stdout] --> /opt/rustwide/workdir/clippy.toml:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | blacklisted-names = ["foo", "bar", "baz", "quux"] # default (cf clippy_lints/src/utils/conf.rs) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: error reading Clippy's configuration file: deprecated field `cyclomatic-complexity-threshold`. Please use `cognitive-complexity-threshold` instead [INFO] [stdout] --> /opt/rustwide/workdir/clippy.toml:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | cyclomatic-complexity-threshold = 25 # just for testing (default value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: error reading Clippy's configuration file: deprecated field `blacklisted-names`. Please use `disallowed-names` instead [INFO] [stdout] --> /opt/rustwide/workdir/clippy.toml:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | blacklisted-names = ["foo", "bar", "baz", "quux"] # default (cf clippy_lints/src/utils/conf.rs) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: error reading Clippy's configuration file: deprecated field `cyclomatic-complexity-threshold`. Please use `cognitive-complexity-threshold` instead [INFO] [stdout] --> /opt/rustwide/workdir/clippy.toml:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | cyclomatic-complexity-threshold = 25 # just for testing (default value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | service: service, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `service` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | spawn_out: spawn_out, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `spawn_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | recv: recv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `recv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | nb_loop: nb_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `nb_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | service: service, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `service` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | spawn_out: spawn_out, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `spawn_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | recv: recv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `recv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spawn/restart.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | nb_loop: nb_loop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `nb_loop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | fn register(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^ help: try naming the parameter or explicitly ignoring it: `_: &P` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn register(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Token` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 25 | fn register(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Ready` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | fn reregister(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^ help: try naming the parameter or explicitly ignoring it: `_: &P` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | fn reregister(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Token` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:27:35 [INFO] [stdout] | [INFO] [stdout] 27 | fn reregister(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Ready` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | fn with_capacity(usize) -> Self; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: usize` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/channels/mod.rs:89:34 [INFO] [stdout] | [INFO] [stdout] 89 | fn send_with_handle(&mut self, C) -> Result>; [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: C` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | fn register(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^ help: try naming the parameter or explicitly ignoring it: `_: &P` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | Option<::CommandIn>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Option<::CommandIn>` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | fn get_weak_send(&Self::Send) -> Option; [INFO] [stdout] | ^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self::Send` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 230 | fn send(&mut self, Command) -> Result<()>; [INFO] [stdout] | ^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Command` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:25:26 [INFO] [stdout] | [INFO] [stdout] 25 | fn register(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Token` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 25 | fn register(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Ready` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | fn reregister(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^ help: try naming the parameter or explicitly ignoring it: `_: &P` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | fn reregister(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Token` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:27:35 [INFO] [stdout] | [INFO] [stdout] 27 | fn reregister(&self, &P, Token, Ready) -> Result; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Ready` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/eventloop/mod.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 42 | fn with_capacity(usize) -> Self; [INFO] [stdout] | ^^^^^ help: try naming the parameter or explicitly ignoring it: `_: usize` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/channels/mod.rs:89:34 [INFO] [stdout] | [INFO] [stdout] 89 | fn send_with_handle(&mut self, C) -> Result>; [INFO] [stdout] | ^ help: try naming the parameter or explicitly ignoring it: `_: C` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | Option<::CommandIn>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Option<::CommandIn>` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:221:20 [INFO] [stdout] | [INFO] [stdout] 221 | fn get_weak_send(&Self::Send) -> Option; [INFO] [stdout] | ^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &Self::Send` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:230:22 [INFO] [stdout] | [INFO] [stdout] 230 | fn send(&mut self, Command) -> Result<()>; [INFO] [stdout] | ^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: Command` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / error_chain! { [INFO] [stdout] 21 | | // standard types [INFO] [stdout] 22 | | types { [INFO] [stdout] 23 | | Error, ErrorKind, ResultExt, Result; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:52:40 [INFO] [stdout] | [INFO] [stdout] 52 | description(::std::error::Error::description(err)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / error_chain! { [INFO] [stdout] 21 | | // standard types [INFO] [stdout] 22 | | types { [INFO] [stdout] 23 | | Error, ErrorKind, ResultExt, Result; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:52:40 [INFO] [stdout] | [INFO] [stdout] 52 | description(::std::error::Error::description(err)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/channels/mod.rs:102:32 [INFO] [stdout] | [INFO] [stdout] 102 | fn test_trait_item1(_i: Box>) {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 102 | fn test_trait_item1(_i: Box>) {} [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/channels/mod.rs:105:29 [INFO] [stdout] | [INFO] [stdout] 105 | fn test_trait_item2(_i: &SpawnSendWithHandle) {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 105 | fn test_trait_item2(_i: &dyn SpawnSendWithHandle) {} [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/error.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / error_chain! { [INFO] [stdout] 21 | | // standard types [INFO] [stdout] 22 | | types { [INFO] [stdout] 23 | | Error, ErrorKind, ResultExt, Result; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/error.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / error_chain! { [INFO] [stdout] 21 | | // standard types [INFO] [stdout] 22 | | types { [INFO] [stdout] 23 | | Error, ErrorKind, ResultExt, Result; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `th_join` is never read [INFO] [stdout] --> src/spawn/threadblock.rs:46:3 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct ThreadHandleBlock { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 45 | return_state: Arc)>>>, [INFO] [stdout] 46 | th_join: JoinHandle>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `th_join` is never read [INFO] [stdout] --> src/spawn/threadpark.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 59 | pub struct ThreadHandlePark { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 60 | return_state: Arc)>>>, [INFO] [stdout] 61 | th_join: JoinHandle>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `th_join` is never read [INFO] [stdout] --> src/spawn/threadpark.rs:68:3 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct ThreadHandleParkRef { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] 67 | return_state: Arc)>>>, [INFO] [stdout] 68 | th_join: JoinHandle>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `th_join` is never read [INFO] [stdout] --> src/spawn/threadblock.rs:46:3 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct ThreadHandleBlock { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 45 | return_state: Arc)>>>, [INFO] [stdout] 46 | th_join: JoinHandle>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `th_join` is never read [INFO] [stdout] --> src/spawn/threadpark.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 59 | pub struct ThreadHandlePark { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 60 | return_state: Arc)>>>, [INFO] [stdout] 61 | th_join: JoinHandle>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `th_join` is never read [INFO] [stdout] --> src/spawn/threadpark.rs:68:3 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct ThreadHandleParkRef { [INFO] [stdout] | ------------------- field in this struct [INFO] [stdout] 67 | return_state: Arc)>>>, [INFO] [stdout] 68 | th_join: JoinHandle>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_trait_item1` is never used [INFO] [stdout] --> src/channels/mod.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | fn test_trait_item1(_i: Box>) {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_trait_item2` is never used [INFO] [stdout] --> src/channels/mod.rs:105:4 [INFO] [stdout] | [INFO] [stdout] 105 | fn test_trait_item2(_i: &SpawnSendWithHandle) {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/blocking.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return Ok(BlockingSameThread((service, spawn_out, r, err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return Ok(BlockingSameThread((service, spawn_out, r, err))); [INFO] [stdout] 59 + Ok(BlockingSameThread((service, spawn_out, r, err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/blocking.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return Ok(BlockingSameThread((service, spawn_out, r, err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return Ok(BlockingSameThread((service, spawn_out, r, err))); [INFO] [stdout] 59 + Ok(BlockingSameThread((service, spawn_out, r, err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/spawn/restart.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | / if let &mut RestartSameThread::Ended(_) = self { [INFO] [stdout] 110 | | true [INFO] [stdout] 111 | | } else { [INFO] [stdout] 112 | | false [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 109 - if let &mut RestartSameThread::Ended(_) = self { [INFO] [stdout] 110 - true [INFO] [stdout] 111 - } else { [INFO] [stdout] 112 - false [INFO] [stdout] 113 - } [INFO] [stdout] 109 + matches!(self, &mut RestartSameThread::Ended(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/spawn/restart.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | / if let &mut RestartSameThread::Ended(_) = self { [INFO] [stdout] 110 | | true [INFO] [stdout] 111 | | } else { [INFO] [stdout] 112 | | false [INFO] [stdout] 113 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 109 - if let &mut RestartSameThread::Ended(_) = self { [INFO] [stdout] 110 - true [INFO] [stdout] 111 - } else { [INFO] [stdout] 112 - false [INFO] [stdout] 113 - } [INFO] [stdout] 109 + matches!(self, &mut RestartSameThread::Ended(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/spawn/threadblock.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | return_state: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/threadblock.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let ost = replace(&mut (*mlock), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `(*mlock).take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/spawn/threadblock.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | return_state: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/threadblock.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / return Ok(ThreadHandleBlock { [INFO] [stdout] 163 | | return_state: finished2.0, [INFO] [stdout] 164 | | th_join: join_handle, [INFO] [stdout] 165 | | finished: finished2.1, [INFO] [stdout] 166 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 ~ Ok(ThreadHandleBlock { [INFO] [stdout] 163 + return_state: finished2.0, [INFO] [stdout] 164 + th_join: join_handle, [INFO] [stdout] 165 + finished: finished2.1, [INFO] [stdout] 166 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/threadblock.rs:92:17 [INFO] [stdout] | [INFO] [stdout] 92 | let ost = replace(&mut (*mlock), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `(*mlock).take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/threadblock.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / return Ok(ThreadHandleBlock { [INFO] [stdout] 163 | | return_state: finished2.0, [INFO] [stdout] 164 | | th_join: join_handle, [INFO] [stdout] 165 | | finished: finished2.1, [INFO] [stdout] 166 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 ~ Ok(ThreadHandleBlock { [INFO] [stdout] 163 + return_state: finished2.0, [INFO] [stdout] 164 + th_join: join_handle, [INFO] [stdout] 165 + finished: finished2.1, [INFO] [stdout] 166 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/spawn/threadpark.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | return_state: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/spawn/threadpark.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | return_state: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/threadpark.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | let ost = replace(&mut (*mlock), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `(*mlock).take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/threadpark.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | let ost = replace(&mut (*mlock), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `(*mlock).take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/spawn/threadpark.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | return_state: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/spawn/threadpark.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | return_state: Arc)>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/threadpark.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | let ost = replace(&mut (*mlock), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `(*mlock).take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/threadpark.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | / return Ok(ThreadHandlePark { [INFO] [stdout] 231 | | return_state: finished2.0, [INFO] [stdout] 232 | | th_join: join_handle, [INFO] [stdout] 233 | | park_sync: skip, [INFO] [stdout] 234 | | finished: finished2.1, [INFO] [stdout] 235 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 ~ Ok(ThreadHandlePark { [INFO] [stdout] 231 + return_state: finished2.0, [INFO] [stdout] 232 + th_join: join_handle, [INFO] [stdout] 233 + park_sync: skip, [INFO] [stdout] 234 + finished: finished2.1, [INFO] [stdout] 235 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/threadpark.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | let ost = replace(&mut (*mlock), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `(*mlock).take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/threadpark.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | / return Ok(ThreadHandlePark { [INFO] [stdout] 231 | | return_state: finished2.0, [INFO] [stdout] 232 | | th_join: join_handle, [INFO] [stdout] 233 | | park_sync: skip, [INFO] [stdout] 234 | | finished: finished2.1, [INFO] [stdout] 235 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 ~ Ok(ThreadHandlePark { [INFO] [stdout] 231 + return_state: finished2.0, [INFO] [stdout] 232 + th_join: join_handle, [INFO] [stdout] 233 + park_sync: skip, [INFO] [stdout] 234 + finished: finished2.1, [INFO] [stdout] 235 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/threadpark.rs:301:5 [INFO] [stdout] | [INFO] [stdout] 301 | / return Ok(ThreadHandleParkRef { [INFO] [stdout] 302 | | return_state: finished2.0, [INFO] [stdout] 303 | | th_join: join_handle, [INFO] [stdout] 304 | | park_sync: skip, [INFO] [stdout] 305 | | finished: finished2.1, [INFO] [stdout] 306 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 ~ Ok(ThreadHandleParkRef { [INFO] [stdout] 302 + return_state: finished2.0, [INFO] [stdout] 303 + th_join: join_handle, [INFO] [stdout] 304 + park_sync: skip, [INFO] [stdout] 305 + finished: finished2.1, [INFO] [stdout] 306 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/threadpark.rs:301:5 [INFO] [stdout] | [INFO] [stdout] 301 | / return Ok(ThreadHandleParkRef { [INFO] [stdout] 302 | | return_state: finished2.0, [INFO] [stdout] 303 | | th_join: join_handle, [INFO] [stdout] 304 | | park_sync: skip, [INFO] [stdout] 305 | | finished: finished2.1, [INFO] [stdout] 306 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 ~ Ok(ThreadHandleParkRef { [INFO] [stdout] 302 + return_state: finished2.0, [INFO] [stdout] 303 + th_join: join_handle, [INFO] [stdout] 304 + park_sync: skip, [INFO] [stdout] 305 + finished: finished2.1, [INFO] [stdout] 306 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/spawn/futurecpupool.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !self.1.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.1.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/futurecpupool.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 77 | let r = replace(&mut self.1, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `self.1.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | return Ok(CpuPoolHandle(future, None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return Ok(CpuPoolHandle(future, None)); [INFO] [stdout] 141 + Ok(CpuPoolHandle(future, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/spawn/futurecpupool2.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !self.1.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.1.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/futurecpupool2.rs:73:34 [INFO] [stdout] | [INFO] [stdout] 73 | if let Some((s, d, res)) = replace(&mut self.1, None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `self.1.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/spawn/futurecpupool.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !self.1.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.1.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool2.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | return Ok(CpuPoolHandleFuture(future, None, recv)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return Ok(CpuPoolHandleFuture(future, None, recv)); [INFO] [stdout] 157 + Ok(CpuPoolHandleFuture(future, None, recv)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool2.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 127 | return okfuture((service, spawn_out, Ok(()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 ~ okfuture((service, spawn_out, Ok(()))) [INFO] [stdout] 128 | } [INFO] [stdout] ... [INFO] [stdout] 136 | }, [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool2.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 134 | return okfuture((service, spawn_out, Err(e))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 ~ okfuture((service, spawn_out, Err(e))) [INFO] [stdout] 135 | // return errfuture((service,spawn_out,e)) [INFO] [stdout] 136 | }, [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/futurecpupool.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 77 | let r = replace(&mut self.1, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `self.1.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool.rs:141:5 [INFO] [stdout] | [INFO] [stdout] 141 | return Ok(CpuPoolHandle(future, None)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return Ok(CpuPoolHandle(future, None)); [INFO] [stdout] 141 + Ok(CpuPoolHandle(future, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/spawn/mod.rs:148:6 [INFO] [stdout] | [INFO] [stdout] 148 | impl<'a, A: SpawnerYield> SpawnerYield for &'a mut A { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 148 - impl<'a, A: SpawnerYield> SpawnerYield for &'a mut A { [INFO] [stdout] 148 + impl SpawnerYield for &mut A { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NoService` [INFO] [stdout] --> src/noservice.rs:15:3 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | NoService(PhantomData) [INFO] [stdout] 17 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for NoService { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/spawn/futurecpupool2.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !self.1.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `self.1.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `None` [INFO] [stdout] --> src/spawn/futurecpupool2.rs:73:34 [INFO] [stdout] | [INFO] [stdout] 73 | if let Some((s, d, res)) = replace(&mut self.1, None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `self.1.take()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool2.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | return Ok(CpuPoolHandleFuture(future, None, recv)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return Ok(CpuPoolHandleFuture(future, None, recv)); [INFO] [stdout] 157 + Ok(CpuPoolHandleFuture(future, None, recv)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool2.rs:127:19 [INFO] [stdout] | [INFO] [stdout] 127 | return okfuture((service, spawn_out, Ok(()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 ~ okfuture((service, spawn_out, Ok(()))) [INFO] [stdout] 128 | } [INFO] [stdout] ... [INFO] [stdout] 136 | }, [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/spawn/futurecpupool2.rs:134:19 [INFO] [stdout] | [INFO] [stdout] 134 | return okfuture((service, spawn_out, Err(e))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 ~ okfuture((service, spawn_out, Err(e))) [INFO] [stdout] 135 | // return errfuture((service,spawn_out,e)) [INFO] [stdout] 136 | }, [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/spawn/mod.rs:148:6 [INFO] [stdout] | [INFO] [stdout] 148 | impl<'a, A: SpawnerYield> SpawnerYield for &'a mut A { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 148 - impl<'a, A: SpawnerYield> SpawnerYield for &'a mut A { [INFO] [stdout] 148 + impl SpawnerYield for &mut A { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NoService` [INFO] [stdout] --> src/noservice.rs:15:3 [INFO] [stdout] | [INFO] [stdout] 15 | / pub fn new() -> Self { [INFO] [stdout] 16 | | NoService(PhantomData) [INFO] [stdout] 17 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 14 + impl Default for NoService { [INFO] [stdout] 15 + fn default() -> Self { [INFO] [stdout] 16 + Self::new() [INFO] [stdout] 17 + } [INFO] [stdout] 18 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `MpscSender::send` doesn't need a mutable reference [INFO] [stdout] --> src/channels/mpscref.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 44 | >::send(&mut self.0, t.get_sendable())?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 44 - >::send(&mut self.0, t.get_sendable())?; [INFO] [stdout] 44 + >::send(&self.0, t.get_sendable())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/channels/mod.rs:42:6 [INFO] [stdout] | [INFO] [stdout] 42 | impl<'a, C> SpawnSend for &'a mut VecDeque { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 42 - impl<'a, C> SpawnSend for &'a mut VecDeque { [INFO] [stdout] 42 + impl SpawnSend for &mut VecDeque { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually take no `self` [INFO] [stdout] --> src/lib.rs:219:10 [INFO] [stdout] | [INFO] [stdout] 219 | fn new(&mut self) -> Result<(Self::Send, Self::Recv)>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/spawn/restart.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | replace(self, rs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 128 | let _ = replace(self, rs); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `MpscSender::send` doesn't need a mutable reference [INFO] [stdout] --> src/channels/mpscref.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 44 | >::send(&mut self.0, t.get_sendable())?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 44 - >::send(&mut self.0, t.get_sendable())?; [INFO] [stdout] 44 + >::send(&self.0, t.get_sendable())?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/channels/mod.rs:42:6 [INFO] [stdout] | [INFO] [stdout] 42 | impl<'a, C> SpawnSend for &'a mut VecDeque { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 42 - impl<'a, C> SpawnSend for &'a mut VecDeque { [INFO] [stdout] 42 + impl SpawnSend for &mut VecDeque { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually take no `self` [INFO] [stdout] --> src/lib.rs:219:10 [INFO] [stdout] | [INFO] [stdout] 219 | fn new(&mut self) -> Result<(Self::Send, Self::Recv)>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/spawn/restart.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | replace(self, rs); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 128 | let _ = replace(self, rs); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.44s [INFO] running `Command { std: "docker" "inspect" "1c2fb14575b5859905deef6cec25eb90ccf233ed161e084601518eaf9627e3bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c2fb14575b5859905deef6cec25eb90ccf233ed161e084601518eaf9627e3bc", kill_on_drop: false }` [INFO] [stdout] 1c2fb14575b5859905deef6cec25eb90ccf233ed161e084601518eaf9627e3bc