[INFO] cloning repository https://github.com/checkm4ted/rusty-gameoflife [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/checkm4ted/rusty-gameoflife" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcheckm4ted%2Frusty-gameoflife", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcheckm4ted%2Frusty-gameoflife'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d6dd8e76b664ebb487d49b634386993d90c8f61e [INFO] linting checkm4ted/rusty-gameoflife against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcheckm4ted%2Frusty-gameoflife" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/checkm4ted/rusty-gameoflife [INFO] finished tweaking git repo https://github.com/checkm4ted/rusty-gameoflife [INFO] tweaked toml for git repo https://github.com/checkm4ted/rusty-gameoflife written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/checkm4ted/rusty-gameoflife on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/litten2up/raylib-rs` [INFO] [stderr] Updating git submodule `https://github.com/raysan5/raylib` [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: target.nightly-x86_64-pc-windows-msvc.rustflags [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cmake v0.1.57 [INFO] [stderr] Downloaded cond v1.0.5 [INFO] [stderr] Downloaded bindgen v0.63.0 [INFO] [stderr] Downloaded cc v1.2.57 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] acc42ddead21cc2915f3925b0b5e5b83817c02f00a46888d6429122d95548049 [INFO] running `Command { std: "docker" "start" "-a" "acc42ddead21cc2915f3925b0b5e5b83817c02f00a46888d6429122d95548049", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "acc42ddead21cc2915f3925b0b5e5b83817c02f00a46888d6429122d95548049", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acc42ddead21cc2915f3925b0b5e5b83817c02f00a46888d6429122d95548049", kill_on_drop: false }` [INFO] [stdout] acc42ddead21cc2915f3925b0b5e5b83817c02f00a46888d6429122d95548049 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9452c8b3595da02775acf1fdc51f06469ea387c34612edddab1529df9d1cb8d0 [INFO] running `Command { std: "docker" "start" "-a" "9452c8b3595da02775acf1fdc51f06469ea387c34612edddab1529df9d1cb8d0", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: target.nightly-x86_64-pc-windows-msvc.rustflags [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling linux-raw-sys v0.4.15 [INFO] [stderr] Compiling bitflags v2.11.0 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling libloading v0.8.9 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling bindgen v0.63.0 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking cond v1.0.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling raylib-sys v4.5.0 (https://github.com/litten2up/raylib-rs?branch=4.5.0#234081bd) [INFO] [stderr] Checking raylib v4.5.0 (https://github.com/litten2up/raylib-rs?branch=4.5.0#234081bd) [INFO] [stderr] Checking gol-rust v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/impls.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - self.draw_grid = !self.draw_grid; [INFO] [stdout] 25 - return; [INFO] [stdout] 24 + self.draw_grid = !self.draw_grid; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/impls.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / self.camera.target = [INFO] [stdout] 33 | | self.camera.target - d.get_mouse_delta() * (1f32 / self.camera.zoom); [INFO] [stdout] | |________________________________________________________________________________^ help: replace it with: `self.camera.target -= d.get_mouse_delta() * (1f32 / self.camera.zoom)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impls.rs:103:57 [INFO] [stdout] | [INFO] [stdout] 103 | let neighbors_r = (grid.get_alive_neighbors(&cell) as f32 / 8f32 * 255f32) as u8; [INFO] [stdout] | ^^^^^ help: change this to: `cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/impls.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 222 - (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] 222 + !(!cell.alive && neighbors != 3 || neighbors != 2 && neighbors != 3); [INFO] [stdout] | [INFO] [stdout] 222 - (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] 222 + (neighbors == 3 || neighbors == 2) && (neighbors == 3 || cell.alive); [INFO] [stdout] | [INFO] [stdout] 222 - (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] 222 + neighbors == 3 || cell.alive && neighbors == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impls.rs:219:54 [INFO] [stdout] | [INFO] [stdout] 219 | let neighbors = self.get_alive_neighbors(&cell); [INFO] [stdout] | ^^^^^ help: change this to: `cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | d.draw_text(&"| |", WIN_WIDTH - 60, 12, 60, Color::WHITE); [INFO] [stdout] | ^^^^^^ help: change this to: `"| |"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/impls.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - self.draw_grid = !self.draw_grid; [INFO] [stdout] 25 - return; [INFO] [stdout] 24 + self.draw_grid = !self.draw_grid; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/impls.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | / self.camera.target = [INFO] [stdout] 33 | | self.camera.target - d.get_mouse_delta() * (1f32 / self.camera.zoom); [INFO] [stdout] | |________________________________________________________________________________^ help: replace it with: `self.camera.target -= d.get_mouse_delta() * (1f32 / self.camera.zoom)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impls.rs:103:57 [INFO] [stdout] | [INFO] [stdout] 103 | let neighbors_r = (grid.get_alive_neighbors(&cell) as f32 / 8f32 * 255f32) as u8; [INFO] [stdout] | ^^^^^ help: change this to: `cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/impls.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 222 - (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] 222 + !(!cell.alive && neighbors != 3 || neighbors != 2 && neighbors != 3); [INFO] [stdout] | [INFO] [stdout] 222 - (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] 222 + (neighbors == 3 || neighbors == 2) && (neighbors == 3 || cell.alive); [INFO] [stdout] | [INFO] [stdout] 222 - (cell.alive && neighbors == 2 || neighbors == 3) || (!cell.alive && neighbors == 3); [INFO] [stdout] 222 + neighbors == 3 || cell.alive && neighbors == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/impls.rs:219:54 [INFO] [stdout] | [INFO] [stdout] 219 | let neighbors = self.get_alive_neighbors(&cell); [INFO] [stdout] | ^^^^^ help: change this to: `cell` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | d.draw_text(&"| |", WIN_WIDTH - 60, 12, 60, Color::WHITE); [INFO] [stdout] | ^^^^^^ help: change this to: `"| |"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 51s [INFO] running `Command { std: "docker" "inspect" "9452c8b3595da02775acf1fdc51f06469ea387c34612edddab1529df9d1cb8d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9452c8b3595da02775acf1fdc51f06469ea387c34612edddab1529df9d1cb8d0", kill_on_drop: false }` [INFO] [stdout] 9452c8b3595da02775acf1fdc51f06469ea387c34612edddab1529df9d1cb8d0