[INFO] cloning repository https://github.com/chaos-dotcom/planky [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chaos-dotcom/planky" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchaos-dotcom%2Fplanky", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchaos-dotcom%2Fplanky'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 51960401333dea3335cf8504a15190ac5e4b8fd6 [INFO] linting chaos-dotcom/planky against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchaos-dotcom%2Fplanky" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/chaos-dotcom/planky [INFO] finished tweaking git repo https://github.com/chaos-dotcom/planky [INFO] tweaked toml for git repo https://github.com/chaos-dotcom/planky written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/chaos-dotcom/planky on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/chaos-dotcom/planky already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest Rust 1.96.0-nightly compatible versions [INFO] [stderr] Adding mime v0.3.17 [INFO] [stderr] Adding mime_guess v2.0.5 [INFO] [stderr] Adding unicase v2.9.0 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded smawk v0.3.2 [INFO] [stderr] Downloaded zvariant_derive v5.5.3 [INFO] [stderr] Downloaded phf_codegen v0.11.3 [INFO] [stderr] Downloaded enumflags2_derive v0.7.11 [INFO] [stderr] Downloaded zmij v1.0.12 [INFO] [stderr] Downloaded lab v0.11.0 [INFO] [stderr] Downloaded phf v0.11.3 [INFO] [stderr] Downloaded textwrap v0.16.2 [INFO] [stderr] Downloaded windows-link v0.1.1 [INFO] [stderr] Downloaded windows-version v0.1.4 [INFO] [stderr] Downloaded ratatui-widgets v0.3.0 [INFO] [stderr] Downloaded block2 v0.6.1 [INFO] [stderr] Downloaded mac-notification-sys v0.6.9 [INFO] [stderr] Downloaded async-signal v0.2.11 [INFO] [stderr] Downloaded aws-lc-rs v1.15.2 [INFO] [stderr] Downloaded directories v6.0.0 [INFO] [stderr] Downloaded notifica v3.0.2 [INFO] [stderr] Downloaded pest_meta v2.8.5 [INFO] [stderr] Downloaded notify-rust v3.6.3 [INFO] [stderr] Downloaded tauri-winrt-notification v0.7.2 [INFO] [stderr] Downloaded toml_edit v0.22.26 [INFO] [stderr] Downloaded winnow v0.7.10 [INFO] [stderr] Downloaded itertools v0.14.0 [INFO] [stderr] Downloaded dbus v0.6.5 [INFO] [stderr] Downloaded zerocopy v0.8.33 [INFO] [stderr] Downloaded webpki-root-certs v1.0.5 [INFO] [stderr] Downloaded find-msvc-tools v0.1.7 [INFO] [stderr] Downloaded dirs v1.0.5 [INFO] [stderr] Downloaded mac-notification-sys v0.3.0 [INFO] [stderr] Downloaded objc2 v0.6.1 [INFO] [stderr] Downloaded zvariant v5.5.3 [INFO] [stderr] Downloaded chrono v0.4.42 [INFO] [stderr] Downloaded anyhow v1.0.100 [INFO] [stderr] Downloaded pest_derive v2.8.5 [INFO] [stderr] Downloaded pest v2.8.5 [INFO] [stderr] Downloaded vtparse v0.6.2 [INFO] [stderr] Downloaded async-io v2.4.1 [INFO] [stderr] Downloaded toml_datetime v0.6.9 [INFO] [stderr] Downloaded polling v3.8.0 [INFO] [stderr] Downloaded zbus v5.7.1 [INFO] [stderr] Downloaded crossterm v0.29.0 [INFO] [stderr] Downloaded rustls-webpki v0.103.8 [INFO] [stderr] Downloaded security-framework v3.5.1 [INFO] [stderr] Downloaded wezterm-input-types v0.1.0 [INFO] [stderr] Downloaded reqwest v0.13.1 [INFO] [stderr] Downloaded line-clipping v0.3.5 [INFO] [stderr] Downloaded termwiz v0.23.3 [INFO] [stderr] Downloaded finl_unicode v1.4.0 [INFO] [stderr] Downloaded rustls v0.23.36 [INFO] [stderr] Downloaded zerocopy-derive v0.8.33 [INFO] [stderr] Downloaded kasuari v0.4.11 [INFO] [stderr] Downloaded socket2 v0.6.1 [INFO] [stderr] Downloaded zvariant_utils v3.2.0 [INFO] [stderr] Downloaded phf_shared v0.11.3 [INFO] [stderr] Downloaded wezterm-dynamic-derive v0.1.1 [INFO] [stderr] Downloaded strum v0.27.2 [INFO] [stderr] Downloaded ratatui-macros v0.7.0 [INFO] [stderr] Downloaded unicode-linebreak v0.1.5 [INFO] [stderr] Downloaded uuid v1.19.0 [INFO] [stderr] Downloaded num_threads v0.1.7 [INFO] [stderr] Downloaded openssl-probe v0.2.0 [INFO] [stderr] Downloaded aws-lc-sys v0.35.0 [INFO] [stderr] Downloaded quinn v0.11.9 [INFO] [stderr] Downloaded async-process v2.3.1 [INFO] [stderr] Downloaded async-trait v0.1.88 [INFO] [stderr] Downloaded enumflags2 v0.7.11 [INFO] [stderr] Downloaded signal-hook-mio v0.2.4 [INFO] [stderr] Downloaded phf_macros v0.11.3 [INFO] [stderr] Downloaded wezterm-dynamic v0.2.1 [INFO] [stderr] Downloaded ratatui-core v0.1.0 [INFO] [stderr] Downloaded strum_macros v0.27.2 [INFO] [stderr] Downloaded filedescriptor v0.8.3 [INFO] [stderr] Downloaded mac_address v1.1.8 [INFO] [stderr] Downloaded phf_generator v0.11.3 [INFO] [stderr] Downloaded compact_str v0.9.0 [INFO] [stderr] Downloaded unicode-truncate v2.0.0 [INFO] [stderr] Downloaded ratatui v0.30.0 [INFO] [stderr] Downloaded psl-types v2.0.11 [INFO] [stderr] Downloaded publicsuffix v2.3.0 [INFO] [stderr] Downloaded cc v1.2.52 [INFO] [stderr] Downloaded rustls-pki-types v1.13.2 [INFO] [stderr] Downloaded async-executor v1.13.2 [INFO] [stderr] Downloaded hermit-abi v0.5.1 [INFO] [stderr] Downloaded zbus_macros v5.7.1 [INFO] [stderr] Downloaded ratatui-crossterm v0.1.0 [INFO] [stderr] Downloaded memmem v0.1.1 [INFO] [stderr] Downloaded pest_generator v2.8.5 [INFO] [stderr] Downloaded terminfo v0.9.0 [INFO] [stderr] Downloaded termios v0.3.3 [INFO] [stderr] Downloaded atomic v0.6.1 [INFO] [stderr] Downloaded siphasher v1.0.1 [INFO] [stderr] Downloaded ratatui-termwiz v0.1.0 [INFO] [stderr] Downloaded quinn-proto v0.11.13 [INFO] [stderr] Downloaded quinn-udp v0.5.14 [INFO] [stderr] Downloaded unicode-width v0.2.2 [INFO] [stderr] Downloaded ipnet v2.11.0 [INFO] [stderr] Downloaded lru-slab v0.1.2 [INFO] [stderr] Downloaded wezterm-bidi v0.2.3 [INFO] [stderr] Downloaded wezterm-blob-leases v0.1.1 [INFO] [stderr] Downloaded csscolorparser v0.6.2 [INFO] [stderr] Downloaded wezterm-color-types v0.3.0 [INFO] [stderr] Downloaded security-framework-sys v2.15.0 [INFO] [stderr] Downloaded libdbus-sys v0.2.5 [INFO] [stderr] Downloaded fs_extra v1.3.0 [INFO] [stderr] Downloaded iri-string v0.7.10 [INFO] [stderr] Downloaded mio v1.0.4 [INFO] [stderr] Downloaded notify-rust v4.11.7 [INFO] [stderr] Downloaded cookie_store v0.22.0 [INFO] [stderr] Downloaded winrt v0.6.0 [INFO] [stderr] Downloaded rustls-platform-verifier v0.6.2 [INFO] [stderr] Downloaded cmake v0.1.57 [INFO] [stderr] Downloaded ordered-float v4.6.0 [INFO] [stderr] Downloaded lru v0.16.3 [INFO] [stderr] Downloaded rustls-platform-verifier-android v0.1.1 [INFO] [stderr] Downloaded deltae v0.3.2 [INFO] [stderr] Downloaded windows v0.61.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eda6516859de464333be1ffff0aa7179e852e9eef6f09133ea09ea8940ff4d2e [INFO] running `Command { std: "docker" "start" "-a" "eda6516859de464333be1ffff0aa7179e852e9eef6f09133ea09ea8940ff4d2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eda6516859de464333be1ffff0aa7179e852e9eef6f09133ea09ea8940ff4d2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eda6516859de464333be1ffff0aa7179e852e9eef6f09133ea09ea8940ff4d2e", kill_on_drop: false }` [INFO] [stdout] eda6516859de464333be1ffff0aa7179e852e9eef6f09133ea09ea8940ff4d2e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e549773fd214ff170c2bd7b87c109e400f3ecc02f0e95ec5a20d37322bdba93a [INFO] running `Command { std: "docker" "start" "-a" "e549773fd214ff170c2bd7b87c109e400f3ecc02f0e95ec5a20d37322bdba93a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling find-msvc-tools v0.1.7 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling hashbrown v0.15.3 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Compiling winnow v0.7.10 [INFO] [stderr] Compiling equivalent v1.0.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling toml_datetime v0.6.9 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling rustversion v1.0.21 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling aws-lc-rs v1.15.2 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling indexmap v2.9.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Compiling cc v1.2.52 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling toml_edit v0.22.26 [INFO] [stderr] Checking unicode-truncate v2.0.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking line-clipping v0.3.5 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking openssl-probe v0.2.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Compiling aws-lc-sys v0.35.0 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling enumflags2_derive v0.7.11 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking polling v3.8.0 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking kasuari v0.4.11 [INFO] [stderr] Checking async-io v2.4.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking ratatui-core v0.1.0 [INFO] [stderr] Checking async-signal v0.2.11 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking async-process v2.3.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking zvariant_utils v3.2.0 [INFO] [stderr] Checking enumflags2 v0.7.11 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking ratatui-widgets v0.3.0 [INFO] [stderr] Checking ratatui-crossterm v0.1.0 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Compiling zvariant_derive v5.5.3 [INFO] [stderr] Checking ratatui-macros v0.7.0 [INFO] [stderr] Checking ratatui v0.30.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking publicsuffix v2.3.0 [INFO] [stderr] Compiling zvariant v5.5.3 [INFO] [stderr] Checking cookie_store v0.22.0 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Compiling zbus_macros v5.7.1 [INFO] [stderr] Checking zbus v5.7.1 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.1 [INFO] [stderr] Checking notify-rust v4.11.7 [INFO] [stderr] Checking planky v3.0.12 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/todo.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl Todo { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 25 | pub fn new(description: String, due_date: Option) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `due_date` are never read [INFO] [stdout] --> src/planka.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 153 | struct CardDetailsItem { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 154 | #[serde(rename = "id")] [INFO] [stdout] 155 | id: String, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 159 | due_date: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/planka.rs:1399:12 [INFO] [stdout] | [INFO] [stdout] 168 | impl PlankaClient { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1399 | pub fn fetch_board_actions(&self, board_id: &str, before_id: Option<&str>) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1437 | pub fn fetch_card_actions(&self, card_id: &str, before_id: Option<&str>) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1475 | pub fn add_label_to_card(&self, card_id: &str, label_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1497 | pub fn remove_label_from_card(&self, card_id: &str, label_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1516 | pub fn add_member_to_card(&self, card_id: &str, user_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1538 | pub fn remove_member_from_card(&self, card_id: &str, user_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1557 | pub fn create_project_manager(&self, project_id: &str, user_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1580 | pub fn delete_project_manager(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1599 | pub fn fetch_projects(&self) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1635 | pub fn fetch_project_details(&self, project_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1679 | pub fn update_project( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1717 | pub fn delete_project(&self, project_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1736 | pub fn fetch_task_list(&self, task_list_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1772 | pub fn update_task_list( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1806 | pub fn delete_task_list(&self, task_list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1825 | pub fn update_board( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1865 | pub fn delete_board(&self, board_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1882 | pub fn fetch_board_details(&self, board_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1929 | pub fn create_board_membership(&self, board_id: &str, user_id: &str, role: &str, can_comment: Option) -> Result, can_comment: Option) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1976 | pub fn delete_board_membership(&self, membership_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1993 | pub fn create_label(&self, board_id: &str, color: &str, name: Option<&str>, position: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2017 | pub fn update_label(&self, label_id: &str, position: Option, name: Option<&str>, color: Option<&str>) -> Result<(), Strin... [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2041 | pub fn delete_label(&self, label_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2058 | pub fn clear_list(&self, list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2077 | pub fn create_list(&self, board_id: &str, name: &str, list_type: Option<&str>, position: Option, color: Option<&str>) -> ... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2102 | pub fn fetch_list_details(&self, list_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2136 | pub fn update_list(&self, list_id: &str, board_id: Option<&str>, list_type: Option<&str>, position: Option, name: Option<... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2162 | pub fn delete_list(&self, list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2179 | pub fn move_list_cards(&self, source_list_id: &str, target_list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2199 | pub fn sort_list(&self, list_id: &str, field_name: &str, order: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2275 | pub fn upload_background_image(&self, project_id: &str, file_path: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2302 | pub fn delete_background_image(&self, background_image_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2322 | pub fn create_base_custom_field_group(&self, project_id: &str, name: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2344 | pub fn update_base_custom_field_group(&self, id: &str, name: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2367 | pub fn delete_base_custom_field_group(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2482 | pub fn get_custom_field_group(&self, id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2564 | pub fn create_custom_field_in_base_group(&self, base_custom_field_group_id: &str, position: i64, name: &str, show_on_front_of_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2604 | pub fn delete_custom_field(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2616 | pub fn update_custom_field(&self, id: &str, position: Option, name: Option<&str>, show_on_front_of_card: Option) ->... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2635 | pub fn accept_terms(&self, pending_token: &str, signature: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2650 | pub fn logout_me(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2664 | pub fn exchange_with_oidc(&self, code: &str, nonce: &str, with_http_only_token: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2682 | pub fn revoke_pending_token(&self, pending_token: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2696 | pub fn fetch_server_config(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2717 | pub fn create_board_notification_service(&self, board_id: &str, url_value: &str, format_value: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2729 | pub fn create_user_notification_service(&self, user_id: &str, url_value: &str, format_value: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2741 | pub fn delete_notification_service(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2752 | pub fn update_notification_service(&self, id: &str, url_value: Option<&str>, format_value: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2767 | pub fn test_notification_service(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2778 | pub fn fetch_notifications(&self) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2803 | pub fn read_all_notifications(&self) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2814 | pub fn fetch_notification(&self, id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2834 | pub fn update_notification(&self, id: &str, is_read: bool) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2845 | pub fn fetch_terms(&self, r#type: &str, language: Option<&str>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2867 | pub fn create_user(&self, email: &str, password: &str, role: &str, name: &str, username: Option<&str>) -> Result Result, String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2909 | pub fn delete_user(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2920 | pub fn fetch_user(&self, id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2940 | pub fn update_user(&self, id: &str, role: Option<&str>, name: Option<&str>, is_deactivated: Option) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2956 | pub fn update_user_avatar(&self, id: &str, file_path: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2968 | pub fn update_user_email(&self, id: &str, email: &str, current_password: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2982 | pub fn update_user_password(&self, id: &str, password: &str, current_password: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2996 | pub fn update_user_username(&self, id: &str, username: Option<&str>, current_password: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3010 | pub fn create_webhook( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3039 | pub fn fetch_webhooks(&self) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3064 | pub fn delete_webhook(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3075 | pub fn update_webhook( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `user_id` is never read [INFO] [stdout] --> src/planka.rs:3192:9 [INFO] [stdout] | [INFO] [stdout] 3190 | pub struct PlankaComment { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 3191 | pub id: String, [INFO] [stdout] 3192 | pub user_id: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaComment` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `task_list_id` are never read [INFO] [stdout] --> src/planka.rs:3208:9 [INFO] [stdout] | [INFO] [stdout] 3206 | pub struct PlankaTask { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 3207 | pub id: String, [INFO] [stdout] 3208 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 3209 | pub is_completed: bool, [INFO] [stdout] 3210 | pub task_list_id: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaTask` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `show_on_front_of_card` is never read [INFO] [stdout] --> src/planka.rs:3217:9 [INFO] [stdout] | [INFO] [stdout] 3214 | pub struct PlankaCustomField { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 3217 | pub show_on_front_of_card: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaCustomField` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `description` and `attachments` are never read [INFO] [stdout] --> src/planka.rs:3232:9 [INFO] [stdout] | [INFO] [stdout] 3229 | pub struct PlankaCardDetails { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 3232 | pub description: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3239 | pub attachments: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaCardDetails` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaAction` is never constructed [INFO] [stdout] --> src/planka.rs:3249:12 [INFO] [stdout] | [INFO] [stdout] 3249 | pub struct PlankaAction { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaProject` is never constructed [INFO] [stdout] --> src/planka.rs:3259:12 [INFO] [stdout] | [INFO] [stdout] 3259 | pub struct PlankaProject { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaProjectDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3267:12 [INFO] [stdout] | [INFO] [stdout] 3267 | pub struct PlankaProjectDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaTaskListDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3276:12 [INFO] [stdout] | [INFO] [stdout] 3276 | pub struct PlankaTaskListDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaBoardDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3283:12 [INFO] [stdout] | [INFO] [stdout] 3283 | pub struct PlankaBoardDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaListDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3292:12 [INFO] [stdout] | [INFO] [stdout] 3292 | pub struct PlankaListDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaServerConfig` is never constructed [INFO] [stdout] --> src/planka.rs:3299:12 [INFO] [stdout] | [INFO] [stdout] 3299 | pub struct PlankaServerConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaOidcConfig` is never constructed [INFO] [stdout] --> src/planka.rs:3306:12 [INFO] [stdout] | [INFO] [stdout] 3306 | pub struct PlankaOidcConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaNotification` is never constructed [INFO] [stdout] --> src/planka.rs:3313:12 [INFO] [stdout] | [INFO] [stdout] 3313 | pub struct PlankaNotification { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaNotificationService` is never constructed [INFO] [stdout] --> src/planka.rs:3324:12 [INFO] [stdout] | [INFO] [stdout] 3324 | pub struct PlankaNotificationService { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaUser` is never constructed [INFO] [stdout] --> src/planka.rs:3333:12 [INFO] [stdout] | [INFO] [stdout] 3333 | pub struct PlankaUser { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaWebhook` is never constructed [INFO] [stdout] --> src/planka.rs:3343:12 [INFO] [stdout] | [INFO] [stdout] 3343 | pub struct PlankaWebhook { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaTerms` is never constructed [INFO] [stdout] --> src/planka.rs:3353:12 [INFO] [stdout] | [INFO] [stdout] 3353 | pub struct PlankaTerms { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/app.rs:164:1 [INFO] [stdout] | [INFO] [stdout] 164 | / impl Default for InputMode { [INFO] [stdout] 165 | | fn default() -> Self { [INFO] [stdout] 166 | | InputMode::Normal [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Default)] [INFO] [stdout] 60 | pub enum InputMode { [INFO] [stdout] 61 ~ #[default] [INFO] [stdout] 62 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:359:17 [INFO] [stdout] | [INFO] [stdout] 359 | / if let Some(cfg) = cfg { [INFO] [stdout] 360 | | if let Ok((client, _)) = PlankaClient::from_config(cfg) { [INFO] [stdout] 361 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 362 | | for b in boards { [INFO] [stdout] ... | [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 359 ~ if let Some(cfg) = cfg [INFO] [stdout] 360 ~ && let Ok((client, _)) = PlankaClient::from_config(cfg) { [INFO] [stdout] 361 | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] ... [INFO] [stdout] 406 | } [INFO] [stdout] 407 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:360:21 [INFO] [stdout] | [INFO] [stdout] 360 | / if let Ok((client, _)) = PlankaClient::from_config(cfg) { [INFO] [stdout] 361 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 362 | | for b in boards { [INFO] [stdout] 363 | | if let Ok(lists) = client.resolve_lists(&b.name) { [INFO] [stdout] ... | [INFO] [stdout] 407 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 360 ~ if let Ok((client, _)) = PlankaClient::from_config(cfg) [INFO] [stdout] 361 ~ && let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 362 | for b in boards { [INFO] [stdout] ... [INFO] [stdout] 405 | } [INFO] [stdout] 406 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:422:58 [INFO] [stdout] | [INFO] [stdout] 422 | t.due_date = due.as_deref().and_then(|s| format_planka_due(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:431:59 [INFO] [stdout] | [INFO] [stdout] 431 | due_date: due.as_deref().and_then(|s| format_planka_due(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:434:34 [INFO] [stdout] | [INFO] [stdout] 434 | ... .map(|s| format_planka_created(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_created` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:462:21 [INFO] [stdout] | [INFO] [stdout] 462 | / if let Ok(lists) = client.resolve_lists(&op.project) { [INFO] [stdout] 463 | | if let Some(name) = op.name.clone() { [INFO] [stdout] 464 | | let due = op.due.as_deref(); [INFO] [stdout] 465 | | if let Ok(cid) = client.create_card(&lists.todo_list_id, &name, due) { [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 462 ~ if let Ok(lists) = client.resolve_lists(&op.project) [INFO] [stdout] 463 ~ && let Some(name) = op.name.clone() { [INFO] [stdout] 464 | let due = op.due.as_deref(); [INFO] [stdout] ... [INFO] [stdout] 489 | } [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:494:21 [INFO] [stdout] | [INFO] [stdout] 494 | / if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] 495 | | if client.move_card(cid, lid).is_ok() { [INFO] [stdout] 496 | | if let Some(t) = self.todos.iter_mut().find(|t| t.planka_card_id.as_deref() == Some(cid.as_str())) { [INFO] [stdout] 497 | | t.planka_list_id = Some(lid.to_string()); [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 494 ~ if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) [INFO] [stdout] 495 ~ && client.move_card(cid, lid).is_ok() { [INFO] [stdout] 496 | if let Some(t) = self.todos.iter_mut().find(|t| t.planka_card_id.as_deref() == Some(cid.as_str())) { [INFO] [stdout] ... [INFO] [stdout] 503 | } [INFO] [stdout] 504 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:508:21 [INFO] [stdout] | [INFO] [stdout] 508 | / if let Some(ref cid) = op.card_id { [INFO] [stdout] 509 | | if client.delete_card(cid).is_ok() { [INFO] [stdout] 510 | | if let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] 511 | | self.pending_ops.remove(pos); [INFO] [stdout] ... | [INFO] [stdout] 515 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 508 ~ if let Some(ref cid) = op.card_id [INFO] [stdout] 509 ~ && client.delete_card(cid).is_ok() { [INFO] [stdout] 510 | if let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] ... [INFO] [stdout] 513 | } [INFO] [stdout] 514 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:509:25 [INFO] [stdout] | [INFO] [stdout] 509 | / if client.delete_card(cid).is_ok() { [INFO] [stdout] 510 | | if let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] 511 | | self.pending_ops.remove(pos); [INFO] [stdout] 512 | | any_removed = true; [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 509 ~ if client.delete_card(cid).is_ok() [INFO] [stdout] 510 ~ && let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] 511 | self.pending_ops.remove(pos); [INFO] [stdout] 512 | any_removed = true; [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/app.rs:494:34 [INFO] [stdout] | [INFO] [stdout] 494 | if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 494 - if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] 494 + if let (Some(cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:554:17 [INFO] [stdout] | [INFO] [stdout] 554 | / if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 555 | | if !boards.is_empty() { [INFO] [stdout] 556 | | let names: Vec = boards.iter().map(|b| b.name.clone()).collect(); [INFO] [stdout] 557 | | self.planka_boards = boards; [INFO] [stdout] ... | [INFO] [stdout] 566 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 554 ~ if let Ok(boards) = client.fetch_boards() [INFO] [stdout] 555 ~ && !boards.is_empty() { [INFO] [stdout] 556 | let names: Vec = boards.iter().map(|b| b.name.clone()).collect(); [INFO] [stdout] ... [INFO] [stdout] 564 | } [INFO] [stdout] 565 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:559:25 [INFO] [stdout] | [INFO] [stdout] 559 | / if !self.projects.iter().any(|p| p == &self.current_project) { [INFO] [stdout] 560 | | if let Some(first) = self.projects.get(0) { [INFO] [stdout] 561 | | self.current_project = first.clone(); [INFO] [stdout] 562 | | self.selected = 0; [INFO] [stdout] 563 | | } [INFO] [stdout] 564 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 559 ~ if !self.projects.iter().any(|p| p == &self.current_project) [INFO] [stdout] 560 ~ && let Some(first) = self.projects.get(0) { [INFO] [stdout] 561 | self.current_project = first.clone(); [INFO] [stdout] 562 | self.selected = 0; [INFO] [stdout] 563 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.projects.get(0)` [INFO] [stdout] --> src/app.rs:560:50 [INFO] [stdout] | [INFO] [stdout] 560 | ... if let Some(first) = self.projects.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.projects.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:603:29 [INFO] [stdout] | [INFO] [stdout] 603 | / ... if t.project == self.current_project { [INFO] [stdout] 604 | | ... if let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 605 | | ... index_by_card.insert(cid.clone(), i); [INFO] [stdout] 606 | | ... } [INFO] [stdout] 607 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 603 ~ if t.project == self.current_project [INFO] [stdout] 604 ~ && let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 605 | index_by_card.insert(cid.clone(), i); [INFO] [stdout] 606 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:620:51 [INFO] [stdout] | [INFO] [stdout] 620 | ... .and_then(|s| format_planka_due(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:632:76 [INFO] [stdout] | [INFO] [stdout] 632 | ... due_date: card.due.as_deref().and_then(|s| format_planka_due(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:636:46 [INFO] [stdout] | [INFO] [stdout] 636 | ... .map(|s| format_planka_created(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_created` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:664:9 [INFO] [stdout] | [INFO] [stdout] 664 | / if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 665 | | if !boards.is_empty() { [INFO] [stdout] 666 | | self.planka_boards = boards.clone(); [INFO] [stdout] 667 | | self.projects = boards.iter().map(|b| b.name.clone()).collect(); [INFO] [stdout] ... | [INFO] [stdout] 675 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 664 ~ if let Ok(boards) = client.fetch_boards() [INFO] [stdout] 665 ~ && !boards.is_empty() { [INFO] [stdout] 666 | self.planka_boards = boards.clone(); [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] 674 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:668:17 [INFO] [stdout] | [INFO] [stdout] 668 | / if !self.projects.iter().any(|p| p == &self.current_project) { [INFO] [stdout] 669 | | if let Some(first) = self.projects.get(0) { [INFO] [stdout] 670 | | self.current_project = first.clone(); [INFO] [stdout] 671 | | self.selected = 0; [INFO] [stdout] 672 | | } [INFO] [stdout] 673 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 668 ~ if !self.projects.iter().any(|p| p == &self.current_project) [INFO] [stdout] 669 ~ && let Some(first) = self.projects.get(0) { [INFO] [stdout] 670 | self.current_project = first.clone(); [INFO] [stdout] 671 | self.selected = 0; [INFO] [stdout] 672 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.projects.get(0)` [INFO] [stdout] --> src/app.rs:669:42 [INFO] [stdout] | [INFO] [stdout] 669 | if let Some(first) = self.projects.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.projects.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:717:17 [INFO] [stdout] | [INFO] [stdout] 717 | / if t.project == proj { [INFO] [stdout] 718 | | if let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 719 | | local_index.insert(cid.clone(), i); [INFO] [stdout] 720 | | } [INFO] [stdout] 721 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 717 ~ if t.project == proj [INFO] [stdout] 718 ~ && let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 719 | local_index.insert(cid.clone(), i); [INFO] [stdout] 720 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/app.rs:724:50 [INFO] [stdout] | [INFO] [stdout] 724 | for (_cid, (rcard, rdone, rlist)) in &remote_by_id { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 724 - for (_cid, (rcard, rdone, rlist)) in &remote_by_id { [INFO] [stdout] 724 + for (rcard, rdone, rlist) in remote_by_id.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:732:39 [INFO] [stdout] | [INFO] [stdout] 732 | ... .and_then(|s| format_planka_due(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:744:65 [INFO] [stdout] | [INFO] [stdout] 744 | due_date: rcard.due.as_deref().and_then(|s| format_planka_due(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:748:34 [INFO] [stdout] | [INFO] [stdout] 748 | ... .map(|s| format_planka_created(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_created` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:844:17 [INFO] [stdout] | [INFO] [stdout] 844 | / if let Some(existing) = self.planka_config.as_ref() { [INFO] [stdout] 845 | | if !existing.email_or_username.is_empty() { [INFO] [stdout] 846 | | self.input_planka = existing.email_or_username.clone(); [INFO] [stdout] 847 | | } [INFO] [stdout] 848 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 844 ~ if let Some(existing) = self.planka_config.as_ref() [INFO] [stdout] 845 ~ && !existing.email_or_username.is_empty() { [INFO] [stdout] 846 | self.input_planka = existing.email_or_username.clone(); [INFO] [stdout] 847 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:857:17 [INFO] [stdout] | [INFO] [stdout] 857 | / if let Some(existing) = self.planka_config.as_ref() { [INFO] [stdout] 858 | | if !existing.password.is_empty() { [INFO] [stdout] 859 | | self.input_planka = existing.password.clone(); [INFO] [stdout] 860 | | } [INFO] [stdout] 861 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 857 ~ if let Some(existing) = self.planka_config.as_ref() [INFO] [stdout] 858 ~ && !existing.password.is_empty() { [INFO] [stdout] 859 | self.input_planka = existing.password.clone(); [INFO] [stdout] 860 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:889:9 [INFO] [stdout] | [INFO] [stdout] 889 | / if self.planka_boards.is_empty() { [INFO] [stdout] 890 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 891 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | | self.planka_boards = boards; [INFO] [stdout] ... | [INFO] [stdout] 895 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 889 ~ if self.planka_boards.is_empty() [INFO] [stdout] 890 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 891 | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | self.planka_boards = boards; [INFO] [stdout] 893 | } [INFO] [stdout] 894 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:890:13 [INFO] [stdout] | [INFO] [stdout] 890 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 891 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | | self.planka_boards = boards; [INFO] [stdout] 893 | | } [INFO] [stdout] 894 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 890 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 891 ~ && let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | self.planka_boards = boards; [INFO] [stdout] 893 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:901:13 [INFO] [stdout] | [INFO] [stdout] 901 | / if let Some(ref pid) = b.project_id { [INFO] [stdout] 902 | | if seen.insert(pid.clone()) { [INFO] [stdout] 903 | | let pname = b.project_name.clone().unwrap_or_else(|| "Project".to_string()); [INFO] [stdout] 904 | | projects.push((pid.clone(), pname)); [INFO] [stdout] 905 | | } [INFO] [stdout] 906 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 901 ~ if let Some(ref pid) = b.project_id [INFO] [stdout] 902 ~ && seen.insert(pid.clone()) { [INFO] [stdout] 903 | let pname = b.project_name.clone().unwrap_or_else(|| "Project".to_string()); [INFO] [stdout] 904 | projects.push((pid.clone(), pname)); [INFO] [stdout] 905 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:909:9 [INFO] [stdout] | [INFO] [stdout] 909 | projects.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 909 - projects.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] 909 + projects.sort_by_key(|a| a.1.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:913:9 [INFO] [stdout] | [INFO] [stdout] 913 | / if let Some(cur_pid) = self [INFO] [stdout] 914 | | .planka_boards [INFO] [stdout] 915 | | .iter() [INFO] [stdout] 916 | | .find(|b| b.name == self.current_project) [INFO] [stdout] ... | [INFO] [stdout] 922 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 917 ~ .and_then(|b| b.project_id.clone()) [INFO] [stdout] 918 ~ && let Some(pos) = projects.iter().position(|(id, _)| *id == cur_pid) { [INFO] [stdout] 919 | sel = pos; [INFO] [stdout] 920 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:1194:12 [INFO] [stdout] | [INFO] [stdout] 1194 | if new_done || (!new_done && was_done) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1194 - if new_done || (!new_done && was_done) { [INFO] [stdout] 1194 + if !(!new_done && !was_done) { [INFO] [stdout] | [INFO] [stdout] 1194 - if new_done || (!new_done && was_done) { [INFO] [stdout] 1194 + if new_done || was_done { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1194:9 [INFO] [stdout] | [INFO] [stdout] 1194 | / if new_done || (!new_done && was_done) { [INFO] [stdout] 1195 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1196 | | let lists = if let Some(l) = self.planka_lists_by_board.get(&self.current_project).cloned() { [INFO] [stdout] 1197 | | l [INFO] [stdout] ... | [INFO] [stdout] 1236 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1194 ~ if (new_done || (!new_done && was_done)) { [INFO] [stdout] 1195 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1196 | let lists = if let Some(l) = self.planka_lists_by_board.get(&self.current_project).cloned() { [INFO] [stdout] ... [INFO] [stdout] 1234 | } [INFO] [stdout] 1235 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/app.rs:1251:9 [INFO] [stdout] | [INFO] [stdout] 1251 | let target_is_doing: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1276 | target_is_doing = current_list_id.as_deref() != Some(lists.doing_list_id.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `target_is_doing` here [INFO] [stdout] | [INFO] [stdout] 1251 ~ [INFO] [stdout] 1252 | let lists = match self.ensure_planka_client() { [INFO] [stdout] ... [INFO] [stdout] 1275 | // Decide toggle target based on current list [INFO] [stdout] 1276 ~ let target_is_doing: bool = current_list_id.as_deref() != Some(lists.doing_list_id.as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1325:9 [INFO] [stdout] | [INFO] [stdout] 1325 | / if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] 1326 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1327 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1328 | | self.planka_lists_by_board [INFO] [stdout] ... | [INFO] [stdout] 1333 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1325 ~ if self.planka_lists_by_board.get(&self.current_project).is_none() [INFO] [stdout] 1326 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1327 | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] ... [INFO] [stdout] 1331 | } [INFO] [stdout] 1332 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&self.current_project).is_none()` [INFO] [stdout] --> src/app.rs:1325:39 [INFO] [stdout] | [INFO] [stdout] 1325 | if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] | ---------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.planka_lists_by_board.contains_key(&self.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1326:13 [INFO] [stdout] | [INFO] [stdout] 1326 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1327 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1328 | | self.planka_lists_by_board [INFO] [stdout] 1329 | | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1332 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1326 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 1327 ~ && let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1328 | self.planka_lists_by_board [INFO] [stdout] 1329 | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] 1330 | self.planka_lists = Some(lists); [INFO] [stdout] 1331 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1345:9 [INFO] [stdout] | [INFO] [stdout] 1345 | / if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] 1346 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1347 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1348 | | self.planka_lists_by_board [INFO] [stdout] ... | [INFO] [stdout] 1353 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1345 ~ if self.planka_lists_by_board.get(&self.current_project).is_none() [INFO] [stdout] 1346 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1347 | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] ... [INFO] [stdout] 1351 | } [INFO] [stdout] 1352 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&self.current_project).is_none()` [INFO] [stdout] --> src/app.rs:1345:39 [INFO] [stdout] | [INFO] [stdout] 1345 | if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] | ---------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.planka_lists_by_board.contains_key(&self.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1346:13 [INFO] [stdout] | [INFO] [stdout] 1346 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1347 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1348 | | self.planka_lists_by_board [INFO] [stdout] 1349 | | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1352 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1346 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 1347 ~ && let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1348 | self.planka_lists_by_board [INFO] [stdout] 1349 | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] 1350 | self.planka_lists = Some(lists); [INFO] [stdout] 1351 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1364:9 [INFO] [stdout] | [INFO] [stdout] 1364 | / if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] 1365 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1366 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1367 | | self.planka_lists_by_board [INFO] [stdout] ... | [INFO] [stdout] 1372 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1364 ~ if self.planka_lists_by_board.get(&self.current_project).is_none() [INFO] [stdout] 1365 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1366 | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] ... [INFO] [stdout] 1370 | } [INFO] [stdout] 1371 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&self.current_project).is_none()` [INFO] [stdout] --> src/app.rs:1364:39 [INFO] [stdout] | [INFO] [stdout] 1364 | if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] | ---------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.planka_lists_by_board.contains_key(&self.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1365:13 [INFO] [stdout] | [INFO] [stdout] 1365 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1366 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1367 | | self.planka_lists_by_board [INFO] [stdout] 1368 | | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1371 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1365 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 1366 ~ && let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1367 | self.planka_lists_by_board [INFO] [stdout] 1368 | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] 1369 | self.planka_lists = Some(lists); [INFO] [stdout] 1370 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1613:9 [INFO] [stdout] | [INFO] [stdout] 1613 | / if let Some(vc) = self.view_card.as_ref() { [INFO] [stdout] 1614 | | if let Some(last) = vc.attachments_full.last() { [INFO] [stdout] 1615 | | self.input_attachment_name = last.name.clone(); [INFO] [stdout] 1616 | | self.input_mode = InputMode::RenamingAttachment; [INFO] [stdout] ... | [INFO] [stdout] 1620 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1613 ~ if let Some(vc) = self.view_card.as_ref() [INFO] [stdout] 1614 ~ && let Some(last) = vc.attachments_full.last() { [INFO] [stdout] 1615 | self.input_attachment_name = last.name.clone(); [INFO] [stdout] ... [INFO] [stdout] 1618 | return; [INFO] [stdout] 1619 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1751:13 [INFO] [stdout] | [INFO] [stdout] 1751 | / if let Some(vc) = self.view_card.as_ref() { [INFO] [stdout] 1752 | | if let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1753 | | if let Some(v) = g.values_by_field.get(&fid) { [INFO] [stdout] 1754 | | self.input_custom_field_value = v.clone(); [INFO] [stdout] ... | [INFO] [stdout] 1759 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1751 ~ if let Some(vc) = self.view_card.as_ref() [INFO] [stdout] 1752 ~ && let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1753 | if let Some(v) = g.values_by_field.get(&fid) { [INFO] [stdout] ... [INFO] [stdout] 1757 | } [INFO] [stdout] 1758 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1799:9 [INFO] [stdout] | [INFO] [stdout] 1799 | / if let Some(vc) = self.view_card.as_ref() { [INFO] [stdout] 1800 | | if let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1801 | | self.input_cfg_group_name = g.name.clone().unwrap_or_default(); [INFO] [stdout] 1802 | | self.input_mode = InputMode::RenamingCustomFieldGroup; [INFO] [stdout] ... | [INFO] [stdout] 1806 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1799 ~ if let Some(vc) = self.view_card.as_ref() [INFO] [stdout] 1800 ~ && let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1801 | self.input_cfg_group_name = g.name.clone().unwrap_or_default(); [INFO] [stdout] ... [INFO] [stdout] 1804 | return; [INFO] [stdout] 1805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | / if !todo.done { [INFO] [stdout] 23 | | if let Some(due) = &todo.due_date { [INFO] [stdout] 24 | | if due == &today { [INFO] [stdout] 25 | | #[cfg(target_os = "linux")] [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 22 ~ if !todo.done [INFO] [stdout] 23 ~ && let Some(due) = &todo.due_date { [INFO] [stdout] 24 | if due == &today { [INFO] [stdout] ... [INFO] [stdout] 49 | } [INFO] [stdout] 50 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | / if let Some(due) = &todo.due_date { [INFO] [stdout] 24 | | if due == &today { [INFO] [stdout] 25 | | #[cfg(target_os = "linux")] [INFO] [stdout] 26 | | Notification::new() [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ if let Some(due) = &todo.due_date [INFO] [stdout] 24 ~ && due == &today { [INFO] [stdout] 25 | #[cfg(target_os = "linux")] [INFO] [stdout] ... [INFO] [stdout] 48 | } [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / if app.planka_lists_by_board.get(&app.current_project).is_none() { [INFO] [stdout] 31 | | if let Ok(client) = app.ensure_planka_client() { [INFO] [stdout] 32 | | // Ensure boards are cached so the header can show "Project - Board" [INFO] [stdout] 33 | | if app.planka_boards.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if app.planka_lists_by_board.get(&app.current_project).is_none() [INFO] [stdout] 31 ~ && let Ok(client) = app.ensure_planka_client() { [INFO] [stdout] 32 | // Ensure boards are cached so the header can show "Project - Board" [INFO] [stdout] ... [INFO] [stdout] 42 | } [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&app.current_project).is_none()` [INFO] [stdout] --> src/tui.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | if app.planka_lists_by_board.get(&app.current_project).is_none() { [INFO] [stdout] | --------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!app.planka_lists_by_board.contains_key(&app.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / if app.planka_boards.is_empty() { [INFO] [stdout] 34 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 35 | | app.planka_boards = boards; [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if app.planka_boards.is_empty() [INFO] [stdout] 34 ~ && let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 35 | app.planka_boards = boards; [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / if crossterm::event::poll(Duration::from_millis(100))? { [INFO] [stdout] 53 | | if let CEvent::Key(key) = event::read()? { [INFO] [stdout] 54 | | if key.kind != KeyEventKind::Press { [INFO] [stdout] 55 | | continue; [INFO] [stdout] ... | [INFO] [stdout] 605 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 52 ~ if crossterm::event::poll(Duration::from_millis(100))? [INFO] [stdout] 53 ~ && let CEvent::Key(key) = event::read()? { [INFO] [stdout] 54 | if key.kind != KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 603 | } [INFO] [stdout] 604 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | / ... if app.selected < filtered_todos(app).len().saturating_sub(1) { [INFO] [stdout] 84 | | ... app.selected += 1; [INFO] [stdout] 85 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ KeyCode::Down [INFO] [stdout] 83 ~ if app.selected < filtered_todos(app).len().saturating_sub(1) => { [INFO] [stdout] 84 | app.selected += 1; [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:88:29 [INFO] [stdout] | [INFO] [stdout] 88 | / ... if app.selected > 0 { [INFO] [stdout] 89 | | ... app.selected -= 1; [INFO] [stdout] 90 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 87 ~ KeyCode::Up [INFO] [stdout] 88 ~ if app.selected > 0 => { [INFO] [stdout] 89 | app.selected -= 1; [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:247:29 [INFO] [stdout] | [INFO] [stdout] 247 | / ... if !app.create_board_projects.is_empty() { [INFO] [stdout] 248 | | ... if app.create_board_project_index == 0 { [INFO] [stdout] 249 | | ... app.create_board_project_index = app.create_board_projects.len() - 1; [INFO] [stdout] 250 | | ... } else { [INFO] [stdout] ... | [INFO] [stdout] 253 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ KeyCode::Left | KeyCode::Char('[') [INFO] [stdout] 247 ~ if !app.create_board_projects.is_empty() => { [INFO] [stdout] 248 | if app.create_board_project_index == 0 { [INFO] [stdout] ... [INFO] [stdout] 252 | } [INFO] [stdout] 253 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:256:29 [INFO] [stdout] | [INFO] [stdout] 256 | / ... if !app.create_board_projects.is_empty() { [INFO] [stdout] 257 | | ... app.create_board_project_index = (app.create_board_project_index + 1) % app.create_board_projects.len(); [INFO] [stdout] 258 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 255 ~ KeyCode::Right | KeyCode::Char(']') [INFO] [stdout] 256 ~ if !app.create_board_projects.is_empty() => { [INFO] [stdout] 257 | app.create_board_project_index = (app.create_board_project_index + 1) % app.create_board_projects.len(); [INFO] [stdout] 258 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/tui.rs:372:71 [INFO] [stdout] | [INFO] [stdout] 372 | KeyCode::Char(c) if app.view_card_tab == 2 && c >= '1' && c <= '9' => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('1'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:374:29 [INFO] [stdout] | [INFO] [stdout] 374 | / ... if let Some(vc) = app.view_card.as_ref() { [INFO] [stdout] 375 | | ... if idx < vc.custom_field_groups.len() { [INFO] [stdout] 376 | | ... app.selected_custom_group_index = idx; [INFO] [stdout] 377 | | ... } [INFO] [stdout] 378 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 374 ~ if let Some(vc) = app.view_card.as_ref() [INFO] [stdout] 375 ~ && idx < vc.custom_field_groups.len() { [INFO] [stdout] 376 | app.selected_custom_group_index = idx; [INFO] [stdout] 377 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:561:29 [INFO] [stdout] | [INFO] [stdout] 561 | ... if app.control_center_index < 4 { app.control_center_index += 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 560 ~ KeyCode::Down [INFO] [stdout] 561 ~ if app.control_center_index < 4 => { app.control_center_index += 1; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:564:29 [INFO] [stdout] | [INFO] [stdout] 564 | ... if app.control_center_index > 0 { app.control_center_index -= 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 563 ~ KeyCode::Up [INFO] [stdout] 564 ~ if app.control_center_index > 0 => { app.control_center_index -= 1; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:592:29 [INFO] [stdout] | [INFO] [stdout] 592 | / ... if app.selected < filtered_todos(app).len().saturating_sub(1) { [INFO] [stdout] 593 | | ... app.selected += 1; [INFO] [stdout] 594 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 591 ~ KeyCode::Down [INFO] [stdout] 592 ~ if app.selected < filtered_todos(app).len().saturating_sub(1) => { [INFO] [stdout] 593 | app.selected += 1; [INFO] [stdout] 594 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:597:29 [INFO] [stdout] | [INFO] [stdout] 597 | / ... if app.selected > 0 { [INFO] [stdout] 598 | | ... app.selected -= 1; [INFO] [stdout] 599 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 596 ~ KeyCode::Up [INFO] [stdout] 597 ~ if app.selected > 0 => { [INFO] [stdout] 598 | app.selected -= 1; [INFO] [stdout] 599 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:1298:5 [INFO] [stdout] | [INFO] [stdout] 1298 | / if let Ok(dt) = NaiveDateTime::parse_from_str(due_date_str, "%Y-%m-%d %H:%M") { [INFO] [stdout] 1299 | | if let Some(dt_local) = Local.from_local_datetime(&dt).single() { [INFO] [stdout] 1300 | | return dt_local < now; [INFO] [stdout] 1301 | | } [INFO] [stdout] 1302 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1298 ~ if let Ok(dt) = NaiveDateTime::parse_from_str(due_date_str, "%Y-%m-%d %H:%M") [INFO] [stdout] 1299 ~ && let Some(dt_local) = Local.from_local_datetime(&dt).single() { [INFO] [stdout] 1300 | return dt_local < now; [INFO] [stdout] 1301 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/tui.rs:1496:18 [INFO] [stdout] | [INFO] [stdout] 1496 | if days <= 0 { [INFO] [stdout] | __________________^ [INFO] [stdout] 1497 | | days + 7 // Next week [INFO] [stdout] 1498 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/tui.rs:1498:12 [INFO] [stdout] | [INFO] [stdout] 1498 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 1499 | | days + 7 // Force next week [INFO] [stdout] 1500 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/tui.rs:1583:17 [INFO] [stdout] | [INFO] [stdout] 1583 | time = time + Dur::hours(12); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time += Dur::hours(12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/tui.rs:1585:17 [INFO] [stdout] | [INFO] [stdout] 1585 | time = time - Dur::hours(12); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time -= Dur::hours(12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:413:13 [INFO] [stdout] | [INFO] [stdout] 413 | / if status.is_success() && !text.trim_start().starts_with('<') { [INFO] [stdout] 414 | | if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 415 | | if let Some(arr) = v [INFO] [stdout] 416 | | .get("included") [INFO] [stdout] ... | [INFO] [stdout] 432 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 413 ~ if status.is_success() && !text.trim_start().starts_with('<') [INFO] [stdout] 414 ~ && let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 415 | if let Some(arr) = v [INFO] [stdout] ... [INFO] [stdout] 430 | } [INFO] [stdout] 431 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:414:17 [INFO] [stdout] | [INFO] [stdout] 414 | / if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 415 | | if let Some(arr) = v [INFO] [stdout] 416 | | .get("included") [INFO] [stdout] 417 | | .and_then(|i| i.get("lists")) [INFO] [stdout] ... | [INFO] [stdout] 431 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 414 ~ if let Ok(v) = serde_json::from_str::(&text) [INFO] [stdout] 415 ~ && let Some(arr) = v [INFO] [stdout] 416 | .get("included") [INFO] [stdout] ... [INFO] [stdout] 429 | } [INFO] [stdout] 430 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | / if lists.is_empty() { [INFO] [stdout] 437 | | if let Some(ref project_id) = board.project_id { [INFO] [stdout] 438 | | let url = format!("{}/api/projects/{}?include=boards,lists", base, project_id); [INFO] [stdout] 439 | | let auth = self.auth_header(); [INFO] [stdout] ... | [INFO] [stdout] 492 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 436 ~ if lists.is_empty() [INFO] [stdout] 437 ~ && let Some(ref project_id) = board.project_id { [INFO] [stdout] 438 | let url = format!("{}/api/projects/{}?include=boards,lists", base, project_id); [INFO] [stdout] ... [INFO] [stdout] 490 | } [INFO] [stdout] 491 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:463:17 [INFO] [stdout] | [INFO] [stdout] 463 | / if status.is_success() && !text.trim_start().starts_with('<') { [INFO] [stdout] 464 | | if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 465 | | if let Some(arr) = v [INFO] [stdout] 466 | | .get("included") [INFO] [stdout] ... | [INFO] [stdout] 490 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 463 ~ if status.is_success() && !text.trim_start().starts_with('<') [INFO] [stdout] 464 ~ && let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 465 | if let Some(arr) = v [INFO] [stdout] ... [INFO] [stdout] 488 | } [INFO] [stdout] 489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:464:21 [INFO] [stdout] | [INFO] [stdout] 464 | / if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 465 | | if let Some(arr) = v [INFO] [stdout] 466 | | .get("included") [INFO] [stdout] 467 | | .and_then(|i| i.get("lists")) [INFO] [stdout] ... | [INFO] [stdout] 489 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 464 ~ if let Ok(v) = serde_json::from_str::(&text) [INFO] [stdout] 465 ~ && let Some(arr) = v [INFO] [stdout] 466 | .get("included") [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] 488 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:508:20 [INFO] [stdout] | [INFO] [stdout] 508 | } else if n.contains("done") || n.contains("completed") || n.contains("complete") { [INFO] [stdout] | ____________________^ [INFO] [stdout] 509 | | if done_id.is_none() { done_id = Some(id.clone()); } [INFO] [stdout] 510 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 508 ~ } else if (n.contains("done") || n.contains("completed") || n.contains("complete")) { [INFO] [stdout] 509 ~ && done_id.is_none() { done_id = Some(id.clone()); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:840:13 [INFO] [stdout] | [INFO] [stdout] 840 | / if status.is_success() && !text.trim_start().starts_with('<') { [INFO] [stdout] 841 | | if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 842 | | if let Some(arr) = v [INFO] [stdout] 843 | | .get("included") [INFO] [stdout] ... | [INFO] [stdout] 869 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 840 ~ if status.is_success() && !text.trim_start().starts_with('<') [INFO] [stdout] 841 ~ && let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 842 | if let Some(arr) = v [INFO] [stdout] ... [INFO] [stdout] 867 | } [INFO] [stdout] 868 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:841:17 [INFO] [stdout] | [INFO] [stdout] 841 | / if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 842 | | if let Some(arr) = v [INFO] [stdout] 843 | | .get("included") [INFO] [stdout] 844 | | .and_then(|i| i.get("cards")) [INFO] [stdout] ... | [INFO] [stdout] 868 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 841 ~ if let Ok(v) = serde_json::from_str::(&text) [INFO] [stdout] 842 ~ && let Some(arr) = v [INFO] [stdout] 843 | .get("included") [INFO] [stdout] ... [INFO] [stdout] 866 | return Ok(out); [INFO] [stdout] 867 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:860:29 [INFO] [stdout] | [INFO] [stdout] 860 | / ... if c.created.is_none() { [INFO] [stdout] 861 | | ... if let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 862 | | ... c.created = created; [INFO] [stdout] 863 | | ... } [INFO] [stdout] 864 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 860 ~ if c.created.is_none() [INFO] [stdout] 861 ~ && let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 862 | c.created = created; [INFO] [stdout] 863 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:926:13 [INFO] [stdout] | [INFO] [stdout] 926 | / if c.created.is_none() { [INFO] [stdout] 927 | | if let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 928 | | c.created = created; [INFO] [stdout] 929 | | } [INFO] [stdout] 930 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 926 ~ if c.created.is_none() [INFO] [stdout] 927 ~ && let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 928 | c.created = created; [INFO] [stdout] 929 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:994:21 [INFO] [stdout] | [INFO] [stdout] 994 | / ... if lid_json == Some(lid.as_str()) { [INFO] [stdout] 995 | | ... if let Some(n) = l.get("name").and_then(|x| x.as_str()).or_else(|| l.get("title").and_then(|x| x.as_str())) { [INFO] [stdout] 996 | | ... list_name = Some(n.to_string()); [INFO] [stdout] 997 | | ... break; [INFO] [stdout] 998 | | ... } [INFO] [stdout] 999 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 994 ~ if lid_json == Some(lid.as_str()) [INFO] [stdout] 995 ~ && let Some(n) = l.get("name").and_then(|x| x.as_str()).or_else(|| l.get("title").and_then(|x| x.as_str())) { [INFO] [stdout] 996 | list_name = Some(n.to_string()); [INFO] [stdout] 997 | break; [INFO] [stdout] 998 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1017:21 [INFO] [stdout] | [INFO] [stdout] 1017 | / if cl_card == Some(id.as_str()) { [INFO] [stdout] 1018 | | if let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) { [INFO] [stdout] 1019 | | if let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | | labels.push(name.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1023 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1017 ~ if cl_card == Some(id.as_str()) [INFO] [stdout] 1018 ~ && let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) { [INFO] [stdout] 1019 | if let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | labels.push(name.clone()); [INFO] [stdout] 1021 | } [INFO] [stdout] 1022 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1018:25 [INFO] [stdout] | [INFO] [stdout] 1018 | / if let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) { [INFO] [stdout] 1019 | | if let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | | labels.push(name.clone()); [INFO] [stdout] 1021 | | } [INFO] [stdout] 1022 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1018 ~ if let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) [INFO] [stdout] 1019 ~ && let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | labels.push(name.clone()); [INFO] [stdout] 1021 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1080:21 [INFO] [stdout] | [INFO] [stdout] 1080 | / if let (Some(fid), Some(name)) = ( [INFO] [stdout] 1081 | | f.get("id").and_then(|x| x.as_str()), [INFO] [stdout] 1082 | | f.get("name").and_then(|x| x.as_str()), [INFO] [stdout] 1083 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 1094 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1083 ~ ) [INFO] [stdout] 1084 ~ && let Some(gid) = f.get("customFieldGroupId").and_then(|x| x.as_str()) { [INFO] [stdout] 1085 | fields_by_group [INFO] [stdout] ... [INFO] [stdout] 1092 | }); [INFO] [stdout] 1093 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/planka.rs:1115:13 [INFO] [stdout] | [INFO] [stdout] 1115 | fields.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1115 - fields.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 1115 + fields.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/planka.rs:1119:9 [INFO] [stdout] | [INFO] [stdout] 1119 | ... custom_field_groups.sort_by(|a, b| a.name.as_deref().unwrap_or("").to_lowercase().cmp(&b.name.as_deref().unwrap_or("").to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1119 - custom_field_groups.sort_by(|a, b| a.name.as_deref().unwrap_or("").to_lowercase().cmp(&b.name.as_deref().unwrap_or("").to_lowercase())); [INFO] [stdout] 1119 + custom_field_groups.sort_by_key(|a| a.name.as_deref().unwrap_or("").to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1157:9 [INFO] [stdout] | [INFO] [stdout] 1157 | / if let Some(included) = v.get("included").and_then(|x| x.as_object()) { [INFO] [stdout] 1158 | | if let Some(users) = included.get("users").and_then(|x| x.as_array()) { [INFO] [stdout] 1159 | | for u in users { [INFO] [stdout] 1160 | | if let Some(uid) = u.get("id").and_then(|x| x.as_str()) { [INFO] [stdout] ... | [INFO] [stdout] 1167 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1157 ~ if let Some(included) = v.get("included").and_then(|x| x.as_object()) [INFO] [stdout] 1158 ~ && let Some(users) = included.get("users").and_then(|x| x.as_array()) { [INFO] [stdout] 1159 | for u in users { [INFO] [stdout] ... [INFO] [stdout] 1165 | } [INFO] [stdout] 1166 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1160:21 [INFO] [stdout] | [INFO] [stdout] 1160 | / ... if let Some(uid) = u.get("id").and_then(|x| x.as_str()) { [INFO] [stdout] 1161 | | ... if let Some(name) = u.get("name").and_then(|x| x.as_str()).or_else(|| u.get("username").and_then(|x| x.as_str())) { [INFO] [stdout] 1162 | | ... user_name_by_id.insert(uid.to_string(), name.to_string()); [INFO] [stdout] 1163 | | ... } [INFO] [stdout] 1164 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1160 ~ if let Some(uid) = u.get("id").and_then(|x| x.as_str()) [INFO] [stdout] 1161 ~ && let Some(name) = u.get("name").and_then(|x| x.as_str()).or_else(|| u.get("username").and_then(|x| x.as_str())) { [INFO] [stdout] 1162 | user_name_by_id.insert(uid.to_string(), name.to_string()); [INFO] [stdout] 1163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/todo.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl Todo { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 25 | pub fn new(description: String, due_date: Option) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `due_date` are never read [INFO] [stdout] --> src/planka.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 153 | struct CardDetailsItem { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 154 | #[serde(rename = "id")] [INFO] [stdout] 155 | id: String, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 159 | due_date: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/planka.rs:1399:12 [INFO] [stdout] | [INFO] [stdout] 168 | impl PlankaClient { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1399 | pub fn fetch_board_actions(&self, board_id: &str, before_id: Option<&str>) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1437 | pub fn fetch_card_actions(&self, card_id: &str, before_id: Option<&str>) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1475 | pub fn add_label_to_card(&self, card_id: &str, label_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1497 | pub fn remove_label_from_card(&self, card_id: &str, label_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1516 | pub fn add_member_to_card(&self, card_id: &str, user_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1538 | pub fn remove_member_from_card(&self, card_id: &str, user_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1557 | pub fn create_project_manager(&self, project_id: &str, user_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1580 | pub fn delete_project_manager(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1599 | pub fn fetch_projects(&self) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1635 | pub fn fetch_project_details(&self, project_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1679 | pub fn update_project( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1717 | pub fn delete_project(&self, project_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1736 | pub fn fetch_task_list(&self, task_list_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1772 | pub fn update_task_list( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1806 | pub fn delete_task_list(&self, task_list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1825 | pub fn update_board( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1865 | pub fn delete_board(&self, board_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1882 | pub fn fetch_board_details(&self, board_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1929 | pub fn create_board_membership(&self, board_id: &str, user_id: &str, role: &str, can_comment: Option) -> Result, can_comment: Option) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1976 | pub fn delete_board_membership(&self, membership_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1993 | pub fn create_label(&self, board_id: &str, color: &str, name: Option<&str>, position: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2017 | pub fn update_label(&self, label_id: &str, position: Option, name: Option<&str>, color: Option<&str>) -> Result<(), Strin... [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2041 | pub fn delete_label(&self, label_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2058 | pub fn clear_list(&self, list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2077 | pub fn create_list(&self, board_id: &str, name: &str, list_type: Option<&str>, position: Option, color: Option<&str>) -> ... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2102 | pub fn fetch_list_details(&self, list_id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2136 | pub fn update_list(&self, list_id: &str, board_id: Option<&str>, list_type: Option<&str>, position: Option, name: Option<... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2162 | pub fn delete_list(&self, list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2179 | pub fn move_list_cards(&self, source_list_id: &str, target_list_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2199 | pub fn sort_list(&self, list_id: &str, field_name: &str, order: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2275 | pub fn upload_background_image(&self, project_id: &str, file_path: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2302 | pub fn delete_background_image(&self, background_image_id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2322 | pub fn create_base_custom_field_group(&self, project_id: &str, name: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2344 | pub fn update_base_custom_field_group(&self, id: &str, name: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2367 | pub fn delete_base_custom_field_group(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2482 | pub fn get_custom_field_group(&self, id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2564 | pub fn create_custom_field_in_base_group(&self, base_custom_field_group_id: &str, position: i64, name: &str, show_on_front_of_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2604 | pub fn delete_custom_field(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2616 | pub fn update_custom_field(&self, id: &str, position: Option, name: Option<&str>, show_on_front_of_card: Option) ->... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2635 | pub fn accept_terms(&self, pending_token: &str, signature: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2650 | pub fn logout_me(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2664 | pub fn exchange_with_oidc(&self, code: &str, nonce: &str, with_http_only_token: Option) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2682 | pub fn revoke_pending_token(&self, pending_token: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2696 | pub fn fetch_server_config(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2717 | pub fn create_board_notification_service(&self, board_id: &str, url_value: &str, format_value: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2729 | pub fn create_user_notification_service(&self, user_id: &str, url_value: &str, format_value: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2741 | pub fn delete_notification_service(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2752 | pub fn update_notification_service(&self, id: &str, url_value: Option<&str>, format_value: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2767 | pub fn test_notification_service(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2778 | pub fn fetch_notifications(&self) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2803 | pub fn read_all_notifications(&self) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2814 | pub fn fetch_notification(&self, id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2834 | pub fn update_notification(&self, id: &str, is_read: bool) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2845 | pub fn fetch_terms(&self, r#type: &str, language: Option<&str>) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2867 | pub fn create_user(&self, email: &str, password: &str, role: &str, name: &str, username: Option<&str>) -> Result Result, String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2909 | pub fn delete_user(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2920 | pub fn fetch_user(&self, id: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2940 | pub fn update_user(&self, id: &str, role: Option<&str>, name: Option<&str>, is_deactivated: Option) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2956 | pub fn update_user_avatar(&self, id: &str, file_path: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2968 | pub fn update_user_email(&self, id: &str, email: &str, current_password: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2982 | pub fn update_user_password(&self, id: &str, password: &str, current_password: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 2996 | pub fn update_user_username(&self, id: &str, username: Option<&str>, current_password: Option<&str>) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3010 | pub fn create_webhook( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3039 | pub fn fetch_webhooks(&self) -> Result, String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3064 | pub fn delete_webhook(&self, id: &str) -> Result<(), String> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3075 | pub fn update_webhook( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `user_id` is never read [INFO] [stdout] --> src/planka.rs:3192:9 [INFO] [stdout] | [INFO] [stdout] 3190 | pub struct PlankaComment { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 3191 | pub id: String, [INFO] [stdout] 3192 | pub user_id: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaComment` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `task_list_id` are never read [INFO] [stdout] --> src/planka.rs:3208:9 [INFO] [stdout] | [INFO] [stdout] 3206 | pub struct PlankaTask { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 3207 | pub id: String, [INFO] [stdout] 3208 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 3209 | pub is_completed: bool, [INFO] [stdout] 3210 | pub task_list_id: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaTask` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `show_on_front_of_card` is never read [INFO] [stdout] --> src/planka.rs:3217:9 [INFO] [stdout] | [INFO] [stdout] 3214 | pub struct PlankaCustomField { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 3217 | pub show_on_front_of_card: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaCustomField` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `description` and `attachments` are never read [INFO] [stdout] --> src/planka.rs:3232:9 [INFO] [stdout] | [INFO] [stdout] 3229 | pub struct PlankaCardDetails { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 3232 | pub description: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 3239 | pub attachments: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlankaCardDetails` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaAction` is never constructed [INFO] [stdout] --> src/planka.rs:3249:12 [INFO] [stdout] | [INFO] [stdout] 3249 | pub struct PlankaAction { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaProject` is never constructed [INFO] [stdout] --> src/planka.rs:3259:12 [INFO] [stdout] | [INFO] [stdout] 3259 | pub struct PlankaProject { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaProjectDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3267:12 [INFO] [stdout] | [INFO] [stdout] 3267 | pub struct PlankaProjectDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaTaskListDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3276:12 [INFO] [stdout] | [INFO] [stdout] 3276 | pub struct PlankaTaskListDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaBoardDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3283:12 [INFO] [stdout] | [INFO] [stdout] 3283 | pub struct PlankaBoardDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaListDetails` is never constructed [INFO] [stdout] --> src/planka.rs:3292:12 [INFO] [stdout] | [INFO] [stdout] 3292 | pub struct PlankaListDetails { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaServerConfig` is never constructed [INFO] [stdout] --> src/planka.rs:3299:12 [INFO] [stdout] | [INFO] [stdout] 3299 | pub struct PlankaServerConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaOidcConfig` is never constructed [INFO] [stdout] --> src/planka.rs:3306:12 [INFO] [stdout] | [INFO] [stdout] 3306 | pub struct PlankaOidcConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaNotification` is never constructed [INFO] [stdout] --> src/planka.rs:3313:12 [INFO] [stdout] | [INFO] [stdout] 3313 | pub struct PlankaNotification { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaNotificationService` is never constructed [INFO] [stdout] --> src/planka.rs:3324:12 [INFO] [stdout] | [INFO] [stdout] 3324 | pub struct PlankaNotificationService { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaUser` is never constructed [INFO] [stdout] --> src/planka.rs:3333:12 [INFO] [stdout] | [INFO] [stdout] 3333 | pub struct PlankaUser { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaWebhook` is never constructed [INFO] [stdout] --> src/planka.rs:3343:12 [INFO] [stdout] | [INFO] [stdout] 3343 | pub struct PlankaWebhook { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PlankaTerms` is never constructed [INFO] [stdout] --> src/planka.rs:3353:12 [INFO] [stdout] | [INFO] [stdout] 3353 | pub struct PlankaTerms { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/planka.rs:1679:5 [INFO] [stdout] | [INFO] [stdout] 1679 | / pub fn update_project( [INFO] [stdout] 1680 | | &self, [INFO] [stdout] 1681 | | project_id: &str, [INFO] [stdout] 1682 | | name: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 1687 | | background_gradient: Option<&str>, [INFO] [stdout] 1688 | | ) -> Result<(), String> { [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/planka.rs:1825:5 [INFO] [stdout] | [INFO] [stdout] 1825 | / pub fn update_board( [INFO] [stdout] 1826 | | &self, [INFO] [stdout] 1827 | | board_id: &str, [INFO] [stdout] 1828 | | position: Option, [INFO] [stdout] ... | [INFO] [stdout] 1835 | | is_subscribed: Option, [INFO] [stdout] 1836 | | ) -> Result<(), String> { [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/app.rs:164:1 [INFO] [stdout] | [INFO] [stdout] 164 | / impl Default for InputMode { [INFO] [stdout] 165 | | fn default() -> Self { [INFO] [stdout] 166 | | InputMode::Normal [INFO] [stdout] 167 | | } [INFO] [stdout] 168 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Default)] [INFO] [stdout] 60 | pub enum InputMode { [INFO] [stdout] 61 ~ #[default] [INFO] [stdout] 62 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:359:17 [INFO] [stdout] | [INFO] [stdout] 359 | / if let Some(cfg) = cfg { [INFO] [stdout] 360 | | if let Ok((client, _)) = PlankaClient::from_config(cfg) { [INFO] [stdout] 361 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 362 | | for b in boards { [INFO] [stdout] ... | [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 359 ~ if let Some(cfg) = cfg [INFO] [stdout] 360 ~ && let Ok((client, _)) = PlankaClient::from_config(cfg) { [INFO] [stdout] 361 | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] ... [INFO] [stdout] 406 | } [INFO] [stdout] 407 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:360:21 [INFO] [stdout] | [INFO] [stdout] 360 | / if let Ok((client, _)) = PlankaClient::from_config(cfg) { [INFO] [stdout] 361 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 362 | | for b in boards { [INFO] [stdout] 363 | | if let Ok(lists) = client.resolve_lists(&b.name) { [INFO] [stdout] ... | [INFO] [stdout] 407 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 360 ~ if let Ok((client, _)) = PlankaClient::from_config(cfg) [INFO] [stdout] 361 ~ && let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 362 | for b in boards { [INFO] [stdout] ... [INFO] [stdout] 405 | } [INFO] [stdout] 406 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:422:58 [INFO] [stdout] | [INFO] [stdout] 422 | t.due_date = due.as_deref().and_then(|s| format_planka_due(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:431:59 [INFO] [stdout] | [INFO] [stdout] 431 | due_date: due.as_deref().and_then(|s| format_planka_due(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:434:34 [INFO] [stdout] | [INFO] [stdout] 434 | ... .map(|s| format_planka_created(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_created` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:462:21 [INFO] [stdout] | [INFO] [stdout] 462 | / if let Ok(lists) = client.resolve_lists(&op.project) { [INFO] [stdout] 463 | | if let Some(name) = op.name.clone() { [INFO] [stdout] 464 | | let due = op.due.as_deref(); [INFO] [stdout] 465 | | if let Ok(cid) = client.create_card(&lists.todo_list_id, &name, due) { [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 462 ~ if let Ok(lists) = client.resolve_lists(&op.project) [INFO] [stdout] 463 ~ && let Some(name) = op.name.clone() { [INFO] [stdout] 464 | let due = op.due.as_deref(); [INFO] [stdout] ... [INFO] [stdout] 489 | } [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:494:21 [INFO] [stdout] | [INFO] [stdout] 494 | / if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] 495 | | if client.move_card(cid, lid).is_ok() { [INFO] [stdout] 496 | | if let Some(t) = self.todos.iter_mut().find(|t| t.planka_card_id.as_deref() == Some(cid.as_str())) { [INFO] [stdout] 497 | | t.planka_list_id = Some(lid.to_string()); [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 494 ~ if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) [INFO] [stdout] 495 ~ && client.move_card(cid, lid).is_ok() { [INFO] [stdout] 496 | if let Some(t) = self.todos.iter_mut().find(|t| t.planka_card_id.as_deref() == Some(cid.as_str())) { [INFO] [stdout] ... [INFO] [stdout] 503 | } [INFO] [stdout] 504 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:508:21 [INFO] [stdout] | [INFO] [stdout] 508 | / if let Some(ref cid) = op.card_id { [INFO] [stdout] 509 | | if client.delete_card(cid).is_ok() { [INFO] [stdout] 510 | | if let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] 511 | | self.pending_ops.remove(pos); [INFO] [stdout] ... | [INFO] [stdout] 515 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 508 ~ if let Some(ref cid) = op.card_id [INFO] [stdout] 509 ~ && client.delete_card(cid).is_ok() { [INFO] [stdout] 510 | if let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] ... [INFO] [stdout] 513 | } [INFO] [stdout] 514 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:509:25 [INFO] [stdout] | [INFO] [stdout] 509 | / if client.delete_card(cid).is_ok() { [INFO] [stdout] 510 | | if let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] 511 | | self.pending_ops.remove(pos); [INFO] [stdout] 512 | | any_removed = true; [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 509 ~ if client.delete_card(cid).is_ok() [INFO] [stdout] 510 ~ && let Some(pos) = self.pending_ops.iter().position(|p| p.ts == op.ts) { [INFO] [stdout] 511 | self.pending_ops.remove(pos); [INFO] [stdout] 512 | any_removed = true; [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/app.rs:494:34 [INFO] [stdout] | [INFO] [stdout] 494 | if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 494 - if let (Some(ref cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] 494 + if let (Some(cid), Some(ref lid)) = (op.card_id.as_ref(), op.list_id.as_ref()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:554:17 [INFO] [stdout] | [INFO] [stdout] 554 | / if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 555 | | if !boards.is_empty() { [INFO] [stdout] 556 | | let names: Vec = boards.iter().map(|b| b.name.clone()).collect(); [INFO] [stdout] 557 | | self.planka_boards = boards; [INFO] [stdout] ... | [INFO] [stdout] 566 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 554 ~ if let Ok(boards) = client.fetch_boards() [INFO] [stdout] 555 ~ && !boards.is_empty() { [INFO] [stdout] 556 | let names: Vec = boards.iter().map(|b| b.name.clone()).collect(); [INFO] [stdout] ... [INFO] [stdout] 564 | } [INFO] [stdout] 565 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:559:25 [INFO] [stdout] | [INFO] [stdout] 559 | / if !self.projects.iter().any(|p| p == &self.current_project) { [INFO] [stdout] 560 | | if let Some(first) = self.projects.get(0) { [INFO] [stdout] 561 | | self.current_project = first.clone(); [INFO] [stdout] 562 | | self.selected = 0; [INFO] [stdout] 563 | | } [INFO] [stdout] 564 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 559 ~ if !self.projects.iter().any(|p| p == &self.current_project) [INFO] [stdout] 560 ~ && let Some(first) = self.projects.get(0) { [INFO] [stdout] 561 | self.current_project = first.clone(); [INFO] [stdout] 562 | self.selected = 0; [INFO] [stdout] 563 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.projects.get(0)` [INFO] [stdout] --> src/app.rs:560:50 [INFO] [stdout] | [INFO] [stdout] 560 | ... if let Some(first) = self.projects.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.projects.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:603:29 [INFO] [stdout] | [INFO] [stdout] 603 | / ... if t.project == self.current_project { [INFO] [stdout] 604 | | ... if let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 605 | | ... index_by_card.insert(cid.clone(), i); [INFO] [stdout] 606 | | ... } [INFO] [stdout] 607 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 603 ~ if t.project == self.current_project [INFO] [stdout] 604 ~ && let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 605 | index_by_card.insert(cid.clone(), i); [INFO] [stdout] 606 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:620:51 [INFO] [stdout] | [INFO] [stdout] 620 | ... .and_then(|s| format_planka_due(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:632:76 [INFO] [stdout] | [INFO] [stdout] 632 | ... due_date: card.due.as_deref().and_then(|s| format_planka_due(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:636:46 [INFO] [stdout] | [INFO] [stdout] 636 | ... .map(|s| format_planka_created(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_created` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:664:9 [INFO] [stdout] | [INFO] [stdout] 664 | / if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 665 | | if !boards.is_empty() { [INFO] [stdout] 666 | | self.planka_boards = boards.clone(); [INFO] [stdout] 667 | | self.projects = boards.iter().map(|b| b.name.clone()).collect(); [INFO] [stdout] ... | [INFO] [stdout] 675 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 664 ~ if let Ok(boards) = client.fetch_boards() [INFO] [stdout] 665 ~ && !boards.is_empty() { [INFO] [stdout] 666 | self.planka_boards = boards.clone(); [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] 674 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:668:17 [INFO] [stdout] | [INFO] [stdout] 668 | / if !self.projects.iter().any(|p| p == &self.current_project) { [INFO] [stdout] 669 | | if let Some(first) = self.projects.get(0) { [INFO] [stdout] 670 | | self.current_project = first.clone(); [INFO] [stdout] 671 | | self.selected = 0; [INFO] [stdout] 672 | | } [INFO] [stdout] 673 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 668 ~ if !self.projects.iter().any(|p| p == &self.current_project) [INFO] [stdout] 669 ~ && let Some(first) = self.projects.get(0) { [INFO] [stdout] 670 | self.current_project = first.clone(); [INFO] [stdout] 671 | self.selected = 0; [INFO] [stdout] 672 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.projects.get(0)` [INFO] [stdout] --> src/app.rs:669:42 [INFO] [stdout] | [INFO] [stdout] 669 | if let Some(first) = self.projects.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.projects.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:717:17 [INFO] [stdout] | [INFO] [stdout] 717 | / if t.project == proj { [INFO] [stdout] 718 | | if let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 719 | | local_index.insert(cid.clone(), i); [INFO] [stdout] 720 | | } [INFO] [stdout] 721 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 717 ~ if t.project == proj [INFO] [stdout] 718 ~ && let Some(ref cid) = t.planka_card_id { [INFO] [stdout] 719 | local_index.insert(cid.clone(), i); [INFO] [stdout] 720 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/app.rs:724:50 [INFO] [stdout] | [INFO] [stdout] 724 | for (_cid, (rcard, rdone, rlist)) in &remote_by_id { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 724 - for (_cid, (rcard, rdone, rlist)) in &remote_by_id { [INFO] [stdout] 724 + for (rcard, rdone, rlist) in remote_by_id.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:732:39 [INFO] [stdout] | [INFO] [stdout] 732 | ... .and_then(|s| format_planka_due(s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:744:65 [INFO] [stdout] | [INFO] [stdout] 744 | due_date: rcard.due.as_deref().and_then(|s| format_planka_due(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_due` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/app.rs:748:34 [INFO] [stdout] | [INFO] [stdout] 748 | ... .map(|s| format_planka_created(s)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `format_planka_created` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:844:17 [INFO] [stdout] | [INFO] [stdout] 844 | / if let Some(existing) = self.planka_config.as_ref() { [INFO] [stdout] 845 | | if !existing.email_or_username.is_empty() { [INFO] [stdout] 846 | | self.input_planka = existing.email_or_username.clone(); [INFO] [stdout] 847 | | } [INFO] [stdout] 848 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 844 ~ if let Some(existing) = self.planka_config.as_ref() [INFO] [stdout] 845 ~ && !existing.email_or_username.is_empty() { [INFO] [stdout] 846 | self.input_planka = existing.email_or_username.clone(); [INFO] [stdout] 847 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:857:17 [INFO] [stdout] | [INFO] [stdout] 857 | / if let Some(existing) = self.planka_config.as_ref() { [INFO] [stdout] 858 | | if !existing.password.is_empty() { [INFO] [stdout] 859 | | self.input_planka = existing.password.clone(); [INFO] [stdout] 860 | | } [INFO] [stdout] 861 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 857 ~ if let Some(existing) = self.planka_config.as_ref() [INFO] [stdout] 858 ~ && !existing.password.is_empty() { [INFO] [stdout] 859 | self.input_planka = existing.password.clone(); [INFO] [stdout] 860 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:889:9 [INFO] [stdout] | [INFO] [stdout] 889 | / if self.planka_boards.is_empty() { [INFO] [stdout] 890 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 891 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | | self.planka_boards = boards; [INFO] [stdout] ... | [INFO] [stdout] 895 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 889 ~ if self.planka_boards.is_empty() [INFO] [stdout] 890 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 891 | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | self.planka_boards = boards; [INFO] [stdout] 893 | } [INFO] [stdout] 894 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:890:13 [INFO] [stdout] | [INFO] [stdout] 890 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 891 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | | self.planka_boards = boards; [INFO] [stdout] 893 | | } [INFO] [stdout] 894 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 890 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 891 ~ && let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 892 | self.planka_boards = boards; [INFO] [stdout] 893 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:901:13 [INFO] [stdout] | [INFO] [stdout] 901 | / if let Some(ref pid) = b.project_id { [INFO] [stdout] 902 | | if seen.insert(pid.clone()) { [INFO] [stdout] 903 | | let pname = b.project_name.clone().unwrap_or_else(|| "Project".to_string()); [INFO] [stdout] 904 | | projects.push((pid.clone(), pname)); [INFO] [stdout] 905 | | } [INFO] [stdout] 906 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 901 ~ if let Some(ref pid) = b.project_id [INFO] [stdout] 902 ~ && seen.insert(pid.clone()) { [INFO] [stdout] 903 | let pname = b.project_name.clone().unwrap_or_else(|| "Project".to_string()); [INFO] [stdout] 904 | projects.push((pid.clone(), pname)); [INFO] [stdout] 905 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/app.rs:909:9 [INFO] [stdout] | [INFO] [stdout] 909 | projects.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 909 - projects.sort_by(|a, b| a.1.to_lowercase().cmp(&b.1.to_lowercase())); [INFO] [stdout] 909 + projects.sort_by_key(|a| a.1.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:913:9 [INFO] [stdout] | [INFO] [stdout] 913 | / if let Some(cur_pid) = self [INFO] [stdout] 914 | | .planka_boards [INFO] [stdout] 915 | | .iter() [INFO] [stdout] 916 | | .find(|b| b.name == self.current_project) [INFO] [stdout] ... | [INFO] [stdout] 922 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 917 ~ .and_then(|b| b.project_id.clone()) [INFO] [stdout] 918 ~ && let Some(pos) = projects.iter().position(|(id, _)| *id == cur_pid) { [INFO] [stdout] 919 | sel = pos; [INFO] [stdout] 920 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:1194:12 [INFO] [stdout] | [INFO] [stdout] 1194 | if new_done || (!new_done && was_done) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1194 - if new_done || (!new_done && was_done) { [INFO] [stdout] 1194 + if !(!new_done && !was_done) { [INFO] [stdout] | [INFO] [stdout] 1194 - if new_done || (!new_done && was_done) { [INFO] [stdout] 1194 + if new_done || was_done { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1194:9 [INFO] [stdout] | [INFO] [stdout] 1194 | / if new_done || (!new_done && was_done) { [INFO] [stdout] 1195 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1196 | | let lists = if let Some(l) = self.planka_lists_by_board.get(&self.current_project).cloned() { [INFO] [stdout] 1197 | | l [INFO] [stdout] ... | [INFO] [stdout] 1236 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1194 ~ if (new_done || (!new_done && was_done)) { [INFO] [stdout] 1195 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1196 | let lists = if let Some(l) = self.planka_lists_by_board.get(&self.current_project).cloned() { [INFO] [stdout] ... [INFO] [stdout] 1234 | } [INFO] [stdout] 1235 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/app.rs:1251:9 [INFO] [stdout] | [INFO] [stdout] 1251 | let target_is_doing: bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1276 | target_is_doing = current_list_id.as_deref() != Some(lists.doing_list_id.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `target_is_doing` here [INFO] [stdout] | [INFO] [stdout] 1251 ~ [INFO] [stdout] 1252 | let lists = match self.ensure_planka_client() { [INFO] [stdout] ... [INFO] [stdout] 1275 | // Decide toggle target based on current list [INFO] [stdout] 1276 ~ let target_is_doing: bool = current_list_id.as_deref() != Some(lists.doing_list_id.as_str()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1325:9 [INFO] [stdout] | [INFO] [stdout] 1325 | / if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] 1326 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1327 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1328 | | self.planka_lists_by_board [INFO] [stdout] ... | [INFO] [stdout] 1333 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1325 ~ if self.planka_lists_by_board.get(&self.current_project).is_none() [INFO] [stdout] 1326 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1327 | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] ... [INFO] [stdout] 1331 | } [INFO] [stdout] 1332 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&self.current_project).is_none()` [INFO] [stdout] --> src/app.rs:1325:39 [INFO] [stdout] | [INFO] [stdout] 1325 | if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] | ---------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.planka_lists_by_board.contains_key(&self.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1326:13 [INFO] [stdout] | [INFO] [stdout] 1326 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1327 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1328 | | self.planka_lists_by_board [INFO] [stdout] 1329 | | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1332 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1326 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 1327 ~ && let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1328 | self.planka_lists_by_board [INFO] [stdout] 1329 | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] 1330 | self.planka_lists = Some(lists); [INFO] [stdout] 1331 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1345:9 [INFO] [stdout] | [INFO] [stdout] 1345 | / if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] 1346 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1347 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1348 | | self.planka_lists_by_board [INFO] [stdout] ... | [INFO] [stdout] 1353 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1345 ~ if self.planka_lists_by_board.get(&self.current_project).is_none() [INFO] [stdout] 1346 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1347 | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] ... [INFO] [stdout] 1351 | } [INFO] [stdout] 1352 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&self.current_project).is_none()` [INFO] [stdout] --> src/app.rs:1345:39 [INFO] [stdout] | [INFO] [stdout] 1345 | if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] | ---------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.planka_lists_by_board.contains_key(&self.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1346:13 [INFO] [stdout] | [INFO] [stdout] 1346 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1347 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1348 | | self.planka_lists_by_board [INFO] [stdout] 1349 | | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1352 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1346 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 1347 ~ && let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1348 | self.planka_lists_by_board [INFO] [stdout] 1349 | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] 1350 | self.planka_lists = Some(lists); [INFO] [stdout] 1351 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1364:9 [INFO] [stdout] | [INFO] [stdout] 1364 | / if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] 1365 | | if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1366 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1367 | | self.planka_lists_by_board [INFO] [stdout] ... | [INFO] [stdout] 1372 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1364 ~ if self.planka_lists_by_board.get(&self.current_project).is_none() [INFO] [stdout] 1365 ~ && let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1366 | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] ... [INFO] [stdout] 1370 | } [INFO] [stdout] 1371 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&self.current_project).is_none()` [INFO] [stdout] --> src/app.rs:1364:39 [INFO] [stdout] | [INFO] [stdout] 1364 | if self.planka_lists_by_board.get(&self.current_project).is_none() { [INFO] [stdout] | ---------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.planka_lists_by_board.contains_key(&self.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1365:13 [INFO] [stdout] | [INFO] [stdout] 1365 | / if let Ok(client) = self.ensure_planka_client() { [INFO] [stdout] 1366 | | if let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1367 | | self.planka_lists_by_board [INFO] [stdout] 1368 | | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1371 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1365 ~ if let Ok(client) = self.ensure_planka_client() [INFO] [stdout] 1366 ~ && let Ok(lists) = client.resolve_lists(&self.current_project) { [INFO] [stdout] 1367 | self.planka_lists_by_board [INFO] [stdout] 1368 | .insert(self.current_project.clone(), lists.clone()); [INFO] [stdout] 1369 | self.planka_lists = Some(lists); [INFO] [stdout] 1370 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1613:9 [INFO] [stdout] | [INFO] [stdout] 1613 | / if let Some(vc) = self.view_card.as_ref() { [INFO] [stdout] 1614 | | if let Some(last) = vc.attachments_full.last() { [INFO] [stdout] 1615 | | self.input_attachment_name = last.name.clone(); [INFO] [stdout] 1616 | | self.input_mode = InputMode::RenamingAttachment; [INFO] [stdout] ... | [INFO] [stdout] 1620 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1613 ~ if let Some(vc) = self.view_card.as_ref() [INFO] [stdout] 1614 ~ && let Some(last) = vc.attachments_full.last() { [INFO] [stdout] 1615 | self.input_attachment_name = last.name.clone(); [INFO] [stdout] ... [INFO] [stdout] 1618 | return; [INFO] [stdout] 1619 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1751:13 [INFO] [stdout] | [INFO] [stdout] 1751 | / if let Some(vc) = self.view_card.as_ref() { [INFO] [stdout] 1752 | | if let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1753 | | if let Some(v) = g.values_by_field.get(&fid) { [INFO] [stdout] 1754 | | self.input_custom_field_value = v.clone(); [INFO] [stdout] ... | [INFO] [stdout] 1759 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1751 ~ if let Some(vc) = self.view_card.as_ref() [INFO] [stdout] 1752 ~ && let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1753 | if let Some(v) = g.values_by_field.get(&fid) { [INFO] [stdout] ... [INFO] [stdout] 1757 | } [INFO] [stdout] 1758 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:1799:9 [INFO] [stdout] | [INFO] [stdout] 1799 | / if let Some(vc) = self.view_card.as_ref() { [INFO] [stdout] 1800 | | if let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1801 | | self.input_cfg_group_name = g.name.clone().unwrap_or_default(); [INFO] [stdout] 1802 | | self.input_mode = InputMode::RenamingCustomFieldGroup; [INFO] [stdout] ... | [INFO] [stdout] 1806 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1799 ~ if let Some(vc) = self.view_card.as_ref() [INFO] [stdout] 1800 ~ && let Some(g) = vc.custom_field_groups.get(self.selected_custom_group_index) { [INFO] [stdout] 1801 | self.input_cfg_group_name = g.name.clone().unwrap_or_default(); [INFO] [stdout] ... [INFO] [stdout] 1804 | return; [INFO] [stdout] 1805 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | / if !todo.done { [INFO] [stdout] 23 | | if let Some(due) = &todo.due_date { [INFO] [stdout] 24 | | if due == &today { [INFO] [stdout] 25 | | #[cfg(target_os = "linux")] [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 22 ~ if !todo.done [INFO] [stdout] 23 ~ && let Some(due) = &todo.due_date { [INFO] [stdout] 24 | if due == &today { [INFO] [stdout] ... [INFO] [stdout] 49 | } [INFO] [stdout] 50 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/daemon.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | / if let Some(due) = &todo.due_date { [INFO] [stdout] 24 | | if due == &today { [INFO] [stdout] 25 | | #[cfg(target_os = "linux")] [INFO] [stdout] 26 | | Notification::new() [INFO] [stdout] ... | [INFO] [stdout] 50 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 23 ~ if let Some(due) = &todo.due_date [INFO] [stdout] 24 ~ && due == &today { [INFO] [stdout] 25 | #[cfg(target_os = "linux")] [INFO] [stdout] ... [INFO] [stdout] 48 | } [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | / if app.planka_lists_by_board.get(&app.current_project).is_none() { [INFO] [stdout] 31 | | if let Ok(client) = app.ensure_planka_client() { [INFO] [stdout] 32 | | // Ensure boards are cached so the header can show "Project - Board" [INFO] [stdout] 33 | | if app.planka_boards.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 30 ~ if app.planka_lists_by_board.get(&app.current_project).is_none() [INFO] [stdout] 31 ~ && let Ok(client) = app.ensure_planka_client() { [INFO] [stdout] 32 | // Ensure boards are cached so the header can show "Project - Board" [INFO] [stdout] ... [INFO] [stdout] 42 | } [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&app.current_project).is_none()` [INFO] [stdout] --> src/tui.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | if app.planka_lists_by_board.get(&app.current_project).is_none() { [INFO] [stdout] | --------------------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!app.planka_lists_by_board.contains_key(&app.current_project)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / if app.planka_boards.is_empty() { [INFO] [stdout] 34 | | if let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 35 | | app.planka_boards = boards; [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if app.planka_boards.is_empty() [INFO] [stdout] 34 ~ && let Ok(boards) = client.fetch_boards() { [INFO] [stdout] 35 | app.planka_boards = boards; [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / if crossterm::event::poll(Duration::from_millis(100))? { [INFO] [stdout] 53 | | if let CEvent::Key(key) = event::read()? { [INFO] [stdout] 54 | | if key.kind != KeyEventKind::Press { [INFO] [stdout] 55 | | continue; [INFO] [stdout] ... | [INFO] [stdout] 605 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 52 ~ if crossterm::event::poll(Duration::from_millis(100))? [INFO] [stdout] 53 ~ && let CEvent::Key(key) = event::read()? { [INFO] [stdout] 54 | if key.kind != KeyEventKind::Press { [INFO] [stdout] ... [INFO] [stdout] 603 | } [INFO] [stdout] 604 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | / ... if app.selected < filtered_todos(app).len().saturating_sub(1) { [INFO] [stdout] 84 | | ... app.selected += 1; [INFO] [stdout] 85 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ KeyCode::Down [INFO] [stdout] 83 ~ if app.selected < filtered_todos(app).len().saturating_sub(1) => { [INFO] [stdout] 84 | app.selected += 1; [INFO] [stdout] 85 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:88:29 [INFO] [stdout] | [INFO] [stdout] 88 | / ... if app.selected > 0 { [INFO] [stdout] 89 | | ... app.selected -= 1; [INFO] [stdout] 90 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 87 ~ KeyCode::Up [INFO] [stdout] 88 ~ if app.selected > 0 => { [INFO] [stdout] 89 | app.selected -= 1; [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:247:29 [INFO] [stdout] | [INFO] [stdout] 247 | / ... if !app.create_board_projects.is_empty() { [INFO] [stdout] 248 | | ... if app.create_board_project_index == 0 { [INFO] [stdout] 249 | | ... app.create_board_project_index = app.create_board_projects.len() - 1; [INFO] [stdout] 250 | | ... } else { [INFO] [stdout] ... | [INFO] [stdout] 253 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 246 ~ KeyCode::Left | KeyCode::Char('[') [INFO] [stdout] 247 ~ if !app.create_board_projects.is_empty() => { [INFO] [stdout] 248 | if app.create_board_project_index == 0 { [INFO] [stdout] ... [INFO] [stdout] 252 | } [INFO] [stdout] 253 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:256:29 [INFO] [stdout] | [INFO] [stdout] 256 | / ... if !app.create_board_projects.is_empty() { [INFO] [stdout] 257 | | ... app.create_board_project_index = (app.create_board_project_index + 1) % app.create_board_projects.len(); [INFO] [stdout] 258 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 255 ~ KeyCode::Right | KeyCode::Char(']') [INFO] [stdout] 256 ~ if !app.create_board_projects.is_empty() => { [INFO] [stdout] 257 | app.create_board_project_index = (app.create_board_project_index + 1) % app.create_board_projects.len(); [INFO] [stdout] 258 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/tui.rs:372:71 [INFO] [stdout] | [INFO] [stdout] 372 | KeyCode::Char(c) if app.view_card_tab == 2 && c >= '1' && c <= '9' => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('1'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:374:29 [INFO] [stdout] | [INFO] [stdout] 374 | / ... if let Some(vc) = app.view_card.as_ref() { [INFO] [stdout] 375 | | ... if idx < vc.custom_field_groups.len() { [INFO] [stdout] 376 | | ... app.selected_custom_group_index = idx; [INFO] [stdout] 377 | | ... } [INFO] [stdout] 378 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 374 ~ if let Some(vc) = app.view_card.as_ref() [INFO] [stdout] 375 ~ && idx < vc.custom_field_groups.len() { [INFO] [stdout] 376 | app.selected_custom_group_index = idx; [INFO] [stdout] 377 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:561:29 [INFO] [stdout] | [INFO] [stdout] 561 | ... if app.control_center_index < 4 { app.control_center_index += 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 560 ~ KeyCode::Down [INFO] [stdout] 561 ~ if app.control_center_index < 4 => { app.control_center_index += 1; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:564:29 [INFO] [stdout] | [INFO] [stdout] 564 | ... if app.control_center_index > 0 { app.control_center_index -= 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 563 ~ KeyCode::Up [INFO] [stdout] 564 ~ if app.control_center_index > 0 => { app.control_center_index -= 1; } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:592:29 [INFO] [stdout] | [INFO] [stdout] 592 | / ... if app.selected < filtered_todos(app).len().saturating_sub(1) { [INFO] [stdout] 593 | | ... app.selected += 1; [INFO] [stdout] 594 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 591 ~ KeyCode::Down [INFO] [stdout] 592 ~ if app.selected < filtered_todos(app).len().saturating_sub(1) => { [INFO] [stdout] 593 | app.selected += 1; [INFO] [stdout] 594 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:597:29 [INFO] [stdout] | [INFO] [stdout] 597 | / ... if app.selected > 0 { [INFO] [stdout] 598 | | ... app.selected -= 1; [INFO] [stdout] 599 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 596 ~ KeyCode::Up [INFO] [stdout] 597 ~ if app.selected > 0 => { [INFO] [stdout] 598 | app.selected -= 1; [INFO] [stdout] 599 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:1298:5 [INFO] [stdout] | [INFO] [stdout] 1298 | / if let Ok(dt) = NaiveDateTime::parse_from_str(due_date_str, "%Y-%m-%d %H:%M") { [INFO] [stdout] 1299 | | if let Some(dt_local) = Local.from_local_datetime(&dt).single() { [INFO] [stdout] 1300 | | return dt_local < now; [INFO] [stdout] 1301 | | } [INFO] [stdout] 1302 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1298 ~ if let Ok(dt) = NaiveDateTime::parse_from_str(due_date_str, "%Y-%m-%d %H:%M") [INFO] [stdout] 1299 ~ && let Some(dt_local) = Local.from_local_datetime(&dt).single() { [INFO] [stdout] 1300 | return dt_local < now; [INFO] [stdout] 1301 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/tui.rs:1496:18 [INFO] [stdout] | [INFO] [stdout] 1496 | if days <= 0 { [INFO] [stdout] | __________________^ [INFO] [stdout] 1497 | | days + 7 // Next week [INFO] [stdout] 1498 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/tui.rs:1498:12 [INFO] [stdout] | [INFO] [stdout] 1498 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 1499 | | days + 7 // Force next week [INFO] [stdout] 1500 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/tui.rs:1583:17 [INFO] [stdout] | [INFO] [stdout] 1583 | time = time + Dur::hours(12); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time += Dur::hours(12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/tui.rs:1585:17 [INFO] [stdout] | [INFO] [stdout] 1585 | time = time - Dur::hours(12); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time -= Dur::hours(12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:413:13 [INFO] [stdout] | [INFO] [stdout] 413 | / if status.is_success() && !text.trim_start().starts_with('<') { [INFO] [stdout] 414 | | if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 415 | | if let Some(arr) = v [INFO] [stdout] 416 | | .get("included") [INFO] [stdout] ... | [INFO] [stdout] 432 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 413 ~ if status.is_success() && !text.trim_start().starts_with('<') [INFO] [stdout] 414 ~ && let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 415 | if let Some(arr) = v [INFO] [stdout] ... [INFO] [stdout] 430 | } [INFO] [stdout] 431 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:414:17 [INFO] [stdout] | [INFO] [stdout] 414 | / if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 415 | | if let Some(arr) = v [INFO] [stdout] 416 | | .get("included") [INFO] [stdout] 417 | | .and_then(|i| i.get("lists")) [INFO] [stdout] ... | [INFO] [stdout] 431 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 414 ~ if let Ok(v) = serde_json::from_str::(&text) [INFO] [stdout] 415 ~ && let Some(arr) = v [INFO] [stdout] 416 | .get("included") [INFO] [stdout] ... [INFO] [stdout] 429 | } [INFO] [stdout] 430 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:436:9 [INFO] [stdout] | [INFO] [stdout] 436 | / if lists.is_empty() { [INFO] [stdout] 437 | | if let Some(ref project_id) = board.project_id { [INFO] [stdout] 438 | | let url = format!("{}/api/projects/{}?include=boards,lists", base, project_id); [INFO] [stdout] 439 | | let auth = self.auth_header(); [INFO] [stdout] ... | [INFO] [stdout] 492 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 436 ~ if lists.is_empty() [INFO] [stdout] 437 ~ && let Some(ref project_id) = board.project_id { [INFO] [stdout] 438 | let url = format!("{}/api/projects/{}?include=boards,lists", base, project_id); [INFO] [stdout] ... [INFO] [stdout] 490 | } [INFO] [stdout] 491 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:463:17 [INFO] [stdout] | [INFO] [stdout] 463 | / if status.is_success() && !text.trim_start().starts_with('<') { [INFO] [stdout] 464 | | if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 465 | | if let Some(arr) = v [INFO] [stdout] 466 | | .get("included") [INFO] [stdout] ... | [INFO] [stdout] 490 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 463 ~ if status.is_success() && !text.trim_start().starts_with('<') [INFO] [stdout] 464 ~ && let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 465 | if let Some(arr) = v [INFO] [stdout] ... [INFO] [stdout] 488 | } [INFO] [stdout] 489 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:464:21 [INFO] [stdout] | [INFO] [stdout] 464 | / if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 465 | | if let Some(arr) = v [INFO] [stdout] 466 | | .get("included") [INFO] [stdout] 467 | | .and_then(|i| i.get("lists")) [INFO] [stdout] ... | [INFO] [stdout] 489 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 464 ~ if let Ok(v) = serde_json::from_str::(&text) [INFO] [stdout] 465 ~ && let Some(arr) = v [INFO] [stdout] 466 | .get("included") [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] 488 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:508:20 [INFO] [stdout] | [INFO] [stdout] 508 | } else if n.contains("done") || n.contains("completed") || n.contains("complete") { [INFO] [stdout] | ____________________^ [INFO] [stdout] 509 | | if done_id.is_none() { done_id = Some(id.clone()); } [INFO] [stdout] 510 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 508 ~ } else if (n.contains("done") || n.contains("completed") || n.contains("complete")) { [INFO] [stdout] 509 ~ && done_id.is_none() { done_id = Some(id.clone()); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:840:13 [INFO] [stdout] | [INFO] [stdout] 840 | / if status.is_success() && !text.trim_start().starts_with('<') { [INFO] [stdout] 841 | | if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 842 | | if let Some(arr) = v [INFO] [stdout] 843 | | .get("included") [INFO] [stdout] ... | [INFO] [stdout] 869 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 840 ~ if status.is_success() && !text.trim_start().starts_with('<') [INFO] [stdout] 841 ~ && let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 842 | if let Some(arr) = v [INFO] [stdout] ... [INFO] [stdout] 867 | } [INFO] [stdout] 868 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:841:17 [INFO] [stdout] | [INFO] [stdout] 841 | / if let Ok(v) = serde_json::from_str::(&text) { [INFO] [stdout] 842 | | if let Some(arr) = v [INFO] [stdout] 843 | | .get("included") [INFO] [stdout] 844 | | .and_then(|i| i.get("cards")) [INFO] [stdout] ... | [INFO] [stdout] 868 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 841 ~ if let Ok(v) = serde_json::from_str::(&text) [INFO] [stdout] 842 ~ && let Some(arr) = v [INFO] [stdout] 843 | .get("included") [INFO] [stdout] ... [INFO] [stdout] 866 | return Ok(out); [INFO] [stdout] 867 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:860:29 [INFO] [stdout] | [INFO] [stdout] 860 | / ... if c.created.is_none() { [INFO] [stdout] 861 | | ... if let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 862 | | ... c.created = created; [INFO] [stdout] 863 | | ... } [INFO] [stdout] 864 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 860 ~ if c.created.is_none() [INFO] [stdout] 861 ~ && let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 862 | c.created = created; [INFO] [stdout] 863 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:926:13 [INFO] [stdout] | [INFO] [stdout] 926 | / if c.created.is_none() { [INFO] [stdout] 927 | | if let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 928 | | c.created = created; [INFO] [stdout] 929 | | } [INFO] [stdout] 930 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 926 ~ if c.created.is_none() [INFO] [stdout] 927 ~ && let Ok(created) = self.fetch_card_created(&c.id) { [INFO] [stdout] 928 | c.created = created; [INFO] [stdout] 929 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:994:21 [INFO] [stdout] | [INFO] [stdout] 994 | / ... if lid_json == Some(lid.as_str()) { [INFO] [stdout] 995 | | ... if let Some(n) = l.get("name").and_then(|x| x.as_str()).or_else(|| l.get("title").and_then(|x| x.as_str())) { [INFO] [stdout] 996 | | ... list_name = Some(n.to_string()); [INFO] [stdout] 997 | | ... break; [INFO] [stdout] 998 | | ... } [INFO] [stdout] 999 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 994 ~ if lid_json == Some(lid.as_str()) [INFO] [stdout] 995 ~ && let Some(n) = l.get("name").and_then(|x| x.as_str()).or_else(|| l.get("title").and_then(|x| x.as_str())) { [INFO] [stdout] 996 | list_name = Some(n.to_string()); [INFO] [stdout] 997 | break; [INFO] [stdout] 998 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1017:21 [INFO] [stdout] | [INFO] [stdout] 1017 | / if cl_card == Some(id.as_str()) { [INFO] [stdout] 1018 | | if let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) { [INFO] [stdout] 1019 | | if let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | | labels.push(name.clone()); [INFO] [stdout] ... | [INFO] [stdout] 1023 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1017 ~ if cl_card == Some(id.as_str()) [INFO] [stdout] 1018 ~ && let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) { [INFO] [stdout] 1019 | if let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | labels.push(name.clone()); [INFO] [stdout] 1021 | } [INFO] [stdout] 1022 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1018:25 [INFO] [stdout] | [INFO] [stdout] 1018 | / if let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) { [INFO] [stdout] 1019 | | if let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | | labels.push(name.clone()); [INFO] [stdout] 1021 | | } [INFO] [stdout] 1022 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1018 ~ if let Some(lid) = cl.get("labelId").and_then(|x| x.as_str()) [INFO] [stdout] 1019 ~ && let Some(name) = label_by_id.get(lid) { [INFO] [stdout] 1020 | labels.push(name.clone()); [INFO] [stdout] 1021 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1080:21 [INFO] [stdout] | [INFO] [stdout] 1080 | / if let (Some(fid), Some(name)) = ( [INFO] [stdout] 1081 | | f.get("id").and_then(|x| x.as_str()), [INFO] [stdout] 1082 | | f.get("name").and_then(|x| x.as_str()), [INFO] [stdout] 1083 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 1094 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1083 ~ ) [INFO] [stdout] 1084 ~ && let Some(gid) = f.get("customFieldGroupId").and_then(|x| x.as_str()) { [INFO] [stdout] 1085 | fields_by_group [INFO] [stdout] ... [INFO] [stdout] 1092 | }); [INFO] [stdout] 1093 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/planka.rs:1115:13 [INFO] [stdout] | [INFO] [stdout] 1115 | fields.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1115 - fields.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 1115 + fields.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/planka.rs:1119:9 [INFO] [stdout] | [INFO] [stdout] 1119 | ... custom_field_groups.sort_by(|a, b| a.name.as_deref().unwrap_or("").to_lowercase().cmp(&b.name.as_deref().unwrap_or("").to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1119 - custom_field_groups.sort_by(|a, b| a.name.as_deref().unwrap_or("").to_lowercase().cmp(&b.name.as_deref().unwrap_or("").to_lowercase())); [INFO] [stdout] 1119 + custom_field_groups.sort_by_key(|a| a.name.as_deref().unwrap_or("").to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1157:9 [INFO] [stdout] | [INFO] [stdout] 1157 | / if let Some(included) = v.get("included").and_then(|x| x.as_object()) { [INFO] [stdout] 1158 | | if let Some(users) = included.get("users").and_then(|x| x.as_array()) { [INFO] [stdout] 1159 | | for u in users { [INFO] [stdout] 1160 | | if let Some(uid) = u.get("id").and_then(|x| x.as_str()) { [INFO] [stdout] ... | [INFO] [stdout] 1167 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1157 ~ if let Some(included) = v.get("included").and_then(|x| x.as_object()) [INFO] [stdout] 1158 ~ && let Some(users) = included.get("users").and_then(|x| x.as_array()) { [INFO] [stdout] 1159 | for u in users { [INFO] [stdout] ... [INFO] [stdout] 1165 | } [INFO] [stdout] 1166 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/planka.rs:1160:21 [INFO] [stdout] | [INFO] [stdout] 1160 | / ... if let Some(uid) = u.get("id").and_then(|x| x.as_str()) { [INFO] [stdout] 1161 | | ... if let Some(name) = u.get("name").and_then(|x| x.as_str()).or_else(|| u.get("username").and_then(|x| x.as_str())) { [INFO] [stdout] 1162 | | ... user_name_by_id.insert(uid.to_string(), name.to_string()); [INFO] [stdout] 1163 | | ... } [INFO] [stdout] 1164 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1160 ~ if let Some(uid) = u.get("id").and_then(|x| x.as_str()) [INFO] [stdout] 1161 ~ && let Some(name) = u.get("name").and_then(|x| x.as_str()).or_else(|| u.get("username").and_then(|x| x.as_str())) { [INFO] [stdout] 1162 | user_name_by_id.insert(uid.to_string(), name.to_string()); [INFO] [stdout] 1163 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/planka.rs:1679:5 [INFO] [stdout] | [INFO] [stdout] 1679 | / pub fn update_project( [INFO] [stdout] 1680 | | &self, [INFO] [stdout] 1681 | | project_id: &str, [INFO] [stdout] 1682 | | name: Option<&str>, [INFO] [stdout] ... | [INFO] [stdout] 1687 | | background_gradient: Option<&str>, [INFO] [stdout] 1688 | | ) -> Result<(), String> { [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/planka.rs:1825:5 [INFO] [stdout] | [INFO] [stdout] 1825 | / pub fn update_board( [INFO] [stdout] 1826 | | &self, [INFO] [stdout] 1827 | | board_id: &str, [INFO] [stdout] 1828 | | position: Option, [INFO] [stdout] ... | [INFO] [stdout] 1835 | | is_subscribed: Option, [INFO] [stdout] 1836 | | ) -> Result<(), String> { [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 18s [INFO] running `Command { std: "docker" "inspect" "e549773fd214ff170c2bd7b87c109e400f3ecc02f0e95ec5a20d37322bdba93a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e549773fd214ff170c2bd7b87c109e400f3ecc02f0e95ec5a20d37322bdba93a", kill_on_drop: false }` [INFO] [stdout] e549773fd214ff170c2bd7b87c109e400f3ecc02f0e95ec5a20d37322bdba93a