[INFO] cloning repository https://github.com/chandanbauri/rust_todo_cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/chandanbauri/rust_todo_cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchandanbauri%2Frust_todo_cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchandanbauri%2Frust_todo_cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0f4f96130d0dc5e5e82951eebac8ff8526aac446 [INFO] linting chandanbauri/rust_todo_cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fchandanbauri%2Frust_todo_cli" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/chandanbauri/rust_todo_cli [INFO] finished tweaking git repo https://github.com/chandanbauri/rust_todo_cli [INFO] tweaked toml for git repo https://github.com/chandanbauri/rust_todo_cli written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/chandanbauri/rust_todo_cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/chandanbauri/rust_todo_cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f88e89e54e5d544127fb8b00b5349837b532bd5b67746bfb1b424edc773a0d18 [INFO] running `Command { std: "docker" "start" "-a" "f88e89e54e5d544127fb8b00b5349837b532bd5b67746bfb1b424edc773a0d18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f88e89e54e5d544127fb8b00b5349837b532bd5b67746bfb1b424edc773a0d18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f88e89e54e5d544127fb8b00b5349837b532bd5b67746bfb1b424edc773a0d18", kill_on_drop: false }` [INFO] [stdout] f88e89e54e5d544127fb8b00b5349837b532bd5b67746bfb1b424edc773a0d18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05e6eafb7365744934f0252863e55c367d91294775680bd5cb2fec2b9c3b8b48 [INFO] running `Command { std: "docker" "start" "-a" "05e6eafb7365744934f0252863e55c367d91294775680bd5cb2fec2b9c3b8b48", kill_on_drop: false }` [INFO] [stderr] Checking chadan_todo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if !(true) { [INFO] [stdout] | ^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `create_todo` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:26:38 [INFO] [stdout] | [INFO] [stdout] 26 | todo_app.create_todo(&mut todo_title); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 26 - todo_app.create_todo(&mut todo_title); [INFO] [stdout] 26 + todo_app.create_todo(&todo_title); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:57:40 [INFO] [stdout] | [INFO] [stdout] 57 | fn trigger_action(option_selected: &String, todo_app: &mut todo::TodoApp) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 - fn trigger_action(option_selected: &String, todo_app: &mut todo::TodoApp) { [INFO] [stdout] 57 + fn trigger_action(option_selected: &str, todo_app: &mut todo::TodoApp) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | if !(true) { [INFO] [stdout] | ^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `create_todo` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:26:38 [INFO] [stdout] | [INFO] [stdout] 26 | todo_app.create_todo(&mut todo_title); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 26 - todo_app.create_todo(&mut todo_title); [INFO] [stdout] 26 + todo_app.create_todo(&todo_title); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:57:40 [INFO] [stdout] | [INFO] [stdout] 57 | fn trigger_action(option_selected: &String, todo_app: &mut todo::TodoApp) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 57 - fn trigger_action(option_selected: &String, todo_app: &mut todo::TodoApp) { [INFO] [stdout] 57 + fn trigger_action(option_selected: &str, todo_app: &mut todo::TodoApp) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "05e6eafb7365744934f0252863e55c367d91294775680bd5cb2fec2b9c3b8b48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05e6eafb7365744934f0252863e55c367d91294775680bd5cb2fec2b9c3b8b48", kill_on_drop: false }` [INFO] [stdout] 05e6eafb7365744934f0252863e55c367d91294775680bd5cb2fec2b9c3b8b48