[INFO] cloning repository https://github.com/ccie18473/AMSPoker-v3a [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ccie18473/AMSPoker-v3a" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fccie18473%2FAMSPoker-v3a", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fccie18473%2FAMSPoker-v3a'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] de4a44297f58e69f8cc580bf59670d787a78414a [INFO] linting ccie18473/AMSPoker-v3a against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fccie18473%2FAMSPoker-v3a" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ccie18473/AMSPoker-v3a [INFO] finished tweaking git repo https://github.com/ccie18473/AMSPoker-v3a [INFO] tweaked toml for git repo https://github.com/ccie18473/AMSPoker-v3a written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ccie18473/AMSPoker-v3a on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ccie18473/AMSPoker-v3a already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bracket-lib v0.8.1 [INFO] [stderr] Downloaded getrandom v0.2.3 [INFO] [stderr] Downloaded quote v1.0.10 [INFO] [stderr] Downloaded glutin_wgl_sys v0.1.5 [INFO] [stderr] Downloaded glutin_glx_sys v0.1.7 [INFO] [stderr] Downloaded num_enum_derive v0.4.3 [INFO] [stderr] Downloaded owned_ttf_parser v0.6.0 [INFO] [stderr] Downloaded dlib v0.4.2 [INFO] [stderr] Downloaded bracket-algorithm-traits v0.8.2 [INFO] [stderr] Downloaded bracket-random v0.8.2 [INFO] [stderr] Downloaded bracket-color v0.8.2 [INFO] [stderr] Downloaded bracket-pathfinding v0.8.4 [INFO] [stderr] Downloaded bracket-noise v0.8.2 [INFO] [stderr] Downloaded anyhow v1.0.48 [INFO] [stderr] Downloaded glow v0.10.0 [INFO] [stderr] Downloaded glutin v0.26.0 [INFO] [stderr] Downloaded x11-dl v2.19.1 [INFO] [stderr] Downloaded futures v0.1.31 [INFO] [stderr] Downloaded ttf-parser v0.6.2 [INFO] [stderr] Downloaded nix v0.20.0 [INFO] [stderr] Downloaded syn v1.0.81 [INFO] [stderr] Downloaded serde v1.0.130 [INFO] [stderr] Downloaded winit v0.24.0 [INFO] [stderr] Downloaded ndk-sys v0.2.2 [INFO] [stderr] Downloaded nix v0.18.0 [INFO] [stderr] Downloaded rand v0.8.4 [INFO] [stderr] Downloaded wide v0.6.5 [INFO] [stderr] Downloaded wayland-client v0.28.6 [INFO] [stderr] Downloaded bytemuck v1.7.2 [INFO] [stderr] Downloaded tokio-timer v0.2.13 [INFO] [stderr] Downloaded darling_core v0.10.2 [INFO] [stderr] Downloaded libc v0.2.108 [INFO] [stderr] Downloaded darling v0.10.2 [INFO] [stderr] Downloaded libloading v0.6.7 [INFO] [stderr] Downloaded smithay-client-toolkit v0.12.3 [INFO] [stderr] Downloaded once_cell v1.8.0 [INFO] [stderr] Downloaded wayland-commons v0.28.6 [INFO] [stderr] Downloaded cocoa v0.23.0 [INFO] [stderr] Downloaded ultraviolet v0.8.1 [INFO] [stderr] Downloaded core-foundation v0.9.2 [INFO] [stderr] Downloaded core-video-sys v0.1.4 [INFO] [stderr] Downloaded slab v0.4.5 [INFO] [stderr] Downloaded ndk-macro v0.2.0 [INFO] [stderr] Downloaded raw-window-handle v0.3.3 [INFO] [stderr] Downloaded wayland-cursor v0.28.6 [INFO] [stderr] Downloaded wayland-scanner v0.28.6 [INFO] [stderr] Downloaded libloading v0.7.2 [INFO] [stderr] Downloaded wayland-sys v0.28.6 [INFO] [stderr] Downloaded wayland-protocols v0.28.6 [INFO] [stderr] Downloaded pkg-config v0.3.22 [INFO] [stderr] Downloaded bracket-geometry v0.8.3 [INFO] [stderr] Downloaded wayland-egl v0.28.6 [INFO] [stderr] Downloaded crossbeam-utils v0.7.2 [INFO] [stderr] Downloaded wasm-timer v0.1.3 [INFO] [stderr] Downloaded ndk v0.2.1 [INFO] [stderr] Downloaded rusttype v0.9.2 [INFO] [stderr] Downloaded dirs v3.0.2 [INFO] [stderr] Downloaded xdg v2.4.0 [INFO] [stderr] Downloaded calloop v0.6.5 [INFO] [stderr] Downloaded glutin_egl_sys v0.1.5 [INFO] [stderr] Downloaded osmesa-sys v0.1.2 [INFO] [stderr] Downloaded crc32fast v1.2.2 [INFO] [stderr] Downloaded tokio-executor v0.1.10 [INFO] [stderr] Downloaded num_enum v0.4.3 [INFO] [stderr] Downloaded darling_macro v0.10.2 [INFO] [stderr] Downloaded dirs-sys v0.3.6 [INFO] [stderr] Downloaded memmap2 v0.1.0 [INFO] [stderr] Downloaded bumpalo v3.8.0 [INFO] [stderr] Downloaded glutin_gles2_sys v0.1.5 [INFO] [stderr] Downloaded ppv-lite86 v0.2.15 [INFO] [stderr] Downloaded rand_hc v0.3.1 [INFO] [stderr] Downloaded send_wrapper v0.2.0 [INFO] [stderr] Downloaded strsim v0.9.3 [INFO] [stderr] Downloaded ndk-glue v0.2.1 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Downloaded andrew v0.3.1 [INFO] [stderr] Downloaded shared_library v0.1.9 [INFO] [stderr] Downloaded android_glue v0.2.3 [INFO] [stderr] Downloaded glutin_emscripten_sys v0.1.1 [INFO] [stderr] Downloaded redox_users v0.4.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.32 [INFO] [stderr] Downloaded object-pool v0.5.4 [INFO] [stderr] Downloaded bracket-terminal v0.8.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cfaa28825248546b6aacb4b9116f5ed94d99abf8e972a28997436d61c1ba1486 [INFO] running `Command { std: "docker" "start" "-a" "cfaa28825248546b6aacb4b9116f5ed94d99abf8e972a28997436d61c1ba1486", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cfaa28825248546b6aacb4b9116f5ed94d99abf8e972a28997436d61c1ba1486", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfaa28825248546b6aacb4b9116f5ed94d99abf8e972a28997436d61c1ba1486", kill_on_drop: false }` [INFO] [stdout] cfaa28825248546b6aacb4b9116f5ed94d99abf8e972a28997436d61c1ba1486 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b4da22cfeb80b7a250a80bf99b629915d3c88e0f43c0b86148ec612ba280ab5 [INFO] running `Command { std: "docker" "start" "-a" "4b4da22cfeb80b7a250a80bf99b629915d3c88e0f43c0b86148ec612ba280ab5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.108 [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Compiling pkg-config v0.3.22 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking libloading v0.7.2 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Compiling crc32fast v1.2.2 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling anyhow v1.0.48 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Checking wide v0.6.5 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking glow v0.10.0 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking dirs v3.0.2 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking xdg v2.4.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking object-pool v0.5.4 [INFO] [stderr] Checking bracket-color v0.8.2 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Checking ultraviolet v0.8.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking bracket-random v0.8.2 [INFO] [stderr] Checking bracket-noise v0.8.2 [INFO] [stderr] Checking bracket-geometry v0.8.3 [INFO] [stderr] Checking bracket-algorithm-traits v0.8.2 [INFO] [stderr] Checking bracket-pathfinding v0.8.4 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking wayland-egl v0.28.6 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking winit v0.24.0 [INFO] [stderr] Checking glutin v0.26.0 [INFO] [stderr] Checking bracket-terminal v0.8.5 [INFO] [stderr] Checking bracket-lib v0.8.1 [INFO] [stderr] Checking poker v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | pub use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | pub use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | pub use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | pub use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `nmbr` is never read [INFO] [stdout] --> src/game.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | nmbr[c] = 1; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `button` is never read [INFO] [stdout] --> src/game.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct TGame { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | pub button: TButton, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `nmbr` is never read [INFO] [stdout] --> src/game.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | nmbr[c] = 1; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/deck.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 37 | let hand = TDeck { cards: Vec::new() }; [INFO] [stdout] | --------------------------------------- unnecessary `let` binding [INFO] [stdout] 38 | hand [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ TDeck { cards: Vec::new() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/game.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | if self.deck.cards.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.deck.cards.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | return self.flag3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return self.flag3; [INFO] [stdout] 227 + self.flag3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - return 1; [INFO] [stdout] 232 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:235:13 [INFO] [stdout] | [INFO] [stdout] 235 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 235 - return 2; [INFO] [stdout] 235 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return 3; [INFO] [stdout] 238 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | return 4; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return 4; [INFO] [stdout] 241 + 4 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 - return 0; [INFO] [stdout] 243 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `button` is never read [INFO] [stdout] --> src/game.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct TGame { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 14 | pub button: TButton, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:278:5 [INFO] [stdout] | [INFO] [stdout] 278 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - return false; [INFO] [stdout] 278 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return false; [INFO] [stdout] 295 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:305:5 [INFO] [stdout] | [INFO] [stdout] 305 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 305 - return false; [INFO] [stdout] 305 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return true; [INFO] [stdout] 373 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:375:9 [INFO] [stdout] | [INFO] [stdout] 375 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 375 - return false; [INFO] [stdout] 375 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:353:50 [INFO] [stdout] | [INFO] [stdout] 353 | if (nmbr[j] == 1) && (nmbr[j + 13] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 354 | | pair = true; [INFO] [stdout] 355 | | } else if (nmbr[j] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:355:57 [INFO] [stdout] | [INFO] [stdout] 355 | } else if (nmbr[j] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 356 | | pair = true; [INFO] [stdout] 357 | | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:355:57 [INFO] [stdout] | [INFO] [stdout] 355 | } else if (nmbr[j] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 356 | | pair = true; [INFO] [stdout] 357 | | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:357:57 [INFO] [stdout] | [INFO] [stdout] 357 | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 358 | | pair = true; [INFO] [stdout] 359 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:357:57 [INFO] [stdout] | [INFO] [stdout] 357 | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 358 | | pair = true; [INFO] [stdout] 359 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:359:62 [INFO] [stdout] | [INFO] [stdout] 359 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 360 | | pair = true; [INFO] [stdout] 361 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:359:62 [INFO] [stdout] | [INFO] [stdout] 359 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 360 | | pair = true; [INFO] [stdout] 361 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:361:62 [INFO] [stdout] | [INFO] [stdout] 361 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 362 | | pair = true; [INFO] [stdout] 363 | | } else if (nmbr[j + 26] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:361:62 [INFO] [stdout] | [INFO] [stdout] 361 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 362 | | pair = true; [INFO] [stdout] 363 | | } else if (nmbr[j + 26] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:363:62 [INFO] [stdout] | [INFO] [stdout] 363 | } else if (nmbr[j + 26] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 364 | | pair = true; [INFO] [stdout] 365 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game.rs:372:5 [INFO] [stdout] | [INFO] [stdout] 372 | / if trio && pair { [INFO] [stdout] 373 | | return true; [INFO] [stdout] 374 | | } else { [INFO] [stdout] 375 | | return false; [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `return trio && pair` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 394 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return false; [INFO] [stdout] 394 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:439:5 [INFO] [stdout] | [INFO] [stdout] 439 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - return false; [INFO] [stdout] 439 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `nmbr` [INFO] [stdout] --> src/game.rs:403:14 [INFO] [stdout] | [INFO] [stdout] 403 | for j in 0..52 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 403 - for j in 0..52 { [INFO] [stdout] 403 + for (j, ) in nmbr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `array` [INFO] [stdout] --> src/game.rs:409:14 [INFO] [stdout] | [INFO] [stdout] 409 | for k in 0..5 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 409 - for k in 0..5 { [INFO] [stdout] 409 + for in &mut array { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/game.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | array[k] = array[k] % 13; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array[k] %= 13` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/deck.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 37 | let hand = TDeck { cards: Vec::new() }; [INFO] [stdout] | --------------------------------------- unnecessary `let` binding [INFO] [stdout] 38 | hand [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ TDeck { cards: Vec::new() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:445:12 [INFO] [stdout] | [INFO] [stdout] 445 | if ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1)) [INFO] [stdout] | ____________^ [INFO] [stdout] 446 | | || ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 445 - if ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1)) [INFO] [stdout] 446 - || ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1)) [INFO] [stdout] 445 + if !(nmbr[i] != 1 || nmbr[i + 13] != 1 || nmbr[i + 26] != 1 && nmbr[i + 39] != 1) [INFO] [stdout] | [INFO] [stdout] 445 - if ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1)) [INFO] [stdout] 446 - || ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1)) [INFO] [stdout] 445 + if ((nmbr[i + 39] == 1) || (nmbr[i + 26] == 1)) && (nmbr[i + 13] == 1) && (nmbr[i] == 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:453:5 [INFO] [stdout] | [INFO] [stdout] 453 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return false; [INFO] [stdout] 453 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:476:9 [INFO] [stdout] | [INFO] [stdout] 476 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 476 - return true; [INFO] [stdout] 476 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:478:9 [INFO] [stdout] | [INFO] [stdout] 478 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 478 - return false; [INFO] [stdout] 478 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:461:50 [INFO] [stdout] | [INFO] [stdout] 461 | if (nmbr[i] == 1) && (nmbr[i + 13] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 462 | | count += 1; [INFO] [stdout] 463 | | } else if (nmbr[i] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:463:57 [INFO] [stdout] | [INFO] [stdout] 463 | } else if (nmbr[i] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 464 | | count += 1; [INFO] [stdout] 465 | | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:463:57 [INFO] [stdout] | [INFO] [stdout] 463 | } else if (nmbr[i] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 464 | | count += 1; [INFO] [stdout] 465 | | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:465:57 [INFO] [stdout] | [INFO] [stdout] 465 | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 466 | | count += 1; [INFO] [stdout] 467 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:465:57 [INFO] [stdout] | [INFO] [stdout] 465 | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 466 | | count += 1; [INFO] [stdout] 467 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:467:62 [INFO] [stdout] | [INFO] [stdout] 467 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 468 | | count += 1; [INFO] [stdout] 469 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:467:62 [INFO] [stdout] | [INFO] [stdout] 467 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 468 | | count += 1; [INFO] [stdout] 469 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:469:62 [INFO] [stdout] | [INFO] [stdout] 469 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 470 | | count += 1; [INFO] [stdout] 471 | | } else if (nmbr[i + 26] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:469:62 [INFO] [stdout] | [INFO] [stdout] 469 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 470 | | count += 1; [INFO] [stdout] 471 | | } else if (nmbr[i + 26] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:471:62 [INFO] [stdout] | [INFO] [stdout] 471 | } else if (nmbr[i + 26] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 472 | | count += 1; [INFO] [stdout] 473 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game.rs:475:5 [INFO] [stdout] | [INFO] [stdout] 475 | / if count == 2 { [INFO] [stdout] 476 | | return true; [INFO] [stdout] 477 | | } else { [INFO] [stdout] 478 | | return false; [INFO] [stdout] 479 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `return count == 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return true; [INFO] [stdout] 485 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 487 - return true; [INFO] [stdout] 487 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/game.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 59 | if self.deck.cards.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.deck.cards.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:489:9 [INFO] [stdout] | [INFO] [stdout] 489 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 489 - return true; [INFO] [stdout] 489 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 491 - return true; [INFO] [stdout] 491 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 493 - return true; [INFO] [stdout] 493 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 495 - return true; [INFO] [stdout] 495 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 497 - return false; [INFO] [stdout] 497 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | return self.flag3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 227 - return self.flag3; [INFO] [stdout] 227 + self.flag3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:484:42 [INFO] [stdout] | [INFO] [stdout] 484 | if (nmbr[0] == 1) && (nmbr[13] == 1) { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 485 | | return true; [INFO] [stdout] 486 | | } else if (nmbr[0] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:486:49 [INFO] [stdout] | [INFO] [stdout] 486 | } else if (nmbr[0] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 487 | | return true; [INFO] [stdout] 488 | | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:486:49 [INFO] [stdout] | [INFO] [stdout] 486 | } else if (nmbr[0] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 487 | | return true; [INFO] [stdout] 488 | | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:488:49 [INFO] [stdout] | [INFO] [stdout] 488 | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 489 | | return true; [INFO] [stdout] 490 | | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:488:49 [INFO] [stdout] | [INFO] [stdout] 488 | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 489 | | return true; [INFO] [stdout] 490 | | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:490:50 [INFO] [stdout] | [INFO] [stdout] 490 | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 491 | | return true; [INFO] [stdout] 492 | | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:490:50 [INFO] [stdout] | [INFO] [stdout] 490 | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 491 | | return true; [INFO] [stdout] 492 | | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:492:50 [INFO] [stdout] | [INFO] [stdout] 492 | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 493 | | return true; [INFO] [stdout] 494 | | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:492:50 [INFO] [stdout] | [INFO] [stdout] 492 | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 493 | | return true; [INFO] [stdout] 494 | | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:494:50 [INFO] [stdout] | [INFO] [stdout] 494 | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 495 | | return true; [INFO] [stdout] 496 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game.rs:494:12 [INFO] [stdout] | [INFO] [stdout] 494 | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | ____________^ [INFO] [stdout] 495 | | return true; [INFO] [stdout] 496 | | } else { [INFO] [stdout] 497 | | return false; [INFO] [stdout] 498 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `{ return (nmbr[26] == 1) && (nmbr[39] == 1) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 87 | self.game.panel.credits = self.game.panel.credits - (10 - self.game.panel.bets); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.credits -= (10 - self.game.panel.bets)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | return 1; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 232 - return 1; [INFO] [stdout] 232 + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:235:13 [INFO] [stdout] | [INFO] [stdout] 235 | return 2; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 235 - return 2; [INFO] [stdout] 235 + 2 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return 3; [INFO] [stdout] 238 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | return 4; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return 4; [INFO] [stdout] 241 + 4 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | self.game.panel.credits = self.game.panel.credits + self.game.panel.wins; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.credits += self.game.panel.wins` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 - return 0; [INFO] [stdout] 243 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | self.game.panel.wins = 2 * self.game.panel.wins; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.wins *= 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | self.game.panel.wins = 2 * self.game.panel.wins; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.wins *= 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:278:5 [INFO] [stdout] | [INFO] [stdout] 278 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 278 - return false; [INFO] [stdout] 278 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:295:5 [INFO] [stdout] | [INFO] [stdout] 295 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 295 - return false; [INFO] [stdout] 295 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:305:5 [INFO] [stdout] | [INFO] [stdout] 305 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 305 - return false; [INFO] [stdout] 305 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return true; [INFO] [stdout] 373 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:375:9 [INFO] [stdout] | [INFO] [stdout] 375 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 375 - return false; [INFO] [stdout] 375 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:353:50 [INFO] [stdout] | [INFO] [stdout] 353 | if (nmbr[j] == 1) && (nmbr[j + 13] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 354 | | pair = true; [INFO] [stdout] 355 | | } else if (nmbr[j] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:355:57 [INFO] [stdout] | [INFO] [stdout] 355 | } else if (nmbr[j] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 356 | | pair = true; [INFO] [stdout] 357 | | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:355:57 [INFO] [stdout] | [INFO] [stdout] 355 | } else if (nmbr[j] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 356 | | pair = true; [INFO] [stdout] 357 | | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:357:57 [INFO] [stdout] | [INFO] [stdout] 357 | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 358 | | pair = true; [INFO] [stdout] 359 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:357:57 [INFO] [stdout] | [INFO] [stdout] 357 | } else if (nmbr[j] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 358 | | pair = true; [INFO] [stdout] 359 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:359:62 [INFO] [stdout] | [INFO] [stdout] 359 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 360 | | pair = true; [INFO] [stdout] 361 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:359:62 [INFO] [stdout] | [INFO] [stdout] 359 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 360 | | pair = true; [INFO] [stdout] 361 | | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:361:62 [INFO] [stdout] | [INFO] [stdout] 361 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 362 | | pair = true; [INFO] [stdout] 363 | | } else if (nmbr[j + 26] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:361:62 [INFO] [stdout] | [INFO] [stdout] 361 | } else if (nmbr[j + 13] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 362 | | pair = true; [INFO] [stdout] 363 | | } else if (nmbr[j + 26] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:363:62 [INFO] [stdout] | [INFO] [stdout] 363 | } else if (nmbr[j + 26] == 1) && (nmbr[j + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 364 | | pair = true; [INFO] [stdout] 365 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game.rs:372:5 [INFO] [stdout] | [INFO] [stdout] 372 | / if trio && pair { [INFO] [stdout] 373 | | return true; [INFO] [stdout] 374 | | } else { [INFO] [stdout] 375 | | return false; [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `return trio && pair` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:394:5 [INFO] [stdout] | [INFO] [stdout] 394 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return false; [INFO] [stdout] 394 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:439:5 [INFO] [stdout] | [INFO] [stdout] 439 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 - return false; [INFO] [stdout] 439 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `nmbr` [INFO] [stdout] --> src/game.rs:403:14 [INFO] [stdout] | [INFO] [stdout] 403 | for j in 0..52 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 403 - for j in 0..52 { [INFO] [stdout] 403 + for (j, ) in nmbr.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is only used to index `array` [INFO] [stdout] --> src/game.rs:409:14 [INFO] [stdout] | [INFO] [stdout] 409 | for k in 0..5 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 409 - for k in 0..5 { [INFO] [stdout] 409 + for in &mut array { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/game.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 410 | array[k] = array[k] % 13; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `array[k] %= 13` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:445:12 [INFO] [stdout] | [INFO] [stdout] 445 | if ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1)) [INFO] [stdout] | ____________^ [INFO] [stdout] 446 | | || ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 445 - if ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1)) [INFO] [stdout] 446 - || ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1)) [INFO] [stdout] 445 + if !(nmbr[i] != 1 || nmbr[i + 13] != 1 || nmbr[i + 26] != 1 && nmbr[i + 39] != 1) [INFO] [stdout] | [INFO] [stdout] 445 - if ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1)) [INFO] [stdout] 446 - || ((nmbr[i] == 1) && (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1)) [INFO] [stdout] 445 + if ((nmbr[i + 39] == 1) || (nmbr[i + 26] == 1)) && (nmbr[i + 13] == 1) && (nmbr[i] == 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:453:5 [INFO] [stdout] | [INFO] [stdout] 453 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return false; [INFO] [stdout] 453 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:476:9 [INFO] [stdout] | [INFO] [stdout] 476 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 476 - return true; [INFO] [stdout] 476 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:478:9 [INFO] [stdout] | [INFO] [stdout] 478 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 478 - return false; [INFO] [stdout] 478 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:461:50 [INFO] [stdout] | [INFO] [stdout] 461 | if (nmbr[i] == 1) && (nmbr[i + 13] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 462 | | count += 1; [INFO] [stdout] 463 | | } else if (nmbr[i] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:463:57 [INFO] [stdout] | [INFO] [stdout] 463 | } else if (nmbr[i] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 464 | | count += 1; [INFO] [stdout] 465 | | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:463:57 [INFO] [stdout] | [INFO] [stdout] 463 | } else if (nmbr[i] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 464 | | count += 1; [INFO] [stdout] 465 | | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:465:57 [INFO] [stdout] | [INFO] [stdout] 465 | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 466 | | count += 1; [INFO] [stdout] 467 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 42.32s [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:465:57 [INFO] [stdout] | [INFO] [stdout] 465 | } else if (nmbr[i] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | _________________________________________________________^ [INFO] [stdout] 466 | | count += 1; [INFO] [stdout] 467 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:467:62 [INFO] [stdout] | [INFO] [stdout] 467 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 468 | | count += 1; [INFO] [stdout] 469 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:467:62 [INFO] [stdout] | [INFO] [stdout] 467 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 26] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 468 | | count += 1; [INFO] [stdout] 469 | | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:469:62 [INFO] [stdout] | [INFO] [stdout] 469 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 470 | | count += 1; [INFO] [stdout] 471 | | } else if (nmbr[i + 26] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:469:62 [INFO] [stdout] | [INFO] [stdout] 469 | } else if (nmbr[i + 13] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 470 | | count += 1; [INFO] [stdout] 471 | | } else if (nmbr[i + 26] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:471:62 [INFO] [stdout] | [INFO] [stdout] 471 | } else if (nmbr[i + 26] == 1) && (nmbr[i + 39] == 1) { [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 472 | | count += 1; [INFO] [stdout] 473 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game.rs:475:5 [INFO] [stdout] | [INFO] [stdout] 475 | / if count == 2 { [INFO] [stdout] 476 | | return true; [INFO] [stdout] 477 | | } else { [INFO] [stdout] 478 | | return false; [INFO] [stdout] 479 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `return count == 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return true; [INFO] [stdout] 485 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:487:9 [INFO] [stdout] | [INFO] [stdout] 487 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 487 - return true; [INFO] [stdout] 487 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:489:9 [INFO] [stdout] | [INFO] [stdout] 489 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 489 - return true; [INFO] [stdout] 489 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 491 - return true; [INFO] [stdout] 491 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 493 - return true; [INFO] [stdout] 493 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:495:9 [INFO] [stdout] | [INFO] [stdout] 495 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 495 - return true; [INFO] [stdout] 495 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 497 - return false; [INFO] [stdout] 497 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:484:42 [INFO] [stdout] | [INFO] [stdout] 484 | if (nmbr[0] == 1) && (nmbr[13] == 1) { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 485 | | return true; [INFO] [stdout] 486 | | } else if (nmbr[0] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:486:49 [INFO] [stdout] | [INFO] [stdout] 486 | } else if (nmbr[0] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 487 | | return true; [INFO] [stdout] 488 | | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:486:49 [INFO] [stdout] | [INFO] [stdout] 486 | } else if (nmbr[0] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 487 | | return true; [INFO] [stdout] 488 | | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:488:49 [INFO] [stdout] | [INFO] [stdout] 488 | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 489 | | return true; [INFO] [stdout] 490 | | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:488:49 [INFO] [stdout] | [INFO] [stdout] 488 | } else if (nmbr[0] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 489 | | return true; [INFO] [stdout] 490 | | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:490:50 [INFO] [stdout] | [INFO] [stdout] 490 | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 491 | | return true; [INFO] [stdout] 492 | | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:490:50 [INFO] [stdout] | [INFO] [stdout] 490 | } else if (nmbr[13] == 1) && (nmbr[26] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 491 | | return true; [INFO] [stdout] 492 | | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:492:50 [INFO] [stdout] | [INFO] [stdout] 492 | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 493 | | return true; [INFO] [stdout] 494 | | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/game.rs:492:50 [INFO] [stdout] | [INFO] [stdout] 492 | } else if (nmbr[13] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 493 | | return true; [INFO] [stdout] 494 | | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/game.rs:494:50 [INFO] [stdout] | [INFO] [stdout] 494 | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 495 | | return true; [INFO] [stdout] 496 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/game.rs:494:12 [INFO] [stdout] | [INFO] [stdout] 494 | } else if (nmbr[26] == 1) && (nmbr[39] == 1) { [INFO] [stdout] | ____________^ [INFO] [stdout] 495 | | return true; [INFO] [stdout] 496 | | } else { [INFO] [stdout] 497 | | return false; [INFO] [stdout] 498 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `{ return (nmbr[26] == 1) && (nmbr[39] == 1) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 87 | self.game.panel.credits = self.game.panel.credits - (10 - self.game.panel.bets); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.credits -= (10 - self.game.panel.bets)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | self.game.panel.credits = self.game.panel.credits + self.game.panel.wins; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.credits += self.game.panel.wins` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | self.game.panel.wins = 2 * self.game.panel.wins; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.wins *= 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/table.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | self.game.panel.wins = 2 * self.game.panel.wins; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.game.panel.wins *= 2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "4b4da22cfeb80b7a250a80bf99b629915d3c88e0f43c0b86148ec612ba280ab5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b4da22cfeb80b7a250a80bf99b629915d3c88e0f43c0b86148ec612ba280ab5", kill_on_drop: false }` [INFO] [stdout] 4b4da22cfeb80b7a250a80bf99b629915d3c88e0f43c0b86148ec612ba280ab5