[INFO] cloning repository https://github.com/cbbowen/weakkey [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cbbowen/weakkey" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcbbowen%2Fweakkey", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcbbowen%2Fweakkey'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 45d8c324f5f59b95e32beb5c0296eb027bb4518d [INFO] linting cbbowen/weakkey against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcbbowen%2Fweakkey" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/cbbowen/weakkey [INFO] finished tweaking git repo https://github.com/cbbowen/weakkey [INFO] tweaked toml for git repo https://github.com/cbbowen/weakkey written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/cbbowen/weakkey on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/cbbowen/weakkey already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 47466c7c2c933d0999bffaf0b58d7f7157ce24a3f558aa930d2a99db8a5b05f8 [INFO] running `Command { std: "docker" "start" "-a" "47466c7c2c933d0999bffaf0b58d7f7157ce24a3f558aa930d2a99db8a5b05f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "47466c7c2c933d0999bffaf0b58d7f7157ce24a3f558aa930d2a99db8a5b05f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47466c7c2c933d0999bffaf0b58d7f7157ce24a3f558aa930d2a99db8a5b05f8", kill_on_drop: false }` [INFO] [stdout] 47466c7c2c933d0999bffaf0b58d7f7157ce24a3f558aa930d2a99db8a5b05f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3caeef1519e93412df58835ebc7b7792f208bdb04c5f66745b75fece03fa7469 [INFO] running `Command { std: "docker" "start" "-a" "3caeef1519e93412df58835ebc7b7792f208bdb04c5f66745b75fece03fa7469", kill_on_drop: false }` [INFO] [stderr] Checking weakkey v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/rc.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod rc; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking proptest v1.9.0 [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/rc.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod rc; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/rc/rc.rs:48:35 [INFO] [stdout] | [INFO] [stdout] 48 | self.writes.push(bytes.iter().cloned().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/rc/rc.rs:63:35 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(Rc::as_ptr(&key.inner()), Rc::as_ptr(&w)); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `key.inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rc/rc.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | assert!(!(ka < ka)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(ka >= ka)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rc/rc.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | assert!(!(kb < kb)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(kb >= kb)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/rc/weak.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 67 | self.writes.push(bytes.iter().cloned().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rc/weak.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | assert!(!(ka < ka)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(ka >= ka)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rc/weak.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 126 | assert!(!(kb < kb)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(kb >= kb)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/sync/arc.rs:48:35 [INFO] [stdout] | [INFO] [stdout] 48 | self.writes.push(bytes.iter().cloned().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sync/arc.rs:63:36 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(Arc::as_ptr(&key.inner()), Arc::as_ptr(&w)); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `key.inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sync/arc.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | assert!(!(ka < ka)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(ka >= ka)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sync/arc.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | assert!(!(kb < kb)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(kb >= kb)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/sync/weak.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 67 | self.writes.push(bytes.iter().cloned().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sync/weak.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | assert!(!(ka < ka)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(ka >= ka)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sync/weak.rs:126:21 [INFO] [stdout] | [INFO] [stdout] 126 | assert!(!(kb < kb)); [INFO] [stdout] | ^^^^^^^^^^ help: try: `(kb >= kb)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.92s [INFO] running `Command { std: "docker" "inspect" "3caeef1519e93412df58835ebc7b7792f208bdb04c5f66745b75fece03fa7469", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3caeef1519e93412df58835ebc7b7792f208bdb04c5f66745b75fece03fa7469", kill_on_drop: false }` [INFO] [stdout] 3caeef1519e93412df58835ebc7b7792f208bdb04c5f66745b75fece03fa7469