[INFO] cloning repository https://github.com/catalincatuna/git_imp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/catalincatuna/git_imp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcatalincatuna%2Fgit_imp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcatalincatuna%2Fgit_imp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b833738ff8e131c9d0c27dc4e45fcf3915891221 [INFO] linting catalincatuna/git_imp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcatalincatuna%2Fgit_imp" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/catalincatuna/git_imp [INFO] finished tweaking git repo https://github.com/catalincatuna/git_imp [INFO] tweaked toml for git repo https://github.com/catalincatuna/git_imp written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/catalincatuna/git_imp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/catalincatuna/git_imp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded parking_lot_core v0.9.6 [INFO] [stderr] Downloaded is-terminal v0.4.2 [INFO] [stderr] Downloaded native-tls v0.2.10 [INFO] [stderr] Downloaded ascii85 v0.2.1 [INFO] [stderr] Downloaded openssl-sys v0.9.75 [INFO] [stderr] Downloaded reqwest v0.11.13 [INFO] [stderr] Downloaded rustix v0.36.6 [INFO] [stderr] Downloaded clap v4.0.32 [INFO] [stderr] Downloaded openssl v0.10.41 [INFO] [stderr] Downloaded tokio v1.24.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b88fa543e05a30b2ee182c5a7bd77536488847fc5ec19bd90fa88bfd16b20d8 [INFO] running `Command { std: "docker" "start" "-a" "8b88fa543e05a30b2ee182c5a7bd77536488847fc5ec19bd90fa88bfd16b20d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b88fa543e05a30b2ee182c5a7bd77536488847fc5ec19bd90fa88bfd16b20d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b88fa543e05a30b2ee182c5a7bd77536488847fc5ec19bd90fa88bfd16b20d8", kill_on_drop: false }` [INFO] [stdout] 8b88fa543e05a30b2ee182c5a7bd77536488847fc5ec19bd90fa88bfd16b20d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 808efab1be5a0ee46100cffe991d606502f97a9f633d3e364109f2d9f029e4be [INFO] running `Command { std: "docker" "start" "-a" "808efab1be5a0ee46100cffe991d606502f97a9f633d3e364109f2d9f029e4be", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling parking_lot_core v0.9.6 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling tokio v1.24.1 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Compiling io-lifetimes v1.0.3 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling rustix v0.36.6 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Compiling anyhow v1.0.59 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking os_str_bytes v6.4.1 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking ipnet v2.5.0 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking ascii85 v0.2.1 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking is-terminal v0.4.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling clap_derive v4.0.21 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking clap v4.0.32 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.15 [INFO] [stderr] Checking hyper v0.14.23 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.13 [INFO] [stderr] Checking git-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `anyhow::Context` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::Context; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::write::ZlibEncoder` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use flate2::write::ZlibEncoder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::Compression` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use flate2::Compression; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Digest` and `Sha1` [INFO] [stdout] --> src/main.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use sha1::{Digest, Sha1}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ffi::CStr` and `io::BufReader` [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | use std::{ffi::CStr, io::BufReader}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::hash` [INFO] [stdout] --> src/git_functions.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use core::hash; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/git_functions.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::Metadata` [INFO] [stdout] --> src/git_functions.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::fs::Metadata; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `walkdir::WalkDir` [INFO] [stdout] --> src/git_functions.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use walkdir::WalkDir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ascii85::encode` [INFO] [stdout] --> src/utils.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use ascii85::encode; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/utils.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use base64; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `base64` [INFO] [stdout] --> src/utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use base64; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/utils.rs:8:27 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{prelude::*, Cursor}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `anyhow::Context` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use anyhow::Context; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::write::ZlibEncoder` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use flate2::write::ZlibEncoder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::Compression` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use flate2::Compression; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Digest` and `Sha1` [INFO] [stdout] --> src/main.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | use sha1::{Digest, Sha1}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ffi::CStr` and `io::BufReader` [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | use std::{ffi::CStr, io::BufReader}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::hash` [INFO] [stdout] --> src/git_functions.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use core::hash; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::format` [INFO] [stdout] --> src/git_functions.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::fmt::format; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::Metadata` [INFO] [stdout] --> src/git_functions.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::fs::Metadata; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `walkdir::WalkDir` [INFO] [stdout] --> src/git_functions.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use walkdir::WalkDir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ascii85::encode` [INFO] [stdout] --> src/utils.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use ascii85::encode; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/utils.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use base64; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `base64` [INFO] [stdout] --> src/utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use base64; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/utils.rs:8:27 [INFO] [stdout] | [INFO] [stdout] 8 | use std::io::{prelude::*, Cursor}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::Object` [INFO] [stdout] --> src/git_functions.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | use crate::data::Object; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::Object` [INFO] [stdout] --> src/git_functions.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | use crate::data::Object; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `data::Command` [INFO] [stdout] --> src/main.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | use data::Command; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/utils.rs` [INFO] [stdout] --> src/main.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | mod utils; [INFO] [stdout] | ^^^^^^^^^^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/git_functions.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / #[path = "utils.rs"] [INFO] [stdout] 20 | | mod utils; [INFO] [stdout] | |__________^ first loaded here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] = note: `#[warn(clippy::duplicate_mod)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/utils.rs` [INFO] [stdout] --> src/main.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | mod utils; [INFO] [stdout] | ^^^^^^^^^^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/git_functions.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / #[path = "utils.rs"] [INFO] [stdout] 20 | | mod utils; [INFO] [stdout] | |__________^ first loaded here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] = note: `#[warn(clippy::duplicate_mod)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/git_functions.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | _ => { [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/git_functions.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 28 | Command::Init => { [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 35 | / Command::CatFile { [INFO] [stdout] 36 | | pretty_print, [INFO] [stdout] 37 | | object_hash, [INFO] [stdout] 38 | | } => { [INFO] [stdout] | |_________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 78 | / Command::HashObject { [INFO] [stdout] 79 | | write_object, [INFO] [stdout] 80 | | object_file, [INFO] [stdout] 81 | | } => { [INFO] [stdout] | |_________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 121 | / Command::LsTree { [INFO] [stdout] 122 | | name_only, [INFO] [stdout] 123 | | tree_sha, [INFO] [stdout] 124 | | } => { [INFO] [stdout] | |_________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 209 | _ => { [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/git_functions.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buf_copy = buf.clone(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/git_functions.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | let mut header = header.to_str().unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pretty_print` [INFO] [stdout] --> src/git_functions.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | pretty_print, [INFO] [stdout] | ^^^^^^^^^^^^ help: try ignoring the field: `pretty_print: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `write_object` [INFO] [stdout] --> src/git_functions.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | write_object, [INFO] [stdout] | ^^^^^^^^^^^^ help: try ignoring the field: `write_object: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_content` [INFO] [stdout] --> src/git_functions.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | let file_content = &hex_result[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_content` [INFO] [stdout] --> src/git_functions.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | let file_content = &hex_result[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_only` [INFO] [stdout] --> src/git_functions.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | name_only, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `name_only: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buf_copy` [INFO] [stdout] --> src/git_functions.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buf_copy = buf.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_buf_copy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/git_functions.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | _ => { [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/git_functions.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 28 | Command::Init => { [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 35 | / Command::CatFile { [INFO] [stdout] 36 | | pretty_print, [INFO] [stdout] 37 | | object_hash, [INFO] [stdout] 38 | | } => { [INFO] [stdout] | |_________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 78 | / Command::HashObject { [INFO] [stdout] 79 | | write_object, [INFO] [stdout] 80 | | object_file, [INFO] [stdout] 81 | | } => { [INFO] [stdout] | |_________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 121 | / Command::LsTree { [INFO] [stdout] 122 | | name_only, [INFO] [stdout] 123 | | tree_sha, [INFO] [stdout] 124 | | } => { [INFO] [stdout] | |_________- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 209 | _ => { [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/git_functions.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buf_copy = buf.clone(); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/git_functions.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | let mut header = header.to_str().unwrap(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pretty_print` [INFO] [stdout] --> src/git_functions.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | pretty_print, [INFO] [stdout] | ^^^^^^^^^^^^ help: try ignoring the field: `pretty_print: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `write_object` [INFO] [stdout] --> src/git_functions.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | write_object, [INFO] [stdout] | ^^^^^^^^^^^^ help: try ignoring the field: `write_object: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_content` [INFO] [stdout] --> src/git_functions.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | let file_content = &hex_result[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_content` [INFO] [stdout] --> src/git_functions.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | let file_content = &hex_result[2..]; [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_content` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name_only` [INFO] [stdout] --> src/git_functions.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | name_only, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `name_only: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buf_copy` [INFO] [stdout] --> src/git_functions.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | let mut buf_copy = buf.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_buf_copy` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_filename` is never used [INFO] [stdout] --> src/utils.rs:295:8 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn extract_filename(input: String) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_total_size` is never used [INFO] [stdout] --> src/utils.rs:307:8 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn calculate_total_size(obj: &Object) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_after_numeric` is never used [INFO] [stdout] --> src/utils.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn extract_after_numeric(input: String, patterns: &[&str]) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_file_hash` is never used [INFO] [stdout] --> src/utils.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn compute_file_hash(path: &PathBuf) -> anyhow::Result<[u8; 20], Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `process_directory` is never used [INFO] [stdout] --> src/utils.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn process_directory(dir: &PathBuf) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Object` is never constructed [INFO] [stdout] --> src/data.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Object { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `serialize` and `display` are never used [INFO] [stdout] --> src/data.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Object { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] 19 | // Serialize [INFO] [stdout] 20 | pub fn serialize(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn display(&self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/utils.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | use std::{fs, usize}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:45:44 [INFO] [stdout] | [INFO] [stdout] 45 | let contents = std::fs::read_to_string(&path).unwrap_or(' '.to_string()); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/utils.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(entry) = dir.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for entry in dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_filename` is never used [INFO] [stdout] --> src/utils.rs:295:8 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn extract_filename(input: String) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `calculate_total_size` is never used [INFO] [stdout] --> src/utils.rs:307:8 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn calculate_total_size(obj: &Object) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_after_numeric` is never used [INFO] [stdout] --> src/utils.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn extract_after_numeric(input: String, patterns: &[&str]) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_file_hash` is never used [INFO] [stdout] --> src/utils.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn compute_file_hash(path: &PathBuf) -> anyhow::Result<[u8; 20], Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `process_directory` is never used [INFO] [stdout] --> src/utils.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn process_directory(dir: &PathBuf) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Object` is never constructed [INFO] [stdout] --> src/data.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Object { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `serialize` and `display` are never used [INFO] [stdout] --> src/data.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl Object { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] 19 | // Serialize [INFO] [stdout] 20 | pub fn serialize(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn display(&self) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/git_functions.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/utils.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | use std::{fs, usize}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:45:44 [INFO] [stdout] | [INFO] [stdout] 45 | let contents = std::fs::read_to_string(&path).unwrap_or(' '.to_string()); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/git_functions.rs:82:43 [INFO] [stdout] | [INFO] [stdout] 82 | let file_path = PathBuf::from(format!("{}", object_file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `object_file.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git_functions.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 105 | e.write_all(&blob.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `blob.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/utils.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(entry) = dir.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for entry in dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/git_functions.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if !fs::metadata(&path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/git_functions.rs:82:43 [INFO] [stdout] | [INFO] [stdout] 82 | let file_path = PathBuf::from(format!("{}", object_file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `object_file.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/git_functions.rs:105:25 [INFO] [stdout] | [INFO] [stdout] 105 | e.write_all(&blob.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `blob.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | data.extend_from_slice(&self.mode.as_bytes()); // Add field1 as bytes [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.mode.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/data.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | data.extend_from_slice(&self.mode.as_bytes()); // Add field1 as bytes [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.mode.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | let result = git_functions::execute_git_function(Command::Init).unwrap_or(()); // Now `add` is accessible [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 47 ~ git_functions::execute_git_function(Command::Init).unwrap_or(()); // Now `add` is accessible [INFO] [stdout] 48 ~ assert_eq!((), ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/git_functions.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 138 | / z.read_until(0, &mut buf) [INFO] [stdout] 139 | | .context("read header from .git/objects"); [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 138 | let _ = z.read_until(0, &mut buf) [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/git_functions.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 138 | / z.read_until(0, &mut buf) [INFO] [stdout] 139 | | .context("read header from .git/objects"); [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 138 | let _ = z.read_until(0, &mut buf) [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.65s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "808efab1be5a0ee46100cffe991d606502f97a9f633d3e364109f2d9f029e4be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "808efab1be5a0ee46100cffe991d606502f97a9f633d3e364109f2d9f029e4be", kill_on_drop: false }` [INFO] [stdout] 808efab1be5a0ee46100cffe991d606502f97a9f633d3e364109f2d9f029e4be