[INFO] cloning repository https://github.com/carter-thaxton/lox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/carter-thaxton/lox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarter-thaxton%2Flox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarter-thaxton%2Flox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 72c8c8907168f05528cd728451641cd28e56ca43 [INFO] linting carter-thaxton/lox against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcarter-thaxton%2Flox" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/carter-thaxton/lox [INFO] finished tweaking git repo https://github.com/carter-thaxton/lox [INFO] tweaked toml for git repo https://github.com/carter-thaxton/lox written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/carter-thaxton/lox on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/carter-thaxton/lox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9f2d8a23aceda25bb8f4602378947b205c86a548002a85819029e4c698152ba [INFO] running `Command { std: "docker" "start" "-a" "b9f2d8a23aceda25bb8f4602378947b205c86a548002a85819029e4c698152ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9f2d8a23aceda25bb8f4602378947b205c86a548002a85819029e4c698152ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9f2d8a23aceda25bb8f4602378947b205c86a548002a85819029e4c698152ba", kill_on_drop: false }` [INFO] [stdout] b9f2d8a23aceda25bb8f4602378947b205c86a548002a85819029e4c698152ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e3a0beac6ac04a7d403b01ef5afecb7a3a70d3c12a75b3e76ecd1253c9945aba [INFO] running `Command { std: "docker" "start" "-a" "e3a0beac6ac04a7d403b01ef5afecb7a3a70d3c12a75b3e76ecd1253c9945aba", kill_on_drop: false }` [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking lox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/errors.rs:249:42 [INFO] [stdout] | [INFO] [stdout] 249 | ErrorKind::ParserError(_) => &self.span.as_ref().expect("ParserError should have a span"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.span.as_ref().expect("ParserError should have a span")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/interpreter.rs:179:60 [INFO] [stdout] | [INFO] [stdout] 179 | let args: Result, Error> = args.into_iter().map(|arg| self.evaluate(arg)).collect(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:294:47 [INFO] [stdout] | [INFO] [stdout] 294 | let result = self.execute(&stmt); [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:415:47 [INFO] [stdout] | [INFO] [stdout] 415 | let result = self.execute(&body); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:538:17 [INFO] [stdout] | [INFO] [stdout] 538 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return Ok(()); [INFO] [stdout] 538 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:540:17 [INFO] [stdout] | [INFO] [stdout] 540 | return Err(Error::test_output_mismatch(expected, actual)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return Err(Error::test_output_mismatch(expected, actual)); [INFO] [stdout] 540 + Err(Error::test_output_mismatch(expected, actual)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | return Err(Error::test_output_missing(expected)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 543 - return Err(Error::test_output_missing(expected)); [INFO] [stdout] 543 + Err(Error::test_output_missing(expected)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lexer.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | / match self { [INFO] [stdout] 145 | | TokenKind::ExpectOutput(_) => true, [INFO] [stdout] 146 | | TokenKind::ExpectParserError(_) => true, [INFO] [stdout] 147 | | TokenKind::ExpectRuntimeError(_) => true, [INFO] [stdout] 148 | | _ => false, [INFO] [stdout] 149 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 144 - match self { [INFO] [stdout] 145 - TokenKind::ExpectOutput(_) => true, [INFO] [stdout] 146 - TokenKind::ExpectParserError(_) => true, [INFO] [stdout] 147 - TokenKind::ExpectRuntimeError(_) => true, [INFO] [stdout] 148 - _ => false, [INFO] [stdout] 149 - } [INFO] [stdout] 144 + matches!(self, TokenKind::ExpectOutput(_) | TokenKind::ExpectParserError(_) | TokenKind::ExpectRuntimeError(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:354:29 [INFO] [stdout] | [INFO] [stdout] 354 | if !c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:360:85 [INFO] [stdout] | [INFO] [stdout] 360 | if self.peek() == Some('.') && self.peek_next().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:364:33 [INFO] [stdout] | [INFO] [stdout] 364 | ... if !c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | / return Ok(Stmt::Var { [INFO] [stdout] 141 | | name: name.to_string(), [INFO] [stdout] 142 | | init: Some(expr), [INFO] [stdout] 143 | | line: tok.span.line, [INFO] [stdout] 144 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ Ok(Stmt::Var { [INFO] [stdout] 141 + name: name.to_string(), [INFO] [stdout] 142 + init: Some(expr), [INFO] [stdout] 143 + line: tok.span.line, [INFO] [stdout] 144 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | / return Ok(Stmt::Var { [INFO] [stdout] 148 | | name: name.to_string(), [INFO] [stdout] 149 | | init: None, [INFO] [stdout] 150 | | line: tok.span.line, [INFO] [stdout] 151 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 ~ Ok(Stmt::Var { [INFO] [stdout] 148 + name: name.to_string(), [INFO] [stdout] 149 + init: None, [INFO] [stdout] 150 + line: tok.span.line, [INFO] [stdout] 151 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 168 | if !self.matches(TokenKind::Comma).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches(TokenKind::Comma).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | / return Ok(Stmt::Function { [INFO] [stdout] 185 | | name: name.to_string(), [INFO] [stdout] 186 | | params, [INFO] [stdout] 187 | | body, [INFO] [stdout] 188 | | line, [INFO] [stdout] 189 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 ~ Ok(Stmt::Function { [INFO] [stdout] 185 + name: name.to_string(), [INFO] [stdout] 186 + params, [INFO] [stdout] 187 + body, [INFO] [stdout] 188 + line, [INFO] [stdout] 189 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:349:16 [INFO] [stdout] | [INFO] [stdout] 349 | if !in_loop.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `in_loop.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:224:47 [INFO] [stdout] | [INFO] [stdout] 224 | let else_branch = else_branch.map(|e| Box::new(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Box::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:398:9 [INFO] [stdout] | [INFO] [stdout] 398 | return Err(self.parser_error("Expect '}' after block.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - return Err(self.parser_error("Expect '}' after block.")); [INFO] [stdout] 398 + Err(self.parser_error("Expect '}' after block.")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:594:28 [INFO] [stdout] | [INFO] [stdout] 594 | if !self.matches(TokenKind::Comma).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches(TokenKind::Comma).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:715:20 [INFO] [stdout] | [INFO] [stdout] 715 | if !self.matches(TokenKind::Comma).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches(TokenKind::Comma).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:726:9 [INFO] [stdout] | [INFO] [stdout] 726 | return Ok(Expr::Function { params, body, line }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 726 - return Ok(Expr::Function { params, body, line }); [INFO] [stdout] 726 + Ok(Expr::Function { params, body, line }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser.rs:704:57 [INFO] [stdout] | [INFO] [stdout] 704 | let lparen = self.consume(TokenKind::LeftParen, format!("Expect '(' after fun."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expect '(' after fun.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser.rs:722:44 [INFO] [stdout] | [INFO] [stdout] 722 | self.consume(TokenKind::LeftBrace, format!("Expect '{{' before function body."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expect '{' before function body.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/errors.rs:249:42 [INFO] [stdout] | [INFO] [stdout] 249 | ErrorKind::ParserError(_) => &self.span.as_ref().expect("ParserError should have a span"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.span.as_ref().expect("ParserError should have a span")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:167:60 [INFO] [stdout] | [INFO] [stdout] 167 | Stmt::Function { params, body, .. } => match resolve_function(FunctionKind::Method, params, body, scopes) { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 168 | | Err(err) => { [INFO] [stdout] 169 | | if has_superclass { [INFO] [stdout] 170 | | scopes.pop(); [INFO] [stdout] ... | [INFO] [stdout] 175 | | _ => {} [INFO] [stdout] 176 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 167 ~ Stmt::Function { params, body, .. } => if let Err(err) = resolve_function(FunctionKind::Method, params, body, scopes) { [INFO] [stdout] 168 + if has_superclass { [INFO] [stdout] 169 + scopes.pop(); [INFO] [stdout] 170 + } [INFO] [stdout] 171 + scopes.pop(); [INFO] [stdout] 172 + return Err(err); [INFO] [stdout] 173 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | / match resolve_stmt(stmt, scopes) { [INFO] [stdout] 200 | | Err(err) => { [INFO] [stdout] 201 | | scopes.pop(); [INFO] [stdout] 202 | | return Err(err); [INFO] [stdout] 203 | | } [INFO] [stdout] 204 | | _ => {} [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 199 ~ if let Err(err) = resolve_stmt(stmt, scopes) { [INFO] [stdout] 200 + scopes.pop(); [INFO] [stdout] 201 + return Err(err); [INFO] [stdout] 202 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | / match scopes.declare_and_check(param, *line) { [INFO] [stdout] 336 | | Err(err) => { [INFO] [stdout] 337 | | scopes.pop(); [INFO] [stdout] 338 | | return Err(err); [INFO] [stdout] 339 | | } [INFO] [stdout] 340 | | _ => {} [INFO] [stdout] 341 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 335 ~ if let Err(err) = scopes.declare_and_check(param, *line) { [INFO] [stdout] 336 + scopes.pop(); [INFO] [stdout] 337 + return Err(err); [INFO] [stdout] 338 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 346 | / match resolve_stmt(stmt, scopes) { [INFO] [stdout] 347 | | Err(err) => { [INFO] [stdout] 348 | | scopes.pop(); [INFO] [stdout] 349 | | return Err(err); [INFO] [stdout] 350 | | } [INFO] [stdout] 351 | | _ => {} [INFO] [stdout] 352 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 346 ~ if let Err(err) = resolve_stmt(stmt, scopes) { [INFO] [stdout] 347 + scopes.pop(); [INFO] [stdout] 348 + return Err(err); [INFO] [stdout] 349 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/interpreter.rs:179:60 [INFO] [stdout] | [INFO] [stdout] 179 | let args: Result, Error> = args.into_iter().map(|arg| self.evaluate(arg)).collect(); [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/runtime.rs:79:10 [INFO] [stdout] | [INFO] [stdout] 79 | fcn: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:129:69 [INFO] [stdout] | [INFO] [stdout] 129 | let fcn = Function::new(Some(name.to_string()), ¶ms, &body, *line, is_init, env); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:129:78 [INFO] [stdout] | [INFO] [stdout] 129 | let fcn = Function::new(Some(name.to_string()), ¶ms, &body, *line, is_init, env); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:294:47 [INFO] [stdout] | [INFO] [stdout] 294 | let result = self.execute(&stmt); [INFO] [stdout] | ^^^^^ help: change this to: `stmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/interpreter.rs:415:47 [INFO] [stdout] | [INFO] [stdout] 415 | let result = self.execute(&body); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/runtime.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | / match self { [INFO] [stdout] 312 | | Value::Nil | Value::False => false, [INFO] [stdout] 313 | | _ => true, [INFO] [stdout] 314 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 311 - match self { [INFO] [stdout] 312 - Value::Nil | Value::False => false, [INFO] [stdout] 313 - _ => true, [INFO] [stdout] 314 - } [INFO] [stdout] 311 + !matches!(self, Value::Nil | Value::False) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/runtime.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 318 | / match self { [INFO] [stdout] 319 | | Value::Number(_) => true, [INFO] [stdout] 320 | | _ => false, [INFO] [stdout] 321 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 318 - match self { [INFO] [stdout] 319 - Value::Number(_) => true, [INFO] [stdout] 320 - _ => false, [INFO] [stdout] 321 - } [INFO] [stdout] 318 + matches!(self, Value::Number(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/runtime.rs:324:67 [INFO] [stdout] | [INFO] [stdout] 324 | pub fn builtin_fn(name: impl Into, arity: usize, fcn: Box Result>) -> Value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:538:17 [INFO] [stdout] | [INFO] [stdout] 538 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return Ok(()); [INFO] [stdout] 538 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:540:17 [INFO] [stdout] | [INFO] [stdout] 540 | return Err(Error::test_output_mismatch(expected, actual)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return Err(Error::test_output_mismatch(expected, actual)); [INFO] [stdout] 540 + Err(Error::test_output_mismatch(expected, actual)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/interpreter.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | return Err(Error::test_output_missing(expected)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 543 - return Err(Error::test_output_missing(expected)); [INFO] [stdout] 543 + Err(Error::test_output_missing(expected)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lexer.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | / match self { [INFO] [stdout] 145 | | TokenKind::ExpectOutput(_) => true, [INFO] [stdout] 146 | | TokenKind::ExpectParserError(_) => true, [INFO] [stdout] 147 | | TokenKind::ExpectRuntimeError(_) => true, [INFO] [stdout] 148 | | _ => false, [INFO] [stdout] 149 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 144 - match self { [INFO] [stdout] 145 - TokenKind::ExpectOutput(_) => true, [INFO] [stdout] 146 - TokenKind::ExpectParserError(_) => true, [INFO] [stdout] 147 - TokenKind::ExpectRuntimeError(_) => true, [INFO] [stdout] 148 - _ => false, [INFO] [stdout] 149 - } [INFO] [stdout] 144 + matches!(self, TokenKind::ExpectOutput(_) | TokenKind::ExpectParserError(_) | TokenKind::ExpectRuntimeError(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:354:29 [INFO] [stdout] | [INFO] [stdout] 354 | if !c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:360:85 [INFO] [stdout] | [INFO] [stdout] 360 | if self.peek() == Some('.') && self.peek_next().is_some_and(|c| c.is_digit(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:364:33 [INFO] [stdout] | [INFO] [stdout] 364 | ... if !c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:140:13 [INFO] [stdout] | [INFO] [stdout] 140 | / return Ok(Stmt::Var { [INFO] [stdout] 141 | | name: name.to_string(), [INFO] [stdout] 142 | | init: Some(expr), [INFO] [stdout] 143 | | line: tok.span.line, [INFO] [stdout] 144 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 ~ Ok(Stmt::Var { [INFO] [stdout] 141 + name: name.to_string(), [INFO] [stdout] 142 + init: Some(expr), [INFO] [stdout] 143 + line: tok.span.line, [INFO] [stdout] 144 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | / return Ok(Stmt::Var { [INFO] [stdout] 148 | | name: name.to_string(), [INFO] [stdout] 149 | | init: None, [INFO] [stdout] 150 | | line: tok.span.line, [INFO] [stdout] 151 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 ~ Ok(Stmt::Var { [INFO] [stdout] 148 + name: name.to_string(), [INFO] [stdout] 149 + init: None, [INFO] [stdout] 150 + line: tok.span.line, [INFO] [stdout] 151 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:168:20 [INFO] [stdout] | [INFO] [stdout] 168 | if !self.matches(TokenKind::Comma).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches(TokenKind::Comma).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:184:9 [INFO] [stdout] | [INFO] [stdout] 184 | / return Ok(Stmt::Function { [INFO] [stdout] 185 | | name: name.to_string(), [INFO] [stdout] 186 | | params, [INFO] [stdout] 187 | | body, [INFO] [stdout] 188 | | line, [INFO] [stdout] 189 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 184 ~ Ok(Stmt::Function { [INFO] [stdout] 185 + name: name.to_string(), [INFO] [stdout] 186 + params, [INFO] [stdout] 187 + body, [INFO] [stdout] 188 + line, [INFO] [stdout] 189 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:349:16 [INFO] [stdout] | [INFO] [stdout] 349 | if !in_loop.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `in_loop.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:224:47 [INFO] [stdout] | [INFO] [stdout] 224 | let else_branch = else_branch.map(|e| Box::new(e)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Box::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:398:9 [INFO] [stdout] | [INFO] [stdout] 398 | return Err(self.parser_error("Expect '}' after block.")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 398 - return Err(self.parser_error("Expect '}' after block.")); [INFO] [stdout] 398 + Err(self.parser_error("Expect '}' after block.")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:594:28 [INFO] [stdout] | [INFO] [stdout] 594 | if !self.matches(TokenKind::Comma).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches(TokenKind::Comma).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:715:20 [INFO] [stdout] | [INFO] [stdout] 715 | if !self.matches(TokenKind::Comma).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.matches(TokenKind::Comma).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:726:9 [INFO] [stdout] | [INFO] [stdout] 726 | return Ok(Expr::Function { params, body, line }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 726 - return Ok(Expr::Function { params, body, line }); [INFO] [stdout] 726 + Ok(Expr::Function { params, body, line }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser.rs:704:57 [INFO] [stdout] | [INFO] [stdout] 704 | let lparen = self.consume(TokenKind::LeftParen, format!("Expect '(' after fun."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expect '(' after fun.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser.rs:722:44 [INFO] [stdout] | [INFO] [stdout] 722 | self.consume(TokenKind::LeftBrace, format!("Expect '{{' before function body."))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expect '{' before function body.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:167:60 [INFO] [stdout] | [INFO] [stdout] 167 | Stmt::Function { params, body, .. } => match resolve_function(FunctionKind::Method, params, body, scopes) { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 168 | | Err(err) => { [INFO] [stdout] 169 | | if has_superclass { [INFO] [stdout] 170 | | scopes.pop(); [INFO] [stdout] ... | [INFO] [stdout] 175 | | _ => {} [INFO] [stdout] 176 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 167 ~ Stmt::Function { params, body, .. } => if let Err(err) = resolve_function(FunctionKind::Method, params, body, scopes) { [INFO] [stdout] 168 + if has_superclass { [INFO] [stdout] 169 + scopes.pop(); [INFO] [stdout] 170 + } [INFO] [stdout] 171 + scopes.pop(); [INFO] [stdout] 172 + return Err(err); [INFO] [stdout] 173 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | / match resolve_stmt(stmt, scopes) { [INFO] [stdout] 200 | | Err(err) => { [INFO] [stdout] 201 | | scopes.pop(); [INFO] [stdout] 202 | | return Err(err); [INFO] [stdout] 203 | | } [INFO] [stdout] 204 | | _ => {} [INFO] [stdout] 205 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 199 ~ if let Err(err) = resolve_stmt(stmt, scopes) { [INFO] [stdout] 200 + scopes.pop(); [INFO] [stdout] 201 + return Err(err); [INFO] [stdout] 202 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | / match scopes.declare_and_check(param, *line) { [INFO] [stdout] 336 | | Err(err) => { [INFO] [stdout] 337 | | scopes.pop(); [INFO] [stdout] 338 | | return Err(err); [INFO] [stdout] 339 | | } [INFO] [stdout] 340 | | _ => {} [INFO] [stdout] 341 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 335 ~ if let Err(err) = scopes.declare_and_check(param, *line) { [INFO] [stdout] 336 + scopes.pop(); [INFO] [stdout] 337 + return Err(err); [INFO] [stdout] 338 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/resolver.rs:346:9 [INFO] [stdout] | [INFO] [stdout] 346 | / match resolve_stmt(stmt, scopes) { [INFO] [stdout] 347 | | Err(err) => { [INFO] [stdout] 348 | | scopes.pop(); [INFO] [stdout] 349 | | return Err(err); [INFO] [stdout] 350 | | } [INFO] [stdout] 351 | | _ => {} [INFO] [stdout] 352 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 346 ~ if let Err(err) = resolve_stmt(stmt, scopes) { [INFO] [stdout] 347 + scopes.pop(); [INFO] [stdout] 348 + return Err(err); [INFO] [stdout] 349 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/runtime.rs:79:10 [INFO] [stdout] | [INFO] [stdout] 79 | fcn: Box Result>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:129:69 [INFO] [stdout] | [INFO] [stdout] 129 | let fcn = Function::new(Some(name.to_string()), ¶ms, &body, *line, is_init, env); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/runtime.rs:129:78 [INFO] [stdout] | [INFO] [stdout] 129 | let fcn = Function::new(Some(name.to_string()), ¶ms, &body, *line, is_init, env); [INFO] [stdout] | ^^^^^ help: change this to: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/runtime.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | / match self { [INFO] [stdout] 312 | | Value::Nil | Value::False => false, [INFO] [stdout] 313 | | _ => true, [INFO] [stdout] 314 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 311 - match self { [INFO] [stdout] 312 - Value::Nil | Value::False => false, [INFO] [stdout] 313 - _ => true, [INFO] [stdout] 314 - } [INFO] [stdout] 311 + !matches!(self, Value::Nil | Value::False) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/runtime.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 318 | / match self { [INFO] [stdout] 319 | | Value::Number(_) => true, [INFO] [stdout] 320 | | _ => false, [INFO] [stdout] 321 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 318 - match self { [INFO] [stdout] 319 - Value::Number(_) => true, [INFO] [stdout] 320 - _ => false, [INFO] [stdout] 321 - } [INFO] [stdout] 318 + matches!(self, Value::Number(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/runtime.rs:324:67 [INFO] [stdout] | [INFO] [stdout] 324 | pub fn builtin_fn(name: impl Into, arity: usize, fcn: Box Result>) -> Value { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `Command { std: "docker" "inspect" "e3a0beac6ac04a7d403b01ef5afecb7a3a70d3c12a75b3e76ecd1253c9945aba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3a0beac6ac04a7d403b01ef5afecb7a3a70d3c12a75b3e76ecd1253c9945aba", kill_on_drop: false }` [INFO] [stdout] e3a0beac6ac04a7d403b01ef5afecb7a3a70d3c12a75b3e76ecd1253c9945aba